Timeline
Jun 6, 2009:
- 10:45 PM Changeset in webkit [44488] by
-
- 2 edits in trunk/WebKitTools
Factor out the code to check whether a library contains a given symbol in to a helper function.
Reviewed by Dan Bernstein.
- Scripts/webkitdirs.pm:
- 10:25 PM Changeset in webkit [44487] by
-
- 8 edits in trunk
Detect when XHTML MP and WCSS are disabled and skip their associated regression tests.
Reviewed by Sam Weinig.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
Remove XHTML MP and WCSS tests from the skipped lists as run-webkit-tests
now treats them like our other optional features and will skip them automatically
when the feature is not compiled in.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 8:09 PM Changeset in webkit [44486] by
-
- 2 edits in trunk/LayoutTests
Unskip two more tests that now pass.
- platform/mac-snowleopard/Skipped:
- 6:38 PM Changeset in webkit [44485] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-06 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26175
[GTK] Download progress notification should be throttled, for the benefit of download managers
Throttle notifications for the 'progress' property of the Download
object, and update documentation to note the fact that this is
being done, and how to get all notifications if you really care
about them.
- webkit/webkitdownload.cpp: (webkit_download_class_init): (webkit_download_received_data):
- 6:10 PM Changeset in webkit [44484] by
-
- 2 edits in trunk/LayoutTests
Unskip some tests now that they pass.
- platform/mac-snowleopard/Skipped:
- 6:10 PM Changeset in webkit [44483] by
-
- 4 edits in trunk
<rdar://problem/6778101> Four SSL-related test failures
Reviewed by Brady Eidson.
With newer versions of CFNetwork we receive a NSURLErrorServerCertificateUntrusted error
code rather than the more specific NSURLErrorServerCertificateHasUnknownRoot that DumpRenderTree
was looking for. Update DumpRenderTree to accommodate the different error code.
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
- platform/mac-snowleopard/Skipped: Unskip the tests.
- 5:20 PM Changeset in webkit [44482] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-06 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6930540>
REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle
Test: fast/css/font-family-builtins.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::identifierForFamily): Fix typo. Fantasy family should be -webkit-fantasy not, -webkit-serif.
LayoutTests:
2009-06-06 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Test for <rdar://problem/6930540>
REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle
- fast/css/font-family-builtins-expected.txt: Added.
- fast/css/font-family-builtins.html: Added.
- 3:17 PM Changeset in webkit [44481] by
-
- 13 edits in trunk
WebCore:
2009-06-06 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Fix for <rdar://problem/6936235>
Need to support StorageEvent.storageArea to meet the Web Storage spec
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::dispatchStorageEvent): Pass the localStorage for the frame being dispatched to.
- storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::dispatchStorageEvent): Ditto, only for sessionStorage.
- storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
- storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::storageArea):
- storage/StorageEvent.idl: Add storageArea member.
LayoutTests:
2009-06-06 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Update tests for <rdar://problem/6936235>
Need to support StorageEvent.storageArea to meet the Web Storage spec
Test StorageEvent.uri, StorageEvent.source and StorageEvent.storageArea.
- storage/domstorage/localstorage/iframe-events-expected.txt:
- storage/domstorage/localstorage/iframe-events.html:
- storage/domstorage/localstorage/resources/iframe-events-second.html:
- storage/domstorage/sessionstorage/iframe-events-expected.txt:
- storage/domstorage/sessionstorage/iframe-events.html:
- storage/domstorage/sessionstorage/resources/iframe-events-second.html:
- 9:53 AM Changeset in webkit [44480] by
-
- 11 edits in trunk
Reviewed by Anders Carlsson.
Force initialization of the WML variable state, right after the dynamically created WML elements have been added to the tree.
Note that "regular WML" doesn't support JavaScript at all, in a normal WML document WMLDocument::finishedParsing() takes care of that.
Jun 5, 2009:
- 9:49 PM Changeset in webkit [44479] by
-
- 5 edits in trunk
2009-06-05 WANG Lu <coolwanglu@gmail.com>
Reviewed by Jan Alonzo.
[Gtk] WebKit GTK with libsoup won't recognize proxies
https://bugs.webkit.org/show_bug.cgi?id=25263
Added --with-libsoup-gnome (default=no) to enable GNOME-specific
features of libsoup, an important one of which is the proxy-resolver
feature.
- configure.ac:
2009-06-05 WANG Lu <coolwanglu@gmail.com>
Reviewed by Jan Alonzo.
[Gtk] WebKit GTK with libsoup won't recognize proxies
https://bugs.webkit.org/show_bug.cgi?id=25263
If libsoup-gnome is enabled, proper parameters are added when creating
a new soup session, in order to enable GNOME-specific features of
libsoup.
- GNUmakefile.am:
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::createSoupSession):
- 7:54 PM Changeset in webkit [44478] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Rudder stamped by Sam Weinig.
Add missing ASSERT.
- assembler/X86Assembler.h: (JSC::X86Assembler::getRelocatedAddress):
- 7:39 PM Changeset in webkit [44477] by
-
- 5 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Switch storePtrWithPatch to take the initial immediate value as an argument.
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::storePtrWithPatch):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtrWithPatch):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jsr):
- 5:08 PM Changeset in webkit [44476] by
-
- 5 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove patchLength..tByIdExternalLoadPrefix magic numbers from JIT.h.
These aren't really suitable values to be tracking within common code
of the JIT, since they are not (and realistically cannot) be checked
by ASSERTs, as the other repatch offsets are. Move this functionality
(skipping the REX prefix when patching load instructions to LEAs on
x86-64) into the X86Assembler.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadPtrToLEA):
- assembler/X86Assembler.h: (JSC::X86Assembler::repatchLoadPtrToLEA):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace):
- 4:24 PM Changeset in webkit [44475] by
-
- 3 edits in trunk/WebCore
2009-06-05 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add ononline and onoffline attributes for the <body> element.
- html/HTMLAttributeNames.in: Added ononlineAttr and onofflineAttr.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Map ononlineAttr and onofflineAttr to window event listeners.
- 1:22 PM Changeset in webkit [44474] by
-
- 2 edits in trunk/WebKit/mac
2009-06-05 David Hyatt <hyatt@apple.com>
Reviewed by Mark Rowe.
Update a WebView's active state when it moves to a different window.
- WebView/WebView.mm: (-[WebView viewDidMoveToWindow]):
- 10:43 AM Changeset in webkit [44473] by
-
- 2 edits in trunk/WebKitSite
2009-06-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.com>
Bug 26188: Clarify some of the cases in the coding style guide
Reviewed and tweaked by David Kilzer.
Changed the coding style document to clarify some cases of ambiguity.
- coding/coding-style.html:
- 9:02 AM Changeset in webkit [44472] by
-
- 9 edits in trunk
2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add missing includes of config.h
- 7:53 AM Changeset in webkit [44471] by
-
- 2 edits in trunk/WebCore
2009-06-05 Fumitoshi Ukai <ukai@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26215
Try to fix the Chromium build.
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs): (WebCore::fillNonBMPGlyphs):
- 7:53 AM QtWebKitTodo edited by
- (diff)
- 7:43 AM Changeset in webkit [44470] by
-
- 4 edits in trunk
2009-06-05 Shinichiro Hamaji <hamaji@chromium.org>
Bug 26160: Compile fails in MacOSX when GNU fileutils are installed
Reviewed by Alexey Proskuryakov.
Use /bin/ln instead of ln for cases where this command is used with -h option.
As this option is not supported by GNU fileutils, this change helps users
who have GNU fileutils in their PATH.
- JavaScriptCore.xcodeproj/project.pbxproj:
WebCore:
2009-06-05 Shinichiro Hamaji <hamaji@chromium.org>
Bug 26160: Compile fails in MacOSX when GNU fileutils are installed
Reviewed by Alexey Proskuryakov.
Use /bin/ln instead of ln for cases where this command is used with -h option.
As this option is not supported by GNU fileutils, this change helps users
who have GNU fileutils in their PATH.
- WebCore.xcodeproj/project.pbxproj:
- 7:10 AM Changeset in webkit [44469] by
-
- 1 edit in trunk/WebKit/qt/Api/qwebsettings.cpp
Fix the Qt build after r44413
- 7:00 AM Changeset in webkit [44468] by
-
- 9 edits2 adds in trunk
2009-06-03 Ben Murdoch <benm@google.com>
<https://bugs.webkit.org/show_bug.cgi?id=25710> HTML5 Database stops executing transactions if the URL hash changes while a transaction is open and an XHR is in progress.
Reviewed by Alexey Proskuryakov.
Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading
https://bugs.webkit.org/show_bug.cgi?id=25710
Test: storage/hash-change-with-xhr.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopAllLoaders):
- loader/FrameLoader.h:
- loader/FrameLoaderTypes.h: (WebCore::):
- page/Page.cpp: (WebCore::Page::goToItem):
- WebCore.base.exp:
- 5:12 AM Changeset in webkit [44467] by
-
- 2 edits in trunk/WebCore
2009-06-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Make sure the correct config.h is included when shadow-building
- 5:05 AM Changeset in webkit [44466] by
-
- 2 edits in trunk/WebKitTools
2009-06-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Fix Perl warning when calling chdir with an empty/undefined path
This happened when the included makespec was in the same directory as
the parent makespec, so the relative path between the two was empty.
- 5:03 AM Changeset in webkit [44465] by
-
- 3 edits in trunk/WebCore
2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix Qt build after r44452
- 4:27 AM Changeset in webkit [44464] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add missing changelog for r44462
- 4:24 AM Changeset in webkit [44463] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Fix the Qt build (missing symbols)
- 4:24 AM Changeset in webkit [44462] by
-
- 3 edits1 delete in trunk/WebCore
[Qt] Remove some dead code (MenuEventProxy)
- 3:58 AM Changeset in webkit [44461] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Remove DoubleNotEqual floating point comparison condition for now -
it is not used, and it is unclear the semantics are correct (I think
this comparison would actually give you not-equal-or-unordered, which
might be what is wanted... we can revisit this interface & get it
right when required).
Also, fix asserts in branchArith32 ops. All adds & subs can check
for Signed, multiply only sets OF so can only check for overflow.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32):
- 3:46 AM Changeset in webkit [44460] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Minor tidy up in JITStubs.
- jit/JITStubs.cpp: (JSC::StackHack::StackHack):
- jit/JITStubs.h:
- 3:15 AM Changeset in webkit [44459] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-05 Koen Kooi <koen@dominion.thruhere.net>
Reviewed by Xan Lopez.
Build fix for glib unicode backend.
- wtf/unicode/glib/UnicodeMacrosFromICU.h:
- 2:31 AM Changeset in webkit [44458] by
-
- 2 edits in trunk/WebCore
2009-06-05 Xan Lopez <xlopez@igalia.com>
More build fixes.
- platform/graphics/gtk/GlyphPageTreeNodePango.cpp: (WebCore::GlyphPage::fill):
- 2:19 AM Changeset in webkit [44457] by
-
- 5 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
3 tiny cleanups:
- assembler/MacroAssemblerX86.h:
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtrWithPatch):
store*() methods should take an ImplicitAddress, rather than an Address.
- assembler/X86Assembler.h:
Make patchPointer private.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_ret):
Remove empty line at end of function.
- 2:16 AM Changeset in webkit [44456] by
-
- 4 edits in trunk/WebCore
2009-06-05 Xan Lopez <xlopez@igalia.com>
Fix the GTK+ build.
- GNUmakefile.am:
- platform/graphics/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
- 12:55 AM Changeset in webkit [44455] by
-
- 13 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Encapsulate many uses of void* in the assembler & jit with types that provide
more semantic information. The new types are:
- MacroAssemblerCodePtr - this wraps a pointer into JIT generated code.
- FunctionPtr - this wraps a pointer to a C/C++ function in JSC.
- ReturnAddressPtr - this wraps a return address resulting from a 'call' instruction.
Wrapping these types allows for stronger type-checking than is possible with everything
represented a void*. For example, it is now enforced by the type system that near
calls can only be linked to JIT code and not to C functions in JSC (this was previously
required, but could not be enforced on the interface).
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon): (JSC::AbstractMacroAssembler::CodeLocationCommon::dataLocation): (JSC::AbstractMacroAssembler::CodeLocationCommon::executableAddress): (JSC::AbstractMacroAssembler::CodeLocationCommon::reset): (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadToLEA): (JSC::AbstractMacroAssembler::CodeLocationInstruction::CodeLocationInstruction): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR): (JSC::AbstractMacroAssembler::CodeLocationLabel::operator!): (JSC::AbstractMacroAssembler::CodeLocationLabel::reset): (JSC::AbstractMacroAssembler::CodeLocationLabel::CodeLocationLabel): (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination): (JSC::AbstractMacroAssembler::CodeLocationJump::relink): (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump): (JSC::AbstractMacroAssembler::CodeLocationCall::relink): (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::relink): (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToTrampoline): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::addressForLookup): (JSC::AbstractMacroAssembler::trampolineAt): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization): (JSC::::CodeLocationCommon::instructionAtOffset): (JSC::::CodeLocationCommon::labelAtOffset): (JSC::::CodeLocationCommon::jumpAtOffset): (JSC::::CodeLocationCommon::callAtOffset): (JSC::::CodeLocationCommon::nearCallAtOffset): (JSC::::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::::CodeLocationCommon::dataLabel32AtOffset):
- assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr): (JSC::FunctionPtr::value): (JSC::FunctionPtr::executableAddress): (JSC::ReturnAddressPtr::ReturnAddressPtr): (JSC::ReturnAddressPtr::value): (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr): (JSC::MacroAssemblerCodePtr::executableAddress): (JSC::MacroAssemblerCodePtr::dataLocation): (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
- assembler/X86Assembler.h: (JSC::X86Assembler::patchPointerForCall):
- jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
- jit/JITCall.cpp: (JSC::JIT::compileOpCall):
- jit/JITCode.h: (JSC::JITCode::operator !): (JSC::JITCode::addressForCall): (JSC::JITCode::offsetOf): (JSC::JITCode::execute): (JSC::JITCode::size): (JSC::JITCode::HostFunction):
- jit/JITInlineMethods.h: (JSC::JIT::emitNakedCall):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::JITThunks::ctiArrayLengthTrampoline): (JSC::JITThunks::ctiStringLengthTrampoline): (JSC::JITThunks::ctiVirtualCallPreLink): (JSC::JITThunks::ctiVirtualCallLink): (JSC::JITThunks::ctiVirtualCall): (JSC::JITThunks::ctiNativeCallThunk):
- yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::operator!): (JSC::Yarr::RegexCodeBlock::execute):
- 12:51 AM Changeset in webkit [44454] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-05 Antti Koivisto <Antti Koivisto>
Try to unbreak Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 12:36 AM Changeset in webkit [44453] by
-
- 5 edits in trunk/WebCore
2009-06-05 Antti Koivisto <Antti Koivisto>
Try to fix Windows (and possibly other platforms) build.
Restore ResourceResponseBase::lastModifiedDate() and setLastModifiedDate() removed in previous commit.
for now since PluginStream used on some platforms expects them and calculations differ from plain
Last-modified header value.
Also include <wtf/MathExtras.h> to get isfinite().
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate):
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
