Timeline

Jun 7, 2009:

11:38 PM Changeset in webkit [44494] by jmalonzo@webkit.org

• 5 edits in trunk

Revert "2009-06-05 WANG Lu <​coolwanglu@gmail.com>"

Revert commit r44479 as we need to workout first what the best option is for adding
optional features like this.

9:28 PM Changeset in webkit [44493] by barraclough@apple.com

• 2 edits in trunk/JavaScriptCore

2009-06-07 Gavin Barraclough <​barraclough@apple.com>

RS by Sam Weinig.

Remove bonus bogus \n from last commit.

• jit/JITStubs.cpp: (JSC::):

9:23 PM Changeset in webkit [44492] by barraclough@apple.com

• 4 edits in trunk/JavaScriptCore

2009-06-07 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam Weinig.

Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.

• jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):

JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).

• jit/JITStubs.cpp: (JSC::):

Add ctiOpThrowNotCaught definitions.

(JSC::JITStubs::DEFINE_STUB_FUNCTION):

Change cti_op_throw to always change its return address.

• jit/JITStubs.h:

Add ctiOpThrowNotCaught declaration.

7:19 PM Changeset in webkit [44491] by mitz@apple.com

• 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

• fix <rdar://problem/6931661> -[WebView _selectionIsAll] returns YES when the selection is inside a text field.

• editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): Return false if the selection is in a shadow tree.

1:25 PM Changeset in webkit [44490] by kov@webkit.org

• 2 edits in trunk/WebCore

2009-06-07 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=26106
[GTK] Crashes when you keep a combo open during a page transition, then close it

Hide the combo popup and disconnect from its signals during
PopupMenu destruction to handle this exceptional case with no
crash.

• platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::menuUnmapped):

1:55 AM Changeset in webkit [44489] by mrowe@apple.com

• 2 edits in trunk/WebKitTools

Delete the AccessibilityController that we allocated in -init.

Rubber-stamped by Cameron Zwarich.

• DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate dealloc]):

Jun 6, 2009:

10:45 PM Changeset in webkit [44488] by mrowe@apple.com

• 2 edits in trunk/WebKitTools

Factor out the code to check whether a library contains a given symbol in to a helper function.

Reviewed by Dan Bernstein.

• Scripts/webkitdirs.pm:

10:25 PM Changeset in webkit [44487] by mrowe@apple.com

• 8 edits in trunk

Detect when XHTML MP and WCSS are disabled and skip their associated regression tests.

Reviewed by Sam Weinig.

• Scripts/run-webkit-tests:
• Scripts/webkitdirs.pm:

Remove XHTML MP and WCSS tests from the skipped lists as run-webkit-tests
now treats them like our other optional features and will skip them automatically
when the feature is not compiled in.

• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:

8:09 PM Changeset in webkit [44486] by mrowe@apple.com

• 2 edits in trunk/LayoutTests

Unskip two more tests that now pass.

• platform/mac-snowleopard/Skipped:

6:38 PM Changeset in webkit [44485] by kov@webkit.org

• 2 edits in trunk/WebKit/gtk

2009-06-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=26175
[GTK] Download progress notification should be throttled, for the benefit of download managers

Throttle notifications for the 'progress' property of the Download
object, and update documentation to note the fact that this is
being done, and how to get all notifications if you really care
about them.

• webkit/webkitdownload.cpp: (webkit_download_class_init): (webkit_download_received_data):

6:10 PM Changeset in webkit [44484] by mrowe@apple.com

• 2 edits in trunk/LayoutTests

Unskip some tests now that they pass.

• platform/mac-snowleopard/Skipped:

6:10 PM Changeset in webkit [44483] by mrowe@apple.com

• 4 edits in trunk

<rdar://problem/6778101> Four SSL-related test failures

Reviewed by Brady Eidson.

With newer versions of CFNetwork we receive a NSURLErrorServerCertificateUntrusted error
code rather than the more specific NSURLErrorServerCertificateHasUnknownRoot that DumpRenderTree
was looking for. Update DumpRenderTree to accommodate the different error code.

• DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):

• platform/mac-snowleopard/Skipped: Unskip the tests.

5:20 PM Changeset in webkit [44482] by weinig@apple.com

• 3 edits
  2 adds in trunk

WebCore:

2009-06-06 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6930540>
REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle

Test: fast/css/font-family-builtins.html

• css/CSSComputedStyleDeclaration.cpp: (WebCore::identifierForFamily): Fix typo. Fantasy family should be -webkit-fantasy not, -webkit-serif.

LayoutTests:

2009-06-06 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Test for <rdar://problem/6930540>
REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle

• fast/css/font-family-builtins-expected.txt: Added.
• fast/css/font-family-builtins.html: Added.

3:17 PM Changeset in webkit [44481] by weinig@apple.com

• 13 edits in trunk

WebCore:

2009-06-06 Sam Weinig <​sam@webkit.org>

Reviewed by Brady Eidson.

Fix for <rdar://problem/6936235>
Need to support StorageEvent.storageArea to meet the Web Storage spec

• storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::dispatchStorageEvent): Pass the localStorage for the frame being dispatched to.
• storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::dispatchStorageEvent): Ditto, only for sessionStorage.

• storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
• storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::storageArea):
• storage/StorageEvent.idl: Add storageArea member.

LayoutTests:

2009-06-06 Sam Weinig <​sam@webkit.org>

Reviewed by Brady Eidson.

Update tests for <rdar://problem/6936235>
Need to support StorageEvent.storageArea to meet the Web Storage spec

Test StorageEvent.uri, StorageEvent.source and StorageEvent.storageArea.

• storage/domstorage/localstorage/iframe-events-expected.txt:
• storage/domstorage/localstorage/iframe-events.html:
• storage/domstorage/localstorage/resources/iframe-events-second.html:
• storage/domstorage/sessionstorage/iframe-events-expected.txt:
• storage/domstorage/sessionstorage/iframe-events.html:
• storage/domstorage/sessionstorage/resources/iframe-events-second.html:

9:53 AM Changeset in webkit [44480] by Nikolas Zimmermann

• 11 edits in trunk

Reviewed by Anders Carlsson.

Force initialization of the WML variable state, right after the dynamically created WML elements have been added to the tree.
Note that "regular WML" doesn't support JavaScript at all, in a normal WML document WMLDocument::finishedParsing() takes care of that.