⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 11, 2009:

11:46 PM Changeset in webkit [44622] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Only use the VisibleSelection object if it actually belongs to the
object we are using.

This is pretty hacky-ish, but I can't seem to find a direct API to
get the VisibleSelection for a given object, only the global one.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): (webkit_accessible_text_get_n_selections): (webkit_accessible_text_get_selection):
5:58 PM Changeset in webkit [44621] by jparent@chromium.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

2009-06-11 Ryosuke Niwa <​rniwa@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=2628i
Converted LayoutTests\editing\deleting\4875189.html from a pixel test t

dumpAsText test

since it only checks whether the result contains exactly two paragraphs

or not.

  • editing/deleting/4875189-expected.txt: Added.
  • editing/deleting/4875189.html:
  • platform/mac/editing/deleting/4875189-expected.checksum: Removed.
  • platform/mac/editing/deleting/4875189-expected.png: Removed.
  • platform/mac/editing/deleting/4875189-expected.txt: Removed.
  • platform/qt/editing/deleting/4875189-expected.txt: Removed.
4:47 PM Changeset in webkit [44620] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-11 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Add a test to perform an actual download.

  • tests/testdownload.c: (navigation_policy_decision_requested_cb): (notify_status_cb): (download_requested_cb): (test_webkit_download_perform): (main):
3:38 PM Changeset in webkit [44619] by kov@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-06-11 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Fix crash when downloading, caused by assuming SoupMessage would
be there. This change factors the logic required to create a
ResourceRequest from a WebKitNetworkRequest into a core()
function, like we have for some other classes.

  • webkit/webkitdownload.cpp: (webkit_download_start):
  • webkit/webkitprivate.cpp: (WebKit::core):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
3:17 PM Changeset in webkit [44618] by eric@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2009-06-11 Eric Seidel <​eric@webkit.org>

Rubber stamped by Dave Levin.

Add missing pixel results

  • platform/mac/editing/style/apply-through-end-of-document-expected.checksum: Added.
  • platform/mac/editing/style/apply-through-end-of-document-expected.png: Added.
  • platform/mac/fast/canvas/canvas-empty-image-pattern-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
  • platform/mac/fast/canvas/canvas-empty-image-pattern-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
  • platform/mac/fast/css/compare-content-style-expected.checksum: Added.
  • platform/mac/fast/css/compare-content-style-expected.png: Added.
  • platform/mac/fast/dynamic/anchor-lock-expected.checksum: Added.
  • platform/mac/fast/dynamic/anchor-lock-expected.png: Added.
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.checksum: Added.
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.png: Added.
  • platform/mac/webarchive/test-link-rel-icon-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
  • platform/mac/webarchive/test-link-rel-icon-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
2:20 PM Changeset in webkit [44617] by eric@webkit.org
  • 4 edits in trunk/WebCore

Speculative fix

1:05 PM Changeset in webkit [44616] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.18

New tag.

1:05 PM Changeset in webkit [44615] by mrowe@apple.com
  • 1 delete in branches/Safari-6530.18

Hrm, this isn't where I should live.

1:03 PM Changeset in webkit [44614] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

1:02 PM Changeset in webkit [44613] by mrowe@apple.com
  • 1 copy in branches/Safari-6530.18

New tag.

12:59 PM Changeset in webkit [44612] by mrowe@apple.com
  • 13 edits in branches/WWDC-2009-branch

Merge r44591.

12:58 PM Changeset in webkit [44611] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

11:47 AM Changeset in webkit [44610] by oliver@apple.com
  • 5 edits in trunk

Lower stringify recursion limit to deal with small windows stack.

11:20 AM Changeset in webkit [44609] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-11 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Steve Falkenburg.

​https://bugs.webkit.org/show_bug.cgi?id=26306

Revert 42565 as it leads to DumpRenderTree crashing on startup because
Windows can't find CFURLCacheCopySharedURLCache in CoreNetwork.dll.

  • DumpRenderTree/win/DumpRenderTree.cpp:
11:15 AM Changeset in webkit [44608] by bfulgham@webkit.org
  • 8 edits
    4 adds in trunk

2009-06-11 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=25512
Handle texts after unfinished special tags (i.e., script, style, textarea,
title, xmp, and iframe) as the text node under the tags in view-source mode.
Before this change, all texts in unfinished special tags cannot be seen even in view-source mode.

10:57 AM Changeset in webkit [44607] by ariya@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

Fix compilation warnings
<​https://bugs.webkit.org/show_bug.cgi?id=26015>

  • wtf/ThreadingNone.cpp: (WTF::ThreadCondition::wait): Fix compilation warning. (WTF::ThreadCondition::timedWait): Ditto.
10:39 AM Changeset in webkit [44606] by ariya@webkit.org
  • 2 edits in trunk

2009-06-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

[Qt] Fix release build detection
​https://bugs.webkit.org/show_bug.cgi?id=26267

  • WebKit.pri:
10:28 AM Changeset in webkit [44605] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-06-11 Yongjun Zhang <​yongjun.zhang@nokia.com>

Reviewed by Ariya Hidayat.

​https://bugs.webkit.org/show_bug.cgi?id=26291

[Qt] build break in ImageDecoderQt.cpp.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::reset): (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::isSizeAvailable):
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::setSize):
9:34 AM Changeset in webkit [44604] by bfulgham@webkit.org
  • 3 edits in trunk/WebKitSite

2009-06-10 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Eric Seidel.

Fixes ​https://bugs.webkit.org/show_bug.cgi?id=26309.
Update a few items in the testing language to:
(1) Reflect results are now generated with Leopard (not Tiger)
(2) Explain how to generate pixel-level layout tests.

6:57 AM Changeset in webkit [44603] by Simon Hausmann
  • 1 edit
    7 deletes in trunk/WebCore

2009-06-11 Simon Hausmann <​simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Removed obsolete and unmaintained files from the old Symbian port.

4:59 AM QtWebKitTodo edited by Simon Hausmann
(diff)
4:58 AM QtWebKitTodo edited by Simon Hausmann
(diff)

Jun 10, 2009:

10:31 PM Changeset in webkit [44602] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-10 Brent Fulgham <​bfulgham@gmail.com>

Unreviewed build fix.
Reverted change to skip file, as Windows build is
still failing.

  • platform/win/Skipped:
9:59 PM Changeset in webkit [44601] by bfulgham@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

2009-06-05 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Eric Seidel.

Re-enable the video-zoom-controls test on Windows.

​https://bugs.webkit.org/show_bug.cgi?id=25465

  • platform/win/Skipped:
  • platform/win/media: Added.
  • platform/win/media/video-zoom-controls-expected.checksum: Added.
  • platform/win/media/video-zoom-controls-expected.png: Added.
  • platform/win/media/video-zoom-controls-expected.txt: Added.
9:44 PM Changeset in webkit [44600] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Jan Alonzo.

[gtk] Change DumpRenderTree to use a GtkScrolledWindow instead of GtkFixed

Change the code to use GtkScrolledWindow and resize the GtkScrolledWindow
to pass more tests. Make sure the content is bigger than a thumbnail.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): (main):
8:14 PM Changeset in webkit [44599] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-10 Gustavo Noronha Silva <Gustavo Noronha Silva>

Disabling new tests, and tests that use features of DRT we don't
currently implement.

  • platform/gtk/Skipped:
7:48 PM Changeset in webkit [44598] by kov@webkit.org
  • 6 edits
    1 add in trunk

2009-06-10 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Add unit tests for our WebKitNetworkRequest object.

  • GNUmakefile.am:

WebKit/gtk

2009-06-10 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Make WebKitNetworkRequest a proper GObject, making URI and
SoupMessage properties. Also adding unit tests for creation and
destruction.

  • tests/testnetworkrequest.c: Added. (test_network_request_create_destroy): (test_network_request_properties): (main):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_property): (webkit_network_request_set_property): (webkit_network_request_class_init): (webkit_network_request_init): (webkit_network_request_constructor): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_set_uri): (webkit_network_request_get_uri):
  • webkit/webkitnetworkrequest.h:
5:31 PM Changeset in webkit [44597] by pkasting@chromium.org
  • 11 edits in trunk/WebCore

2009-06-10 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25709 part six
Miscellaneous tiny changes. The important bits here are the ANSI C++
compliance fix in skia/ImageDecoders.h (needed to compile this file on
non-MSVC) and some behavioral fixes for the XBM decoder that Chromium
unit tests partly exposed. Other changes are mostly cosmetic.

  • platform/image-decoders/ImageDecoder.h: Make some variables private again. This will break QTWebKit but those guys have agreed to wait on my finishing the ImageDecoder changes.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  • platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): Make more in line with other decoders' comments and structure, use a ref to decrease verbosity. (WebCore::BMPImageReader::processRLEData): Use a ref to decrease verbosity. (WebCore::BMPImageReader::processNonRLEData): Use a ref to decrease verbosity.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix ANSI violation that MSVC let me compile (!).
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  • platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  • platform/image-decoders/skia/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::frameBufferAtIndex): Return 0 for non-zero indexes, don't try to decode unnecessarily after failure or when the size couldn't be computed, make more in line with other decoders' comments and structure, call RGBA32Buffer::setRect() appropriately.
5:16 PM Changeset in webkit [44596] by bfulgham@webkit.org
  • 1 edit
    1 move
    2 adds
    1 delete in trunk/LayoutTests

2009-06-10 Brent Fulgham <​bfulgham@webkit.org>

Unreviewed build correction.

Clean up some stupid test mistakes, add pixel-level Mac tests
for the new zero-radius gradient test.

4:22 PM Changeset in webkit [44595] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Build correction for @r44574 (missing expected results).
See ​https://bugs.webkit.org/show_bug.cgi?id=26059.

3:47 PM Changeset in webkit [44594] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-10 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
3:40 PM BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
3:37 PM BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
3:37 PM BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
2:54 PM Changeset in webkit [44593] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Fix collapsing empty shadow nodes in textareas.

1:55 PM Changeset in webkit [44592] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Implement atk_text_get_n_selections.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_n_selections):
1:37 PM Changeset in webkit [44591] by mitz@apple.com
  • 13 edits in trunk

WebCore:

Reviewed by Anders Carlsson.

  • fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead

Calling stopLoadRequest() from notifyFinished() removed the
ScriptElementData from the CachedScript's client set, which could make
it eligible for purging. The fix is to call removeClient() only after
executing the script, which protects it from being purged while it is
in the document's queue of scripts to execute soon.

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::execute): Call removeClient() here. (WebCore::ScriptElementData::notifyFinished): Instead of calling stopLoadRequest(), which calls removeClient(), just reset m_cachedScript.

WebKitTools:

Reviewed by Adele Peterson.

  • add a LayoutTestController method for temporarily changing the WebKit cache model
  • DumpRenderTree/LayoutTestController.cpp: (setCacheModelCallback): Added. Calls LayoutTestController::setCacheModel() with the first argument as an integer. (LayoutTestController::staticFunctions): Added setCacheModel.
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Reset the cache model to WebCacheModelDocumentBrowser.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setCacheModel): Added. Calls -[WebPreferences setCacheModel:].
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setCacheModel):

LayoutTests:

Reviewed by Adele Peterson.

  • updated test to cover <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead
  • fast/dom/HTMLScriptElement/nested-execution.html:
  • fast/dom/HTMLScriptElement/resources/nested-execution.js:
1:36 PM Changeset in webkit [44590] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe and Eric Seidel.

Update WebInspector localizedStrings.js with new resource tracking strings
​https://bugs.webkit.org/show_bug.cgi?id=26247

  • English.lproj/localizedStrings.js:
12:43 PM Changeset in webkit [44589] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.9

Tagging 1.1.9.

12:22 PM Changeset in webkit [44588] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android specific files.
​https://bugs.webkit.org/show_bug.cgi?id=26280

12:21 PM Changeset in webkit [44587] by bfulgham@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android specific file to WebCore/platform/android (part 9).
​https://bugs.webkit.org/show_bug.cgi?id=26266

12:19 PM Changeset in webkit [44586] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android platform specific files.
​https://bugs.webkit/org/show_bug.cgi?id=26265 (part 8).

12:18 PM Changeset in webkit [44585] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform. (part 6).
​https://bugs.webkit.org/show_bug.cgi?id=26264

12:11 PM Changeset in webkit [44584] by bfulgham@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 7).
​https://bugs.webkit.org/show_bug.cgi?id=23296

12:09 PM Changeset in webkit [44583] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 5).
​https://bugs.webkit.org/show_bug.cgi?id=23296

12:06 PM Changeset in webkit [44582] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 4).
​https://bugs.webkit.org/show_bug.cgi?id=23296

12:05 PM Changeset in webkit [44581] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 3).
​https://bugs.webkit.org/show_bug.cgi?id=23296

12:01 PM Changeset in webkit [44580] by bfulgham@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 2).
​https://bugs.webkit.org/show_bug.cgi?id=23296

11:46 AM Changeset in webkit [44579] by levin@chromium.org
  • 6 edits
    1 copy in trunk/WebCore

2009-06-10 Nate Chapin <​japhet@google.com>

Reviewed by David Levin.

Finish moving V8Custom from src.chromium.org to svn.webkit.org.

​https://bugs.webkit.org/show_bug.cgi?id=26258

  • bindings/v8/custom/V8CustomBinding.cpp: Finished upstreaming. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::V8Custom::GetTargetFrame): Moved from v8_custom.cpp. (WebCore::V8Custom::DowncastSVGPathSeg): Moved from v8_custom.cpp.
  • bindings/v8/custom/V8CustomBinding.h: Finished upstreaming.
  • bindings/v8/custom/V8DatabaseCustom.cpp: Updated includes.
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Updated includes.
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: Updated includes.
  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
11:21 AM Changeset in webkit [44578] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

2009-06-05 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by NOBODY (OOPS!).

​https://bugs.webkit.org/show_bug.cgi?id=26214
Bug 26214: RenderTextControl: Remove ASSERT for checking that visiblePositionForIndex()'s return is not null.

11:18 AM Changeset in webkit [44577] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-10 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

News for 1.1.9.

  • NEWS:
11:16 AM Changeset in webkit [44576] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-04 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26197
Bug 26197: Incorrect variable initialization in PlatformContextSkia.cpp

11:04 AM Changeset in webkit [44575] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

2009-06-10 Dean McNamee <​deanm@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26061
Make sure filling a canvas pattern with an empty image doesn't crash.

10:57 AM Changeset in webkit [44574] by bfulgham@webkit.org
  • 4 edits
    1 add in trunk

Correct Bug #26059.
​https://bugs.webkit.org/show_bug.cgi?id=26059.

10:46 AM Changeset in webkit [44573] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

2009-06-10 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25709 part five
Rewrite users of ImageDecoder.h to use "safe" API calls, Skia side.
This tweaks the RGBA32Buffer interfaces to be implementable by Cairo as
well and modifies Skia's usage of those interfaces accordingly. Once a
similar change lands on the Cairo side, the Skia and Cairo decoders
should be identical except for the implementation of RGBA32Buffer.

  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() function.
  • platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::processNonRLEData): Use new RGBA32Buffer::zeroFill() function.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow): Rewrite to use RGBA32Buffer::setRGBA(x, y, ...) calls as well as other RGBA32Buffer interface calls instead of knowing the underlying types inside the buffer; also try and add clarity.
  • platform/image-decoders/skia/ImageDecoder.h: Removed bitmap(), width(), and height(). (WebCore::RGBA32Buffer::zeroFill): Added. (WebCore::RGBA32Buffer::copyBitmapData): Avoid using bitmap(), which is going away. (WebCore::RGBA32Buffer::copyRowNTimes): Added. (WebCore::RGBA32Buffer::setSize): Use new zeroFill() function. (WebCore::RGBA32Buffer::asNewNativeImage): Added. (WebCore::RGBA32Buffer::setRGBA): Condensed two versions into one that takes coordinates instead of a raw pointer.
10:36 AM Changeset in webkit [44572] by xan@webkit.org
  • 2 edits in trunk

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Version bump in preparation for 1.1.9 release.

  • configure.ac:
10:27 AM Changeset in webkit [44571] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25671
[GTK] Implement support for set_caret_offset

Make an implementation that actually works.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset):
10:26 AM Changeset in webkit [44570] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-09 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_clear_main_frame_name):
10:25 AM Changeset in webkit [44569] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-10 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26294

Make sure all member variables are initialized so that the default
assignment operator and copy constructors do not read uninitialized
memory.

  • platform/network/ResourceResponseBase.cpp:
10:18 AM Changeset in webkit [44568] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-06-10 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

Update main resource meta-data when resource tracking is disabled.

​https://bugs.webkit.org/show_bug.cgi?id=26253

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorController.h:
10:17 AM Changeset in webkit [44567] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Implement atk_text_get_selection.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_selection):
10:03 AM Changeset in webkit [44566] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not check if our parent class has the finalize method, it's
guaranteed to be there.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_finalize):
9:25 AM Changeset in webkit [44565] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Brent Fulgham <​bfulgham@webkit.org>

Build correct for Windows Cairo targets.

  • WebCore.vcproj/WebCore.vcproj: Disable warning 4611 (interaction between '_setjmp' and C++ object destruction is non-portable) for the two Cairo targets. This used to be disabled in a #pragma, but recent refactoring removed these lines.
9:20 AM Changeset in webkit [44564] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-10 Brent Fulgham <​bfulgham@webkit.org>

Build fix for Windows target.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Correct missing </File> tag after @r44550 that prevents the project from being loaded in the Visual Studio IDE.
9:06 AM QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
8:37 AM Changeset in webkit [44563] by Simon Hausmann
  • 4 edits in trunk/WebCore

2009-06-10 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Fix the build of PluginView on Qt with 64-bit where we disable plugins
at compile time.

Use the FooNone.cpp files at compile-time.

8:32 AM Changeset in webkit [44562] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-06-10 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Qt build.

ImageDecoderQt needs m_size and m_sizeAvailable to be protected.

8:21 AM Changeset in webkit [44561] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Use absolute path for install_name on Mac

7:48 AM Changeset in webkit [44560] by ariya@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-06-10 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Documented ResolveRule and StylePriority enum values as well as their use in
QWebElement::styleProperty and QWebElement::setStyleProperty methods.

Based on the work of Simon Hausmann.

  • Api/qwebelement.cpp: (QWebElement::styleProperty): (QWebElement::setStyleProperty):
  • Api/qwebelement.h:
6:10 AM Changeset in webkit [44559] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-08 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Reduce duplicated code to access the text of a AtkText
object. doAXStringForRange calls text() internally, so we are
doing exactly the same after the change.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (getPangoLayoutForAtk):
6:10 AM Changeset in webkit [44558] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Pass a PangoLayout to the GailTextUtil function calls.

It's needed for LINE boundary calls to work correctly.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (updateLayout): (getPangoLayoutForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):
6:10 AM Changeset in webkit [44557] by xan@webkit.org
  • 7 edits in trunk

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Add new dependency on the Gail utils library, needed for our a11y
implementation.

  • GNUmakefile.am:
  • configure.ac:

WebCore:

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Use GailUtilText instead of my crappy partial reimplementation of
it. This should add support for LINE boundaries too, although it's
mostly untested for now.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):

WebKit/gtk:

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Update test for new implementation (it fixes two bugs and adds
actual implementations for LINE boundaries).

  • tests/testatk.c: (test_webkit_atk_get_text_at_offset):
3:41 AM Changeset in webkit [44556] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix: include <stdio.h> as it is required in jpeglib.h

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
Note: See TracTimeline for information about the timeline view.