Timeline
Jun 15, 2009:
- 11:52 PM Changeset in webkit [44713] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Sam Weinig.
Rename PatchBuffer to LinkBuffer. Previously our terminology has been a little
mixed up, but we have decided to fix on refering to the process that takes place
at the end of code generation as 'linking', and on any modifications that take
place later (and once the code has potentially already been executed) as 'patching'.
However, the term 'PatchBuffer' is already in use, and needs to be repurposed.
To try to minimize confusion, we're going to switch the terminology over in stages,
so for now we'll refer to later modifications as 'repatching'. This means that the
new 'PatchBuffer' has been introduced with the name 'RepatchBuffer' instead.
This patch renames the old 'PatchBuffer' to 'LinkBuffer'. We'll leave ToT in this
state for a week or so to try to avoid to much overlap of the meaning of the term
'PatchBuffer', then will come back and rename 'RepatchBuffer'.
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::LinkBuffer::LinkBuffer): (JSC::AbstractMacroAssembler::LinkBuffer::~LinkBuffer):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile):
- 11:17 PM Changeset in webkit [44712] by
-
- 7 edits in trunk
WebCore:
2009-06-15 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): When inserting a newline after the blockquote, we don't want to apply the original style after the insertion.
LayoutTests:
2009-06-15 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Updating test for:
<rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
This test case covered inserting a newline after a blockquote, but outside of the blockquote. I added some
text insertion to verify that the newline doesn't get any old styles copied from the blockquote.
- editing/pasteboard/5368833.html:
- platform/mac/editing/pasteboard/5368833-expected.checksum:
- platform/mac/editing/pasteboard/5368833-expected.png:
- platform/mac/editing/pasteboard/5368833-expected.txt:
- 10:35 PM Changeset in webkit [44711] by
-
- 11 edits1 copy in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Having moved most of their functionality into the RepatchBuffer class,
we can simplify the CodeLocation* classes.
The CodeLocation* classes are currently a tangle of templatey and friendly
badness, burried in the middle of AbstractMacroAssembler. Having moved
the ability to repatch out into RepatchBufer they are now do-nothing wrappers
on CodePtr (MacroAssemblerCodePtr), that only exist to provide type-safety.
Simplify the code, and move them off into their own header.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::PatchBuffer::patch):
- assembler/CodeLocation.h: Copied from assembler/AbstractMacroAssembler.h. (JSC::CodeLocationCommon::CodeLocationCommon): (JSC::CodeLocationInstruction::CodeLocationInstruction): (JSC::CodeLocationLabel::CodeLocationLabel): (JSC::CodeLocationJump::CodeLocationJump): (JSC::CodeLocationCall::CodeLocationCall): (JSC::CodeLocationNearCall::CodeLocationNearCall): (JSC::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::CodeLocationCommon::instructionAtOffset): (JSC::CodeLocationCommon::labelAtOffset): (JSC::CodeLocationCommon::jumpAtOffset): (JSC::CodeLocationCommon::callAtOffset): (JSC::CodeLocationCommon::nearCallAtOffset): (JSC::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::CodeLocationCommon::dataLabel32AtOffset):
- assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::operator!):
- bytecode/CodeBlock.h: (JSC::getStructureStubInfoReturnLocation): (JSC::getCallLinkInfoReturnLocation): (JSC::getMethodCallLinkInfoReturnLocation):
- bytecode/Instruction.h:
- bytecode/JumpTable.h: (JSC::StringJumpTable::ctiForValue): (JSC::SimpleJumpTable::ctiForValue):
- bytecode/StructureStubInfo.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCatch):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
- 10:03 PM Changeset in webkit [44710] by
-
- 2 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove outdated comment.
- bindings/js/JSDOMWindowBase.h:
- 9:58 PM Changeset in webkit [44709] by
-
- 6 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Bring CustomGetPropertyNames more inline with the other
extended attributes prefixed with Custom, by making it
require a complete implementation.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames):
- bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getPropertyNames):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getPropertyNames):
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getPropertyNames):
- bindings/scripts/CodeGeneratorJS.pm:
- 9:04 PM Changeset in webkit [44708] by
-
- 2 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove commented out ondataunavailable attribute event listener which
has now been removed from HTML 5.
- page/DOMWindow.idl:
- 9:02 PM Changeset in webkit [44707] by
-
- 6 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Move entire custom implementation of getOwnPropertySlot and put
for JSDOMWindow into JSDOMWindowCustom, eliminating the bit in
JSDOMWindowBase.
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): (WebCore::childFrameGetter): (WebCore::indexGetter): (WebCore::namedItemGetter): (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::getPropertyAttributes):
- bindings/js/JSDOMWindowCustom.h:
- page/DOMWindow.idl:
- 9:00 PM Changeset in webkit [44706] by
-
- 2 edits in trunk/WebCore
2009-06-15 Jeremy Orlow (jorlow@chromium.org)
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26356
Define the functions in V8CustomBindings.h. "Forgot" this in my
earlier patch since it wasn't fully upstreamed when I wrote the
patch.
- bindings/v8/custom/V8CustomBinding.h:
- 8:01 PM Changeset in webkit [44705] by
-
- 11 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Having introduced the RepatchBuffer, ProcessorReturnAddress is now a do-nothing
wrapper around ReturnAddressPtr. Remove it. In tugging on this piece of string
it made sense to roll out the use of ReturnAddressPtr a little further into
JITStubs (which had always been the intention).
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
- assembler/MacroAssemblerCodeRef.h: (JSC::ReturnAddressPtr::ReturnAddressPtr):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getStubInfo): (JSC::CodeBlock::getCallLinkInfo): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::getBytecodeIndex):
- interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC):
- jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compilePatchGetArrayLength):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::StackHack::StackHack): (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::): (JSC::JITStackFrame::returnAddressSlot):
- runtime/JSGlobalData.h:
- 7:13 PM Changeset in webkit [44704] by
-
- 2 edits in trunk/WebKit/qt
2009-06-15 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Adam Treat.
Support the back/forward/stop/refresh multimedia keys and accept the
event when handling backspace and shift backspace as we should.
- Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
- 6:36 PM Changeset in webkit [44703] by
-
- 2 edits in trunk/WebCore
2009-06-15 Andre Boule <aboule@apple.com>
Reviewed by Cameron Zwarich and Dan Bernstein.
- fix <rdar://problem/6967975> crash with NSString drawAtPoint
No test possible because this crash can only occur if the client uses
WebKit text drawing without ever using WebCore text, and DumpRenderTree
cannot do either.
- platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Null-check
gFontPlatformDataCache.
- 6:27 PM Changeset in webkit [44702] by
-
- 11 edits in trunk
2009-06-15 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
<rdar://problem/6974857>
Define ENABLE_3D_RENDERING and WTF_USE_ACCELERATED_COMPOSITING when building on 10.6.
Move the ENABLE_3D_RENDERING switch from config.h and WebKitPrefix.h to wtf/Platform.h
- 6:12 PM Changeset in webkit [44701] by
-
- 6 edits in trunk/WebCore
2009-06-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Make WebInspector's console evaluation/completion asynchronous.
This way of evaluation allows serializing calls between
InspectorController and its frontend.
- inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): (WebInspector.Console.prototype._reportCompletions): (WebInspector.Console.prototype._evalInInspectedWindow): (WebInspector.Console.prototype._enterKeyPressed.printResult): (WebInspector.Console.prototype._enterKeyPressed):
- inspector/front-end/DatabaseQueryView.js:
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady):
- 5:26 PM Changeset in webkit [44700] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Move repatching methods into a set of methods on a class. This will allow us to
coallesce memory reprotection calls. Really, we want this class to be called
PatchBuffer, we want the class PatchBuffer to be called LinkBuffer, we want both
to be memblers of MacroAssembler rather then AbstractMacroAssembler, we don't
want the CodeLocationFoo types anymore (they are now only really there to provide
type safety, and that is completely undermined by the way we use offsets). Then
the link & patch buffers should delegate the actual patching calls to the
architecture-specific layer of the MacroAssembler. Landing all these changes as a
sequence of patches.
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::RepatchBuffer::RepatchBuffer): (JSC::AbstractMacroAssembler::RepatchBuffer::relink): (JSC::AbstractMacroAssembler::RepatchBuffer::repatch): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::repatchLoadPtrToLEA):
- jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- 4:19 PM Web Inspector edited by
- (diff)
- 4:19 PM Web Inspector edited by
- (diff)
- 4:16 PM Changeset in webkit [44699] by
-
- 2 edits in trunk/WebKit/mac
2009-06-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6967569>
CrashTracer: 15 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostManager::didCreateWindow + 85
Make sure to remove the entry from the plug-in host map so we won't end up with an entry that has a null value.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
- 4:10 PM Changeset in webkit [44698] by
-
- 2 edits in trunk/WebCore
2009-06-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
Reverted previous change as the old behavior was correct for heavy view.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
- 3:39 PM Changeset in webkit [44697] by
-
- 2 edits in trunk/WebCore
2009-06-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/6968125> Profiler 'Call' count is incorrect in Heavy
view (26418)
- Removed code that copied call and time data from it's ancestor.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
- 3:21 PM Changeset in webkit [44696] by
-
- 5 edits2 adds in trunk
Reviewed by Simon Fraser <Simon Fraser>.
Added logic to updateTransitions similar to that in updateKeyframeAnimations
which detects and removes stale transitions.
Test: transitions/cancel-transition.html
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation):
- page/animation/ImplicitAnimation.h: (WebCore::ImplicitAnimation::active): (WebCore::ImplicitAnimation::setActive):
- 2:18 PM Changeset in webkit [44695] by
-
- 11 edits in trunk
WebCore:
Reviewed by Tim Hatcher.
- allow the source code font in the Web Inspector to be customized
- css/view-source.css: Use the default monospace font family and size
for source code.
- inspector/front-end/inspector.css: Use the default monospace font
family and size for console I/O.
WebKit/mac:
Reviewed by Tim Hatcher.
- make the source code font in the Web Inspector match Mac defaults
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Set the default monospace font to 11px Menlo, except on Leopard and Tiger where it is 10px Monaco.
WebKit/win:
Reviewed by Tim Hatcher.
- use a nice source code font in the Web Inspector
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage): Set the default monospace font to
13px Courier New, which is the default source code font in Visual
Studio.
LayoutTests:
Reviewed by Tim Hatcher.
- updated results after changing source view to use the default monospace font family and size
- platform/mac/fast/frames/viewsource-attribute-expected.checksum:
- platform/mac/fast/frames/viewsource-attribute-expected.png:
- platform/mac/fast/frames/viewsource-attribute-expected.txt:
- 1:25 PM Changeset in webkit [44694] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=26377
[GTK] Confusion about range of 'progress' property
Range for the progress property is 0.0 .. 1.0, don't multiply it
by 100 to make it a percentage.
- webkit/webkitwebview.cpp: (webkit_web_view_get_progress):
- 1:17 PM Changeset in webkit [44693] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Hunt & Oliver Garen.
We are currently generating two copies of the slow path for op_call for no reason. Stop that.
Originally op_call used two slow paths since the first set up the pointer to the CallLinkInfo
for use when linking. However this is now looked up using the return address (as we do for
property accesses) so the two paths are now identical.
No performance impact, reduces memory footprint.
- bytecode/CodeBlock.h:
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::linkCall):
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
- jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- 11:39 AM Changeset in webkit [44692] by
-
- 4 edits in trunk/WebKit/qt
2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Adam Treat
https://bugs.webkit.org/show_bug.cgi?id=26351
Remove bool QWebHitTestResult::isScrollBar() const and make sure a null QWebHitTestResult is returned instead.
- 11:39 AM Changeset in webkit [44691] by
-
- 1 edit16 adds in trunk/WebKitExamplePlugins
2009-06-15 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Add Core Animation movie plug-in example.
- NetscapeCoreAnimationMoviePlugin: Added.
- NetscapeCoreAnimationMoviePlugin/English.lproj: Added.
- NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Added.
- NetscapeCoreAnimationMoviePlugin/Info.plist: Added.
- NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Added.
- NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Added. (createImageNamed): (-[MovieControllerLayer init]): (-[MovieControllerLayer dealloc]): (-[MovieControllerLayer _playPauseButtonRect]): (-[MovieControllerLayer _sliderRect]): (-[MovieControllerLayer _sliderThumbRect]): (-[MovieControllerLayer _innerSliderRect]): (-[MovieControllerLayer _drawPlayPauseButtonInContext:]): (-[MovieControllerLayer _drawSliderInContext:]): (-[MovieControllerLayer drawInContext:]): (-[MovieControllerLayer _currentTime]): (-[MovieControllerLayer _duration]): (-[MovieControllerLayer _isPlaying]): (-[MovieControllerLayer _updateTime:]): (-[MovieControllerLayer _rateDidChange:]): (-[MovieControllerLayer _timeDidChange:]): (-[MovieControllerLayer actionForKey:]): (-[MovieControllerLayer setMovie:]): (-[MovieControllerLayer _setNewTimeForThumbCenterX:]): (-[MovieControllerLayer handleMouseDown:]): (-[MovieControllerLayer handleMouseUp:]): (-[MovieControllerLayer handleMouseDragged:]):
- NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Added.
- NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Added.
- NetscapeCoreAnimationMoviePlugin/Pause.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/Play.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/main.m: Added. (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): (NPP_WriteReady): (NPP_Write): (NPP_StreamAsFile): (NPP_Print): (handleMouseDown): (togglePlayPause): (handleMouseUp): (handleMouseDragged): (handleMouseEntered): (handleMouseExited): (handleKeyDown): (handleScrollEvent): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
- NetscapeCoreAnimationMoviePlugin/test.html: Added.
- 11:14 AM Changeset in webkit [44690] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.10
Tagging 1.1.10.
- 8:40 AM Changeset in webkit [44689] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Add new symbols list for 1.1.10 release.
- docs/webkitgtk-docs.sgml:
- 8:39 AM Changeset in webkit [44688] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Fix Since tags for the new uri and message properties.
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
- 8:38 AM Changeset in webkit [44687] by
-
- 2 edits in trunk/WebCore
2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by and done with Tor Arne Vestbø.
Fix initialization of uninitialized members in FontFallbackListQt, leading
to random crashes when rendering text.
- 8:30 AM Changeset in webkit [44686] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Adding new documented API to the generated
documentation.
- docs/webkitgtk-sections.txt:
- 7:38 AM Changeset in webkit [44685] by
-
- 2 edits in trunk/WebKit/qt
2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Adam Treat.
Fix the logic for disabling the fixed layout feature, when an invalid
QSize is set.
- 7:31 AM Changeset in webkit [44684] by
-
- 4 edits in trunk
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Version bump in preparation for 1.1.10 release.
- configure.ac:
WebKit/gtk:
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update NEWS for 1.1.10 release.
- NEWS:
- 7:17 AM Changeset in webkit [44683] by
-
- 2 edits in trunk/WebCore
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25895
[Gtk] Segfault when deleting the last/only character in an entry if a11y is enabled
Use computeOffsetInContainerNode instead of the inline
offsetInContainerNode to return the caret offset, since the former
can handle all types of anchoring. Otherwise we'll hit an ASSERT
in some situations in debug builds, and crash.
- editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 4:53 AM Changeset in webkit [44682] by
-
- 12 edits2 moves in trunk/WebCore
2009-06-15 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix build break
Rename JSONObject to InspectorJSONObject
- 1:39 AM Changeset in webkit [44681] by
-
- 7 edits in trunk
2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Mark Rowe.
Reviewed by Simon Hausmann.
Reviewed by Xan Lopez.
Refactor handling of options in the build-webkit script
Options are now defined in one place, and then reused when creating
the usage help text, the arguments to GetOptions(), and when passing
the options on to the underlying port-dependent build systems.
This allows the Qt port to read the defaults for the options from the
pro file (dynamically), and to pass the options on to qmake at build.
- 12:37 AM Changeset in webkit [44680] by
-
- 2 edits in trunk/WebKitTools
Fix <https://bugs.webkit.org/show_bug.cgi?id=26312>.
Bug 26312: Multiple copies of Safari opened with WebKit nightly and Safari 3.2.3
Reviewed by Cameron Zwarich.
Skip the trampoline detection for versions of Safari < 4.0 as they don't play these
tricks, and having WebKitNightlyEnabler assume that we were in the trampoline was
preventing our LaunchServices trickery from being run. This led to fresh copies of
WebKit.app being launched when a URL or file was opened from an external application
rather than the existing instance being reused.
- WebKitLauncher/WebKitNightlyEnabler.m:
(insideSafari4OnTigerTrampoline):
(enableWebKitNightlyBehaviour):
- 12:02 AM Changeset in webkit [44679] by
-
- 1 edit in trunk/WebCore/platform/graphics/qt/FontFallbackListQt.cpp
Fix Qt build break after r44672
Jun 14, 2009:
- 11:11 PM Changeset in webkit [44678] by
-
- 4 edits5 adds in trunk/WebCore
Bug 26399: REGRESSION: java applet accessibility broken
https://bugs.webkit.org/show_bug.cgi?id=26399
- 9:46 PM Changeset in webkit [44677] by
-
- 20 edits in trunk/WebCore
2009-06-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Rename the CustomGetOwnPropertySlot and CustomPutFunction extended attributes
to DelegatingGetOwnPropertySlot and DelegatingPutFunction to more clearly describe
their functionality (customGetOwnPropertySlot and customPut member functions have
been renamed getOwnPropertySlotDelegate and putDelegate). CustomGetOwnPropertySlot
and CustomPutFunction have been repurposed to mean a complete custom implementation
of the function which is inline with other extended attributes prefixed with Custom.
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::putDelegate):
- bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::getOwnPropertySlotDelegate): (WebCore::JSDOMWindow::putDelegate):
- bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLAppletElement::putDelegate):
- bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLEmbedElement::putDelegate):
- bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLObjectElement::putDelegate):
- bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getOwnPropertySlotDelegate): (WebCore::JSHistory::putDelegate):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getOwnPropertySlotDelegate): (WebCore::JSLocation::putDelegate): (WebCore::JSLocationPrototype::putDelegate):
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::putDelegate):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
- bindings/scripts/CodeGeneratorJS.pm:
- css/CSSStyleDeclaration.idl:
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- storage/Storage.idl:
- workers/WorkerContext.idl:
- 9:36 PM Changeset in webkit [44676] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=26395 <rdar://problem/6971333> REGRESSION (r40813-r40884): No caret after going back/forward to page with focused text field
No test, since the back/forward cache is disabled in DumpRenderTree
- loader/FrameLoader.cpp: (WebCore::FrameLoader::open): Added a call to CachedPage::restore(), which was removed in r40870.
- 8:07 PM Changeset in webkit [44675] by
-
- 2 edits in trunk/WebCore
2009-06-14 Darin Adler <Darin Adler>
- editing/TextIterator.cpp: (WebCore::BitStack::push): Use named constant instead of hardcoded numbers. (WebCore::BitStack::top): Ditto.
- 7:39 PM Changeset in webkit [44674] by
-
- 9 edits2 adds in trunk
WebCore:
2009-06-14 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>
Test: fast/text/find-hidden-text.html
- editing/TextIterator.cpp: (WebCore::BitStack::BitStack): Added. (WebCore::BitStack::push): Added. (WebCore::BitStack::pop): Added. (WebCore::BitStack::top): Added. (WebCore::BitStack::size): Added. (WebCore::parentOrShadowParent): Added. Helper function for walking up the parent node chain, crossing shadow tree boundaries. (WebCore::depthCrossingShadowBoundaries): Added for use in assertions. Counts the depth of a node using the parentOrShadowParent function. (WebCore::fullyClipsContents): Added. Returns true for an element that fully clips its contents, currently defined as a box that has zero width or height and hides overflow. We can add other cases here later. (WebCore::ignoresContainerClip): Added. Returns true for an element that ignores its container clip, currently defined as an element with absolute or fixed positioning. (WebCore::pushFullyClippedState): Added. Pushes a bit on the stack indicating if the node in question fully clips its contents. (WebCore::setUpFullyClippedStack): Added. Pushes a bit for each ancestor of a node. Used when creating an iterator. (WebCore::TextIterator::TextIterator): Removed code to initialize m_inShadowContent. Call setUpFullyClippedStack. (WebCore::TextIterator::advance): Use parentOrShadowParent. Call pop when moving up to a parent node, and also one extra time when moving to a sibling node. Call pushFullyClippedState when moving to a child node, or when moving to a sibling node after the aforementioned call to pop. (WebCore::TextIterator::handleTextNode): Return early if the node is fully clipped. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Call setUpFullyClippedStack. (WebCore::SimplifiedBackwardsTextIterator::advance): Same changes as TextIterator::advance above.
- editing/TextIterator.h: Added BitStack class and added m_fullyClippedStack to both TextIterator and SimplifiedBackwardsTextIterator. Removed unneeded m_inShadowContent.
LayoutTests:
2009-06-14 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>
- fast/text/find-hidden-text-expected.txt: Added.
- fast/text/find-hidden-text.html: Added.
- fast/block/float/crash-replaced-display-block-expected.txt: Removed a space.
- fast/dom/Range/acid3-surround-contents-expected.txt: Removed a blank line.
- fast/dom/object-embed-plugin-scripting-expected.txt: Removed four spaces.
- fast/parser/badentity-expected.txt: Removed a blank line.
- http/tests/security/local-video-poster-from-remote-expected.txt: Removed a blank line.
- 4:52 PM Changeset in webkit [44673] by
-
- 3 edits in trunk/WebCore
2009-06-14 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Back out Simon's fix and replace it with a better one that doesn't needlessly destroy RenderObjects.
Use NoInherit rather than Detach for child index changes, and don't worry about other pseudo-class state
changes, since they were handled already with setNeedsStyleRecalcs on the affected objects themselves.
- dom/Element.cpp: (WebCore::Element::recalcStyle):
- dom/Node.cpp: (WebCore::Node::diff):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setChildIndex):
- 2:57 PM Changeset in webkit [44672] by
-
- 7 edits in trunk/WebCore
2009-06-14 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Move all of the mutable member variables from Font into the refcounted FontFallbackList. This makes
copying of Fonts more efficient and also effectively makes all of the mutations of a Font object happen
inside the FontFallbackList.
- WebCore.base.exp:
- platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::primaryFont): (WebCore::Font::update):
- platform/graphics/Font.h: (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing):
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch):
- platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::primarySimpleFontData): (WebCore::FontFallbackList::primaryFontData):
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
- 2:27 PM Changeset in webkit [44671] by
-
- 6 edits4 adds in trunk
2009-06-14 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix an issue noted on quirksmode.com where dynamically adding siblings does not
update :nth-child style correctly.
Test: fast/css/nth-child-dynamic.html
- dom/Node.h: Change diff() to take const RenderStyle*
- dom/Node.cpp: (WebCore::Node::diff): When comparing styles to decide whether to detach and reattach, we need to look at whether the pseudoclass-related data in the style changed (since RenderStyle::diff doesn't check this).
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getCachedPseudoStyle): (WebCore::RenderStyle::inheritedNotEqual): Make these methods const.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::styleType): (WebCore::InheritedFlags::pseudoClassStateEquivalent): Make methods const. Add new method that compares the pseudoclass-related members.
- 12:03 AM Changeset in webkit [44670] by
-
- 7 edits2 adds in trunk/SunSpider
Update V8 benchmark to version 4.
Reviewed by Cameron Zwarich.
- tests/LIST-V8:
- tests/v8-crypto.js:
- tests/v8-deltablue.js:
- tests/v8-earley-boyer.js:
- tests/v8-raytrace.js:
- tests/v8-regexp.js: Added.
- tests/v8-richards.js:
- tests/v8-splay.js: Added.
