⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 18, 2009:

10:39 PM Changeset in webkit [44843] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-18 Gavin Barraclough <​barraclough@apple.com>

Reviewed by NOBODY (Windows build fix).

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
10:06 PM Changeset in webkit [44842] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-18 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Timezone calculation incorrect in Venezuela.

​https://bugs.webkit.org/show_bug.cgi?id=26531
<rdar://problem/6646169> Time is incorrectly reported to JavaScript in both Safari 3 and Firefox 3

The problem is that we're calculating the timezone relative to 01/01/2000,
but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.
According to the spec, section 15.9.1.9 states "the time since the beginning
of the year", presumably meaning the *current* year. Change the calculation
to be based on whatever the current year is, rather than a canned date.

No performance impact.

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
10:06 PM Changeset in webkit [44841] by krit@webkit.org
  • 3 edits
    4 adds in trunk

2009-06-18 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

feOffset and objectBoundingBox
​https://bugs.webkit.org/show_bug.cgi?id=26441

If we use objectBoundingBox for primitiveUnits, the fractions given
to dx or dy of feOffset must be multiplied with the referenced objects
objectBoundingBox size.

Test: svg/filters/feOffset.svg

  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):

Test for feOffset with the primitiveUnits objectBoundingBox
and userSpaceOnUse.

  • platform/mac/svg/filters/feOffset-expected.checksum: Added.
  • platform/mac/svg/filters/feOffset-expected.png: Added.
  • platform/mac/svg/filters/feOffset-expected.txt: Added.
  • svg/filters/feOffset.svg: Added.
10:00 PM Changeset in webkit [44840] by krit@webkit.org
  • 6 edits
    8 adds in trunk

2009-06-18 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

feTile implementation missing
​https://bugs.webkit.org/show_bug.cgi?id=26419

Implementation of feTile, a pattern effect for SVG filters. It was
necessary to modify FilterEffect since source inputs need a secial
logic and we have to identify if an effect is a source input.

Tests: svg/batik/filters/feTile.svg

svg/filters/feTile.svg

  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isSourceInput):
  • platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
  • platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

Reviewed by Oliver Hunt.

Added a test of batik and a own one to check behavior of the
new feTile effect in SVG.

  • platform/mac/svg/batik/filters/feTile-expected.checksum: Added.
  • platform/mac/svg/batik/filters/feTile-expected.png: Added.
  • platform/mac/svg/batik/filters/feTile-expected.txt: Added.
  • platform/mac/svg/filters/feTile-expected.checksum: Added.
  • platform/mac/svg/filters/feTile-expected.png: Added.
  • platform/mac/svg/filters/feTile-expected.txt: Added.
  • svg/batik/filters/feTile.svg: Added.
  • svg/filters/feTile.svg: Added.
9:44 PM Changeset in webkit [44839] by krit@webkit.org
  • 4 edits
    4 adds in trunk

2009-06-18 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

feMerge implementation
​https://bugs.webkit.org/show_bug.cgi?id=26480

Added feMerge to the SVG Filter system.

Test: svg/filters/feMerge.svg

  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::uniteChildEffectSubregions): (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:

Check the feMerge implementation.

  • platform/mac/svg/filters/feMerge-expected.checksum: Added.
  • platform/mac/svg/filters/feMerge-expected.png: Added.
  • platform/mac/svg/filters/feMerge-expected.txt: Added.
  • svg/filters/feMerge.svg: Added.
7:32 PM Changeset in webkit [44838] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-06-18 Gavin Barraclough <​barraclough@apple.com>

Rubber Stamped by Mark Rowe (originally reviewed by Sam Weinig).

(Reintroducing patch added in r44492, and reverted in r44796.)

Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):

JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).

  • jit/JITStubs.cpp: (JSC::):

Add ctiOpThrowNotCaught definitions.

(JSC::JITStubs::DEFINE_STUB_FUNCTION):

Change cti_op_throw to always change its return address.

  • jit/JITStubs.h:

Add ctiOpThrowNotCaught declaration.

6:51 PM Changeset in webkit [44837] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speculative Windows build fix.

  • page/win/FrameCGWin.cpp: Add missing #include.
6:21 PM Changeset in webkit [44836] by bfulgham@webkit.org
  • 8 edits in trunk

WebCore:

2009-06-17 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Dave Levin.

​https://bugs.webkit.org/show_bug.cgi?id=26425
Final refactorings, picking up a few places where BitmapInfo
could be used.

  • page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):

WebKit/win:

2009-06-18 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Dave Levin.

Remove some boilerplate using the BitmapInfo struct.
​https://bugs.webkit.org/show_bug.cgi?id=26425

  • WebFrame.cpp: (WebFrame::spoolPages):
  • WebIconDatabase.cpp: (createDIB):
  • WebKit.vcproj/WebKit.sln:
  • WebNodeHighlight.cpp: (WebNodeHighlight::update):
  • WebView.cpp: (WebView::ensureBackingStore):
6:20 PM Changeset in webkit [44835] by Chris Fleizach
  • 4 edits
    2 adds in trunk

Bug 26522: In DOM mode, VoiceOver reads some mouseover text on web sites strangely
​https://bugs.webkit.org/show_bug.cgi?id=26522

6:18 PM Changeset in webkit [44834] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix after recent RenderTheme changes.

6:14 PM Changeset in webkit [44833] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

2009-06-18 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26460 part two
Attempt to minimize diff of following functional change by first landing
non-functional change to:

  • Make readUintX() public and static (since they will need to be once BMPImageReader is included in *ImageDecoder via composition rather than inheritance). Add wrappers in each class so callers can be simpler. In the next patch, these wrappers will be beefed up slightly and the callers will get even simpler.
  • Change direct setting of m_failed to use setFailed(), since in the next patch much of this code won't even have direct access to m_failed
  • Add a helper function in ICOImageDecoder to determine the image type instead of simply doing it inline
  • Rewrap lines that used to be <=80 cols and slipped over it during the original landing of these decoders
  • Other misc. changes, e.g. adding constructor definitions, reordering functions, changing RGBA32Buffer& to RGBA32Buffer*, etc. that have no functional effect but minimize the subsequent diff for readability
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::processFileHeader):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::getInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16Helper): (WebCore::BMPImageReader::readUint32Helper): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::getComponent): (WebCore::BMPImageReader::setI): (WebCore::BMPImageReader::setRGBA): (WebCore::BMPImageReader::fillRGBA):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::decodeImage): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::isBetterEntry): (WebCore::ICOImageDecoder::processImageType):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
3:52 PM Changeset in webkit [44832] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-06-18 Peter Kasting <​pkasting@google.com>

Fix build bustage.

  • platform/image-decoders/gif/GIFImageDecoder.h:
3:34 PM Changeset in webkit [44831] by kmccullough@apple.com
  • 11 edits in trunk

JavaScriptCore:

2009-06-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

  • Exposed functions now needed by WebCore.

WebCore:

2009-06-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

Convert intptr_t to Strings so that we don't loose bits in the
conversion to JS. Previously they were being put into 32bit ints.

  • inspector/InspectorController.cpp: Convert the String back to an intptr_t. (WebCore::InspectorController::addBreakpoint): (WebCore::InspectorController::removeBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorController.idl: Use strings in JS to avoid 32bit truncation.
  • inspector/InspectorFrontend.cpp: Make the intptr_t into a String. (WebCore::InspectorFrontend::parsedScriptSource):
  • platform/text/PlatformString.h: Implemented the necessary conversion functions to be able to convert to and from an intptr_t.
  • platform/text/String.cpp: Ditto. (WebCore::String::toIntPtrStrict): (WebCore::String::toIntPtr): (WebCore::charactersToIntPtrStrict): (WebCore::charactersToIntPtr):
  • platform/text/StringImpl.cpp: Ditto. (WebCore::StringImpl::toIntPtrStrict): (WebCore::StringImpl::toIntPtr):
  • platform/text/StringImpl.h: Ditto.
3:15 PM Changeset in webkit [44830] by jparent@chromium.org
  • 3 edits
    2 adds
    8 deletes in trunk/LayoutTests

2009-06-18 Ryosuke Niwa <​rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/insertHTML-expected.txt: Added.
  • editing/execCommand/insertHTML.html:
  • editing/execCommand/switch-list-type-expected.txt: Added.
  • editing/execCommand/switch-list-type.html:
  • platform/mac/editing/execCommand/insertHTML-expected.checksum: Removed.
  • platform/mac/editing/execCommand/insertHTML-expected.png: Removed.
  • platform/mac/editing/execCommand/insertHTML-expected.txt: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.checksum: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.png: Removed.
  • platform/mac/editing/execCommand/switch-list-type-expected.txt: Removed.
  • platform/qt/editing/execCommand/insertHTML-expected.txt: Removed.
  • platform/qt/editing/execCommand/switch-list-type-expected.txt: Removed.
3:04 PM Changeset in webkit [44829] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-06-17 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Eric Seidel.

Final cleanups in this refactoring:
(1) Move WindowsBitmap implementation from CG-specific file to

the platform-common GraphicsContextWin.cpp, since it is
equally useful on both platforms.

(2) Revise the TransformationMatrix logic as suggested by

Adam Roben in his review comments to Part #2 of this
refactoring.

  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap): (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
2:44 PM Changeset in webkit [44828] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6926859>
NPN_ConvertPoint doesn't give the right value when converting to/from NPCoordinateSpaceFlippedScreen


When inverting Y, use the height of the first screen instead of the screen the window is on.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::windowFrameChanged): (WebKit::NetscapePluginInstanceProxy::mouseEvent):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2:39 PM Changeset in webkit [44827] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-18 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez and Christian Dywan.

Add a new load status to report that the first visually non-empty
layout has been done.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
  • webkit/webkitwebframe.h:
2:39 PM Changeset in webkit [44826] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-18 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix parameters of navigation-policy-decision-requested callback,
to be correct in number and type

  • tests/testhttpbackend.c: (navigation_policy_decision_requested_cb):
2:29 PM Changeset in webkit [44825] by pkasting@chromium.org
  • 12 edits in trunk/WebCore

2009-06-18 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26460 part one
Make isSizeAvailable non-const, since it's not logically const (it
triggers lazy decoding), and simplify all the implementations (without
changing behavior; just make less verbose). Remove some other
inappropriate consts, which enables the removal of all the mutable
declarations in the decoders.

  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::setSize): Make public to avoid needing a friend declaration in the JPEG decoder, and because the ICO/BMP decoders will soon need this.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::decode):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::isSizeAvailable):
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::isSizeAvailable): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::isSizeAvailable): (WebCore::PNGImageDecoder::decode):
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::isSizeAvailable): (WebCore::XBMImageDecoder::frameBufferAtIndex): (WebCore::XBMImageDecoder::decode):
  • platform/image-decoders/xbm/XBMImageDecoder.h: Rename decodeXBM() to decode() for consistency with the JPEG/PNG decoders, and in the future the ICO/BMP decoders.
2:25 PM Changeset in webkit [44824] by jparent@chromium.org
  • 4 edits
    3 adds
    12 deletes in trunk/LayoutTests

2009-06-18 Ryosuke Niwa <​rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5207369-expected.txt: Added.
  • editing/execCommand/5207369.html:
  • editing/execCommand/5210032-expected.txt: Added.
  • editing/execCommand/5210032.html:
  • editing/execCommand/5432254-1-expected.txt: Added.
  • editing/execCommand/5432254-1.html:
  • platform/mac/editing/execCommand/5207369-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5207369-expected.png: Removed.
  • platform/mac/editing/execCommand/5207369-expected.txt: Removed.
  • platform/mac/editing/execCommand/5210032-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5210032-expected.png: Removed.
  • platform/mac/editing/execCommand/5210032-expected.txt: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5432254-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5207369-expected.txt: Removed.
  • platform/qt/editing/execCommand/5210032-expected.txt: Removed.
  • platform/qt/editing/execCommand/5432254-1-expected.txt: Removed.
2:21 PM Changeset in webkit [44823] by jparent@chromium.org
  • 4 edits
    3 adds
    12 deletes in trunk/LayoutTests

Ryosuke Niwa <​rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.

  • editing/execCommand/5142012-3-expected.txt: Added.
  • editing/execCommand/5142012-3.html:
  • editing/execCommand/5144139-1-expected.txt: Added.
  • editing/execCommand/5144139-1.html:
  • editing/execCommand/5164796-expected.txt: Added.
  • editing/execCommand/5164796.html:
  • platform/mac/editing/execCommand/5142012-3-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5142012-3-expected.png: Removed.
  • platform/mac/editing/execCommand/5142012-3-expected.txt: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.png: Removed.
  • platform/mac/editing/execCommand/5144139-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/5164796-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5164796-expected.png: Removed.
  • platform/mac/editing/execCommand/5164796-expected.txt: Removed.
  • platform/qt/editing/execCommand/5142012-3-expected.txt: Removed.
  • platform/qt/editing/execCommand/5144139-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5164796-expected.txt: Removed.
2:13 PM Changeset in webkit [44822] by jparent@chromium.org
  • 4 edits
    3 adds
    12 deletes in trunk/LayoutTests

Ryosuke Niwa <​rniwa@google.com>

Reviewed by Eric Seidel.

The following pixel tests have been converted into dumpastext tests.

This

fixes the bug 26336 partially.

  • editing/execCommand/4916583-expected.txt: Added.
  • editing/execCommand/4916583.html:
  • editing/execCommand/5119244-expected.txt: Added.
  • editing/execCommand/5119244.html:
  • editing/execCommand/5120591-expected.txt: Added.
  • editing/execCommand/5120591.html:
  • platform/mac/editing/execCommand/4916583-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4916583-expected.png: Removed.
  • platform/mac/editing/execCommand/4916583-expected.txt: Removed.
  • platform/mac/editing/execCommand/5119244-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5119244-expected.png: Removed.
  • platform/mac/editing/execCommand/5119244-expected.txt: Removed.
  • platform/mac/editing/execCommand/5120591-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5120591-expected.png: Removed.
  • platform/mac/editing/execCommand/5120591-expected.txt: Removed.
  • platform/qt/editing/execCommand/4916583-expected.txt: Removed.
  • platform/qt/editing/execCommand/5119244-expected.txt: Removed.
  • platform/qt/editing/execCommand/5120591-expected.txt: Removed.
1:47 PM Changeset in webkit [44821] by bfulgham@webkit.org
  • 6 edits in trunk/WebCore

2009-06-17 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Eric Seidel.

Move some common functions out of platform files and into
the common implementation.

​https://bugs.webkit.org/show_bug.cgi?id=26425.
Add a new platform context method (flush) so that the
getWindowsContext method can be consolidated into the common
GraphicsContextWin.cpp file.


  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::flush):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::flush):
  • platform/graphics/win/GraphicsContextCGWin.cpp: Remove getWindowContext method.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Remove getWindowContext method and fillWithClearColor methods.
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::fillWithClearColor): Moved from *CairoWin.cpp (WebCore::GraphicsContext::getWindowsContext): Moved from *CairoWin.cpp
1:44 PM Changeset in webkit [44820] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-18 Christian Dywan <​christian@twotoasts.de>

Reviewed by Gustavo Noronha.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::loadDone): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static function loadDone to emit "load-done" and update the status and update the relevent places. We missed some status notifications before.
1:30 PM Changeset in webkit [44819] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-18 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Be consistent in always using the term URI instead of URL in the
documentation of WebKitWebView signals.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
1:28 PM Changeset in webkit [44818] by ojan@chromium.org
  • 2 edits in trunk/WebCore

2009-06-18 Ojan Vafai <​ojan@chromium.org>

Reviewed by Oliver Hunt.

Remove code that I accidentally committed in r44811.

  • editing/markup.cpp: (WebCore::createMarkup):
1:25 PM Changeset in webkit [44817] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-06-18 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/6983207> Non-layer content is not re-rendered when transition
starts sometimes (with hardware acceleration).

When deciding which RenderLayers should be composited, when a layer goes into
compositing mode we repaint the old location. However, we did that before
we'd looked at all the factors that may force a layer to composite, so missed
some cases. Fix by doing the repaint once we really know whether it's going
to composite.

Test: compositing/repaint/become-overlay-composited-layer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
12:58 PM Changeset in webkit [44816] by ap@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

Reviewed by Maciej Stachowiak and Dave Levin.

​https://bugs.webkit.org/show_bug.cgi?id=26510
Add tests for authentication behavior with cross-origin XMLHttpRequest

  • http/tests/xmlhttprequest/cross-origin-authorization-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-authorization.html: Added.
  • http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-no-authorization.html: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-authorization.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-preset-authorization-frame.html: Added.
  • platform/mac-tiger/Skipped:
12:21 PM Changeset in webkit [44815] by Darin Adler
  • 1 edit in trunk/WebKitTools/ChangeLog

2009-06-18 Darin Adler <Darin Adler>

Rubber stamped by Mark Rowe.

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression tests. The close method can be called on a window that's already closed so we can't assert here.
12:19 PM Changeset in webkit [44814] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-06-18 Simon Fraser <Simon Fraser>

Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined, and
the Tiger build where QTMovieLayer does not exist.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering): (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
12:18 PM Changeset in webkit [44813] by Darin Adler
  • 12 edits in trunk

JavaScriptCore:

2009-06-17 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
​https://bugs.webkit.org/show_bug.cgi?id=26429

For marking I decided not to use gcProtect, because this is inside the engine
so it's easy enough to just do marking. And that darned gcProtect does locking!
Oliver tried to convince me to used MarkedArgumentBuffer, but the constructor
for that class says "FIXME: Remove all clients of this API, then remove this API."

  • runtime/Collector.cpp: (JSC::Heap::collect): Add a call to JSONObject::markStringifiers.
  • runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers): Added emptyIdentifier.
  • runtime/CommonIdentifiers.h: Ditto.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Initialize firstStringifierToMark to 0.
  • runtime/JSGlobalData.h: Added firstStringifierToMark.
  • runtime/JSONObject.cpp: Cut down the includes to the needed ones only. (JSC::unwrapNumberOrString): Added. Helper for unwrapping number and string objects to get their number and string values. (JSC::ReplacerPropertyName::ReplacerPropertyName): Added. The class is used to wrap an identifier or integer so we don't have to do any work unless we actually call a replacer. (JSC::ReplacerPropertyName::value): Added. (JSC::gap): Added. Helper function for the Stringifier constructor. (JSC::PropertyNameForFunctionCall::PropertyNameForFunctionCall): Added. The class is used to wrap an identifier or integer so we don't have to allocate a number or string until we actually call toJSON or a replacer. (JSC::PropertyNameForFunctionCall::asJSValue): Added. (JSC::Stringifier::Stringifier): Updated and moved out of the class definition. Added code to hook this into a singly linked list for marking. (JSC::Stringifier::~Stringifier): Remove from the singly linked list. (JSC::Stringifier::mark): Mark all the objects in the holder stacks. (JSC::Stringifier::stringify): Updated. (JSC::Stringifier::appendQuotedString): Tweaked and streamlined a bit. (JSC::Stringifier::toJSON): Renamed from toJSONValue. (JSC::Stringifier::appendStringifiedValue): Renamed from stringify. Added code to use the m_holderStack to do non-recursive stringify of objects and arrays. This code also uses the timeout checker since in pathological cases it could be slow even without calling into the JavaScript virtual machine. (JSC::Stringifier::willIndent): Added. (JSC::Stringifier::indent): Added. (JSC::Stringifier::unindent): Added. (JSC::Stringifier::startNewLine): Added. (JSC::Stringifier::Holder::Holder): Added. (JSC::Stringifier::Holder::appendNextProperty): Added. This is the function that handles the format of arrays and objects. (JSC::JSONObject::getOwnPropertySlot): Moved this down to the bottom of the file so the JSONObject class is not interleaved with the Stringifier class. (JSC::JSONObject::markStringifiers): Added. Calls mark. (JSC::JSONProtoFuncStringify): Streamlined the code here. The code to compute the gap string is now a separate function.
  • runtime/JSONObject.h: Made everything private. Added markStringifiers.

LayoutTests:

2009-06-17 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
​https://bugs.webkit.org/show_bug.cgi?id=26429

  • fast/js/JSON-stringify-expected.txt: Updated.
  • fast/js/resources/JSON-stringify.js: Changed the infinite object and infinite array tests to instead just test something a fixed number of levels deep. Otherwise we end up with an infinite loop in the test, which would lead to the slow-script dialog in the production web browser. Also raised the number from 512 to 2048 since there's no fixed limit any more.
12:14 PM EFLWebKit edited by tonikitoo@gmail.com
(diff)
12:06 PM Changeset in webkit [44812] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-06-18 Simon Fraser <Simon Fraser>

Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
11:58 AM Changeset in webkit [44811] by ojan@chromium.org
  • 6 edits
    3 adds in trunk

2009-06-17 Erik Arvidsson <​arv@chromium.org>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=15189
Adds the HTML5 input event support for textarea.


Also, moves the oninput attribute parse handling to HTMLElement so that
it can be set on any HTML element so that bubbling events can be handled
using HTML attribute handlers.

Test: fast/forms/textarea-input-event.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
11:53 AM Changeset in webkit [44810] by krit@webkit.org
  • 6 edits in trunk/WebCore

2009-06-18 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

Share code between filterEffects
​https://bugs.webkit.org/show_bug.cgi?id=26479

Share more code of filter effects. The imageBuffer creation can move to
FilterEffect ant every effect asks for the GraphicsContext. Move the
drawingRect calculation to FilterEffect.

  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingRect): (WebCore::FilterEffect::getEffectContext):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
11:52 AM Changeset in webkit [44809] by Simon Fraser
  • 14 edits in trunk/WebCore

2009-06-18 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=26499

Support hardware-accelerationed rendering of video elements.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): (WebCore::HTMLMediaElement::mediaPlayerRepaint): Just move these methods to group the render-related methods together.

(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
Call out method to ask the RenderLayerCompositor if presentation of this video
can be acclerated. It might say no, if, for example, the video has a reflection.

(WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
Fetch the GraphicsLayer from the RenderVideo that will host the movie layer.

  • html/HTMLMediaElement.h: Reordered the rendering-related methods, and added two methods related to video acceleration.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::acceleratedRenderingStateChanged): Called by the rendering system when it determines that the video must go into, or fall off of the hardware-accelerated path.

(WebCore::MediaPlayer::supportsAcceleratedRendering):
Method to say whether the media engine supports accelerated rendering.

  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): Moved.

(WebCore::MediaPlayerClient::mediaPlayerRenderingCanBeAccelerated):
(WebCore::MediaPlayerClient::mediaPlayerGraphicsLayer):
New methods to ask the client if the rendering system can support accelerated
rendering, and to get a GraphicsLayer to plug the movie layer into.

  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateInterface::acceleratedRenderingStateChanged): Forwarding methods from MediaPlayer.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Some new methods related to using a QTMovieLayer, and to simplify the rendering mode logic.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): Methods to create and destroy the QTMovieLayer.

(WebCore::MediaPlayerPrivate::currentRenderingMode):
(WebCore::MediaPlayerPrivate::preferredRenderingMode):
Methods to clarify the code that decides which of the 3 rendering modes to use.

(WebCore::MediaPlayerPrivate::setUpVideoRendering):
Changed to use the new rendering mode methods.

(WebCore::MediaPlayerPrivate::tearDownVideoRendering):
Destroy the layer if we have one.

(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
Small utility method.

(WebCore::MediaPlayerPrivate::updateStates):
Move the call to setUpVideoRendering() to before we send out the state notifications,
so that we will have created the rendering objects already.

(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
Return true if we have QTMovieLayer.

(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
We've been told that we went into or out of accelerated mode; maybe reset
the renderer, and set the layer if we have to.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): We may need to udpate compositing layers if the video went into accelerated mode.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseDirectCompositing): Add smarts to deal with video, which allows us to avoid extra backing store.

(WebCore::RenderLayerBacking::contentsBox):
Use the videoBox to use the content layer for video layers.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): Poke the RenderVideo if the state changed.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Handle an edge case when the video element itself is a stacking context
because of opacity or transform.

(WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
Allow video to throw us into compositing mode if the media engine supports it.

  • rendering/RenderLayerCompositor.h: New methods related to video.
  • rendering/RenderVideo.h:
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer): Call rendererContentChanged() to give the compositor a change to throw the video into compositing mode.

(WebCore::RenderVideo::supportsAcceleratedRendering):
(WebCore::RenderVideo::acceleratedRenderingStateChanged):
(WebCore::RenderVideo::videoGraphicsLayer):
Methods to allow the MediaPlayer to do rendering-related stuff via the media element.

11:40 AM Changeset in webkit [44808] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

Reviewed by Niko.

​https://bugs.webkit.org/show_bug.cgi?id=26385
Root SVG element is not checked on requiredFeatures, requiredExtension like other elements

Also do the isValid check for outer <svg>.

Test: svg/custom/outer-svg-unknown-feature.svg

11:08 AM Changeset in webkit [44807] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2009-06-18 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=26499

New expected results after making <video> elements get RenderLayers.

  • platform/mac/fast/replaced/border-radius-clip-expected.txt:
10:54 AM Changeset in webkit [44806] by mitz@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text

Test: fast/forms/search-vertical-alignment.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): Vertically center the

the search field's inner block.

LayoutTests:

Reviewed by Darin Adler.

  • test and updated result for <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text
  • fast/forms/search-vertical-alignment.html: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.checksum: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
9:30 AM EFLWebKit edited by tonikitoo@gmail.com
(diff)
9:28 AM EFLWebKit edited by tonikitoo@gmail.com
(diff)
8:08 AM Changeset in webkit [44805] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-06-18 Janne Koskinen <​janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

Fix compilation with Symbian WINSCW compiler, which produced
multiple definitions of the CSSPrimitiveValue conversion operators.

It turns out that they are defined inline but not declared inline.

Adding the inline keyword to the declaration fixes the build.

7:45 AM Changeset in webkit [44804] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-06-18 Friedemann Kleint <​Friedemann.Kleint@nokia.com>

Reviewed by Simon Hausmann.

Fixed MinGW compilation.

7:41 AM Changeset in webkit [44803] by Simon Hausmann
  • 4 edits in trunk

2009-06-18 Markus Goetz <​Markus.Goetz@nokia.com>

Reviewed by Simon Hausman.

Clarify in docs how to compile with debug information.

7:40 AM EFLWebKit edited by tonikitoo@gmail.com
(diff)
6:42 AM Changeset in webkit [44802] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-06-18 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] When writing an URL to the clipboard, save the corresponding title
in the mime data as well.

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL):
6:40 AM Changeset in webkit [44801] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-06-18 Jakub Wieczorek <​faw217@gmail.com>

[Qt] Fix build. Add HTMLDataGridElement.

  • WebCore.pro:
3:25 AM Changeset in webkit [44800] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-18 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix.

Add HTMLDataGridElement header and IDL to the build script.

  • GNUmakefile.am:
12:55 AM Changeset in webkit [44799] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-18 Chris Evans <​scarybeasts@gmail.com>

Reviewed by Adam Barth.

Fix 8-digit long hex entities. Fixes bug 26454
​https://bugs.webkit.org/show_bug.cgi?id=26454

Test: fast/parser/eightdigithexentity.html

  • html/HTMLTokenizer.cpp: fix off-by-ones.

LayoutTests:

2009-06-18 Chris Evans <​scarybeasts@gmail.com>

Reviewed by Adam Barth.

Added test for bug 26454 (broken 8-digit hex entities).
​https://bugs.webkit.org/show_bug.cgi?id=26454

  • fast/parser/eightdigithexentity-expected.txt: Added.
  • fast/parser/eightdigithexentity.html: Added.
12:08 AM Changeset in webkit [44798] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-18 David Levin <​levin@chromium.org>

Fix chromium linux build.

Fixes a mistake that happened during the complicated merge for
landing r44775, r44776, r44777.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::create):

Jun 17, 2009:

11:40 PM Changeset in webkit [44797] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

<rdar://problem/6974140> REGRESSION(r43849): Crash in cti_op_call_NotJSFunction when getting directions on maps.google.com

Reviewed by Gavin Barraclough

Roll out r43849 as it appears that we cannot rely on the address of
an objects property storage being constant even if the structure is
unchanged.

10:50 PM Changeset in webkit [44796] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-06-17 Gavin Barraclough <​barraclough@apple.com>

Rubber Stamped by Mark Rowe.

Fully revert r44492 & r44748 while we fix a bug they cause on internal builds <rdar://problem/6955963>.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
  • jit/JITStubs.cpp: (JSC::): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
7:37 PM Changeset in webkit [44795] by barraclough@apple.com
  • 5 edits in trunk

JavaScriptCore:

2009-06-17 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Mark Rowe.

<rdar://problem/6947426> sunspider math-cordic.js exhibits different intermediate results running 32-bit vs. 64-bit

On 64-bit, NaN-encoded values must be detagged before they can be used in rshift.

No performance impact.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift):

LayoutTests:

2009-06-17 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Mark Rowe.

Add tests to check shifts by non-constant amounts.

  • fast/js/kde/operators-expected.txt:
  • fast/js/kde/resources/operators.js:
6:49 PM Changeset in webkit [44794] by Simon Fraser
  • 12 edits in trunk

2009-06-17 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26499

First step to making video rendering be hardware-accelerated:
make <video> elements get self-painting RenderLayers, and add
an isVideo() virtual method to RenderObject.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
  • rendering/RenderObject.h: (WebCore::RenderObject::isVideo):
  • rendering/RenderVideo.h: (WebCore::RenderVideo::requiresLayer): (WebCore::RenderVideo::isVideo):
6:22 PM Changeset in webkit [44793] by bfulgham@webkit.org
  • 6 edits
    1 add in trunk/WebCore

2009-06-17 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor a few common routines in the various Windows ports
and reduce some duplicated code.

(1) Create TransformationMatrix XFORM casting operator, and

switch various XFORM structure uses to utilize it.

(2) Push concatCTM call to GraphicsContextWin now that the

TransformationMatrix can directly create XFORM (rather
than converting to CGAffineTransform/cairo_matrix_t first.)

  • WebCore.vcproj/WebCore.vcproj: Add new BitmapInfo structure.
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/GraphicsContextCairoWin.cpp:
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
6:05 PM Changeset in webkit [44792] by Simon Fraser
  • 12 edits
    6 copies
    1 add in trunk/LayoutTests

2009-06-17 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

Update results after enabling 3d rendering on SnowLeopard.

  • platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.txt.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.txt. Copy the old "mac" results to "mac-leopard" since 3d-rendering is disabled there.
  • platform/mac/fast/media/mq-transform-02-expected.checksum:
  • platform/mac/fast/media/mq-transform-02-expected.png:
  • platform/mac/fast/media/mq-transform-02-expected.txt:
  • platform/mac/fast/media/mq-transform-03-expected.checksum:
  • platform/mac/fast/media/mq-transform-03-expected.png:
  • platform/mac/fast/media/mq-transform-03-expected.txt: New "mac" results for 3d rendering enabled.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Update the results now that these tests are active.
5:41 PM Changeset in webkit [44791] by sfalken@apple.com
  • 20 edits in trunk

WebKit/win:

2009-06-17 Steve Falkenburg <​sfalken@apple.com>

Consolidate WebKit COM interfaces.
Moved IID from the highest numbered COM interface to the first interface and combined all methods.

Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.


Reviewed by Adam Roben.

  • Interfaces/IWebFrameLoadDelegate.idl:
  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl:
  • Interfaces/IWebUIDelegate.idl:
  • Interfaces/IWebUIDelegatePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebContextMenuClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebInspectorDelegate.h:
  • WebFrame.cpp:
  • WebView.cpp:

WebKitTools:

2009-06-17 Steve Falkenburg <​sfalken@apple.com>

Updated for consolidated WebKit COM interfaces.


Reviewed by Adam Roben.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.h:
  • DumpRenderTree/win/UIDelegate.cpp:
  • DumpRenderTree/win/UIDelegate.h:
  • WinLauncher/WinLauncher.h:
5:37 PM Changeset in webkit [44790] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-17 Brent Fulgham <​bfulgham@webkit.org>

Non-CG Windows build fix after @r44758.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderTheme::themeForPage):
5:32 PM Changeset in webkit [44789] by bfulgham@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

2009-06-17 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor a few common routines in the various Windows ports
and reduce some duplicated code.
​https://bugs.webkit.org/show_bug.cgi?id=26425.

Refactor use of BITMAPINFO for the new BitmapInfo structure.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/BitmapInfo.cpp: Added. (WebCore::bitmapInfoForSize): (WebCore::BitmapInfo::create): (WebCore::BitmapInfo::createBottomUp):
  • platform/win/BitmapInfo.h: Added.
  • platform/graphics/win/GraphicsContextCairoWin.cpp:
  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
  • platform/win/DragImageCGWin.cpp: (WebCore::allocImage):
  • platform/win/DragImageCairoWin.cpp: (WebCore::allocImage):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
5:28 PM Changeset in webkit [44788] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 4.0.1

Create Safari 4.0.1 release tag, consisting of version 5530.18 of WebCore and WebKit. JavaScriptCore and JavaScriptGlue remain unchanged.

5:21 PM Changeset in webkit [44787] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 4.0

Create Safari 4.0 release tag, consisting of version x530.17 of each project.

3:37 PM Changeset in webkit [44786] by Adam Roben
  • 3 edits in trunk/WebCore

Remove unnecessary 6th parameter from SOFT_LINK_OPTIONAL

Reviewed by Mark Rowe.

  • platform/graphics/win/ColorSafari.cpp: Removed the 6th parameter and an unnecessary parameter name.
  • platform/win/SoftLinking.h: Removed the unused 6th parameter.
3:10 PM Changeset in webkit [44785] by Adam Roben
  • 3 edits in trunk/WebCore

Make Settings::shouldPaintNativeControls default to true

This matches the default up in WebKit (that was changed in r43318).

Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style
form controls
<​https://bugs.webkit.org/show_bug.cgi?id=26493>

Reviewed by Darin Adler and Dave Hyatt.

No test possible since DRT always uses Mac-style form controls.

  • page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true.
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized.
2:42 PM WebKit Team edited by ben@webkit.org
(diff)
2:26 PM Changeset in webkit [44784] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/js/global-constructors-expected.txt

Update layout test results for addition of datagrid element.

2:24 PM Changeset in webkit [44783] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-17 David Levin <​levin@chromium.org>

Fix chromium Windows build.

A mistake that happened during the complicated merge for
landing r44775, r44776, r44777.

  • rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
2:17 PM EFLWebKit edited by tonikitoo@gmail.com
(diff)
2:16 PM Changeset in webkit [44782] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-06-17 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6981193> Crash in MediaControlInputElement::attachToParent

  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::attachToParent): NULL check element renderer or parent renderer. (WebCore::MediaControlInputElement::attachToParent): Ditto.
2:03 PM EFLWebKit edited by tonikitoo@gmail.com
(diff)
2:02 PM EFLWebKit edited by tonikitoo@gmail.com
(diff)
1:51 PM EFLWebKit edited by tonikitoo@gmail.com
(diff)
1:46 PM EFLWebKit edited by tonikitoo@gmail.com
(diff)
1:45 PM EFLWebKit edited by tonikitoo@gmail.com
(diff)
1:31 PM EFLWebKit edited by tonikitoo@gmail.com
(diff)
1:11 PM Changeset in webkit [44781] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

2009-06-17 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

  • security/index.html: Fix some typos.
1:05 PM Changeset in webkit [44780] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-06-17 David Hyatt <​hyatt@apple.com>

Fix Windows build. There's no HTMLDataGridElement.cpp file yet.

  • html/HTMLElementsAllInOne.cpp:
12:56 PM Changeset in webkit [44779] by weinig@apple.com
  • 2 edits
    1 move in trunk/WebKitSite

2009-06-17 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Move security policy to security/index.html so that
webkit.org/security/ works.

  • nav.inc:
  • security/index.html: Copied from security/security-policy.html.
  • security/security-policy.html: Removed.
12:33 PM Changeset in webkit [44778] by hyatt@apple.com
  • 15 edits
    2 adds in trunk

WebCore:

2009-06-17 David Hyatt <​hyatt@apple.com>

Reviewed by Adam Roben and Anders Carlsson.

Stub out the HTMLDataGridElement.

  • DerivedSources.make:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
  • html/HTMLDataGridElement.h: Added. (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::tagPriority):
  • html/HTMLDataGridElement.idl: Added.
  • html/HTMLElement.cpp: (WebCore::inlineTagList):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
  • html/HTMLTagNames.in:

LayoutTests:

2009-06-17 David Hyatt <​hyatt@apple.com>

Reviewed by Anders Carlsson.

Update window properties layout test for HTMLDataGridElement addition.

  • fast/dom/Window/window-properties-expected.txt:
12:31 PM Changeset in webkit [44777] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-17 David Levin <​levin@chromium.org>

Reviewed by NOBODY (chromium build fix).

Fix typo in previous changes.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
12:18 PM Changeset in webkit [44776] by levin@chromium.org
  • 7 edits in trunk/WebCore

2009-06-17 Albert J. Wong <​ajwong@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26148
Remove common code from RenderThemeChromiumWin that is shared with
RenderThemeChromiumSkia.

Also move supportsControlTints to RenderThemeChromiumLinux since it
is linux specific.

There are no tests changed because this just removes functions with
duplicate implementations between the base and derived classes.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::supportsControlTints):
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::systemFont): (WebCore::RenderThemeChromiumWin::paintCheckbox): (WebCore::RenderThemeChromiumWin::paintRadio): (WebCore::RenderThemeChromiumWin::paintSliderThumb): (WebCore::RenderThemeChromiumWin::caretBlinkIntervalInternal):
  • rendering/RenderThemeChromiumWin.h:
12:18 PM Changeset in webkit [44775] by levin@chromium.org
  • 5 edits in trunk/WebCore

2009-06-17 Albert J. Wong <​ajwong@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26148
Move RenderThemeChromiumSkia into its own file. This is purely a code move.

  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::): (WebCore::setSizeIfAuto): (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::brightenColor): (WebCore::paintButtonLike): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
  • rendering/RenderThemeChromiumSkia.h: (WebCore::RenderThemeChromiumSkia::supportsControlTints):
12:17 PM Changeset in webkit [44774] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-06-17 Albert J. Wong <​ajwong@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26148
Extract RenderThemeChromiumSkia out of RenderThemeChromiumLinux. This
is mostly a code shuffle. The non-suffle changes are:

1) Creation of a caretBlinkIntervalInternal.
2) Moving of some inline functions into the implementation files.
3) Changing of defaultGUIFont into a static class constant from a

static function. Also the type is changed to String.

4) Changing of defaultFontSize into a static class constant from a

static variable in the file scope.

5) The static supportsFocus function was collapsed into

supportsFocusRing.

6) Split the extraDefaultStyleSheet into Skia and Linux versions.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::systemColor): (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
  • rendering/RenderThemeChromiumLinux.h:
12:07 PM Changeset in webkit [44773] by weinig@apple.com
  • 2 edits
    3 adds in trunk/WebKitSite

2009-06-13 Sam Weinig <​sam@webkit.org>

Reviewed by Timothy Hatcher.

Add WebKit Security Policy and member list of the WebKit Security Group.

  • nav.inc:
  • security: Added.
  • security/security-group-members.html: Added.
  • security/security-policy.html: Added.
12:02 PM Changeset in webkit [44772] by Adam Roben
  • 3 edits in trunk/WebCore

Add a SOFT_LINK_OPTIONAL macro

This macro is useful when soft-linking functions that are present in
only some versions of a particular library (e.g., APIs added in
Windows Vista that aren't available on Windows XP).

Reviewed by Ada Chan.

  • platform/graphics/win/ColorSafari.cpp: (WebCore::focusRingColor): Use the SoftLinking.h macros instead of doing the soft-link ourselves. Also removed an unused call to focusRingColor.isValid().
  • platform/win/SoftLinking.h: Added SOFT_LINK_OPTIONAL.
11:25 AM Changeset in webkit [44771] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-17 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Gustavo Noronha Silva.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26470.
The use of zero-width or zero-height rectangles in generating
gradients caused Windows Cairo to crash, and webkitgtk to
produce invalid images.

11:22 AM Changeset in webkit [44770] by ojan@chromium.org
  • 2 edits in trunk/WebCore

2009-06-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by NOBODY (OOPS!).

If loading a font fails because of the sandbox, we ask the browser process to
try to load it by calling ensureFontLoaded. If it still fails after
ensureFontLoaded, we hit a ASSERT_NOT_REACHED.

This case happens once in a while during browser shutdown. The browser will
queue a message to the renderer to shutdown, and will then stop answering sync
messages from the renderer. If the renderer is still loading a page during this
time, it might try to call the browser process to ask to load a font. The
browser process will ignore the request, and the font will fail to load, even
after the second try.

This is unfortunate, but there is no real risk here, since the renderer will be
going away as soon as it processes another message.

This can't be layout tested as it depends on the sandbox.

​https://bugs.webkit.org/show_bug.cgi?id=26484

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter):
11:21 AM Changeset in webkit [44769] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-06-17 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=26482
<rdar://problem/6978590> When setting playback rate to 0, the audio element stops
playing (doesn't resume later)

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setRate): Ditto.
10:13 AM Changeset in webkit [44768] by Adam Roben
  • 2 edits in trunk/WebCore

Add all the generated JS*.cpp files back to WebCore.vcproj

They are not compiled by the vcproj directly. Instead they are
compiled as part of DerivedSources.cpp. Having them listed in the
vcproj makes them be included in Project Find, etc.

Rubber-stamped in advance by Steve Falkenburg.

  • WebCore.vcproj/WebCore.vcproj:
10:01 AM Changeset in webkit [44767] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-17 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Fisher.

Don't fire redundant 'change' events for a file upload form.
​https://bugs.webkit.org/show_bug.cgi?id=26471

  • platform/FileChooser.cpp: (WebCore::FileChooser::chooseFiles): Suppress change event if the existing selected files and the incoming selected files are equal. (WebCore::FileChooser::chooseIcon): Returns 0 if there is no selected files.
9:45 AM Changeset in webkit [44766] by treat@webkit.org
  • 4 edits in trunk

2009-06-17 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.

9:39 AM Changeset in webkit [44765] by treat@webkit.org
  • 15 edits in trunk

2009-06-17 George Staikos <​george.staikos@torchmobile.com>

Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.

8:54 AM Changeset in webkit [44764] by Adam Roben
  • 3 edits in trunk/LayoutTests

Fix Skipped file format after r44519

  • platform/qt/Skipped:
  • platform/win/Skipped: Removed bogus ": Added."s in these files.
8:42 AM Changeset in webkit [44763] by Adam Roben
  • 5 edits in trunk/WebCore

Speculative Mac build fix

  • page/Page.h: Forward-declare RenderTheme instead of including RenderTheme.h so that we don't need to make RenderTheme.h a private header for WebKit's benefit.
  • editing/SelectionController.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderObject.cpp: Added #includes of RenderTheme.h.
8:32 AM Changeset in webkit [44762] by Adam Roben
  • 2 edits in trunk/WebCore

Speculative Mac build fix

  • rendering/RenderThemeMac.mm: (WebCore::RenderTheme::create): Added.
8:26 AM Changeset in webkit [44761] by Adam Roben
  • 2 edits in trunk/WebCore

Speculative Mac build fix

  • rendering/RenderThemeMac.mm: (WebCore::RenderTheme::themeForPage): Remove the name of an unused parameter.
8:14 AM Changeset in webkit [44760] by Adam Roben
  • 2 edits in trunk/WebCore

Speculative Mac build fix

  • page/Page.cpp: (WebCore::Page::Page): Change the initializer order to match the declaration order.
7:52 AM Changeset in webkit [44759] by Adam Roben
  • 3 edits in trunk/WebCore

2009-06-16 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Follow up to bug ​https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page

Make the Qt implementation of RenderTheme create a theme per page,
and use the QStyle associated with the view of each page, in order
to make the QWidget setStyle() method work as advertised.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::qStyle): (WebCore::findFrameLineWidth): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::adjustRepaintRect): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::setButtonPadding): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::setPopupPadding):
  • platform/qt/RenderThemeQt.h:
7:52 AM Changeset in webkit [44758] by Adam Roben
  • 39 edits in trunk

2009-06-16 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Dave Hyatt and Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page

Create a different RenderTheme per page, so that RenderTheme has
access to page specific theming. This is needed for the Qt port, as Qt
supports setting the theme (style) per widget.

This change was suggested and discussed with Dave Hyatt.

More detailed:

1) Create a theme per page or one global one, depending on the needs

of the platform.

2) Add an accesser to the theme from RenderObject.
3) Change all uses of the theming to access the theme through

RenderObject, using the global default theme as fallback, when the
document of RenderObject has no page.
When we don't have access to a RenderObject, use the default theme.

4) Modify all RenderTheme platform implementations to work with the

above changes, still creating only one global theme.

2:11 AM Changeset in webkit [44757] by barraclough@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-06-17 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com

Remove PropertySlot::putValue - PropertySlots should only be used for getting,
not putting. Rename JSGlobalObject::getOwnPropertySlot to hasOwnPropertyForWrite,
which is what it really was being used to ask, and remove some other getOwnPropertySlot
& getOwnPropertySlotForWrite methods, which were unused and likely to lead to confusion.

  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::hasOwnPropertyForWrite):
  • runtime/JSObject.h:
  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/PropertySlot.h:

WebCore:

2009-06-17 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com

JSDOMWindowCustom was using PropertySlot::putValue, however this interface
appears to be fundaementally incorrect - PropertySlots are only used to get
values, all puts use PutPropertySlot. However PutPropertySlot cannot be
used in the fashion desired here - it only reports the caching type of a
write that has been performed.

(This caused a bug where the put should have triggered a transition, and
failed to do so.)

Removing the faulty case from the optimization leads to a ~0.5% progression
on in-browser SunSpider (presumably the very first case was not being hit
often, and the simplification here is beneficial).

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::put):
1:48 AM Changeset in webkit [44756] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-06-17 Markus Goetz <​Markus.Goetz@nokia.com>

Reviewed by Simon Hausmann.

QWebPage: Don't call supportsSsl()

This stops QWebPage from loading the OpenSSL libs,
certificates etc. when they are not needed for the non-HTTPS case.

Loading the SSL libraries can be a very slow operation.

12:41 AM Changeset in webkit [44755] by levin@chromium.org
  • 8 edits
    3 deletes in trunk

WebCore:

2009-06-17 David Levin <​levin@chromium.org>

Reviewed by NOBODY, layout tests fix.

​https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.

Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.

  • dom/Document.cpp: (WebCore::Document::detach):
  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/Scrollbar.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
  • rendering/RenderScrollbar.h:

LayoutTests:

2009-06-17 David Levin <​levin@chromium.org>

Reviewed by NOBODY, layout tests fix.

​https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.

Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.

  • scrollbars/resources/page-with-custom-scrollbars.html: Removed.
  • scrollbars/scrollbar-crash-on-refresh-expected.txt: Removed.
  • scrollbars/scrollbar-crash-on-refresh.html: Removed.
Note: See TracTimeline for information about the timeline view.