⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 20, 2009:

11:19 PM Changeset in webkit [44910] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-06-20 Darin Adler <Darin Adler>

  • platform/gtk/Skipped: Skip some new tests.
11:15 PM Changeset in webkit [44909] by Darin Adler
  • 2 edits in trunk/WebKit/win

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
10:42 PM Changeset in webkit [44908] by alice.liu@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2009-06-19 Alice Liu <​alice.liu@apple.com>

Fix ​https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Can't test this bug with an automated layout test since it requires b/f caching

  • manual-tests/animated-gif-bfcache-crash.html: Added.
  • manual-tests/resources/containsAnimatedGif.html: Added.

Adding checks for hostWindow() since there is no guarantee that the Page is alive

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::wheelEvent):

LayoutTests:

2009-06-19 Alice Liu <​alice.liu@apple.com>

Fix ​https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html

  • http/tests/misc/resources/animated-gif-with-offsets.gif: Added.
7:43 PM Changeset in webkit [44907] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

Roll out the Windows portion of r44905 as it broke the build.

7:05 PM Changeset in webkit [44906] by weinig@apple.com
  • 6 edits in trunk

WebCore:

2009-06-20 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Barth.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26554
Shadowing of top and parent

  • page/DOMWindow.idl:

LayoutTests:

2009-06-20 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Barth.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=26554

Test writing to parent and top.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
4:07 PM Changeset in webkit [44905] by Darin Adler
  • 4 edits in trunk/WebKit

WebKit/mac:

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.

WebKit/win:

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
2:57 PM Changeset in webkit [44904] by jmalonzo@webkit.org
  • 6 edits in trunk

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Implement DRT XSS auditor support
​https://bugs.webkit.org/show_bug.cgi?id=26571

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
2:56 PM Changeset in webkit [44903] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-20 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

webkit_web_back_forward_list_add_item() should add a ref for the history item
​https://bugs.webkit.org/show_bug.cgi?id=26517

Add a ref to the WebHistoryItem when it's added to the back
forward list through webkit_web_back_forward_list_add_item.
This keeps the history item alive and prevents pywebkitgtk from
crashing

  • tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_add_item):
2:54 PM Changeset in webkit [44902] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

Fix <​https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

Reviewed by Dan Bernstein.

We allow selections to begin within an element that has -webkit-user-select: none set,
unless the element is draggable as dragging should take priority over starting a selection.

Test: editing/selection/user-drag-element-and-user-select-none.html

  • dom/Node.cpp:

(WebCore::Node::canStartSelection):

Test for <​https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

  • editing/selection/user-drag-element-and-user-select-none-expected.txt: Added.
  • editing/selection/user-drag-element-and-user-select-none.html: Added.
1:34 PM Changeset in webkit [44901] by Darin Adler
  • 5 edits in trunk

WebCore:

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
​https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): When entering a text control, start at the top of the shadow tree (by calling shadowTreeRootNode). Also remove assumption that innerTextElement will never be 0 since RenderTextControl doesn't really guarantee this.

LayoutTests:

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
​https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/selection/find-in-text-control-expected.txt: Updated to expect finding text in <input type="text"> and <input type="search">, but not in <input type="password">.
  • editing/selection/find-in-text-control.html: Added tests for <input> elements as well as <textarea> elements. Also tweaked result output format to accomodate multiple text nodes.
11:06 AM Changeset in webkit [44900] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix namespace comment in SegmentedVector.h

  • wtf/SegmentedVector.h: Updated namespace comment to reflect new namespace after r44897.
6:27 AM Changeset in webkit [44899] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-20 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<​https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

An Iterator added for SegmentedVector. Currently
only the pre ++ operator is supported.

  • wtf/SegmentedVector.h: (WTF::SegmentedVectorIterator::~SegmentedVectorIterator): (WTF::SegmentedVectorIterator::operator*): (WTF::SegmentedVectorIterator::operator->): (WTF::SegmentedVectorIterator::operator++): (WTF::SegmentedVectorIterator::operator==): (WTF::SegmentedVectorIterator::operator!=): (WTF::SegmentedVectorIterator::operator=): (WTF::SegmentedVectorIterator::SegmentedVectorIterator): (WTF::SegmentedVector::alloc): (WTF::SegmentedVector::begin): (WTF::SegmentedVector::end):
6:20 AM Changeset in webkit [44898] by kov@webkit.org
  • 3 edits
    1 add in trunk

2009-06-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Initial test case for loading statuses.

  • tests/testloading.c: Added. (load_finished_cb): (status_changed_cb): (test_loading_status): (main):
6:14 AM Changeset in webkit [44897] by ddkilzer@apple.com
  • 8 edits
    1 move in trunk/JavaScriptCore

2009-06-20 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<​https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

Move SegmentedVector to /wtf subdirectory
and change "namespace JSC" to "namespace WTF"

Additional build file updates by David Kilzer.

  • GNUmakefile.am: Updated path to SegmentedVector.h.
  • JavaScriptCore.order: Updated SegmentedVector namespace from JSC to WTF in mangled C++ method name.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to bytecompiler\SegmentedVector.h.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to wtf\SegmentedVector.h.
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved SegmentedVector.h definition from bytecompiler subdirectory to wtf subdirectory.
  • bytecompiler/BytecodeGenerator.h: Updated #include path to
SegmentedVector.h and prepended WTF
namespace to its use.
  • parser/Lexer.h: Ditto.
  • wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h. (WTF::SegmentedVector::SegmentedVector): (WTF::SegmentedVector::~SegmentedVector): (WTF::SegmentedVector::size): (WTF::SegmentedVector::at): (WTF::SegmentedVector::operator[]): (WTF::SegmentedVector::last): (WTF::SegmentedVector::append): (WTF::SegmentedVector::removeLast): (WTF::SegmentedVector::grow): (WTF::SegmentedVector::clear): (WTF::SegmentedVector::deleteAllSegments): (WTF::SegmentedVector::segmentExistsFor): (WTF::SegmentedVector::segmentFor): (WTF::SegmentedVector::subscriptFor): (WTF::SegmentedVector::ensureSegmentsFor): (WTF::SegmentedVector::ensureSegment):
5:34 AM Changeset in webkit [44896] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-20 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Jan Alonzo.

Fix the ordering in which the new load status goes into the enum
to avoid ABI breakage.

  • webkit/webkitwebframe.h:
2:48 AM Changeset in webkit [44895] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-20 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by NOBODY.

Speculative Qt build fix - add HTMLDataGridColElement to the build script.

  • WebCore.pro:
2:20 AM Changeset in webkit [44894] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-06-19 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26561

Remove a memcpy by retrieving the already existing copy of a string
instead of making a new one.

  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::source):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::source):
1:11 AM Changeset in webkit [44893] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-20 Xan Lopez <​xlopez@igalia.com>

Skip new accessibility test, we still lack and accessibilityController.

  • platform/gtk/Skipped:
1:00 AM Changeset in webkit [44892] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-20 Xan Lopez <​xlopez@igalia.com>

We don't seem to support these new HTTP tests either, skip them.

  • platform/gtk/Skipped:
12:53 AM Changeset in webkit [44891] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-20 Xan Lopez <​xlopez@igalia.com>

Skip test that requires eventSender.

  • platform/gtk/Skipped:

Jun 19, 2009:

11:21 PM Changeset in webkit [44890] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2009-06-19 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Steve Falkenburg.

​https://bugs.webkit.org/show_bug.cgi?id=26494
Bug 26494: RenderTheme::themeForPage reads from Settings before it has
been initialized by WebKit

Get the shouldPaintNativeControls preference and update the settings
before initializing the page, as the page depends on it after the
themeForPage change.

  • WebView.cpp: (WebView::initWithFrame):
6:29 PM Changeset in webkit [44889] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

2009-06-19 Gavin Barraclough <​barraclough@apple.com>

Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).

  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::checkStructure):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_get_by_val):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
6:29 PM Changeset in webkit [44888] by Darin Adler
  • 2 edits in trunk/WebKitTools

2009-06-19 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: More renaming ideas.
6:19 PM Changeset in webkit [44887] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-06-19 Gavin Barraclough <​barraclough@apple.com>

Reviewed by NOBODY (Windows build fix).

  • jit/JIT.h:
  • jit/JITInlineMethods.h:
6:07 PM Changeset in webkit [44886] by barraclough@apple.com
  • 12 edits in trunk/JavaScriptCore

2009-06-19 Gabor Loki <​loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Reorganize ARM architecture specific macros.
Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).

Bug 24986: ARM JIT port
<​https://bugs.webkit.org/show_bug.cgi?id=24986>

  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
5:52 PM Changeset in webkit [44885] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/ChangeLog

Fixed the changelog, copied the same thing into both on accident.

5:49 PM Changeset in webkit [44884] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-06-19 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix armv7 JIT build issues.

Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.

  • Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
  • Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
5:35 PM Changeset in webkit [44883] by bweinstein@apple.com
  • 7 edits
    1 add in trunk

2009-06-19 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Steve Falkenburg.


​https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:

2009-06-19 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Steve Falkenburg.


​https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7


The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.


Unable to add tests to simulate touch behavior/gestures.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp:
5:27 PM Changeset in webkit [44882] by bfulgham@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

2009-06-19 Ryosuke Niwa <​rniwa@google.com>

Reviewed by Maciej Stachowiak.

This fixs the bug 26361. The original test case did not invoke the event that
triggered the actual test. This patch adds code to invoke this event, and also
converts it from a pixel test to a dumpAsText test.

4:54 PM Changeset in webkit [44881] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Fixed a build error, which only shows up in the i386 compile

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
4:35 PM Changeset in webkit [44880] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-06-19 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.

<rdar://problem/6988385> REGRESSION: In full page video player, movie's
video track becomes detached from its controller.

When in the media document, the MediaPlayer should not report that it
is capable of hardware acceleration, because it renders via a QTMovieView
which is already accelerated.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
4:14 PM Changeset in webkit [44879] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Adding XSSAuditor.cpp to the wx build.

3:43 PM Changeset in webkit [44878] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=26544

If I am doing a Matrix hardware animation and any matrix is singular, I revert to software.
This is not really testable, since we can't see what the hardware animation is doing.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
3:32 PM Changeset in webkit [44877] by ggaren@apple.com
  • 5 edits in trunk/WebCore

2009-06-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


An additional fix for Bug 26532: Native functions do not correctly unlink
from optimised callsites when they're collected
<​https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385>

Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame
accessors, so the type of object you get to wrap a function is the same,
regardless of whether the access to the function is cross-frame.


This is faster and more idiomatic than what we had before. It also would
have avoided Bug 26532 because it would have prevented a conflicting
PrototypeFunction from being allocated to wrap postMessage, where a
NativeFunctionWrapper had been allocated previously.


  • bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
  • bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
3:23 PM Changeset in webkit [44876] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-06-19 Simon Fraser <Simon Fraser>

Reviewed by John Sullivan

<rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent

Fix a crash that could occur in complex content due to timing issues
when doing a partial layer tree rebuild which is required when painting;
setCompositingParent() could be called with a parent which has not been made
compositing yet.

3:16 PM Changeset in webkit [44875] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-06-19 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Build fix. Adding missing HTMLDataGrid* files to the build.

  • GNUmakefile.am:
2:49 PM Changeset in webkit [44874] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

2009-06-19 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26460 part three
Make BMPImageReader a standalone class that is used by ICOImageDecoder
and BMPImageDecoder to decode individual BMPs within a file. These
decoders now inherit directly from ImageDecoder.


This also makes these decoders decode on-demand in isSizeAvailable() and
frameBufferAtIndex(), like the other decoders, instead of when setData()
is called, like before. This should provide a speedup on pages
containing BMPs that aren't immediately onscreen.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::processFileHeader):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): (WebCore::BMPImageReader::setFailed):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::setBuffer): (WebCore::BMPImageReader::setData): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::setRGBA):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): (WebCore::ICOImageDecoder::processImageType):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
2:31 PM Changeset in webkit [44873] by treat@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-06-19 Adam Treat <​adam.treat@torchmobile.com>

Blind attempt at build fix.

2:09 PM Changeset in webkit [44872] by hyatt@apple.com
  • 1 add in trunk/WebCore/html/HTMLDataGridElement.cpp

Add missed file.

2:07 PM Changeset in webkit [44871] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-19 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Inherits CallIdentifier struct from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.

  • wtf/HashCountedSet.h:
1:57 PM Changeset in webkit [44870] by treat@webkit.org
  • 6 edits
    6 adds in trunk

2009-06-19 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=26540
Currently the SunSpider test driver lacks an option to run a test suite that
will test JavaScriptCore parsing performance only. This patch adds just such
a test suite and option to SunSpider as well as the jsc test shell. I've included
three large javascript source files found in the wild: jquery, mootools and prototype.
Combined with the concatenation of all three, these form a new testsuite to measure
and test pure JavaScriptCore parsing performance.

1:38 PM Changeset in webkit [44869] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2009-06-19 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26555

Fix the Chromium canary bot. Turns out ScriptSourceCode doesn't have
the same API in V8 and JSC.

  • WebCore/bindings/js/ScriptController.cpp:
  • WebCore/bindings/js/ScriptSourceCode.h:
  • WebCore/bindings/v8/ScriptController.cpp:
  • WebCore/page/XSSAuditor.cpp:
  • WebCore/page/XSSAuditor.h:
1:30 PM Changeset in webkit [44868] by bfulgham@webkit.org
  • 3 edits
    1 add in trunk

009-06-19 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.


Inherits HashCountedSet class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.

  • wtf/HashCountedSet.h:
1:17 PM Changeset in webkit [44867] by hyatt@apple.com
  • 16 edits
    3 adds in trunk

WebCore:

2009-06-19 David Hyatt <​hyatt@apple.com>

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColElement.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAttributeNames.in:
  • html/HTMLDataGridColElement.cpp: Added. (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::label): (WebCore::HTMLDataGridColElement::setLabel): (WebCore::HTMLDataGridColElement::type): (WebCore::HTMLDataGridColElement::setType): (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection): (WebCore::HTMLDataGridColElement::selected): (WebCore::HTMLDataGridColElement::setSelected):
  • html/HTMLDataGridColElement.h: Added. (WebCore::HTMLDataGridColElement::endTagRequirement): (WebCore::HTMLDataGridColElement::tagPriority):
  • html/HTMLDataGridColElement.idl: Added.
  • html/HTMLDataGridElement.h:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

LayoutTests:

2009-06-19 David Hyatt <​hyatt@apple.com>

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=26547


Implement the IDL interface for HTMLDataGridColELement.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
1:09 PM Changeset in webkit [44866] by treat@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-06-19 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=26558
Declare these symbols extern for WINCE as they are provided by libce.

  • runtime/DateConstructor.cpp:
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
12:54 PM Changeset in webkit [44865] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-19 Chris Evans <​scarybeasts@gmail.com>

Reviewed by Eric Seidel.

There is no new test because this cannot be tested deterministically.
I've not been able to cause a crash at all in the test framework, but
I have verified that this is happening in the wild and that the patch
fixes the likely cause in the debugger.

  • loader/TextResourceDecoder.cpp: careful not to iterate off the end of our input buffer looking for the end of the comment.
12:37 PM Changeset in webkit [44864] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

12:35 PM Changeset in webkit [44863] by mrowe@apple.com
  • 1 copy in tags/Safari-6531

New tag.

11:48 AM Changeset in webkit [44862] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/6988973> ScopeChain leak in interpreter builds

Reviewed by Maciej Stachowiak

Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.

11:25 AM Changeset in webkit [44861] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-06-19 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26536

Fix external-script-URL-location.html and
write-external-script-open.html LayoutTests.

implicitOpen is called from several places. We need to setXSSAuditor
each time, so I moved the call inside implicitOpen.

  • dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::implicitOpen):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
11:22 AM Changeset in webkit [44860] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-19 Kent Tamura <​tkent@chromium.org>

Reviewed by David Levin.

Use WebCore::multipleFileUploadText() in Chromium to fix a problem
that Chromium shows only the first filename even if a user selects
multiple files for <input type=file multiple>.
<​https://bugs.webkit.org/show_bug.cgi?id=26502>

  • platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth):
11:14 AM Changeset in webkit [44859] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d

Test: editing/selection/move-by-line-005.html

The root cause of this bug was searchAheadForBetterMatch() continuing
past the first rendered text object after the given object. While we
want to skip non-rendered text and empty containers, when we encounter
rendered text object, we must return a text box for that object.

  • dom/Position.cpp: (WebCore::searchAheadForBetterMatch):

LayoutTests:

Reviewed by Dave Hyatt.

  • text for <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
  • editing/selection/move-by-line-005-expected.txt: Added.
  • editing/selection/move-by-line-005.html: Added.
10:46 AM Changeset in webkit [44858] by jshin@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2009-06-18 Jungshik Shin <​jshin@chromium.org>

Reviewed by David Levin

​https://bugs.webkit.org/show_bug.cgi?id=25657

Chromium Linux port does not handle non-BMP characters properly.
It's fixed with a 'UTF-16 iterator macro' to extract Unicode
codepoints out of a UTF-16 input string.

A manual test is added for non-BMP character rendering,
which we can use until a small freely-distributable font
covering non-BMP is added to the Webkit source tree.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • manual-tests/non-bmp.html: Added.
10:01 AM Changeset in webkit [44857] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-19 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=26543
Windows CE uses 'GetLastError' instead of 'errno.'

  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
9:52 AM Changeset in webkit [44856] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Anders Carlsson.

  • update test results after r44806
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
8:47 AM Changeset in webkit [44855] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-06-19 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

V8 Bindings: return proper state from the script stack.

​https://bugs.webkit.org/show_bug.cgi?id=26512

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
8:34 AM Changeset in webkit [44854] by jberlin@apple.com
  • 2 edits in trunk/WebCore

2009-06-19 Jessie Berlin <​jberlin@apple.com>

Reviewed by Simon Fraser.

Windows build fix.


  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
7:28 AM Changeset in webkit [44853] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

2009-06-19 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Simon Hausmann.
Build fix after 44825.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::isSizeAvailable):
  • platform/graphics/qt/ImageDecoderQt.h:
5:18 AM Changeset in webkit [44852] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-06-19 Daniel Teske <​qt-info@nokia.com>

Reviewed by Simon Hausmann.

Remove warnings for QString() constructions from const char *

By explicitly wrapping it with QLatin1String() / QLatin1Char()

2:58 AM Changeset in webkit [44851] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-15 Andre Pedralho <​andre.pedralho@openbossa.org>

Reviewed by Tor Arne Vestbø.

Only pass --makeargs along if an argument is given.

2:23 AM Changeset in webkit [44850] by oliver@apple.com
  • 6 edits in trunk

2009-06-18 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Oliver Hunt.

Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
<​https://bugs.webkit.org/show_bug.cgi?id=26426>

Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
The original number cannot be represented by mantissa of float
(23bit) so that it caused some error.

Test: fast/canvas/image-object-in-canvas.html:

  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
2:06 AM Changeset in webkit [44849] by abarth@webkit.org
  • 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp

Fix copy/paste error.

1:57 AM Changeset in webkit [44848] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-06-19 abarth <​abarth@webkit.org>

Unreviewed attempt to fix the Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
1:29 AM Changeset in webkit [44847] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-19 Adam Barth <​abarth@webkit.org>

Unreviewed attempt to fix Windows build.

  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
1:12 AM Changeset in webkit [44846] by abarth@webkit.org
  • 35 edits
    7 adds in trunk

WebCore:

2009-06-18 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26199

Added an experimental reflective XSS filter. The filter is disabled by
default.

Test: http/tests/security/xssAuditor/script-tag.html

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::xssAuditor):
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Tokenizer.h: (WebCore::Tokenizer::xssAuditor): (WebCore::Tokenizer::setXSSAuditor): (WebCore::Tokenizer::Tokenizer):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::requestObject):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setXSSAuditorEnabled):
  • page/Settings.h: (WebCore::Settings::xssAuditorEnabled):
  • page/XSSAuditor.cpp: Added. (WebCore::isControlCharacter): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::~XSSAuditor): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h: Added. (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::setXSSAuditorEnabled):

WebKit/mac:

2009-06-18 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isXSSAuditorEnabled]): (-[WebPreferences setXSSAuditorEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-06-18 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26199

Added preference to enable the XSSAuditor.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isXSSAuditorEnabled): (WebPreferences::setXSSAuditorEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKitTools:

2009-06-18 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26199

Add support for testing the XSSAuditor.

  • DumpRenderTree/LayoutTestController.cpp: (setXSSAuditorEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setPopupBlockingEnabled):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

2009-06-18 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26199

Added a basic test for the XSSAuditor.

  • http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
  • http/tests/security/xssAuditor/script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag.html: Added.
12:59 AM Changeset in webkit [44845] by levin@chromium.org
  • 3 edits in trunk/JavaScriptCore

2009-06-19 David Levin <​levin@chromium.org>

Reviewed by NOBODY (Windows build fix).

Add export for Windows corresponding to OSX export done in r44844.

12:10 AM Changeset in webkit [44844] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<​https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>

Reviewed by Gavin "Viceroy of Venezuela" Barraclough.

We need to make sure that each native function instance correctly unlinks any references to it
when it is collected. Allowing this to happen required a few changes:

  • Every native function needs a codeblock to track the link information
  • To have this codeblock, every function now also needs its own functionbodynode so we no longer get to have a single shared instance.
  • Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode
Note: See TracTimeline for information about the timeline view.