⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 21, 2009:

11:35 PM Changeset in webkit [44931] by oliver@apple.com
  • 6 edits in trunk

Bug 26592: Support standard toJSON functions
<​https://bugs.webkit.org/show_bug.cgi?id=26592>

Reviewed by Darin Adler

Add support for the standard Date.toJSON function.

11:17 PM Changeset in webkit [44930] by Darin Adler
  • 4 edits in trunk/WebCore

2009-06-21 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
​https://bugs.webkit.org/show_bug.cgi?id=25425

  • bindings/scripts/CodeGeneratorJS.pm: Tweaked mechanism for includes to be a bit more consistent and to make SVGElement.h be included in the header rather than in every implementation file that includes the header. Added code to use getAttribute and setAttribute directly when the [Reflect] extended attribute is used.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • html/HTMLElement.idl: Used [Reflect] for all the attributes in this class that reflect content attributes. Restricting this to one class for now to keep the patch small and start out slowly.
10:08 PM Changeset in webkit [44929] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Bug 26594: JSC needs to support Date.toISOString
<​https://bugs.webkit.org/show_bug.cgi?id=26594>

Reviewed by Sam Weinig

Add support for Date.toISOString.

9:59 PM Changeset in webkit [44928] by weinig@apple.com
  • 7 edits
    3 adds in trunk

WebCore:

2009-06-21 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.

Test: fast/dom/event-attribute-availability.html

  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/Node.idl:

LayoutTests:

2009-06-21 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.

  • fast/dom/event-attribute-availability-expected.txt: Added.
  • fast/dom/event-attribute-availability.html: Added.
  • fast/dom/resources/event-attribute-availability.js: Added.
6:39 PM Changeset in webkit [44927] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

WebCore:

2009-06-21 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=26580


Fix to enable XSSAuditor on child windows.


Test: http/tests/security/xssAuditor/link-opens-new-window.html


  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
  • page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled. Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation to query Settings.

LayoutTests:

2009-06-21 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.


Test for ​https://bugs.webkit.org/show_bug.cgi?id=26580


Tests that XSSAuditor (if enabled) prevents script execution in child window.

  • http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
  • http/tests/security/xssAuditor/link-opens-new-window.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Added.
5:23 PM Changeset in webkit [44926] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

  • make repaint tests more reliable when run in Safari
  • fast/repaint/resources/repaint.js: (runRepaintTest): Increased the timeout from 0 to 100, to ensure that painting occurs once before repaintTest() is called.
5:03 PM Changeset in webkit [44925] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).

Reviewed by Sam Weinig.

  • WebKitLauncher/WebKitNightlyEnablerSparkle.m:

(userAgentStringForSparkle):
(initializeSparkle):

4:32 PM Changeset in webkit [44924] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix build by removing dead code.

4:02 PM Changeset in webkit [44923] by oliver@apple.com
  • 7 edits
    3 adds in trunk

Bug 26587: Support JSON.parse
<​https://bugs.webkit.org/show_bug.cgi?id=26587>

Reviewed by Darin Adler and Cameron Zwarich.

Extend the LiteralParser to support the full strict JSON
grammar, fix a few places where the grammar was incorrectly
lenient. Doesn't yet support the JSON.parse reviver function
but that does not block the JSON.parse functionality itself.

3:46 PM Changeset in webkit [44922] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-06-21 David Levin <​levin@chromium.org>

Reviewed by NOBODY (speculative build fix for windows).

Simply removed some whitespace form this file to make windows build wtf and
hopefully copy the new MessageQueque.h so that WebCore picks it up.

  • wtf/Assertions.cpp:
3:16 PM Changeset in webkit [44921] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-21 David Levin <​levin@chromium.org>

Reviewed by NOBODY.

Speculative windows build fix (idea by Mark Rowe).

  • WebCore.vcproj/WebCore.vcproj:
3:03 PM Changeset in webkit [44920] by mrowe@apple.com
  • 2 edits
    2 adds in trunk/WebKitTools

Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
trigger an update via the built-in software update mechanism.

Reviewed by Sam Weinig.

  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
  • WebKitLauncher/WebKitLauncherURLProtocol.m: Added.

(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
(+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol stopLoading]):
(-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
determine whether the x-webkit-launcher is available and working.
(-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
(-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.

3:02 PM Changeset in webkit [44919] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-21 David Levin <​levin@chromium.org>

Reviewed by NOBODY (Speculative gtk build fix).

  • GNUmakefile.am:
2:56 PM Changeset in webkit [44918] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-06-21 David Levin <​levin@chromium.org>

Reviewed by NOBODY.

Speculative tiger build fix and a windows build fix.
More fixes may still be in order.

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
2:46 PM Changeset in webkit [44917] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-21 David Levin <​levin@chromium.org>

Reviewed by NOBODY (Speculative tiger build fix).

  • dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
2:32 PM Changeset in webkit [44916] by levin@chromium.org
  • 9 edits
    2 adds in trunk

WebCore:

2009-06-21 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

<​https://bugs.webkit.org/show_bug.cgi?id=26448>

Added optimized GC for MessagePorts when the entangled port is run by the same thread.
Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.

  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Now marks remotely entangled ports as in-use, in addition to those with pending activity.
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Now checks if the entangled port is local (run by same thread) and if so mark()s it.
  • dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports. (WebCore::MessagePort::start): (WebCore::MessagePort::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread
  • dom/MessagePort.h:
  • dom/MessagePortProxyWrapper.h:
  • dom/default/MessagePortProxy.cpp: (WebCore::MessagePortProxyWrapper::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread (WebCore::MessagePortProxy::hasPendingActivity): Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages. (WebCore::MessagePortProxy::locallyEntangledPort):
  • dom/default/MessagePortProxy.h:

LayoutTests:

2009-06-21 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

<​https://bugs.webkit.org/show_bug.cgi?id=26448>

New tests for MessagePort GC cases that weren't previously covered.

  • fast/events/message-channel-gc-4-expected.txt: Added. Test for case where both MessagePorts are in-transit (cloned) when a GC occurs.
  • fast/events/message-channel-gc-4.html-disabled: Added.
2:32 PM Changeset in webkit [44915] by levin@chromium.org
  • 23 edits
    1 move
    7 adds
    2 deletes in trunk

JavaScriptCore:

2009-06-21 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

<​https://bugs.webkit.org/show_bug.cgi?id=25043>
Added support for multi-threaded MessagePorts.

  • wtf/MessageQueue.h: (WTF::::appendAndCheckEmpty):

Added API to test whether the queue was empty before adding an element.

WebCore:

2009-06-21 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

<​https://bugs.webkit.org/show_bug.cgi?id=25043>
Removed obsolete MessagePort.startConversation(), active and onclose APIs.

Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
entirely into the platform-dependent proxy.

Created a thread-safe default PlatformMessagePortChannel implementation.

Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
cross-thread MessagePorts work.

  • GNUMakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added MessagePortChannel/PlatformMessagePortChannel files.

  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):

Changed ports to not mark their entangled pair as reachable, per the spec.

  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):

Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.

  • dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): (WebCore::MessagePort::messageAvailable): (WebCore::MessagePort::start): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::hasPendingActivity):

Changed these APIs to delegate to new PlatformMessagePortChannel APIs.

  • dom/MessagePort.h:

Renamed isQueueOpen() to started().

  • dom/MessagePort.idl:

Removed startConversation and onclose.

  • dom/MessagePortProxy.h: Removed.
  • dom/MessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::EventData::create): (WebCore::MessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::~MessagePortChannel):
  • dom/MessagePortChannel.h: Added. (WebCore::MessagePortChannel::EventData::message): (WebCore::MessagePortChannel::EventData::channel):

Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.

(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::create):

  • dom/ScriptExecutionContext.cpp: (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):

Renamed isQueueOpen() to started().

  • dom/default/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::setRemotePort): (WebCore::PlatformMessagePortChannel::remotePort): (WebCore::PlatformMessagePortChannel::entangledChannel): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::closeInternal): (WebCore::PlatformMessagePortChannel::hasPendingActivity):
  • dom/default/PlatformMessagePortChannel.h: Added. (WebCore::PlatformMessagePortChannel::MessagePortQueue::create): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
  • page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer):

Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.

(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

2009-06-21 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

<​https://bugs.webkit.org/show_bug.cgi?id=25043>
Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
Added more tests of port cloning.

  • fast/events/message-channel-gc-2-expected.txt:
  • fast/events/message-channel-gc-2.html-disabled:
  • fast/events/message-channel-gc-3-expected.txt:
  • fast/events/message-channel-gc-3.html-disabled:
  • fast/events/message-channel-gc-expected.txt:
  • fast/events/message-channel-gc.html-disabled:
  • fast/events/message-port-clone-expected.txt: Added.
  • fast/events/message-port-clone.html-disabled: Added.
  • fast/events/message-port-expected.txt:
  • fast/events/message-port-no-wrapper-expected.txt: Added.
  • fast/events/message-port-onclose-expected.txt: Removed.
  • fast/events/message-port-onclose.html-disabled: Removed.
  • fast/events/message-port.html-disabled:
1:56 PM Changeset in webkit [44914] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Test: fast/css/resize-single-axis.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Ignore movement along the non-resizing axis.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/css/resize-single-axis-expected.txt: Added.
  • fast/css/resize-single-axis.html: Added.
1:47 PM Changeset in webkit [44913] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-21 Sam Weinig <​sam@webkit.org>

Reviewed by Eric Seidel

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox

Test: fast/events/event-trace.html

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched to it. We previously used the document because DOMWindow was not yet an EventTarget.

LayoutTests:

2009-06-21 Sam Weinig <​sam@webkit.org>

Reviewed by Eric Seidel.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox

  • fast/events/event-trace-expected.txt: Added.
  • fast/events/event-trace.html: Added.
1:16 PM Changeset in webkit [44912] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Test: fast/css/resize-value-compared.html

  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==): Compare the resize member.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/css/resize-value-compared-expected.txt: Added.
  • fast/css/resize-value-compared.html: Added.
12:19 AM Changeset in webkit [44911] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-06-21 Darin Adler <Darin Adler>

  • platform/gtk/Skipped: Skip one more test.

Jun 20, 2009:

11:19 PM Changeset in webkit [44910] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-06-20 Darin Adler <Darin Adler>

  • platform/gtk/Skipped: Skip some new tests.
11:15 PM Changeset in webkit [44909] by Darin Adler
  • 2 edits in trunk/WebKit/win

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
10:42 PM Changeset in webkit [44908] by alice.liu@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2009-06-19 Alice Liu <​alice.liu@apple.com>

Fix ​https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Can't test this bug with an automated layout test since it requires b/f caching

  • manual-tests/animated-gif-bfcache-crash.html: Added.
  • manual-tests/resources/containsAnimatedGif.html: Added.

Adding checks for hostWindow() since there is no guarantee that the Page is alive

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::wheelEvent):

LayoutTests:

2009-06-19 Alice Liu <​alice.liu@apple.com>

Fix ​https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>

Reviewed by Maciej Stachowiak.

Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html

  • http/tests/misc/resources/animated-gif-with-offsets.gif: Added.
7:43 PM Changeset in webkit [44907] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

Roll out the Windows portion of r44905 as it broke the build.

7:05 PM Changeset in webkit [44906] by weinig@apple.com
  • 6 edits in trunk

WebCore:

2009-06-20 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Barth.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26554
Shadowing of top and parent

  • page/DOMWindow.idl:

LayoutTests:

2009-06-20 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Barth.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=26554

Test writing to parent and top.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
4:07 PM Changeset in webkit [44905] by Darin Adler
  • 4 edits in trunk/WebKit

WebKit/mac:

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.

WebKit/win:

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

<rdar://problem/6964221> Need more processing of pluginspage.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
2:57 PM Changeset in webkit [44904] by jmalonzo@webkit.org
  • 6 edits in trunk

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Implement DRT XSS auditor support
​https://bugs.webkit.org/show_bug.cgi?id=26571

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
2:56 PM Changeset in webkit [44903] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-20 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

webkit_web_back_forward_list_add_item() should add a ref for the history item
​https://bugs.webkit.org/show_bug.cgi?id=26517

Add a ref to the WebHistoryItem when it's added to the back
forward list through webkit_web_back_forward_list_add_item.
This keeps the history item alive and prevents pywebkitgtk from
crashing

  • tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_add_item):
2:54 PM Changeset in webkit [44902] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

Fix <​https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

Reviewed by Dan Bernstein.

We allow selections to begin within an element that has -webkit-user-select: none set,
unless the element is draggable as dragging should take priority over starting a selection.

Test: editing/selection/user-drag-element-and-user-select-none.html

  • dom/Node.cpp:

(WebCore::Node::canStartSelection):

Test for <​https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none

  • editing/selection/user-drag-element-and-user-select-none-expected.txt: Added.
  • editing/selection/user-drag-element-and-user-select-none.html: Added.
1:34 PM Changeset in webkit [44901] by Darin Adler
  • 5 edits in trunk

WebCore:

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
​https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): When entering a text control, start at the top of the shadow tree (by calling shadowTreeRootNode). Also remove assumption that innerTextElement will never be 0 since RenderTextControl doesn't really guarantee this.

LayoutTests:

2009-06-20 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
​https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329

  • editing/selection/find-in-text-control-expected.txt: Updated to expect finding text in <input type="text"> and <input type="search">, but not in <input type="password">.
  • editing/selection/find-in-text-control.html: Added tests for <input> elements as well as <textarea> elements. Also tweaked result output format to accomodate multiple text nodes.
11:06 AM Changeset in webkit [44900] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix namespace comment in SegmentedVector.h

  • wtf/SegmentedVector.h: Updated namespace comment to reflect new namespace after r44897.
6:27 AM Changeset in webkit [44899] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-20 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<​https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

An Iterator added for SegmentedVector. Currently
only the pre ++ operator is supported.

  • wtf/SegmentedVector.h: (WTF::SegmentedVectorIterator::~SegmentedVectorIterator): (WTF::SegmentedVectorIterator::operator*): (WTF::SegmentedVectorIterator::operator->): (WTF::SegmentedVectorIterator::operator++): (WTF::SegmentedVectorIterator::operator==): (WTF::SegmentedVectorIterator::operator!=): (WTF::SegmentedVectorIterator::operator=): (WTF::SegmentedVectorIterator::SegmentedVectorIterator): (WTF::SegmentedVector::alloc): (WTF::SegmentedVector::begin): (WTF::SegmentedVector::end):
6:20 AM Changeset in webkit [44898] by kov@webkit.org
  • 3 edits
    1 add in trunk

2009-06-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Initial test case for loading statuses.

  • tests/testloading.c: Added. (load_finished_cb): (status_changed_cb): (test_loading_status): (main):
6:14 AM Changeset in webkit [44897] by ddkilzer@apple.com
  • 8 edits
    1 move in trunk/JavaScriptCore

2009-06-20 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Bug 24986: ARM JIT port
<​https://bugs.webkit.org/show_bug.cgi?id=24986>

Reviewed by Oliver Hunt.

Move SegmentedVector to /wtf subdirectory
and change "namespace JSC" to "namespace WTF"

Additional build file updates by David Kilzer.

  • GNUmakefile.am: Updated path to SegmentedVector.h.
  • JavaScriptCore.order: Updated SegmentedVector namespace from JSC to WTF in mangled C++ method name.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to bytecompiler\SegmentedVector.h.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to wtf\SegmentedVector.h.
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved SegmentedVector.h definition from bytecompiler subdirectory to wtf subdirectory.
  • bytecompiler/BytecodeGenerator.h: Updated #include path to
SegmentedVector.h and prepended WTF
namespace to its use.
  • parser/Lexer.h: Ditto.
  • wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h. (WTF::SegmentedVector::SegmentedVector): (WTF::SegmentedVector::~SegmentedVector): (WTF::SegmentedVector::size): (WTF::SegmentedVector::at): (WTF::SegmentedVector::operator[]): (WTF::SegmentedVector::last): (WTF::SegmentedVector::append): (WTF::SegmentedVector::removeLast): (WTF::SegmentedVector::grow): (WTF::SegmentedVector::clear): (WTF::SegmentedVector::deleteAllSegments): (WTF::SegmentedVector::segmentExistsFor): (WTF::SegmentedVector::segmentFor): (WTF::SegmentedVector::subscriptFor): (WTF::SegmentedVector::ensureSegmentsFor): (WTF::SegmentedVector::ensureSegment):
5:34 AM Changeset in webkit [44896] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-20 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Jan Alonzo.

Fix the ordering in which the new load status goes into the enum
to avoid ABI breakage.

  • webkit/webkitwebframe.h:
2:48 AM Changeset in webkit [44895] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-20 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by NOBODY.

Speculative Qt build fix - add HTMLDataGridColElement to the build script.

  • WebCore.pro:
2:20 AM Changeset in webkit [44894] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-06-19 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26561

Remove a memcpy by retrieving the already existing copy of a string
instead of making a new one.

  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::source):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::source):
1:11 AM Changeset in webkit [44893] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-20 Xan Lopez <​xlopez@igalia.com>

Skip new accessibility test, we still lack and accessibilityController.

  • platform/gtk/Skipped:
1:00 AM Changeset in webkit [44892] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-20 Xan Lopez <​xlopez@igalia.com>

We don't seem to support these new HTTP tests either, skip them.

  • platform/gtk/Skipped:
12:53 AM Changeset in webkit [44891] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-20 Xan Lopez <​xlopez@igalia.com>

Skip test that requires eventSender.

  • platform/gtk/Skipped:
Note: See TracTimeline for information about the timeline view.