⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 30, 2009:

11:51 PM Changeset in webkit [45431] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=26877
[GTK] DRT fixes to pass new plugin test

Silence compiler warnings.

Newer GCC don't like using or returning a static string where a
'char*' is expected. Ideally we'd change the function signatures
to return or take 'const char*' I suppose, but since we can't do
that just cast the strings to 'char*'.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_get_value):
11:42 PM Changeset in webkit [45430] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=26877
[GTK] DRT fixes to pass new plugin test

Use the common pluginLog function instead of a local copy.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_destroy_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
11:41 PM Changeset in webkit [45429] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=26877
[GTK] DRT fixes to pass new plugin test

Modify our DRT as done in bug #15457 to log logSrc as src in order
to pass test plugins/netscape-plugin-map-data-to-src.html.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance):
11:10 PM Changeset in webkit [45428] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Converted some more arithmetic ops to put { tag, payload } in
{ regT1, regT0 }.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
11:07 PM Changeset in webkit [45427] by adele@apple.com
  • 2 edits in trunk/WebKit/mac

2009-06-30 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/7014389> REGRESSION(4-TOT): Hyperlinks have no tooltips in Mail unless you first click in the message body

Updated these new methods (added as part of the viewless WebKit effort) that call through to WebHTMLView to use _selectedOrMainFrame,
instead of just selectedFrame. When the selection changes, I don't think there is a situation where there's no selected frame, but
it seems better to keep these two uses the same, since if there is a case, this will be more like the old behavior, before there was
a version of _selectionChanged in WebView.

  • WebView/WebView.mm: (-[WebView _setToolTip:]): (-[WebView _selectionChanged]):
10:58 PM Changeset in webkit [45426] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-30 Xan Lopez <​xlopez@igalia.com>

Disable test using eventSender.

  • platform/gtk/Skipped:
10:44 PM Changeset in webkit [45425] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-30 Xan Lopez <​xlopez@igalia.com>

Disable new tests until we enable the accessibility controller.

  • platform/gtk/Skipped:
10:28 PM Changeset in webkit [45424] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Converted some more arithmetic ops to put { tag, payload } in
{ regT1, regT0 }, and added a case for subtract constant.


SunSpider says no change. v8 says 0.3% slower.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSub32Constant): (JSC::JIT::emitSlow_op_sub):
10:19 PM Changeset in webkit [45423] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Land some code that has a hope of compiling.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::imageSourceOptions):

9:55 PM Changeset in webkit [45422] by barraclough@apple.com
  • 5 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam Weinig.

Remove more uses of addressFor(), load double constants directly from
the constantpool in the CodeBlock, rather than from the register file.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp):
9:37 PM Changeset in webkit [45421] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2009-06-30 Stephanie Lewis <Stephanie Lewis>

Reviewed by Simon Fraser.

Flip back on block caching. Throwing away block data, while
a perceived memory win, is a performance hit in cases where we
are repainting large images (i.e. backgrounds) frequently
(i.e. a flash video playing on top).
<rdar://problem/6933515> REGRESSION(L-SL): Large JPEG images are
decoded on drawing, slowing down painting of sites that frequently
repaint e.g. because of Flash (pandora.com, Starcraft 2)

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::imageSourceOptions):
8:50 PM Changeset in webkit [45420] by ggaren@apple.com
  • 5 edits in branches/nitro-extreme

JavaScriptCore:

2009-06-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed a bug in postfix ops, where we would treat x = x++ and x = x--
as a no-op, even if x were not an int, and the ++/-- could have side-effects.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec):

LayoutTests:

2009-06-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Added a test for x=x++ and x=x-- where the ++ / -- have side-effects.

  • fast/js/postfix-syntax-expected.txt:
  • fast/js/resources/postfix-syntax.js: (o.valueOf):
8:24 PM Changeset in webkit [45419] by mjs@apple.com
  • 11 edits
    1 move in trunk/WebCore

2009-06-30 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::loadFullDefaultStyle):
  • css/html.css: Copied from css/html4.css.
  • css/html4.css: Removed.
  • css/themeWin.css:
  • platform/Theme.h:
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
  • rendering/RenderTheme.h:
7:53 PM Changeset in webkit [45418] by jmalonzo@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

Fix ChangeLog of r45415

7:40 PM Changeset in webkit [45417] by ggaren@apple.com
  • 1 edit in branches/nitro-extreme/JavaScriptCore/ChangeLog

Fixed a ChangeLog merge fail.

7:40 PM Changeset in webkit [45416] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam Weinig.

Start removing cases of addressFor().

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble): (JSC::JIT::emitStoreDouble):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
7:27 PM Changeset in webkit [45415] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-30 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Jan Alonzo.

[GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation()
​https://bugs.webkit.org/show_bug.cgi?id=26835

  • GtkLauncher/main.c: (create_toolbar):
7:16 PM Changeset in webkit [45414] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2009-06-30 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Drag and drop support
​https://bugs.webkit.org/show_bug.cgi?id=23642

Define DragImageRef as GdkPixbuf and implement essential
functions which manipulate drag images.

  • platform/DragImage.h:
  • platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::createDragImageFromImage):
7:15 PM Changeset in webkit [45413] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-30 Maxime Simon <Maxime Simon>

Reviewed by Eric Seidel.

StorageNamespace.cpp build issue
​https://bugs.webkit.org/show_bug.cgi?id=26859

Moved #endif ENABLE(DOM_STORAGE) position
so that the build doesn't fail.
The namespace WebCore was started after the #if ENABLE(DOM_STORAGE)
but closed after the #endif.

  • storage/StorageNamespace.cpp:
6:01 PM Changeset in webkit [45412] by barraclough@apple.com
  • 5 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam Weinig.

Start removing cases of addressFor().

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble): (JSC::JIT::emitStoreDouble):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
5:40 PM Changeset in webkit [45411] by Simon Fraser
  • 13 edits in trunk/LayoutTests

2009-06-30 Simon Fraser <Simon Fraser>

Rubber-stamped by Dan Bernstein.

Update compositing pixel results now that DRT dumps them correctly.

  • compositing/overflow/overflow-scroll.html: Fixed typo in this testcase.
  • platform/mac/compositing/overflow/ancestor-overflow-expected.checksum:
  • platform/mac/compositing/overflow/ancestor-overflow-expected.png:
  • platform/mac/compositing/overflow/overflow-positioning-expected.checksum:
  • platform/mac/compositing/overflow/overflow-positioning-expected.png:
  • platform/mac/compositing/overflow/overflow-scroll-expected.txt:
  • platform/mac/compositing/overflow/parent-overflow-expected.checksum:
  • platform/mac/compositing/overflow/parent-overflow-expected.png:
  • platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
  • platform/mac/compositing/repaint/content-into-overflow-expected.png:
  • platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
  • platform/mac/compositing/repaint/overflow-into-content-expected.png:
5:40 PM Changeset in webkit [45410] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2009-06-30 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix drawing of view background in pixel snapshots when using compositing.
We still need to call -displayIfNeeded to ensure that the NSView drawing
has happened.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
4:29 PM Changeset in webkit [45409] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Geoffrey Garen <​ggaren@apple.com>

Rolled back in my last patch with regression fixed.

  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
4:09 PM Changeset in webkit [45408] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-30 Eric Seidel <​eric@webkit.org>

No review, reverting r45396. (George Staikos agrees the change was wrong.)
​http://trac.webkit.org/changeset/45396

  • fast/css/getComputedStyle/computed-style-font-family-expected.txt:
4:01 PM Changeset in webkit [45407] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-06-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/7020825> HTMLMediaElement should not assume seeking is only possible in
buffered time ranges

  • html/HTMLMediaElement.cpp:

Don't ASSERT if the network state goes to Idle when when the ready state is
HaveEnoughData or higher, it is perfectly legal.

(WebCore::HTMLMediaElement::setReadyState):

Don't clear m_seeking after posting a 'seeking' event.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::seek):

Do nothing when asked to seek to the same time we are already seeking to. Check requested
seek time against maxTimeSeekable, not maxTimeLoaded.

(WebCore::MediaPlayerPrivate::doSeek):

Don't bother stopping a movie that isn't playing. Minor cleanup to make the code more readable.

(WebCore::MediaPlayerPrivate::seekTimerFired):

Check requested seek time against maxTimeSeekable, not maxTimeLoaded.

(WebCore::MediaPlayerPrivate::updateStates):

A streaming movie has as much data as it needs once it reaches "playable", so
set the ready state to HaveFutureData. A movie with metadata doesn't drop back
to "have nothing" when seeking. A streaming movie doesn't use the network when paused.

(WebCore::MediaPlayerPrivate::timeChanged):

It may not be possible to seek to a specific time in a streamed movie but when seeking
in a streaming movie QuickTime sets the time to closest time possible and posts a
timechanged notification, so update m_seekTo so we can detect when the seek completes.

3:43 PM Changeset in webkit [45406] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Geoffrey Garen <​ggaren@apple.com>

Rolled out my last patch because it was a 2% SunSpider regression.

  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
3:43 PM Changeset in webkit [45405] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-30 Eric Seidel <​eric@webkit.org>

Typo fix only, no review.

Fix typo causing failure during land-diff

  • Scripts/bugzilla-tool:
3:27 PM Changeset in webkit [45404] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Gavin "Sam Weinig" Barraclough.


Standardized the rest of our opcodes to put { tag, payload } in
{ regT1, regT0 } where possible.

  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
3:06 PM Changeset in webkit [45403] by sfalken@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=26860

Reviewed by Sam Weinig.

Blacklist Yahoo Application State plug-in for versions prior to 1.0.0.6.
Earlier versions cause corruption crashes.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted):
2:57 PM Changeset in webkit [45402] by dino@apple.com
  • 9 edits in trunk/WebCore

2009-06-30 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7005207> <video> in canvas broken with ACCEL_COMPOSITING

Fix drawImage of video in CanvasRenderingContext2D when
accelerated compositing is enabled. This is done by
adding a new paint method to HTMLVideoElement that
is only called from canvas, which will create the software
renderer if necessary, but otherwise calls the regular
paint method. Meanwhile, add logic to the software video
renderer so that it can be created without calling repaint
every time it sees a new frame.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paintCurrentFrameInContext):
  • html/HTMLVideoElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::paintCurrentFrameInContext):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::paintCurrentFrameInContext):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::createQTVideoRenderer): (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering): (WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
2:47 PM Changeset in webkit [45401] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-30 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
and thus failed on SnowLeopard.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
2:39 PM Changeset in webkit [45400] by barraclough@apple.com
  • 7 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoffrey Garen.

Replace calls to store32(tagFor()) and store32(payloadFor())
with emitStoreInt32(), emitStoreBool(), and emitStoreCell().

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::emit_op_load_varargs):
  • jit/JITInlineMethods.h: (JSC::JIT::emitStoreInt32): (JSC::JIT::emitStoreCell): (JSC::JIT::emitStoreBool): (JSC::JIT::emitStore):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
  • jit/JITStubCall.h: (JSC::JITStubCall::call):
2:38 PM Changeset in webkit [45399] by hyatt@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Remove conflict markers from ChangeLog.

2:37 PM Changeset in webkit [45398] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2009-06-30 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
and thus failed on SnowLeopard.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
2:37 PM Changeset in webkit [45397] by hyatt@apple.com
  • 8 edits
    2 adds in trunk

WebCore:

<<<<<<< .mine

LayoutTests:

2009-06-30 David Hyatt <​hyatt@apple.com>

Reviewed by Beth Dakin.

Add layout test for ​https://bugs.webkit.org/show_bug.cgi?id=26858.

  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt: Added.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html: Added.
2:27 PM Changeset in webkit [45396] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2009-06-30 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

Updated LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
according to the default font size value set in WebKit/qt/Api/qwebsettings.cpp (in
this case '14').

  • fast/css/getComputedStyle/computed-style-font-family-expected.txt:
2:27 PM Changeset in webkit [45395] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2009-06-30 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

Updated LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
to some newly cross-platform CSS properties.

  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
2:07 PM Changeset in webkit [45394] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-06-30 Jeremy Orlow (​jorlow@chromium.org)

Reviewed by David Levin.

​https://bugs.webkit.org/show_bug.cgi?id=26852

Fix some minor build issues in the v8 bindings.

  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator): (WebCore::storageGetter): (WebCore::storageSetter): (WebCore::storageDeleter):
  • storage/StorageArea.cpp:
1:16 PM Changeset in webkit [45393] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

1:16 PM Changeset in webkit [45392] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.19.2

New tag.

1:10 PM Changeset in webkit [45391] by agl@chromium.org
  • 3 edits in trunk/WebCore

2009-06-30 Adam Langley <​agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: use different fonts for each script run.

​https://bugs.webkit.org/show_bug.cgi?id=26853

Previously, when rendering complex text, we picked a single font which
could render all the glyphs needed for the run. However, this meant
that sometimes lines were rendered with, for example, [LATIN, THAI,
LATIN] and we could end up with a different font for the Latin parts
than for lines without Thai in them.

With this patch, we pick a font for each script run.

This change is covered by existing layout tests.

1:02 PM Changeset in webkit [45390] by mrowe@apple.com
  • 1 edit in branches/WWDC-2009-branch/WebKit/mac/ChangeLog

Fix up the ChangeLog.

1:02 PM Changeset in webkit [45389] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

2009-06-30 David Levin <​levin@chromium.org>

Reviewed by Oliver Hunt.

Make media/video-document-types pass again. It broke when the
call to waitUntilDone was accidently made asynchronous in r45378.

  • media/video-document-types.html:
12:57 PM Changeset in webkit [45388] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r45386.

12:53 PM Changeset in webkit [45387] by Simon Fraser
  • 9 edits
    2 adds in trunk

2009-06-30 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt, Dan Bernstein.

<rdar://problem/6191676> Redraw issues scrolling overflow:scroll div with compositing

There are two parts to this fix. First, if a compositing layer has overflow clipping
or a mask, then the compositing layer does not need to be sized to encompass all
non-composited children.

Second, when scrolling, we have to back up to the compositing ancestor and have
it reposition descendant compositing layers, because overflow doesn't follow
the z-order tree.

Test: compositing/overflow/overflow-scroll.html

  • page/FrameView.cpp: (WebCore::FrameView::layout): Pass the UpdateCompositingLayers flag when updating layers after layout, so that we can reposition compositing layers if we're not about to do a layer rebuild.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): Only update compositing layers if the flag is set.

(WebCore::RenderLayer::scrollToOffset):
Do compositing layer updates from the compositing ancestor in one fell swoop.

  • rendering/RenderLayer.h: Replace the unused FullUpdate flag with one that allows us to specify whether compositing layers should be updated.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
  • rendering/RenderLayerBacking.h: New param that we can pass to updateCompositingDescendantGeometry to control whether the update goes deep.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): We can return earlier if this is not a self-painting layer. If the layer has overflow clip or a mask, then the composited bounds are just the local bounds, excluding descendants.

(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

  • rendering/RenderLayerCompositor.h: Renamed from updateCompositingChildrenGeometry, and added a flag that allows us to do a deep update.
12:52 PM Changeset in webkit [45386] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7006959> 'Save as…’ does not work in Mail

Reviewed by Timothy Hatcher.

  • WebView/WebFrameView.mm:

(-[WebFrameView initWithFrame:]): Call _needMailThreadWorkaroundIfCalledOffMainThread rather than
needMailThreadWorkaround, as the latter is intended to be used at the point which a workaround would
be applied and thus contains a main thread check. Since -initWithFrame: is called on the main thread,
this was causing us to not switch from exception-throwing to logging for the thread violation behavior.

11:27 AM Changeset in webkit [45385] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=26764
Uncaught NOT_FOUND_ERR: DOMException 8 loading empty text file

Test: fast/parser/empty-text-resource.html

  • loader/TextDocument.cpp: (WebCore::TextTokenizer::finish): Create document tree if it hasn't been created yet.
11:23 AM Changeset in webkit [45384] by bweinstein@apple.com
  • 7 edits in trunk

2009-06-30 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Adam Roben.

Renamed scrollbarUnderPoint to scrollbarAtPoint.

  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent):
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarAtPoint):
  • platform/ScrollView.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleMouseDownEvent): (WebCore::PopupListBox::handleMouseMoveEvent):

2009-06-30 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Adam Roben.


Renamed scrollbarUnderPoint to scrollbarAtPoint to follow conventions.

  • Api/qwebpage.cpp: (QWebPage::swallowContextMenuEvent):
11:05 AM Changeset in webkit [45383] by oliver@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/6960286> CrashTracer: [REGRESSION] 1120 crashes in Safari at com.apple.WebCore • WebCore::JSLazyEventListener::parseCode const + 62

Reviewed by Geoff Garen

<select> elements and other elements the produce popups can keep their popups
live across a page load. If this occurs and the <select> element has an
onchange handler it is possible to get into a state where we try to execute
JS on a page that no longer has an execution context.

10:42 AM Changeset in webkit [45382] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-06-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Standardized the rest of the property access instructions to put { tag,
payload } in { regT1, regT0 }.

Small v8 speedup, 0.2% SunSpider slowdown.

  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoad): (JSC::JIT::emitLoad2):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::patchPutByIdReplace):
10:32 AM Changeset in webkit [45381] by levin@chromium.org
  • 17 edits
    8 adds in trunk

WebCore:

2009-06-30 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

<​https://bugs.webkit.org/show_bug.cgi?id=25435>

Added support for sending MessagePorts to/from Workers via postMessage().

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::messageChannel): Exposes MessageChannel constructor WorkerContext.
  • bindings/js/JSWorkerCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Now correctly handles being instantiated from within a Worker.
  • platform/CrossThreadCopier.h: (WebCore::GenericWorkerTaskTraits<PassOwnPtr>): Added support for passing PassOwnPtr as argument to GenericWorkerTask
  • workers/GenericWorkerTask.h: (WebCore::):
    • workers/Worker.cpp: (WebCore::Worker::postMessage): Now handles disentangling/entangling MessagePorts sent to/from via postMessage. (WebCore::Worker::dispatchMessage):
    • workers/Worker.h:
    • workers/Worker.idl: Added an optional MessagePort argument to postMessage()
    • workers/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): Workers now report pending activity whenever there are remotely entangled ports. (WebCore::WorkerContext::postMessage): Now handles disentangling/entangling MessagePorts sent to/from via postMessage. (WebCore::WorkerContext::dispatchMessage):
    • workers/WorkerContext.h:
    • workers/WorkerContext.idl: Added an optional MessagePort argument to postMessage()
    • workers/WorkerContextProxy.h:
    • workers/WorkerMessagingProxy.cpp: Updated messaging infrastructure to transport an optional MessagePort/MessagePortChannel. (WebCore::MessageWorkerContextTask::create): (WebCore::MessageWorkerContextTask::MessageWorkerContextTask): (WebCore::MessageWorkerContextTask::performTask): (WebCore::MessageWorkerTask::create): (WebCore::MessageWorkerTask::MessageWorkerTask): (WebCore::MessageWorkerTask::performTask): (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
    • workers/WorkerMessagingProxy.h: Added additional postMessage() API that accepts a MessagePort
    • workers/WorkerObjectProxy.h: Added additional postMessage() API that accepts a MessagePort

LayoutTests:

2009-06-30 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

<​https://bugs.webkit.org/show_bug.cgi?id=25435>

Added tests for sending MessagePorts to/from workers.

  • fast/workers/resources/worker-cloneport.js: Added. (onmessage):
  • fast/workers/resources/worker-messageport.js: Added. (onmessage): (pingBack):
  • fast/workers/worker-cloneport-expected.txt: Added.
  • fast/workers/worker-cloneport.html-disabled: Added. Tests for cloning a port while messages are sent from another thread.
  • fast/workers/worker-messageport-expected.txt: Added.
  • fast/workers/worker-messageport.html-disabled: Added. General tests for sending messages to workers via message ports.
  • fast/workers/worker-messageport-gc-expected.txt: Added.
  • fast/workers/worker-messageport-gc.html-disabled: Added. Tests to ensure Workers don't shut down when reachable only via MessagePorts.
10:07 AM Changeset in webkit [45380] by treat@webkit.org
  • 6 edits
    3 adds in trunk/WebKit/qt

2009-06-30 Joe Ligman <​joseph.ligman@nokia.com>

Reviewed by Adam Treat.

Bug 26422: [Qt] QWebPagePrivate::frameAt calculates wrong frame

Added a public method QWebPage::frameAt
Removed QWebPagePrivate::frameAt, which calcuated the wrong frame
Modified QWebPage::swallowContextMenuEvent to use the new frameAt method
New test case for frameAt added to tst_qwebpage.cpp

9:57 AM Changeset in webkit [45379] by agl@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2009-06-30 Adam Langley <​agl@google.com>

Reviewed by Eric Seidel.

Chromium: Add complex text support on Linux.

​https://bugs.webkit.org/show_bug.cgi?id=25068

This patch adds complex text support on Linux using Harfbuzz. It's not
the fastest code possible: some caching of font tables will certainly
be required. However, it's probably the simplest code that works.

This will require checking in new baselines in the Chromium tree for
those layout tests which now pass.

9:30 AM Changeset in webkit [45378] by eric.carlson@apple.com
  • 4 edits in trunk

2009-06-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7019799> Slow loading MediaDocument can fall back to plug-in unnecessarily

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):

Always fall back to a plug-in if m_hasUnsupportedTracks is set.

(WebCore::MediaPlayerPrivate::disableUnsupportedTracks):

Set m_hasUnsupportedTracks if we disable a track.

2009-06-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.


<rdar://problem/7019799> Slow loading MediaDocument can fall back to plug-in unnecessarily


Don't test iframe immediately, switch over from <video> to <embed> may not have
happend when the document 'load' event fires.

  • media/video-document-types.html:
9:25 AM Changeset in webkit [45377] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-06-30 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Fix inverted if/else that's causing a layout test in src.chromium.org to fail.

​https://bugs.webkit.org/show_bug.cgi?id=26820

8:49 AM Changeset in webkit [45376] by mitz@apple.com
  • 8 edits in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap to Grid" window is clipping

Added an app-specific quirk to revert the behavior of <link> elements
to the way it was before r30673, namely that if the rel attribute
is not "stylesheet" but the type attribute contains "text/css", the
link behaves as a stylesheet link.

  • WebCore.base.exp: Exported setTreatsAnyTextCSSLinkAsStylesheet().
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Check

Settings::treatsAnyTextCSSLinkAsStylesheet() and if true, allow a
style sheet link if the type contains "text/css".

  • page/Settings.cpp: (WebCore::Settings::Settings):

Initialize m_treatsAnyTextCSSLinkAsStylesheet.

(WebCore::Settings::setTreatsAnyTextCSSLinkAsStylesheet): Added.

  • page/Settings.h: (WebCore::Settings::treatsAnyTextCSSLinkAsStylesheet): Added.

WebKit/mac:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap to Grid" window is clipping
  • Misc/WebKitVersionChecks.h: Added

WEBKIT_FIRST_VERSION_WITHOUT_SHADE10_QUIRK

  • WebView/WebView.mm: (-[WebView _needsLinkElementTextCSSQuirk]): Added. Returns YES if the

client app is a version of Shade 10 earlier than 10.6 and it was
linked against a version of WebKit earlier than 531.2.

(-[WebView _preferencesChangedNotification:]): Added a call to

Settings::setTreatsAnyTextCSSLinkAsStylesheet().

7:14 AM Changeset in webkit [45375] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

2009-06-30 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

Add QWebFrame::baseUrl() function that exposes the base URL of a frame.
Autotests included.

  • Api/qwebframe.cpp: (QWebFrame::baseUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp:
7:05 AM Changeset in webkit [45374] by staikos@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-30 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

Override operator new/delete with const std::nothrow_t& as the second
argument.

6:54 AM QtWebKitContrib edited by treat@kde.org
(diff)
6:51 AM QtWebKitContrib edited by treat@kde.org
(diff)
5:15 AM Changeset in webkit [45373] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-30 Adrien Nader <​camaradetux@gmail.com>

Reviewed by Xan Lopez.

Fix typo in GNUMakefile.am: it reads WebCOre instead of WebCore.

  • GNUmakefile.am:
5:10 AM Changeset in webkit [45372] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-30 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Turn on ENABLE_DATAGRID so we can run the layout tests.

  • GNUmakefile.am:
3:55 AM Changeset in webkit [45371] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-30 Xan Lopez <​xlopez@igalia.com>

Skip new editing tests.

They are failing because we don't have a dumpEditingCallbacks
implementation.

  • platform/gtk/Skipped:
2:55 AM Changeset in webkit [45370] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-06-30 Gabor Loki <​loki@inf.u-szeged.hu>

Reviewed by Sam Weinig.

<​https://bugs.webkit.org/show_bug.cgi?id=24986>

Remove unnecessary references to AssemblerBuffer.

  • interpreter/Interpreter.cpp:
  • interpreter/Interpreter.h:
2:33 AM Changeset in webkit [45369] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2009-06-30 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

Include a built copy of BeautifulSoup 3.1.0.1 so that
bugzilla-tool users do not need to install it manually.
​https://bugs.webkit.org/show_bug.cgi?id=26833

BeautifulSoup is BSD-licensed (thus WebKit compatible) and available from:
​http://www.crummy.com/software/BeautifulSoup

  • Scripts/bugzilla-tool: fixed a typo in a log message.
  • Scripts/modules/BeautifulSoup.py: Added.
  • Scripts/modules/bugzilla.py:
2:03 AM Changeset in webkit [45368] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-06-30 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Hausmann.

Fix our create_patch handling to not
hang when creating large patches.
​https://bugs.webkit.org/show_bug.cgi?id=26834

We're now using StringIO to make an in-memory buffer for the patch
instead of piping from the patch command directly to the upload.
The previous hang was caused by calling wait() when the process had already
filed the stdout buffer.

  • Scripts/modules/scm.py:
12:52 AM Changeset in webkit [45367] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-06-30 Raju Kunnath <​raju.kunnath@nokia.com>

Reviewed by Simon Hausmann.

<​https://bugs.webkit.org/show_bug.cgi?id=26752>

[Qt] Windows release build issue with Qt4.5 due to -GL flag on msvc2005 and msvc2008.

  • WebCore.pro: Removed -GL compiler option for win32-msvc2005|win32-msvc2008.
12:48 AM Changeset in webkit [45366] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

Initialize member variables in the right order. Fixes compiler
warning.

  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader):
12:24 AM Changeset in webkit [45365] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by David Levin.

​https://bugs.webkit.org/show_bug.cgi?id=26831
Fix compiler warning in WorkerLoaderProxy.h

Forward declaration of a class within a class is not allowed,
since the compiler can't know if the declaration is legal at that
point. This gives the following compiler warning:

../../WebCore/workers/WorkerLoaderProxy.h:40: warning: declaration
"class WebCore::ScriptExecutionContext::Task" does not declare
anything

Include the full ScriptExecutionHeader header instead.

  • workers/WorkerLoaderProxy.h:

Jun 29, 2009:

11:43 PM Changeset in webkit [45364] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

Fix a couple of compiler warnings.

  • webkit/webkitwebnavigationaction.cpp:
  • webkit/webkitwebview.cpp: (webkit_web_view_real_move_cursor):
10:56 PM Changeset in webkit [45363] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

Remove unused function.

  • plugins/gtk/PluginPackageGtk.cpp:
10:12 PM Changeset in webkit [45362] by Simon Fraser
  • 4 edits in trunk/WebCore

2009-06-29 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Change RenderLayer::updateLayerPositions() to use a bitmask instead of two
boolean arguments. FullUpdate is unused at present, but will be used soon.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::):
8:08 PM Changeset in webkit [45361] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-06-29 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Various cleanups.

  • Use fpRegT* instead of X86::xmm*.
  • Use a switch statement in emitBinaryDoubleOp instead of a bunch of if/elses.
  • jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div):
5:09 PM Changeset in webkit [45360] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-06-29 David Levin <​levin@chromium.org>

Reviewed by Oliver Hunt.

Still seeing occasional leaks from UString::sharedBuffer code
​https://bugs.webkit.org/show_bug.cgi?id=26420

The problem is that the pointer to the memory allocation isn't visible
by "leaks" due to the lower bits being used as flags. The fix is to
make the pointer visible in memory (in debug only). The downside of
this fix that the memory allocated by sharedBuffer will still look like
a leak in non-debug builds when any flags are set.

  • wtf/PtrAndFlags.h: (WTF::PtrAndFlags::set):
4:44 PM Changeset in webkit [45359] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-06-29 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Fix one more bad merge in V8Proxy.

​https://bugs.webkit.org/show_bug.cgi?id=26819

4:21 PM Changeset in webkit [45358] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

2009-06-29 David Hyatt <​hyatt@apple.com>

Fix Windows bustage. Missed two configurations for enabling DATAGRID.

  • WebKit.vcproj/WebKit.vcproj:
3:35 PM Changeset in webkit [45357] by weinig@apple.com
  • 6 edits
    2 deletes in trunk

JavaScriptCore:

2009-06-29 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Remove more unused scons support.

  • SConstruct: Removed.

WebCore:

2009-06-29 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Remove more unused scons support.

  • SConstruct: Removed.

WebKitTools:

2009-06-29 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Remove more unused scons support.

  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
3:33 PM Changeset in webkit [45356] by oliver@apple.com
  • 5 edits in trunk

<rdar://problem/7016214> JSON.parse fails to parse valid JSON with most Unicode characters
<​https://bugs.webkit.org/show_bug.cgi?id=26802>

Reviewed by Gavin Barraclough.

In the original JSON.parse patch unicode was handled correctly, however in some last
minute "clean up" I oversimplified isSafeStringCharacter. This patch corrects this bug.

2:38 PM Changeset in webkit [45355] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-06-29 Sam Weinig <​sam@webkit.org>

Reviewed by Dave Hyatt.

Fix some incorrect create functions.

  • html/DataGridColumn.h: (WebCore::DataGridColumn::create):
  • html/DataGridColumnList.h: (WebCore::DataGridColumnList::create):
2:32 PM Changeset in webkit [45354] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2009-06-29 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

Updated LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-expected.txt to some newly cross-platform CSS properties.

The file has not been updated for a while.

2:31 PM Changeset in webkit [45353] by weinig@apple.com
  • 15 edits
    2 adds in trunk

WebCore:

2009-06-29 Sam Weinig <​sam@webkit.org>

Reviewed by Dave Hyatt.

Remove initialize method from DataGridDataSource and add
DOMDataGridDataSource.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDataGridDataSource.cpp:
  • bindings/js/JSDataGridDataSource.h:
  • bindings/js/JSHTMLDataGridElementCustom.cpp: (WebCore::JSHTMLDataGridElement::setDataSource):
  • html/DOMDataGridDataSource.cpp: Added. (WebCore::DOMDataGridDataSource::DOMDataGridDataSource): (WebCore::DOMDataGridDataSource::~DOMDataGridDataSource):
  • html/DOMDataGridDataSource.h: Added. (WebCore::DOMDataGridDataSource::create): (WebCore::DOMDataGridDataSource::isDOMDataGridDataSource): (WebCore::asDOMDataGridDataSource):
  • html/DataGridDataSource.h: (WebCore::DataGridDataSource::isDOMDataGridDataSource): (WebCore::DataGridDataSource::isJSDataGridDataSource):
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::setDataSource): (WebCore::HTMLDataGridElement::dataSource):
  • html/HTMLDataGridElement.h:

LayoutTests:

2009-06-29 Sam Weinig <​sam@webkit.org>

Reviewed by Dave Hyatt.

Update for the change in DataGridDataSource API.

  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
1:58 PM Changeset in webkit [45352] by Nate Chapin
  • 3 edits in trunk/WebCore

2009-06-29 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Fix a couple of bad merge items from my previous V8Proxy patch.

​https://bugs.webkit.org/show_bug.cgi?id=26813

1:42 PM Changeset in webkit [45351] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-26 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

Rename land-and-update to land-diff and make it awesome.
​https://bugs.webkit.org/show_bug.cgi?id=26734

Renamed land-and-update to land-diff
Made the BUGID argument optional.
Added optional support for building and testing before landing.

land-diff [options] [BUGID] Lands the current working directory diff and updates the bug if provided.

Options:

-r REVIEWER, --reviewer=REVIEWER

Update ChangeLogs to say Reviewed by REVIEWER.

--no-close Leave bug open after landing.
--no-build Commit without building first, implies --no-test.
--no-test Commit without running run-webkit-tests.

  • Scripts/bugzilla-tool:
1:41 PM Changeset in webkit [45350] by cmarrin@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=26706

Fixed crash due to dereference of m_toStyle

1:36 PM Changeset in webkit [45349] by alice.liu@apple.com
  • 1 edit in trunk/WebCore/plugins/win/PluginMessageThrottlerWin.cpp

build fix. accidental omission of end paren

1:22 PM Changeset in webkit [45348] by eric.carlson@apple.com
  • 16 edits in trunk

2009-06-29 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7014813> Ask media engine if a movie is streamed or downloaded.

  • WebCore.base.exp:

Export _wkQTMovieGetType

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::hasSingleSecurityOrigin):

Move to keep with other non-callback functions.

(WebCore::MediaPlayer::movieLoadType):

New, returns the movie type.

  • platform/graphics/MediaPlayer.h:

Declare MovieLoadType enum and movieLoadType method.

  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::movieLoadType):

Default implementation of movieLoadType

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):

Don't base m_isStreaming on protocol, there are other types of streaming movies.

(WebCore::MediaPlayerPrivate::maxTimeBuffered):

Don't assume all streams are unbuffered.

(WebCore::MediaPlayerPrivate::updateStates):

Update m_isStreaming once we have metadata.

(WebCore::MediaPlayerPrivate::disableUnsupportedTracks):

Tracks that are disabled to begin with shouldn't be included in m_enabledTrackCount.

(WebCore::MediaPlayerPrivate::movieLoadType):

New, return movie type.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Add wkQTMovieGetType.

2009-06-29 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7014813> Ask media engine if a movie is streamed or downloaded.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

Add QTMovieGetType.

2009-06-29 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/7014813>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
1:15 PM Changeset in webkit [45347] by alice.liu@apple.com
  • 2 edits in trunk/WebCore

2009-06-29 Alice Liu <​alice.liu@apple.com>

Fixed <rdar://problem/6930280> Reproducible crash at USA Today photo gallery

Reviewed by Anders Carlsson.

No test added because the crash requires a flash plugin

  • plugins/win/PluginMessageThrottlerWin.cpp: Rely on the hWnd of the plugin to tell us whether the PluginView has been deleted during execution of its wndProc. (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
1:02 PM Changeset in webkit [45346] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-06-29 Dmitry Titov <​dimich@chromium.org>

Reviewed by David Levin.

​https://bugs.webkit.org/show_bug.cgi?id=26811

[Chromium] Remove a flag and functions used to enable workers in runtime.

  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/WorkerContextExecutionProxy.h:
1:00 PM Changeset in webkit [45345] by Simon Fraser
  • 5 edits in trunk/WebCore

2009-06-29 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

<rdar://problem/6976712> Text antialiasing problems when rendering into compositing layers.

Improve the appearance of text in compositing layers by making use of
CA's layer geometry flipping, rather that doing it ourselves with a flip
transform. This allows CG to use font autohinting in the layer text.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setGeometryOrientation): (WebCore::GraphicsLayer::geometryOrientation): New methods to set whether this layer uses flipped geometry.
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setGeometryOrientation): (WebCore::GraphicsLayerCA::geometryOrientation): Subclass in order to call into CA

(WebCore::GraphicsLayerCA::setContentsLayer):
Now that CA is doing the geometry flipping, we no longer need to flip the content
layers for image and video manually

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Turn on flipping on the root layer.
12:52 PM Changeset in webkit [45344] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests

2009-06-29 David Hyatt <​hyatt@apple.com>

Reviewed by Mark Rowe.

Update layout tests for addition of HTMLDataGridCellElement constructor.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
12:36 PM Changeset in webkit [45343] by Nikolas Zimmermann
  • 1 edit
    4 moves in trunk/LayoutTests

Reviewed by Adam Treat.
Rename go-task-animation.* to ontimer-inline-event.* to reflect what it really tests.

12:11 PM Changeset in webkit [45342] by Nikolas Zimmermann
  • 9 edits
    7 adds in trunk

Reviewed by Adam Treat.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26246

Implement most WML specific <select> element features.
Add 'iname' / 'ivalue' support and support variable references.

Add two tests covering most select/variable related functionality.
Needs more tests when adding full 'iname' / 'ivalue' support (used in conjuction with onpick).

Tests: http/tests/wml/post-data-to-server.html

wml/select-element-variables.html

11:11 AM Changeset in webkit [45341] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-06-29 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add inline code dealing with doubles for op_jfalse and op_jtrue.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::): (JSC::MacroAssemblerX86Common::zeroDouble):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
9:34 AM Changeset in webkit [45340] by jberlin@apple.com
  • 3 edits in trunk/WebKit/win

2009-06-29 Jessie Berlin <​jberlin@apple.com>

Fix the windows build.

Reviewed by Adam Roben.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::isSpeaking):
  • WebCoreSupport/WebContextMenuClient.h:
9:03 AM Changeset in webkit [45339] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

2009-06-29 David Hyatt <​hyatt@apple.com>

Reviewed by Adam Roben.

Make sure to patch all configurations to have datagrid enabled.

  • WebKit.vcproj/WebKit.vcproj:
8:52 AM Changeset in webkit [45338] by hyatt@apple.com
  • 35 edits in trunk

WebCore:

2009-06-29 David Hyatt <​hyatt@apple.com>

Reviewed by Adam Roben.

Put <datagrid> behind an ifdef.

  • Configurations/FeatureDefines.xcconfig:
  • bindings/js/JSDataGridColumnListCustom.cpp:
  • bindings/js/JSDataGridDataSource.cpp:
  • bindings/js/JSDataGridDataSource.h:
  • bindings/js/JSHTMLDataGridElementCustom.cpp:
  • html/DataGridColumn.cpp:
  • html/DataGridColumn.h:
  • html/DataGridColumn.idl:
  • html/DataGridColumnList.cpp:
  • html/DataGridColumnList.h:
  • html/DataGridColumnList.idl:
  • html/DataGridDataSource.h:
  • html/HTMLDataGridCellElement.cpp:
  • html/HTMLDataGridCellElement.h:
  • html/HTMLDataGridCellElement.idl:
  • html/HTMLDataGridColElement.cpp:
  • html/HTMLDataGridColElement.h:
  • html/HTMLDataGridColElement.idl:
  • html/HTMLDataGridElement.cpp:
  • html/HTMLDataGridElement.h:
  • html/HTMLDataGridElement.idl:
  • html/HTMLDataGridRowElement.cpp:
  • html/HTMLDataGridRowElement.h:
  • html/HTMLDataGridRowElement.idl:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:
  • rendering/RenderDataGrid.cpp:
  • rendering/RenderDataGrid.h:

WebKit/mac:

2009-06-29 David Hyatt <​hyatt@apple.com>

Reviewed by Adam Roben.

Put datagrid behind an #ifdef.

  • Configurations/FeatureDefines.xcconfig:

WebKit/win:

2009-06-29 David Hyatt <​hyatt@apple.com>

Reviewed by Adam Roben.

Put <datagrid> behind an ifdef.

  • WebKit.vcproj/WebKit.vcproj:
6:57 AM Changeset in webkit [45337] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-06-29 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat and Adam Roben.

Fix compilation with MINGW. Ported MSVC inline assembly to
GNU inline assembly. Also fixed casting errors where gcc
refused to cast a pointer-to-function to a pointer-to-object,
without an intermediate cast to a non-pointer type.

2:17 AM Changeset in webkit [45336] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-06-29 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Qt build, add missing isSpeaking() implementation to
ContextMenuClient.

Note: See TracTimeline for information about the timeline view.