Timeline
Jul 4, 2009:
- 10:53 AM Changeset in webkit [45546] by
-
- 2 edits in trunk/JavaScriptCore
- debug build fix
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::getLastParen):
- 7:21 AM Changeset in webkit [45545] by
-
- 5 edits in trunk/JavaScriptCore
2009-07-03 Yong Li <yong.li@torchmobile.com>
Reviewed by Maciej Stachowiak (and revised slightly)
RegExp::match to be optimized
https://bugs.webkit.org/show_bug.cgi?id=26957
Allow regexp matching to use Vectors with inline capacity instead of
allocating a new ovector buffer every time.
~5% speedup on SunSpider string-unpack-code test, 0.3% on SunSpider overall.
- runtime/RegExp.cpp: (JSC::RegExp::match):
- runtime/RegExp.h:
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructorPrivate::RegExpConstructorPrivate): (JSC::RegExpConstructorPrivate::lastOvector): (JSC::RegExpConstructorPrivate::tempOvector): (JSC::RegExpConstructorPrivate::changeLastOvector): (JSC::RegExpConstructor::performMatch): (JSC::RegExpMatchesArray::RegExpMatchesArray): (JSC::RegExpMatchesArray::fillArrayInstance): (JSC::RegExpConstructor::getBackref): (JSC::RegExpConstructor::getLastParen): (JSC::RegExpConstructor::getLeftContext): (JSC::RegExpConstructor::getRightContext):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncSplit):
- 7:20 AM Changeset in webkit [45544] by
-
- 2 edits in trunk/WebKitTools
2009-07-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
bugzilla-tool forgot how to obsolete patches
https://bugs.webkit.org/show_bug.cgi?id=26951
- Scripts/modules/bugzilla.py:
Jul 3, 2009:
- 9:50 PM Changeset in webkit [45543] by
-
- 1 edit in trunk/WebCore/ChangeLog
Added Radar link I left out by accident the first time.
- 9:48 PM Changeset in webkit [45542] by
-
- 2 edits in trunk/WebCore
2009-07-03 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
REGRESSION (r44670-r44680): Typing is suprisingly slow in password field on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=26959
The code to handle iteration boundaries was malfunctioning when the boundary was
at the edge of a shadow tree. This happens all the time with <input> elements.
It's not immediately obvious how to make a regression test for this since the
symptom was a performance problem, not incorrect behavior. I'll add a test if I
figure out a way to make one.
- editing/TextIterator.cpp: (WebCore::parentCrossingShadowBoundaries): Renamed from parentOrShadowParent. (WebCore::depthCrossingShadowBoundaries): Updated for name change. (WebCore::nextInPreOrderCrossingShadowBoundaries): Added. (WebCore::previousInPostOrderCrossingShadowBoundaries): Added. (WebCore::setUpFullyClippedStack): Updated for name change. (WebCore::TextIterator::TextIterator): Updated for name change. Use nextInPreOrderCrossingShadowBoundaries instead of Range::pastLastNode to fix the bug. (WebCore::TextIterator::advance): Updated for name change. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Tweaked formatting. (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto. Changed code that initializes m_pastStartNode to use previousInPostOrderCrossingShadowBoundaries. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Tweaked formatting. (WebCore::SimplifiedBackwardsTextIterator::exitNode): Ditto.
- 8:56 PM Changeset in webkit [45541] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Simon Fraser.
- fix <rdar://problem/6964278> REGRESSION (r42118): Scrolling redraw problem in FileMaker Pro
- WebView/WebHTMLView.mm: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Perform layout if needed, even on Mac OS X versions that have -viewWillDraw. This prevents attempts to draw without layout in case -viewWillDraw was not called due to NSView issues or the client did something during the display operation that re-invalidated the layout.
- 8:27 PM Changeset in webkit [45540] by
-
- 1 edit1 add in trunk/BugsSite
Bug 26958: Change edit link to review link in request messages
Reviewed by Dan Bernstein.
- template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl. Changed link from "action=edit" to "action=review".
- 6:09 PM Changeset in webkit [45539] by
-
- 2 edits in trunk/LayoutTests
Not reviewed. Forgot to land ontimer-inline-event.html results within my last WML commit.
- 5:19 PM Changeset in webkit [45538] by
-
- 2 edits in trunk/BugsSite
Bug 26950: Make the summary and alias fields support click-to-edit
<https://bugs.webkit.org/show_bug.cgi?id=26950>
Reviewed by Maciej Stachowiak.
Original patch by Maciej Stachowiak.
- js/field.js: (hideEditableField): Updated to add click event listeners to the alias and short description elements to make them easier to edit. Renamed field_id parameter to field2_id (short description id) and added a field1_id parameter (alias id). (showEditableField): If a third parameter is passed in the ContainerInputArray parameter, use it to find the element to focus. Otherwise, fall back to the original behavior of focusing the first input field. (hideAliasAndSummary): Changed to pass the id for the alias element to hideEditableField().
- 1:54 PM Changeset in webkit [45537] by
-
- 2 edits in trunk/WebCore
2009-07-03 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Background audio stops playing when JS GC runs
https://bugs.webkit.org/show_bug.cgi?id=26956
Ensure we keep the Audio object around while it is playing, so that it
doesn't get collected.
Not testable because there's no way to know whether the audio keeps
playing without holding a reference to it.
- bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM):
- 12:34 PM Changeset in webkit [45536] by
-
- 2 edits in trunk/WebKitSite
2009-07-03 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Adam and Collin's affiliation is incorrect
https://bugs.webkit.org/show_bug.cgi?id=26954
This change corrects their affiliation.
- security/security-group-members.html:
- 7:08 AM Changeset in webkit [45535] by
-
- 2 edits in trunk/WebCore
2009-07-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26814
[Gtk] Caret-moved events are not issued for the correct offset
when text is selected forward
Report the caret offset from the end of the selection, otherwise
we'll report the same offset when moving the caret while
modififying the selection (eg, with Shift + Right).
- editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 7:08 AM Changeset in webkit [45534] by
-
- 2 edits in trunk/WebCore
2009-07-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26815
[Gtk] text-selection-changed events are not issued for the correct
object when the selection spans multiple objects
Get the focused node from the end of the selection, not the start,
so we can detect when we cross object boundaries.
- editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 3:47 AM Changeset in webkit [45533] by
-
- 2 edits in trunk/LayoutTests
2009-07-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Fisher.
Increase delay in worker-terminate layout test to make it more reliable.
https://bugs.webkit.org/show_bug.cgi?id=26917
This test used time delay to see of terminated worker does not return
messages (terminated). In some test conditions, the current delay (500ms)
is too short and test fails. Move setting the delay to the end of initialization
and increase it 2x to make test more reliable.
- fast/workers/worker-terminate.html:
- 3:24 AM Changeset in webkit [45532] by
-
- 2 edits in trunk/LayoutTests
2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>
Skip tests that require expected results that Gtk doesn't have.
- platform/gtk/Skipped:
- 2:57 AM Changeset in webkit [45531] by
-
- 11 edits1 add in trunk
2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez and Gustavo Noronha.
Set user-agent from application
https://bugs.webkit.org/show_bug.cgi?id=17375
Add 'user-agent' setter/getter API to WebSettings.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::userAgent):
- WebCoreSupport/FrameLoaderClientGtk.h:
- webkit/webkitprivate.h:
- webkit/webkitversion.h.in:
- webkit/webkitwebsettings.cpp: (webkit_get_user_agent): (webkit_web_settings_class_init): (webkit_web_settings_finalize): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy): (webkit_web_settings_get_user_agent):
- webkit/webkitwebsettings.h:
- webkit/webkitwebview.cpp: (webkit_web_view_dispose):
Define UA version macros to be used by the UA string.
Add new WebSettings unit test for the User-Agent string API.
- GNUmakefile.am:
- configure.ac:
