Timeline
Jul 5, 2009:
- 10:22 PM Changeset in webkit [45557] by
-
- 2 edits in trunk/WebCore
2009-07-05 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Darin Adler.
REGRESSION (r40499): fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342
Re-added code removed by commit r40499.
Without this, both Qt and Mac were crashing while running the test.
Note that this does not entirely fix the bug. It fixes the WebCore
crash, but the test no longer seems to work due to loader changes.
So this patch does not reenable the test. The test probably has to
be rewritten.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removedFromDocument): Re-added code to set the CSS target of the document to 0.
- 6:46 PM Changeset in webkit [45556] by
-
- 6 edits3 adds in trunk
2009-07-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).
Test: transitions/extra-transition.html
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
- page/animation/CompositeAnimation.h:
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
- 12:39 PM Changeset in webkit [45555] by
-
- 6 edits3 deletes in trunk
2009-07-05 Simon Fraser <Simon Fraser>
Revert the previous commit because it broke the
animations/transition-and-animation-1.html
testcase.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent):
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
- page/animation/CompositeAnimation.h:
- 12:18 PM Changeset in webkit [45554] by
-
- 6 edits4 adds in trunk
2009-07-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).
Test: transitions/extra-transition.html
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
- page/animation/CompositeAnimation.h:
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
- 8:45 AM Changeset in webkit [45553] by
-
- 6 edits in trunk
2009-07-05 Lars Knoll <lars.knoll@nokia.com>
Reviewed by Maciej Stachowiak.
Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.
The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.
Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.
Based on idea by Norbert Leser.
- runtime/Lookup.h: Define JSC_CONST_HASHTABLE as const for !WINSCW.
- create_hash_table: Use JSC_CONST_HASHTABLE for hashtables.
- runtime/JSGlobalData.cpp: Import various global hashtables via the macro.
WebCore:
2009-07-05 Lars Knoll <lars.knoll@nokia.com>
Reviewed by Maciej Stachowiak.
Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.
The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.
Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.
Based on idea by Norbert Leser.
- bindings/scripts/CodeGeneratorJS.pm: Use JSC_CONST_HASHTABLE for hash tables define in the bindings.
- 7:53 AM Changeset in webkit [45552] by
-
- 7 edits in trunk/WebKit/gtk
2009-07-05 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
Always initialize WebCore.
It is possible that WebKitWebSettings and other classes get
constructed before the WebKitWebView. In this case WebCore is
not yet properly initialized. Add webkit_init to every class
that can be constructed by API users.
- webkit/webkitdownload.cpp: (webkit_download_class_init):
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_class_init):
- webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_class_init):
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_class_init):
- 7:33 AM Changeset in webkit [45551] by
-
- 3 edits in trunk/WebKit/qt
2009-07-05 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Fix two qdoc warnings.
Added missing \property for QWebFrame::hasFocus and added \a
tag for pos of QWebPage::frameAt.
- Api/qwebframe.cpp:
- Api/qwebpage.cpp:
- 6:06 AM Changeset in webkit [45550] by
-
- 3 edits4 adds in trunk
Reviewed by Maciej Stachowiak.
Bug 26897 - Dynamic SVG images do not display correctly
https://bugs.webkit.org/show_bug.cgi?id=26897
Use repaint() to fix a rendering problem with a SVG image embedded in xhtml.
Test: svg/custom/createImageElement2.xhtml
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
- 3:43 AM Changeset in webkit [45549] by
-
- 2 edits in trunk/WebCore
2009-07-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26960
[Gtk] caret offset not updated when selecting text
Report the caret offset from the end of the selection so it works
correctly for multi-char selections too (ie, anything that is not
the zero width caret).
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
- 12:28 AM Changeset in webkit [45548] by
-
- 2 edits in trunk/WebCore
Fix Qt link error by adding two new localized strings
In r45474 two new strings got added to LocalizedStrings.h add
the definition of them to Qt.
- 12:27 AM Changeset in webkit [45547] by
-
- 2 edits in trunk/WebKit/qt
2009-07-04 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
Use the recently introduced FocusController::setFocused
Use the recently introduced FocusController::setFocused
in the Qt platform. The SelectionController will be updated
from within the FocusController now.
- Api/qwebpage.cpp: (QWebPagePrivate::focusInEvent): (QWebPagePrivate::focusOutEvent):
Jul 4, 2009:
- 10:53 AM Changeset in webkit [45546] by
-
- 2 edits in trunk/JavaScriptCore
- debug build fix
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::getLastParen):
- 7:21 AM Changeset in webkit [45545] by
-
- 5 edits in trunk/JavaScriptCore
2009-07-03 Yong Li <yong.li@torchmobile.com>
Reviewed by Maciej Stachowiak (and revised slightly)
RegExp::match to be optimized
https://bugs.webkit.org/show_bug.cgi?id=26957
Allow regexp matching to use Vectors with inline capacity instead of
allocating a new ovector buffer every time.
~5% speedup on SunSpider string-unpack-code test, 0.3% on SunSpider overall.
- runtime/RegExp.cpp: (JSC::RegExp::match):
- runtime/RegExp.h:
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructorPrivate::RegExpConstructorPrivate): (JSC::RegExpConstructorPrivate::lastOvector): (JSC::RegExpConstructorPrivate::tempOvector): (JSC::RegExpConstructorPrivate::changeLastOvector): (JSC::RegExpConstructor::performMatch): (JSC::RegExpMatchesArray::RegExpMatchesArray): (JSC::RegExpMatchesArray::fillArrayInstance): (JSC::RegExpConstructor::getBackref): (JSC::RegExpConstructor::getLastParen): (JSC::RegExpConstructor::getLeftContext): (JSC::RegExpConstructor::getRightContext):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncSplit):
- 7:20 AM Changeset in webkit [45544] by
-
- 2 edits in trunk/WebKitTools
2009-07-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
bugzilla-tool forgot how to obsolete patches
https://bugs.webkit.org/show_bug.cgi?id=26951
- Scripts/modules/bugzilla.py:
