Timeline
Jul 8, 2009:
- 9:12 PM Changeset in webkit [45658] by
-
- 6 edits in trunk
WebCore:
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure we can click outside the slider thumb and start dragging.
https://bugs.webkit.org/show_bug.cgi?id=26229
Previously we were assuming that if the thumb hasn't been clicked, we
wouldn't issue any value change upon dragging.
We need to handle the two different cases:
- Clicked in the thumb, we need to make sure the cursor is always pointing the same slider thumb point.
- Clicked outside, the cursor should always be pointing to the center of the thumb.
For simplicity, we don't remember the original point of the mouse down,
but an offset between that point and the thumb.
- rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::SliderThumbElement): (WebCore::SliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::mouseEventOffsetToThumb): Utility function.
- rendering/RenderSlider.h:
LayoutTests:
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure we can click outside the slider thumb and start dragging.
https://bugs.webkit.org/show_bug.cgi?id=26229
Along with the events chain, test that the slider value are correct,
and that clicking outside the slider and dragging works as expected.
- fast/forms/slider-mouse-events-expected.txt:
- fast/forms/slider-mouse-events.html:
- 9:09 PM Changeset in webkit [45657] by
-
- 3 edits in trunk/JavaScriptGlue
2009-07-08 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein
- fix <rdar://problem/6971484> REGRESSION (r30534): "Scrolling Credits" effect does not scroll on iMovie 7.1.4 on Tiger
In <http://trac.webkit.org/changeset/30534>, the prototype of
JSObject::put() which UserObjectImp had been overriding changed, but
UserObjectImp wasn't updated, so its override was no longer getting
called after that.
- UserObjectImp.cpp: (UserObjectImp::put): Match the current prototype of JSObject::put(). The PutPropertySlot argument is unused.
- UserObjectImp.h: Ditto.
- 6:29 PM Changeset in webkit [45656] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Versioning.
- 6:25 PM Changeset in webkit [45655] by
-
- 9 edits1 copy in trunk
WebCore:
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=27100
<rdar://problem/7042621>
Don't display "loading" in the <video> controller when
there is no src specified.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlStatusDisplayElement::update): The only way to find out if we have an element is currentSrc(). networkState() will always report LOADING according to the spec.
LayoutTests:
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Reenable media/video-empty-source.html. Test the controls
look when there is no src specified in a <video> element.
- platform/mac-leopard/media/video-empty-source-expected.checksum:
- platform/mac-leopard/media/video-empty-source-expected.png:
- platform/mac-leopard/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/mac/media/video-empty-source-expected.txt.
- platform/mac-snowleopard/Skipped:
- platform/mac/media/video-empty-source-expected.checksum:
- platform/mac/media/video-empty-source-expected.png:
- platform/mac/media/video-empty-source-expected.txt:
- 6:25 PM Changeset in webkit [45654] by
-
- 4 edits in trunk/WebKitTools
Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and actually work
Reviewed by Eric Seidel.
Removed the required BUGID argument from the "post-commits"
command and replaced it with a -bbug-id switch or parsing the commit log message for the bug URL. Fixed a bug in the
"post-commits" that would ignore the COMMITISH used and post a
patch of local changes against HEAD. Added --no-commit switch
to disable using the bulk of the ChangeLog entry as the comment
for the new patch.
- Scripts/bugzilla-tool: (bug_id_from_commit_message): Added. Returns a bug id from the commit log message, thus enforcing the need for a bug URL in the message. (PostCommitsAsPatchesToBug.init): Updated help description to match new behavior of pulling bug ids from commit log
messages instead of from the command line. Added -bbug-id switch and --no-comment switch.
(PostCommitsAsPatchesToBug.execute): Updated to use
bug_id_from_commit_message() to pull bug ids from commit log
messages. Also switched from SCM.create_patch() to use
SCM.create_patch_from_local_commit() to fix a bug where local
repository changes were posted as a patch instead of the
specific COMMITISH. Fall back to -bbug-id if no URL is found in the commit log message. Don't specify a comment for the
patch if --no-comment is used. Set cherry_pick argument to True
for Git.commit_ids_from_range_arguments() since we don't want
implicit commit range behavior for this command.
- Scripts/modules/bugzilla.py: Import datetime module. (timestamp): Added. Returns a timestamp in the form of "YYYYMMDDhhmmss". (Bugzilla.bug_server_regex): Added static attribute. (Bugzilla.add_patch_to_bug): Construct a more meaningful patch file name using the bug_id and timestamp().
- Scripts/modules/scm.py: (SCM.create_patch_from_local_commit): Added. (Git.create_patch_from_local_commit): Added. Runs "git diff" to return a patch for the given commit_id.
- 6:15 PM Changeset in webkit [45653] by
-
- 3 edits in trunk/LayoutTests
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Rubber-stamped by Simon Fraser.
Fix the media/controls-after-reload.html and media/controls-styling.html
on windows. (Needed a line at end of file)
- platform/win/media/controls-after-reload-expected.txt:
- platform/win/media/controls-styling-expected.txt:
- 5:15 PM Changeset in webkit [45652] by
-
- 3 edits2 adds in trunk/WebCore
2009-07-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Move V8GCController functions to their own file
https://bugs.webkit.org/show_bug.cgi?id=27102
- bindings/v8/V8GCController.cpp: Added.
- bindings/v8/V8GCController.h: Added.
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- 4:55 PM Changeset in webkit [45651] by
-
- 10 edits4 copies in trunk/WebCore
2009-07-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Split StorageArea and StorageNamespace into an interface and implementation.
https://bugs.webkit.org/show_bug.cgi?id=27072
I need to split StorageNamespace and StorageArea into an interface and
implementation. In a later patch, I'll implement a proxy interface
that'll run inside the Chromium renderer process.
Additionally, fix the alphabetical ordering of files I recently added
in the project files.
This is a continuation of other refactoring work:
https://bugs.webkit.org/show_bug.cgi?id=25376
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/StorageArea.cpp: (WebCore::StorageArea::create):
- storage/StorageArea.h: (WebCore::StorageArea::~StorageArea):
- storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp. (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy): (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear): (WebCore::StorageAreaImpl::contains): (WebCore::StorageAreaImpl::importItem): (WebCore::StorageAreaImpl::securityOrigin): (WebCore::StorageAreaImpl::close): (WebCore::StorageAreaImpl::blockUntilImportComplete): (WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
- storage/StorageAreaSync.h:
- storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace):
- storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
- storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp. (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea): (WebCore::StorageNamespaceImpl::close):
- storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
- 4:26 PM Changeset in webkit [45650] by
-
- 108 edits35 copies1 delete in branches/nitro-extreme
Merged r45600:45633 into nitro-extreme branch.
- 4:06 PM Changeset in webkit [45649] by
-
- 1 edit in trunk/WebCore/bindings/v8/V8Proxy.cpp
Unreviewed fix for Chromium link errors.
- 3:59 PM Changeset in webkit [45648] by
-
- 1 edit in trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-head-base-href.pl
Unreviewed change: Mark echo-head-base-href.pl executable to try to make tree green.
- 3:58 PM Changeset in webkit [45647] by
-
- 2 edits in trunk/WebKitTools
2009-07-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Make prepare-ChangeLog less shouty
https://bugs.webkit.org/show_bug.cgi?id=27098
- Scripts/prepare-ChangeLog:
- 3:48 PM Changeset in webkit [45646] by
-
- 12 edits in trunk/WebCore
2009-07-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Move garbage collector related functions from V8Proxy to V8GCController
https://bugs.webkit.org/show_bug.cgi?id=26967
This patch just moves the functions around in V8Proxy. We'll actually
move them to a separate file in another patch.
- bindings/v8/NPV8Object.cpp: (freeV8NPObject):
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::~ScheduledAction):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::gcProtectJSWrapper): (WebCore::ScriptController::gcUnprotectJSWrapper):
- bindings/v8/ScriptInstance.cpp: (WebCore::V8ScriptInstance::clear): (WebCore::V8ScriptInstance::set):
- bindings/v8/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::operator=): (WebCore::ScriptValue::clear):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::disposeListenerObject):
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::~V8LazyEventListener): (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
- bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::V8NodeFilterCondition): (WebCore::V8NodeFilterCondition::~V8NodeFilterCondition):
- bindings/v8/V8Proxy.cpp: (WebCore::V8GCController::registerGlobalHandle): (WebCore::V8GCController::unregisterGlobalHandle): (WebCore::V8GCController::gcProtect): (WebCore::V8GCController::gcUnprotect): (WebCore::V8Proxy::destroyGlobal): (WebCore::V8Proxy::updateDocumentWrapper): (WebCore::V8Proxy::clearDocumentWrapper): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::initContextIfNeeded):
- bindings/v8/V8Proxy.h: (WebCore::): (WebCore::GlobalHandleInfo::GlobalHandleInfo):
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
- 3:42 PM Changeset in webkit [45645] by
-
- 2 edits in trunk/LayoutTests
2009-07-08 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Holger Freyther a while ago.
Add two more tests to the Qt skip list due to missing DRT
features.
- platform/qt/Skipped:
- 3:36 PM Changeset in webkit [45644] by
-
- 11 edits4 deletes in trunk/WebCore
Reverting r45643 due to build bustage.
- 3:27 PM Changeset in webkit [45643] by
-
- 11 edits4 copies in trunk/WebCore
2009-07-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Split StorageArea and StorageNamespace into an interface and implementation.
https://bugs.webkit.org/show_bug.cgi?id=27072
I need to split StorageNamespace and StorageArea into an interface and
implementation. In a later patch, I'll implement a proxy interface
that'll run inside the Chromium renderer process.
Additionally, fix the alphabetical ordering of files I recently added
in the project files.
This is a continuation of other refactoring work:
https://bugs.webkit.org/show_bug.cgi?id=25376
- WebCore.xcodeproj/project.pbxproj:
- storage/StorageArea.cpp: (WebCore::StorageArea::create): (WebCore::StorageArea::~StorageArea):
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp. (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy): (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear): (WebCore::StorageAreaImpl::contains): (WebCore::StorageAreaImpl::importItem): (WebCore::StorageAreaImpl::securityOrigin): (WebCore::StorageAreaImpl::close): (WebCore::StorageAreaImpl::blockUntilImportComplete): (WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
- storage/StorageAreaSync.h:
- storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespace::~StorageNamespace):
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp. (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea): (WebCore::StorageNamespaceImpl::close):
- storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
- 3:13 PM Changeset in webkit [45642] by
-
- 6 edits18 adds in trunk
2009-07-08 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Prevents injection of HTML Base tag.
Tests: http/tests/security/xssAuditor/base-href-control-char.html
http/tests/security/xssAuditor/base-href-null-char.html
http/tests/security/xssAuditor/base-href-safe.html
http/tests/security/xssAuditor/base-href-safe2.html
http/tests/security/xssAuditor/base-href-scheme-relative.html
http/tests/security/xssAuditor/base-href.html
- html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::parseMappedAttribute): (WebCore::HTMLBaseElement::process): Modified to call XSSAuditor::canSetBaseElementURL to determine if it is safe to use base element URL.
- html/HTMLBaseElement.h: Added field m_hrefAttrValue to store unparsed base element URL.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL):
- page/XSSAuditor.h:
2009-07-08 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests prevention of injected HTML Base tag.
- http/tests/security/xssAuditor/base-href-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-control-char.html: Added.
- http/tests/security/xssAuditor/base-href-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-null-char.html: Added.
- http/tests/security/xssAuditor/base-href-safe-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-safe.html: Added.
- http/tests/security/xssAuditor/base-href-safe2-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-safe2.html: Added.
- http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-scheme-relative.html: Added.
- http/tests/security/xssAuditor/base-href.html: Added.
- http/tests/security/xssAuditor/resources/base-href: Added.
- http/tests/security/xssAuditor/resources/base-href/base-href-safe2.html: Added.
- http/tests/security/xssAuditor/resources/base-href/really-safe-script.js: Added.
- http/tests/security/xssAuditor/resources/base-href/safe-script.js: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Added.
- http/tests/security/xssAuditor/resources/safe-script.js: Added.
- 2:51 PM Changeset in webkit [45641] by
-
- 1 edit4 adds in trunk/WebCore
2009-07-08 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Upstream V8 npruntime bindings.
- 2:35 PM Changeset in webkit [45640] by
-
- 2 edits in trunk/WebCore
2009-07-08 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Darin Fisher.
Extending the PlatformFileHandle definition from PLATFORM(WIN) to
PLATFORM(WIN_OS)
- platform/FileSystem.h:
- 2:27 PM Changeset in webkit [45639] by
-
- 4 edits28 adds in trunk
2009-07-08 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Resolves issue when HTTP parameters contain null- and non-null-control- characters.
Tests: http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html
http/tests/security/xssAuditor/embed-tag-control-char.html
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/embed-tag.html
http/tests/security/xssAuditor/link-onclick-control-char.html
http/tests/security/xssAuditor/link-onclick-null-char.html
http/tests/security/xssAuditor/object-embed-tag-control-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag.html
http/tests/security/xssAuditor/object-tag.html
http/tests/security/xssAuditor/script-tag-post-control-char.html
http/tests/security/xssAuditor/script-tag-post-null-char.html
http/tests/security/xssAuditor/script-tag-with-source-control-char.html
http/tests/security/xssAuditor/script-tag-with-source-null-char.html
- page/XSSAuditor.cpp: (WebCore::isNonNullControlCharacter): Called by XSSAuditor::decodeURL. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): Added parameters matchNullCharacters, and matchNonNullControlCharacters. (WebCore::XSSAuditor::findInRequest): Added parameters matchNullCharacters, and matchNonNullControlCharacters.
- page/XSSAuditor.h:
2009-07-08 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests that HTTP parameters that contain null- and non-null-control characters are
properly handled by XSSAuditor.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html: Added.
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-control-char.html: Added.
- http/tests/security/xssAuditor/embed-tag-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-null-char.html: Added.
- http/tests/security/xssAuditor/embed-tag.html: Added.
- http/tests/security/xssAuditor/link-onclick-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick-control-char.html: Added.
- http/tests/security/xssAuditor/link-onclick-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick-null-char.html: Added.
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/object-embed-tag-control-char.html: Added.
- http/tests/security/xssAuditor/object-embed-tag-expected.txt: Added.
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/object-embed-tag-null-char.html: Added.
- http/tests/security/xssAuditor/object-embed-tag.html: Added.
- http/tests/security/xssAuditor/object-tag-expected.txt: Added.
- http/tests/security/xssAuditor/object-tag.html: Added.
- http/tests/security/xssAuditor/resources/execGetURL.swf: Added.
- http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post-control-char.html: Added.
- http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post-null-char.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-control-char.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-null-char.html: Added.
- 2:22 PM Changeset in webkit [45638] by
-
- 2 edits in trunk/WebKitTools
Bug 27083: bugzilla.py: Clean up bug_server use
Reviewed by Darin Adler.
- Scripts/modules/bugzilla.py: (Bugzilla.fetch_bug_ids_from_commit_queue): Use bug_server instead of hard-coding the URL. (Bugzilla.authenticate): Remove extra '/' before URL path. (Bugzilla.add_patch_to_bug): Ditto.
- 2:19 PM Changeset in webkit [45637] by
-
- 1 edit1 add in trunk/WebCore
2009-07-08 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Dimitri Glazkov.
Add DerivesSourcesAllInOne.cpp to help with release windows compilation.
https://bugs.webkit.org/show_bug.cgi?id=27093
This is specific for v8, no change in behavior.
- bindings/v8/DerivedSourcesAllInOne.cpp: Added.
- 2:14 PM Changeset in webkit [45636] by
-
- 3 edits in trunk/WebCore
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by NOBODY (OOPS!).
Make sure the Media controller doesn't fade in for no reason.
This is happening because a update() call to the controller
panel may reset the opacity to 1.0, given that it reloads the
style.
We also add a different fade in and fade out time to soften
the fade out effect.
No test case because this depends on how the movie is loaded.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::updateControlVisibility): Simplify , and make sure we stop the timer if there is no animation to do. (WebCore::RenderMedia::opacityAnimationTimerFired):
- rendering/RenderMedia.h:
- 2:05 PM Changeset in webkit [45635] by
-
- 2 edits in trunk/WebCore
Bug 27081: Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER)
Reviewed by Timothy Hatcher.
- platform/cf/RunLoopTimerCF.cpp: This code is only used on Mac OS X when HAVE(RUNLOOP_TIMER) is enabled, so wrap the code in that macro as well.
- 1:56 PM Changeset in webkit [45634] by
-
- 8 edits in trunk
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
- 1:34 PM Changeset in webkit [45633] by
-
- 6 edits in trunk/WebCore
Reviewed (an earlier version) by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=27090
Remove lockBackForwardList argument from HTMLFormElement::submit()
No change in behavior, so no tests.
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
- html/HTMLFormElement.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::scheduleFormSubmission):
- loader/FrameLoader.h: Don't pass lockBackForwardList around when it's known to be false.
- 1:32 PM Changeset in webkit [45632] by
-
- 2 edits in trunk/WebCore
2009-07-08 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Adam Barth.
Fix V8 idl codegen to use unique constant names
<https://bugs.webkit.org/show_bug.cgi?id=27089>
Embed the interface name in the global constant names so coagulating all
the .cc files into one compile unit works with V8 bindings.
Nothing added; Still compiles and pass tests.
- bindings/scripts/CodeGeneratorV8.pm:
- 11:56 AM Changeset in webkit [45631] by
-
- 2 edits in trunk/WebKitTools
2009-07-08 Brent Fulgham <bfulgham@webkit.org>
Build fix for Windows Cairo.
Cairo build was incorrectly #including the PixelDumpSupportCG.h
instead of PixelDumpSupportCairo.h
- DumpRenderTree/win/PixelDumpSupportWin.cpp: Correct #include
- 11:01 AM Changeset in webkit [45630] by
-
- 3 edits in trunk/WebCore
2009-07-08 Brent Fulgham <bfulgham@webkit.org>
Build fix: Add missing #includes for Windows (cURL) build.
The <winsock2.h> and <windows.h> headers were not being
included in Windows cURL builds.
- platform/network/ResourceHandleInternal.h:
- platform/network/curl/ResourceHandleManager.h:
- 10:50 AM Changeset in webkit [45629] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Add special test results for media/controls-after-reload.html
and media/controls-styling.html on Windows.
- platform/win/media/controls-after-reload-expected.txt: Added.
- platform/win/media/controls-styling-expected.txt: Added.
- 10:20 AM Changeset in webkit [45628] by
-
- 2 edits in trunk/LayoutTests
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Fix the Leopard test result for media/controls-after-reload.txt.
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- 9:42 AM Changeset in webkit [45627] by
-
- 2 edits in trunk/WebKitTools
2009-07-08 David Faure <faure@kde.org>
Reviewed by Ariya Hidayat.
Small documentation improvement for build-webkit --help
- Scripts/build-webkit: mention --debug option
- 9:38 AM Changeset in webkit [45626] by
-
- 2 edits in trunk/WebKit/qt
2009-07-08 Pradeepto Bhattacharya <pradeepto@kde.org>
Reviewed by Ariya Hidayat.
Build fix.
- WebCoreSupport/FrameLoaderClientQt.h: Removed the slot slotCallPolicyFunction().
- 7:44 AM Changeset in webkit [45625] by
-
- 3 edits in trunk/WebKit/qt
2009-07-08 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø.
Fix DRT instability issues with fast/loader/submit-form-while-parsing-2.html
When the form is submitted we call the policy function in the frame
loader delayed with a queued connection. That queued connection
sometimes interferes with the javascript timeout set in the testcase.
Eliminate the entire delayed policy function mechanism and instead always
call back directly, like in the other ports. In most other places we called
the slot directly anyway.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Remove m_policyFunction. (WebCore::FrameLoaderClientQt::callPolicyFunction): Call the policy function directly instead of emitting the queued signal. (WebCore::FrameLoaderClientQt::cancelPolicyCheck): Call callPolicyFunction directly. (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Ditto.
- WebCoreSupport/FrameLoaderClientQt.h: Remove m_policyFunction as well as the associated signal.
- 7:24 AM BuildingQtOnLinux edited by
- mention --debug argument for build-webkit, rather useful for developers (diff)
- 6:55 AM Changeset in webkit [45624] by
-
- 30 edits in trunk/WebCore
2009-07-08 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Kilzer.
WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884
Fix bunch of style issues in WebCore/rendering.
This patch is created to demonstrate cpplint.py.
No testcase because it's just a style fixes.
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::layout):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeEllipsisBox):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
- rendering/MediaControlElements.h:
- rendering/RenderArena.cpp:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::startDelayUpdateScrollInfo): (WebCore::RenderBlock::finishDelayUpdateScrollInfo): (WebCore::RenderBlock::updateScrollInfoAfterLayout): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine): (WebCore::RenderBlock::floatBottom): (WebCore::RenderBlock::leftBottom): (WebCore::RenderBlock::rightBottom):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::layoutLegend):
- rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): (WebCore::FlexBoxIterator::reset): (WebCore::FlexBoxIterator::first): (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderFrameSet.cpp: (WebCore::borderStartEdgeColor):
- rendering/RenderFrameSet.h:
- rendering/RenderImage.cpp:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::panScroll):
- rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::updateMarqueeStyle):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
- rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): (WebCore::RenderObject::localCaretRect):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
- rendering/RenderSlider.h:
- rendering/RenderTable.cpp: (WebCore::RenderTable::outerBorderBottom):
- rendering/RenderTableCol.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::itemIsSeparator):
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::supportsHover):
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::supportsFocusRing):
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addStackContent):
- rendering/SVGCharacterLayoutInfo.h:
- rendering/TextControlInnerElements.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):
- 6:33 AM Changeset in webkit [45623] by
-
- 2 edits in trunk/LayoutTests
2009-07-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Remove non-existing tests from the Qt skipped list.
- platform/qt/Skipped:
- 6:33 AM Changeset in webkit [45622] by
-
- 2 edits in trunk/WebKitTools
2009-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Correct git url of the Qt test-fonts.
- DumpRenderTree/qt/main.cpp: (main):
Jul 7, 2009:
- 11:46 PM Changeset in webkit [45621] by
-
- 2190 edits69 copies214 adds411 deletes in branches/nitro-extreme
Merged r45243:45600 into nitro-extreme branch.
- 10:38 PM Changeset in webkit [45620] by
-
- 5 edits in trunk/WebCore
Reduce complexity of lifetime management in DynamicNodeList caches
<https://bugs.webkit.org/show_bug.cgi?id=27068>
Reviewed by Maciej Stachowiak
Switch the Cache object used by DynamicNodeList into a normal
refcounted object rather than having a weird flag controlled
refcounting system, where positive refcount did not automatically
imply the cache object would actually still be live.
- 10:33 PM Changeset in webkit [45619] by
-
- 25 edits in trunk/LayoutTests/platform
Set the svn:mime-type property of recently-added PNG files to image/png.
- 10:26 PM Changeset in webkit [45618] by
-
- 4 edits8 adds in trunk
2009-07-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
-webkit-perspective should be a Length
https://bugs.webkit.org/show_bug.cgi?id=27066
-webkit-perspective should not take a magic valueless number, but should
be a normal Length value which responds to zooming. Treat valueless numbers
as pixels for backward compatibility.
Test: transforms/3d/general/perspective-units.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- 7:26 PM Changeset in webkit [45617] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Dave Hyatt.
Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView.
https://bugs.webkit.org/show_bug.cgi?id=27057
- WebView.cpp: (WebViewWndProc):
- 6:55 PM Changeset in webkit [45616] by
-
- 2 edits in trunk/WebKitTools
2009-07-07 Brady Eidson <beidson@apple.com>
Tiger build fix, work around missing NSString API.
- DumpRenderTree/mac/DumpRenderTree.mm: (dumpHistoryItem):
- 6:41 PM Changeset in webkit [45615] by
-
- 5 edits in trunk
WebKitTools:
2009-07-07 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls.
Make the dump of a history item agnostic to the layout of filesystem on the testing machine.
- DumpRenderTree/mac/DumpRenderTree.mm: (dumpHistoryItem):
- DumpRenderTree/win/DumpRenderTree.cpp: (dumpHistoryItem):
LayoutTests:
2009-07-07 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls.
- fast/loader/subframe-navigate-during-main-frame-load-expected.txt: Make the results agnostic to the layout of filesystem on the testing machine.
- 6:19 PM Changeset in webkit [45614] by
-
- 5 edits3 adds in trunk
WebCore:
2009-07-07 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
We need to make sure that when we reattach, we also reattach
the children in every MediaControlElement. Else we may end up
having no remaining or elapsed time.
We have to handle that, because we are using a special shadow
tree in the DOM, and that we are ourselves handling
attaching/detaching the renderer.
The strategy here is to try to implement ::attach(), and try
to reuse as much code as we can from the super class, including
children attachement.
Test: media/controls-after-reload.html
- rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::styleForElement): Code factoring. (WebCore::MediaControlElement::rendererIsNeeded): Code factoring. (WebCore::MediaControlElement::attach): Implement attach and call super class so that children are also attached. (WebCore::MediaControlElement::updateStyle): Use attach() (WebCore::MediaControlInputElement::styleForElement): Code factoring. (WebCore::MediaControlInputElement::rendererIsNeeded): Code factoring. (WebCore::MediaControlInputElement::attach): See above. (WebCore::MediaControlInputElement::updateStyle): Use attach()
- rendering/MediaControlElements.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls): Directly run attach() on the m_panel, which is a root node for our shadow tree.
LayoutTests:
2009-07-07 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure nothing changing the src and reloading doesn't
change the look of the controller.
- media/controls-after-reload.html: Added.
- platform/mac-leopard/media/controls-after-reload-expected.txt: Added.
- platform/mac/media/controls-after-reload-expected.txt: Added.
- 5:19 PM Changeset in webkit [45613] by
-
- 5 edits4 adds in trunk
2009-07-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Repaint issue after layer drops out of composited mode.
<https://bugs.webkit.org/show_bug.cgi?id=27022>
RenderLayers cache repaint rects in the form of m_repaintRect and m_outlineBox,
and expect these to stay valid from one style change to the next. These rects
are relative to the repaint container, so if a layer stops being composited,
we need to recompute them.
Test: compositing/repaint/layer-repaint-rects.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::computeRepaintRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):
- 4:45 PM Changeset in webkit [45612] by
-
- 8 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt and Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=26963 <rdar://problem/7030998> Reproducible crash at FontCache::getFontData() when a custom font is used in a pseudo-style
Test: fast/css/pseudo-cache-stale.html
- dom/Element.cpp: (WebCore::Element::pseudoStyleCacheIsInvalid): Added. Given the old style and the new style, goes over cached pseudo-styles in the old style and re-resolves the same style types off the new style. If any of the new pseudo-styles is different from the currently cached corresponding style, returns true. Otherwise, returns false. (WebCore::Element::recalcStyle): Validate the pseudo-style cache before deciding to keep the existing style.
- dom/Element.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::uncachedFirstLineStyle): Added this version that returns an uncached first-line style based off the given style. (WebCore::RenderObject::getUncachedPseudoStyle): Added the 'ownStyle' parameter.
- rendering/RenderObject.h:
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getPseudoStyleCache): Added. Returns the cached pseudo-styles in the passed-in vector.
- rendering/style/RenderStyle.h:
LayoutTests:
Reviewed by Dave Hyatt and Darin Adler.
- test for https://bugs.webkit.org/show_bug.cgi?id=26963 <rdar://problem/7030998> Reproducible crash at FontCache::getFontData() when a custom font is used in a pseudo-style
- fast/css/pseudo-cache-stale.html: Added.
- platform/mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
- platform/mac/fast/css/pseudo-cache-stale-expected.png: Added.
- platform/mac/fast/css/pseudo-cache-stale-expected.txt: Added.
- 4:44 PM Changeset in webkit [45611] by
-
- 1 edit1 move1 add in trunk/LayoutTests
2009-07-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
revise test expectations for bug 26088
http://bugs.webkit.org/show_bug.cgi?id=26088
generate pixel expectations, move location of generic expected file
for the crash test.
- fast/text/text-large-negative-letter-spacing-with-opacity-expected.txt: Copied from platform/mac/fast/text/text-large-negative-letter-spacing-with-opacity-expected.txt.
- platform/mac/fast/text/text-large-negative-letter-spacing-with-opacity-expected.txt: Removed.
- platform/mac/fast/text/text-letter-spacing-expected.checksum: Added.
- platform/mac/fast/text/text-letter-spacing-expected.png: Added.
- 3:04 PM Changeset in webkit [45610] by
-
- 1 edit1 add in trunk/LayoutTests
2009-07-07 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Add a specific leopard result for controls-styling.html, given that it doesn't
use the new controller look.
- platform/mac-leopard/media/controls-styling-expected.txt: Added.
- 2:52 PM Changeset in webkit [45609] by
-
- 15 edits in trunk
2009-07-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Stop loading constants into the register file.
Instead, use high register values (highest bit bar the sign bit set) to indicate
constants in the instruction stream, and when we encounter such a value load it
directly from the CodeBlock.
Since constants are no longer copied into the register file, this patch renders
the 'unexpected constant' mechanism redundant, and removes it.
2% improvement, thanks to Sam Weinig.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::mark): (JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h: (JSC::CodeBlock::isTemporaryRegisterIndex): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::isConstantRegisterIndex): (JSC::CodeBlock::getConstant): (JSC::ExecState::r):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::preserveLastVar): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::addConstantValue): (JSC::BytecodeGenerator::emitEqualityOp): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitNewError):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNode):
- interpreter/CallFrame.h: (JSC::ExecState::noCaller): (JSC::ExecState::hasHostCallFrameFlag): (JSC::ExecState::addHostCallFrameFlag): (JSC::ExecState::removeHostCallFrameFlag):
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::throwException): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
- parser/Nodes.cpp: (JSC::DeleteResolveNode::emitBytecode): (JSC::DeleteValueNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode):
- runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
- wtf/Platform.h:
LayoutTests:
2009-07-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
fast/js/global-recursion-on-full-stack.html is a little finicky.
The test recurses down the JS stack to find the bottom (catching this with an exception),
then tries to call a host function (document.write), switch writes new '<script>' code,
and expects this code to be run, then expects this code to try to call 'f();' again,
which it expects to fail, and it expects to catch that exception. However it is possible
that one of the earlier stages (the call to document.write, entering the interpreter to
run the new global code) will fail, depending on exactly how much stack space was free at
the point the last call to f() failed.
Tweak the test to make it work.
- fast/js/global-recursion-on-full-stack.html:
- 2:36 PM Changeset in webkit [45608] by
-
- 5 edits8 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix https://bugs.webkit.org/show_bug.cgi?id=27042 <rdar://problem/7010981> Incomplete painting of newly created floats
Tests: fast/repaint/float-in-new-block-with-layout-delta.html
fast/repaint/float-new-in-block.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): If the child has never been laid out before, paint its overhanging floats in addition to itself.
- rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect): Added and initialized a boolean everHadLayout member.
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Paint floats that have never been laid out before and did not move from (0, 0).
LayoutTests:
Reviewed by Simon Fraser.
- tests for https://bugs.webkit.org/show_bug.cgi?id=27042 <rdar://problem/7010981> Incomplete painting of newly created floats
- fast/repaint/float-in-new-block-with-layout-delta.html: Added.
- fast/repaint/float-new-in-block.html: Added.
- platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum: Added.
- platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
- platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added.
- platform/mac/fast/repaint/float-new-in-block-expected.checksum: Added.
- platform/mac/fast/repaint/float-new-in-block-expected.png: Added.
- platform/mac/fast/repaint/float-new-in-block-expected.txt: Added.
- 2:27 PM Changeset in webkit [45607] by
-
- 5 edits in trunk/WebKit/mac
2009-07-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- Fix <rdar://problem/6544693>.
For Flash, don't cache which methods or fields in an object are missing, since they can
be added at any time.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
- Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::shouldCacheMissingPropertiesAndMethods):
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): (WebKit::ProxyInstance::fieldNamed):
- 2:19 PM Changeset in webkit [45606] by
-
- 6 edits3 adds in trunk
WebCore:
2009-07-07 Brady Eidson <beidson@apple.com>
Contributions from both Darin Adler and Brady Eidson.
Reviewed by Darin Adler.
<rdar://problem/7024039> REGRESSION (r42158): Back-forward navigation does not work correctly on nytimes.com
In r42158 we lost some exclusions to making back/forward items for subframe navigations when a main frame
navigation was still in progress.
This patch makes things even better than it used to be by:
- Locking back/forward history at the time the navigation is scheduled, not after the load has committed.
- Locking back/forward history if *any* ancestor frame is still loading instead of just the main frame.
Test: fast/loader/subframe-navigate-during-main-frame-load.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Move out the history locking logic into a standalone function so it can be used from multiple sites. (WebCore::mustLockBackForwardList): Returns true if any ancestor frame is still loading. (WebCore::FrameLoader::scheduleLocationChange): Respect mustLockBackForwardList() in addition to the passed in lockBackForwardList flag. (WebCore::FrameLoader::scheduleFormSubmission): Ditto.
LayoutTests:
2009-07-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7024039> REGRESSION (r42158): Back-forward navigation does not work correctly on nytimes.com
- fast/loader/resources/subframe-navigate-during-main-frame-load2.html: Added.
- fast/loader/subframe-navigate-during-main-frame-load-expected.txt: Added.
- fast/loader/subframe-navigate-during-main-frame-load.html: Added.
- http/tests/navigation/javascriptlink-subframeload-expected.txt: Updated results to reflect the progression!
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt: Ditto!
- http/tests/misc/redirect-to-about-blank.html: Add missing semi-colons.
- 2:15 PM Changeset in webkit [45605] by
-
- 1 edit1 add in trunk/WebCore
2009-07-07 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Upstream DOMObjectsInclude.h from src.chromium.org.
- bindings/v8/DOMObjectsInclude.h: Added.
- 1:16 PM Changeset in webkit [45604] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Versioning.k
- 1:02 PM Changeset in webkit [45603] by
-
- 17 edits1 copy in trunk/WebCore
2009-07-07 Nate Chapin <Nate Chapin>
Reviewed by David Levin.
- 12:05 PM Changeset in webkit [45602] by
-
- 2 edits in trunk/WebCore
Bug 26995 - AX: Some webpages do not send AXLoadComplete
https://bugs.webkit.org/show_bug.cgi?id=26995
- 11:02 AM Changeset in webkit [45601] by
-
- 4 edits4 adds in trunk
WebCore:
2009-07-06 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure that the CSS properties letter-spacing, word-spacing,
line-height, text-transform, text-indent, text-shadow,
text-decoration and color do not affect the media element controls,
that display text.
Controls that display text are only present in when the theme
MediaControllerThemeQT is being used.
Test: media/controls-styling.html
- css/mediaControlsQT.css:
- rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::updateStyle): Special case for text-decoration. text-decoration can't be overriden from CSS, because text-decoration is additive for historical reasons.
LayoutTests:
2009-07-06 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure overriding properties won't affect the media controller.
- media/controls-styling.html: Added.
- 10:54 AM Changeset in webkit [45600] by
-
- 2 edits in trunk/JavaScriptCore
Bug 27025: Crashes and regression test failures related to regexps in 64-bit
Fix <https://bugs.webkit.org/show_bug.cgi?id=27025> / <rdar://problem/7033448>.
Reviewed by Darin Adler.
For x86_64 RegexGenerator uses rbx, a callee-save register, as a scratch register but
neglects to save and restore it. The change in handling of the output vector in r45545
altered code generation so that the RegExp::match was now storing important data in rbx,
which caused crashes and bogus results when it was clobbered.
- yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter): Save rbx.
(JSC::Yarr::RegexGenerator::generateReturn): Restore rbx.
- 10:30 AM Changeset in webkit [45599] by
-
- 2 edits in trunk/WebCore
2009-07-07 Albert Wong <ajwong@chromium.org>
Not reviewed, Chromium build fix.
Add in missing header + fix syntax issue that crept into last patch.
https://bugs.webkit.org/show_bug.cgi?id=27027
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
- 10:15 AM Changeset in webkit [45598] by
-
- 9 edits in trunk/WebCore
2009-07-07 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Make use of geometry information to decide which layers become composited.
<rdar://problem/7011947>
<https://bugs.webkit.org/show_bug.cgi?id=27021>
In addition to looking at painting order, also, optionally, take layer
overlap into account when deciding which RenderLayers need to be composited.
No testcase because DRT doesn't dump which layers are composited.
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): Removed the unused CompositingUpdate parameter, and just do an early return when there is no view.
- rendering/RenderLayer.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): (WebCore::RenderLayer::dirtyZOrderLists): (WebCore::RenderLayer::dirtyNormalFlowList): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::mustOverlapCompositedLayers): (WebCore::RenderLayer::setMustOverlapCompositedLayers): Change "overlay" to "overlap" for consistency with the use of "overlap" elsewhere.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout): compositingLayersNeedUpdate() renamed to compositingLayersNeedRebuild().
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
Tell the compositor that we started an accelerated animation or transition.
- rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::compositingLayersNeedRebuild): Renamed, since it's explicitly about changes in hierarchy now.
(WebCore::RenderLayerCompositor::setCompositingConsultsOverlap):
(WebCore::RenderLayerCompositor::compositingConsultsOverlap):
New getter and setter for whether compositing should take overlap into account.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): Add m_compositingConsultsOverlap, re-order some member variables.
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingEnabledFlag):
Whitespace cleanup and method rename.
(WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild):
Method and variable renaming.
(WebCore::RenderLayerCompositor::updateCompositingLayers):
Now we have to run through the layer hierarchy every time if looking
at overlap, because changes in layout can now alter compositing behavior.
We minimize work by tracking whether we actually need to change the layer
hierarchy via needLayerRebuild.
(WebCore::RenderLayerCompositor::updateBacking):
3D transforms turn off overlap mode.
(WebCore::RenderLayerCompositor::layerWasAdded):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
Method rename.
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::overlapsCompositedLayers):
Utility methods to add a layer to the overlapMap (computing the absolute
bounding box only if we haven't already done so), and testing the map
entries.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
If a layer would composite only because it comes after other compositing
layers in the painting order, then consult the overlap map to determine whether
it overlaps, and thus actually needs to composite.
Add layers to the map when they must be composited.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
Only do re-parenting work if the updateHierarchy flag is set.
(WebCore::RenderLayerCompositor::didStartAcceleratedAnimation):
When we start an accelerated transition or animation, we stop looking at
overlap because we can no longer guarantee correct front-to-back ordering while the
accelerated animation is running.
(WebCore::RenderLayerCompositor::needsToBeComposited):
Method renames.
- rendering/RenderView.cpp: (WebCore::RenderView::setMaximalOutlineSize): Add comment indicating that this could be optimized.
- 9:52 AM Changeset in webkit [45597] by
-
- 4 edits35 adds in trunk/BugsSite
Updated BugsSite with local changes on server
The new files were created by checksetup.pl during the upgrade
to Bugzilla 3.2.3. The rest are self-explanatory.
- data: Added "bugzilla-update.xml" to svn:ignore.
- data/attachments: Added "groups.*" to svn:ignore.
- data/params: Updated for a few changed parameters.
- lib/.htaccess: Added.
- skins/contrib/Dusk/IE-fixes.css: Added.
- skins/contrib/Dusk/admin.css: Added.
- skins/contrib/Dusk/create_attachment.css: Added.
- skins/contrib/Dusk/dependency-tree.css: Added.
- skins/contrib/Dusk/duplicates.css: Added.
- skins/contrib/Dusk/editusers.css: Added.
- skins/contrib/Dusk/help.css: Added.
- skins/contrib/Dusk/index.css: Added.
- skins/contrib/Dusk/panel.css: Added.
- skins/contrib/Dusk/params.css: Added.
- skins/contrib/Dusk/release-notes.css: Added.
- skins/contrib/Dusk/show_bug.css: Added.
- skins/contrib/Dusk/show_multiple.css: Added.
- skins/contrib/Dusk/summarize-time.css: Added.
- skins/contrib/Dusk/voting.css: Added.
- skins/contrib/Dusk/yui: Added.
- skins/contrib/Dusk/yui/calendar.css: Added.
- skins/custom/IE-fixes.css: Added.
- skins/custom/admin.css: Added.
- skins/custom/buglist.css: Added.
- skins/custom/create_attachment.css: Added.
- skins/custom/dependency-tree.css: Added.
- skins/custom/duplicates.css: Added.
- skins/custom/editusers.css: Added.
- skins/custom/help.css: Added.
- skins/custom/panel.css: Added.
- skins/custom/params.css: Added.
- skins/custom/release-notes.css: Added.
- skins/custom/show_bug.css: Added.
- skins/custom/show_multiple.css: Added.
- skins/custom/summarize-time.css: Added.
- skins/custom/voting.css: Added.
- skins/custom/yui: Added.
- skins/custom/yui/calendar.css: Added.
- 9:16 AM Changeset in webkit [45596] by
-
- 3 edits in trunk/WebCore
2009-07-07 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Fisher.
Speed up creation of V8 wrappers for DOM nodes.
This patch doesn't require new tests as it a set of refactorings
to speed up wrapper creation.
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- 8:51 AM Changeset in webkit [45595] by
-
- 5 edits in trunk
2009-07-07 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] textarea height property works only if other property are defined
https://bugs.webkit.org/show_bug.cgi?id=18984
Let WebCore handle textarea's metrics instead of readjusting it RenderthemeGtk.
Test: fast/forms/textarea-metrics.html
- platform/gtk/RenderThemeGtk.cpp:
- platform/gtk/RenderThemeGtk.h:
- LayoutTests/platform/gtk/Skipped:
- 7:29 AM Changeset in webkit [45594] by
-
- 6 edits3 adds in trunk
2009-07-07 Ben Murdoch <benm@google.com>
Reviewed by Antti Koivisto.
HTML5 Database becomes locked if a transaction is in progress when the page is refreshed.
https://bugs.webkit.org/show_bug.cgi?id=25711
Tests fix for https://bugs.webkit.org/show_bug.cgi?id=25711, where
web storage databases could become locked until the browser is
shut down if the page is refreshed whilst a transaction is in
progress.
- storage/database-lock-after-reload-expected.txt: Added.
- storage/database-lock-after-reload.html: Added.
- storage/resources/database-lock-after-reload-2.html: Added.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25711 where web
storage databases could become locked until the browser is shut
down if the page is refreshed whilst a transaction is in progress.
Test: storage/database-lock-after-reload.html
- storage/Database.cpp: (WebCore::Database::Database): (WebCore::Database::close): add code to inform the database thread we've closed the database. (WebCore::Database::performOpenAndVerify): add code to inform the database thread we've opened a database.
- storage/Database.h: (WebCore::Database::opened): return true iff the underlying sqlite database has been opened but not closed.
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread): Before the database thread terminates, close any databases that ran transactions in this thread. (WebCore::DatabaseThread::recordDatabaseOpen): Records a database that executed a transaction in this thread. (WebCore::DatabaseThread::recordDatabaseClosed): Removes a database from the set of open databases.
- storage/DatabaseThread.h: (WebCore::DatabaseThread::getThreadID): return the thread id for the database thread.
- 7:04 AM Changeset in webkit [45593] by
-
- 6 edits in trunk
WebKit/qt:
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Add Qt DRT hook for clearing the frame name.
- Api/qwebframe.cpp: (qt_drt_clearFrameName):
WebKitTools:
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Clear the main frame's name between loading pages, like in r36652. This
reduces the side-effects between test cases.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
LayoutTests:
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Removed subframe-self-close.html from the Qt skip list.
- platform/qt/Skipped:
- 5:52 AM Changeset in webkit [45592] by
-
- 2 edits1 add in trunk/WebCore
2009-07-07 Jiahua Huang <jhuangjiahua@gmail.com>
Reviewed by Jan Alonzo.
[Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791
Fix problem with UTF-16 clipboard pasted.
- manual-tests/gtk/paste-richtext-from-firefox.html: Added.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::documentFragment):
- 5:35 AM Changeset in webkit [45591] by
-
- 2 edits in trunk/WebCore
2009-07-07 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Change 'Continue debug' shortcut from F5 to F8 for consistency with Firebug.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- 3:48 AM Changeset in webkit [45590] by
-
- 2 edits in trunk/LayoutTests
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Added all current failing Qt DRT tests to the skip list, for a fresh start.
- platform/qt/Skipped:
- 3:27 AM Changeset in webkit [45589] by
-
- 2 edits in trunk/WebKitTools
2009-07-06 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Fix various layout tests with Qt's DRT.
Remember to set the focus on the web page before
loading.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
- 3:25 AM Changeset in webkit [45588] by
-
- 3 edits in trunk/WebKitTools
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø and Holger Freyther.
Fix timeout timer handling in Qt DRT.
Use QBasicTimer instead of startTimer/killTimer, to fix the
problem that starting the timeout timer did not stop a
previously started timer, causing multiple emissions of timeout.
The timerEvent() implementation now also checks the timer id, to
protect against double timeouts.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::timerEvent):
- DumpRenderTree/qt/jsobjects.h:
