⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 9, 2009:

10:26 PM Changeset in webkit [45702] by bfulgham@webkit.org
  • 6 edits in trunk/WebCore

2009-07-09 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

added InlineBox::isLeaf()
firstLeafChild()/lastLeafChild() not virtual and not callable on InlineBox anymore.
firstLeafChild()/lastLeafChild() will no longer return a node outside of the given subtree.
Removed firstLeafChildAfterBox()/lastLeafChildBeforeBox()
Removed potentially quadratic behavior if all nodes before/after a given box are empty InlineFlowBoxes

Currently, these methods are called on RootInlineBox objects only, so above changes should not have
any observable effect (only the removal of the square performance behavior could apply,
but the conditions for that are probably of a rather theoretical nature).

  • rendering/InlineBox.cpp: (WebCore::InlineBox::nextLeafChild): (WebCore::InlineBox::prevLeafChild):
  • rendering/InlineBox.h: (WebCore::InlineBox::isLeaf):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::firstLeafChild): (WebCore::InlineFlowBox::lastLeafChild):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::firstChild): (WebCore::InlineFlowBox::lastChild): (WebCore::InlineFlowBox::isLeaf):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::closestLeafChildForXPos):
10:12 PM Changeset in webkit [45701] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-07-09 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

Added InlineBox::baselinePosition() and lineHeight() methods
(adapted remaining code accordingly to use those methods)

No change in functionality.

  • rendering/InlineBox.h: (WebCore::InlineBox::baselinePosition): (WebCore::InlineBox::lineHeight):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically):
10:10 PM Changeset in webkit [45700] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-07-09 Maciej Stachowiak <​mjs@apple.com>

Not reviewed, build fix.

Windows build fix for the last change.

  • wtf/dtoa.cpp: Forgot to include Vector.h
10:01 PM Changeset in webkit [45699] by oliver@apple.com
  • 5 edits in trunk

Bug 27142 - canPlayType() should return empty string for unsupported content
<​https://bugs.webkit.org/show_bug.cgi?id=27142>

Reviewed by Maciej Stachowiak

Return "" instead of "no" for unsupport media types.

9:42 PM Changeset in webkit [45698] by bfulgham@webkit.org
  • 8 edits
    3 adds in trunk

WebCore:

2009-07-09 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

Implement the part of HTML5 spec that deals with parsing of <rp> and <rt> tags
in that their end tags are optional if followed by <rp>/<rt>.

Also specify a new accessibility role "annotation" for <rp> and <rt>.

Affected code parts are not enclosed in #IF ENABLE(RUBY), since the parsing
is not affected by whether ruby is rendered properly or not (in fact, it may
be more profound without ruby layouting, since the contents of <rp> are not hidden).

Test: fast/ruby/parse-rp.html

  • accessibility/AccessibilityObject.h: (WebCore::):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::roleValue):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::endTagRequirement): (WebCore::HTMLElement::tagPriority): (WebCore::inlineTagList):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::rpCreateErrorCheck): (WebCore::HTMLParser::rtCreateErrorCheck): (WebCore::HTMLParser::getNode):
  • html/HTMLParser.h:
  • html/HTMLTagNames.in:

LayoutTests:

2009-07-09 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Maciej Stachowiak.

Test proper parsing of HTML5 <rp> and <rt> tags.
Both tags are optional if followed by another <rp>/<rt> tag.


See also ​https://bugs.webkit.org/show_bug.cgi?id=26985

  • fast/ruby: Added.
  • fast/ruby/parse-rp-expected.txt: Added.
  • fast/ruby/parse-rp.html: Added.
9:29 PM Changeset in webkit [45697] by dimich@chromium.org
  • 5 edits in trunk/WebCore

2009-07-09 Dmitry Titov <​dimich@chromium.org>

Not reviewed, fix for previous commit.

The change ​http://trac.webkit.org/changeset/45695 did not correctly
enabled GTL and QT build flags. This caused layout tests failure.
This is speculative fix for those failures.

  • GNUmakefile.am: added ENABLE_CHANNEL_MESSAGING flag.
  • WebCore.pro: ditto.
  • page/DOMWindow.idl: touched to cause recompile.
  • workers/WorkerContext.idl: ditto.
8:45 PM Changeset in webkit [45696] by mjs@apple.com
  • 3 edits
    7 adds in trunk

2009-07-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION: crash in edge cases of floating point parsing.
​https://bugs.webkit.org/show_bug.cgi?id=27110
<rdar://problem/7044458>


Tests: fast/css/number-parsing-crash.html

fast/css/number-parsing-crash.html
fast/js/number-parsing-crash.html


  • wtf/dtoa.cpp: (WTF::BigInt::BigInt): Converted this to more a proper class, using a Vector with inline capacity

(WTF::lshift): Rearranged logic somewhat nontrivially to deal with the new way of sizing BigInts.
Added an assertion to verify that invariants are maintained.

All other functions are adapted fairly mechanically to the above changes.
(WTF::BigInt::clear):
(WTF::BigInt::size):
(WTF::BigInt::resize):
(WTF::BigInt::words):
(WTF::BigInt::append):
(WTF::multadd):
(WTF::s2b):
(WTF::i2b):
(WTF::mult):
(WTF::cmp):
(WTF::diff):
(WTF::b2d):
(WTF::d2b):
(WTF::ratio):
(WTF::strtod):
(WTF::quorem):
(WTF::dtoa):

2009-07-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.


REGRESSION: crash in edge cases of floating point parsing.
<rdar://problem/7044458>
​https://bugs.webkit.org/show_bug.cgi?id=27110


Test cases for both JavaScript and CSS use of dtoa.

  • fast/css/number-parsing-crash-2-expected.txt: Added.
  • fast/css/number-parsing-crash-2.html: Added.
  • fast/css/number-parsing-crash-expected.txt: Added.
  • fast/css/number-parsing-crash.html: Added.
  • fast/js/number-parsing-crash-expected.txt: Added.
  • fast/js/number-parsing-crash.html: Added.
  • fast/js/resources/number-parsing-crash.js: Added.
8:20 PM Changeset in webkit [45695] by dimich@chromium.org
  • 22 edits
    16 moves in trunk

2009-07-09 Drew Wilson <​atwilson@google.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • configure.ac: enable CHANNEL_MESSAGING.

JavaScriptCore:

2009-07-09 Drew Wilson <​atwilson@google.com>

Reviewed by Alexey Proskuryakov.

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • Configurations/FeatureDefines.xcconfig:

WebCore:

2009-07-09 Drew Wilson <​atwilson@google.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
is now implemented for Web Workers and is reasonably stable.

Tests: fast/events/message-channel-gc-2.html

fast/events/message-channel-gc-3.html
fast/events/message-channel-gc-4.html
fast/events/message-channel-gc.html
fast/events/message-channel-listener-circular-ownership.html
fast/events/message-port-clone.html
fast/events/message-port-constructor-for-deleted-document.html
fast/events/message-port-deleted-document.html
fast/events/message-port-deleted-frame.html
fast/events/message-port-inactive-document.html
fast/events/message-port-no-wrapper.html
fast/events/message-port.html
fast/workers/worker-cloneport.html
fast/workers/worker-messageport-gc.html
fast/workers/worker-messageport.html

  • Configurations/FeatureDefines.xcconfig: Turned on ENABLE_CHANNEL_MESSAGING.
  • WebCore/WebCore.vcproj/WebCoreCommon.vsprops: ditto.
  • WebCore/WebCore.vcproj/build-generated-files.sh: ditto.
  • WebCore/page/DOMWindow.idl: touch the file to cause re-generation of headers.
  • WebCore/workers/WorkerContext.idl: ditto.

WebKit/mac:

2009-07-09 Drew Wilson <​atwilson@google.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • Configurations/FeatureDefines.xcconfig:

WebKit/win:

2009-07-09 Drew Wilson <​atwilson@google.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2009-07-09 Drew Wilson <​atwilson@google.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.

  • Scripts/build-webkit:

LayoutTests:

2009-07-09 Drew Wilson <​atwilson@google.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=26903

Turned on CHANNEL_MESSAGING by default, re-enabled the various tests, and updated expected results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/constructors-cached-navigate-expected.txt:
  • fast/events/message-channel-gc-2.html: Renamed from LayoutTests/fast/events/message-channel-gc-2.html-disabled.
  • fast/events/message-channel-gc-3.html: Renamed from LayoutTests/fast/events/message-channel-gc-3.html-disabled.
  • fast/events/message-channel-gc-4.html: Renamed from LayoutTests/fast/events/message-channel-gc-4.html-disabled.
  • fast/events/message-channel-gc.html: Renamed from LayoutTests/fast/events/message-channel-gc.html-disabled.
  • fast/events/message-channel-listener-circular-ownership.html: Renamed from LayoutTests/fast/events/message-channel-listener-circular-ownership.html-disabled.
  • fast/events/message-port-clone.html: Renamed from LayoutTests/fast/events/message-port-clone.html-disabled.
  • fast/events/message-port-constructor-for-deleted-document.html: Renamed from LayoutTests/fast/events/message-port-constructor-for-deleted-document.html-disabled.
  • fast/events/message-port-deleted-document.html: Renamed from LayoutTests/fast/events/message-port-deleted-document.html-disabled.
  • fast/events/message-port-deleted-frame.html: Renamed from LayoutTests/fast/events/message-port-deleted-frame.html-disabled.
  • fast/events/message-port-inactive-document.html: Renamed from LayoutTests/fast/events/message-port-inactive-document.html-disabled.
  • fast/events/message-port-no-wrapper.html: Renamed from LayoutTests/fast/events/message-port-no-wrapper.html-disabled.
  • fast/events/message-port.html: Renamed from LayoutTests/fast/events/message-port.html-disabled.
  • fast/js/global-constructors-expected.txt:
  • fast/workers/worker-cloneport.html: Renamed from LayoutTests/fast/workers/worker-cloneport.html-disabled.
  • fast/workers/worker-messageport-gc.html: Renamed from LayoutTests/fast/workers/worker-messageport-gc.html-disabled.
  • fast/workers/worker-messageport.html: Renamed from LayoutTests/fast/workers/worker-messageport.html-disabled.
  • http/tests/security/MessagePort/event-listener-context.html: Renamed from LayoutTests/http/tests/security/MessagePort/event-listener-context.html-disabled
8:01 PM Changeset in webkit [45694] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

7:44 PM Changeset in webkit [45693] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 27016 - Interpreter crashes due to invalid array indexes
<​https://bugs.webkit.org/show_bug.cgi?id=27016>

Reviewed by Darin Adler.

Unsigned vs signed conversions results in incorrect behaviour in
64bit interpreter builds.

7:15 PM Changeset in webkit [45692] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <​jhoneycutt@apple.com>

A more robust fix for <rdar://problem/6930280> Reproducible crash at
USA Today photo gallery

Reviewed by Steve Falkenburg.

  • plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired): Protect the PluginView from destruction before calling its window proc.
7:15 PM Changeset in webkit [45691] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <​jhoneycutt@apple.com>

<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)

Reviewed by Darin Adler.

  • plugins/PluginView.cpp: (WebCore::PluginView::bindingInstance): Protect the PluginView from destruction before calling NPN_GetValue. If the renderer for the PluginView was destroyed during the call, and the PluginView's ref count is now 1, return null.
7:15 PM Changeset in webkit [45690] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <​jhoneycutt@apple.com>

Speculative fix for <rdar://problem/6991251> WER #13: Crash in
WebKit!WebCore::PluginView::performRequest+203 (1311461169)

Reviewed by Darin Adler.

  • plugins/PluginView.cpp: (WebCore::PluginView::performRequest): Protect the PluginView from destruction before performing a load. Removed some trailing whitespace.
6:49 PM Changeset in webkit [45689] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

2009-07-09 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Alice Liu.

Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271)
​https://bugs.webkit.org/show_bug.cgi?id=27140

Added a preference key to remember whether the user prefers the inspector detached or attached.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible (WebInspectorClient::closeWindow): Ditto (WebInspectorClient::attachWindow): Set preference to attached windows here (WebInspectorClient::detachWindow): Set preference to detached windows here (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached (WebInspectorClient::onClose): Pass both parameters into setWindowVisible
6:19 PM Changeset in webkit [45688] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-07-09 Darin Adler <Darin Adler>

Reviewed by Adele Peterson and Dan Bernstein.

<rdar://problem/7024972> Cannot set font to Helvetica Neue Light in Mail compose window

No regression test because this only affects the font panel.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]): Fix code that detects whether the font would survive a round trip by using the weight corresponding to "bold" or "normal" rather than the actual weight number.
6:04 PM Changeset in webkit [45687] by pdherbemont@apple.com
  • 8 edits
    1 copy
    2 deletes in trunk

WebCore:

2009-07-09 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

Full page zoom breaks remaining and elapsed time display in the <video> controller.
​https://bugs.webkit.org/show_bug.cgi?id=27123

We are changing the size of the time remaining and time elapsed field, to
automatically hide them, when the controller is too short.

Because we toggle the size between 0 and the previous value of the
controller, we miss any width change that may occur during full page zoom,
and we fail to restore a correct width.

This change fixes that problem by using a cloned style on which we
set the width to 0, and restoring the previous style when going back to
the normal width.

We take care about properly using the cloned style or the pseudo style,
by overriding styleForElement().

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::styleForElement): (WebCore::MediaControlElement::attach): (WebCore::MediaControlElement::updateStyle): (WebCore::MediaControlInputElement::styleForElement): (WebCore::MediaControlInputElement::attach): (WebCore::MediaControlInputElement::updateStyle): (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement): (WebCore::MediaControlTimeDisplayElement::styleForElement): (WebCore::MediaControlTimeDisplayElement::setVisible):
  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::shouldShowTimeDisplayControls): Make sure we take in account the zoom level when deciding if we should hide the ellapsed and remaining time.

LayoutTests:

2009-07-09 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

Full page zoom breaks remaining and elapsed time display in the &lt;video&gt; controller.
​https://bugs.webkit.org/show_bug.cgi?id=27123

  • media/video-zoom-controls.html: Remove duplicated code.
  • platform/mac-leopard/media/video-zoom-controls-expected.txt: Copied from LayoutTests/platform/mac/media/video-zoom-controls-expected.txt.
  • platform/mac-snowleopard/Skipped:
  • platform/mac/media/video-zoom-controls-expected.checksum: Removed. The test is not reliable for pixel test.
  • platform/mac/media/video-zoom-controls-expected.png: Removed.
  • platform/mac/media/video-zoom-controls-expected.txt: Updated
6:00 PM Changeset in webkit [45686] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/27114> bugzilla-tool: Parse short bug URL from commit log messages

Reviewed by Adam Roben.

  • Scripts/bugzilla-tool: (bug_id_from_commit_message): Check for the short bug URL before checking for the longer bugs.webkit.org URL.
5:55 PM Changeset in webkit [45685] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-07-09 Michael Nordman <Michael Nordman>

Reviewed by Darin Adler.

Fix chromium build bustage due to Widget being a RefCounted class.
​https://bugs.webkit.org/show_bug.cgi?id=27139

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:
5:41 PM Changeset in webkit [45684] by Chris Fleizach
  • 4 edits
    2 adds in trunk

Bug 27130 - Need to implement ARIA role="toolbar"
​https://bugs.webkit.org/show_bug.cgi?id=27130

4:26 PM Changeset in webkit [45683] by Dimitri Glazkov
  • 2 edits
    2 adds in trunk

JavaScriptCore:

2009-07-09 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[Chromium] Upstream JavaScriptCore.gypi, the project file for Chromium build.
​https://bugs.webkit.org/show_bug.cgi?id=27135

WebCore:

2009-07-09 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[Chromium] Upstream WebCore.gypi, the project file for Chromium build.
​https://bugs.webkit.org/show_bug.cgi?id=27135

  • WebCore.gypi: Added.
4:03 PM Changeset in webkit [45682] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Jon Honeycutt <​jhoneycutt@apple.com>

Build fix.

  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
3:54 PM Changeset in webkit [45681] by ap@webkit.org
  • 7 edits in trunk/WebKit/win

Reviewed by Oliver Hunt.

<rdar://problem/6921671> Visit count shouldn't be incremented by redirects.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Do not increase visit count if there is a redirect source. As a result, only pages that were explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking a link) will be counted.
  • Interfaces/IWebHistoryItemPrivate.idl:
  • WebHistory.cpp: (WebHistory::visitedURL):
  • WebHistory.h:
  • WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle):
  • WebHistoryItem.h: Marshal this new argument all the way down to WebCore.
3:33 PM Changeset in webkit [45680] by Simon Fraser
  • 4 edits in trunk/WebCore

2009-07-09 Simon Fraser <Simon Fraser>

Build fix for SnowLeopard.

Avoid using the contentsTransform methods if not on Leopard, because
we don't need to call them.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateContentsTransform):
  • platform/graphics/mac/WebLayer.mm: (-[WebLayer setNeedsDisplayInRect:]):
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]):
3:26 PM Changeset in webkit [45679] by Beth Dakin
  • 37 edits in trunk

WebCore:

2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix or make fixable:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createPlugin): Changed to return PassRefPtr (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::loadPlugin): Make the widget variable a RefPtr. Use .get() when passing it to RenderPart::setWidget(). (WebCore::FrameLoader::createJavaAppletWidget): Make the widget variable a RefPtr.
  • loader/FrameLoader.h: Changed the return type of createJavaAppletWidget().
  • loader/FrameLoaderClient.h: Change the return types of createPlugin() and createJavaAppletWidget().
  • page/Frame.cpp: (WebCore::Frame::createView): No need to call .get() since setWidget() takes a RefPtr.
  • page/FrameView.cpp: (WebCore::FrameView::layoutIfNeededRecursive): children() now returns a HashSet of RefPtrs.
  • page/FrameView.h: Remove inheritance from RefCounted; we pick this up from ScrollView through Widget.
  • platform/ScrollView.cpp: (WebCore::ScrollView::addChild): addChild() now takes a PassRefPtr and m_children now keeps a HashSet of RefPtrs.
  • platform/ScrollView.h: ScrollView constructor is now protected. (WebCore::ScrollView::children): m_children is now a HashSet of RefPtrs.
  • platform/Scrollbar.h: Remove inheritance from RefCounted; we pick this up from ScrollView through Widget.
  • platform/Widget.h: Inherit from RefCounted. Cleaned up some whitespace. Make m_widget a RefPtr.
  • plugins/PluginView.cpp: (WebCore::PluginView::create): Adopt the PluginView when returning it.
  • plugins/PluginView.h: Changed create() to return a PassRefPtr.
  • rendering/RenderApplet.cpp: Receive result in a RefPtr when calling createJavaAppletWidget().
  • rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget): setWidget() now takes a PassRefPtr. Also removed the manual ref of FrameViews. This is handled by having m_widget be a RefPtr. Removed deleteWidget().
  • rendering/RenderPart.h: Removed override of deleteWidget().
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::paint): (WebCore::RenderWidget::setOverlapTestResult): (WebCore::RenderWidget::updateWidgetPosition): Use .get(). (WebCore::RenderWidget::clearWidget): Don't call deleteWidget(). It was removed.
  • rendering/RenderWidget.h: Removed deleteWidget(). Made m_widget a RefPtr. (WebCore::RenderWidget::widget): Use .get().

WebKit/gtk:

2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):

WebKit/qt:

2009-07-09 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp: (WebFrame::createJavaAppletWidget):
  • WebFrame.h:

WebKit/wx:

2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>

Reviewed by Dave Hyatt.

Make Widget RefCounted to fix:

<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createPlugin): (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
  • WebKitSupport/FrameLoaderClientWx.h:
3:17 PM Changeset in webkit [45678] by weinig@apple.com
  • 25 edits in trunk/WebKit

WebKit/mac:

2009-07-09 Sam Weinig <​sam@webkit.org>

Reviewed by Steve Falkenburg.

Roll out r43848. The quirk is no longer necessary.

  • WebView/WebView.mm: (-[WebView WebCore::_userAgentForURL:WebCore::]):

WebKit/win:

2009-07-09 Sam Weinig <​sam@webkit.org>

Reviewed by Steve Falkenburg.

Roll out r43848. The quirk is no longer necessary.

  • WebView.cpp: (WebView::userAgentForKURL):
3:11 PM Changeset in webkit [45677] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 27129 - AX: possible assertion for a non-native image in accessibility
​https://bugs.webkit.org/show_bug.cgi?id=27129

2:57 PM Changeset in webkit [45676] by Simon Fraser
  • 8 edits in trunk/WebCore

2009-07-09 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Improve the appearance of text in compositing layers when -[CALayer geometryFlipped]
is not available.
<rdar://problem/6120614>

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsOrientation): (WebCore::GraphicsLayer::contentsOrientation):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): Add a m_contentsOrientation member and getter/setter to control whether the contents of this layer have a transform applied to them before display.
  • platform/graphics/mac/GraphicsLayerCA.h: New method to return the default contents orientation.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::flipTransform): Convenience method to return a transform with a Y flip.

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setSize):
After the size changes we have to update the contentsTransform.

(WebCore::GraphicsLayerCA::setGeometryOrientation):
(WebCore::GraphicsLayerCA::geometryOrientation):
If -setGeometryFlipped: is not available, use a children transform.

(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Tiled layers have issues with flipped contentsTransform, so just use
top-down drawing for them. Call updateContentsTransform() to set the
new contents transform after swapping layers.

(WebCore::GraphicsLayerCA::defaultContentsOrientation):
Use bottom-up when -geometryFlipped is not available, otherwise top-down.

(WebCore::GraphicsLayerCA::updateContentsTransform):
Set the layer contents transform based on contentsOrientation().

(WebCore::GraphicsLayerCA::setContentsLayer):
We have to manually flip contents layers if we're not using -geometryFlipped.

  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: Do early return if layerContents is nil. Flip the CTM if the layer has bottom-up coordinates, so that CG sees a CTM with no flip. Do the CGContextRestoreGState() after drawing the debug indicator.

(-[WebLayer setNeedsDisplayInRect:]):

  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]): Need to map the dirty rect through the contentsTransform.
2:53 PM Changeset in webkit [45675] by ap@webkit.org
  • 10 edits in trunk

Reviewed by Geoff Garen.

<rdar://problem/6921671> Visit counter shouldn't be incremented by redirects.

Can't test this functionality with layout tests.

WebCore:

  • WebCore.base.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::recordVisitAtTime): (WebCore::HistoryItem::visited):
  • history/HistoryItem.h: Only increase visit count if explicitly told to. Now, some visits change last access time, but do not increase visit count.

WebKit:

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Do not increase visit count if there is a redirect source. As a result, only pages that were explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking a link) will be counted.
  • History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
  • History/WebHistoryInternal.h:
  • History/WebHistoryItem.mm: (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
  • History/WebHistoryItemInternal.h: Marshal this new argument all the way down to WebCore.
2:47 PM Changeset in webkit [45674] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7046098> MediaControllerThemeQT requires QuickTime 7.6.3

Require QuickTime 7.6.3 or higher to enable the new media controller UI.

  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
1:57 PM Changeset in webkit [45673] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Sam Weinig <​sam@webkit.org>

Reviewed by Beth Dakin.

Remove incorrect comment.

  • page/MouseEventWithHitTestResults.h:
1:49 PM Changeset in webkit [45672] by mrowe@apple.com
  • 1 edit in tags/Safari-6531.3/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.

1:42 PM Changeset in webkit [45671] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

1:40 PM Changeset in webkit [45670] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.3

New tag.

1:00 PM Changeset in webkit [45669] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-09 Joe Mason <​joe.mason@torchmobile.com>

Reviewed by George Staikos.

Authors: Yong Li <​yong.li@torchmobile.com>, Joe Mason <​joe.mason@torchmobile.com>

​https://bugs.webkit.org/show_bug.cgi?id=27031
Add an override for deleteOwnedPtr(HDC) on Windows

  • wtf/OwnPtrCommon.h:
  • wtf/OwnPtrWin.cpp: (WTF::deleteOwnedPtr):
12:20 PM Changeset in webkit [45668] by oliver@apple.com
  • 2 edits in trunk/WebKitSite

JavaScript section of ​http://webkit.org is excessively out of date.

Reviewed by Geoff Garen.

This removes old todo entries (like adding an API, which we've had since Leopard),
and adds an additional todo for a webkit-less Objective-C API.

12:11 PM Changeset in webkit [45667] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Guard singal.h dependency with HAVE(SIGNAL_H) to enable building jsc
on SYMBIAN.

​https://bugs.webkit.org/show_bug.cgi?id=27026

Based on Norbert Leser's work.

  • jsc.cpp: (printUsageStatement): (parseArguments):
  • wtf/Platform.h:
11:18 AM Changeset in webkit [45666] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-07-09 Mads Ager <​ager@chromium.org>

Reviewed by Dimitri Glazkov.

Update the V8 bindings codegenerator to use the RGBColor::create
method to handle refcounts for RGBColor objects correctly.


  • bindings/scripts/CodeGeneratorV8.pm: Use RGBColor::create to create RGBColor objects.
10:41 AM Changeset in webkit [45665] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Crash in RenderMedia::styleDidChange.
<rdar://problem/7044313> CrashTracer: quicklook crashed generating thumbnail for page with
media element (RenderMedia::styleDidChange + 115)

Speculative fix for crash in styleDidChange. Null check controller elements before tell
them to update style.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange):
10:37 AM Changeset in webkit [45664] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Move V8DOMWrapper to its own file
​https://bugs.webkit.org/show_bug.cgi?id=27121

  • bindings/v8/V8DOMWrapper.cpp: Added. (WebCore::GetToStringName): (WebCore::ConstructorToString): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::domObjectHasJSWrapper): (WebCore::V8DOMWrapper::setJSWrapperForDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForDOMNode): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::domWrapperType): (WebCore::V8DOMWrapper::convertToNativeObjectImpl): (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::lookupDOMWrapper): (WebCore::V8DOMWrapper::convertDOMWrapperToNodeHelper): (WebCore::V8DOMWrapper::wrapNativeNodeFilter): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::setDOMWrapper): (WebCore::V8DOMWrapper::maybeDOMWrapper): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::isWrapperOfType): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object):
  • bindings/v8/V8DOMWrapper.h: Added. (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::wrapCPointer): (WebCore::V8DOMWrapper::extractCPointer): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent): (WebCore::V8DOMWrapper::extractCPointerImpl): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
10:20 AM Changeset in webkit [45663] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-07-09 David Hyatt <​hyatt@apple.com>

Reviewed by Adele Peterson.

Crash in setFocusedFrame.
<rdar://7032869> Crashing in setFocusedFrame on blogger.com.

Speculative fix for crasher in setFocusedFrame. Make sure to ref both frames and fire
the events only after the local member has been updated.

  • page/FocusController.cpp: (WebCore::FocusController::setFocusedFrame):
10:05 AM Changeset in webkit [45662] by eric.carlson@apple.com
  • 8 edits
    8 adds in trunk

2009-07-09 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Possible crashes when mouse clicks not dispatched because range input destroyed while
thumb is being dragged (e.g. scrub to end of movie)
<rdar://problem/7037494>
​https://bugs.webkit.org/show_bug.cgi?id=27101

Some shadow nodes "capture" all mouse events from mouseDown to mouseUp so they continue to
get mouse events even when the mouse is moved outside of the node. This is done by putting
EventHandler into a mode where it sends all mouse events to the node regardless of the
actual mouse position. The mode is set on mouseDown and cleared on mouseUp but if the
node is deleted while in this mode, the mouseUp is never sent and EventHandler continues
to try to send events to the deleted node. This sometimes results in a crash, and sometimes
in a page that doesn't respond to click events.

Tests: fast/forms/search-delete-while-cancel-button-clicked.html

fast/forms/slider-delete-while-dragging-thumb.html
media/audio-delete-while-slider-thumb-clicked.html
media/audio-delete-while-step-button-clicked.html

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::detach):

New, call setCapturingMouseEventsNode if capturing mouse events.

  • rendering/MediaControlElements.h:

Declare detach().

  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::detach):

New, call setCapturingMouseEventsNode if capturing mouse events.

  • rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::detach):

New, call setCapturingMouseEventsNode if capturing mouse events.

  • rendering/TextControlInnerElements.h:

Declare detach().

2009-07-09 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Possible crashes when mouse clicks not dispatched because range input destroyed while
thumb is being dragged (e.g. scrub to end of movie)
<rdar://problem/7037494>
​https://bugs.webkit.org/show_bug.cgi?id=27101

Tests deleting a control while capturing mouse events.

  • fast/forms/search-delete-while-cancel-button-clicked-expected.txt: Added.
  • fast/forms/search-delete-while-cancel-button-clicked.html: Added.
  • fast/forms/slider-delete-while-dragging-thumb-expected.txt: Added.
  • fast/forms/slider-delete-while-dragging-thumb.html: Added.
  • media/audio-delete-while-slider-thumb-clicked-expected.txt: Added.
  • media/audio-delete-while-slider-thumb-clicked.html: Added.
  • media/audio-delete-while-step-button-clicked-expected.txt: Added.
  • media/audio-delete-while-step-button-clicked.html: Added.
  • platform/mac-snowleopard/Skipped:

Skip the new media controller tests until <rdar://problem/6502936> is fixed.

8:50 AM Changeset in webkit [45661] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-07-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Dimitri Glazkov.

Enter the Frame's context before creating new objects in setContextDebugId.

​https://bugs.webkit.org/show_bug.cgi?id=27112

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
1:58 AM Changeset in webkit [45660] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-09 Simon Hausmann <Simon Hausmann>

Fix the Qt build.

  • WebCore.pro: Add new storage impl files to the build.
12:11 AM Changeset in webkit [45659] by abarth@webkit.org
  • 72 edits in trunk/WebCore

2009-07-08 Adam Barth <​abarth@webkit.org>

Rubber stamped by Eric Seidel.

[V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
​https://bugs.webkit.org/show_bug.cgi?id=27107

This patch is just renaming. Code motion will occur next.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::getReceiverObject):
  • bindings/v8/V8Collection.cpp: (WebCore::toOptionsCollectionSetter):
  • bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::getNamedPropertyOfCollection): (WebCore::nodeCollectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::nodeCollectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter):
  • bindings/v8/V8DOMMap.cpp: (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/V8GCController.cpp: (WebCore::enumerateDOMObjectMap): (WebCore::DOMObjectVisitor::visitDOMWrapper): (WebCore::GCPrologueVisitor::visitDOMWrapper): (WebCore::GCEpilogueVisitor::visitDOMWrapper):
  • bindings/v8/V8Helpers.cpp: (WebCore::wrapNPObject):
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::domObjectHasJSWrapper): (WebCore::V8DOMWrapper::setJSWrapperForDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForDOMNode): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::getConstructor): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8Proxy::retrieveWindow): (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::installDOMWindow): (WebCore::setDOMExceptionHelper): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::domWrapperType): (WebCore::V8DOMWrapper::convertToNativeObjectImpl): (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::lookupDOMWrapper): (WebCore::V8DOMWrapper::convertDOMWrapperToNodeHelper): (WebCore::V8DOMWrapper::wrapNativeNodeFilter): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::setDOMWrapper): (WebCore::V8DOMWrapper::maybeDOMWrapper): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::isWrapperOfType): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8Proxy::bindJsObjectToWindow):
  • bindings/v8/V8Proxy.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::wrapCPointer): (WebCore::V8DOMWrapper::extractCPointer): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent): (WebCore::V8DOMWrapper::extractCPointerImpl): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8Proxy::constructDOMObject): (WebCore::toV8):
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGPODTypeUtil::toSVGPODType):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::GetConstructor): (WebCore::WorkerContextExecutionProxy::ToV8Object): (WebCore::WorkerContextExecutionProxy::EventToV8Object): (WebCore::WorkerContextExecutionProxy::toV8):
  • bindings/v8/custom/V8AttrCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8): (WebCore::toCanvasStyle): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClientRectListCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CustomBinding.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK): (WebCore::V8Custom::GetTargetFrame):
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
  • bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLInputElementCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::removeElement):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NavigatorCustom.cpp: (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator): (WebCore::storageGetter): (WebCore::storageSetter): (WebCore::storageDeleter):
  • bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::SetTimeoutOrInterval): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

Jul 8, 2009:

9:12 PM Changeset in webkit [45658] by pdherbemont@apple.com
  • 6 edits in trunk

WebCore:

2009-07-08 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

Make sure we can click outside the slider thumb and start dragging.
​https://bugs.webkit.org/show_bug.cgi?id=26229

Previously we were assuming that if the thumb hasn't been clicked, we
wouldn't issue any value change upon dragging.

We need to handle the two different cases:

  • Clicked in the thumb, we need to make sure the cursor is always pointing the same slider thumb point.
  • Clicked outside, the cursor should always be pointing to the center of the thumb.

For simplicity, we don't remember the original point of the mouse down,
but an offset between that point and the thumb.

  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::SliderThumbElement): (WebCore::SliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::mouseEventOffsetToThumb): Utility function.
  • rendering/RenderSlider.h:

LayoutTests:

2009-07-08 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

Make sure we can click outside the slider thumb and start dragging.
​https://bugs.webkit.org/show_bug.cgi?id=26229

Along with the events chain, test that the slider value are correct,
and that clicking outside the slider and dragging works as expected.

  • fast/forms/slider-mouse-events-expected.txt:
  • fast/forms/slider-mouse-events.html:
9:09 PM Changeset in webkit [45657] by mitz@apple.com
  • 3 edits in trunk/JavaScriptGlue

2009-07-08 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein

  • fix <rdar://problem/6971484> REGRESSION (r30534): "Scrolling Credits" effect does not scroll on iMovie 7.1.4 on Tiger

In <​http://trac.webkit.org/changeset/30534>, the prototype of
JSObject::put() which UserObjectImp had been overriding changed, but
UserObjectImp wasn't updated, so its override was no longer getting
called after that.

  • UserObjectImp.cpp: (UserObjectImp::put): Match the current prototype of JSObject::put(). The PutPropertySlot argument is unused.
  • UserObjectImp.h: Ditto.
6:29 PM Changeset in webkit [45656] by sfalken@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.

6:25 PM Changeset in webkit [45655] by pdherbemont@apple.com
  • 9 edits
    1 copy in trunk

WebCore:

2009-07-08 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=27100
<rdar://problem/7042621>

Don't display "loading" in the <video> controller when
there is no src specified.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlStatusDisplayElement::update): The only way to find out if we have an element is currentSrc(). networkState() will always report LOADING according to the spec.

LayoutTests:

2009-07-08 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=27100

Reenable media/video-empty-source.html. Test the controls
look when there is no src specified in a <video> element.

  • platform/mac-leopard/media/video-empty-source-expected.checksum:
  • platform/mac-leopard/media/video-empty-source-expected.png:
  • platform/mac-leopard/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/mac/media/video-empty-source-expected.txt.
  • platform/mac-snowleopard/Skipped:
  • platform/mac/media/video-empty-source-expected.checksum:
  • platform/mac/media/video-empty-source-expected.png:
  • platform/mac/media/video-empty-source-expected.txt:
6:25 PM Changeset in webkit [45654] by ddkilzer@apple.com
  • 4 edits in trunk/WebKitTools

Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and actually work

<​https://bugs.webkit.org/show_bug.cgi?id=27062>

Reviewed by Eric Seidel.

Removed the required BUGID argument from the "post-commits"

command and replaced it with a -bbug-id switch or parsing the

commit log message for the bug URL. Fixed a bug in the
"post-commits" that would ignore the COMMITISH used and post a
patch of local changes against HEAD. Added --no-commit switch
to disable using the bulk of the ChangeLog entry as the comment
for the new patch.

  • Scripts/bugzilla-tool: (bug_id_from_commit_message): Added. Returns a bug id from the commit log message, thus enforcing the need for a bug URL in the message. (PostCommitsAsPatchesToBug.init): Updated help description to match new behavior of pulling bug ids from commit log
messages instead of from the command line. Added -bbug-id

switch and --no-comment switch.
(PostCommitsAsPatchesToBug.execute): Updated to use
bug_id_from_commit_message() to pull bug ids from commit log
messages. Also switched from SCM.create_patch() to use
SCM.create_patch_from_local_commit() to fix a bug where local
repository changes were posted as a patch instead of the

specific COMMITISH. Fall back to -bbug-id if no URL is found

in the commit log message. Don't specify a comment for the
patch if --no-comment is used. Set cherry_pick argument to True
for Git.commit_ids_from_range_arguments() since we don't want
implicit commit range behavior for this command.

  • Scripts/modules/bugzilla.py: Import datetime module. (timestamp): Added. Returns a timestamp in the form of "YYYYMMDDhhmmss". (Bugzilla.bug_server_regex): Added static attribute. (Bugzilla.add_patch_to_bug): Construct a more meaningful patch file name using the bug_id and timestamp().
  • Scripts/modules/scm.py: (SCM.create_patch_from_local_commit): Added. (Git.create_patch_from_local_commit): Added. Runs "git diff" to return a patch for the given commit_id.
6:15 PM Changeset in webkit [45653] by pdherbemont@apple.com
  • 3 edits in trunk/LayoutTests

2009-07-08 Pierre d'Herbemont <​pdherbemont@apple.com>

Rubber-stamped by Simon Fraser.

Fix the media/controls-after-reload.html and media/controls-styling.html
on windows. (Needed a line at end of file)

  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
5:15 PM Changeset in webkit [45652] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-07-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] Move V8GCController functions to their own file
​https://bugs.webkit.org/show_bug.cgi?id=27102

  • bindings/v8/V8GCController.cpp: Added.
  • bindings/v8/V8GCController.h: Added.
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
4:55 PM Changeset in webkit [45651] by darin@chromium.org
  • 10 edits
    4 copies in trunk/WebCore

2009-07-08 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Split StorageArea and StorageNamespace into an interface and implementation.
​https://bugs.webkit.org/show_bug.cgi?id=27072

I need to split StorageNamespace and StorageArea into an interface and
implementation. In a later patch, I'll implement a proxy interface
that'll run inside the Chromium renderer process.

Additionally, fix the alphabetical ordering of files I recently added
in the project files.

This is a continuation of other refactoring work:
​https://bugs.webkit.org/show_bug.cgi?id=25376

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/StorageArea.cpp: (WebCore::StorageArea::create):
  • storage/StorageArea.h: (WebCore::StorageArea::~StorageArea):
  • storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp. (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy): (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear): (WebCore::StorageAreaImpl::contains): (WebCore::StorageAreaImpl::importItem): (WebCore::StorageAreaImpl::securityOrigin): (WebCore::StorageAreaImpl::close): (WebCore::StorageAreaImpl::blockUntilImportComplete): (WebCore::StorageAreaImpl::dispatchStorageEvent):
  • storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
  • storage/StorageAreaSync.h:
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace):
  • storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
  • storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp. (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea): (WebCore::StorageNamespaceImpl::close):
  • storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
4:26 PM Changeset in webkit [45650] by barraclough@apple.com
  • 108 edits
    35 copies
    1 delete in branches/nitro-extreme

Merged r45600:45633 into nitro-extreme branch.

4:06 PM Changeset in webkit [45649] by abarth@webkit.org
  • 1 edit in trunk/WebCore/bindings/v8/V8Proxy.cpp

Unreviewed fix for Chromium link errors.

3:59 PM Changeset in webkit [45648] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-head-base-href.pl

Unreviewed change: Mark echo-head-base-href.pl executable to try to make tree green.

3:58 PM Changeset in webkit [45647] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.

Make prepare-ChangeLog less shouty
​https://bugs.webkit.org/show_bug.cgi?id=27098

  • Scripts/prepare-ChangeLog:
3:48 PM Changeset in webkit [45646] by abarth@webkit.org
  • 12 edits in trunk/WebCore

2009-07-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] Move garbage collector related functions from V8Proxy to V8GCController
​https://bugs.webkit.org/show_bug.cgi?id=26967

This patch just moves the functions around in V8Proxy. We'll actually
move them to a separate file in another patch.

  • bindings/v8/NPV8Object.cpp: (freeV8NPObject):
  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::~ScheduledAction):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::gcProtectJSWrapper): (WebCore::ScriptController::gcUnprotectJSWrapper):
  • bindings/v8/ScriptInstance.cpp: (WebCore::V8ScriptInstance::clear): (WebCore::V8ScriptInstance::set):
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::operator=): (WebCore::ScriptValue::clear):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::disposeListenerObject):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::~V8LazyEventListener): (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::V8NodeFilterCondition): (WebCore::V8NodeFilterCondition::~V8NodeFilterCondition):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8GCController::registerGlobalHandle): (WebCore::V8GCController::unregisterGlobalHandle): (WebCore::V8GCController::gcProtect): (WebCore::V8GCController::gcUnprotect): (WebCore::V8Proxy::destroyGlobal): (WebCore::V8Proxy::updateDocumentWrapper): (WebCore::V8Proxy::clearDocumentWrapper): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::initContextIfNeeded):
  • bindings/v8/V8Proxy.h: (WebCore::): (WebCore::GlobalHandleInfo::GlobalHandleInfo):
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
3:42 PM Changeset in webkit [45645] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2009-07-08 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Holger Freyther a while ago.

Add two more tests to the Qt skip list due to missing DRT
features.

  • platform/qt/Skipped:
3:36 PM Changeset in webkit [45644] by darin@chromium.org
  • 11 edits
    4 deletes in trunk/WebCore

Reverting r45643 due to build bustage.

3:27 PM Changeset in webkit [45643] by darin@chromium.org
  • 11 edits
    4 copies in trunk/WebCore

2009-07-08 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Split StorageArea and StorageNamespace into an interface and implementation.
​https://bugs.webkit.org/show_bug.cgi?id=27072

I need to split StorageNamespace and StorageArea into an interface and
implementation. In a later patch, I'll implement a proxy interface
that'll run inside the Chromium renderer process.

Additionally, fix the alphabetical ordering of files I recently added
in the project files.

This is a continuation of other refactoring work:
​https://bugs.webkit.org/show_bug.cgi?id=25376

  • WebCore.xcodeproj/project.pbxproj:
  • storage/StorageArea.cpp: (WebCore::StorageArea::create): (WebCore::StorageArea::~StorageArea):
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp. (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy): (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear): (WebCore::StorageAreaImpl::contains): (WebCore::StorageAreaImpl::importItem): (WebCore::StorageAreaImpl::securityOrigin): (WebCore::StorageAreaImpl::close): (WebCore::StorageAreaImpl::blockUntilImportComplete): (WebCore::StorageAreaImpl::dispatchStorageEvent):
  • storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
  • storage/StorageAreaSync.h:
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespace::~StorageNamespace):
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp. (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea): (WebCore::StorageNamespaceImpl::close):
  • storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
3:13 PM Changeset in webkit [45642] by abarth@webkit.org
  • 6 edits
    18 adds in trunk

2009-07-08 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.


​https://bugs.webkit.org/show_bug.cgi?id=26918


Prevents injection of HTML Base tag.

Tests: http/tests/security/xssAuditor/base-href-control-char.html

http/tests/security/xssAuditor/base-href-null-char.html
http/tests/security/xssAuditor/base-href-safe.html
http/tests/security/xssAuditor/base-href-safe2.html
http/tests/security/xssAuditor/base-href-scheme-relative.html
http/tests/security/xssAuditor/base-href.html

  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::parseMappedAttribute): (WebCore::HTMLBaseElement::process): Modified to call XSSAuditor::canSetBaseElementURL to determine if it is safe to use base element URL.
  • html/HTMLBaseElement.h: Added field m_hrefAttrValue to store unparsed base element URL.
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL):
  • page/XSSAuditor.h:

2009-07-08 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.


​https://bugs.webkit.org/show_bug.cgi?id=26918


Tests prevention of injected HTML Base tag.

  • http/tests/security/xssAuditor/base-href-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-control-char.html: Added.
  • http/tests/security/xssAuditor/base-href-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-null-char.html: Added.
  • http/tests/security/xssAuditor/base-href-safe-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-safe.html: Added.
  • http/tests/security/xssAuditor/base-href-safe2-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-safe2.html: Added.
  • http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-scheme-relative.html: Added.
  • http/tests/security/xssAuditor/base-href.html: Added.
  • http/tests/security/xssAuditor/resources/base-href: Added.
  • http/tests/security/xssAuditor/resources/base-href/base-href-safe2.html: Added.
  • http/tests/security/xssAuditor/resources/base-href/really-safe-script.js: Added.
  • http/tests/security/xssAuditor/resources/base-href/safe-script.js: Added.
  • http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Added.
  • http/tests/security/xssAuditor/resources/safe-script.js: Added.
2:51 PM Changeset in webkit [45641] by Nate Chapin
  • 1 edit
    4 adds in trunk/WebCore

2009-07-08 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream V8 npruntime bindings.

​https://bugs.webkit.org/show_bug.cgi?id=27094

2:35 PM Changeset in webkit [45640] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-08 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Darin Fisher.

Extending the PlatformFileHandle definition from PLATFORM(WIN) to
PLATFORM(WIN_OS)

​https://bugs.webkit.org/show_bug.cgi?id=27013

  • platform/FileSystem.h:
2:27 PM Changeset in webkit [45639] by abarth@webkit.org
  • 4 edits
    28 adds in trunk

2009-07-08 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.


​https://bugs.webkit.org/show_bug.cgi?id=27071


Resolves issue when HTTP parameters contain null- and non-null-control- characters.

Tests: http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html

http/tests/security/xssAuditor/embed-tag-control-char.html
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/embed-tag.html
http/tests/security/xssAuditor/link-onclick-control-char.html
http/tests/security/xssAuditor/link-onclick-null-char.html
http/tests/security/xssAuditor/object-embed-tag-control-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag.html
http/tests/security/xssAuditor/object-tag.html
http/tests/security/xssAuditor/script-tag-post-control-char.html
http/tests/security/xssAuditor/script-tag-post-null-char.html
http/tests/security/xssAuditor/script-tag-with-source-control-char.html
http/tests/security/xssAuditor/script-tag-with-source-null-char.html

  • page/XSSAuditor.cpp: (WebCore::isNonNullControlCharacter): Called by XSSAuditor::decodeURL. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): Added parameters matchNullCharacters, and matchNonNullControlCharacters. (WebCore::XSSAuditor::findInRequest): Added parameters matchNullCharacters, and matchNonNullControlCharacters.
  • page/XSSAuditor.h:

2009-07-08 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27071

Tests that HTTP parameters that contain null- and non-null-control characters are
properly handled by XSSAuditor.


  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html: Added.
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-control-char.html: Added.
  • http/tests/security/xssAuditor/embed-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/embed-tag-null-char.html: Added.
  • http/tests/security/xssAuditor/embed-tag.html: Added.
  • http/tests/security/xssAuditor/link-onclick-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick-control-char.html: Added.
  • http/tests/security/xssAuditor/link-onclick-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/link-onclick-null-char.html: Added.
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/object-embed-tag-control-char.html: Added.
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/object-embed-tag-null-char.html: Added.
  • http/tests/security/xssAuditor/object-embed-tag.html: Added.
  • http/tests/security/xssAuditor/object-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/object-tag.html: Added.
  • http/tests/security/xssAuditor/resources/execGetURL.swf: Added.
  • http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post-control-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-post-null-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-control-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-null-char.html: Added.
2:22 PM Changeset in webkit [45638] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 27083: bugzilla.py: Clean up bug_server use

<​https://bugs.webkit.org/show_bug.cgi?id=27083>

Reviewed by Darin Adler.

  • Scripts/modules/bugzilla.py: (Bugzilla.fetch_bug_ids_from_commit_queue): Use bug_server instead of hard-coding the URL. (Bugzilla.authenticate): Remove extra '/' before URL path. (Bugzilla.add_patch_to_bug): Ditto.
2:19 PM Changeset in webkit [45637] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/WebCore

2009-07-08 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Dimitri Glazkov.

Add DerivesSourcesAllInOne.cpp to help with release windows compilation.
​https://bugs.webkit.org/show_bug.cgi?id=27093

This is specific for v8, no change in behavior.

  • bindings/v8/DerivedSourcesAllInOne.cpp: Added.
2:14 PM Changeset in webkit [45636] by pdherbemont@apple.com
  • 3 edits in trunk/WebCore

2009-07-08 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by NOBODY (OOPS!).

​https://bugs.webkit.org/show_bug.cgi?id=27086

Make sure the Media controller doesn't fade in for no reason.
This is happening because a update() call to the controller
panel may reset the opacity to 1.0, given that it reloads the
style.

We also add a different fade in and fade out time to soften
the fade out effect.

No test case because this depends on how the movie is loaded.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::updateControlVisibility): Simplify , and make sure we stop the timer if there is no animation to do. (WebCore::RenderMedia::opacityAnimationTimerFired):
  • rendering/RenderMedia.h:
2:05 PM Changeset in webkit [45635] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Bug 27081: Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER)

<​https://bugs.webkit.org/show_bug.cgi?id=27081>

Reviewed by Timothy Hatcher.

  • platform/cf/RunLoopTimerCF.cpp: This code is only used on Mac OS X when HAVE(RUNLOOP_TIMER) is enabled, so wrap the code in that macro as well.
1:56 PM Changeset in webkit [45634] by bolsinga@apple.com
  • 8 edits in trunk

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:

WebCore:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.

  • WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
  • loader/FrameLoader.h:

WebKit/mac:

2009-07-08 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

Add -[WebView _isProcessingUserGesture]
​https://bugs.webkit.org/show_bug.cgi?id=27084

Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
  • WebView/WebViewPrivate.h:
1:34 PM Changeset in webkit [45633] by ap@webkit.org
  • 6 edits in trunk/WebCore

Reviewed (an earlier version) by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=27090
Remove lockBackForwardList argument from HTMLFormElement::submit()

No change in behavior, so no tests.

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
  • html/HTMLFormElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::scheduleFormSubmission):
  • loader/FrameLoader.h: Don't pass lockBackForwardList around when it's known to be false.
1:32 PM Changeset in webkit [45632] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-08 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Adam Barth.

Fix V8 idl codegen to use unique constant names
<​https://bugs.webkit.org/show_bug.cgi?id=27089>

Embed the interface name in the global constant names so coagulating all
the .cc files into one compile unit works with V8 bindings.

Nothing added; Still compiles and pass tests.

  • bindings/scripts/CodeGeneratorV8.pm:
11:56 AM Changeset in webkit [45631] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-08 Brent Fulgham <​bfulgham@webkit.org>

Build fix for Windows Cairo.

Cairo build was incorrectly #including the PixelDumpSupportCG.h
instead of PixelDumpSupportCairo.h

  • DumpRenderTree/win/PixelDumpSupportWin.cpp: Correct #include
11:01 AM Changeset in webkit [45630] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-07-08 Brent Fulgham <​bfulgham@webkit.org>

Build fix: Add missing #includes for Windows (cURL) build.
The <winsock2.h> and <windows.h> headers were not being
included in Windows cURL builds.

  • platform/network/ResourceHandleInternal.h:
  • platform/network/curl/ResourceHandleManager.h:
10:50 AM Changeset in webkit [45629] by pdherbemont@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-08 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

Add special test results for media/controls-after-reload.html
and media/controls-styling.html on Windows.

  • platform/win/media/controls-after-reload-expected.txt: Added.
  • platform/win/media/controls-styling-expected.txt: Added.
10:20 AM Changeset in webkit [45628] by pdherbemont@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-08 Pierre d'Herbemont <​pdherbemont@apple.com>

Fix the Leopard test result for media/controls-after-reload.txt.

  • platform/mac-leopard/media/controls-after-reload-expected.txt:
9:42 AM Changeset in webkit [45627] by ariya@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-08 David Faure <​faure@kde.org>

Reviewed by Ariya Hidayat.

Small documentation improvement for build-webkit --help

  • Scripts/build-webkit: mention --debug option
9:38 AM Changeset in webkit [45626] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-08 Pradeepto Bhattacharya <​pradeepto@kde.org>

Reviewed by Ariya Hidayat.

Build fix.

  • WebCoreSupport/FrameLoaderClientQt.h: Removed the slot slotCallPolicyFunction().
7:44 AM Changeset in webkit [45625] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-07-08 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=27080

Fix DRT instability issues with fast/loader/submit-form-while-parsing-2.html

When the form is submitted we call the policy function in the frame
loader delayed with a queued connection. That queued connection
sometimes interferes with the javascript timeout set in the testcase.

Eliminate the entire delayed policy function mechanism and instead always
call back directly, like in the other ports. In most other places we called
the slot directly anyway.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Remove m_policyFunction. (WebCore::FrameLoaderClientQt::callPolicyFunction): Call the policy function directly instead of emitting the queued signal. (WebCore::FrameLoaderClientQt::cancelPolicyCheck): Call callPolicyFunction directly. (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Ditto.
  • WebCoreSupport/FrameLoaderClientQt.h: Remove m_policyFunction as well as the associated signal.
7:24 AM BuildingQtOnLinux edited by faure@kde.org
mention --debug argument for build-webkit, rather useful for developers (diff)
6:55 AM Changeset in webkit [45624] by ddkilzer@apple.com
  • 30 edits in trunk/WebCore

2009-07-08 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Kilzer.

WebKit needs a style linting tool
​https://bugs.webkit.org/show_bug.cgi?id=25884

Fix bunch of style issues in WebCore/rendering.
This patch is created to demonstrate cpplint.py.

No testcase because it's just a style fixes.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::layout):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeEllipsisBox):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
  • rendering/MediaControlElements.h:
  • rendering/RenderArena.cpp:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::startDelayUpdateScrollInfo): (WebCore::RenderBlock::finishDelayUpdateScrollInfo): (WebCore::RenderBlock::updateScrollInfoAfterLayout): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine): (WebCore::RenderBlock::floatBottom): (WebCore::RenderBlock::leftBottom): (WebCore::RenderBlock::rightBottom):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::layoutLegend):
  • rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): (WebCore::FlexBoxIterator::reset): (WebCore::FlexBoxIterator::first): (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderFrameSet.cpp: (WebCore::borderStartEdgeColor):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::panScroll):
  • rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::updateMarqueeStyle):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): (WebCore::RenderObject::localCaretRect):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
  • rendering/RenderSlider.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::outerBorderBottom):
  • rendering/RenderTableCol.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::itemIsSeparator):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::supportsHover):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::supportsFocusRing):
  • rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addStackContent):
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/TextControlInnerElements.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):
6:33 AM Changeset in webkit [45623] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-08 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Remove non-existing tests from the Qt skipped list.

  • platform/qt/Skipped:
6:33 AM Changeset in webkit [45622] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-07 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Correct git url of the Qt test-fonts.

  • DumpRenderTree/qt/main.cpp: (main):
Note: See TracTimeline for information about the timeline view.