Context Navigation

← Previous Period
Next Period →

Timeline

Jul 11, 2009:

10:17 PM Changeset in webkit [45759] by oliver@apple.com

3 edits
3 adds in trunk

Bug 27187 - Match Gecko behaviour for canvas path mutation APIs on an empty path
<https://bugs.webkit.org/show_bug.cgi?id=27187>

Reviewed by Simon Fraser

Simple API change, check for the empty path and add appropriate point if necessary.

Test: fast/canvas/canvas-modify-emptyPath.html

7:15 PM Changeset in webkit [45758] by eric.carlson@apple.com

7 edits in trunk

2009-07-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):

Return "probably" if type has codecs parameter.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsType):

Ditto.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::supportsType):

Ditto.

2009-07-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186

media/video-can-play-type-expected.txt:
media/video-can-play-type.html:

1:26 PM Changeset in webkit [45757] by mrowe@apple.com

5 edits in trunk

Versioning.

1:24 PM Changeset in webkit [45756] by mrowe@apple.com

1 copy in branches/safari-4-branch

New branch.

12:21 PM Changeset in webkit [45755] by beidson@apple.com

2 edits in trunk/WebCore

2009-07-11 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe.

A worker-thread inspired follow-up for:
https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
REGRESSION: XHR stream connection blocks iFrame loading and resource downloading

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Don't perform the XHR compensation when the XHR is running on a worker thread. Accessing the global Cache data structures from a non-main thread is not currently supported.

11:44 AM Changeset in webkit [45754] by Simon Fraser

10 edits
6 moves
35 adds in trunk

2009-07-11 Simon Fraser <Simon Fraser>

Enable support for accelerated compositing and 3d transforms on Leopard.
<https://bugs.webkit.org/show_bug.cgi?id=20166>
<rdar://problem/6120614>

Reviewed by Oliver Hunt.

3:18 AM Changeset in webkit [45753] by Simon Hausmann

3 edits in trunk/WebCore

2009-07-11 Simon Hausmann <Simon Hausmann>

Fix the Qt build after r45724.

bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp):
bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):

Jul 10, 2009:

11:46 PM Changeset in webkit [45752] by abarth@webkit.org

4 edits
16 adds in trunk

WebCore:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26921

Implements support for HTML entities, so XSSAuditor can protect against attacks
encoded with HTML entities.

Tests: http/tests/security/xssAuditor/inline-event-HTML-entities.html

http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html
http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html
http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html
http/tests/security/xssAuditor/javascript-link-HTML-entities.html
http/tests/security/xssAuditor/link-onclick-entities.html
http/tests/security/xssAuditor/script-tag-entities.html
http/tests/security/xssAuditor/script-tag-with-source-entities.html

page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Modified to call WebCore::XSSAuditor::decodeHTMLEntities to decode HTML entities. (WebCore::XSSAuditor::decodeHTMLEntities): Added method to decode HTML entities. (WebCore::XSSAuditor::findInRequest):
page/XSSAuditor.h:

LayoutTests:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26921

Tests protection against HTML entities encoded attacks.

http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt: Added.
http/tests/security/xssAuditor/inline-event-HTML-entities.html: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html: Added.
http/tests/security/xssAuditor/javascript-link-HTML-entities.html: Added.
http/tests/security/xssAuditor/link-onclick-entities-expected.txt: Added.
http/tests/security/xssAuditor/link-onclick-entities.html: Added.
http/tests/security/xssAuditor/script-tag-entities-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-entities.html: Added.
http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-source-entities.html: Added.

11:25 PM Changeset in webkit [45751] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/27173> svn-apply: Fix typo in git command used to find deleted files

Reviewed by Eric Seidel.

Scripts/svn-apply: (scmWillDeleteFile): Changed 'head' to 'HEAD'.

11:16 PM Changeset in webkit [45750] by ddkilzer@apple.com

11 edits in trunk

Bug 27007: Build fixes when ICONDATABASE is disabled

<https://bugs.webkit.org/show_bug.cgi?id=27007>

Reviewed by Sam Weinig.

WebCore:

WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp to the project.
loader/icon/IconDatabase.cpp: Added #if ENABLE(ICONDATABASE)/#endif macro guard.
loader/icon/IconDatabase.h: Removed three public methods from #if ENABLE(ICONDATABASE)/#endif macro so that they may be stubbed out in IconDatabaseNone.cpp.
loader/icon/IconDatabaseNone.cpp: Added #if !ENABLE(ICONDATABASE)/#endif macro guard. (WebCore::IconDatabase::importIconURLForPageURL): Added. (WebCore::IconDatabase::importIconDataForIconURL): Added. (WebCore::IconDatabase::shouldStopThreadActivity): Added.

WebKit/mac:

Misc/WebIconDatabase.mm: (defaultClient): Return 0 if ICONDATABASE is disabled.
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out the body of the method if ICONDATABASE is disabled. (WebFrameLoaderClient::registerForIconNotification): Ditto.
WebCoreSupport/WebIconDatabaseClient.mm: Added #if ENABLE(ICONDATABASE)/#endif guard to source.
WebView/WebView.mm: (-[WebView setFrameLoadDelegate:]): Wrapped code that starts the icon database machinery in #if ENABLE(ICONDATABASE)/#endif. (-[WebView _registerForIconNotification:]): Wrapped method in #if ENABLE(ICONDATABASE)/#endif guard. (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
WebView/WebViewInternal.h: Wrapped methods in #if ENABLE(ICONDATABASE)/#endif guard. (-[WebView _registerForIconNotification:]): (-[WebView _dispatchDidReceiveIconFromWebFrame:]):

11:02 PM Changeset in webkit [45749] by abarth@webkit.org

6 edits
7 copies in trunk

WebCore:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Fixes issue where JavaScript URLs that contain null- and non-null control characters can
bypass XSSAuditor.

Tests: http/tests/security/xssAuditor/javascript-link-control-char.html

http/tests/security/xssAuditor/javascript-link-null-char.html
http/tests/security/xssAuditor/javascript-link.html

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in bindings/js/ScriptController.cpp.
page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs into its own method.
page/XSSAuditor.h:

LayoutTests:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Tests prevention of JavaScript URLs that contain null- and non-null control characters.

http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
http/tests/security/xssAuditor/javascript-link.html: Added.
http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.

10:50 PM Changeset in webkit [45748] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-07-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip tests in the Gtk port that

are dependent on eventSender
require platform-specific results
regressed (with links to the regression bug report)
failing (due to missing/incomplete implementation)

platform/gtk/Skipped:

10:36 PM Changeset in webkit [45747] by ddkilzer@apple.com

141 edits in trunk/WebCore

2009-07-10 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Kilzer.

WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Fix bunch of style issues by autofix of cpplint.
This patch is created to demonstrate the autofix of cpplint.py.

No new testcases because it's a style fix

css/CSSParser.cpp: (WebCore::CSSParser::parseMediaQuery): (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseValue): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::ShadowParseContext::commitValue): (WebCore::ShadowParseContext::commitLength): (WebCore::ShadowParseContext::commitColor): (WebCore::BorderImageParseContext::commitNumber): (WebCore::BorderImageParseContext::commitWidth): (WebCore::BorderImageParseContext::commitRule): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::lex): (WebCore::CSSParser::text):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
css/MediaList.cpp: (WebCore::MediaList::deleteMedium):
css/MediaQuery.h:
css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
css/MediaQueryEvaluator.h:
css/MediaQueryExp.h: (WebCore::MediaQueryExp::operator==):
css/WebKitCSSMatrix.h:
dom/Comment.h:
dom/Document.cpp: (WebCore::Document::setFocusedNode):
dom/Document.h: (WebCore::Document::setHasDashboardRegions):
dom/DocumentFragment.cpp: (WebCore::DocumentFragment::nodeName):
dom/DocumentFragment.h:
dom/DynamicNodeList.h:
dom/EditingText.h:
dom/Element.cpp: (WebCore::Element::dispatchAttrAdditionEvent):
dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::item):
dom/Node.cpp: (WebCore::Node::nodeValue): (WebCore::Node::nodeIndex):
dom/NodeRareData.h: (WebCore::NodeListsNodeData::create):
dom/Notation.h:
dom/ProcessingInstruction.h:
dom/Range.cpp: (WebCore::Range::processContents):
dom/StyledElement.cpp: (WebCore::toHex):
dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::): (WebCore::OffsetBuffer::readOutBytes): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::attributesStartElementNsHandler):
dom/XMLTokenizerQt.cpp: (WebCore::attributesStartElementNsHandler): (WebCore::XMLTokenizer::parseStartElement):
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
editing/Editor.cpp: (WebCore::Editor::pasteAsPlainText):
editing/SelectionController.cpp: (WebCore::SelectionController::directionOfEnclosingBlock):
editing/SmartReplaceICU.cpp: (WebCore::addAllCodePoints):
history/HistoryItem.cpp: (WebCore::HistoryItem::icon): (WebCore::HistoryItem::adoptVisitCounts):
html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyFillColor):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::isLiveLink):
html/HTMLAppletElement.h:
html/HTMLAudioElement.h:
html/HTMLBRElement.h:
html/HTMLBaseElement.h:
html/HTMLBaseFontElement.h:
html/HTMLDListElement.h:
html/HTMLDirectoryElement.h:
html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::reset):
html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::parseMappedAttribute):
html/HTMLHeadElement.h:
html/HTMLHtmlElement.h:
html/HTMLImageElement.h: (WebCore::HTMLImageElement::setLoadManually):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
html/HTMLIsIndexElement.h:
html/HTMLMarqueeElement.cpp:
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
html/HTMLMenuElement.h:
html/HTMLMetaElement.h:
html/HTMLModElement.h:
html/HTMLOListElement.h:
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
html/HTMLParamElement.h:
html/HTMLQuoteElement.h:
html/HTMLStyleElement.h:
html/HTMLTableCaptionElement.h:
html/HTMLTableCellElement.h:
html/HTMLTableColElement.h:
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::deleteRow):
html/HTMLTitleElement.h:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseNonHTMLText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write):
html/HTMLUListElement.h:
html/HTMLVideoElement.h:
html/TimeRanges.h: (WebCore::TimeRanges::Range::Range):
inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::newInspectorJSONObject):
page/Console.cpp: (WebCore::Console::addMessage):
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::defaultKeyboardEventHandler):
page/Frame.cpp: (WebCore::Frame::jsDefaultStatusBarText):
page/android/DragControllerAndroid.cpp: (WebCore::DragController::dragOperation):
page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::eventActivatedView):
page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
page/gtk/DragControllerGtk.cpp: (WebCore::DragController::dragOperation):
page/qt/DragControllerQt.cpp:
page/win/DragControllerWin.cpp: (WebCore::DragController::isCopyKeyDown):
page/win/FrameWin.h:
rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventOffsetToThumb):
rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setVerticalAlignLength): (WebCore::InheritedFlags::setUnicodeBidi): (WebCore::InheritedFlags::setCursor):
rendering/style/RenderStyleConstants.h: (WebCore::):
rendering/style/SVGRenderStyleDefs.h:
rendering/style/StyleInheritedData.h: (WebCore::StyleInheritedData::operator!=):
storage/DatabaseTask.h:
svg/GradientAttributes.h:
svg/LinearGradientAttributes.h:
svg/PatternAttributes.h:
svg/RadialGradientAttributes.h:
svg/SVGAnimatedPathData.h:
svg/SVGAnimatedPoints.h:
svg/SVGAnimationElement.h:
svg/SVGClipPathElement.h:
svg/SVGElementInstance.h:
svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
svg/SVGFEBlendElement.h:
svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
svg/SVGFEDistantLightElement.h:
svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
svg/SVGFEFloodElement.h:
svg/SVGFEFuncAElement.h:
svg/SVGFEFuncBElement.h:
svg/SVGFEFuncGElement.h:
svg/SVGFEFuncRElement.h:
svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
svg/SVGFEPointLightElement.h:
svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
svg/SVGFESpotLightElement.h:
svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
svg/SVGLineElement.cpp: (WebCore::SVGLineElement::parseMappedAttribute):
svg/SVGList.h:
svg/SVGListTraits.h: (WebCore::):
svg/SVGMPathElement.h:
svg/SVGMetadataElement.h:
svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc):
svg/SVGPathElement.h:
svg/SVGPathSegClosePath.h:
svg/SVGSVGElement.h:
svg/SVGSetElement.h:
svg/SVGSwitchElement.h:
svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::parseMappedAttribute):
svg/SVGTextPathElement.h:
svg/SVGTitleElement.h:
svg/SVGTransformable.cpp: (WebCore::):
svg/SVGViewSpec.cpp: (WebCore::):
svg/animation/SMILTime.cpp: (WebCore::operator+): (WebCore::operator-): (WebCore::operator*):
svg/animation/SVGSMILElement.h:
svg/graphics/SVGResource.cpp: (WebCore::clientMap):
wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::value):
wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::value):
workers/WorkerRunLoop.cpp:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection):
xml/XPathPath.h:

10:22 PM Changeset in webkit [45746] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported commands

Reviewed by Eric Seidel.

When bugzilla-tool -hhelp is invoked in an svn working

directory, don't print help for commands that are only supported
on git working directories.

Scripts/bugzilla-tool: (Command.init): Added requires_local_commits argument with a default of False. Set self.requires_local_commits attribute. (PostCommitsAsPatchesToBug.execute): Removed SCM.supports_local_commits() check since this is now handled by BugzillaTool.main(). (PostCommitsAsPatchesToBug.init): Added requires_local_commits=True argument to Command.init(). (BugzillaTool.commands_usage): Don't print help for commands if they require local commits and the current SCM doesn't support them. (BugzillaTool.main): If command_object requires local commits and the current SCM doesn't, exit with an error message.

9:20 PM Changeset in webkit [45745] by Simon Fraser

3 edits in trunk/WebKit/mac

2009-07-10 Simon Fraser <Simon Fraser>

Reviewed by John Sullivan.

Flashing as hardware layers are created and destroyed in some content
<rdar://problem/7032246>

There's a window of time between the end of one runloop cycle, after CA layers changes
have been committed, and the window display at the start of the next cycle when
CA may push updates to the screen before AppKit has drawn the view contents. If
we know that we need to do drawing synchronization (which we do when content moves
between a layer and the view), then we need to call -disableScreenUpdatesUntilFlush
from the existing runloop observer that is set up when layers need repainting to
ensure that layer updates don't reach the screen before view-based painting does.

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]): Tweak the comments

WebView/WebView.mm: (viewUpdateRunLoopObserverCallBack): (-[WebView _scheduleViewUpdate]): Add a big comment to explain the timing of things. Call -disableScreenUpdatesUntilFlush when the view _needsOneShotDrawingSynchronization.

9:02 PM Changeset in webkit [45744] by eric.carlson@apple.com

18 edits in trunk

2009-07-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7049066>.
Update SnowLeopard media controller layout.

css/mediaControlsQT.css:

Update for new layout.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieLoadType):

Added to replace isStreaming.

html/HTMLMediaElement.h:

Declare movieLoadType, remove isStreaming.

rendering/MediaControlElements.cpp: (WebCore::MediaControlStatusDisplayElement::update):

Use movieLoadType instead of isStreaming.

(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):

MediaControlElement is the base class, not HTMLInputElement.

(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded):

Ditto.

(WebCore::MediaControlRewindButtonElement::rendererIsNeeded):

Don't display rewind button for live streams.

(WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded):

MediaControlInputElement is the base class, not HTMLInputElement.

rendering/MediaControlElements.h:

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::getMediaUIPartStateFlags):

New, return wkDrawMediaUIPart flags.

(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):

Use getMediaUIPartStateFlags.

2009-07-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/7049066>.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

2009-07-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7049066>.
Update media tests for new SnowLeopard controller layout.

platform/mac/media/controls-after-reload-expected.txt:
platform/mac/media/controls-styling-expected.txt:
platform/mac/media/video-empty-source-expected.txt:
platform/mac/media/video-zoom-controls-expected.txt:

7:02 PM Changeset in webkit [45743] by abarth@webkit.org

6 edits
7 deletes in trunk

Reverted 45741. Tests failed.

6:39 PM Changeset in webkit [45742] by pkasting@chromium.org

1 edit
1 move in trunk/LayoutTests

2009-07-10 Peter Kasting <pkasting@google.com>

https://bugs.webkit.org/show_bug.cgi?id=19562
Disable a failing layout test caused by the patch for this bug until
I have time to determine that the obvious fix is correct.

fast/dom/domListEnumeration.html: Removed.
fast/dom/domListEnumeration.html-disabled: Copied from LayoutTests/fast/dom/domListEnumeration.html.

6:31 PM Changeset in webkit [45741] by abarth@webkit.org

6 edits
7 adds in trunk

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Fixes issue where JavaScript URLs that contain null- and non-null control characters can
bypass XSSAuditor.

Tests: http/tests/security/xssAuditor/javascript-link-control-char.html

http/tests/security/xssAuditor/javascript-link-null-char.html
http/tests/security/xssAuditor/javascript-link.html

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in bindings/js/ScriptController.cpp.
page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs into its own method.
page/XSSAuditor.h:

2009-07-10 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27151

Tests prevention of JavaScript URLs that contain null- and non-null control characters.

http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
http/tests/security/xssAuditor/javascript-link.html: Added.
http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.

6:21 PM Changeset in webkit [45740] by abarth@webkit.org

4 edits in trunk/WebKit

WebKit/mac:

2009-07-10 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig with the power of Grayskull.

Enable XSSAuditor by default.

WebView/WebPreferences.mm: (+[WebPreferences initialize]):

WebKit/win:

2009-07-10 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig with the power of Grayskull.

Enable XSSAuditor by default.

WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

5:57 PM Changeset in webkit [45739] by pkasting@chromium.org

17 edits
5 adds in trunk

WebCore:

2009-07-10 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Added build stuff and stub for the ValidityState class, part of HTML5
section Forms:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate

Test: fast/forms/ValidityState-001.html

DerivedSources.cpp: Fix aimed to include ValidityState files
DerivedSources.make: ditto
GNUmakefile.am: ditto
WebCore.gypi: ditto
WebCore.pro: ditto
WebCore.vcproj/WebCore.vcproj: ditto
WebCore.xcodeproj/project.pbxproj: ditto
WebCoreSources.bkl: ditto
html/HTMLButtonElement.idl: "validity" attribute
html/HTMLFieldSetElement.idl: ditto
html/HTMLFormControlElement.cpp: object getter (WebCore::HTMLFormControlElement::validity):
html/HTMLFormControlElement.h: ditto
html/HTMLInputElement.idl: "validity" attribute
html/HTMLSelectElement.idl: ditto
html/HTMLTextAreaElement.idl: ditto
html/ValidityState.cpp: Added. (WebCore::ValidityState::ValidityState): (WebCore::ValidityState::valid): validation flag
html/ValidityState.h: Added. (WebCore::ValidityState::create): creation routine (WebCore::ValidityState::control): ValidityState's parent getter (WebCore::ValidityState::valueMissing): validation flag (WebCore::ValidityState::typeMismatch): ditto (WebCore::ValidityState::patternMismatch): ditto (WebCore::ValidityState::tooLong): ditto (WebCore::ValidityState::rangeUnderflow): ditto (WebCore::ValidityState::rangeOverflow): ditto (WebCore::ValidityState::stepMismatch): ditto (WebCore::ValidityState::customError): ditto
html/ValidityState.idl: Added.

LayoutTests:

2009-07-10 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=19562
Minimal test case for ValidityState; more tests are going to be added
along with specific validation routines.

fast/forms/ValidityState-001-expected.txt: Added.
fast/forms/ValidityState-001.html: Added.

4:55 PM Changeset in webkit [45738] by mrowe@apple.com

4 edits in trunk

Versioning.

4:54 PM Changeset in webkit [45737] by mrowe@apple.com

1 copy in tags/Safari-6531.4

New tag.

4:21 PM Changeset in webkit [45736] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Second part of the "make Windows happier" dance.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

4:15 PM Changeset in webkit [45735] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Try and make the Windows build happy.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

4:01 PM Changeset in webkit [45734] by beidson@apple.com

2 edits in trunk/WebCore

2009-07-10 Brady Eidson <beidson@apple.com>

Style cleanup over my last patch.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::~XMLHttpRequest):

4:00 PM Changeset in webkit [45733] by kmccullough@apple.com

7 edits in trunk

JavaScriptCore:

2009-07-10 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoffrey Garen.

debugger/Debugger.h: Made this function virtual for use in WebCore's WebInspector.

WebCore:

2009-07-10 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoffrey Garen.

inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
inspector/JavaScriptCallFrame.h: New helper method, used below.

inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::detach): In the special case where we detach from a window currently executing JavaScript, manually tear down our representation of the JavaScript call stack, since we won't get any more callbacks from JavaScriptCore to automatically tear it down. It's too bad that WebCore is responsible for this kind of tracking -- in the future, it would be nice if more of the breakpoint handling was inside of JavaScriptCore.

3:57 PM Changeset in webkit [45732] by beidson@apple.com

5 edits in trunk/WebCore

2009-07-10 Brady Eidson <beidson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
REGRESSION: XHR stream connection blocks iFrame loading and resource downloading

With this test we ended up going over the maximum-connections-per-host limit that CFNetwork expected.
When that happened, the first request that was over the limit ended up in a bizarre state where it
wasn't fully serviced until after the long running XHR was complete.

Loader and Loader::Host work together to try to not exceed the max-connection limit but non-cache
resources - such as XHR - could still end up causing this limit to be exceeded.

This fix adds a workaround specifically for XHR while we hash out a more thorough solution that will
handle this at the resource handle level.

loader/loader.cpp: (WebCore::Loader::nonCacheRequestInFlight): (WebCore::Loader::nonCacheRequestComplete): (WebCore::Loader::Host::Host): (WebCore::Loader::Host::nonCacheRequestInFlight): (WebCore::Loader::Host::nonCacheRequestComplete): (WebCore::Loader::Host::servePendingRequests): Take nonCacheRequestsInFlight into account.
loader/loader.h: (WebCore::Loader::Host::processingResource): Take nonCacheRequestsInFlight into account.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestAsynchronously): Bump the nonCacheRequestInFlight count. (WebCore::XMLHttpRequest::didFail): Decrement that count if the Loader was notified. (WebCore::XMLHttpRequest::didFinishLoading): Ditto.

3:09 PM Changeset in webkit [45731] by yael.aharon@nokia.com

5 edits in trunk/WebKit/qt

2009-07-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27136

Fix a bug where webkit hangs when executing infinite JavaScript loop.

Api/qwebpage.cpp:
Api/qwebpage.h:
WebCoreSupport/ChromeClientQt.cpp:
tests/qwebpage/tst_qwebpage.cpp:

2:53 PM Changeset in webkit [45730] by bfulgham@webkit.org

4 edits in trunk

2009-07-10 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

ParserArenaDeletable overrides new, but it does not override delete.
ParserArenaDeletable must be freed by fastFree
because it is allocated by fastMalloc.

parser/NodeConstructors.h: (JSC::ParserArenaDeletable::operator delete):
parser/Nodes.h:

2:31 PM Changeset in webkit [45729] by Antti Koivisto

2 edits in trunk/WebCore

2009-07-10 Antti Koivisto <Antti Koivisto>

Try to unbreak non-Mac build.

page/ChromeClient.h: (WebCore::ChromeClient::formDidFocus): (WebCore::ChromeClient::formDidBlur):

2:28 PM Changeset in webkit [45728] by Beth Dakin

2 edits in trunk/WebCore

2009-07-10 Beth Dakin <Beth Dakin>

Reviewed by Anders Carlsson.

The rest of the fix for <rdar://problem/7038831> REGRESSION (TOT):
In Mail, a crash occurs at WebCore::Widget::afterMouseDown() after
clicking To Do's close box

Make the Widget* in passMouseDownEventToWidget() a RefPtr.

page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget):

2:19 PM Changeset in webkit [45727] by Simon Hausmann

2 edits in trunk/LayoutTests

2009-07-10 Simon Hausmann <Simon Hausmann>

No Review, just re-ordering Qt DRT skip list.

Moved skipped crash tests to the crash section.

platform/qt/Skipped:

2:10 PM Changeset in webkit [45726] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/27117> bugzilla-tool: use Mac OS X keychain for authentication

Reviewed by Eric Seidel.

Try reading credentials from git config first, then keychain if
running on Mac OS X, else prompt at the command-line.

Scripts/modules/bugzilla.py: Added "import platform". (credentials_from_git): Added. (credentials_from_keychain): Added. (is_mac_os_x): Added. (read_credentials): Added. (Bugzilla.init): Moved instance attribute bug_server to a static attribute named bug-server_url. (Bugzilla.bug_server_host): Added. Extracted host name from bug_server_url. (Bugzilla.bug_server_regex): Updated to be created using bug_server_host. (Bugzilla.bug_server_url): Renamed from bug_server. (Bugzilla.bug_url_for_bug_id): Updated for renaming of bug_server to bug_server_url. (Bugzilla.attachment_url_for_id): Ditto. (Bugzilla.fetch_bug_ids_from_commit_queue): Ditto. (Bugzilla.authenticate): Ditto. Updated to use read_credentials(). (Bugzilla.add_patch_to_bug): Ditto.

2:02 PM Changeset in webkit [45725] by ddkilzer@apple.com

4 edits
1 add in trunk/WebKitTools

<http://webkit.org/b/27115> bugzilla-tool: extract duplicate logging methods into a module

Reviewed by Adam Roben.

Scripts/bugzilla-tool: Removed error() and log() methods and added import of new logging module.
Scripts/modules/bugzilla.py: Ditto. Removed "import sys".
Scripts/modules/scm.py: Ditto.

Scripts/modules/logging.py: Added. (log): Added. (error): Added. Prefix error messages with "ERROR: ".

1:53 PM Changeset in webkit [45724] by eric@webkit.org

8 edits in trunk/WebCore

2009-07-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

rename getDOMStructure calls w/o JSGlobalObject* to deprecatedGetDOMStructure
https://bugs.webkit.org/show_bug.cgi?id=27157

This is the first step to fixing
https://bugs.webkit.org/show_bug.cgi?id=27088

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMBinding.h: (WebCore::deprecatedGetDOMStructure): (WebCore::createDOMObjectWrapper): (WebCore::createDOMNodeWrapper):
bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
bindings/js/JSRGBColor.cpp: (WebCore::JSRGBColor::JSRGBColor):
bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray):
bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::RuntimeObjectImp):

1:32 PM Changeset in webkit [45723] by bolsinga@apple.com

9 edits in trunk

WebCore:

2009-07-10 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Antti Koivisto.

Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Call the appropriate new ChromeClient methods for focus and blur.

html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFocusEvent): (WebCore::HTMLFormControlElement::dispatchBlurEvent):
html/HTMLFormControlElement.h:
loader/EmptyClients.h: (WebCore::EmptyChromeClient::formDidFocus): (WebCore::EmptyChromeClient::formDidBlur):
page/ChromeClient.h:

WebKit/mac:

2009-07-10 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Antti Koivisto.

Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Call the appropriate private delegate methods from the ChromeClient.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::formStateDidChange): (WebChromeClient::formDidFocus): (WebChromeClient::formDidBlur):
WebView/WebUIDelegatePrivate.h:

1:26 PM Changeset in webkit [45722] by Dimitri Glazkov

3 edits in trunk/LayoutTests

2009-07-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

Changing the test string from a platform-dependent file:/// to a more
generic http://.

https://bugs.webkit.org/show_bug.cgi?id=27138

fast/dom/anchor-toString-expected.txt:
fast/dom/anchor-toString.html:

1:25 PM Changeset in webkit [45721] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/7048741> REGRESSION: Error about missing SwMenuX.dll opening pages with Shockwave

Use altered search path while loading plug-ins. This modifies the DLL search order
to look in the directory containing the plug-in even if a call to SetDllDirectory
was previously made. Use of SetDllDirectory removes the current directory from the search path,
breaking the previous strategy for locating any dependent DLLs of the plug-in.

Reviewed by Jon Honeycutt.

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Use LoadLibraryEx with LOAD_WITH_ALTERED_SEARCH_PATH

1:15 PM Changeset in webkit [45720] by Simon Hausmann

2 edits in trunk/LayoutTests

2009-07-10 Simon Hausmann <Simon Hausmann>

No Review, just skipping a new test for Qt DRT.

Skip fast/forms/slider-delete-while-dragging-thumb.html due to missing eventSender
bits & pieces.

platform/qt/Skipped:

12:19 PM Changeset in webkit [45719] by Adam Roben

16 edits in trunk

Sort all our Xcode projects

Accomplished using sort-Xcode-project-file.

Requested by Dave Kilzer.

JavaScriptCore:

JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

WebCore.xcodeproj/project.pbxproj:

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKitExamplePlugins:

NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj:
NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj:

WebKitTools:

DrawTest/DrawTest.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:

12:18 PM Changeset in webkit [45718] by Adam Roben

2 edits in trunk/WebKitTools

Print prepare-ChangeLog's reminders to STDERR so they don't end up in the diff output

Fixes REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines
into the diff
<https://bugs.webkit.org/show_bug.cgi?id=27150>

Reviewed by Maciej Stachowiak.

Scripts/prepare-ChangeLog:

12:18 PM Changeset in webkit [45717] by Adam Roben

2 edits in trunk/WebKitTools

Use case-insensitive comparisons when sorting Xcode project files

This matches the sorting used in Xcode's files list.

Fixes Bug 27079: sort-Xcode-project-file should sort
case-insensitively, to match Xcode's files list
<https://bugs.webkit.org/show_bug.cgi?id=27079>

Reviewed by Dave Kilzer.

Scripts/sort-Xcode-project-file: (sortChildrenByFileName): (sortFilesByFileName): Lowercase the strings before comparing them so that the comparison will be case-insensitive.

12:10 PM Changeset in webkit [45716] by agl@chromium.org

2 edits in trunk/WebCore

2009-07-10 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: use disabled images for disabled widgets.

https://bugs.webkit.org/show_bug.cgi?id=27106

Previously, checkboxes and radio controls rendered the same even if disabled.
The Chromium side of this change is r20224.

rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::paintRadio):

11:54 AM Changeset in webkit [45715] by Simon Fraser

3 edits in trunk/WebCore

2009-07-10 Simon Fraser <Simon Fraser>

Reviewed by John Sullivan.

Fix crash when changing the zoom level in http://iphone.akamai.com/
<rdar://problem/7029077>

RenderLayerBacking's paintIntoLayer() method called updateLayerListsIfNeeded(),
which could potentially destroy that compositing layer, causing a crash.
Prevent this from happening by not doing a compositing update from paintIntoLayer().

The existing updateLayerListsIfNeeded() was renamed to updateCompositingAndLayerListsIfNeeded(),
and still does the compositing update. The new updateLayerListsIfNeeded() does not touch
compositing layers, and is still called from paintIntoLayer().

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateLayerListsIfNeeded): (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
rendering/RenderLayer.h:

11:46 AM Changeset in webkit [45714] by dimich@chromium.org

11 edits in trunk/WebCore

2009-07-10 Drew Wilson <atwilson@google.com>

Reviewed by Darin Adler.

Need to remove UsesManualToJSImplementation() in favor of CustomToJS.
https://bugs.webkit.org/show_bug.cgi?id=27010

Added support for CustomToJS IDL attribute to replace the hard-coded class list in UsesManualToJSImplementation().

This is just a cleanup of existing functionality, so existing LayoutTests adequately cover this patch.

bindings/scripts/CodeGeneratorJS.pm: Removed UsesManualToJSImplementation(), added support for CustomToJS attribute.
css/CSSRule.idl:
css/CSSValue.idl:
css/StyleSheet.idl:
dom/Document.idl:
dom/Event.idl:
dom/Node.idl:
html/ImageData.idl:
svg/SVGElementInstance.idl:
svg/SVGPathSeg.idl: Added CustomToJS attribute to all the above IDL files.

10:45 AM Changeset in webkit [45713] by mitz@apple.com

2 edits in trunk/WebCore

fix the build by reverting the ill-advised r45711

page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):

10:41 AM Changeset in webkit [45712] by bweinstein@apple.com

4 edits in trunk

2009-07-09 Brian Weinstein <bweinstein@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=27141

Updated WebInspectorClient to use Web Inspector Preferences to remember whether or not it should be
docked or a free window instead of NSUserDefaults it used to have.

WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

2009-07-09 Brian Weinstein <bweinstein@apple.com>

Reviewed by Tim Hatcher.

Updated WebCore.base.exp to add some needed functions.

WebCore.base.exp:

9:56 AM Changeset in webkit [45711] by mitz@apple.com

2 edits in trunk/WebCore

address a review comment from Simon Fraser which I forgot to include in the last check-in

page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor): Pass true to getRect() for maximum transform friendliness!

9:54 AM Changeset in webkit [45710] by mitz@apple.com

5 edits
2 adds in trunk

WebCore:

Reviewed by Simon Fraser.

fix https://bugs.webkit.org/show_bug.cgi?id=27137 <rdar://problem/7043124> REGRESSION (r44311): Reproducible crash due to infinite recursion into FrameLoader::gotoAnchor() -> FrameView::layout()

Test: fast/loader/goto-anchor-infinite-layout.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Moved the code to update layout, find the renderer to scroll to, and scroll from here to methods on FrameView, and replaced it with a call to FrameView::maintainScrollPositionAtAnchor(). (WebCore::FrameLoader::completed): Call maintainScrollPositionAtAnchor() instead of setLockedToAnchor().

page/FrameView.cpp: (WebCore::FrameView::FrameView): Removed initialization of m_lockedToAnchor. (WebCore::FrameView::reset): Reset m_maintainScrollPositionAnchor instead of m_lockedToAnchor. (WebCore::FrameView::layout): Removed the code related to scrolling to the anchor from here, because scrolling can trigger events which invalidate the layout, and as such, belongs with the post-layout tasks. (WebCore::FrameView::maintainScrollPositionAtAnchor): Added. When called with a node scrolls the view to the top of that node and maintains it scrolled to the top of the node during subsequent layouts, until this function is called with 0 or other things trigger scrolling. (WebCore::FrameView::scrollRectIntoViewRecursively): Reset m_maintainScrollPositionAnchor. (WebCore::FrameView::setScrollPosition): Ditto. (WebCore::FrameView::scrollToAnchor): Added. Scrolls to the top of m_maintainScrollPositionAnchor, if it is set. (WebCore::FrameView::performPostLayoutTasks): Call scrollToAnchor(). (WebCore::FrameView::setWasScrolledByUser): Reset m_maintainScrollPositionAnchor.

page/FrameView.h: Removed lockedToAnchor(), setLockedToAnchor(), and m_lockedToAnchor. Added maintainScrollPositionAtAnchor() and m_maintainScrollPositionAnchor.

LayoutTests:

Reviewed by Simon Fraser.

test for https://bugs.webkit.org/show_bug.cgi?id=27137 <rdar://problem/7043124> REGRESSION (r44311): Reproducible crash due to infinite recursion into FrameLoader::gotoAnchor() -> FrameView::layout()

fast/loader/goto-anchor-infinite-layout-expected.txt: Added.
fast/loader/goto-anchor-infinite-layout.html: Added.

8:39 AM Changeset in webkit [45709] by Simon Hausmann

2 edits
2 deletes in trunk/LayoutTests

2009-07-09 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

Re-enabled dom/xhtml/level2/html/HTMLBaseElement0{1,2} for the Qt DRT,
as there's now a cross-platform result and it passes.

platform/qt/Skipped:
platform/qt/dom/xhtml/level2/html/HTMLBaseElement01-expected.txt: Removed.
platform/qt/dom/xhtml/level2/html/HTMLBaseElement02-expected.txt: Removed.

8:30 AM Changeset in webkit [45708] by Simon Hausmann

7 edits in trunk

WebKit/qt:

2009-07-10 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27108

Fix crash when in frame tree of a new frame before the new frame
has been installed in the frame tree, similar to r35088.

After calling Frame::init() the frame it may have been removed from the
frame tree again through JavaScript. Detect this by checking the page()
afterwards.

To make this check safe the Frame::init() code was moved into
QWebFrameData's constructor, where a RefPtr holds a reference to the frame.
After the check back in FrameLoaderClientQt we would hold the single
reference left and after release() the frame, its frame loader, its
client as well as the QWebFrame should have disappeared then.

Api/qwebframe.cpp: (QWebFramePrivate::init): Only call Frame::init here, the rest is done in QWebFrameData's constructor. (QWebFrame::QWebFrame):
Api/qwebframe_p.h: Adjust declaration. (QWebFrameData::QWebFrameData): Create the Frame here.
Api/qwebpage.cpp: (QWebPagePrivate::createMainFrame): Adjust and simplify to new QWebFrame constructor.
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame): Adjust to new QWebFrame construction using QWebFrameData and add the check like in r35088.

LayoutTests:

2009-07-08 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27108

Remove fast/loader/frame-creation-removal.html from the skip list, it
passes now.

platform/qt/Skipped:

6:25 AM Changeset in webkit [45707] by Simon Hausmann

2 edits in trunk/WebCore

2009-07-04 Sriram Yadavalli <sriram.yadavalli@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26439

QtWebKit fails in loading www.nytimes.com in Windows/Linux

QNetworkReplyHandler is ignoring content associated with 401 error.
This causes the XHR response handling to fail.

Simon: Added also ProxyAuthenticationRequiredError, to handle the same
case when going through proxies, as suggested by Prasanth.

platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):

5:47 AM Changeset in webkit [45706] by Simon Hausmann

6 edits in trunk

WebKitTools:

2009-07-08 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=27109

Fix side-effects in the Qt DRT with tests using application fonts.

Detect if a test used application fonts and re-initialize the fontconfig
application fontset accordingly.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): call initializeFonts and remove all application fonts after running a testcase. (WebCore::DumpRenderTree::initializeFonts): Moved fontconfig initialization code here from main.
DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts.
DumpRenderTree/qt/main.cpp: (main): Moved fontconfig initialization code to DRT::initializeFonts.

LayoutTests:

2009-07-08 Simon Hausmann <Simon Hausmann>