⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 12, 2009:

11:12 PM Changeset in webkit [45790] by bfulgham@webkit.org
  • 10 edits in trunk/WebKit

WebKit/gtk:

2009-07-12 Brent Fulgham <​bfulgham@gmail.com>

Speculative build fix after ​http://trac.webkit.org/changeset/45786.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::addMessageToConsole):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/qt:

2009-07-12 Brent Fulgham <​bfulgham@gmail.com>

Speculative build fix after ​http://trac.webkit.org/changeset/45786.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/wx:

2009-07-12 Brent Fulgham <​bfulgham@gmail.com>

Speculative build fix after ​http://trac.webkit.org/changeset/45786.

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::addMessageToConsole):
  • WebKitSupport/ChromeClientWx.h:
11:02 PM Changeset in webkit [45789] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

2009-07-12 Brent Fulgham <​bfulgham@gmail.com>

Speculative Windows build fix after ​http://trac.webkit.org/changeset/45786.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::addMessageToConsole):
10:38 PM Changeset in webkit [45788] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-script-src.pl

Fix executable bit. We should fix bugzilla-tool to understand executable bits.

10:36 PM Changeset in webkit [45787] by abarth@webkit.org
  • 6 edits
    7 adds in trunk

2009-07-12 Adam Barth <​abarth@webkit.org>

Reviewed by Oliver Hunt.

Facebook Chat is broken due to XSS auditor
​https://bugs.webkit.org/show_bug.cgi?id=27179

Instead of just using the script's URL as to detect an XSS attack, we
now use a bit of context before the URL. In particular, we use the
bytes from the beginning of the attribute name to the end of the
attribute value. In virtually all injection attacks, the attacker
would need to supply the attribute name as well as the attribute value.
However, in the Facebook false positive, the attribute name is not
present in the URL.

Tests: http/tests/security/xssAuditor/script-tag-src-redirect-safe.html

http/tests/security/xssAuditor/script-tag-with-source-double-quote.html
http/tests/security/xssAuditor/script-tag-with-source-no-quote.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h:
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
  • page/XSSAuditor.h:

2009-07-12 Adam Barth <​abarth@webkit.org>

Reviewed by Oliver Hunt.

Facebook Chat is broken due to XSS auditor
​https://bugs.webkit.org/show_bug.cgi?id=27179

Add some more test coverage to our handling of script tags with src
attributes. Also, ensure that we don't raise the alarm when a URL
parameter is injected directly into the attribute value.

  • http/tests/security/xssAuditor/resources/echo-script-src.pl: Added.
  • http/tests/security/xssAuditor/script-tag-src-redirect-safe-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/base-href-safe-expected.txt.
  • http/tests/security/xssAuditor/script-tag-src-redirect-safe.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote.html: Added.
10:08 PM Changeset in webkit [45786] by bfulgham@webkit.org
  • 36 edits in trunk

WebCore:

2009-07-12 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Refactor ConsoleMessage to add MessageType attribute.
​https://bugs.webkit.org/show_bug.cgi?id=20625

  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::printErrorMessage):
  • dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::count):
  • inspector/InspectorController.h:
  • inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): (WebInspector.ConsoleMessage): Added type property. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleCommandResult): (WebInspector.ConsoleGroup.prototype.addMessage): (WebInspector.ConsoleGroup.prototype._titleClicked):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._addTip): (WebInspector.Resource.prototype._checkWarning):
  • inspector/front-end/inspector.css: Changed ".console-group-title-level" to ".console-group-title"
  • inspector/front-end/inspector.js: (WebInspector.addMessageToConsole):
  • loader/DocLoader.cpp: (WebCore::DocLoader::printAccessDeniedMessage):
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::addMessageToConsole):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reportLocalLoadFailed): (WebCore::FrameLoader::shouldAllowNavigation):
  • page/ChromeClient.h:
  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): (WebCore::Console::addMessage): (WebCore::Console::error): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::timeEnd): (WebCore::Console::warn):
  • page/Console.h: Added MessageType enum. (WebCore::):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
  • workers/GenericWorkerTask.h: Added GenericWorkerTask8 for the extra argument. (WebCore::GenericWorkerTask8::create): (WebCore::GenericWorkerTask8::GenericWorkerTask8): (WebCore::GenericWorkerTask8::performTask): (WebCore::createCallbackTask):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::importScripts):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
  • xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc):

WebKit/mac:

2009-07-12 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Refactor ConsoleMessage to add MessageType attribute.
​https://bugs.webkit.org/show_bug.cgi?id=20625

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole):
9:07 PM Changeset in webkit [45785] by bfulgham@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2009-07-12 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl.

​https://bugs.webkit.org/show_bug.cgi?id=27132

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • dom/HTMLAllCollection.idl: Added.
8:55 PM Changeset in webkit [45784] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-12 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Maciej Stachowiak.

Inspector: Duplicate Computation in Autocompletion
​https://bugs.webkit.org/show_bug.cgi?id=26778

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
6:43 PM Changeset in webkit [45783] by eric.carlson@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

2009-07-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=27197
QuickTime supports data: urls, add a layout test.

  • media/audio-data-url-expected.txt: Added.
  • media/audio-data-url.html: Added.

New test.

  • platform/gtk/Skipped:

Skip the new test.

5:54 PM Changeset in webkit [45782] by mitz@apple.com
  • 10 edits
    1 move
    1 delete in trunk

WebCore:

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=27196
Rename bidi.cpp to RenderBlockLineLayout.cpp and remove bidi.h

  • GNUmakefile.am: Updated.
  • WebCore.gypi: Updated.
  • WebCore.pro: Updated.
  • WebCore.vcproj/WebCore.vcproj: Updated.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • WebCoreSources.bkl: Updated.
  • rendering/RenderBlock.h: Removed unnecessary forward declaration and

updated comments.

  • rendering/RenderBlockLineLayout.cpp: Copied from WebCore/rendering/bidi.cpp.

Removed unnecessary #include statements.

(WebCore::BidiRun::BidiRun): Moved here from bidi.h.
(WebCore::RenderBlock::layoutInlineChildren): Removed outdated comment.

  • rendering/bidi.cpp: Removed.
  • rendering/bidi.h: Removed.

WebKitTools:

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=27196
Update check-for-global-initializers for the renaming for bidi.cpp to
RenderBlockLineLayout.cpp

  • Scripts/check-for-global-initializers:
4:48 PM Changeset in webkit [45781] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

4:41 PM Changeset in webkit [45780] by mitz@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • Image cleanup
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): Use the data() accessor instead of the m_data member. (WebCore::BitmapImage::dataChanged): Ditto.
  • platform/graphics/Image.h: Re-ordered #includes and class declarations. Removed the drawPatternCallback() declaration. Made member variables private.
  • platform/graphics/cg/ImageCG.cpp: (WebCore::drawPatternCallback): Changed this from a member function to a static function.
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Use the data() accessor instead of the m_data member.
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Ditto.
2:49 PM Changeset in webkit [45779] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r45758.

2:49 PM Changeset in webkit [45778] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45755.

2:49 PM Changeset in webkit [45777] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebKit/mac

Merge r45745.

2:49 PM Changeset in webkit [45776] by mrowe@apple.com
  • 18 edits in branches/safari-4-branch

Merge r45744.

2:49 PM Changeset in webkit [45775] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r45736.

2:49 PM Changeset in webkit [45774] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r45735.

2:48 PM Changeset in webkit [45773] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45734.

2:48 PM Changeset in webkit [45772] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r45733.

2:48 PM Changeset in webkit [45771] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/WebCore

Merge r45732.

2:48 PM Changeset in webkit [45770] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45728.

2:48 PM Changeset in webkit [45769] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45721.

2:48 PM Changeset in webkit [45768] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r45715.

2:48 PM Changeset in webkit [45767] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-4-branch

Merge r45710.

2:48 PM Changeset in webkit [45766] by mrowe@apple.com
  • 169 edits in branches/safari-4-branch

2009-07-10 Beth Dakin <Beth Dakin>

<rdar://problem/7045243> Roll text metrics change out

  • css/html.css:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
2:47 PM Changeset in webkit [45765] by mrowe@apple.com
  • 29 edits in branches/safari-4-branch

<rdar://problem/7047403> Disable channel messaging

2:47 PM Changeset in webkit [45764] by mrowe@apple.com
  • 14 edits in branches/safari-4-branch

<rdar://problem/7048551> Disable datagrid

2:46 PM Changeset in webkit [45763] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2009-07-12 Daniel Bates <​dbates@intudata.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=27189


Fixes insufficient check in XSSAuditor::canSetBaseElementURL that caused
XSSAuditor to incorrectly block HTML Base elements whose base path coincided
with the URL of the page.

Test: http/tests/security/xssAuditor/base-href-safe3.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL): Changed conditional to only call XSSAuditor::findInRequest() if the host in the page URL disagrees with the host in the base element URL.

2009-07-12 Daniel Bates <​dbates@intudata.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=27189


Tests that XSSAuditor does not block HTML Base elements whose path has the
same host as the page.

  • http/tests/security/xssAuditor/base-href-safe3-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-safe3.html: Added.
  • http/tests/security/xssAuditor/resources/base-href/base-href-safe3.html: Added.
1:27 PM Changeset in webkit [45762] by Darin Adler
  • 9 edits in trunk/WebCore

2009-07-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Text searching with ICU should take the user's default locale into account
​https://bugs.webkit.org/show_bug.cgi?id=27184
rdar://problem/6812121

No simple way to test this since it's dependent on user locale.
After this, the user's default locale is used only on Mac.

  • editing/TextIterator.cpp: (WebCore::createSearcher): Pass result of the currentSearchLocaleID function as the locale.
  • platform/text/TextBreakIteratorInternalICU.h: Added declaration of currentSearchLocaleID function.
  • platform/text/android/TextBreakIteratorInternalICU.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: (WebCore::currentSearchLocaleID): Ditto.
  • platform/text/gtk/TextBreakIteratorInternalICUGtk.cpp: (WebCore::currentSearchLocaleID): Ditto.
  • platform/text/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::textBreakLocalePreference): Added. Returns the value of the AppleTextBreakLocale preference. (WebCore::topLanguagePreference): Added. Returns the value of the first item in the AppleLanguages preference. (WebCore::canonicalLanguageIdentifier): Added. Cover for the CFLocaleCreateCanonicalLanguageIdentifierFromString function. (WebCore::getLocale): Added. Transfers the locale from a CFStringRef into a buffer. (WebCore::getSearchLocale): Added. Calls topLanguagePreference, canonicalLanguageIdentifier, and getLocale. (WebCore::currentSearchLocaleID): Added. Calls getSearchLocale once. (WebCore::getTextBreakLocale): Changed to call textBreakLocalePreference, topLanguagePreference, canonicalLanguageIdentifier, and getLocale.
  • platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
  • platform/wx/TemporaryLinkStubs.cpp: (WebCore::currentSearchLocaleID): Ditto.
11:42 AM Changeset in webkit [45761] by xan@webkit.org
  • 2 edits in trunk

2009-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version in preparation for 1.1.11 release.

  • configure.ac:
10:25 AM Changeset in webkit [45760] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Create a PangoLayout that properly represents the visual
appearance of the text in the web page so that the line boundary
modes of getText{At,Before,After}Offset work correctly.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (UTF16ToUTF8): (g_substr): (convertUniCharToUTF8): (getPangoLayoutForAtk):

Jul 11, 2009:

10:17 PM Changeset in webkit [45759] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Bug 27187 - Match Gecko behaviour for canvas path mutation APIs on an empty path
<​https://bugs.webkit.org/show_bug.cgi?id=27187>

Reviewed by Simon Fraser

Simple API change, check for the empty path and add appropriate point if necessary.

Test: fast/canvas/canvas-modify-emptyPath.html

7:15 PM Changeset in webkit [45758] by eric.carlson@apple.com
  • 7 edits in trunk

2009-07-11 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement.canPlayType "maybe" and "probably" reversed
​https://bugs.webkit.org/show_bug.cgi?id=27186

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):

Return "probably" if type has codecs parameter.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsType):

Ditto.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::supportsType):

Ditto.

2009-07-11 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement.canPlayType "maybe" and "probably" reversed
​https://bugs.webkit.org/show_bug.cgi?id=27186

  • media/video-can-play-type-expected.txt:
  • media/video-can-play-type.html:
1:26 PM Changeset in webkit [45757] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

1:24 PM Changeset in webkit [45756] by mrowe@apple.com
  • 1 copy in branches/safari-4-branch

New branch.

12:21 PM Changeset in webkit [45755] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-07-11 Brady Eidson <​beidson@apple.com>

Reviewed by Mark Rowe.

A worker-thread inspired follow-up for:
​https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
REGRESSION: XHR stream connection blocks iFrame loading and resource downloading

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Don't perform the XHR compensation when the XHR is running on a worker thread. Accessing the global Cache data structures from a non-main thread is not currently supported.
11:44 AM Changeset in webkit [45754] by Simon Fraser
  • 10 edits
    6 moves
    35 adds in trunk

2009-07-11 Simon Fraser <Simon Fraser>

Enable support for accelerated compositing and 3d transforms on Leopard.
<​https://bugs.webkit.org/show_bug.cgi?id=20166>
<rdar://problem/6120614>

Reviewed by Oliver Hunt.

3:18 AM Changeset in webkit [45753] by Simon Hausmann
  • 3 edits in trunk/WebCore

2009-07-11 Simon Hausmann <Simon Hausmann>

Fix the Qt build after r45724.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp):
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
Note: See TracTimeline for information about the timeline view.