⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 13, 2009:

11:06 PM BuildingCairoOnWindows edited by bfulgham@webkit.org
(diff)
11:05 PM BuildingCairoOnWindows edited by bfulgham@webkit.org
Remove instruction to include GIFLIB, as this is no longer necessary. (diff)
11:04 PM BuildingCairoOnWindows edited by bfulgham@webkit.org
Removed instructions to edit config.h, as this is no longer necessary! (diff)
10:35 PM Changeset in webkit [45855] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: handle debugger shortcuts while on source frame or on
script file selector.

​https://bugs.webkit.org/show_bug.cgi?id=27224

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
9:00 PM Changeset in webkit [45854] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-07-13 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Use standard HashCountedSet instead of a hand rolled one
in HTMLDocument.

  • html/HTMLDocument.cpp: (WebCore::addItemToMap): (WebCore::removeItemFromMap):
  • html/HTMLDocument.h:
8:32 PM WebKit Team edited by tonikitoo@gmail.com
added indt folks (diff)
7:44 PM Changeset in webkit [45853] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-13 Brady Eidson <​beidson@apple.com>

Fix Leopard regression I just introduced.

  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
7:01 PM Changeset in webkit [45852] by beidson@apple.com
  • 4 edits
    3 copies
    1 add in trunk/LayoutTests

2009-07-13 Brady Eidson <​beidson@apple.com>

Rubberstamped by Mark Rowe.

Add SnowLeopard specific results for differing MIME types that are (mostly) progressions.

  • platform/mac-leopard/platform/mac/fast/loader: Added.
  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-expected.txt.
  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
6:04 PM Changeset in webkit [45851] by Darin Adler
  • 12 edits
    5 adds in trunk

WebCore:

2009-07-13 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler and Maciej Stachowiak.

Implement HTML5 draggable
​https://bugs.webkit.org/show_bug.cgi?id=26262

This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

Spec: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

Test: fast/html/draggable.html

  • css/html.css:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::draggable):
  • html/HTMLAnchorElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::draggable): (WebCore::HTMLElement::setDraggable):
  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::draggable):
  • html/HTMLImageElement.h:

LayoutTests:

2009-07-13 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler and Maciej Stachowiak.

Implement HTML5 draggable
​https://bugs.webkit.org/show_bug.cgi?id=26262

This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

Spec: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

  • fast/html/draggable-expected.txt: Added.
  • fast/html/draggable.html: Added.
  • fast/html/resources: Added.
  • fast/html/resources/images: Added.
  • fast/html/resources/images/lime.png: Added.
  • fast/dom/resources/domListEnumeration.js: Updated.
  • fast/dom/domListEnumeration-expected.txt: Updated.
5:47 PM Changeset in webkit [45850] by Simon Fraser
  • 3 edits
    9 adds in trunk

2009-07-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Image rendered as layer contents looks different from image rendered via CG.
<rdar://problem/7048830>

Fix a visible color profile difference between between images rendered via Core Graphics
and those rendered via a compositing layer, by assigning the GenericRGB profile to
untagged images (which come through as having the DeviceRGB profile) when they are set
as layer contents.

Test: compositing/color-matching/image-color-matching.html

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
5:20 PM Changeset in webkit [45849] by Darin Adler
  • 2 edits in trunk/WebCore

2009-07-13 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=27220
Assertion failure in createSearcher() (usearch_open() status is U_USING_DEFAULT_WARNING)

  • editing/TextIterator.cpp: (WebCore::createSearcher): Add U_USING_DEFAULT_WARNING as a possible status code in the assertion. Affects only the assertion.
5:07 PM Changeset in webkit [45848] by ap@webkit.org
  • 6 edits
    4 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26925
<rdar://problem/7027850> URL Fragment Breaks Application Cache Loads

Test: http/tests/appcache/main-resource-hash.html

  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::resourceForURL): (WebCore::ApplicationCache::resourceForRequest):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest): (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::addEntry): Remove URL fragment at appcache code borders.
  • loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::create):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup): (WebCore::ApplicationCacheStorage::cacheGroupForURL): (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Assert that there is no URL fragment in URL at key points in appcache code.
5:02 PM Changeset in webkit [45847] by Darin Adler
  • 3 edits
    1 copy
    1 add in trunk

WebCore:

2009-07-13 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work

Test: fast/text/find-spaces.html

  • editing/TextIterator.cpp: (WebCore::findPlainText): Removed unneeded special case. The empty string case already works correctly.

LayoutTests:

2009-07-13 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work

  • fast/text/find-spaces-expected.txt: Added.
  • fast/text/find-spaces.html: Copied from LayoutTests/fast/text/find-case-folding.html.
4:42 PM Changeset in webkit [45846] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/win

2009-07-13 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
​https://bugs.webkit.org/show_bug.cgi?id=27240.

  • WebFrame.cpp: (WebFrame::printHeader): New shared method to print the header. (WebFrame::printFooter): New shared method to print the footer. (WebFrame::spoolPage): New conditionally-compiled method to print a page. (WebFrame::spoolPages): Revised to call the platform-specific spoolPage for each page.
  • WebFrame.h: Add new method prototypes.
4:23 PM Changeset in webkit [45845] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-07-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Remove NPPVpluginPrivateModeBool, it was removed from the spec.


  • bridge/npapi.h:
4:08 PM Changeset in webkit [45844] by feng@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Feng Qian <​feng@chromium.org>

Reviewed by Dimitri Glazkov.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=27237

Make V8DOMMap.h compiling with gcc option -Werror=non=virtual-dtor.

  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::WeakReferenceMap): (WebCore::WeakReferenceMap::~WeakReferenceMap):
4:03 PM Changeset in webkit [45843] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-07-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Remove an accidental add of bidi.(cpp|h) to WebCore.gypi.

  • WebCore.gypi: Removed bidi.cpp and bidi.h
3:46 PM Changeset in webkit [45842] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-07-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Update WebCore.gyp in preparation to hooking it up.

  • WebCore.gypi: Added files that were mid-stream while switching over.
3:41 PM Changeset in webkit [45841] by mrowe@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add Leopard-specific results for fast/text/international/khmer-selection.html.

  • platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/khmer-selection-expected.txt.
3:08 PM Changeset in webkit [45840] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Dmitry Titov <​dimich@chromium.org>

Not reviewed, another small fix for Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
3:00 PM Changeset in webkit [45839] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-07-13 Dmitry Titov <​dimich@chromium.org>

Not reviewed, fix Chromium build bustage.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/V8Proxy.cpp: (WebCore::JavaScriptConsoleMessage::addToPage):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::handleConsoleMessage):
1:45 PM Changeset in webkit [45838] by mrowe@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add a missing layout test result to improve the quality of life of the Mac buildbots.

  • platform/mac/fast/text/international/khmer-selection-expected.txt: Added.
1:32 PM Changeset in webkit [45837] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-07-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Adam Roben.

"Unrecognized selector" console log when the Safari 4 Welcome page navigates to Top Sites.
<rdar://problem/6994893

attachRootGraphicsLayer() should not assume that the frameView's documentView
is a WebHTMLView.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::attachRootGraphicsLayer):
1:16 PM Changeset in webkit [45836] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-07-13 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>

Add null page check in HTMLDocument::hasFocus.

Test: fast/dom/HTMLDocument/hasFocus-frameless-crash.html

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::hasFocus): Add page null check. (WebCore::HTMLDocument::createTokenizer): Cleanup page null check.

LayoutTests:

2009-07-13 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>

  • fast/dom/HTMLDocument/hasFocus-frameless-crash-expected.txt: Added.
  • fast/dom/HTMLDocument/hasFocus-frameless-crash.html: Added.
1:13 PM Changeset in webkit [45835] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Disable continuous spell checking in the inspector
​https://bugs.webkit.org/show_bug.cgi?id=27131

  • inspector/front-end/inspector.html: Added spellcheck="false" to the

main-panels and console-prompt containers.

12:38 PM Changeset in webkit [45834] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-07-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler and Kevin Decker.

<rdar://problem/7053687> Core Animation plug-ins continue to grow larger and larger when opening new tabs (32 bit-only)

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView setLayer:]): Add a FIXME.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setLayer:]): Make sure to set the size of the layer before changing the autoresizing mask so it won't grow everytime it's inserted into the layer tree.
12:14 PM Changeset in webkit [45833] by agl@chromium.org
  • 3 edits
    1 add in trunk

2009-07-13 Adam Langley <​agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: fix assertion when rendering google.com.kh

​https://bugs.webkit.org/show_bug.cgi?id=26924

Some shapers (i.e. Khmer) will produce cluster logs which report that
/no/ code points contributed to certain glyphs. Because of this, we
take any code point which contributed to the glyph in question, or any
subsequent glyph. If we run off the end, then we take the last code
point.

Added LayoutTests/fast/text/international/khmar-selection.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::offsetForPositionForComplexText):
12:05 PM Changeset in webkit [45832] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

spellcheck="false" is ignored
<rdar://problem/7054177>

  • editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): Moved code to check the

spellcheck attribute from here...

(WebCore::Editor::spellCheckingEnabledInFocusedNode): ...to here.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Bail out

if spell chcking is disabled by the spellcheck attribute.

  • editing/Editor.h:
11:34 AM Changeset in webkit [45831] by bfulgham@webkit.org
  • 9 edits
    1 add in trunk

WebCore:

2009-07-13 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
​https://bugs.webkit.org/show_bug.cgi=27087


  • WebCore.vcproj/WebCore.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo builds.
  • config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.

WebKit/win:

2009-07-13 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
​https://bugs.webkit.org/show_bug.cgi=27087

  • WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.

WebKitLibraries:

2009-07-13 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
​https://bugs.webkit.org/show_bug.cgi=27087


  • win/tools/vsprops/WinCairo.vsprops: Added. Defines the new WIN_CAIRO flag used to drive non-Apple Windows build.

WebKitTools:

2009-07-13 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Add new configuration flag for redistributable Windows build.
​https://bugs.webkit.org/show_bug.cgi=27087

  • DumpRenderTree/config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.
11:15 AM Changeset in webkit [45830] by pkasting@chromium.org
  • 17 edits
    1 move
    5 deletes in trunk

WebCore:

2009-07-13 Peter Kasting <​pkasting@google.com>

​https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLButtonElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::form):
  • html/HTMLInputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/ValidityState.cpp: Removed.
  • html/ValidityState.h: Removed.
  • html/ValidityState.idl: Removed.

LayoutTests:

2009-07-13 Peter Kasting <​pkasting@google.com>

​https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).
This also re-enables fast/dom/domListEnumeration.html.

  • fast/dom/domListEnumeration.html: Copied from LayoutTests/fast/dom/domListEnumeration.html-disabled.
  • fast/dom/domListEnumeration.html-disabled: Removed.
  • fast/forms/ValidityState-001-expected.txt: Removed.
  • fast/forms/ValidityState-001.html: Removed.
11:11 AM Changeset in webkit [45829] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-07-13 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Add HTMLAllCollection to WebCore.gypi.

​https://bugs.webkit.org/show_bug.cgi?id=27223

10:08 AM Changeset in webkit [45828] by bolsinga@apple.com
  • 2 edits in trunk/WebKit/mac

2009-07-13 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Simon Fraser.

Correct these delegate methods' declarations by adding parameter names.

  • WebView/WebUIDelegatePrivate.h:
9:44 AM Changeset in webkit [45827] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Late NEWS file for 1.1.11.

  • NEWS:
9:40 AM Changeset in webkit [45826] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

WebCore:

2009-07-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[V8] Add a missing check for constructor call in WebKitCSSMatrixConstructor.
​https://bugs.webkit.org/show_bug.cgi?id=27218

Test: fast/css/matrix-as-function-crash.html

  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Added a check for constructor call.

LayoutTests:

2009-07-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Make sure that calling WebKitCSSMatrix as function does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=27218

  • fast/css/matrix-as-function-crash-expected.txt: Added.
  • fast/css/matrix-as-function-crash.html: Added.
8:53 AM Changeset in webkit [45825] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.11

Tagging 1.1.11.

8:29 AM Changeset in webkit [45824] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Changes to the doc control files for 1.1.11.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
8:23 AM Changeset in webkit [45823] by kov@webkit.org
  • 2 edits in trunk

2009-07-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Require the correct libsoup version now that
it's released.

  • configure.ac:
7:55 AM Changeset in webkit [45822] by Simon Hausmann
  • 2 adds in trunk/WebKitTools/DumpRenderTree/qt/TestNetscapePlugin

Added .pro file missing from r45813

7:54 AM Changeset in webkit [45821] by vestbo@webkit.org
  • 2 edits in trunk

2009-07-13 Laszlo Gombos <Laszlo Gombos>

Reviewed by Tor Arne Vestbø.

[Qt] Build fix for QtWebKit on Win
​https://bugs.webkit.org/show_bug.cgi?id=27205

  • WebKit.pri: Include the major version number in the QtWebKit library file for Win.
7:32 AM Changeset in webkit [45820] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-07-13 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix qdoc warnings for QWebPage::shouldInterruptJavaScript() and mention
how to re-implement it.

  • Api/qwebpage.cpp:
7:20 AM Changeset in webkit [45819] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Holger Freyther.

Fix unit test to use the correct assumption that the SoupMessage
will be NULL when WebKitNetworkRequest is created from an URI.

  • tests/testnetworkrequest.c: (test_network_request_create_destroy):
6:58 AM WebKit Team edited by treat@kde.org
(diff)
6:15 AM Changeset in webkit [45818] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2009-07-13 Simon Hausmann <​simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Unskip three more fast/js tests that pass with the Qt DRT.

  • platform/qt/Skipped:
6:04 AM Changeset in webkit [45817] by Simon Hausmann
  • 3 edits
    1 delete in trunk

WebKitTools:

2009-07-13 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Always run the Qt DRT with the raster graphicssystem on X11, for
increased stability in the image based tests, in particular canvas.

  • DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Removed Qt DRT specific result for canvas-getImageData as we pass this
test with the raster graphicssystem.

  • platform/qt/fast/canvas/canvas-getImageData-expected.txt: Removed.
5:29 AM Changeset in webkit [45816] by kov@webkit.org
  • 4 edits in trunk

Unreviewed make dist build fix.

5:27 AM Changeset in webkit [45815] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-13 Cédric Luthi <​cedric.luthi@gmail.com>

Reviewed by Tor Arne Vestbø.

Fix NPWindow clip rect in PluginViewMac

The rect should be in window-coordinates. This bug can be observed
with Flash 10 here: ​http://www.permadi.com/tutorial/cursorTracker/

  • plugins/mac/PluginViewMac.cpp:
3:55 AM Changeset in webkit [45814] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Fix crash with plugins when the plugin stream is cancelled.

Similar to r26667 handle the case where didReceiveResponse on the
plugin view results in failure to set up the stream and
setMainDocumentError being called instead. This will set the
m_pluginView back to 0 and we need check for it before calling
didReceiveData.

This was triggered by consecutive execution of
LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
followed by LayoutTests/scrollbars/scrollbar-crash-on-refresh.html

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::committedLoad):
3:55 AM Changeset in webkit [45813] by Simon Hausmann
  • 7 edits in trunk

.:

2009-07-13 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Add the test netscape plugin for the Qt DRT to the build.

  • WebKit.pro:

WebKitTools:

2009-07-13 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix test netscape plugin usage with the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): Enable plugins in the settings.
  • Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build directory to make Qt DRT find the test netscape plugin.

LayoutTests:

2009-07-13 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Enable a bunch of plugin layout tests for the Qt DRT.

  • platform/qt/Skipped:
3:53 AM Changeset in webkit [45812] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Make sure to disable the fixed contents size when resetting the page/view
state between test runs, to avoid side-effects.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid QSize to disable the fixed layout.
3:52 AM Changeset in webkit [45811] by Simon Hausmann
  • 4 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

When creating new windows, don't forget to connect the new
page's main frame. This ensures that for example the layoutTestController
is also available there.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::createWindow):

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Removed two more storage tests from the Qt DRT skip list that relied on
layoutTestController to be accessible in newly opened windows.

  • platform/qt/Skipped:
3:50 AM Changeset in webkit [45810] by Simon Hausmann
  • 5 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Added support for LayoutTestController.setPrivateBrowsingEnabled.

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled):
  • DumpRenderTree/qt/jsobjects.h:

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Removed three tests from the Qt DRT Skip list that rely on
LayoutTestController.setPrivateBrowsingEnabled and pass now.

  • platform/qt/Skipped:
3:49 AM Changeset in webkit [45809] by Simon Hausmann
  • 11 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Added QWebDatabase::removeAllDatabases, as a way to delete all
databases from the offline storage path.

Used by the Qt DRT.

  • Api/qwebdatabase.cpp: (QWebDatabase::removeAllDatabases):
  • Api/qwebdatabase.h:

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Added support for database callbacks, storage quota setting,
and clearing of all databases.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::dumpDatabaseQuota):
  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::dumpDatabaseCallbacks):
  • DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Enable a bunch of more storage layout tests for the Qt DRT, now that
they pass.

  • platform/qt/Skipped:
3:48 AM Changeset in webkit [45808] by Simon Hausmann
  • 4 edits in trunk

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Setup the path in the Qt DRT for HTML 5 Databases, to enable some of
the storage layout tests.

  • DumpRenderTree/qt/main.cpp: (main):

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Enable some storage layout tests in the Qt DRT, as the pass now.

  • platform/qt/Skipped:
3:46 AM Changeset in webkit [45807] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Fix Qt implementation of WebCore::directoryName to return the absolute
directory name instead of the base file name.

  • platform/qt/FileSystemQt.cpp: (WebCore::directoryName):
3:45 AM Changeset in webkit [45806] by Simon Hausmann
  • 8 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Added loadStarted() and loadFinished() signals to QWebFrame,
to allow load tracking of individual frames, as opposed to
QWebPage's loadStarted/loadFinished signals that are emitted
whenever _any_ child frame loads/finishes.

  • Api/qwebframe.cpp: Document new signals.
  • Api/qwebframe.h: Add new signals.
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): Connect new signals.

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Make the test output more robust by dumping only when the main
frame finishes loading, instead of when _any_ frame finishes.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Connect to the main frame's loadFinished() signal instead of the page's one.

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Removed 20 more frame tests from the Qt skip list as they pass now
after making sure we only dump after the main frame's loadFinished
signal.

  • platform/qt/Skipped:
3:40 AM Changeset in webkit [45805] by Simon Hausmann
  • 9 edits in trunk

WebKit/qt:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Add hooks for the GCController JavaScript interface needed by the
Qt DRT.

Fixed sort order of includes in qwebframe.cpp.

  • Api/qwebframe.cpp: (qt_drt_javaScriptObjectsCount): (qt_drt_garbageCollector_collect): (qt_drt_garbageCollector_collectOnAlternateThread):

WebKitTools:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Implement the GCController DRT interface in the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine.
  • DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController.
  • DumpRenderTree/qt/jsobjects.cpp: Implement GCController. (GCController::GCController): (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
  • DumpRenderTree/qt/jsobjects.h: Declare GCController.

LayoutTests:

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Remove fast/frames/removal-before-attach-crash.html and
fast/dom/StyleSheet/ownerNode-lifetime-2.html from the Qt DRT skip
list, as they pass now with support for the GCController.

  • platform/qt/Skipped:
3:34 AM Changeset in webkit [45804] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-13 Simon Hausmann <Simon Hausmann>

Reviewed by Ariya Hidayat.

Fix WebCore::Path::isEmpty() for the Qt port to return true
if there is no element in the path.

QPainterPath::isEmpty() returns also true if there is one single
MoveTo element inside, which makes sense but doesn't patch Webcore's
is-empty definition.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::isEmpty): Use elementCount() == 0.
3:22 AM Changeset in webkit [45803] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-07-13 Reinout van Schouwen <​reinouts@gnome.org>

<​https://bugs.webkit.org/show_bug.cgi?id=26980> [Gtk] Updated Dutch translation

Rubber-stamped by Jan Alonzo.

  • nl.po: Added.
3:11 AM Changeset in webkit [45802] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-07-13 Jan Michael Alonzo <​jmalonzo@webkit.org>

<​https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk]
REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html

Reviewed by Gustavo Noronha.

Unskip fast/events/frame-programmatic-focus.html

  • platform/gtk/Skipped:

focus-in and focus-out events only get triggered when there's user
interaction, hence setFocused(bool) never gets called when
focusEvent is triggered when running the layout tests. The
solution seems to be to implement grab-focus too so we can call
setFocused(bool) when a widget has focus.

  • webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event): (webkit_web_view_class_init):
2:57 AM Changeset in webkit [45801] by jmalonzo@webkit.org
  • 12 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT

Reviewed by Gustavo Noronha and Xan Lopez.

Unskip tests that now pass due to support for JS windows in Gtk DRT.

  • platform/gtk/Skipped:

Add API to support opening and closing of JavaScript windows automatically.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_real_close_web_view): (webkit_web_view_class_init): (webkit_web_view_update_settings): (webkit_web_view_settings_notify): (webkit_web_view_set_group_name):
  • webkit/webkitwebview.h:

Support running of tests that open and close JS windows automatically.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpFramesAsText): (dumpBackForwardListForAllWebViews): (resetWebViewToConsistentStateBeforeTesting): (dump): (runTest): (webViewClose): (createWebView): (webViewCreate): (main):
  • DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::windowCount): (LayoutTestController::setPopupBlockingEnabled):
2:47 AM Changeset in webkit [45800] by Simon Hausmann
  • 3 edits in trunk/LayoutTests

2009-07-13 Simon Hausmann <​simon.hausmann@nokia.com>

Rubber-stamped by Oliver Hunt.

Tweak mouseout-dead-subframe.html to be more robust.

The test calls notifyDone() and then dumpAsText(). The latter call has no effect
as notifyDone() performs the dump, but it passes in the mac DRT because the mime-type
of the .html file is detected as text/plain and therefore the text is dumped instead
of the render tree.

Changed the testcase to call dumpAsText() first and then notifyDone(), to make it
pass without relying on the mime type detection.

That also makes the test pass in the Qt DRT.

  • fast/events/mouseout-dead-subframe.html: Swapped notifyDone() and dumpAsText() calls to call the former before the latter.
  • platform/qt/Skipped: Removed skipped test.
2:36 AM Changeset in webkit [45799] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Maciej Stachowiak.

prepare-ChangeLog should decode HTML entities in short description
​https://bugs.webkit.org/show_bug.cgi?id=27122

Decode the short description by adding a function which decodes HTML
entities. It can decode &, <, >, ", and ' . They may be sufficient
as the description seems to be encoded by xml_quote in
​http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm

  • Scripts/prepare-ChangeLog:
2:31 AM Changeset in webkit [45798] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Albert J. Wong <​ajwong@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream fixes to NPV8Object.cpp that make ~30 layout tests pass.
​https://bugs.webkit.org/show_bug.cgi?id=27127

There were a number of bugs introduced during the last upstreaming
effort that broke around 30 layout tests. This fixes those bugs.
It also has compile fixes to match the recent cutting apart of
V8Proxy.

  • bindings/v8/NPV8Object.cpp: (freeV8NPObject): (npCreateV8ScriptObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_EvaluateHelper): (NPN_SetException): (NPN_Construct):
2:31 AM Changeset in webkit [45797] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 Mads Ager <​ager@chromium.org>

Reviewed by Adam Barth.

Fix memory leak in the V8 binding layer.
​https://bugs.webkit.org/show_bug.cgi?id=27163

Reinitializing the context is not necessary when clearing the proxy for navigation
and it will lead us to hold on to an empty context for each frame.

Test for empty context instead of empty global object handle when
updating the document for a context.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::updateDocument):
2:31 AM Changeset in webkit [45796] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-13 John Gregg <​johnnyg@google.com>

Reviewed by David Levin.

Correct the logic to determine if a V8 callback returns a value.
​https://bugs.webkit.org/show_bug.cgi?id=27155

  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
  • Don't crash if result.IsEmpty().
1:58 AM Changeset in webkit [45795] by levin@chromium.org
  • 25 edits
    16 adds in trunk

2009-07-13 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
​https://bugs.webkit.org/show_bug.cgi?id=26932

.:

Added ENABLE(SHARED_WORKERS) flag.

  • configure.ac:

JavaScriptCore:

Added ENABLE(SHARED_WORKERS) flag (off by default).

  • Configurations/FeatureDefines.xcconfig:

WebCore:

Initial IDL definition and bindings for SharedWorkers.

  • Configurations/FeatureDefines.xcconfig: Added new files for SharedWorker support.
  • DerivedSources.make: Added new files for SharedWorker support.
  • GNUmakefile.am: Added new files for SharedWorker support.
  • WebCore.gypi: Added new files for SharedWorker support.
  • WebCore.pro: Added new files for SharedWorker support.
  • WebCore.xcodeproj/project.pbxproj: Added new files for SharedWorker support.
  • bindings/js/JSAbstractWorkerCustom.cpp: Added. (WebCore::JSAbstractWorker::mark): Custom mark handler that marks the event listeners. (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener): (WebCore::JSAbstractWorker::toJS): Custom toJS handler which differentiates between various subclasses.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::sharedWorker): SharedWorker constructor (only enabled when SHARED_WORKERS is enabled).
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget): Added support for converting to/from SharedWorkers.
  • bindings/js/JSSharedWorkerConstructor.cpp: Added. (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor): (WebCore::constructSharedWorker): (WebCore::JSSharedWorkerConstructor::getConstructData):
  • bindings/js/JSSharedWorkerConstructor.h: Added. (WebCore::JSSharedWorkerConstructor::classInfo):
  • bindings/js/JSSharedWorkerCustom.cpp: Added. (WebCore::JSSharedWorker::mark): Custom mark function that marks the internal MessagePort.
  • bindings/v8/DOMObjectsInclude.h: Updated to include new header files.
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: Added. (WebCore::getEventListener): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): V8 handlers for add/removeEventListener().
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8SharedWorkerCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Custom constructor for SharedWorker.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toSharedWorker):
  • dom/EventTarget.h:
  • page/DOMWindow.idl:
  • workers/AbstractWorker.cpp: Added. (WebCore::AbstractWorker::AbstractWorker): Common base class for SharedWorker and (soon) Worker. The functions below were copied from Worker.cpp. This is the first step in refactoring Worker to derive from AbstractWorker to enable code sharing. (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::addEventListener): (WebCore::AbstractWorker::removeEventListener): (WebCore::AbstractWorker::dispatchEvent): (WebCore::AbstractWorker::dispatchLoadErrorEvent): (WebCore::AbstractWorker::dispatchScriptErrorEvent):
  • workers/AbstractWorker.h: Added. Definitions of functionality shared by Worker.h and SharedWorker.h. In a future patch, Worker will derive from AbstractWorker. (WebCore::AbstractWorker::scriptExecutionContext): (WebCore::AbstractWorker::setOnerror): (WebCore::AbstractWorker::onerror): (WebCore::AbstractWorker::eventListeners): (WebCore::AbstractWorker::refEventTarget): (WebCore::AbstractWorker::derefEventTarget):
  • workers/AbstractWorker.idl: Added.
  • workers/SharedWorker.cpp: Added. (WebCore::SharedWorker::SharedWorker): (WebCore::SharedWorker::~SharedWorker):
  • workers/SharedWorker.h: Added. (WebCore::SharedWorker::create): (WebCore::SharedWorker::port): (WebCore::SharedWorker::toSharedWorker):
  • workers/SharedWorker.idl: Added.

WebKit/mac:

Added ENABLE(SHARED_WORKERS) flag (disabled by default).

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

Added support for --shared-workers (turned off by default)

  • Scripts/build-webkit:

LayoutTests:

Unit tests for new SharedWorker APIs (disabled by default).

  • fast/workers/shared-worker-constructor-expected.txt: Added.
  • fast/workers/shared-worker-constructor.html-disabled: Added.
  • fast/workers/shared-worker-event-listener-expected.txt: Added.
  • fast/workers/shared-worker-event-listener.html-disabled: Added.
1:32 AM Changeset in webkit [45794] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-13 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Cleanup - Remove prf install target
​https://bugs.webkit.org/show_bug.cgi?id=27191

qtwebkit.prf has been removed; this cleans up the related
install target as well.

  • WebCore.pro: Remove prf install target
1:30 AM Changeset in webkit [45793] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-07-07 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

​https://bugs.webkit.org/show_bug.cgi?id=27058

Removed superfluous parenthesis around single expression.
Compilers on Symbian platform fail to properly parse and compile.

1:24 AM Changeset in webkit [45792] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-07-13 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Maciej Stachoviak.

​https://bugs.webkit.org/show_bug.cgi?id=27054

Renamed Translator to HashTranslator

Codewarrior compiler (WINSCW) latest b482 cannot resolve typename
mismatch between template declaration and definition
(HashTranslator / Translator)

  • wtf/HashSet.h:
1:20 AM Changeset in webkit [45791] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-07-13 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=27053

Ambiguity in LabelScope initialization

Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve
type of "0" unambiguously. Set expression explicitly to
PassRefPtr<Label>::PassRefPtr()

  • bytecompiler/BytecodeGenerator.cpp

Jul 12, 2009:

11:12 PM Changeset in webkit [45790] by bfulgham@webkit.org
  • 10 edits in trunk/WebKit

WebKit/gtk:

2009-07-12 Brent Fulgham <​bfulgham@gmail.com>

Speculative build fix after ​http://trac.webkit.org/changeset/45786.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::addMessageToConsole):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/qt:

2009-07-12 Brent Fulgham <​bfulgham@gmail.com>

Speculative build fix after ​http://trac.webkit.org/changeset/45786.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/wx:

2009-07-12 Brent Fulgham <​bfulgham@gmail.com>

Speculative build fix after ​http://trac.webkit.org/changeset/45786.

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::addMessageToConsole):
  • WebKitSupport/ChromeClientWx.h:
11:02 PM Changeset in webkit [45789] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

2009-07-12 Brent Fulgham <​bfulgham@gmail.com>

Speculative Windows build fix after ​http://trac.webkit.org/changeset/45786.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::addMessageToConsole):
10:38 PM Changeset in webkit [45788] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-script-src.pl

Fix executable bit. We should fix bugzilla-tool to understand executable bits.

10:36 PM Changeset in webkit [45787] by abarth@webkit.org
  • 6 edits
    7 adds in trunk

2009-07-12 Adam Barth <​abarth@webkit.org>

Reviewed by Oliver Hunt.

Facebook Chat is broken due to XSS auditor
​https://bugs.webkit.org/show_bug.cgi?id=27179

Instead of just using the script's URL as to detect an XSS attack, we
now use a bit of context before the URL. In particular, we use the
bytes from the beginning of the attribute name to the end of the
attribute value. In virtually all injection attacks, the attacker
would need to supply the attribute name as well as the attribute value.
However, in the Facebook false positive, the attribute name is not
present in the URL.

Tests: http/tests/security/xssAuditor/script-tag-src-redirect-safe.html

http/tests/security/xssAuditor/script-tag-with-source-double-quote.html
http/tests/security/xssAuditor/script-tag-with-source-no-quote.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h:
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
  • page/XSSAuditor.h:

2009-07-12 Adam Barth <​abarth@webkit.org>

Reviewed by Oliver Hunt.

Facebook Chat is broken due to XSS auditor
​https://bugs.webkit.org/show_bug.cgi?id=27179

Add some more test coverage to our handling of script tags with src
attributes. Also, ensure that we don't raise the alarm when a URL
parameter is injected directly into the attribute value.

  • http/tests/security/xssAuditor/resources/echo-script-src.pl: Added.
  • http/tests/security/xssAuditor/script-tag-src-redirect-safe-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/base-href-safe-expected.txt.
  • http/tests/security/xssAuditor/script-tag-src-redirect-safe.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote.html: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote.html: Added.
10:08 PM Changeset in webkit [45786] by bfulgham@webkit.org
  • 36 edits in trunk

WebCore:

2009-07-12 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Refactor ConsoleMessage to add MessageType attribute.
​https://bugs.webkit.org/show_bug.cgi?id=20625

  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::printErrorMessage):
  • dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::count):
  • inspector/InspectorController.h:
  • inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): (WebInspector.ConsoleMessage): Added type property. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleCommandResult): (WebInspector.ConsoleGroup.prototype.addMessage): (WebInspector.ConsoleGroup.prototype._titleClicked):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._addTip): (WebInspector.Resource.prototype._checkWarning):
  • inspector/front-end/inspector.css: Changed ".console-group-title-level" to ".console-group-title"
  • inspector/front-end/inspector.js: (WebInspector.addMessageToConsole):
  • loader/DocLoader.cpp: (WebCore::DocLoader::printAccessDeniedMessage):
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::addMessageToConsole):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reportLocalLoadFailed): (WebCore::FrameLoader::shouldAllowNavigation):
  • page/ChromeClient.h:
  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): (WebCore::Console::addMessage): (WebCore::Console::error): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::timeEnd): (WebCore::Console::warn):
  • page/Console.h: Added MessageType enum. (WebCore::):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
  • workers/GenericWorkerTask.h: Added GenericWorkerTask8 for the extra argument. (WebCore::GenericWorkerTask8::create): (WebCore::GenericWorkerTask8::GenericWorkerTask8): (WebCore::GenericWorkerTask8::performTask): (WebCore::createCallbackTask):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::importScripts):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
  • xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc):

WebKit/mac:

2009-07-12 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Refactor ConsoleMessage to add MessageType attribute.
​https://bugs.webkit.org/show_bug.cgi?id=20625

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole):
9:07 PM Changeset in webkit [45785] by bfulgham@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2009-07-12 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl.

​https://bugs.webkit.org/show_bug.cgi?id=27132

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • dom/HTMLAllCollection.idl: Added.
8:55 PM Changeset in webkit [45784] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-12 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Maciej Stachowiak.

Inspector: Duplicate Computation in Autocompletion
​https://bugs.webkit.org/show_bug.cgi?id=26778

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
6:43 PM Changeset in webkit [45783] by eric.carlson@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

2009-07-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=27197
QuickTime supports data: urls, add a layout test.

  • media/audio-data-url-expected.txt: Added.
  • media/audio-data-url.html: Added.

New test.

  • platform/gtk/Skipped:

Skip the new test.

5:54 PM Changeset in webkit [45782] by mitz@apple.com
  • 10 edits
    1 move
    1 delete in trunk

WebCore:

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=27196
Rename bidi.cpp to RenderBlockLineLayout.cpp and remove bidi.h

  • GNUmakefile.am: Updated.
  • WebCore.gypi: Updated.
  • WebCore.pro: Updated.
  • WebCore.vcproj/WebCore.vcproj: Updated.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • WebCoreSources.bkl: Updated.
  • rendering/RenderBlock.h: Removed unnecessary forward declaration and

updated comments.

  • rendering/RenderBlockLineLayout.cpp: Copied from WebCore/rendering/bidi.cpp.

Removed unnecessary #include statements.

(WebCore::BidiRun::BidiRun): Moved here from bidi.h.
(WebCore::RenderBlock::layoutInlineChildren): Removed outdated comment.

  • rendering/bidi.cpp: Removed.
  • rendering/bidi.h: Removed.

WebKitTools:

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=27196
Update check-for-global-initializers for the renaming for bidi.cpp to
RenderBlockLineLayout.cpp

  • Scripts/check-for-global-initializers:
4:48 PM Changeset in webkit [45781] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

4:41 PM Changeset in webkit [45780] by mitz@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • Image cleanup
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): Use the data() accessor instead of the m_data member. (WebCore::BitmapImage::dataChanged): Ditto.
  • platform/graphics/Image.h: Re-ordered #includes and class declarations. Removed the drawPatternCallback() declaration. Made member variables private.
  • platform/graphics/cg/ImageCG.cpp: (WebCore::drawPatternCallback): Changed this from a member function to a static function.
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Use the data() accessor instead of the m_data member.
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Ditto.
2:49 PM Changeset in webkit [45779] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r45758.

2:49 PM Changeset in webkit [45778] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45755.

2:49 PM Changeset in webkit [45777] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebKit/mac

Merge r45745.

2:49 PM Changeset in webkit [45776] by mrowe@apple.com
  • 18 edits in branches/safari-4-branch

Merge r45744.

2:49 PM Changeset in webkit [45775] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r45736.

2:49 PM Changeset in webkit [45774] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge r45735.

2:48 PM Changeset in webkit [45773] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45734.

2:48 PM Changeset in webkit [45772] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r45733.

2:48 PM Changeset in webkit [45771] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/WebCore

Merge r45732.

2:48 PM Changeset in webkit [45770] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45728.

2:48 PM Changeset in webkit [45769] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r45721.

2:48 PM Changeset in webkit [45768] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r45715.

2:48 PM Changeset in webkit [45767] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-4-branch

Merge r45710.

2:48 PM Changeset in webkit [45766] by mrowe@apple.com
  • 169 edits in branches/safari-4-branch

2009-07-10 Beth Dakin <Beth Dakin>

<rdar://problem/7045243> Roll text metrics change out

  • css/html.css:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
2:47 PM Changeset in webkit [45765] by mrowe@apple.com
  • 29 edits in branches/safari-4-branch

<rdar://problem/7047403> Disable channel messaging

2:47 PM Changeset in webkit [45764] by mrowe@apple.com
  • 14 edits in branches/safari-4-branch

<rdar://problem/7048551> Disable datagrid

2:46 PM Changeset in webkit [45763] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2009-07-12 Daniel Bates <​dbates@intudata.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=27189


Fixes insufficient check in XSSAuditor::canSetBaseElementURL that caused
XSSAuditor to incorrectly block HTML Base elements whose base path coincided
with the URL of the page.

Test: http/tests/security/xssAuditor/base-href-safe3.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL): Changed conditional to only call XSSAuditor::findInRequest() if the host in the page URL disagrees with the host in the base element URL.

2009-07-12 Daniel Bates <​dbates@intudata.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=27189


Tests that XSSAuditor does not block HTML Base elements whose path has the
same host as the page.

  • http/tests/security/xssAuditor/base-href-safe3-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-safe3.html: Added.
  • http/tests/security/xssAuditor/resources/base-href/base-href-safe3.html: Added.
1:27 PM Changeset in webkit [45762] by Darin Adler
  • 9 edits in trunk/WebCore

2009-07-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Text searching with ICU should take the user's default locale into account
​https://bugs.webkit.org/show_bug.cgi?id=27184
rdar://problem/6812121

No simple way to test this since it's dependent on user locale.
After this, the user's default locale is used only on Mac.

  • editing/TextIterator.cpp: (WebCore::createSearcher): Pass result of the currentSearchLocaleID function as the locale.
  • platform/text/TextBreakIteratorInternalICU.h: Added declaration of currentSearchLocaleID function.
  • platform/text/android/TextBreakIteratorInternalICU.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: (WebCore::currentSearchLocaleID): Ditto.
  • platform/text/gtk/TextBreakIteratorInternalICUGtk.cpp: (WebCore::currentSearchLocaleID): Ditto.
  • platform/text/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::textBreakLocalePreference): Added. Returns the value of the AppleTextBreakLocale preference. (WebCore::topLanguagePreference): Added. Returns the value of the first item in the AppleLanguages preference. (WebCore::canonicalLanguageIdentifier): Added. Cover for the CFLocaleCreateCanonicalLanguageIdentifierFromString function. (WebCore::getLocale): Added. Transfers the locale from a CFStringRef into a buffer. (WebCore::getSearchLocale): Added. Calls topLanguagePreference, canonicalLanguageIdentifier, and getLocale. (WebCore::currentSearchLocaleID): Added. Calls getSearchLocale once. (WebCore::getTextBreakLocale): Changed to call textBreakLocalePreference, topLanguagePreference, canonicalLanguageIdentifier, and getLocale.
  • platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
  • platform/wx/TemporaryLinkStubs.cpp: (WebCore::currentSearchLocaleID): Ditto.
11:42 AM Changeset in webkit [45761] by xan@webkit.org
  • 2 edits in trunk

2009-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version in preparation for 1.1.11 release.

  • configure.ac:
10:25 AM Changeset in webkit [45760] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Create a PangoLayout that properly represents the visual
appearance of the text in the web page so that the line boundary
modes of getText{At,Before,After}Offset work correctly.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (UTF16ToUTF8): (g_substr): (convertUniCharToUTF8): (getPangoLayoutForAtk):
Note: See TracTimeline for information about the timeline view.