⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 15, 2009:

11:10 PM Changeset in webkit [45967] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

2009-07-15 David Levin <​levin@chromium.org>

Rubber-stamped by Oliver Hunt.

Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
​https://bugs.webkit.org/show_bug.cgi?id=26254

Change the expected Windows result (similar to the mac result change).

  • platform/win/fast/forms/basic-textareas-expected.txt:
10:32 PM Changeset in webkit [45966] by levin@chromium.org
  • 9 edits in trunk

2009-07-15 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
​https://bugs.webkit.org/show_bug.cgi?id=26254

WebCore:

Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.

This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.

Committer note: Earlier I reverted this change because I did it incorrectly
by leaving out css/html.css. In the patch, the filename was the old name
css/html4.css and that led to my error.

  • css/html.css:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):

LayoutTests:

Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.

This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.

  • fast/forms/basic-textareas.html:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
10:03 PM Changeset in webkit [45965] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 James Hawkins <​jhawkins@google.com>

Reviewed by Adam Barth.

[V8] Remove a local variable that is shadowing a function parameter.
​https://bugs.webkit.org/show_bug.cgi?id=27309

No test required as this modification does not change the current behavior.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
7:28 PM Changeset in webkit [45964] by agl@chromium.org
  • 3 edits
    2 deletes in trunk/WebCore

2009-07-15 Adam Langley <​agl@google.com>

No review: reverting previous change.

Revert r45959:

2009-07-15 Dumitru Daniliuc <​dumi@chromium.org>
Reviewed by Dimitri Glazkov.

Adding the Win SQLite VFS implementation for Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=26940

The Chromium side of this patch was landed in 20839, but broke the build. It
was reverted in r20840. Thus, I'm reverting this side of the patch too.

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: Removed.
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Removed.
5:14 PM Changeset in webkit [45963] by levin@chromium.org
  • 8 edits in trunk

WebCore:

2009-07-15 David Levin <​levin@chromium.org>

Layout test fix, reverting previous change.

Reverting r45962 as it caused several layout test failures.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):

LayoutTests:

2009-07-15 David Levin <​levin@chromium.org>

Layout test fix, reverting previous change.

Reverting r45962 as it caused several layout test failures.

  • fast/forms/basic-textareas.html:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
4:46 PM Changeset in webkit [45962] by levin@chromium.org
  • 8 edits in trunk

2009-06-08 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
​https://bugs.webkit.org/show_bug.cgi?id=26254

WebCore:

Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.

This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.

  • css/html4.css:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):

LayoutTests:

Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.

This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.

  • fast/forms/basic-textareas.html:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
4:35 PM Changeset in webkit [45961] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

4:34 PM Changeset in webkit [45960] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.5

New tag.

4:18 PM Changeset in webkit [45959] by Nate Chapin
  • 3 edits
    3 adds in trunk/WebCore

2009-07-15 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the Win SQLite VFS implementation for Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=26940

4:15 PM Changeset in webkit [45958] by jianli@chromium.org
  • 13 edits in trunk

WebCore:

2009-07-15 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

Bug 25151 - workers that fail to load scripts not firing error event.
​https://bugs.webkit.org/show_bug.cgi?id=25151

This fixes the problem that an error event is not fired when the worker
script fails to load. Some reasons this may occur are an invalid URL for
the worker script or a cross-origin redirect.

We also moves the code to complete the URL and check its origin from
Worker constructor to WorkerScriptLoader loading functions in order to
move the exception throwing logic out of the scope of Worker constructor.
Due to this change, we also remove the output ExceptionCode parameter
in the worker constructor. Corresponding JS/V8 binding codes have been
updated to reflect this change.

  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
  • workers/Worker.h: (WebCore::Worker::create):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerScriptLoader.cpp: (WebCore::toCrossOriginRedirectPolicy): (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::notifyLoadErrorTask): (WebCore::WorkerScriptLoader::createResourceRequest): (WebCore::WorkerScriptLoader::didFail): (WebCore::WorkerScriptLoader::didFailRedirectCheck): (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation): (WebCore::WorkerScriptLoader::notifyError):
  • workers/WorkerScriptLoader.h: (WebCore::): (WebCore::WorkerScriptLoader::url):

LayoutTests:

2009-07-15 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

Bug 25151 - workers that fail to load scripts not firing error event.
​https://bugs.webkit.org/show_bug.cgi?id=25151

Updates layout test cases for bug 25151.

  • fast/workers/worker-constructor-expected.txt:
  • fast/workers/worker-constructor.html:
  • http/tests/workers/worker-redirect-expected.txt:
  • http/tests/workers/worker-redirect.html:
4:11 PM Changeset in webkit [45957] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

4:11 PM Changeset in webkit [45956] by mitz@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

text-shadow is not drawn for text with transparent colour
​https://bugs.webkit.org/show_bug.cgi?id=21374

Test: fast/text/shadow-translucent-fill.html

  • rendering/InlineTextBox.cpp: (WebCore::paintTextWithShadows): If the text fill color is not opaque, paint all shadows separately from the text, by casting them from clipped-out opaque text.

LayoutTests:

Reviewed by Dave Hyatt.

text-shadow is not drawn for text with transparent colour
​https://bugs.webkit.org/show_bug.cgi?id=21374

  • fast/text/shadow-translucent-fill.html: Added.
  • platform/mac/fast/css/shadow-multiple-expected.checksum:
  • platform/mac/fast/css/shadow-multiple-expected.png:
  • platform/mac/fast/text/shadow-translucent-fill-expected.checksum: Added.
  • platform/mac/fast/text/shadow-translucent-fill-expected.png: Added.
  • platform/mac/fast/text/shadow-translucent-fill-expected.txt: Added.
4:02 PM Changeset in webkit [45955] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 Adam Treat <​adam.treat@torchmobile.com>

Fix the Qt build.

  • html/HTMLAreaElement.cpp:
3:56 PM Changeset in webkit [45954] by darin@chromium.org
  • 18 edits in trunk/WebCore

2009-07-15 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Cleanup DOM Storage dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=27180

DOM Storage had several unnecessary (and probably unintended)
dependencies. This patch replaces many includes of header files with
forward declaration of classes, making some destructors explicit, and
taking some factories out of the header files.

This will allow things like StorageAreaSync to take a StorageAreaImpl*
(as it should) rather than a StorageArea* which previously weren't
possible because the dependencies were such a tangled mess.

  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::~LocalStorageTask):
  • storage/LocalStorageTask.h:
  • storage/Storage.cpp: (WebCore::Storage::~Storage):
  • storage/Storage.h:
  • storage/StorageArea.cpp:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync):
  • storage/StorageAreaSync.h:
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
  • storage/StorageEvent.h:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::~StorageSyncManager):
  • storage/StorageSyncManager.h:
3:33 PM Changeset in webkit [45953] by cmarrin@apple.com
  • 3 edits
    2 adds in trunk

Incorrect animation when trying to duplicate effect of transform-origin

​https://bugs.webkit.org/show_bug.cgi?id=27310

The bug is that matrix animation is being used when animating
a list of transform functions that match in the from and to states.
This sometimes works. But because of the way CA does matrix animation
function lists like the one shown in the testcase animate incorrectly.

This fixes the bug by always doing component animation
as long as the function lists match. This allows CA
to animate the components and then recompose the result
into the correct matrix.

3:29 PM Changeset in webkit [45952] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Albert J. Wong <​ajwong@chromium.org>

Reviewed by David Levin.

Upstream the V8NPObject and NPV8Object build changes for WebCore.gypi.

Add upstreamed V8 bindings files into WebCore.gypi so they can be seen
downstream
​https://bugs.webkit.org/show_bug.cgi?id=27274

Changes the build file for chromium. Test built the chromium tree
to verify.

  • WebCore.gypi:
3:24 PM Changeset in webkit [45951] by mrowe@apple.com
  • 2 edits in trunk/WebCore

I like it when the code compiles.

  • WebCore.base.exp:
3:07 PM Changeset in webkit [45950] by sfalken@apple.com
  • 3 edits in branches/safari-4-branch/JavaScriptCore

Merge 45949.

3:02 PM Changeset in webkit [45949] by sfalken@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-15 Steve Falkenburg <​sfalken@apple.com>

Windows Build fix.

Visual Studio reset our intermediate directory on us.
This sets it back.


2:56 PM Changeset in webkit [45948] by sfalken@apple.com
  • 16 edits in branches/safari-4-branch

Merge r45892.

2:50 PM Changeset in webkit [45947] by Darin Adler
  • 40 edits in trunk

WebCore:

2009-07-15 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Renamed parseURL to deprecatedParseURL.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Renamed.
  • bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Renamed.
  • bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Renamed.
  • bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Renamed.
  • bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]): Renamed.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Renamed.
  • bindings/v8/custom/V8CustomBinding.cpp: (WebCore::allowSettingFrameSrcToJavascriptUrl): Renamed.
  • css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Renamed.
  • css/CSSHelper.h: Renamed and updated comment.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Renamed. (WebCore::HTMLAnchorElement::parseMappedAttribute): Renamed.
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::parseMappedAttribute): Renamed.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Renamed.
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Renamed.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::parseMappedAttribute): Renamed.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Renamed.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Renamed.
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::sourceURI): Renamed.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): Renamed.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Renamed.
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Renamed.
  • html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): Renamed.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Renamed.
  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::processAttribute): Renamed. (WebCore::PreloadScanner::emitCSSRule): Renamed.
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage): Renamed.
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage): Renamed.
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage): Renamed.
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): Renamed.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Renamed. (WebCore::HitTestResult::absoluteMediaURL): Renamed. (WebCore::HitTestResult::absoluteLinkURL): Renamed.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Renamed.
  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI): Renamed.
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler): Renamed.
  • wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Renamed.

WebKit/mac:

2009-07-15 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Renamed parseURL to deprecatedParseURL.

  • DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]): Renamed.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Renamed.

WebKit/win:

2009-07-15 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Renamed parseURL to deprecatedParseURL.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Renamed.

WebKitTools:

2009-07-15 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: Check in the version used to rename parseURL to deprecatedParseURL.
2:44 PM Changeset in webkit [45946] by Darin Adler
  • 6 edits
    2 adds in trunk

WebCore:

2009-07-15 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

CSSHelper.h's parseURL is a function that no one should ever call
Part 1: Eliminate callers in the CSS parser.
​https://bugs.webkit.org/show_bug.cgi?id=26599

Test: fast/css/uri-token-parsing.html

  • css/CSSHelper.h: Added a comment explaining why nobody should ever call this function. A FIXME suggests a next step, which would be to rename it deprecatedParseURL.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Removed unneeded call to parseURL; CSSParser::text already takes care of parsing the URI token syntax, and the parseURL function does no good. (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseFillImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto. (WebCore::isCSSWhitespace): Added. Helper function that makes the text function easier to read. (WebCore::CSSParser::text): Tweak logic so that leading and trailing whitespace are both trimmed before removing the quote marks. Changed to use the isCSSWhitespace, isASCIIHexDigit, and toASCIIHexValue functions for clarity.
  • css/CSSParser.h: Removed stray "public:" in this header.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::substring): Optimized the case where the substring covers the entire string, so we just share the StringImpl instead of making a new one. This case came up in earlier versions of the CSS parser changes above. (WebCore::StringImpl::substringCopy): Streamlined the logic here and made it not call substring any more. Before, this was relying on the substring function always making a copy of any non-empty substring.

LayoutTests:

2009-07-15 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

CSSHelper.h's parseURL is a function that no one should ever call
Part 1: Eliminate callers in the CSS parser.
​https://bugs.webkit.org/show_bug.cgi?id=26599

  • fast/css/uri-token-parsing-expected.txt: Added.
  • fast/css/uri-token-parsing.html: Added. Tests URI token parsing cases, many of which were handled wrong before due to stripping quotes and URL() twice.
2:35 PM Changeset in webkit [45945] by Darin Adler
  • 3 edits
    1 copy
    1 add in trunk

WebCore:

2009-07-15 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

After double-clicking a word, using Shift-arrow to select behaves unpredictably
​https://bugs.webkit.org/show_bug.cgi?id=27177
rdar://problem/7034324

Test: editing/selection/extend-selection-after-double-click.html

The bug was due to the m_lastChangeWasHorizontalExtension flag, which was not
being cleared in many cases where it should have been.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Set m_lastChangeWasHorizontalExtension to false. This catches all sorts of cases that don't flow through the modify function. Before, the flag would reflect the last call to the modify function, which was not necessarily the last selection change. (WebCore::SelectionController::willBeModified): Rearrange function for clarity. Remove code that sets m_lastChangeWasHorizontalExtension; that is now handled elsewhere. (WebCore::SelectionController::modify): Call setLastChangeWasHorizontalExtension after setSelection when setting up a trial selection controller, since setSelection now clears that flag. Also changed both trial selection controller cases to set the flag, although it's not strictly necessary in both cases. Added code to set m_lastChangeWasHorizontalExtension when extending the selection, which used to be handled in willBeModified. Now we need to do it after the selection change.

LayoutTests:

2009-07-15 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

After double-clicking a word, using Shift-arrow to select behaves unpredictably
​https://bugs.webkit.org/show_bug.cgi?id=27177
rdar://problem/7034324

  • editing/selection/extend-selection-after-double-click-expected.txt: Added.
  • editing/selection/extend-selection-after-double-click.html: Copied from LayoutTests/editing/selection/word-granularity.html. Then turned it into a new test.
2:16 PM Changeset in webkit [45944] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-07-15 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Need to update DOM Storage files in GYPI file.
​https://bugs.webkit.org/show_bug.cgi?id=27317

Need to update DOM Storage files in the GYPI file. They're pretty out
of date and we're on the path towards enabling them for everyone!

  • WebCore.gypi:
1:55 PM Changeset in webkit [45943] by bfulgham@webkit.org
  • 5 edits in trunk

JavaScriptCore:

2009-07-15 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26794
Make Yacc-generated parsers to use fastMalloc/fastFree.


Define YYMALLOC and YYFREE to fastMalloc and fastFree
respectively.

  • parser/Grammar.y:

WebCore:

2009-07-15 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26794
Make Yacc-generated parsers to use fastMalloc/fastFree.


Define YYMALLOC and YYFREE to fastMalloc and fastFree
respectively.

  • css/CSSGrammar.y:
  • xml/XPathGrammar.y:
1:49 PM Changeset in webkit [45942] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-15 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Jan Alonzo.

Fix enable-xss-auditor property documentation, and default value
to match the fact that it is now enabled by default.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
1:43 PM Changeset in webkit [45941] by hyatt@apple.com
  • 11 edits in trunk

WebCore:

2009-07-15 David Hyatt <​hyatt@apple.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=27193
Don't run in to anonymous blocks. No other browsers do this, and our implementation of run-in
is effectively broken as a result.

No new tests. Changed fast/runin/001.html and fast/runin/generated.html to match new behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):

LayoutTests:

2009-07-15 David Hyatt <​hyatt@apple.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=27193
Don't let run-ins run in to anonymous blocks.

  • fast/runin/001.html:
  • fast/runin/generated.html:
  • platform/mac/fast/runin/001-expected.checksum:
  • platform/mac/fast/runin/001-expected.png:
  • platform/mac/fast/runin/001-expected.txt:
  • platform/mac/fast/runin/generated-expected.checksum:
  • platform/mac/fast/runin/generated-expected.png:
  • platform/mac/fast/runin/generated-expected.txt:
1:15 PM Changeset in webkit [45940] by bfulgham@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-10 David Kilzer <​ddkilzer@apple.com>

bugzilla-tool: create CommitMessage class

Reviewed by Eric Seidel.

Create a CommitMessage class to encapsulate related code.

  • Scripts/bugzilla-tool: (bug_id_from_commit_message): Moved to CommitMessage.parse_bug_id(). (commit_message_for_this_commit): Return a CommitMessage. (ApplyPatchesFromBug.apply_patches): Use CommitMessage.message(). (LandPatchesFromBugs.build_and_commit): Ditto. (CommitMessageForCurrentDiff.execute): Ditto. (PostCommitsAsPatchesToBug.execute): Switched from Git.commit_message_for_commit() to Git.commit_message_for_local_commit(). Switched from bug_id_from_commit_message() to CommitMessage.parse_bug_id().
  • Scripts/modules/scm.py: (first_non_empty_line_after_index): Added. (CommitMessage.init): Added. (CommitMessage.body): Added. (CommitMessage.description): Added. (CommitMessage.message): Added. (CommitMessage.parse_bug_id): Added. Moved from bug_id_from_commit_message() in bugzilla-tool. (Git.commit_message_for_local_commit): Renamed from commit_message_for_commit(). Return a CommitMessage.
1:11 PM Changeset in webkit [45939] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-15 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by David Kilzer.

bugzilla-tool/svn-apply can't handle patches made from a non-root directory
​https://bugs.webkit.org/show_bug.cgi?id=26999

  • Scripts/svn-create-patch:
1:08 PM Changeset in webkit [45938] by bfulgham@webkit.org
  • 21 edits
    4 adds in trunk

WebCore:

2009-07-15 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Test: fast/js/instanceof-operator.html

Fix for: Bug 25205 - XMLHttpRequest instance is not an instanceof XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=25205

In addition to for XMLHttpRequest, this also fixes for:

  • Audio
  • Image
  • MessageChannel
  • Option
  • WebKitCSSMatrix
  • WebKitPoint
  • Worker
  • XSLTProcessor
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMBinding.h: (WebCore::DOMConstructorObject::createStructure): (WebCore::DOMConstructorObject::DOMConstructorObject):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  • bindings/js/JSWebKitCSSMatrixConstructor.h:
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  • bindings/js/JSWebKitPointConstructor.h:
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  • bindings/js/JSWorkerConstructor.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.h:
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  • bindings/js/JSXSLTProcessorConstructor.h:

LayoutTests:

2009-07-15 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Fix for: Bug 25205 - XMLHttpRequest instance is not an instanceof XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=25205

In addition to for XMLHttpRequest, this also fixes for:

  • Audio
  • Image
  • MessageChannel
  • Option
  • WebKitCSSMatrix
  • WebKitPoint
  • Worker
  • XSLTProcessor
  • fast/js/instanceof-operator-expected.txt: Added.
  • fast/js/instanceof-operator.html: Added.
  • fast/js/resources/instanceof-operator-dummy-worker.js: Added.
  • fast/js/resources/instanceof-operator.js: Added.
12:51 PM Changeset in webkit [45937] by bfulgham@webkit.org
  • 5 edits
    4 adds in trunk

WebCore:

2009-07-15 Kai Bruning <​kai@granus.net>

Reviewed by Dave Hyatt.

CSS21 attribute selectors not dynamic for xml.
​https://bugs.webkit.org/show_bug.cgi?id=25072

Moved the relevant test in StyledElement::attributeChanged()
to a new function Element::recalcStyleIfNeededAfterAttributeChanged()
so it can be called from both StyledElement::attributeChanged()
and Element::attributeChanged().
Refactored Element::attributeChanged() into
Element::updateAfterAttributeChanged() and
Element::recalcStyleIfNeededAfterAttributeChanged(), which are called
separately from StyledElement::attributeChanged().

Test: fast/css/attribute-selector-dynamic.xml

  • dom/Element.cpp: (WebCore::Element::attributeChanged): (WebCore::Element::updateAfterAttributeChanged): (WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):
  • dom/Element.h:
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):

LayoutTests:

2009-07-15 Kai Bruning <​kai@granus.net>

Reviewed by Dave Hyatt.

CSS21 attribute selectors not dynamic for xml.
​https://bugs.webkit.org/show_bug.cgi?id=25072

Test that CSS21 attribute selectors take effect when the attribute is
dynamically changed in an xml dom.

  • fast/css/attribute-selector-dynamic.xml: Added.
  • platform/mac/fast/css/attribute-selector-dynamic-expected.checksum: Added.
  • platform/mac/fast/css/attribute-selector-dynamic-expected.png: Added.
  • platform/mac/fast/css/attribute-selector-dynamic-expected.txt: Added.
12:27 PM Changeset in webkit [45936] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Alpha Lam <​hclam@chromium.org>

Reviewed by David Levin.

[V8] Layout test failures for drawImage in Canvas
​https://bugs.webkit.org/show_bug.cgi?id=27311

Fixing several canvas layout tests failures due to a
missing return statement in CanvasRenderingContext2DDrawImage() which
was accidentally removed in r45929.

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
12:16 PM Changeset in webkit [45935] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 Robert Hogan <​robert@roberthogan.net>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26969

If the httpMethod() of the request passed to SubresourceLoader::create is not
supported by the client we must expect to call didFail() while m_loader is still null.

  • loader/DocumentThreadableLoader.cpp: (DocumentThreadableLoader::didFail):Changed.
11:34 AM Changeset in webkit [45934] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-15 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Sam Weinig.

Side bar linking to "DOM Interfaces" returns 404
​https://bugs.webkit.org/show_bug.cgi?id=24000

  • nav.inc:
11:28 AM Changeset in webkit [45933] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Darin Adler <Darin Adler>

Fix a build for a particular Apple configuration.

  • wtf/FastAllocBase.h: Change include to use "" style for including another wtf header. This is the style we use for including other public headers in the same directory.
11:25 AM Changeset in webkit [45932] by levin@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Add bug link to changelog entry.

11:23 AM Changeset in webkit [45931] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 George Staikos <​george.staikos@torchmobile.com>

Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=27303
Implement createThreadInternal for WinCE.
Contains changes by George Staikos <​george.staikos@torchmobile.com> and Joe Mason <​joe.mason@torchmobile.com>

  • wtf/ThreadingWin.cpp: (WTF::createThreadInternal):
11:22 AM Changeset in webkit [45930] by mrowe@apple.com
  • 6 edits in trunk/WebCore

Fix the Mac build.

  • WebCore.base.exp:
  • css/MediaQueryEvaluator.cpp:
  • rendering/SVGRenderTreeAsText.cpp:
  • rendering/style/SVGRenderStyle.cpp:
  • svg/graphics/SVGPaintServer.cpp:
11:21 AM Changeset in webkit [45929] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Alpha Lam <​hclam@chromium.org>

Reviewed by Dimitri Glazkov.

Changed CanvasRenderingContext2DDrawImage() to accept HTMLVideoElement
as a parameter of drawImage() for HTMLCanvasElement.

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
11:14 AM Changeset in webkit [45928] by abarth@webkit.org
  • 7 edits in trunk/WebCore

2009-07-15 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world constructors
​https://bugs.webkit.org/show_bug.cgi?id=27287

Don't enter V8Proxy::m_context before creating DOM constructors.
Instead, use getWrapperContext to get the right context.

After this patch, all my tests pass. I'll enable the feature
downstream and land the tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::lookupDOMWrapper):
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::evaluate):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createWrapperFromCache): (WebCore::V8Proxy::isContextInitialized): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::installDOMWindow): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::getHiddenObjectPrototype): (WebCore::V8Proxy::installHiddenObjectPrototype):
  • bindings/v8/V8Proxy.h:
11:12 AM Changeset in webkit [45927] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Joe Mason <​joe.mason@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=27298
Platform defines for WINCE.
Contains changes by Yong Li <​yong.li@torchmobile.com>,
George Staikos <​george.staikos@torchmobile.com> and Joe Mason <​joe.mason@torchmobile.com>

  • wtf/Platform.h:
11:07 AM Changeset in webkit [45926] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-15 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Darin Adler.

useless null-check statement in visible_units.cpp@logicalStartOfLine
​https://bugs.webkit.org/show_bug.cgi?id=27154

Simple fix.

  • editing/visible_units.cpp: (WebCore::logicalStartOfLine): Doubled honorEditableBoundaryAtOrAfter() call removed.
10:44 AM Changeset in webkit [45925] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Attempted Mac Build Fix.

10:34 AM Changeset in webkit [45924] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=27306
Use RegisterClass instead of RegisterClassEx on WinCE.

  • wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
10:32 AM Changeset in webkit [45923] by beidson@apple.com
  • 12 edits in trunk

WebCore:

2009-07-15 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=27304
WebKit should provide usage and eligibility information about the page cache.

  • WebCore.base.exp:
  • history/CachedFrame.cpp: (WebCore::CachedFrame::childFrameCount):
  • history/CachedFrame.h:
  • history/PageCache.cpp: (WebCore::PageCache::frameCount): (WebCore::PageCache::autoreleasedPageCount):
  • history/PageCache.h: (WebCore::PageCache::pageCount):

WebKit/mac:

2009-07-15 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=27304
WebKit should provide usage and eligibility information about the page cache.

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics numberCachedPages]): (+[WebCoreStatistics numberCachedFrames]): (+[WebCoreStatistics numberAutoreleasedPages]):
  • WebKit.exp:
  • WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): Returns a dictionary with all the data about why the frame is not cacheable. If the frame *is* cacheable, the dictionary is empty.
  • WebView/WebFramePrivate.h:
10:31 AM Changeset in webkit [45922] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-15 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

Chromium's canvas forgets its context after fillText again
​https://bugs.webkit.org/show_bug.cgi?id=27293

No new tests because the test for this was already added in
​https://bugs.webkit.org/show_bug.cgi?id=26436

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite):
10:20 AM Changeset in webkit [45921] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=27301
Use OutputDebugStringW on WinCE since OutputDebugStringA is not supported
Originally written by Yong Li <​yong.li@torchmobile.com> and refactored by
Joe Mason <​joe.mason@torchmobile.com>

  • wtf/Assertions.cpp: vprintf_stderr_common
10:07 AM Changeset in webkit [45920] by levin@chromium.org
  • 1 edit
    2 moves in trunk/WebKitTools

2009-07-15 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

Move cpplint.py to module directory
​https://bugs.webkit.org/show_bug.cgi?id=27302

  • Scripts/modules/cpplint.py: Renamed from WebKitTools/Scripts/cpplint.py.
  • Scripts/modules/cpplint_unittest.py: Renamed from WebKitTools/Scripts/cpplint_unittest.py.
10:02 AM Changeset in webkit [45919] by hyatt@apple.com
  • 19 edits
    10 adds in trunk

WebCore:

2009-07-14 David Hyatt <​hyatt@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=27283

Implement the new 'rem' unit from CSS3.

Added some rem-* tests in fast/css.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::validUnit): (WebCore::unitFromString): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::lex):
  • css/CSSParserValues.cpp: (WebCore::CSSParserValue::createCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort): (WebCore::CSSPrimitiveValue::computeLengthFloat): (WebCore::CSSPrimitiveValue::computeLengthDouble): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::isUnitTypeLength):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition): (WebCore::CSSStyleSelector::createTransformOperations):
  • css/CSSStyleSelector.h:
  • css/MediaQueryEvaluator.cpp: (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval):
  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue):
  • css/tokenizer.flex:
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::usesRemUnits): (WebCore::Document::setUsesRemUnits):
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::cssPrimitiveToLength):
  • svg/graphics/SVGPaintServer.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::dashArrayFromRenderingStyle):
  • svg/graphics/SVGPaintServer.h:

LayoutTests:

2009-07-14 David Hyatt <​hyatt@apple.com>

Reviewed by Simon Fraser.

Add layout tests for the new CSS3 'rem' unit type.

  • fast/css/rem-dynamic-scaling.html: Added.
  • fast/css/rem-units-on-root.html: Added.
  • fast/css/remove-shorthand-expected.checksum: Added.
  • fast/css/remove-shorthand-expected.png: Added.
  • platform/mac/fast/css/rem-dynamic-scaling-expected.checksum: Added.
  • platform/mac/fast/css/rem-dynamic-scaling-expected.png: Added.
  • platform/mac/fast/css/rem-dynamic-scaling-expected.txt: Added.
  • platform/mac/fast/css/rem-units-on-root-expected.checksum: Added.
  • platform/mac/fast/css/rem-units-on-root-expected.png: Added.
  • platform/mac/fast/css/rem-units-on-root-expected.txt: Added.
9:58 AM Changeset in webkit [45918] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=27020
msToGregorianDateTime should set utcOffset to 0 when outputIsUTC is false

  • wtf/DateMath.cpp: (WTF::gregorianDateTimeToMS):
9:56 AM Changeset in webkit [45917] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-15 Brian Weinstein <​bweinstein@apple.com>

Rubberstamped by Mark Rowe.

Add one more test to Windows Skipped List to hopefully get it to stay green.

  • platform/win/Skipped:
9:27 AM Changeset in webkit [45916] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-07-15 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Remove extraneous qualifier, accidentally added in ​http://trac.webkit.org/changeset/45884.

  • bindings/v8/V8DOMWrapper.h: Removed extraneous qualifier.
9:17 AM Changeset in webkit [45915] by Dimitri Glazkov
  • 5 edits in trunk/WebCore

2009-07-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[V8] Update bindings for ValiditeState patch.
​https://bugs.webkit.org/show_bug.cgi?id=19562

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
8:49 AM Changeset in webkit [45914] by Simon Hausmann
  • 5 edits in trunk

JavaScriptCore:

2009-07-15 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Cleanup - Remove obsolete code from the make system
​https://bugs.webkit.org/show_bug.cgi?id=27299

WebCore:

2009-07-15 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Cleanup - Remove obsolete code from the make system
​https://bugs.webkit.org/show_bug.cgi?id=27299

  • WebCore.pro:
8:41 AM Changeset in webkit [45913] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-07-15 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=27285

When the user clicks a link with a target attribute, the newly created window should be visible.
Make new windows created in Qtlauncher visible.

  • QtLauncher/main.cpp: (WebPage::createWindow):
8:33 AM Changeset in webkit [45912] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-15 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix the build without media elements.

  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): Add #if ENABLE(VIDEO) markers around the body of the method.
8:18 AM Changeset in webkit [45911] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-07-07 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=27056

Alternate bool operator for codewarrior compiler (WINSCW).
Compiler (latest b482) reports error for UnspecifiedBoolType construct:
"illegal explicit conversion from 'WTF::OwnArrayPtr<JSC::Register>' to 'bool'"

Same fix as in r38391.

8:14 AM Changeset in webkit [45910] by vestbo@webkit.org
  • 2 edits in trunk

2009-07-15 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Fix the Qt/Mac build by disabling TestNetscapePlugin

We should fix and enable this once we run DRT for Qt/Mac

  • WebKit.pro:
8:14 AM Changeset in webkit [45909] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Darin Adler.

Qualify include path with wtf to fix compilation
on Symbian.
​https://bugs.webkit.org/show_bug.cgi?id=27055

  • interpreter/Interpreter.h:
7:18 AM Changeset in webkit [45908] by Simon Hausmann
  • 4 edits in trunk/JavaScriptCore

2009-07-15 Laszlo Gombos <Laszlo Gombos>

Reviewed by Dave Kilzer.

Turn off non-portable date manipulations for SYMBIAN
​https://bugs.webkit.org/show_bug.cgi?id=27064

Introduce HAVE(TM_GMTOFF), HAVE(TM_ZONE) and HAVE(TIMEGM) guards
and place the rules for controlling the guards in Platform.h.
Turn off these newly introduced guards for SYMBIAN.

  • wtf/DateMath.cpp: (WTF::calculateUTCOffset):
  • wtf/DateMath.h: (WTF::GregorianDateTime::GregorianDateTime): (WTF::GregorianDateTime::operator tm):
  • wtf/Platform.h:
7:04 AM Changeset in webkit [45907] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-07-15 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Undef ASSERT on Symbian, to avoid excessive warnings
​https://bugs.webkit.org/show_bug.cgi?id=27052

  • wtf/Assertions.h:
5:51 AM Changeset in webkit [45906] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2009-07-15 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=27295

Re-implement QWebPage::shouldInterruptJavaScript to disable
js interruption and avoid showing a messagebox during Qt DRT
runs when script execution takes a bit longer.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::shouldInterruptJavaScript): Return false in re-implemented slot.
5:49 AM Changeset in webkit [45905] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-07-15 Aron Xu <​aronmalache@163.com>

Rubber-stamped by Jan Alonzo.

Simplified Chinese translation
​https://bugs.webkit.org/show_bug.cgi?id=27252

  • zh_CN.po: Added.
5:16 AM Changeset in webkit [45904] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

REGRESSION: fast/js/postfix-syntax.html fails with interpreter
​https://bugs.webkit.org/show_bug.cgi?id=27294

Reviewed by Simon Hausmann.

When postfix operators operating on locals assign to the same local
the order of operations has to be to store the incremented value, then
store the unmodified number. Rather than implementing this subtle
semantic in the interpreter I've just made the logic explicit in the
bytecode generator, so x=x++ effectively becomes x=ToNumber(x) (for a
local var x).

2:59 AM Changeset in webkit [45903] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

REGRESSION(43559): fast/js/kde/arguments-scope.html fails with interpreter
​https://bugs.webkit.org/show_bug.cgi?id=27259

Reviewed by Simon Hausmann

The interpreter was incorrectly basing its need to create the arguments object
based on the presence of the callframe's argument reference rather than the local
arguments reference. Based on this it then overrode the local variable reference.

2:32 AM Changeset in webkit [45902] by jmalonzo@webkit.org
  • 1 edit in trunk/WebKit/gtk/po/ChangeLog

Fix ChangeLog attribution to Bruce Cowan

2:29 AM Changeset in webkit [45901] by jmalonzo@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-07-15 Jan Michael Alonzo <​jmalonzo@webkit.org>

Rubber-stamped by Jan Alonzo.

[Gtk] en_GB translation
​https://bugs.webkit.org/show_bug.cgi?id=27244

  • en_GB.po: Added.
2:12 AM Changeset in webkit [45900] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-15 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Jan Alonzo.

Fix the DumpRenderTree GTK+ build
​https://bugs.webkit.org/show_bug.cgi?id=27290

Set USE_SYSTEM_MALLOC macro for the DumpRenderTree build to
disable using TCmalloc in DumpRenderTree.

  • GNUmakefile.am:
1:10 AM Changeset in webkit [45899] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Move storeLastActivePanel out of the
ifdef ENABLE_JAVASCRIPT_DEBUGGER section in IDL;
Add default panel for the first opening of the
WebInspector.

​https://bugs.webkit.org/show_bug.cgi?id=27263

  • inspector/InspectorController.cpp: (InspectorController::setWindowVisible):
  • inspector/InspectorController.idl:

Jul 14, 2009:

11:44 PM Changeset in webkit [45898] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-14 Brian Weinstein <​bweinstein@apple.com>

Rubberstamped by Mark Rowe.

Add tests to Windows Skip list to get it back in green.

  • platform/win/Skipped:
11:00 PM Changeset in webkit [45897] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Steve Falkenburg <​sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

10:58 PM Changeset in webkit [45896] by Darin Adler
  • 2 edits in trunk/WebCore

2009-07-14 Darin Adler <Darin Adler>

Try to fix Windows build.

  • bindings/scripts/CodeGeneratorCOM.pm: Add Reflect and ReflectURL support.
10:40 PM Changeset in webkit [45895] by Darin Adler
  • 38 edits in trunk

Clear stray executable bits that have crept in over time.

10:40 PM Changeset in webkit [45894] by pdherbemont@apple.com
  • 3 edits in trunk/WebCore

2009-07-14 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Oliver Hunt.

HTMLMediaElement::supportsFullscreen() should return false
​https://bugs.webkit.org/show_bug.cgi?id=27284

(Reverting a part of 45875)

HTMLVideoElement::supportsFullscreen() will properly do the
job, and check if the backend supports fullscreen.

HTMLVideoElement is the only subclass to support fullscreen
(conditionnaly). HTMLAudioElement fullscreen is not supported
and is a different kind of fullscreen, if it comes to be wanted.

No test can be done currently given that none of the media
backends support fullscreen.

  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::supportsFullscreen):
10:26 PM Changeset in webkit [45893] by Darin Adler
  • 26 edits in trunk/WebCore

2009-07-14 Darin Adler <Darin Adler>

Reviewed by Dimitri Glazkov.

Next step in making DOM attribute getter/setters consistently use AtomicString
​https://bugs.webkit.org/show_bug.cgi?id=25425

This covers eight DOM classes, and for each one of the classes:

  • Changes the IDL to use the Reflect syntax for all simple cases.
  • Removes unused functions in the classes, mainly newly unused ones that were used for reflection before.
  • Removes unneeded explicitly defined destructors.
  • Explicitly declares destructors as virtual.
  • Removes unneeded includes.
  • Makes members protected or private rather than public where possible.
  • Renames "doc" to "document".
  • Tweaks formatting to match our latest style in a few places.
  • Improves some FIXME comments.

Over time we'll want to do this for all HTML DOM classes.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement):
  • html/HTMLAnchorElement.h: (WebCore::HTMLAnchorElement::endTagRequirement): (WebCore::HTMLAnchorElement::tagPriority):
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.cpp:
  • html/HTMLAppletElement.h:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
  • html/HTMLAreaElement.h: (WebCore::HTMLAreaElement::endTagRequirement): (WebCore::HTMLAreaElement::tagPriority):
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::parseMappedAttribute):
  • html/HTMLBRElement.h:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::HTMLBaseElement): (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process):
  • html/HTMLBaseElement.h:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.cpp: (WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
  • html/HTMLBaseFontElement.h: (WebCore::HTMLBaseFontElement::endTagRequirement): (WebCore::HTMLBaseFontElement::tagPriority):
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  • html/HTMLBlockquoteElement.h: (WebCore::HTMLBlockquoteElement::tagPriority):
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::HTMLBodyElement): (WebCore::HTMLBodyElement::addSubresourceAttributeURLs):
  • html/HTMLBodyElement.h: (WebCore::HTMLBodyElement::endTagRequirement): (WebCore::HTMLBodyElement::tagPriority):
  • html/HTMLBodyElement.idl: Made changes as described above.
  • loader/FrameLoader.cpp: Removed unneeded include of HTMLAnchorElement.h.
10:22 PM Changeset in webkit [45892] by sfalken@apple.com
  • 15 edits in trunk

JavaScriptCore:

2009-07-14 Steve Falkenburg <​sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

WebCore:

2009-07-14 Steve Falkenburg <​sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:

WebKit/win:

2009-07-14 Steve Falkenburg <​sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2009-07-14 Steve Falkenburg <​sfalken@apple.com>

Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/

Reviewed by Darin Adler.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
10:13 PM Changeset in webkit [45891] by bfulgham@webkit.org
  • 113 edits in trunk

JavaScriptCore:

2009-07-14 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
​https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

  • bytecode/SamplingTool.h:
  • bytecompiler/RegisterID.h:
  • interpreter/CachedCall.h:
  • interpreter/RegisterFile.h:
  • parser/Lexer.h:
  • parser/Parser.h:
  • runtime/ArgList.h:
  • runtime/BatchedTransitionOptimizer.h:
  • runtime/Collector.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSCell.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSLock.h:
  • runtime/JSONObject.cpp:
  • runtime/SmallStrings.cpp:
  • runtime/SmallStrings.h:
  • wtf/CrossThreadRefCounted.h:
  • wtf/GOwnPtr.h:
  • wtf/Locker.h:
  • wtf/MessageQueue.h:
  • wtf/OwnArrayPtr.h:
  • wtf/OwnFastMallocPtr.h:
  • wtf/OwnPtr.h:
  • wtf/RefCounted.h:
  • wtf/ThreadSpecific.h:
  • wtf/Threading.h:
  • wtf/Vector.h:
  • wtf/unicode/Collator.h:

WebCore:

2009-07-14 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
​https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

  • bindings/js/GCController.h:
  • bindings/js/WorkerScriptController.h:
  • bindings/v8/V8DOMMap.cpp: (WebCore::):
  • bridge/runtime.h:
  • css/CSSSelector.h:
  • css/CSSSelectorList.h:
  • css/CSSStyleSelector.h:
  • dom/ClassNames.h:
  • dom/MessagePortChannel.h:
  • dom/XMLTokenizerLibxml2.cpp:
  • dom/XMLTokenizerScope.h:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/SelectionController.h:
  • editing/TextIterator.cpp:
  • history/PageCache.h:
  • html/CanvasRenderingContext2D.h:
  • html/HTMLParser.h:
  • html/HTMLParserQuirks.h:
  • html/PreloadScanner.h:
  • loader/Cache.h:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/FrameLoader.h:
  • loader/ProgressTracker.h:
  • loader/ThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/archive/ArchiveResourceCollection.h:
  • loader/icon/IconDatabase.h:
  • loader/icon/IconLoader.h:
  • loader/icon/PageURLRecord.h:
  • loader/loader.h:
  • page/ContextMenuController.h:
  • page/EventHandler.h:
  • page/FrameTree.h:
  • page/Page.h:
  • page/PageGroup.h:
  • page/PageGroupLoadDeferrer.h:
  • page/mac/EventHandlerMac.mm:
  • platform/AutodrainedPool.h:
  • platform/ContextMenu.h:
  • platform/EventLoop.h:
  • platform/HostWindow.h:
  • platform/Pasteboard.h:
  • platform/PurgeableBuffer.h:
  • platform/RunLoopTimer.h:
  • platform/ThreadGlobalData.h:
  • platform/ThreadTimers.h:
  • platform/Timer.h:
  • platform/TreeShared.h:
  • platform/graphics/FontData.h:
  • platform/graphics/GlyphWidthMap.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/skia/GraphicsContextPlatformPrivate.h:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/win/QTMovieWin.cpp:
  • platform/mac/LocalCurrentGraphicsContext.h:
  • platform/network/FormDataBuilder.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/text/StringBuffer.h:
  • platform/text/TextCodec.h:
  • platform/win/WindowMessageBroadcaster.h:
  • rendering/CounterNode.h:
  • rendering/LayoutState.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderView.h:
  • rendering/TransformState.h:
  • svg/SVGAnimatedProperty.h:
  • svg/SynchronizableTypeWrapper.h:
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerRunLoop.cpp:
  • xml/XPathExpressionNode.h:
  • xml/XPathParser.h:
  • xml/XPathPredicate.h:
  • xml/XPathStep.h:

WebKit/gtk:

2009-07-14 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
​https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

  • webkit/webkitdownload.cpp:

WebKit/win:

2009-07-14 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change all Noncopyable inheriting visibility to public.
​https://bugs.webkit.org/show_bug.cgi?id=27225

Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).

  • COMEnumVariant.h:
  • WebDatabaseManager.cpp:
  • WebInspector.h:
  • WebLocalizableStrings.cpp:
10:04 PM Changeset in webkit [45890] by darin@chromium.org
  • 3 edits
    2 adds in trunk

2009-07-14 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

Fails to save document state when navigating away from a page with a
reference fragment.
​https://bugs.webkit.org/show_bug.cgi?id=27281

Test: fast/history/saves-state-after-fragment-nav.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::isCurrentDocument): Use equalIgnoringRef to compare URLs.
8:43 PM Changeset in webkit [45889] by bfulgham@webkit.org
  • 5 edits in trunk/WebCore

2009-07-14 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Sam Weinig.

Inspector: Remove Unintended Global Variables
​https://bugs.webkit.org/show_bug.cgi?id=27203

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/inspector.js: (WebInspector.animateStyle):
7:03 PM Changeset in webkit [45888] by pkasting@chromium.org
  • 19 edits
    5 adds in trunk

WebCore:

2009-07-14 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=19562
Added build stuff and stub for the ValidityState class, part of HTML5
section Forms:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate

Test: fast/forms/ValidityState-001.html

  • DerivedSources.cpp: Inclusion of ValidityState files
  • DerivedSources.make: ditto
  • GNUmakefile.am: ditto
  • WebCore.gypi: ditto
  • WebCore.pro: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • WebCoreSources.bkl: ditto
  • html/HTMLButtonElement.idl: validity attribute
  • html/HTMLFieldSetElement.idl: ditto
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::validity): ValidityState getter
  • html/HTMLFormControlElement.h: ditto
  • html/HTMLInputElement.idl: validity attribute
  • html/HTMLSelectElement.idl: ditto
  • html/HTMLTextAreaElement.idl: ditto
  • html/ValidityState.cpp: Added. (WebCore::ValidityState::ValidityState): (WebCore::ValidityState::valid): validation flag
  • html/ValidityState.h: Added. (WebCore::ValidityState::create): validation flag (WebCore::ValidityState::control): ditto (WebCore::ValidityState::valueMissing): ditto (WebCore::ValidityState::typeMismatch): ditto (WebCore::ValidityState::patternMismatch): ditto (WebCore::ValidityState::tooLong): ditto (WebCore::ValidityState::rangeUnderflow): ditto (WebCore::ValidityState::rangeOverflow): ditto (WebCore::ValidityState::stepMismatch): ditto (WebCore::ValidityState::customError): ditto
  • html/ValidityState.idl: Added.

LayoutTests:

2009-07-14 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=19562
Minimal test case for ValidityState; more tests are going to be added
along with specific validation routines.

  • fast/dom/domListEnumeration-expected.txt: increased expected value of 1 to match the new "validity" attribute
  • fast/dom/resources/domListEnumeration.js: ditto
  • fast/forms/ValidityState-001-expected.txt: Added.
  • fast/forms/ValidityState-001.html: Added.
6:11 PM Changeset in webkit [45887] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change ParserArenaRefCounted's superclass to RefCountedCustomAllocated
​https://bugs.webkit.org/show_bug.cgi?id=27249

ParserArenaDeletable customizes operator new, to avoid double inheritance
ParserArenaDeletable's superclass has been changed to RefCountedCustomAllocated.

  • parser/Nodes.h:
6:02 PM Changeset in webkit [45886] by jparent@chromium.org
  • 6 edits
    2 adds in trunk

WebCore:

2009-07-14 Ryosuke Niwa <​rniwa@google.com>

Reviewed by Eric Seidel.

Outdenting a line inside a blockquote tag does nothing
​https://bugs.webkit.org/show_bug.cgi?id=25316

The bug was caused by the code checking whether the blockquote is created by WebKit or not.
We simply remove this code to be consistent with Firefox and Internet Explorer.
Also, enclosingBlockFlow == enclosingNode in outdentParagraph isn't a sufficient condition to insert
the placeholder before the enclosingNode because there could be contents before the current paragraph.
Instead, we should split the enclosingNode (which is a blockquote) at the starting position of outdentation.
It turned out that this solves the bug 25315 also: ​https://bugs.webkit.org/show_bug.cgi?id=25315

Test: editing/execCommand/outdent-regular-blockquote.html

  • editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote): no longer checks whether a blockquote is created by WebKit or not. (WebCore::IndentOutdentCommand::outdentParagraph): takes care of the case enclosingBlockFlow == enclosingNode

LayoutTests:

2009-07-14 Ryosuke Niwa <​rniwa@google.com>

Reviewed by Eric Seidel.

Outdenting a line inside a blockquote tag does nothing
​https://bugs.webkit.org/show_bug.cgi?id=25315
​https://bugs.webkit.org/show_bug.cgi?id=25316

The expected result for /editing/execCommand/outdent-selection-expected.html
was rebaselined since the original expected result was wrong (Bug 25315).
Namely, "ipsum" moved to the same paragraph as "more Lorem!"
("ipsum" was in the blockblock immediately below "more Lorem!")
and "Dolor" was moved above the list items "Foo", "Bar", and "Baz".

  • editing/execCommand/outdent-regular-blockquote-expected.txt: Added.
  • editing/execCommand/outdent-regular-blockquote.html: Added.
  • platform/mac/editing/execCommand/outdent-selection-expected.checksum:
  • platform/mac/editing/execCommand/outdent-selection-expected.png:
  • platform/mac/editing/execCommand/outdent-selection-expected.txt:
5:47 PM Changeset in webkit [45885] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Add RefCountedCustomAllocated to RefCounted.h
​https://bugs.webkit.org/show_bug.cgi?id=27232

Some class which are inherited from RefCounted customize
operator new, but RefCounted is inherited from Noncopyable
which will be inherited from FastAllocBase. To avoid
conflicts Noncopyable inheriting was moved down to RefCounted
and to avoid double inheritance this class has been added.

  • wtf/RefCounted.h: (WTF::RefCountedCustomAllocated::deref): (WTF::RefCountedCustomAllocated::~RefCountedCustomAllocated):
5:10 PM Changeset in webkit [45884] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-14 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world wrappers for Node prototypes
​https://bugs.webkit.org/show_bug.cgi?id=27277

This change does two things:

1) We bypass the wrapper cache in the isolated world. This is because

the wrapper template cache has prototypes that lead to the main
world. We can add a template cache for the isolated world if
performance warrants.

2) We introduce a smarter way to grab the wrapper context for a frame

that is aware that proxy <-> context do not stand in one-to-one
correspondence. This generalizes our solution for the node wrapper
case to prototypes.

The net result is that Node wrappers get the right prototypes. As
before, tests to follow.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::getWrapperContext):
  • bindings/v8/V8DOMWrapper.h:
5:05 PM Changeset in webkit [45883] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Add NoncopyableCustomAllocated to Noncopyable.h.
​https://bugs.webkit.org/show_bug.cgi?id=27228


Some classes which inherited from Noncopyable overrides operator new
since Noncopyable'll be inherited from FastAllocBase, Noncopyable.h
needs to be extended with this new class to support the overriding.

  • wtf/Noncopyable.h: (WTFNoncopyable::NoncopyableCustomAllocated::NoncopyableCustomAllocated): (WTFNoncopyable::NoncopyableCustomAllocated::~NoncopyableCustomAllocated):
4:36 PM Changeset in webkit [45882] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-14 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world wrappers for Nodes
​https://bugs.webkit.org/show_bug.cgi?id=27271

Previously, we keepy a pointer to the DOMMap on V8Proxy, but this
caused us to miss the branch in V8DOMMap.cpp for isolated worlds.

I have tests, but I can't land them until I get this feature under
control.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNodeToV8Object):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::V8Proxy):
4:16 PM Changeset in webkit [45881] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's IdentifierTable class
​https://bugs.webkit.org/show_bug.cgi?id=27260

Inherits IdentifierTable class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Identifier.cpp:70.

  • runtime/Identifier.cpp:
4:09 PM Changeset in webkit [45880] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-14 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Fix isolated world crash on getting window.location
​https://bugs.webkit.org/show_bug.cgi?id=27268

I have a test for this locally, but it requires a compile-time hack to
run. Once I get the feature's stability under control, we can turn the
feature on and add the tests.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenWindowReference):
  • bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::context):
4:02 PM Changeset in webkit [45879] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-14 Brent Fulgham <​bfulgham@webkit.org>

Correct failing tests after r45875. The original patch did not
test the m_player member for null, causing crashes. This will
happen fairly frequently in real use. Was this original patch
ever tested?
​https://bugs.webkit.org/show_bug.cgi?id=27246

Test via existing media tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::supportsFullscreen): Check for null pointer. (WebCore::HTMLMediaElement::supportsSave): Check for null pointer.
3:50 PM Changeset in webkit [45878] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-14 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

Explicitly mark the HTML generated for the Mac as being UTF-8 encoded.
The Windows clipboard format is explicitly documented as being UTF-8,
and all Linux apps assume UTF-8. On the Mac, though, unless otherwise
indicated, Windows-1252 is assumed, which is wrong.

Bug: ​https://bugs.webkit.org/show_bug.cgi?id=27262

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection):
3:43 PM Changeset in webkit [45877] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-14 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's Profiler class
​https://bugs.webkit.org/show_bug.cgi?id=27253

Inherits Profiler class from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/profiler/Profiler.cpp:56.

  • profiler/Profiler.h:
3:35 PM Changeset in webkit [45876] by Nate Chapin
  • 3 edits
    2 adds in trunk/WebCore

2009-07-14 Albert J. Wong <​ajwong@chromium.org>

Reviewed by Dimitri Glazkov.

Upstream V8NPObject.h and V8NPObject.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=27103

This just upstreams the files from the chromium code base. Only
minor changes to formatting and similar were done, so no testing
is required because nothing really changed. Code verified to compile.

3:20 PM Changeset in webkit [45875] by bfulgham@webkit.org
  • 8 edits in trunk/WebCore

2009-07-14 Albert J. Wong <​ajwong@chromium.org>

Reviewed by Darin Adler.

Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
​https://bugs.webkit.org/show_bug.cgi?id=27246

Added an implementation of supportsSave() into HTMLMediaElement
that delegates to MediaPlayerPrivateImpl so that the media engine
is able to signal whether or not a media source supports saving.

Also added a function to HitTestResult that allows for retrieval
of the currentSrc associated with the "hit" media element.


These functions are just pipeing with no visible UI change so there
are no related layout test changes.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::supportsFullscreen): (WebCore::HTMLMediaElement::supportsSave):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::supportsSave):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsFullscreen): (WebCore::MediaPlayerPrivateInterface::supportsSave):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::altDisplayString): (WebCore::HitTestResult::absoluteMediaURL):
  • rendering/HitTestResult.h:
3:00 PM Changeset in webkit [45874] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-07-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Implement Reflect and ReflectURL attribute support.
​https://bugs.webkit.org/show_bug.cgi?id=27273

  • bindings/scripts/CodeGeneratorV8.pm: Added support for Reflect and ReflectURL attributes.
2:28 PM Changeset in webkit [45873] by bfulgham@webkit.org
  • 8 edits in trunk/WebCore

2009-07-14 Dmitry Titov <​dimich@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=27266
Add hasCurrentPoint() to WebCore::Path.
This fixes Skia-based Chromium regression caused by the fix for
​https://bugs.webkit.org/show_bug.cgi?id=27187.
For Skia, the new method always returns 'true', pending actual implementation.
This means Chromium still will differ from Gecko behavior, but at least its Canvas
will not be completely broken.

Existing Canvas Layout Tests should pass in Chromium after this change.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::lineTo): insteand of Path::isEmpty() test for hasCurrentPoint(). (WebCore::CanvasRenderingContext2D::quadraticCurveTo): ditto. (WebCore::CanvasRenderingContext2D::bezierCurveTo): ditto.
  • platform/graphics/Path.h:
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::hasCurrentPoint):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::isEmpty): (WebCore::Path::hasCurrentPoint):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::hasCurrentPoint):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::hasCurrentPoint):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::hasCurrentPoint): All these files add a Path::hasCurrentPoint() for various platforms.
2:15 PM Changeset in webkit [45872] by Nate Chapin
  • 2 edits
    2 adds in trunk/WebCore

2009-07-14 Nate Chapin <Nate Chapin>

Reviewed by Sam Weinig.

Upstream RGBColor from src.chromium.org.

​https://bugs.webkit.org/show_bug.cgi?id=27133

2:05 PM Changeset in webkit [45871] by mpcomplete@chromium.org
  • 4 edits in trunk/WebCore

2009-07-10 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Darin Fisher.

[V8] Rename the didCreate/DestroyScriptContext calls to make it
clear that that those refer to the frame's contxt. Add another
similar call for when creating contexts via evaluateInNewContext.
​https://bugs.webkit.org/show_bug.cgi?id=27104

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::initContextIfNeeded):
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame): (WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame): (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
  • loader/FrameLoaderClient.h:
1:45 PM Changeset in webkit [45870] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebKit/mac

Merge r45834.

1:45 PM Changeset in webkit [45869] by mrowe@apple.com
  • 3 edits
    9 adds in branches/safari-4-branch

Merge r45850.

1:45 PM Changeset in webkit [45868] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r45836.

1:45 PM Changeset in webkit [45867] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r45832.

1:39 PM Changeset in webkit [45866] by bfulgham@webkit.org
  • 18 edits in trunk/WebCore

2009-07-14 Brent Fulgham <​bfulgham@webkit.org>

Revert ​http://trac.webkit.org/changeset/45864 after
breaking of Windows build.

  • storage/LocalStorageTask.cpp:
  • storage/LocalStorageTask.h:
  • storage/Storage.cpp:
  • storage/Storage.h:
  • storage/StorageArea.cpp:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:
  • storage/StorageAreaSync.h:
  • storage/StorageEvent.cpp:
  • storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.cpp:
  • storage/StorageSyncManager.h:
1:21 PM Changeset in webkit [45865] by treat@webkit.org
  • 3 edits
    2 adds in trunk/JavaScriptCore

2009-07-06 George Staikos <​george.staikos@torchmobile.com>

Reviewed by Adam Treat.

Authors: George Staikos <​george.staikos@torchmobile.com>, Joe Mason <​joe.mason@torchmobile.com>, Makoto Matsumoto <​matumoto@math.keio.ac.jp>, Takuji Nishimura

​https://bugs.webkit.org/show_bug.cgi?id=27030
Implement custom RNG for WinCE using Mersenne Twister

  • wtf/RandomNumber.cpp: (WTF::randomNumber):
  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
  • wtf/wince/mt19937ar.c: Added. (init_genrand): (init_by_array): (genrand_int32): (genrand_int31): (genrand_real1): (genrand_real2): (genrand_real3): (genrand_res53):
12:36 PM Changeset in webkit [45864] by bfulgham@webkit.org
  • 18 edits in trunk/WebCore

2009-07-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Adler.

Cleanup DOM Storage dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=27180

DOM Storage had several unnecessary (and probably unintended)
dependencies. This patch replaces many includes of header files with
forward declaration of classes, making some destructors explicit, and
taking some factories out of the header files.

This will allow things like StorageAreaSync to take a StorageAreaImpl*
(as it should) rather than a StorageArea* which previously weren't
possible because the dependencies were such a tangled mess.

  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::~LocalStorageTask):
  • storage/LocalStorageTask.h:
  • storage/Storage.cpp: (WebCore::Storage::~Storage):
  • storage/Storage.h:
  • storage/StorageArea.cpp:
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp:
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync):
  • storage/StorageAreaSync.h:
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
  • storage/StorageEvent.h:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::~StorageSyncManager):
  • storage/StorageSyncManager.h:
10:54 AM Changeset in webkit [45863] by treat@webkit.org
  • 3 edits in trunk/WebCore

2009-07-14 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=26983

Check to make sure the view is attached to a frame() in the visibleContentsResized()
method as it can be triggered before the view is attached by Frame::createView(...)
setting various values such as setScrollBarModes(...) for example. An ASSERT is
triggered when a view is layout before being attached to a frame().

  • page/FrameView.cpp: (WebCore::FrameView::visibleContentsResized):
  • page/FrameView.h:
9:56 AM Changeset in webkit [45862] by treat@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-14 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Zack Rusin.

​https://bugs.webkit.org/show_bug.cgi?id=26983

The default constructed values for QSize and WebCore::IntSize are different. The former
produces an invalid size whereas the latter produces a size of zero. This was causing
a layout to be triggered when constructing a view and an assert to be hit. This patch fixes
the crash by taking care not to cause an unnecessary layout triggered by ScrollView::setFixedL

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
9:29 AM Changeset in webkit [45861] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2009-07-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: show last opened panel when invoking inspector.

​https://bugs.webkit.org/show_bug.cgi?id=27263

  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting):
  • inspector/InspectorController.idl:
  • inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.loaded):
9:25 AM Changeset in webkit [45860] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-07-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Speed up access to NodeList length.
​https://bugs.webkit.org/show_bug.cgi?id=27264

That's a minimal alternation of the code.

  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): 1) use AtomicString for comparison, 2) use v8::Integer::New instead of v8::Number::New.
9:16 AM Changeset in webkit [45859] by Dimitri Glazkov
  • 10 edits in trunk/WebCore

2009-07-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Do not do unnecessary conversions from v8::Handle<v8::Value> to
v8::Handle<v8::Object> and accompanying changes.
​https://bugs.webkit.org/show_bug.cgi?id=26953

Three things:

1) do not cast from v8::Value to v8::Object if unnecessary---casts are cheap,
but are not free (they check for emptiness of handle);
2) inline conversion from wrapper to node;
3) simplify case to an ASSERT.

This is just a refactoring, so no new tests are needed.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::convertToSVGPODTypeImpl):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::convertDOMWrapperToNative): (WebCore::V8Proxy::convertToNativeObject): (WebCore::V8Proxy::convertToNativeEvent):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toCanvasStyle): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CustomBinding.cpp: (WebCore::V8Custom::GetTargetFrame):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
9:06 AM Changeset in webkit [45858] by Darin Adler
  • 4 edits
    1 copy
    1 add in trunk

WebCore:

2009-07-14 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Straight quotes should match fancy quotes in in-page search
​https://bugs.webkit.org/show_bug.cgi?id=27217

Tests: fast/text/find-quotes.html

  • editing/TextIterator.cpp: (WebCore::foldQuoteMark): Added. (WebCore::foldQuoteMarks): Added. (WebCore::SearchBuffer::SearchBuffer): Call foldQuoteMarks on the target string. (WebCore::SearchBuffer::append): Call foldQuoteMarks on characters as they are added to the search buffer.
  • platform/text/CharacterNames.h: Added more quotation mark character names. Sorted character names with the sort tool.

LayoutTests:

2009-07-14 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Straight quotes should match fancy quotes in in-page search
​https://bugs.webkit.org/show_bug.cgi?id=27217

  • fast/text/find-quotes-expected.txt: Added.
  • fast/text/find-quotes.html: Copied from LayoutTests/fast/text/find-case-folding.html.
8:42 AM Changeset in webkit [45857] by levin@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2009-07-14 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

WebKit needs a style linting tool
​https://bugs.webkit.org/show_bug.cgi?id=25884

Modifies cpplint (​http://google-styleguide.googlecode.com/svn/trunk/cpplint/)
based on WebKit's style guide.

  • Scripts/cpplint.py: Added.
  • Scripts/cpplint_unittest.py: Added.
6:04 AM Changeset in webkit [45856] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2009-07-14 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] DumpRenderTree no longer builds with Qt4.4
​https://bugs.webkit.org/show_bug.cgi?id=27257

Flag Qt 4.5 dependency to allow building with Qt 4.4.

  • DumpRenderTree/qt/main.cpp: (main):
Note: See TracTimeline for information about the timeline view.