Context Navigation

include the spread length for box-shadow but not for text-shadow.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Pass the property ID to valueForShadow().

css/CSSParser.cpp: (WebCore::ShadowParseContext::ShadowParseContext): Added property,

spread, and allowSpread members. Added a property ID parameter to
the constructor. Initialize the property and allowSpread members.

(WebCore::ShadowParseContext::allowLength): Added allowSpread.
(WebCore::ShadowParseContext::commitValue): Pass the spread value to

the ShadowValue constructor. Reset allowSpread.

(WebCore::ShadowParseContext::commitLength): Allow spread after blur

for the box-shadow property.

(WebCore::ShadowParseContext::commitColor): Reset allowSpread.
(WebCore::CSSParser::parseShadow): Pass the property ID to

ShadowParseContext().

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Get the spread value from

the shadow value and pass it to the ShadowData constructor.

css/ShadowValue.cpp: (WebCore::ShadowValue::ShadowValue): Added spread. (WebCore::ShadowValue::cssText): Added spread.

css/ShadowValue.h: (WebCore::ShadowValue::create): Added spread.

page/animation/AnimationBase.cpp: (WebCore::blendFunc): Blend the spread value. (WebCore::PropertyWrapperShadow::blend): Added 0 spread to the default

shadow.

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Account for spread in

the visual overflow calculations.

(WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
(WebCore::InlineFlowBox::paint): Ditto.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): Ditto. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Ditto.

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Inflate the shadow-

casting rect by the shadow spread value. Adjust border radii if
necessary.

rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Account for spread in the

visual overflow calculations.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Ditto.

rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Account for spread. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Ditto.

rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.

rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): Assert that text shadows do not

have spread.

rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): Added spread. (WebCore::ShadowData::operator==): Compare spread.
rendering/style/ShadowData.h: (WebCore::ShadowData::ShadowData): Added spread.

LayoutTests:

Reviewed by Anders Carlsson.

Test box-shadow spread radius
https://bugs.webkit.org/show_bug.cgi?id=27417

fast/box-shadow/spread.html: Added.
platform/mac/fast/box-shadow/spread-expected.checksum: Added.
platform/mac/fast/box-shadow/spread-expected.png: Added.
platform/mac/fast/box-shadow/spread-expected.txt: Added.

3:53 PM Changeset in webkit [46096] by jmalonzo@webkit.org

4 edits in trunk

2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>

https://bugs.webkit.org/show_bug.cgi?id=27145
[Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615

Reviewed by Gustavo Noronha.

platform/gtk/Skipped:

Normalize file URLs.

DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpHistoryItem):

11:50 AM Changeset in webkit [46095] by pkasting@chromium.org

3 edits in trunk/WebKitTools

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Further improve non-Cygwin SVN support.

Scripts/prepare-ChangeLog: Harmless change to be consistent with other places that consume whitespace at the end of svn output.
Scripts/resolve-ChangeLogs: Add support for SVN 1.6. Slightly optimize svn info parsing based on technique in svn-create-patch. Normalize paths and consume whitespace in the same way as prepare-ChangeLog, for Windows systems with a non-Cygwin SVN. Force diff and patch to run in binary mode so that they won't "intelligently" screw up line endings.

10:48 AM Changeset in webkit [46094] by abarth@webkit.org

2 edits in trunk/WebCore

2009-07-18 Adam Barth <abarth@webkit.org>

Reviewed by Jan Alonzo.

Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406

No behavior change.

loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):

10:47 AM Changeset in webkit [46093] by Simon Fraser

2 edits in trunk/WebKitTools

2009-07-18 Simon Fraser <Simon Fraser>

Fix Tiger DRT build.

DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow):
DumpRenderTree/mac/PixelDumpSupportMac.mm:

9:59 AM Changeset in webkit [46092] by Simon Fraser

2 edits in trunk/WebKitTools

2009-07-17 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

DRT doesn't reliably snapshot composited layers
https://bugs.webkit.org/show_bug.cgi?id=27399

If we're doing an "onscreen" pixel capture, it means that we're snapshotting a view
with composited content. In that case we need to force the view to display so that
the composited layers are rendered to the screen.

DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):

8:02 AM Changeset in webkit [46091] by abarth@webkit.org

6 edits in trunk/WebCore

2009-07-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

[V8] Move event listener methods from V8Proxy to V8EventListenerList
https://bugs.webkit.org/show_bug.cgi?id=27408

Move some event listener code out of V8Proxy and into the event
listener list.

I'd like to remove these methods from V8Proxy entirely and just expose
getters for the lists themselves, but I'll do that in a follow up
patch.

bindings/v8/V8EventListenerList.cpp: (WebCore::V8EventListenerList::findWrapper):
bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper):
bindings/v8/V8ObjectEventListener.cpp:
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::findV8EventListener): (WebCore::V8Proxy::findOrCreateV8EventListener): (WebCore::V8Proxy::removeV8EventListener): (WebCore::V8Proxy::findObjectEventListener): (WebCore::V8Proxy::findOrCreateObjectEventListener): (WebCore::V8Proxy::removeObjectEventListener):
bindings/v8/V8Proxy.h:

1:45 AM Changeset in webkit [46090] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip tests that require new expected results, eventSender
and editing callbacks DRT support. Unreviewed.

platform/gtk/Skipped:

1:37 AM Changeset in webkit [46089] by abarth@webkit.org

2 edits in trunk/WebCore

Revert 46088.

1:31 AM Changeset in webkit [46088] by abarth@webkit.org

2 edits in trunk/WebCore

2009-07-18 Adam Barth <abarth@webkit.org>

Reviewed by Jan Alonzo.

Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406

No behavior change.

loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):

12:44 AM Changeset in webkit [46087] by jorlow@chromium.org

16 edits
2 deletes in trunk

WebCore:

2009-07-18 Jeremy Orlow <jorlow@chromium.org>

Rubber stamped by Adam Barth.

Revert https://bugs.webkit.org/show_bug.cgi?id=27383
https://bugs.webkit.org/show_bug.cgi?id=27407

Revert Jens' patch. I believe he forgot to include a file.

WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/DOMObjectsInclude.h:
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
bindings/v8/V8DataGridDataSource.cpp: Removed.
bindings/v8/V8DataGridDataSource.h: Removed.
bindings/v8/V8GCController.h:
bindings/v8/V8Index.h:
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-18 Jeremy Orlow <jorlow@chromium.org>

Rubber stamped by Adam Barth.

Revert https://bugs.webkit.org/show_bug.cgi?id=27383
https://bugs.webkit.org/show_bug.cgi?id=27407

Revert Jens' patch. I believe he forgot to include a file.

fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:

Jul 17, 2009:

11:13 PM Changeset in webkit [46086] by abarth@webkit.org

3 edits
4 adds in trunk

2009-07-17 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27405

Tests that HTML entities that contain an invalid entity, such as an
unknown named entity, are properly handled.

http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt: Added.
http/tests/security/xssAuditor/link-onclick-ampersand.html: Added.
http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-ampersand.html: Added.

2009-07-17 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27405

Fixes an issue when decoding HTML entities with an unknown named entity that
caused null-characters to be inserted into the decoded result.

Test: http/tests/security/xssAuditor/link-onclick-ampersand.html

http/tests/security/xssAuditor/javascript-link-ampersand.html

page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities): Added check to conditional so that non-zero entity values are not inserted during decoding process.

10:42 PM Changeset in webkit [46085] by Simon Fraser

2 edits in trunk/WebKitSite

2009-07-17 Simon Fraser <Simon Fraser>

Fix the font to match the rest of the blog site.

blog-files/3d-transforms/image-flip.html:

10:38 PM Changeset in webkit [46084] by Simon Fraser

1 edit
1 add in trunk/WebKitSite

2009-07-17 Simon Fraser <Simon Fraser>

Move the image flip effect into an iframe to avoid the long
blog page tripping a bug on Leopard.

blog-files/3d-transforms/image-flip.html: Added.

10:32 PM Changeset in webkit [46083] by abarth@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-07-17 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27403
Add test case for https://bugs.webkit.org/show_bug.cgi?id=27394:
properties on a window object should be accessible after the frame
of the window object has navigated to another site.

fast/dom/Window/window-access-after-navigation-expected.txt: Added.
fast/dom/Window/window-access-after-navigation.html: Added.

8:29 PM Changeset in webkit [46082] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-07-17 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

bugzilla-tool does not understand nested SVN repos
https://bugs.webkit.org/show_bug.cgi?id=27404

Determine the root of the working copy by looking at SVN's UUIDs.

Scripts/modules/scm.py:

8:12 PM Changeset in webkit [46081] by jmalonzo@webkit.org

2 edits
1 add in trunk/WebCore

2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>

<http://webkit.org/b/18363> [GTK] Combo boxes cannot be opened pressing space

Reviewed by Holger Freyther.

Add Gtk to platforms that want to open the menulist using the
spacebar.

dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):

7:57 PM Changeset in webkit [46080] by jmalonzo@webkit.org

4 edits in trunk/WebCore

2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25523
[GTK] The text displayed by push buttons is not exposed to assistive technologies

Add new public method text() to RenderButton and use it from
AccessibilityRenderObject::stringValue().

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue):
rendering/RenderButton.cpp: (WebCore::RenderButton::text):
rendering/RenderButton.h:

7:14 PM Changeset in webkit [46079] by jorlow@chromium.org

2 edits in trunk/WebCore

2009-07-17 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Restore proxy retrieval
https://bugs.webkit.org/show_bug.cgi?id=27369

No new tests are needed.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):

7:08 PM Changeset in webkit [46078] by yael.aharon@nokia.com

2 edits in trunk/WebCore

2009-07-17 Yael Aharon <yael.aharon@nokia.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=27351
Added platform "Symbian" to WEBCORE_NAVIGATOR_PLATFORM
Use uname to find the correct platform for Linux.

page/NavigatorBase.cpp:

6:42 PM Changeset in webkit [46077] by jorlow@chromium.org

16 edits
2 adds in trunk

WebCore:

2009-07-17 Jens Alfke <snej@chromium.org>

Reviewed by Dimitri Glazkov.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

WebCore.gypi: Added new source files.
bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates. (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::V8DataGridDataSource): (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::create): (WebCore::V8DataGridDataSource::isJSDataGridDataSource): (WebCore::V8DataGridDataSource::jsDataSource): (WebCore::asV8DataGridDataSource):
bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
bindings/v8/V8Index.h: Conditionalize datagrid stuff.
bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-17 Jens Alfke <snej@chromium.org>

Reviewed by Dimitri Glazkov.

Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:

6:36 PM Changeset in webkit [46076] by levin@chromium.org

2 edits in trunk/WebKitTools

2009-07-17 David Levin <levin@chromium.org>

Reviewed by Mark Rowe.

webkit-tools-completion.sh has two typos and sorting issues.
https://bugs.webkit.org/show_bug.cgi?id=27401

Scripts/webkit-tools-completion.sh: Fix two typos "--dif" and "-clean". Also, sort all lists including items in the case statement and flags for the commands.

6:26 PM Changeset in webkit [46075] by jorlow@chromium.org

13 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

StorageArea should only contain methods we intend to proxy.
https://bugs.webkit.org/show_bug.cgi?id=27181

Right now, StorageAreaSync takes in a StorageArea* and calls methods
like importItem. Really, StorageAreaSync should be operating directly
on StorageAreaImpl* and those methods should be removed from StorageArea
since StorageAreaSync should never be attached to anything other than a
StorageAreaImpl.

This was pointed out in the review for
https://bugs.webkit.org/show_bug.cgi?id=27072

Also clean up StorageNamespaceImpl to operate directly on
StorageAreaImpl. Also, get rid of the factory for StorageArea
since nothing should ever create a StorageArea directly.

GNUmakefile.am:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
storage/StorageArea.cpp: Removed.
storage/StorageArea.h: (WebCore::StorageArea::~StorageArea):
storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::copy):
storage/StorageAreaImpl.h:
storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
storage/StorageAreaSync.h:
storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea):
storage/StorageNamespaceImpl.h:

6:22 PM Changeset in webkit [46074] by jorlow@chromium.org

2 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Add v8 implementation for DOM Storage ScriptObjectQuarantine.
https://bugs.webkit.org/show_bug.cgi?id=27327

Wrap the storage object with a generic object as is done elsewhere in
the file (but continue to hit a NOTIMPLEMENTED if DOM_STORAGE is not
enabled.

bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):

5:12 PM Changeset in webkit [46073] by eroman@chromium.org

2 edits in trunk/WebCore

2009-07-17 Mads Ager <ager@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=27394
Fix access to global object wrappers after navigation of their
frame in the V8 bindings. This fixes selenium test failures.

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocument):

4:54 PM Changeset in webkit [46072] by mrowe@apple.com

2 edits in trunk/WebCore

Fix the 32-bit build by removing implicit float <-> double conversions.

inspector/InspectorController.cpp:

(WebCore::constrainedAttachedWindowHeight):

4:27 PM Changeset in webkit [46071] by bweinstein@apple.com

7 edits in trunk

2009-07-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272

Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight
to set window sizes and redraw the inspector and the inspected web view, and used stored preferences
in InspectorController.cpp to remember user's preferred height.

WebCoreSupport/WebInspectorClient.cpp:

2009-07-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272

Moved preference setting for attached inspector height and inspector height calculation from
WebInspectorClient.mm into InspectorController.cpp, to make this code cross-platform and enable
Windows resizing of attached inspector.

inspector/InspectorController.cpp:
inspector/InspectorController.h:

2009-07-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272

Removed size calculation code from [WebInspectorWindowController setInitialAttachedHeight] into
InspectorController.cpp to make it cross platform, and use InspectorController to store the
user's preferred size for an attached window, instead of NSUserDefaults.

WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController setAttachedWindowHeight:]):

4:25 PM Changeset in webkit [46070] by mitz@apple.com

2 edits in trunk/WebCore

Another attempt at fixing the build after r46063

WebCore.xcodeproj/project.pbxproj: Made ExceptionCode.h a private

header, because it is now included from htmlediting.h, which is
a private header.

4:22 PM Changeset in webkit [46069] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27396
Moving cursor in Thai text sometimes jumps over two characters

Test: editing/text-iterator/thai-cursor-movement.html

platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added a special case for five Thai characters, matching ICU/CLDR changes.

4:13 PM Changeset in webkit [46068] by eric@webkit.org

19 edits
3 adds in trunk

2009-07-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Some constructor objects exposed on Window have the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27276

fast/dom/prototype-inheritance-expected.txt: Added.
fast/dom/prototype-inheritance.html: Added.
fast/dom/resources/prototype-inheritance.js: Added.

2009-07-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Some constructor objects exposed on Window have the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27276

Several Constructor classes were already being passed a global object
during construction, but they were ignoring it for prototype lookup.
I've fixed those to use the passed global object instead.

Most of these Constructor classes should just be auto-generated, but I
refrained from changing them over to auto-gen in this patch.

Fixed CodeGeneratorJS to pass a global object to getDOMConstructor when
available, otherwise default to deprecatedGlobalObjectForPrototype(exec)
to match existing behavior.

Test: fast/dom/prototype-inheritance.html

bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): use the existing globalObject pointer for prototype lookup
bindings/js/JSDOMBinding.h: (WebCore::deprecatedGlobalObjectForPrototype): Make it easy to detect where the wrong global object is being used. (WebCore::deprecatedGetDOMStructure):
bindings/js/JSDOMGlobalObject.h: remove error-prone getDOMConstructor, require passing JSDOMGlobalObject*
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webKitPoint): pass "this" for the global object. (WebCore::JSDOMWindow::webKitCSSMatrix): pass "this" for the global object. (WebCore::JSDOMWindow::xsltProcessor): pass "this" for the global object. (WebCore::JSDOMWindow::worker): pass "this" for the global object.
bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor): use the existing globalObject pointer for prototype lookup
bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): use the existing globalObject pointer for prototype lookup
bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor): use the existing globalObject pointer for prototype lookup
bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor): add new globalObject parameter and use it
bindings/js/JSWebKitCSSMatrixConstructor.h:
bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor): add new globalObject parameter and use it
bindings/js/JSWebKitPointConstructor.h:
bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor): add new globalObject parameter and use it
bindings/js/JSWorkerConstructor.h:
bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): use the existing globalObject pointer for prototype lookup -- XMLHttpRequest constructor was also missing a length. Added one.
bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
bindings/js/JSXSLTProcessorConstructor.h:
bindings/scripts/CodeGeneratorJS.pm:

4:11 PM Changeset in webkit [46067] by mitz@apple.com

2 edits in trunk/WebCore

Build fix

editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):

4:04 PM WebKit Team edited by jparent@chromium.org

(diff)

4:03 PM Changeset in webkit [46066] by ggaren@apple.com

14 edits in branches/nitro-extreme/JavaScriptCore

2009-07-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Get the branch working on windows.
https://bugs.webkit.org/show_bug.cgi?id=27391

SunSpider says 0.3% faster.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Updated MSVC export lists to fix linker errors.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added / removed new / old project files.

jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Used #pragma pack to tell MSVC that these structures represent actual memory layout, and should not be automatically aligned. Changed the return value load to load a 64bit quantity into the canonical registers.

jit/JIT.h: Moved OBJECT_OFFSETOF definition to StdLibExtras.h because it's needed by more than just the JIT, and it supplements a standard library macro (offsetof).

jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): Fixed an incorrectly signed cast to resolve an MSVC warning.

jit/JITStubs.h: Used #pragma pack to tell MSVC that these structures represent actual memory layout, and should not be automatically aligned.

runtime/JSArray.cpp: (JSC::JSArray::JSArray): Replaced memset_pattern8 with a for loop, since memset_pattern8 is not portable. (I verified that this version of the loop gives the best performance / generated code in GCC.)

runtime/JSObject.h: (JSC::JSObject::JSObject): Removed accidental usage of FIELD_OFFSET -- OBJECT_OFFSETOF is our new macro name. (FIELD_OFFSET conflicts with a definition in winnt.h.)

runtime/JSValue.cpp: Added some headers needed by non-all-in-one builds.

runtime/JSValue.h: (JSC::JSValue::): Made the tag signed, to match MSVC's signed enum values. (GCC doesn't seem to care one way or the other.)

wtf/MainThread.cpp: Moved the StdLibExtras.h #include -- I did this a while ago to resolve a conflict with winnt.h. I can't remember if it's truly still needed, but what the heck.

wtf/StdLibExtras.h: Moved OBJECT_OFFSETOF definition here.

4:02 PM Changeset in webkit [46065] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix for symbol lookup error.

Move AbstractWorker from SHARED_WORKERS to WORKERS as Worker derives from it now
Changed in http://trac.webkit.org/changeset/46048

GNUmakefile.am:

4:01 PM Changeset in webkit [46064] by pkasting@chromium.org

3 edits in trunk/WebKitTools

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Tweak some regexes for correctness.

Scripts/prepare-ChangeLog: Allow 1-character filenames (my previous change here didn't quite get things right).
Scripts/update-webkit: Detect conflicting ChangeLogs correctly by not including any trailing whitespace in the name "ChangeLog", and by normalizing paths before calling basename() to avoid confusing it. (normalizePath() copied from prepare-ChangeLog.)

3:58 PM Changeset in webkit [46063] by jparent@chromium.org

5 edits in trunk/WebCore

2009-07-17 Ryosuke Niwa <ryosuke.niwa@gmail.com>

Reviewed by Eric Seidel.

htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

In order to fix the bug 26816, we need several utility functions be added to htmlediting.cpp

No tests because functions haven't been used anywhere yet.

dom/Range.cpp: (WebCore::Range::create): (WebCore::Range::comparePoint): added const qualifier (WebCore::Range::compareNode): added const qualifier
dom/Range.h:
editing/htmlediting.cpp: (WebCore::unsplittableElementForPosition): find the enclosing unsplittable element (editing root & table cell) (WebCore::positionBeforeNode): added ASSERT(node) (WebCore::positionAfterNode): added ASSERT(node) (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode): (WebCore::createRange): create a range object from two visible positions (WebCore::extendRangeToWrappingNodes): extend range to include nodes that starts and ends at the boundaries (WebCore::canMergeLists): typo (WebCore::indexForVisiblePosition): added const qualifier (WebCore::isVisiblyAdjacent): typo (WebCore::isNodeVisiblyContainedWithin): determine if a node is inside a range or within the visible boundaries of the range
editing/htmlediting.h:

3:53 PM WebKit Team edited by darin@chromium.org

(diff)

3:37 PM Changeset in webkit [46062] by pkasting@chromium.org

18 edits
34 adds in trunk

LayoutTests:

2009-07-17 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25551
Test suite for the required attribute, the valueMissing flag and new
:required and :optional CSS pseudoclasses.
Part of the HTML5 sec. Forms.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required

fast/css/pseudo-required-optional-001-expected.txt: Added.
fast/css/pseudo-required-optional-001.html: Added.
fast/css/pseudo-required-optional-002-expected.txt: Added.
fast/css/pseudo-required-optional-002.html: Added.
fast/css/pseudo-required-optional-003-expected.txt: Added.
fast/css/pseudo-required-optional-003.html: Added.
fast/css/pseudo-required-optional-004-expected.txt: Added.
fast/css/pseudo-required-optional-004.html: Added.
fast/css/pseudo-required-optional-005-expected.txt: Added.
fast/css/pseudo-required-optional-005.html: Added.
fast/css/pseudo-required-optional-006-expected.txt: Added.
fast/css/pseudo-required-optional-006.html: Added.
fast/forms/ValidityState-valueMissing-001-expected.txt: Added.
fast/forms/ValidityState-valueMissing-001.html: Added.
fast/forms/ValidityState-valueMissing-002-expected.txt: Added.
fast/forms/ValidityState-valueMissing-002.html: Added.
fast/forms/ValidityState-valueMissing-003-expected.txt: Added.
fast/forms/ValidityState-valueMissing-003.html: Added.
fast/forms/ValidityState-valueMissing-004-expected.txt: Added.
fast/forms/ValidityState-valueMissing-004.html: Added.
fast/forms/ValidityState-valueMissing-005-expected.txt: Added.
fast/forms/ValidityState-valueMissing-005.html: Added.
fast/forms/ValidityState-valueMissing-006-expected.txt: Added.
fast/forms/ValidityState-valueMissing-006.html: Added.
fast/forms/ValidityState-valueMissing-007-expected.txt: Added.
fast/forms/ValidityState-valueMissing-007.html: Added.
fast/forms/ValidityState-valueMissing-008-expected.txt: Added.
fast/forms/ValidityState-valueMissing-008.html: Added.
fast/forms/ValidityState-valueMissing-009-expected.txt: Added.
fast/forms/ValidityState-valueMissing-009.html: Added.
fast/forms/required-attribute-001-expected.txt: Added.
fast/forms/required-attribute-001.html: Added.
fast/forms/required-attribute-002-expected.txt: Added.
fast/forms/required-attribute-002.html: Added.

WebCore:

2009-07-17 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25551
Added support for the "required" attribute, the valueMissing flag
to the ValidityState object and :required/:optional CSS pseudoclasses.
Part of HTML5 sec. Forms specs.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required

Tests: fast/css/pseudo-required-optional-001.html

fast/css/pseudo-required-optional-002.html
fast/css/pseudo-required-optional-003.html
fast/css/pseudo-required-optional-004.html
fast/css/pseudo-required-optional-005.html
fast/css/pseudo-required-optional-006.html
fast/forms/ValidityState-valueMissing-001.html
fast/forms/ValidityState-valueMissing-002.html
fast/forms/ValidityState-valueMissing-003.html
fast/forms/ValidityState-valueMissing-004.html
fast/forms/ValidityState-valueMissing-005.html
fast/forms/ValidityState-valueMissing-006.html
fast/forms/ValidityState-valueMissing-007.html
fast/forms/ValidityState-valueMissing-008.html
fast/forms/ValidityState-valueMissing-009.html
fast/forms/required-attribute-001.html
fast/forms/required-attribute-002.html

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): pseudoRequired/pseudoOptional
css/CSSSelector.h: (WebCore::CSSSelector::): ditto
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto
dom/Element.h: (WebCore::Element::isOptionalFormControl): check for optional controls (WebCore::Element::isRequiredFormControl): check for required controls
html/HTMLAttributeNames.in: required attribute
html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::isOptionalFormControl): ditto
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::required): requiredAttr getter (WebCore::HTMLFormControlElement::setRequired): requiredAttr setter
html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::valueMissing): method definition
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): validation code (WebCore::HTMLInputElement::isRequiredFormControl): ditto
html/HTMLInputElement.h: (WebCore::HTMLInputElement::isOptionalFormControl): ditto
html/HTMLInputElement.idl: required DOM attribute
html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): ditto
html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::valueMissing): validation code (WebCore::HTMLTextAreaElement::isOptionalFormControl): ditto (WebCore::HTMLTextAreaElement::isRequiredFormControl): ditto
html/HTMLTextAreaElement.idl: required DOM attribute
html/ValidityState.cpp:
html/ValidityState.h: (WebCore::ValidityState::valueMissing): validation flag

3:30 PM Changeset in webkit [46061] by Beth Dakin

3 edits in trunk/WebCore

2009-07-17 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=27390 CSS custom
cursor hotspots should work in quirks mode

and corresponding <rdar://problem/6554340>

Enable hotspots in quirks mode.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue):

Update this manual test to reflect the fact that hotspots are now
expected to work in quirks mode.

manual-tests/css3-cursor-fallback-quirks.html:

3:11 PM WikiStart edited by atwilson@chromium.org

Added link to IdlAttributes wiki page. (diff)

3:09 PM IdlAttributes edited by atwilson@chromium.org

(diff)

3:02 PM Changeset in webkit [46060] by pkasting@chromium.org

19 edits in trunk

JavaScriptCore:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:

WebCore:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

WebCore.vcproj/QTMovieWin.vcproj:
WebCore.vcproj/WebCoreCommon.vsprops:
WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

WebKit.vcproj/Interfaces.vcproj:
WebKit.vcproj/InterfacesGenerated.vcproj:
WebKit.vcproj/WebKit.vcproj:
WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools:

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by Steve Falkenburg.

https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/win/ImageDiff.vcproj:
DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

3:01 PM WebKit Team edited by Nate Chapin

(diff)

2:56 PM Changeset in webkit [46059] by barraclough@apple.com

9 edits
3 adds in trunk/JavaScriptCore

2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Add YARR support for generic ARM platforms (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=24986

Add generic ARM port for MacroAssembler. It supports the whole
MacroAssembler functionality except floating point.

The class JmpSrc is extended with a flag which enables to patch
the jump destination offset during execution. This feature is
required for generic ARM port.

Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>

JavaScriptCore.pri:
assembler/ARMAssembler.cpp: Added. (JSC::ARMAssembler::getLdrImmAddress): (JSC::ARMAssembler::linkBranch): (JSC::ARMAssembler::patchConstantPoolLoad): (JSC::ARMAssembler::getOp2): (JSC::ARMAssembler::genInt): (JSC::ARMAssembler::getImm): (JSC::ARMAssembler::moveImm): (JSC::ARMAssembler::dataTransfer32): (JSC::ARMAssembler::baseIndexTransfer32): (JSC::ARMAssembler::executableCopy):
assembler/ARMAssembler.h: Added. (JSC::ARM::): (JSC::ARMAssembler::ARMAssembler): (JSC::ARMAssembler::): (JSC::ARMAssembler::JmpSrc::JmpSrc): (JSC::ARMAssembler::JmpSrc::enableLatePatch): (JSC::ARMAssembler::JmpDst::JmpDst): (JSC::ARMAssembler::JmpDst::isUsed): (JSC::ARMAssembler::JmpDst::used): (JSC::ARMAssembler::emitInst): (JSC::ARMAssembler::and_r): (JSC::ARMAssembler::ands_r): (JSC::ARMAssembler::eor_r): (JSC::ARMAssembler::eors_r): (JSC::ARMAssembler::sub_r): (JSC::ARMAssembler::subs_r): (JSC::ARMAssembler::rsb_r): (JSC::ARMAssembler::rsbs_r): (JSC::ARMAssembler::add_r): (JSC::ARMAssembler::adds_r): (JSC::ARMAssembler::adc_r): (JSC::ARMAssembler::adcs_r): (JSC::ARMAssembler::sbc_r): (JSC::ARMAssembler::sbcs_r): (JSC::ARMAssembler::rsc_r): (JSC::ARMAssembler::rscs_r): (JSC::ARMAssembler::tst_r): (JSC::ARMAssembler::teq_r): (JSC::ARMAssembler::cmp_r): (JSC::ARMAssembler::orr_r): (JSC::ARMAssembler::orrs_r): (JSC::ARMAssembler::mov_r): (JSC::ARMAssembler::movs_r): (JSC::ARMAssembler::bic_r): (JSC::ARMAssembler::bics_r): (JSC::ARMAssembler::mvn_r): (JSC::ARMAssembler::mvns_r): (JSC::ARMAssembler::mul_r): (JSC::ARMAssembler::muls_r): (JSC::ARMAssembler::mull_r): (JSC::ARMAssembler::ldr_imm): (JSC::ARMAssembler::ldr_un_imm): (JSC::ARMAssembler::dtr_u): (JSC::ARMAssembler::dtr_ur): (JSC::ARMAssembler::dtr_d): (JSC::ARMAssembler::dtr_dr): (JSC::ARMAssembler::ldrh_r): (JSC::ARMAssembler::ldrh_d): (JSC::ARMAssembler::ldrh_u): (JSC::ARMAssembler::strh_r): (JSC::ARMAssembler::push_r): (JSC::ARMAssembler::pop_r): (JSC::ARMAssembler::poke_r): (JSC::ARMAssembler::peek_r): (JSC::ARMAssembler::clz_r): (JSC::ARMAssembler::bkpt): (JSC::ARMAssembler::lsl): (JSC::ARMAssembler::lsr): (JSC::ARMAssembler::asr): (JSC::ARMAssembler::lsl_r): (JSC::ARMAssembler::lsr_r): (JSC::ARMAssembler::asr_r): (JSC::ARMAssembler::size): (JSC::ARMAssembler::ensureSpace): (JSC::ARMAssembler::label): (JSC::ARMAssembler::align): (JSC::ARMAssembler::jmp): (JSC::ARMAssembler::patchPointerInternal): (JSC::ARMAssembler::patchConstantPoolLoad): (JSC::ARMAssembler::patchPointer): (JSC::ARMAssembler::repatchInt32): (JSC::ARMAssembler::repatchPointer): (JSC::ARMAssembler::repatchLoadPtrToLEA): (JSC::ARMAssembler::linkJump): (JSC::ARMAssembler::relinkJump): (JSC::ARMAssembler::linkCall): (JSC::ARMAssembler::relinkCall): (JSC::ARMAssembler::getRelocatedAddress): (JSC::ARMAssembler::getDifferenceBetweenLabels): (JSC::ARMAssembler::getCallReturnOffset): (JSC::ARMAssembler::getOp2Byte): (JSC::ARMAssembler::placeConstantPoolBarrier): (JSC::ARMAssembler::RM): (JSC::ARMAssembler::RS): (JSC::ARMAssembler::RD): (JSC::ARMAssembler::RN): (JSC::ARMAssembler::getConditionalField):
assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::JmpSrc::enableLatePatch):
assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Call::enableLatePatch): (JSC::AbstractMacroAssembler::Jump::enableLatePatch):
assembler/MacroAssembler.h:
assembler/MacroAssemblerARM.h: Added. (JSC::MacroAssemblerARM::): (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::and32): (JSC::MacroAssemblerARM::lshift32): (JSC::MacroAssemblerARM::mul32): (JSC::MacroAssemblerARM::not32): (JSC::MacroAssemblerARM::or32): (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::xor32): (JSC::MacroAssemblerARM::load32): (JSC::MacroAssemblerARM::load32WithAddressOffsetPatch): (JSC::MacroAssemblerARM::loadPtrWithPatchToLEA): (JSC::MacroAssemblerARM::load16): (JSC::MacroAssemblerARM::store32WithAddressOffsetPatch): (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::pop): (JSC::MacroAssemblerARM::push): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::swap): (JSC::MacroAssemblerARM::signExtend32ToPtr): (JSC::MacroAssemblerARM::zeroExtend32ToPtr): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::branch16): (JSC::MacroAssemblerARM::branchTest32): (JSC::MacroAssemblerARM::jump): (JSC::MacroAssemblerARM::branchAdd32): (JSC::MacroAssemblerARM::mull32): (JSC::MacroAssemblerARM::branchMul32): (JSC::MacroAssemblerARM::branchSub32): (JSC::MacroAssemblerARM::breakpoint): (JSC::MacroAssemblerARM::nearCall): (JSC::MacroAssemblerARM::call): (JSC::MacroAssemblerARM::ret): (JSC::MacroAssemblerARM::set32): (JSC::MacroAssemblerARM::setTest32): (JSC::MacroAssemblerARM::tailRecursiveCall): (JSC::MacroAssemblerARM::makeTailRecursiveCall): (JSC::MacroAssemblerARM::moveWithPatch): (JSC::MacroAssemblerARM::branchPtrWithPatch): (JSC::MacroAssemblerARM::storePtrWithPatch): (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::supportsFloatingPointTruncate): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::storeDouble): (JSC::MacroAssemblerARM::addDouble): (JSC::MacroAssemblerARM::subDouble): (JSC::MacroAssemblerARM::mulDouble): (JSC::MacroAssemblerARM::convertInt32ToDouble): (JSC::MacroAssemblerARM::branchDouble): (JSC::MacroAssemblerARM::branchTruncateDoubleToInt32): (JSC::MacroAssemblerARM::ARMCondition): (JSC::MacroAssemblerARM::prepareCall): (JSC::MacroAssemblerARM::call32):
assembler/X86Assembler.h: (JSC::X86Assembler::JmpSrc::enableLatePatch):
jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
wtf/Platform.h:
yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):

2:51 PM WebKit Team edited by agl@chromium.org

(diff)

2:29 PM Changeset in webkit [46058] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=27384
Random crashes in appcache/update-cache.html test

loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): Reorder code to avoid using a handle after canceling it.

2:28 PM WebKit Team edited by jorlow@chromium.org

(diff)

2:17 PM Changeset in webkit [46057] by barraclough@apple.com

3 edits
1 add in trunk/JavaScriptCore

2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Extend AssemblerBuffer with constant pool handling mechanism.
https://bugs.webkit.org/show_bug.cgi?id=24986

Add a platform independed constant pool framework.
This pool can store 32 or 64 bits values which is enough to hold
any integer, pointer or double constant.

assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::putIntUnchecked): (JSC::AssemblerBuffer::putInt64Unchecked): (JSC::AssemblerBuffer::append): (JSC::AssemblerBuffer::grow):
assembler/AssemblerBufferWithConstantPool.h: Added. (JSC::):

2:17 PM Changeset in webkit [46056] by jmalonzo@webkit.org

2 edits in trunk/WebCore

Revert "2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>"

This reverts commit http://trac.webkit.org/changeset/46038 as it breaks two
accessibility/ tests in the mac builds.

2:16 PM Changeset in webkit [46055] by levin@chromium.org

1 edit
1 add in trunk/WebKitTools

2009-07-17 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

WebKit should have a bash completion script to aid with common commands.
https://bugs.webkit.org/show_bug.cgi?id=27374

Scripts/webkit-tools-completion.sh: The script which enables option completion for several WebKit command line scripts.

1:17 PM IdlAttributes created by atwilson@chromium.org

1:17 PM Changeset in webkit [46054] by pkasting@chromium.org

2 edits in trunk/WebKitTools

2009-07-17 Peter Kasting <pkasting@google.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=27323
Avoid error spew on Macs, and fix a few other tiny details.

Scripts/svn-create-patch:

1:13 PM Changeset in webkit [46053] by treat@webkit.org

3 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=27377
This makes cpplint complain about this for instance:

if (true)
{

int foo;

}

Add the appropriate unit tests.

Scripts/modules/cpplint.py:
Scripts/modules/cpplint_unittest.py:

1:08 PM Changeset in webkit [46052] by treat@webkit.org

2 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=27377
Don't filter whitespace at the end of the line. This is not
explicitly a rule of webkit coding style, but there is no reason
not to warn of this common style problem.

Don't filter whitespace newline. Now, cpplint will complain
about the following situation:

if (true) {

doSomething();
doSomethingAgain();

}
else

doSomething();

Which is a webkit coding style rule violation.

Scripts/modules/cpplint.py:

1:05 PM Changeset in webkit [46051] by treat@webkit.org

2 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=27377
Move this comment to where it belongs.

Scripts/modules/cpplint_unittest.py:

12:37 PM Changeset in webkit [46050] by bfulgham@webkit.org

2 edits in trunk/WebKitTools

2009-07-17 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Correct crash in WinLauncher due to improper mixing of BSTR
and TCHAR types.
https://bugs.webkit.org/show_bug.cgi?id=27381

WinLauncher/WinLauncher.cpp: (loadURL): Perform SysReAllocString to update the BSTR with the contents of the TCHAR string.

12:27 PM Changeset in webkit [46049] by eroman@chromium.org

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Build fix for non-Darwin.
Add a guard for inclusion of RetainPtr.h which includes CoreFoundation.h

https://bugs.webkit.org/show_bug.cgi?id=27382

wtf/unicode/icu/CollatorICU.cpp:

12:11 PM Changeset in webkit [46048] by levin@chromium.org

19 edits in trunk

WebCore:

2009-07-17 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Changed Worker to derive from AbstractWorker, which involved moving
AbstractWorker files from being wrapped by ENABLE_SHARED_WORKERS to
ENABLE_WORKERS.

Removed obsolete functionality from the JS/V8 bindings that is now
inherited from AbstractWorker.

WebCore.pro: Moved AbstractWorker files out of SHARED_WORKERS section and into WORKERS.
bindings/js/JSAbstractWorkerCustom.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
bindings/js/JSWorkerCustom.cpp: Removed obsolete event listener code (now in base class) (WebCore::JSWorker::mark): No longer need to explicitly mark event listeners (handled by base class).
bindings/v8/V8Index.h: Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
bindings/v8/custom/V8AbstractWorkerCustom.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
bindings/v8/custom/V8CustomBinding.h: Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
bindings/v8/custom/V8WorkerCustom.cpp: Removed obsolete event listener code that now lives in the base class. (WebCore::V8WorkerConstructor): Cleaned up legacy style nits.
workers/AbstractWorker.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
workers/AbstractWorker.h: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
workers/Worker.cpp: Removed event listener code (now in base class). (WebCore::Worker::Worker): Now derives from AbstractWorker. (WebCore::Worker::notifyFinished): Calls dispatchLoadErrorEvent on base class.
workers/Worker.h: Removed APIs that now live in the base class.
workers/Worker.idl: Now derives from AbstractWorker. Removed APIs that live in the base class, and added a GenerateToJS flag.

LayoutTests:

2009-07-17 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Added checks to make sure that Workers are properly constructed and Worker attributes
are visible on the resulting object.

fast/workers/worker-constructor-expected.txt:
fast/workers/worker-constructor.html: Added explicit check for correct construction/postMessage visibility.

12:11 PM Changeset in webkit [46047] by levin@chromium.org

3 edits in trunk/WebKitTools

2009-07-17 David Levin <levin@chromium.org>

Reviewed by Adam Treat.

cpplint should flag usages of NULL.
https://bugs.webkit.org/show_bug.cgi?id=27341

Scripts/modules/cpplint.py: Add the check for NULL test and call it. Make the collapse_strings method public.
Scripts/modules/cpplint_unittest.py: Add several tests to verify the check for NULL behavior. Adjust existing tests due to the new NULL check:
1. Several had NULL removed (or were just removed completely).
2. Two tests now do an assert that allows the caller to check that a particular error is one of several that was returned.

12:11 PM Changeset in webkit [46046] by levin@chromium.org

1 edit
2 adds in trunk/WebKitTools

2009-07-17 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

Add a parser of patches for linter.
https://bugs.webkit.org/show_bug.cgi?id=27363

Adds a simple parser for unified diff format.

Scripts/modules/diff_parser.py: Added.
Scripts/modules/diff_parser_unittest.py: Added.

11:41 AM Changeset in webkit [46045] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

11:36 AM Changeset in webkit [46044] by hyatt@apple.com

4 edits
4 adds in trunk

WebCore:

2009-07-17 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27379
Absolutely-positioned elements with a scrollbar wrap prematurely. Make sure to include
the vertical scrollbar width for overflow:scroll elements.

Added fast/css/positioned-overflow-scroll.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcPrefWidths):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcPrefWidths):

LayoutTests:

2009-07-17 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=27379
Absolutely-positioned elements with a scrollbar wrap prematurely. Make sure to include
the vertical scrollbar width for overflow:scroll elements.

fast/css/positioned-overflow-scroll.html: Added.
platform/mac/fast/css/positioned-overflow-scroll-expected.checksum: Added.
platform/mac/fast/css/positioned-overflow-scroll-expected.png: Added.
platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Added.

11:32 AM Changeset in webkit [46043] by mrowe@apple.com

1 copy in tags/Safari-6531.6

New tag.

11:21 AM Changeset in webkit [46042] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

Get user default collation order via a CFLocale API when available.

wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):

11:01 AM Changeset in webkit [46041] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Need a DOM_STORAGE guard in DerivedSroucesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=27375

In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp
and StorageEvent.cpp. Unfortunately, until later this afternoon,
DOM_STORAGE is not turned on by default in Chromium, and so these two
files are never generated. This breaks the compile.

There are no other instances of guards in the file, which puzzles me...
but I think adding guards is the right way to go about this.

bindings/v8/DerivedSourcesAllInOne.cpp: Added the guard.

11:00 AM Changeset in webkit [46040] by treat@webkit.org

8 edits in trunk/WebKit/qt

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Adam Treat.

Coding style fixes.

Api/qcookiejar.cpp: (QCookieJarPrivate::QCookieJarPrivate): (qHash): (QCookieJar::cookieJar):
Api/qwebelement.cpp: (QWebElement::functions): (QWebElement::scriptableProperties):
Api/qwebframe.cpp: (QWebFrame::metaData): (QWebFrame::scrollBarValue): (QWebFrame::scroll): (QWebFrame::scrollPosition): (QWebFrame::print):
Api/qwebnetworkinterface.cpp: (decodePercentEncoding): (QWebNetworkRequestPrivate::init): (QWebNetworkRequestPrivate::setURL): (QWebNetworkRequest::QWebNetworkRequest): (QWebNetworkRequest::operator=): (QWebNetworkRequest::setUrl): (QWebNetworkRequest::setHttpHeader): (QWebNetworkRequest::httpHeaderField): (QWebNetworkRequest::setHttpHeaderField): (QWebNetworkRequest::setPostData): (QWebNetworkJob::setResponse): (QWebNetworkJob::frame): (QWebNetworkManager::add): (QWebNetworkManager::cancel): (QWebNetworkManager::started): (QWebNetworkManager::data): (QWebNetworkManager::finished): (QWebNetworkManager::addHttpJob): (QWebNetworkManager::cancelHttpJob): (QWebNetworkManager::httpConnectionClosed): (QWebNetworkInterfacePrivate::sendFileData): (QWebNetworkInterfacePrivate::parseDataUrl): (QWebNetworkManager::doWork): (QWebNetworkInterface::setDefaultInterface): (QWebNetworkInterface::defaultInterface): (QWebNetworkInterface::QWebNetworkInterface): (QWebNetworkInterface::addJob): (QWebNetworkInterface::cancelJob): (WebCoreHttp::WebCoreHttp): (WebCoreHttp::request): (WebCoreHttp::scheduleNextRequest): (WebCoreHttp::getConnection): (WebCoreHttp::onResponseHeaderReceived): (WebCoreHttp::onReadyRead): (WebCoreHttp::onRequestFinished): (WebCoreHttp::onAuthenticationRequired): (WebCoreHttp::onProxyAuthenticationRequired):
Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::shortcutOverrideEvent): (QWebPage::inputMethodQuery): (QWebPage::javaScriptPrompt): (QWebPage::updatePositionDependentActions): (QWebPage::userAgentForUrl): (QWebPagePrivate::_q_onLoadProgressChanged): (QWebPage::totalBytes): (QWebPage::bytesReceived):
Api/qwebsettings.cpp: (QWebSettings::iconForUrl): (QWebSettings::setObjectCacheCapacities):
Api/qwebview.cpp: (QWebView::paintEvent): (QWebView::changeEvent):

10:53 AM Changeset in webkit [46039] by beidson@apple.com

2 edits in trunk/WebCore

2009-07-17 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26496

Let WebCore always enforce the connection-per-host limit itself.

loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):

9:48 AM Changeset in webkit [46038] by kov@webkit.org

2 edits in trunk/WebCore

2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies

Expose 'alt' attribute from images as accessible name.
Expose the 'title' core HTML attribute as accessible description.

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::accessibilityDescription):

9:41 AM Changeset in webkit [46037] by cmarrin@apple.com

2 edits in trunk/WebCore

Some transitions don't work correctly on Leopard
https://bugs.webkit.org/show_bug.cgi?id=27356

We only have code to do component animation using valueFunction.
So on Leopard we always need to do matrix animation in hardware.
This fix ensures that.

This is currently not testable because it appears only in the
hardware animation and we can't yet do pixel tests while
hardware animating.

8:56 AM Changeset in webkit [46036] by zecke@webkit.org

2 edits in trunk/WebKitTools

[GTK+] Make TestNescpaePlugin loadable in mozilla

https://bugs.webkit.org/show_bug.cgi?id=27345

Currently the NPNetscapeFuncs of WebKit contains two more
entries than the gecko version. This means comparing the
aMozillaVTable->size with the size of NPNetscpaeFuncs will
fail and the plugin will not be loaded.

For testing it is nice to be able to load the plugin into
gecko and currently we are not using the two extra methods.
Remove the test to be able to use the plugin in gecko.

7:48 AM Changeset in webkit [46035] by zecke@webkit.org

2 edits in trunk/WebCore

2009-07-17 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by NOBODY (OOPS!).

[GTK+] Crash in screenAvailable due a null Widget*

JSDOMWindow::open called screenAvailableRect(0). The other
Screen methods can be called with a null widget as well, fix the
crashing test by checking for null.

In screenRect and screenAvailableRect it is not tried to use
a default screen as the existing implementation didn't try either
in case of not having a toplevel widget.

LayoutTests/fast/frames/crash-removed-iframe.html caused a crash.

platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): New method to get a visual or return zero. (WebCore::screenDepth): Use getVisual. (WebCore::screenDepthPerComponent): Use getVisual. (WebCore::screenIsMonochrome): Use screenDepth which will do the null checking (WebCore::screenRect): Check for !widget. (WebCore::screenAvailableRect): Check for !widget.

7:44 AM Changeset in webkit [46034] by Simon Hausmann

2 edits in trunk/LayoutTests

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Remove tests from Qt Skipped list that are actually working.
https://bugs.webkit.org/show_bug.cgi?id=27316

platform/qt/Skipped:

7:09 AM Changeset in webkit [46033] by treat@webkit.org

2 edits in trunk/WebKitTools

2009-07-17 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Simon Hausmann.

Something about having a single TAB in a style checking tool like this
is equivalent to nails on a chalk board to me...

Scripts/modules/cpplint.py:

6:56 AM Changeset in webkit [46032] by Simon Hausmann

4 edits in trunk

JavaScriptCore:

2009-07-17 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358

JavaScriptCore.pri:

WebCore:

2009-07-17 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358

WebCore.pro:

6:34 AM Changeset in webkit [46031] by Simon Hausmann

1 edit in trunk/WebCore/ChangeLog

Fix a small typo in the changelog

6:32 AM Changeset in webkit [46030] by Simon Hausmann

7 edits in trunk

WebCore:

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Make it possible to set the plugin directories from the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215

plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::installedPlugins): Now optionally takes a populate argument, so we can avoid loading system plugins from the DRT and thus avoid their strerr errors that can make tests fail. (WebCore::PluginDatabase::clear): Make is possible to clear the database. Called from setPluginDirectories.
plugins/PluginDatabase.h: (WebCore::PluginDatabase::setPluginDirectories): Make public

WebKit/qt:

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Overwrite the plugin directories for the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215

Api/qwebpage.cpp: (qt_drt_overwritePluginDirectories): Only set the plugin directories to the ones in the QTWEBKIT_PLUGIN_PATH environment variable.

WebKitTools:

2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Overwrite the plugin directories for the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

5:43 AM Changeset in webkit [46029] by vestbo@webkit.org

2 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

PluginViewMac: Stop the plugin when loading fails

Also, prevent event propagation when in the stopped state

plugins/mac/PluginViewMac.cpp:

5:40 AM Changeset in webkit [46028] by vestbo@webkit.org

4 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

PluginViewMac: Allow query and set of drawing and event models

We now support querying and setting of the drawing and event model,
but we still only support the CoreGraphics drawing model, and the
Carbon event model.

If unsupported drawing or event models are detected we show the
missing-plugin icon.

plugins/PluginView.cpp:
plugins/PluginView.h:
plugins/mac/PluginViewMac.cpp:

5:17 AM Changeset in webkit [46027] by vestbo@webkit.org

2 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Initialize two PluginView members using memset

m_npWindow is used on all platforms, not just for XP_UNIX,
so always initialize it. m_npCgContext on the other hand
is only used for XP_MACOSX.

plugins/PluginView.cpp:

4:46 AM Changeset in webkit [46026] by vestbo@webkit.org

6 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add more debug logging in PluginView

plugins/PluginView.cpp: Add debug for setValue
plugins/gtk/PluginViewGtk.cpp: Add debug for getValue
plugins/mac/PluginViewMac.cpp: Add debug for getValue and more
plugins/qt/PluginViewQt.cpp: Add debug for getValue
plugins/win/PluginViewWin.cpp: Add debug for getValue

4:00 AM Changeset in webkit [46025] by levin@chromium.org

2 edits in trunk/JavaScriptCore

2009-07-17 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by David Levin.

Build fix on platforms don't have MMAP.
https://bugs.webkit.org/show_bug.cgi?id=27365

interpreter/RegisterFile.h: Including stdio.h irrespectively of HAVE(MMAP)

3:52 AM Changeset in webkit [46024] by vestbo@webkit.org

2 edits in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Holger Freyther.

Use same license in PluginDebug.cpp as in the original PluginDebug.h

plugins/PluginDebug.cpp: Use license from PluginDebug.h

3:35 AM Changeset in webkit [46023] by vestbo@webkit.org

7 edits
1 add in trunk/WebCore

2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add more debugging functionality for the WebCore NPAPI layer

GNUmakefile.am: Add PluginDebug.cpp
WebCore.gypi: Add PluginDebug.cpp
WebCore.pro: Add PluginDebug.cpp
WebCore.vcproj/WebCore.vcproj: Add PluginDebug.cpp
WebCoreSources.bkl: Add PluginDebug.cpp
plugins/PluginDebug.h: Move errorStrings to PluginDebug.cpp
plugins/PluginDebug.cpp: New file

12:42 AM Changeset in webkit [46022] by levin@chromium.org

3 edits in trunk/WebCore

2009-07-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by David Levin.

Fix Chromium build with DOM_STORAGE enabled.
https://bugs.webkit.org/show_bug.cgi?id=27360

2 minor changes as noted below:

bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .cpp files.
storage/StorageAreaImpl.cpp: #include "DOMWindow.h"

12:42 AM Changeset in webkit [46021] by levin@chromium.org

15 edits in trunk

2009-07-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
https://bugs.webkit.org/show_bug.cgi?id=27206

Add --enable-web-sockets in configure.ac

configure.ac:

JavaScriptCore:

Add ENABLE_WEB_SOCKETS

Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS

WebCore:

Add ENABLE_WEB_SOCKETS

Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS
GNUmakefile.am: add ENABLE_WEB_SOCKETS
WebCore.vcproj/WebCoreCommon.vsprops: add ENABLE_WEB_SOCKETS
WebCore.vcproj/build-generated-files.sh: add ENABLE_WEB_SOCKETS

WebKit/mac:

Add ENABLE_WEB_SOCKETS

Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS

WebKit/win:

Add ENABLE_WEB_SOCKETS

WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS

WebKitTools:

Add --web-sockets flag.

Scripts/build-webkit: add --web-sockets flag.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed