Timeline
Jul 20, 2009:
- 11:41 PM Changeset in webkit [46156] by
-
- 2 edits in trunk/WebKitTools
Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>.
Bug 27482: svn-apply cannot apply patch generated by Windows SVN
Reviewed by David D. Kilzer.
A regexp in svn-apply was treating everything prior to a \n as part of the
file name. The native Windows SVN client uses \r\n for line endings which
meant that the \r was being included in the file name. This defeated the
special-case logic for ChangeLogs to apply them with an increased fuzz factor,
meaning that the ChangeLog portions of such patches would fail to apply.
Also updated two other regexps that look like they would hit similar problems
with line-endings so that they will correctly handle patches from Windows SVN.
- Scripts/svn-apply:
- 9:35 PM Changeset in webkit [46155] by
-
- 3 edits in trunk/JavaScriptCore
Build fix attempt #2
- 9:22 PM Changeset in webkit [46154] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix attempt #1
- 9:02 PM Changeset in webkit [46153] by
-
- 11 edits2 adds in trunk
Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469
Reviewed Gavin Barraclough
Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.
- 8:33 PM Changeset in webkit [46152] by
-
- 2 edits3 adds in trunk/WebKit/qt
[Qt] Add test for loading webpages...
Performance test for loading webpages...
- 8:32 PM Changeset in webkit [46151] by
-
- 2 edits4 adds in trunk/WebKit/qt
[Qt] Add a test case for drawing a simple viewrect to a QPixmap
- 8:30 PM Changeset in webkit [46150] by
-
- 3 edits3 adds in trunk
2009-07-20 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Guard access to installedMediaEngines()[0].
https://bugs.webkit.org/show_bug.cgi?id=27479
http://code.google.com/p/chromium/issues/detail?id=16541
Else where in the file, installedMediaEngines is always checked for
being empty because access. This patch adds a case which missed that
check.
This triggered a crash in Chromium:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load):
- 8:27 PM Changeset in webkit [46149] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Gavin Barraclough <barraclough@apple.com>
RS Oliver Hunt.
Add ARM assembler files to xcodeproj, for convenience editing.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 8:06 PM Changeset in webkit [46148] by
-
- 2 edits in trunk/WebCore
2009-07-20 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Allow search entries to render with a CSS border if the RenderTheme
doesn't paint them.
https://bugs.webkit.org/show_bug.cgi?id=27466
http://code.google.com/p/chromium/issues/detail?id=16958
<input type="search"> is very much like a text entry except that,
currently, if the RenderTheme doesn't deal with it, nothing is
rendered. With this patch, the default CSS border is rendered if the
RenderTheme requests it.
This will affect many layout tests, but only for Chromium Linux and
those results are not currently in the WebKit tree.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintBorderOnly):
- 7:58 PM Changeset in webkit [46147] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Jessie Berlin <jberlin@apple.com>
Fix an incorrect assertion in Vector::remove.
Reviewed by David Levin.
- wtf/Vector.h: (WTF::::remove): Assert that the position at which to start removing elements + the length (the number of elements to remove) is less than or equal to the size of the entire Vector.
- 7:54 PM Changeset in webkit [46146] by
-
- 2 edits in trunk/LayoutTests
Correct expected results from r46136, which accidentally included the
DumpRenderTree header and trailer
- fast/loader/non-html-load-event-expected.txt:
- 7:19 PM Changeset in webkit [46145] by
-
- 14 edits in trunk/WebCore
2009-07-17 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Switch to faster methods to access internal fields.
https://bugs.webkit.org/show_bug.cgi?id=27372
Minor refactoring.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::setDOMWrapper):
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::removeElement):
- bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 7:15 PM Changeset in webkit [46144] by
-
- 4 edits1 add in trunk/WebCore
2009-07-20 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium Linux: cache Harfbuzz faces.
Previously, we recreated the Harfbuzz face for each script-run. With
this patch, we keep the Harfbuzz face in the FontPlatformData (created
as needed) and so they will persist for the duration of the
FontPlatformData.
Shouldn't affect any layout tests. Results in a significant win on the
intl2 page cycler time.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::setupFontForScriptRun):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::~RefCountedHarfbuzzFace): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::create): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::face): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::RefCountedHarfbuzzFace):
- platform/graphics/chromium/HarfbuzzSkia.h: Added.
- 6:31 PM Changeset in webkit [46143] by
-
- 2 edits in trunk/WebCore
2009-07-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Simon Fraser.
REGRESSION (r46142): Need to remove showTreeThisForThis
https://bugs.webkit.org/show_bug.cgi?id=27475
Removes showTreeThisForThis
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::appendParagraphIntoNode):
- 5:55 PM Changeset in webkit [46142] by
-
- 16 edits8 adds in trunk
WebCore:
2009-07-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Refactoring of indentRegion to fix bugs 26816 and 25317
https://bugs.webkit.org/show_bug.cgi?id=26816
https://bugs.webkit.org/show_bug.cgi?id=25317
https://bugs.webkit.org/show_bug.cgi?id=23995 (partially)
This patch implements appendParagraphIntoNode, a simpler specialized version of moveParagraph
and replaces all calls inside indentRegion. The following is the new behavior of indentRegion.
- We try to indent as many wrapping nodes as possible. e.g. when indenting "hello" in <div>hello</div>, we try to indent div as well.
- We do not delete any wrapping elements With moveParagraph, we used to remove all wrapping nodes, and replaced with a blockquote. This was causing https://bugs.webkit.org/show_bug.cgi?id=23995 for indentation. With appendParagraphIntoNode, we can preserve all wrapping nodes.
- We only split the tree until the closest block node instead of until the root editable node. This behavioral change fixes the bug 25317.
- When multiple paragraphs are indented, we indent the highest common ancestor within the selection. e.g. when a list is a child node of a div, and the entire div is intended,
we enclose the div by a single blockquote.
Note that new behavior is more consistent with that of Internet Explorer and Firefox.
To demonstrate this, the following tests are added.
Tests: editing/execCommand/indent-div-inside-list.html
editing/execCommand/indent-nested-blockquotes.html
editing/execCommand/indent-nested-div.html
editing/execCommand/indent-second-paragraph-in-blockquote.html
- editing/IndentOutdentCommand.cpp: prepareBlockquoteLevelForInsertion is removed (WebCore::IndentOutdentCommand::tryIndentingAsListItem): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::indentIntoBlockquote): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::appendParagraphIntoNode): removes a paragraph and appends it to a new node (WebCore::IndentOutdentCommand::removeUnnecessaryLineBreakAt): removes a break element at the specified position (WebCore::IndentOutdentCommand::indentRegion): exhibits the described behavior
- editing/IndentOutdentCommand.h: updated prototype
- editing/execCommand/19653-1-expected.txt: rebaselined (no longer removes wrapping div)
- editing/execCommand/indent-div-inside-list-expected.txt: Added.
- editing/execCommand/indent-div-inside-list.html: Added.
- editing/execCommand/indent-nested-blockquotes-expected.txt: Added.
- editing/execCommand/indent-nested-blockquotes.html: Added.
- editing/execCommand/indent-nested-div-expected.txt: Added.
- editing/execCommand/indent-nested-div.html: Added.
- editing/execCommand/indent-nested-lists-2-expected.txt: rebaselined (selection corrected)
- editing/execCommand/indent-nested-lists-3-expected.txt: rebaselined (selection corrected)
- editing/execCommand/indent-nested-lists-4-expected.txt: rebaselined (selection corrected)
- editing/execCommand/indent-nested-lists-5-expected.txt: rebaselined (selection corrected)
- editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Added.
- editing/execCommand/indent-second-paragraph-in-blockquote.html: Added.
- platform/mac/editing/execCommand/4641880-2-expected.txt: rebaselined
- platform/mac/editing/execCommand/4916541-expected.txt: rebaselined (no longer removes wrapping span)
- platform/mac/editing/execCommand/5138441-expected.txt: rebaselined
- platform/mac/editing/execCommand/5481523-expected.txt: rebaselined
- platform/mac/editing/execCommand/indent-selection-expected.txt: rebaselined
- 4:59 PM Changeset in webkit [46141] by
-
- 2 edits in trunk/WebCore
Try to fix release builds after r46136
- dom/Element.cpp:
- 4:59 PM Changeset in webkit [46140] by
-
- 6 edits2 deletes in trunk
WebCore:
2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380
Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.
- css/mediaControlsQT.css:
LayoutTests:
2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380
Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.checksum: Removed.
- platform/mac/media/controls-styling-expected.png: Removed.
- platform/mac/media/controls-styling-expected.txt:
- platform/mac/media/video-zoom-controls-expected.txt:
- 4:56 PM Changeset in webkit [46139] by
-
- 19 edits in trunk
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
WebCore:
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/WebCoreGenerated.vcproj:
WebKit/win:
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/InterfacesGenerated.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
WebKitTools:
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 4:35 PM Changeset in webkit [46138] by
-
- 3 edits in trunk/LayoutTests
2009-07-20 Eric Seidel <eric@webkit.org>
Reviewed by Sam Weinig.
Fix failures seen on the bots
https://bugs.webkit.org/show_bug.cgi?id=27463
Ignore more global variables added by DumpRenderTree.
Some platforms don't add all of the DRT controllers,
thus causing this test to fail for those platforms.
Also fix !value to value === null to handle not
skip the cases where value == 0.
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/resources/prototype-inheritance.js:
- 4:15 PM Changeset in webkit [46137] by
-
- 1 edit in trunk/LayoutTests/transitions/extra-transition.html
Fixed a transition LayoutTest which fails on slower machines
- 4:08 PM Changeset in webkit [46136] by
-
- 11 edits4 adds in trunk
WebCore:
Reviewed by Anders Carlsson.
When loading a custom view into a frame, the old document is still
around
<rdar://problem/5145841>
Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>
Test: fast/loader/non-html-load-event.html
- GNUmakefile.am: Added PlaceholderDocument.{cpp,h}
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- dom/Document.h: (WebCore::Document::setStyleSelector): Added this protected accessor for
PlaceholderDocument to use.
- dom/Element.cpp: (WebCore::Element::clientWidth): Check whether the document has a
renderer.
(WebCore::Element::clientHeight): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a PlaceholderDocument for frames
that do not use an HTML view. Do not nullify the content size in
that case.
(WebCore::FrameLoader::transitionToCommitted): For frames that do not
use an HTML view, call receivedFirstData(), which sets up the
frame with a new PlaceHolderDocument.
- loader/PlaceholderDocument.cpp: Added. (WebCore::PlaceholderDocument::attach): Sets up the style selector but
does not create a RenderView.
- loader/PlaceholderDocument.h: Added. (WebCore::PlaceholderDocument::create): (WebCore::PlaceholderDocument::PlaceholderDocument):
LayoutTests:
Reviewed by Anders Carlsson.
Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>
- fast/loader/non-html-load-event-expected.txt: Added.
- fast/loader/non-html-load-event.html: Added.
- 3:45 PM Changeset in webkit [46135] by
-
- 5 edits in trunk/WebCore
Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398
This makes two changes, and only for Leopard.
First, whenever opacity is changed on a layer I propagate the
change into the content layer and all the children if the layer
on which opacity is set is a transform layer (preserve3D is true).
The opacity set is the accumulated opacity from this layer
and all its direct ancestor transform layers. Second, I turn off all
hardware opacity animation.
- 3:16 PM Changeset in webkit [46134] by
-
- 2 edits in trunk/WebKitTools
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27323
Use shorter, more correct code for determining the current directory,
which works better with symbolic links on some systems. Also switch
from checking repository root to checking UUID, to match scm.py.
- Scripts/svn-create-patch:
- 2:46 PM Changeset in webkit [46133] by
-
- 2 edits in trunk/WebKitTools
Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText.
Rubber-stamped by Dan Bernstein.
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFonts):
- 2:38 PM Changeset in webkit [46132] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-07-20 Geoffrey Garen <ggaren@apple.com>
Fixed a post-review typo in r46066 that caused tons of test failures.
SunSpider reports no change.
- runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize the full vector capacity, to avoid uninitialized members at the end.
- 1:55 PM Changeset in webkit [46131] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-07-20 Geoffrey Garen <ggaren@apple.com>
Windows WebKit build fix: Added some missing exports.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 1:41 PM Changeset in webkit [46130] by
-
- 2 edits in trunk/WebKitTools
2009-07-20 David Levin <levin@chromium.org>
Reviewed by Adam Treat.
Enable filename completion for run-webkit-test (added "-o default").
- Scripts/webkit-tools-completion.sh:
- 1:08 PM Changeset in webkit [46129] by
-
- 1 edit2 adds in trunk/WebCore
2009-07-20 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=27349
Add GraphicsContext implementation for the WinCE port.
Written by Yong Li <yong.li@torchmobile.com> and George Staikos <george.staikos@torchmobile.com>
with trivial style fixes by Adam Treat <adam.treat@torchmobile.com>
- platform/graphics/wince/GraphicsContextWince.cpp: Added.
- 1:06 PM Changeset in webkit [46128] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r46058.
- 12:37 PM Changeset in webkit [46127] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r46039.
- 10:56 AM Changeset in webkit [46126] by
-
- 3 edits4 adds in trunk/WebCore
2009-07-20 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adding the Win SQLite VFS implementation for Chromium, and stubs
for the Mac and Linux VFSs.
- WebCore.gypi:
- platform/chromium/ChromiumBridge.h:
- platform/sql/chromium/SQLiteFileSystemChromium.cpp: Added.
- platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Added.
- platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Added.
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Added.
- 6:47 AM Changeset in webkit [46125] by
-
- 2 edits in trunk/WebCore
2009-07-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=27097
[Gtk] Segfault when examining an object of ROLE_TABLE via at-spi
Check that an object is a RenderObject before trying to access its
renderer and related node.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 6:36 AM Changeset in webkit [46124] by
-
- 5 edits in trunk/WebCore
2009-07-20 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265
Reimplemented Qt's FontCache in a way that follows the shared one.
Now we can release its elements when those became inactive.
FontFallbackList had been changed to be able to hold WebCore fonts in its list and to be able to release a FontData what is in the cache.
No change in behavior, so no tests.
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue): (WebCore::FontPlatformDataCacheKey::): Key type for the cache of FontPlatformData objects. It can be constructed from a FontPlatformData or from a FontDescription. The keys have to be consistent with FontPlatformData::FontPlatformData(const FontDescription&) - if we create the same FontPlatformData from two FontDescription then we have to create the same key from them, and vica versa. (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::FontPlatformDataCacheKey::hash): (WebCore::FontPlatformDataCacheKey::computeHash): (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize): (WebCore::FontPlatformDataCacheKeyHash::hash): (WebCore::FontPlatformDataCacheKeyHash::equal): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue): (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue): (WebCore::FontCache::getCachedFontPlatformData): Get a FontDescription and returns a FontPlatformData. (WebCore::FontCache::getCachedFontData): Get a FontPlatformData and returns a SimpleFontData. (WebCore::FontCache::releaseFontData): Get a SimpleFontData and releases it from the cache. Also releases the appropriate FontPlatformData. (WebCore::FontCache::purgeInactiveFontData): Frees inactive elements. (WebCore::FontCache::invalidate): Frees all inactive elements (call purgeInactiveFontData with default argument)
- platform/graphics/qt/FontFallbackListQt.cpp: (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt):
- platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::family): Getter. It is needed for FontPlatformDataCacheKey. (WebCore::FontPlatformData::bold): Ditto. (WebCore::FontPlatformData::italic): Ditto. (WebCore::FontPlatformData::smallCaps): Ditto. (WebCore::FontPlatformData::pixelSize): Ditto.
- platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): Set m_bold.
- 4:01 AM Changeset in webkit [46123] by
-
- 3 edits in trunk/WebKit/gtk
2009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] Widget size negotiation
https://bugs.webkit.org/show_bug.cgi?id=17154
Implement proper size request for the WebView widget.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::contentsSizeChanged):
- webkit/webkitwebview.cpp: (webkit_web_view_size_request): (webkit_web_view_class_init):
- 3:09 AM Changeset in webkit [46122] by
-
- 2 edits in trunk/WebKitTools
2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
No review, just adding Gavin Barraclough as reviewer.
- Scripts/modules/bugzilla.py:
- 3:04 AM Changeset in webkit [46121] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Allow custom memory allocation control in NewThreadContext
https://bugs.webkit.org/show_bug.cgi?id=27338
Inherits NewThreadContext struct from FastAllocBase because it
has been instantiated by 'new' JavaScriptCore/wtf/Threading.cpp:76.
- wtf/Threading.cpp:
- 3:04 AM Changeset in webkit [46120] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Allow custom memory allocation control in JavaScriptCore's JSClassRef.h
https://bugs.webkit.org/show_bug.cgi?id=27340
Inherit StaticValueEntry and StaticFunctionEntry struct from FastAllocBase because these
have been instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:153
and in JavaScriptCore/API/JSClassRef.cpp:166.
- API/JSClassRef.h:
- 3:03 AM Changeset in webkit [46119] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control in JavaScriptCore's RegexPattern.h
https://bugs.webkit.org/show_bug.cgi?id=27343
Inherits RegexPattern.h's structs (which have been instantiated by operator new) from FastAllocBase:
CharacterClass (new call: JavaScriptCore/yarr/RegexCompiler.cpp:144)
PatternAlternative (new call: JavaScriptCore/yarr/RegexPattern.h:221)
PatternDisjunction (new call: JavaScriptCore/yarr/RegexCompiler.cpp:446)
- yarr/RegexPattern.h:
- 3:03 AM Changeset in webkit [46118] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's MatchFrame struct
https://bugs.webkit.org/show_bug.cgi?id=27344
Inherits MatchFrame struct from FastAllocBase because it has
been instantiated by 'new' JavaScriptCore/pcre/pcre_exec.cpp:359.
- pcre/pcre_exec.cpp:
- 3:02 AM Changeset in webkit [46117] by
-
- 2 edits in trunk/WebCore
2009-07-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=26716
[Gtk] Each XMLHttpRequest leaks memory.
Free the SoupURI we create to check the URI. Fix suggested by John
Kjellberg.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
- 2:52 AM Changeset in webkit [46116] by
-
- 4 edits in trunk
.:
2009-07-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438
Based on Norbert Leser's work.
- WebKit.pri: Symbian does not have UiTools
WebKit/qt:
2009-07-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438
Based on Norbert Leser's work.
- QtLauncher/main.cpp: (WebPage::createPlugin):
- 2:50 AM Changeset in webkit [46115] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
Remove some outdated S60 platform specific code
https://bugs.webkit.org/show_bug.cgi?id=27423
- wtf/Platform.h:
- 2:49 AM Changeset in webkit [46114] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Qt build fix with MSVC and MinGW.
- jsc.pro: Make sure jsc is a console application, and turn off exceptions and stl support to fix the build.
- 2:46 AM Changeset in webkit [46113] by
-
- 3 edits in trunk/WebKitTools
2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by David Levin.
Add support for Qt's foreach to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27386
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 2:41 AM Changeset in webkit [46112] by
-
- 2 edits in trunk/WebCore
2009-07-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] On Symbian link against system sqlite3
https://bugs.webkit.org/show_bug.cgi?id=27368
Add an option to force linking against system sqlite3
by adding system-sqlite to the CONFIG variable.
The Symbian specific part of this patch is contributed by
Norbert Leser.
- WebCore.pro:
- 2:32 AM Changeset in webkit [46111] by
-
- 3 edits in trunk/WebCore
2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by and done with Tor Arne Vestbø.
Fix fast/css/pseudo-required-optional-*.html in the Qt build
after r46062.
These tests triggered a bug in RenderThemeQt where we did not fall back
to the unstyled painting of text areas and input fields when they have
a styled background.
Our re-implementation of isControlStyled incorrectly only checked the
border for determining whether to style or not. The base-implementation
performs the same check, but also includes the background. Removing
our implementation fixes the appearance.
- platform/qt/RenderThemeQt.cpp: Removed isControlStyled reimplementation.
- platform/qt/RenderThemeQt.h: Ditto.
- 1:31 AM Changeset in webkit [46110] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not use C++-style comments in preprocessor directives.
GCC does not like this in some configurations, using C-style
comments is safer.
- wtf/Platform.h:
- 1:31 AM Changeset in webkit [46109] by
-
- 2 edits in trunk/WebCore
2009-07-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Change the glib version check to check for the first unstable
release with g_mapped_file_unref. Otherwise this would be useless
until 2.22 is released, a few months from now.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
- 12:51 AM Changeset in webkit [46108] by
-
- 2 edits in trunk/WebCore
2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Add missing (sorted) header files to the HEADERS variable in the qmake
.pro file for improved completion in IDEs.
- WebCore.pro:
- 12:24 AM Changeset in webkit [46107] by
-
- 2 edits in trunk/LayoutTests
2009-07-19 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Xan Lopez.
Skip new fast/dom/prototype-inheritance.html test in the Qt DRT
due to missing features/properties in the window object.
- platform/qt/Skipped:
Jul 19, 2009:
- 8:56 PM Changeset in webkit [46106] by
-
- 3 edits2 adds in trunk/WebCore
2009-07-19 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421
No behavior change.
- WebCore.gypi:
- bindings/v8/V8ConsoleMessage.cpp: Added. (WebCore::V8ConsoleMessage::V8ConsoleMessage): (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::dispatchLater): (WebCore::V8ConsoleMessage::processDelayed): (WebCore::V8ConsoleMessage::handler):
- bindings/v8/V8ConsoleMessage.h: Added. (WebCore::V8ConsoleMessage::Scope::Scope): (WebCore::V8ConsoleMessage::Scope::~Scope):
- bindings/v8/V8Proxy.cpp: (WebCore::logInfo): (WebCore::reportUnsafeAccessTo): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::processConsoleMessages):
- 11:50 AM Changeset in webkit [46105] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Barth.
Remove unused member variable.
- svg/SVGPolyElement.h:
- 11:16 AM Changeset in webkit [46104] by
-
- 3 edits2 adds in trunk
2009-07-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422
Test: media/audio-constructor-autobuffer.html
- bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
Set 'autobuffer' attribute.
2009-07-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422
- media/audio-constructor-autobuffer-expected.txt: Added.
- media/audio-constructor-autobuffer.html: Added.
- 2:47 AM Changeset in webkit [46103] by
-
- 2 edits in trunk/WebCore
2009-07-19 Thierry Bastian <thierry.bastian@nokia.com>
Reviewed by Simon Hausmann.
Fix the Qt build with mingw.
- WebCore.pro: Don't use MSVC commandline options to disable warnings with mingw.
- 12:39 AM Changeset in webkit [46102] by
-
- 14 edits in trunk/WebCore
2009-07-19 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[V8] Phase 2: Remove event listener methods from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27415
No behavior change.
- bindings/v8/V8ObjectEventListener.cpp: (WebCore::weakObjectEventListenerCallback): (WebCore::V8ObjectEventListener::~V8ObjectEventListener):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::disconnectEventListeners):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::eventListeners): (WebCore::V8Proxy::objectListeners):
- bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::getEventListener):
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::~V8EventListener):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::getEventListener):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener):
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
