⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 22, 2009:

11:45 PM WebDevelopers edited by dbates@berkeley.edu
Removed outdated links to Safari version matrix, and FAQ. (diff)
11:32 PM Changeset in webkit [46255] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

[V8] Make Node wrappers go fast
​https://bugs.webkit.org/show_bug.cgi?id=27597

Profiles indicate we're spending a lot of time asking whether we're on
the main thread when looking up DOM wrappers for Nodes, but there isn't
much point in doing that work because Nodes only exist on the main
thread. I've also added an assert to keep us honest in this regard.

  • bindings/v8/V8DOMMap.cpp: (WebCore::): (WebCore::getDOMNodeMap): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread):
10:39 PM Changeset in webkit [46254] by sfalken@apple.com
  • 1 edit
    6 adds in trunk/WebKitTools

Checkpoint new Windows nightly launcher.


Reviewed by Mark Rowe.

  • WebKitLauncherWin: Added.
  • WebKitLauncherWin/Resource.h: Added.
  • WebKitLauncherWin/WebKitLauncherWin.cpp: Added. (getStringValue): Retrieve a string registry value. (applePathFromRegistry): Get an Apple-related path out of the registry. (copyEnvironmentVariable): Copy an environment variable. (safariInstallDir): Helper function to get the install directory for Safari. (safariBrowserExe): Helper function to get the full path of the Safari executable. (_tWinMain): Locate Safari and launch it after setting up an environment variable.
  • WebKitLauncherWin/WebKitLauncherWin.h: Added.
  • WebKitLauncherWin/WebKitLauncherWin.rc: Added.
  • WebKitLauncherWin/WebKitLauncherWin.vcproj: Added.
  • WebKitLauncherWin/webkit.ico: Added.
7:52 PM Changeset in webkit [46253] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove unneeded virtual destructor from ScriptSourceProvider
​https://bugs.webkit.org/show_bug.cgi?id=27563

  • bindings/js/ScriptSourceProvider.h:
7:29 PM Changeset in webkit [46252] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adam Barth.

REGRESSION (r46240): /fast/css/getComputedStyle/computed-style & computed-style-without-renderer needs rebaseline for Windows
​https://bugs.webkit.org/show_bug.cgi?id=27591

Rebaselines the tests.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
7:01 PM Changeset in webkit [46251] by rniwa@webkit.org
  • 7 edits
    8 adds in trunk

WebCore:

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=27476

executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
and adds removeAll member function to CSSValueList.

Tests: editing/execCommand/toggle-text-decorations.html

fast/css/getComputedStyle/getComputedStyle-text-decoration.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
  • css/CSSValueList.cpp: (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
  • css/CSSValueList.h:
  • editing/EditorCommand.cpp: (WebCore::applyCommandToFrame): Apply style to a frame using specified command (WebCore::executeApplyStyle): Uses applyCommandToFrame (WebCore::executeToggleStyleInList): Uses applyCommandToFrame (WebCore::executeToggleStyle): Toggles a style in CSSValueList (WebCore::executeStrikethrough): Uses executeToggleStyleInList (WebCore::executeUnderline): Uses executeToggleStyleInList

LayoutTests:

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=27476

toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"

getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.

  • editing/execCommand/resources/toggle-text-decorations.js: Added. (testSingleToggle):
  • editing/execCommand/toggle-text-decorations-expected.txt: Added.
  • editing/execCommand/toggle-text-decorations.html: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
  • fast/css/getComputedStyle/resources: Added.
  • fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
  • fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added. (expect):
4:27 PM Changeset in webkit [46250] by abarth@webkit.org
  • 4 edits
    9 adds in trunk

2009-07-22 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27174
And
​https://bugs.webkit.org/show_bug.cgi?id=26938

Tests prevention of attacks transformed by PHP Magic Quotes/PHP addslashes().

  • http/tests/security/xssAuditor/resources/echo-intertag-addslashes.pl: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html: Added.

2009-07-22 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27174
And
​https://bugs.webkit.org/show_bug.cgi?id=26938

Code cleanup. Implements support for detecting attacks transformed by
PHP Magic Quotes/PHP addslashes().

Tests: http/tests/security/xssAuditor/script-tag-addslashes-backslash.html

http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html
http/tests/security/xssAuditor/script-tag-addslashes-null-char.html
http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html

  • page/XSSAuditor.cpp: (WebCore::isInvalidCharacter): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::normalize): Decodes HTML entities, removes backslashes, and removes control characters that could otherwise cause a discrepancy between the source code of a script and the outgoing HTTP parameters. (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::decodeHTMLEntities): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:
3:48 PM Changeset in webkit [46249] by levin@chromium.org
  • 1 edit
    1 move in trunk/WebKitTools

2009-07-22 David Levin <​levin@chromium.org>

Reviewed by Adam Treat.

run-webkit-lint should be named check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=27568

This name better reflects the fact that it is about checking the style of files.

  • Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint.
3:31 PM Changeset in webkit [46248] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix false positives in namespace indentation checks.
​https://bugs.webkit.org/show_bug.cgi?id=27567

The regular expression detecting goto labels (in order
to skip those) was too permissive, which caused other
code like "Foo::Bar()" to be treated as a label too,
thereby not stopping the processing loop as expected.

Now comes with a stricter regexp, and more demanding
test cases to check for these issues.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
3:17 PM Changeset in webkit [46247] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

2009-07-22 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam Weinig.

With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once per repatch event.
( ​https://bugs.webkit.org/show_bug.cgi?id=27564 )

Currently we change permissions forwards and backwards for each instruction modified,
instead we should only change permissions once per complete repatching event.

2.5% progression running with ENABLE(ASSEMBLER_WX_EXCLUSIVE) enabled,
which recoups 1/3 of the penalty of running with this mode enabled.

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::linkBranch):
    • Replace usage of MakeWritable with cacheFlush.


  • assembler/ARMAssembler.h: (JSC::ARMAssembler::patchPointerInternal): (JSC::ARMAssembler::repatchLoadPtrToLEA):
    • Replace usage of MakeWritable with cacheFlush.
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::relinkJump): (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer): (JSC::ARMv7Assembler::repatchLoadPtrToLEA): (JSC::ARMv7Assembler::setInt32):
    • Replace usage of MakeWritable with cacheFlush.
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::performFinalization):
    • Make explicit call to cacheFlush.
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
    • Make size always available.
  • assembler/RepatchBuffer.h: (JSC::RepatchBuffer::RepatchBuffer): (JSC::RepatchBuffer::~RepatchBuffer):
    • Add calls to MakeWritable & makeExecutable.
  • assembler/X86Assembler.h: (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::repatchLoadPtrToLEA):
    • Remove usage of MakeWritable.
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getJITCode):
    • Provide access to CodeBlock's JITCode.
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeExecutable): (JSC::ExecutableAllocator::cacheFlush):
    • Remove MakeWritable, make cacheFlush public.
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompile): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
    • Add CodeBlock argument to RepatchBuffer.
  • jit/JIT.h:
    • Pass CodeBlock argument for use by RepatchBuffer.
  • jit/JITCode.h: (JSC::JITCode::start): (JSC::JITCode::size):
    • Provide access to code start & size.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
    • Add CodeBlock argument to RepatchBuffer.
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
    • Pass CodeBlock argument for use by RepatchBuffer.
3:12 PM Changeset in webkit [46246] by oliver@apple.com
  • 2 edits in trunk/WebCore

Null deref in JSObject::mark due to null xhr wrapper
​https://bugs.webkit.org/show_bug.cgi?id=27565

Reviewed by Adele Peterson.

Make event target binding for appcache and xhr behave in the same way as
it does for all other events.

No test as I couldn't make a testcase which was remotely reliable.

3:10 PM Changeset in webkit [46245] by levin@chromium.org
  • 4 edits in trunk

2009-07-22 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Adler.

VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
​https://bugs.webkit.org/show_bug.cgi?id=26375

WebKit/win:

Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
with hex escape sequences.

VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
treated as an error and stopped build).

WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
represented in the current code page (932). Save the file in Unicode format to prevent data loss

A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
localized string generation process.

  • WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):

WebKitTools:

Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now,
the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals
in the macros before writing out them into the file to update.

By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian
strings in the Localizable.strings file.

Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide
users to update-webkit-localizable-strings.

  • Scripts/extract-localizable-strings:
3:09 PM Changeset in webkit [46244] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <​hamaji@google.com>

Reviewed by David Levin.

Tiny typo fixes for cpplint.py
​https://bugs.webkit.org/show_bug.cgi?id=27530

  • Scripts/modules/cpplint.py:
3:09 PM Changeset in webkit [46243] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

run-webkit-lint checks code which are not changed
​https://bugs.webkit.org/show_bug.cgi?id=27529

Add check if the line is newly added.

  • Scripts/run-webkit-lint:
3:09 PM Changeset in webkit [46242] by levin@chromium.org
  • 4 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

run-webkit-lint should have --git-commit option
​https://bugs.webkit.org/show_bug.cgi?id=27528

  • Scripts/modules/cpplint.py:
  • Scripts/run-webkit-lint:
3:09 PM Changeset in webkit [46241] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Mads Ager <​ager@chromium.org>

Reviewed by David Levin.

Inform V8 of the amount of WebCore string memory it is keeping alive.
​https://bugs.webkit.org/show_bug.cgi?id=27537

V8 uses external strings that are backed by WebCore strings. Since
the external strings themselves are small, V8 has no way of
knowing how much memory it is actually holding on to. With this
change, we inform V8 of the amount of WebCore string data it is
holding on to with external strings.

  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource):
2:59 PM Changeset in webkit [46240] by hyatt@apple.com
  • 15 edits
    12 adds in trunk

WebCore:

2009-07-22 David Hyatt <​hyatt@apple.com>

Reviewed by Beth Dakin.

​https://bugs.webkit.org/show_bug.cgi?id=27562
Add the finalized versions of background-clip and background-origin. Remove background-clip from
the background shorthand and have it be auto-set based off background-origin's value.

Three new tests added in fast/backgrounds/size

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseFillProperty):
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:

LayoutTests:

2009-07-22 David Hyatt <​hyatt@apple.com>

Reviewed by Beth Dakin.

​https://bugs.webkit.org/show_bug.cgi?id=27562
Add some new layout tests that drop the prefix from the background properties and use origin
in a shorthand. Update shorthand results and computed style results to account for new properties.

  • fast/backgrounds/size/backgroundSize20.html: Added.
  • fast/backgrounds/size/backgroundSize21.html: Added.
  • fast/backgrounds/size/backgroundSize22.html: Added.
  • fast/css/background-position-serialize-expected.txt:
  • fast/css/remove-shorthand-expected.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/inspector/style-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:47 PM Changeset in webkit [46239] by jorlow@chromium.org
  • 16 edits
    3 adds in trunk

WebCore:

2009-07-22 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

Hook up V8 bindings for DataGrid elements.
​https://bugs.webkit.org/show_bug.cgi?id=27383
​http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • WebCore.gypi: Added new source files.
  • bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
  • bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
  • bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates. (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
  • bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::V8DataGridDataSource): (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
  • bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::create): (WebCore::V8DataGridDataSource::isJSDataGridDataSource): (WebCore::V8DataGridDataSource::jsDataSource): (WebCore::asV8DataGridDataSource):
  • bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
  • bindings/v8/V8Index.h: Conditionalize datagrid stuff.
  • bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-22 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

Hook up V8 bindings for DataGrid elements.
​https://bugs.webkit.org/show_bug.cgi?id=27383
​http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
1:46 PM Changeset in webkit [46238] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

pushDownTextDecorationStyleAroundNode needs clean up
​https://bugs.webkit.org/show_bug.cgi?id=27556

Cleaned up. pushDownTextDecorationStyleAroundNode traverses tree vertically from highestAncestor to targetNode
While traversing, it will apply the specified style to all nodes but targetNode.
i.e. the style is applies to all ancestor nodes and their siblings of targetNode.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Cleaned up and added comments
  • editing/ApplyStyleCommand.h: Updated prototype
1:35 PM Changeset in webkit [46237] by pkasting@chromium.org
  • 4 edits in trunk/WebCore

2009-07-22 Peter Kasting <​pkasting@google.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any type of line endings in WebCore/css/*CSSPropertyNames.in.

  • DerivedSources.make:
  • css/makeprop.pl:
  • css/makevalues.pl:
1:32 PM Changeset in webkit [46236] by pkasting@chromium.org
  • 4 edits in trunk/WebKitTools

2009-07-22 Peter Kasting <​pkasting@google.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=27323
Factor svn-create-patch's "determineSvnRoot()" into a function in
VCSUtils.pm so commit-log-editor can use it too.

  • Scripts/VCSUtils.pm: Add determineSVNRoot().
  • Scripts/commit-log-editor: Use determineSVNRoot() instead of old code (which didn't work as well).
  • Scripts/svn-create-patch: Remove determineSvnRoot() (moved).
1:18 PM Changeset in webkit [46235] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

Revert bugfix for 27557 as this is invalid according to Darin Adler
who states that include order sorting should be case-sensitive.

1:06 PM Changeset in webkit [46234] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-22 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

expand prototype-inheritance test to cover constructors
​https://bugs.webkit.org/show_bug.cgi?id=27547

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/resources/prototype-inheritance.js:
1:05 PM Changeset in webkit [46233] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Case-insensitive comparison of include file order for cpplint.
​https://bugs.webkit.org/show_bug.cgi?id=27557

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
1:00 PM Changeset in webkit [46232] by ggaren@apple.com
  • 5 edits
    1 add in branches/nitro-extreme/WebCore

2009-07-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some trivial differences between the branch and r45633, to
facilitate the merge.

  • bindings/js/ScriptEventListener.cpp:
  • bridge/c/c_instance.cpp:
  • inspector/front-end/Images/resourcesSilhouette.png: Added.
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::paintObject):
  • rendering/RenderDataGrid.h:
12:51 PM Changeset in webkit [46231] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix cpplint generating false positives for
"primary" includes in headers.
​https://bugs.webkit.org/show_bug.cgi?id=27553

Doing so by only flagging includes in header files
as primary when the include filename exactly matches
the header filename.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:24 PM Changeset in webkit [46230] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

cpplint generates false positives for primary includes
​https://bugs.webkit.org/show_bug.cgi?id=27544

Fix false positives for instances when cpplint would
normally classify multiple includes as primary: After
the first primary include, classify subsequent ones as
"other" includes even if they look like primary ones.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:55 AM Changeset in webkit [46229] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Paul Godavari <​paul@chromium.org>

Reviewed by Darin Fisher.

Chromium has a build break after removal of JSRGBColor bindings
​https://bugs.webkit.org/show_bug.cgi?id=27548

Fix a build break in Chromium V8 after the JSRGBColor bindings change:
​https://bugs.webkit.org/show_bug.cgi?id=27242

  • bindings/scripts/CodeGeneratorV8.pm:
11:46 AM Changeset in webkit [46228] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2009-07-22 Gabor Rapcsanyi <​rapcsanyi.gabor@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Pass XAUTHORITY environment variable to $dumpTool as well.

  • Scripts/run-webkit-tests:
10:02 AM Changeset in webkit [46227] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-07-20 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r39185): Safari adds ".jpeg" extension to images that already have ".JPG" extension
​https://bugs.webkit.org/show_bug.cgi?id=27472

  • WebView/WebHTMLView.mm: (matchesExtensionOrEquivalent): Changed category method into a C function. Made it require the leading dot when checking for the extension and do it in a non-case-sensitive way. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Changed to call the function.
9:56 AM Changeset in webkit [46226] by agl@chromium.org
  • 3 edits in trunk/WebCore

2009-07-22 Adam Langley <​agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: add static functions to FontPlatformData which allow
for setting the global font rendering preferences.

​https://bugs.webkit.org/show_bug.cgi?id=27513
​http://code.google.com/p/chromium/issues/detail?id=12179

This should not affect any layout tests.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setHinting): (WebCore::FontPlatformData::setAntiAlias): (WebCore::FontPlatformData::setSubpixelGlyphs): (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/FontPlatformDataLinux.h:
8:20 AM Changeset in webkit [46225] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Add check for correct wtf includes to cpplint.
​https://bugs.webkit.org/show_bug.cgi?id=27524

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
8:15 AM Changeset in webkit [46224] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for multi-line boolean operator placement.
​https://bugs.webkit.org/show_bug.cgi?id=27496

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
7:13 AM Changeset in webkit [46223] by zecke@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-22 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam Treat.

Mention the new webkit-help and webkit-jobs mailinglist. Change
the description of webkit-dev to be more strict.

  • contact.html:
6:34 AM Changeset in webkit [46222] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Move Inspector panels creation into a function to make possible introducing
custom panels.

6:33 AM Changeset in webkit [46221] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-22 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove unused variables.

  • webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event):
6:30 AM Changeset in webkit [46220] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Print console command message upon evaluate
selection request; Handle errors in evaluation request
properly.

​https://bugs.webkit.org/show_bug.cgi?id=27535

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
6:04 AM Changeset in webkit [46219] by kenneth@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-22 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Adam Treat.

Coding style - Clarify some cases with spacing
​https://bugs.webkit.org/show_bug.cgi?id=27499

Add explicit rule about no space before comma or semicolon.

  • coding/coding-style.html:
12:47 AM WebKit Team edited by rniwa@webkit.org
(diff)
12:46 AM WebKit Team edited by rniwa@webkit.org
(diff)
12:17 AM Changeset in webkit [46218] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Xan Lopez <​xlopez@igalia.com>

Attempt to fix the GTK+ build.

  • GNUmakefile.am:

Jul 21, 2009:

11:54 PM Changeset in webkit [46217] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-21 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Qt build.

  • WebCore.pro: Add RGBColor.cpp to the build, remove JSRGBColor.
11:19 PM Changeset in webkit [46216] by abarth@webkit.org
  • 9 edits
    1 add in trunk/WebCore

2009-07-21 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27494

Fixes an issue that can cause a crash or unexpected behavior when calling
WebCore::ScriptSourceCode::source on a cached script.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CachedScriptSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::CachedScriptSourceProvider::source): (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): Separated out source provider and rewrote to use WebCore::ScriptSourceProvider. (WebCore::ScriptSourceCode::source):
  • bindings/js/ScriptSourceProvider.h: Added. (WebCore::ScriptSourceProvider::ScriptSourceProvider): (WebCore::ScriptSourceProvider::~ScriptSourceProvider):
  • bindings/js/StringSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::StringSourceProvider::StringSourceProvider):
10:31 PM Changeset in webkit [46215] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <​sam@webkit.org>

Another attempt to fix the Windows build.

  • WebCore.vcproj/WebCore.vcproj:
10:19 PM Changeset in webkit [46214] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <​sam@webkit.org>

Attempt to fix the Windows build.

  • DerivedSources.cpp:
10:17 PM Changeset in webkit [46213] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-21 Sam Weinig <​sam@webkit.org>

Attempt to fix the GTK build

  • GNUmakefile.am:
10:04 PM Changeset in webkit [46212] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebCore

2009-07-21 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Autogenerate Objective-C binding implementation for RGBColor.

No functionality change.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMRGBColor.mm: Removed.
  • bindings/scripts/CodeGeneratorObjC.pm: Add logic to convert from WebCore::Color to NSColor*.
  • css/RGBColor.idl:
9:27 PM Changeset in webkit [46211] by weinig@apple.com
  • 28 edits
    2 deletes in trunk

WebCore:

2009-07-21 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

Move the JSC and Objective-C bindings onto using the RGBColor object instead
of just an unsigned int. The JSC bindings are now completely autogenerated for
this class. (Also removes the last lut from WebCore).

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSRGBColor.cpp: Removed.
  • bindings/js/JSRGBColor.h: Removed.
  • bindings/objc/DOM.mm: (-[DOMRGBColor _color]):
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]):
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getRGBColorValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getRGBA32Value):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/RGBColor.cpp: (WebCore::RGBColor::alpha):
  • css/RGBColor.h: (WebCore::RGBColor::color): (WebCore::RGBColor::RGBColor):
  • css/RGBColor.idl:
  • page/DOMWindow.idl:
  • svg/SVGColor.cpp: (WebCore::SVGColor::rgbColor):
  • svg/SVGColor.h:

LayoutTests:

2009-07-21 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Changes for ​https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/js/global-constructors-expected.txt:
9:03 PM Changeset in webkit [46210] by barraclough@apple.com
  • 5 edits
    3 adds in trunk

JavaScriptCore:

2009-07-21 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Cache not only the structure of the method, but the
structure of its prototype as well.
​https://bugs.webkit.org/show_bug.cgi?id=27077

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::MethodCallLinkInfo):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::patchMethodCallProto):

LayoutTests:

2009-07-21 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough, RS olliej fix to make the test pass.

Check whether a crash happens after the string
prototype is overwritten twice. The JIT'ed code
may crash if one of its already cached method
called again. Note: This test is not necessary
crash on all systems, because they use different
memory allocators!
​https://bugs.webkit.org/show_bug.cgi?id=27077

  • fast/js/method-check-expected.txt: Added.
  • fast/js/method-check.html: Added.
  • fast/js/resources/method-check.js: Added. (func2): (func.String.prototype.a): (func.String.prototype.b): (func):
8:24 PM Changeset in webkit [46209] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2009-07-21 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam Weinig.

Move call linking / repatching down from AbstractMacroAssembler into MacroAssemblerARCH classes.
( ​https://bugs.webkit.org/show_bug.cgi?id=27527 )

This allows the implementation to be defined per architecture. Specifically this addresses the
fact that x86-64 MacroAssembler implements far calls as a load to register, followed by a call
to register. Patching the call actually requires the pointer load to be patched, rather than
the call to be patched. This is implementation detail specific to MacroAssemblerX86_64, and as
such is best handled there.

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::linkCall): (JSC::MacroAssemblerARM::repatchCall):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::linkCall): (JSC::MacroAssemblerARMv7::repatchCall):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::linkCall): (JSC::MacroAssemblerX86::repatchCall):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::linkCall): (JSC::MacroAssemblerX86_64::repatchCall):
7:42 PM Changeset in webkit [46208] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Correct relative path in the test after moving it.

  • platform/mac/fast/loader/non-html-load-event.html:
7:39 PM Changeset in webkit [46207] by mitz@apple.com
  • 2 edits
    2 moves in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Move fast/loader/non-html-load-event.html under platform/mac because
non-HTML views exist only on Mac.

  • fast/loader/non-html-load-event-expected.txt: Removed.
  • fast/loader/non-html-load-event.html: Removed.
  • platform/mac/fast/loader/non-html-load-event-expected.txt: Copied from LayoutTests/fast/loader/non-html-load-event-expected.txt.
  • platform/mac/fast/loader/non-html-load-event.html: Copied from LayoutTests/fast/loader/non-html-load-event.html.
  • platform/qt/Skipped:
7:08 PM Changeset in webkit [46206] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

7:07 PM Changeset in webkit [46205] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.7

New tag.

6:39 PM Changeset in webkit [46204] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-21 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by George Staikos.

Every wtf file includes other wtf files with <> style includes
except this one. Fix the exception.

  • wtf/ByteArray.h:
5:43 PM Changeset in webkit [46203] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

Implement AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent.
​https://bugs.webkit.org/show_bug.cgi?id=27515

  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
5:37 PM Changeset in webkit [46202] by barraclough@apple.com
  • 10 edits
    2 adds in trunk/JavaScriptCore

2009-07-21 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
( ​https://bugs.webkit.org/show_bug.cgi?id=27485 )

This change is the first step in a process to move code that should be in
the architecture-specific MacroAssembler classes up out of Assmbler and
AbstractMacroAssembler.


  • assembler/ARMAssembler.h: (JSC::ARMAssembler::linkPointer):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme


  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::linkCall): (JSC::ARMv7Assembler::linkPointer): (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer): (JSC::ARMv7Assembler::setInt32): (JSC::ARMv7Assembler::setPointer):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::linkJump): (JSC::AbstractMacroAssembler::linkCall): (JSC::AbstractMacroAssembler::linkPointer): (JSC::AbstractMacroAssembler::getLinkerAddress): (JSC::AbstractMacroAssembler::getLinkerCallReturnOffset): (JSC::AbstractMacroAssembler::repatchJump): (JSC::AbstractMacroAssembler::repatchCall): (JSC::AbstractMacroAssembler::repatchNearCall): (JSC::AbstractMacroAssembler::repatchInt32): (JSC::AbstractMacroAssembler::repatchPointer): (JSC::AbstractMacroAssembler::repatchLoadPtrToLEA):
    • remove the LinkBuffer/RepatchBuffer classes, but leave a set of (private, friended) methods to interface to the Assembler
  • assembler/LinkBuffer.h: Added. (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::~LinkBuffer): (JSC::LinkBuffer::link): (JSC::LinkBuffer::patch): (JSC::LinkBuffer::locationOf): (JSC::LinkBuffer::locationOfNearCall): (JSC::LinkBuffer::returnAddressOffset): (JSC::LinkBuffer::finalizeCode): (JSC::LinkBuffer::finalizeCodeAddendum): (JSC::LinkBuffer::code): (JSC::LinkBuffer::performFinalization):
    • new file containing the LinkBuffer class, previously a member of AbstractMacroAssembler
  • assembler/RepatchBuffer.h: Added. (JSC::RepatchBuffer::RepatchBuffer): (JSC::RepatchBuffer::relink): (JSC::RepatchBuffer::repatch): (JSC::RepatchBuffer::repatchLoadPtrToLEA): (JSC::RepatchBuffer::relinkCallerToTrampoline): (JSC::RepatchBuffer::relinkCallerToFunction): (JSC::RepatchBuffer::relinkNearCallerToTrampoline):
    • new file containing the RepatchBuffer class, previously a member of AbstractMacroAssembler
  • assembler/X86Assembler.h: (JSC::X86Assembler::linkJump): (JSC::X86Assembler::linkCall): (JSC::X86Assembler::linkPointerForCall): (JSC::X86Assembler::linkPointer): (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::setPointer): (JSC::X86Assembler::setInt32): (JSC::X86Assembler::setRel32):
    • rename patchPointer to bring it in line with the current link/repatch naming scheme
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
    • include new headers
    • remove MacroAssembler:: specification from RepatchBuffer usage
  • jit/JITPropertyAccess.cpp:
  • yarr/RegexJIT.cpp:
    • include new headers
5:08 PM Changeset in webkit [46201] by eric@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2009-07-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move m_context out of generator into a superclass
​https://bugs.webkit.org/show_bug.cgi?id=27521

Mostly this is removing code from CodeGeneratorJS
and instead using a DOMObjectWithSVGContext superclass in JSDOMBinding.h.

DOMObjectWithSVGContext.h is its own file so that WebKit doesn't need to
know about SVGElement.h (WebKit includes JSDOMBinding.h for some reason).

I also removed context pointer from SVGZoomEvent since it was never used.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMObjectWithSVGContext.h: Added. (WebCore::DOMObjectWithSVGContext::context): (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/scripts/CodeGeneratorJS.pm:
4:08 PM Changeset in webkit [46200] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r46142): editing/execCommand/19087.html & editing/execCommand/19653-1.html fail in Windows build
​https://bugs.webkit.org/show_bug.cgi?id=27480

Because m_anchorType : 2 is treated as a signed integer by cl.exe, anchorType() wasn't returning the correct value.
We made m_anchorType unsigned so that anchorType() returns the correct value.

  • dom/Position.h: (WebCore::Position::anchorType): statically cast to AnchorType
3:57 PM Changeset in webkit [46199] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

[V8] Add V8 bindings for onerror in WorkerContext.
​https://bugs.webkit.org/show_bug.cgi?id=27518

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
3:54 PM Changeset in webkit [46198] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Jian Li <​jianli@chromium.org>

Fix the incorrect patch being landed for bug 27516 that has already been reviewed.
​https://bugs.webkit.org/show_bug.cgi?id=27516

  • workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
  • workers/WorkerContext.idl:
3:44 PM Changeset in webkit [46197] by jianli@chromium.org
  • 4 edits in trunk/WebCore

2009-07-21 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

Add onerror to WorkerContext.
​https://bugs.webkit.org/show_bug.cgi?id=27516

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark):
  • workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
  • workers/WorkerContext.idl:
3:42 PM Changeset in webkit [46196] by treat@webkit.org
  • 1 edit
    8 adds in trunk/WebCore

2009-07-21 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=27509
Add font-related files for the WinCE port.

Written by Yong Li <​yong.li@torchmobile.com>

  • platform/graphics/wince/FontCacheWince.cpp: Added.
  • platform/graphics/wince/FontCustomPlatformData.cpp: Added.
  • platform/graphics/wince/FontCustomPlatformData.h: Added.
  • platform/graphics/wince/FontPlatformData.cpp: Added.
  • platform/graphics/wince/FontPlatformData.h: Added.
  • platform/graphics/wince/FontWince.cpp: Added.
  • platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Added.
  • platform/graphics/wince/SimpleFontDataWince.cpp: Added.
2:11 PM Changeset in webkit [46195] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Fix the Windows build, and update the comment on top now that wx uses WebCorePrefix.h too.

1:55 PM Changeset in webkit [46194] by kevino@webkit.org
  • 2 edits in trunk/WebCore

WebCorePrefix.h build fixes for non-Mac and wx / CURL builds.

1:52 PM Changeset in webkit [46193] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Missing header added.

1:45 PM Changeset in webkit [46192] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by David Levin.

We can't match implementation file and primary header exactly
since we have so many files in WebKit where the port suffix
is appended to the filename.

Example: FooQt.cpp and the primary header is Foo.h.

  • Scripts/modules/cpplint.py:
1:35 PM Changeset in webkit [46191] by eric@webkit.org
  • 16 edits in trunk/WebCore

2009-07-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject
​https://bugs.webkit.org/show_bug.cgi?id=27478

This is just moving code.
I've added two new classes: DOMObjectWithGlobalPointer and DOMConstructorWithDocument.

DOMObjectWithGlobalPointer is a new baseclass for DOMConstructorObject.
(It's a baseclass because eventually all DOMObjects will have a global pointer, but
I'll be moving them onto DOMObjectWithGlobalPointer in stages.)

DOMConstructorWithDocument is a new baseclass for the 3 constructor objects
which require a backpointer to the Document to function. I made this a subclass of
DOMConstructorObject to make clear that most constructors can hold no-such assumptions
about having a back-pointer to the Document (since many constructors can be used from Workers).

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::globalObject): (WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext): (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer): (WebCore::DOMObjectWithGlobalPointer::mark): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::DOMConstructorWithDocument::document): (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.h:
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
1:15 PM Changeset in webkit [46190] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Revert r46128.

1:06 PM Changeset in webkit [46189] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for switch statement indentation to cpplint.
​https://bugs.webkit.org/show_bug.cgi?id=27508

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:43 PM Changeset in webkit [46188] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Adam Treat.

Feature request: cpplint should check for braces - rule 2
​https://bugs.webkit.org/show_bug.cgi?id=27497

Add the requested feature: Make sure { is on the same line
as the foreach "keyword".

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:18 PM Changeset in webkit [46187] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-07-21 Robert Agoston <​Agoston.Robert@stud.u-szeged.hu>

Reviewed by David Levin.

Fixed #undef typo.
​https://bugs.webkit.org/show_bug.cgi?id=27506

  • bytecode/Opcode.h:
12:18 PM Changeset in webkit [46186] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 James Hawkins <​jhawkins@google.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=27453
Initialize isInt when creating a CSSParserValue for a function.

No change in behavior, so no tests.

  • css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::parserValue):
12:18 PM Changeset in webkit [46185] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-20 Jens Alfke <​snej@google.com>

Reviewed by David Levin.

Bug 27448: [Chromium] On Mac, arrow keys should cause Select to pop up its menu.
Mac build of Chromium doesn't follow Mac HI guidelines to pop up the menu when
an arrow key is pressed.
​https://bugs.webkit.org/show_bug.cgi?id=27448

No new tests; affects only control response to user input.

  • dom/SelectElement.cpp: Changed definition of ARROW_KEYS_POP_MENU to make it true in Mac Chromium, so it will behave compatibly with Mac HI guidelines on pop-up menus. It's not possible to have PLATFORM(MAC) be true in the Mac build of Chromium.
12:18 PM Changeset in webkit [46184] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Paul Godavari <​paul@chromium.org>

Reviewed by Eric Seidel.

[Chromium] popup menus can crash when the selected index is -1
​https://bugs.webkit.org/show_bug.cgi?id=27275

Crash reports from users indicate a crash can occur when PopupListBox::isSelectableItem
is passed an index of less than 0 (which is possible under certain circumstances). This
change prevents such a value from causing a crash by enforcing valid index values passed
by all callers of isSelectableItem. isSelectableItem is now a private method of
PopupListBox, as there are no external callers.

Also cleaned up a small amount of code for style and grammar errors.

No automatic test is provided since we cannot send events to the child window used by
the popup menu.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectPreviousRow):
12:00 PM Changeset in webkit [46183] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Don't include winsock2.h on wx, it conflicts with wx's inclusion of winsock.

11:21 AM Changeset in webkit [46182] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for namespace indentation to cpplint.
​https://bugs.webkit.org/show_bug.cgi?id=27461

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:16 AM Changeset in webkit [46181] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-20 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by David Levin.

Add cpplint check for proper include order
​https://bugs.webkit.org/show_bug.cgi?id=27462

Add a new check to cpplint to flag cases where the include section of a file
does not match the mandated include order and style of the Webkit coding style
guidelines.

Add associated tests.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:13 AM Changeset in webkit [46180] by Adam Roben
  • 13 edits
    2 deletes in trunk

Roll out r46153, r46154, and r46155

These changes were causing build failures and assertion failures on
Windows.

JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSArray.cpp:
  • runtime/StringPrototype.cpp:
  • runtime/UString.cpp:
  • runtime/UString.h:
  • wtf/FastMalloc.cpp:
  • wtf/FastMalloc.h:
  • wtf/Platform.h:
  • wtf/PossiblyNull.h: Removed.

WebCore:

  • ForwardingHeaders/wtf/PossiblyNull.h: Removed.
  • platform/graphics/cg/ImageBufferCG.cpp:
10:34 AM Changeset in webkit [46179] by jianli@chromium.org
  • 12 edits
    3 adds in trunk/WebCore

2009-07-21 Jian Li <​jianli@chromium.org>

Reviewed by Eric Seidel.

Implement ErrorEvent API.
​https://bugs.webkit.org/show_bug.cgi?id=27387

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/ErrorEvent.cpp: Added.
  • dom/ErrorEvent.h: Added.
  • dom/ErrorEvent.idl: Added.
  • dom/Event.cpp: (WebCore::Event::isErrorEvent):
  • dom/Event.h:
10:14 AM Changeset in webkit [46178] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Priit Laes <​plaes@plaes.org>

Reviewed by Gustavo Noronha.

[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
​https://bugs.webkit.org/show_bug.cgi?id=24602

Remove workaround required for <=libsoup-2.26.1

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:09 AM Changeset in webkit [46177] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

V8IsolatedWorld keeps a handle to a disposed context
​https://bugs.webkit.org/show_bug.cgi?id=27397

Make a copy of the context handle before making it weak. We don't want
to make the original handle weak because we want it to survive for the
length of the V8IsolatedWorld::evaluate method.

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
9:50 AM Changeset in webkit [46176] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add ability to evaluate selection while on break point.

​https://bugs.webkit.org/show_bug.cgi?id=27502

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._documentKeyDown):
9:42 AM Changeset in webkit [46175] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Special case ConsolePanel opening since
it is a 'fast view'.

​https://bugs.webkit.org/show_bug.cgi?id=27493

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
8:13 AM Changeset in webkit [46174] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wx build fix. Adding isSpeaking() to ContextMenuClientWx.

6:40 AM Changeset in webkit [46173] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

2009-07-21 Volker Hilsheimer <​volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

Various improvements to the API documentation.

  • Updated link to W3c Database spec
  • Formatting fixes, cleanups
  • Add missing \since 4.6 tags to QWebPage::frameAt
  • Extend QWebDatabase and QWebSecurityOrigin docs.
  • Api/qwebdatabase.cpp:
  • Api/qwebpage.cpp:
  • Api/qwebsecurityorigin.cpp:
  • Api/qwebview.cpp:
6:10 AM Changeset in webkit [46172] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-21 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Remove preliminary-tag from QWebElement

  • Api/qwebelement.cpp:
5:42 AM Changeset in webkit [46171] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2009-07-21 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Skip fast/loader/non-html-load-event.html for the Qt DRT as it requires
support for loading PDF documents.

  • platform/qt/Skipped:
5:02 AM Changeset in webkit [46170] by kenneth@webkit.org
  • 66 edits in trunk

WebCore:

2009-07-20 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Eric Seidel.

Fix Qt code to follow the WebKit Coding Style.

  • platform/graphics/qt/FontQt.cpp: (WebCore::qstring): (WebCore::fixSpacing):
  • platform/graphics/qt/FontQt43.cpp: (WebCore::generateComponents): (WebCore::Font::offsetForPositionForComplexText): (WebCore::cursorToX):
  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtFillRule): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getWindowsContext):
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::paint):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::ReadContext::read): (WebCore::ImageDecoderQt::ReadContext::readImageLines): (WebCore::ImageDecoderQt::setData):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameDurationAtIndex): (WebCore::ImageSource::frameHasAlphaAtIndex): (WebCore::ImageSource::frameIsCompleteAtIndex):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::updateStates):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo): (WebCore::Path::isEmpty):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::TransformationMatrix::operator QTransform):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::setDragImage): (WebCore::getCachedImage): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
  • platform/qt/ClipboardQt.h:
  • platform/qt/ContextMenuItemQt.cpp: (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title):
  • platform/qt/CursorQt.cpp: (WebCore::westPanningCursor): (WebCore::notAllowedCursor):
  • platform/qt/DragDataQt.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::asPlainText): (WebCore::DragData::asFragment):
  • platform/qt/DragImageQt.cpp: (WebCore::createDragImageIconForCachedImage):
  • platform/qt/FileSystemQt.cpp: (WebCore::getFileSize): (WebCore::unloadModule):
  • platform/qt/Localizations.cpp: (WebCore::contextMenuItemTagShowSpellingPanel):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::plainText):
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::fallbackStyle): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::applyTheme): (WebCore::WorldMatrixTransformer::WorldMatrixTransformer): (WebCore::RenderThemeQt::paintMediaBackground): (WebCore::RenderThemeQt::paintMediaFullscreenButton):
  • platform/qt/RenderThemeQt.h:
  • platform/qt/ScreenQt.cpp: (WebCore::screenRect): (WebCore::usableScreenRect):
  • platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::contextMenu):
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::scPart): (WebCore::scrollbarPart):
  • platform/qt/ScrollbarThemeQt.h:
  • platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/qt/TemporaryLinkStubs.cpp: (PluginDatabase::defaultPluginDirectories): (PluginDatabase::getPluginPathsInDirectories): (PluginDatabase::isPreferredPluginDirectory): (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): (WebCore::userIdleTime): (WebCore::prefetchDNS):
  • platform/text/qt/StringQt.cpp: (WebCore::String::String):
  • platform/text/qt/TextBoundaries.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::characterBreakIterator):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::userAgentStatic): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::init):

WebKit/qt:

2009-07-20 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Eric Seidel.

Fix Qt code to follow the WebKit Coding Style.

  • Api/qcookiejar.cpp: (QCookieJar::setCookieJar): (QCookieJar::cookieJar):
  • Api/qcookiejar.h:
  • Api/qwebdatabase.cpp: (QWebDatabase::QWebDatabase): (QWebDatabase::removeDatabase):
  • Api/qwebdatabase.h:
  • Api/qwebdatabase_p.h:
  • Api/qwebelement.h:
  • Api/qwebframe.cpp: (QWebFrame::title): (QWebFrame::print):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
  • Api/qwebhistory.cpp: (QWebHistory::clear):
  • Api/qwebhistory.h:
  • Api/qwebhistory_p.h:
  • Api/qwebhistoryinterface.cpp: (gCleanupInterface): (QWebHistoryInterface::setDefaultInterface): (QWebHistoryInterface::defaultInterface): (QWebHistoryInterface::QWebHistoryInterface):
  • Api/qwebhistoryinterface.h:
  • Api/qwebnetworkinterface.cpp: (QWebNetworkManager::started): (QWebNetworkManager::finished): (QWebNetworkInterfacePrivate::parseDataUrl): (QWebNetworkInterface::addJob): (WebCoreHttp::onResponseHeaderReceived): (WebCoreHttp::onReadyRead):
  • Api/qwebnetworkinterface.h:
  • Api/qwebnetworkinterface_p.h:
  • Api/qwebpage.cpp: (QWebPagePrivate::editorCommandForWebActions): (QWebPagePrivate::createContextMenu): (QWebPagePrivate::focusInEvent): (QWebPage::fixedContentsSize): (QWebPage::setContentEditable): (QWebPage::swallowContextMenuEvent): (QWebPage::findText):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • Api/qwebpluginfactory.h:
  • Api/qwebsecurityorigin.h:
  • Api/qwebsecurityorigin_p.h:
  • Api/qwebsettings.cpp: (QWebSettingsPrivate::QWebSettingsPrivate): (QWebSettingsPrivate::apply): (QWebSettings::globalSettings): (QWebSettings::QWebSettings): (QWebSettings::fontSize): (QWebSettings::setUserStyleSheetUrl): (QWebSettings::setDefaultTextEncoding): (QWebSettings::setIconDatabasePath): (QWebSettings::iconDatabasePath): (QWebSettings::iconForUrl): (QWebSettings::setWebGraphic): (QWebSettings::setFontFamily): (QWebSettings::fontFamily): (QWebSettings::testAttribute): (qt_websettings_setLocalStorageDatabasePath):
  • Api/qwebsettings.h:
  • Api/qwebview.cpp: (QWebView::setPage): (QWebView::event):
  • Api/qwebview.h:
4:05 AM Changeset in webkit [46169] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-21 Priit Laes <​plaes@plaes.org>

Reviewed by Holger Freyther.

[GTK+] Missing accelerator in authentication dialog
​https://bugs.webkit.org/show_bug.cgi?id=25509

Add accelerator to checkbox text.

  • WebKit/gtk/webkit/webkitsoupauthdialog.c: (show_auth_dialog):
3:51 AM Changeset in webkit [46168] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-21 Priit Laes <​plaes@plaes.org>

Reviewed by Holger Freyther.

[GTK] http auth dialog pops up twice after a cancelled atempt
​https://bugs.webkit.org/show_bug.cgi?id=24818

Remove workaround required for libsoup versions <=2.26.2 as we depend
on 2.27.4 now.

  • webkit/webkitsoupauthdialog.c: (session_authenticate):
3:41 AM Changeset in webkit [46167] by levin@chromium.org
  • 1 edit
    4 adds in trunk/WebCore

2009-07-21 Maxime Simon <Maxime Simon>

Reviewed by David Levin.

Added a first bunch of Haiku-specific files for WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=26988

  • platform/haiku/ClipboardHaiku.cpp: Added. (WebCore::ClipboardHaiku::ClipboardHaiku): (WebCore::ClipboardHaiku::clearData): (WebCore::ClipboardHaiku::clearAllData): (WebCore::ClipboardHaiku::getData): (WebCore::ClipboardHaiku::setData): (WebCore::ClipboardHaiku::types): (WebCore::ClipboardHaiku::files): (WebCore::ClipboardHaiku::dragLocation): (WebCore::ClipboardHaiku::dragImage): (WebCore::ClipboardHaiku::setDragImage): (WebCore::ClipboardHaiku::dragImageElement): (WebCore::ClipboardHaiku::setDragImageElement): (WebCore::ClipboardHaiku::createDragImage): (WebCore::ClipboardHaiku::declareAndWriteDragImage): (WebCore::ClipboardHaiku::writeURL): (WebCore::ClipboardHaiku::writeRange): (WebCore::ClipboardHaiku::hasData):
  • platform/haiku/ClipboardHaiku.h: Added. (WebCore::ClipboardHaiku::create): (WebCore::ClipboardHaiku::~ClipboardHaiku):
  • platform/haiku/CookieJarHaiku.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/haiku/CursorHaiku.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::pointerCursor): (WebCore::moveCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
3:35 AM Changeset in webkit [46166] by levin@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

Support lint for patches
​https://bugs.webkit.org/show_bug.cgi?id=27291

Add run-webkit-lint script, which lints recent changes in local
repository. Also, modified cpplint.py so that we don't need to
specify verbose level for process_file().

  • Scripts/modules/cpplint.py:
  • Scripts/run-webkit-lint: Added.
3:12 AM Changeset in webkit [46165] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-21 Albert Astals Cid <​aacid@kde.org>

Reviewed by Tor Arne Vestbø.

Change #error line not to have a ' (single quote)

  • DerivedSources.cpp:
3:12 AM Changeset in webkit [46164] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

diff_parser should accept lines without trailing \n
​https://bugs.webkit.org/show_bug.cgi?id=27483

Normalize the input lines by removing a trailing newline.
Also, add a case for unittest for newly added files.

  • Scripts/modules/diff_parser.py:
  • Scripts/modules/diff_parser_unittest.py:
3:12 AM Changeset in webkit [46163] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

cpplint.py's process_file() should accept customized error function
​https://bugs.webkit.org/show_bug.cgi?id=27487

  • Scripts/modules/cpplint.py:
2:53 AM Changeset in webkit [46162] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

cpplint.py should have an interface to get global error count
​https://bugs.webkit.org/show_bug.cgi?id=27486

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
2:53 AM Changeset in webkit [46161] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

cpplint's parse_argument should not exit even if no files are specified
​https://bugs.webkit.org/show_bug.cgi?id=27489

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
2:53 AM Changeset in webkit [46160] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-21 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

diff_parser: s/add_deleted_line/add_old_line/g
​https://bugs.webkit.org/show_bug.cgi?id=27484

  • Scripts/modules/diff_parser.py:
2:53 AM Changeset in webkit [46159] by levin@chromium.org
  • 17 edits in trunk

.:

2009-07-21 Roland Steiner <​rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
​https://bugs.webkit.org/show_bug.cgi?id=27324

  • configure.ac: Added flag ENABLE_RUBY.

JavaScriptCore:

2009-07-21 Roland Steiner <​rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
​https://bugs.webkit.org/show_bug.cgi?id=27324

  • Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebCore:

2009-07-21 Roland Steiner <​rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
​https://bugs.webkit.org/show_bug.cgi?id=27324

Added flag ENABLE_RUBY:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:

WebKit/mac:

2009-07-21 Roland Steiner <​rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
​https://bugs.webkit.org/show_bug.cgi?id=27324

  • Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebKit/win:

2009-07-21 Roland Steiner <​rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
​https://bugs.webkit.org/show_bug.cgi?id=27324

  • WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.

WebKitTools:

2009-07-21 Roland Steiner <​rolandsteiner@google.com>

Reviewed by David Levin.

Add ENABLE_RUBY to list of build options
​https://bugs.webkit.org/show_bug.cgi?id=27324

  • Scripts/build-webkit: Added flag ENABLE_RUBY.
2:53 AM Changeset in webkit [46158] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-21 James Hawkins <​jhawkins@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=27467
Return an empty path in PlatformContextSkia::currentPathInLocalCoordinates
if matrix.invert() fails. This prevents the use of an uninitialized
value in inverseMatrix.

No new tests added. Run
LayoutTests/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
under valgrind and notice there are no errors.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::currentPathInLocalCoordinates):
2:53 AM Changeset in webkit [46157] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-21 Stephen White <​senorblanco@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=27388

Fix dotted and dashed borders on Chromium/skia. This follows
the logic in the Cg path, so results are much closer to Safari now
(some tests won't be exactly the same due to font layout differences).

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
Note: See TracTimeline for information about the timeline view.