⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 23, 2009:

11:58 PM Changeset in webkit [46320] by eric@webkit.org
  • 17 edits in trunk

2009-07-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make most DOMObjects hold onto a JSDOMGlobalObject*
​https://bugs.webkit.org/show_bug.cgi?id=27588

inner.document.constructor is fixed because all properties on the window
object are created with the correct globalObject (instead of the lexical one).
Since all objects now carry a globalObject pointer, when document creates
HTMLDocumentConstructor it now has the right globalObject to use.

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:

2009-07-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make most DOMObjects hold onto a JSDOMGlobalObject*
​https://bugs.webkit.org/show_bug.cgi?id=27588

This change is almost entirely plumbing. Only one functional
change as part of this all (window.document.constructor has the correct prototype)
Changes are detailed below.

inner.document.constructor is fixed because all properties on the window
object are created with the correct globalObject (instead of the lexical one).
Since all objects now carry a globalObject pointer, when document creates
HTMLDocumentConstructor it now has the right globalObject to use.

Tests:

fast/dom/prototype-inheritance.html
fast/dom/prototype-inheritance-2.html

  • bindings/js/DOMObjectWithSVGContext.h: (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):

Update the comment and add an ignored globalObject argument.

  • bindings/js/JSDOMBinding.h:

Pass a globalObject to all DOMObjects during creation. Currently it's the wrong global object.
Once toJS is passed a globalObject it will be the right one.

(WebCore::createDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):

  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::globalObject): Makes binding generation easier.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): JSHistory is now passed a globalObject, but since it has no custom constructor it doesn't use it. (WebCore::JSDOMWindow::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
  • bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
  • bindings/js/JSHTMLCollectionCustom.cpp: Re-factoring needed to pass globalObject to JSNamedNodesCollection constructor. (WebCore::getNamedItems): (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSNamedNodesCollection.cpp:

Now passed globalObject. This is tested by inner.document.forms.testForm.
The passed globalObject is still wrong until toJS is fixed.

(WebCore::JSNamedNodesCollection::JSNamedNodesCollection):

  • bindings/js/JSNamedNodesCollection.h:
  • bindings/js/JSSharedWorkerConstructor.cpp:

Add DOMConstructorObject missed by ​http://trac.webkit.org/changeset/45938
This class is not compiled by default, so not testable.

(WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor):

  • bindings/js/JSSharedWorkerConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:

Make all bindings objects carry a globalObject pointer using DOMObjectWithGlobalPointer.
SVG bindings which need a context() pointer do not have enough space for globalObject() too.
WorkerContext does not need a globalObject (it is one), so special case it.
Make all .constructor calls use the stored globalObject(). This is what fixes window.document.constructor.
Make all constructors inherit from DOMConstructorObject for consistency. Since the auto-bound constructors
override createStructure anyway, there is no functional change here. Just completing work started in r45938.

11:50 PM Changeset in webkit [46319] by jmalonzo@webkit.org
  • 8 edits in trunk

2009-07-23 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Eric Seidel.

[Gtk] Add implementation of GCController for DRT
​https://bugs.webkit.org/show_bug.cgi?id=27636

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): (main):
  • DumpRenderTree/gtk/GCControllerGtk.cpp: (GCController::collect): (GCController::collectOnAlternateThread):

Enable tests that are now passing.

  • platform/gtk/Skipped:

Add SPI for GCController to use.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_gc_collect_javascript_objects): (webkit_gc_collect_javascript_objects_on_alternate_thread): (webkit_gc_count_javascript_objects):
11:37 PM Changeset in webkit [46318] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-07-23 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Add new test to cover more prototype/constructor inheritance cases
​https://bugs.webkit.org/show_bug.cgi?id=27622

This new test tries hard not to duplicate testing done
by other tests and instead test new objects and prototype chains
which will be fixed as soon as toJS is passed through the globalObject.

This test crawls the object tree under the inner window, finding
one of each type of JavaScript object. It depends on all objects having
a valid prototype chain with a unique name (which is not always the case).
The test tries to stress the cases where the objects would be lazily
creating other objects or their prototypes or constructors which would
require these objects to have a back-pointer to the globalObject to be
able to correctly wire up the prototype chains.

  • fast/dom/prototype-inheritance-2-expected.txt: Added.
  • fast/dom/prototype-inheritance-2.html: Added.
  • fast/dom/resources/prototype-inheritance-2.js: Added. (propertiesOnObject): (): (constructorNamesForWindow): (makeCrawlObject): (evalToCrawlObject): (pushPropertyValuesWithUnseenTypes): (crawl):
11:03 PM Changeset in webkit [46317] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-23 Jan Michael Alonzo <​jmalonzo@webkit.org>

Skip transitions/change-values-during-transition.html which
pass/fails intermittently

  • platform/gtk/Skipped:
10:49 PM Changeset in webkit [46316] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-23 Jan Michael Alonzo <​jmalonzo@webkit.org>

Skip tests that require expected outputs. Also skip failing tests,
with bugs raised against the failures.

  • platform/gtk/Skipped:
10:26 PM Changeset in webkit [46315] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two new tests for GTK that use eventSender.

  • platform/gtk/Skipped:
10:10 PM Changeset in webkit [46314] by mrowe@apple.com
  • 39 edits in trunk/LayoutTests

Fix layout tests that incorrectly attempt to detect whether they're running inside DumpRenderTree using "if (layoutTestController)".

Rubber-stamped by Brady Eidson.

  • editing/execCommand/25256.html:
  • editing/execCommand/25320.html:
  • fast/canvas/arc-crash.html:
  • fast/css/emptyStyleTag.html:
  • fast/events/js-keyboard-event-creation.html:
  • fast/events/scrollbar-double-click.html:
  • fast/forms/select-no-name.html:
  • fast/history/window-open.html:
  • platform/mac/fast/events/objc-event-api.html:
  • platform/mac/fast/events/objc-keyboard-event-creation.html:
  • scrollbars/scrollbar-miss-mousemove-disabled.html:
  • scrollbars/scrollbar-miss-mousemove.html:
  • storage/domstorage/localstorage/clear.html:
  • storage/domstorage/localstorage/delete-removal.html:
  • storage/domstorage/localstorage/enumerate-storage.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/onstorage-attribute-markup.html:
  • storage/domstorage/localstorage/onstorage-attribute-setattribute.html:
  • storage/domstorage/localstorage/private-browsing-affects-storage.html:
  • storage/domstorage/localstorage/resources/window-open-second.html:
  • storage/domstorage/localstorage/simple-events.html:
  • storage/domstorage/localstorage/simple-usage.html:
  • storage/domstorage/localstorage/string-conversion.html:
  • storage/domstorage/localstorage/window-open.html:
  • storage/domstorage/sessionstorage/clear.html:
  • storage/domstorage/sessionstorage/delete-removal.html:
  • storage/domstorage/sessionstorage/enumerate-storage.html:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/onstorage-attribute-markup.html:
  • storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html:
  • storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
  • storage/domstorage/sessionstorage/resources/window-open-second.html:
  • storage/domstorage/sessionstorage/simple-events.html:
  • storage/domstorage/sessionstorage/simple-usage.html:
  • storage/domstorage/sessionstorage/string-conversion.html:
  • storage/domstorage/sessionstorage/window-open.html:
  • storage/domstorage/window-attributes-exist.html:
  • svg/custom/stop-crash.svg:
9:59 PM Changeset in webkit [46313] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

And now with some valid JavaScript syntax!

  • http/tests/misc/redirect-to-about-blank.html:
9:51 PM Changeset in webkit [46312] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Remove unnecessary check for eventSender in an attempt to please the GTK build bot.

  • fast/css/getComputedStyle/getComputedStyle-text-overflow.html:
9:35 PM Changeset in webkit [46311] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Update build.webkit.org config for new machine.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
9:32 PM Changeset in webkit [46310] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Add a workaround for <rdar://problem/6925892> to the test that it affects.

Reviewed by Brady Eidson.

  • http/tests/misc/redirect-to-about-blank.html:
8:56 PM Changeset in webkit [46309] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-23 Brady Eidson <​beidson@apple.com>

Remove accidentally checked in code.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (waitUntilDoneWatchdogFired): (LayoutTestController::setWaitToDump):
8:00 PM Changeset in webkit [46308] by beidson@apple.com
  • 14 edits
    3 adds in trunk

WebCore:

2009-07-23 Brady Eidson <​beidson@apple.com>

Reviewed by Geoff Garen.

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
​https://bugs.webkit.org/show_bug.cgi?id=27595

Test: http/tests/misc/will-send-request-returns-null-on-redirect.html


  • inspector/InspectorController.cpp: (WebCore::InspectorController::removeResource): Null-check the request URL.


  • platform/network/cf/ResourceHandleCFNet.cpp: Ditto, and return null instead of creating an empty one. (WebCore::willSendRequest):

WebKit/win:

2009-07-23 Brady Eidson <​beidson@apple.com>

Reviewed by Geoff Garen.

WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest.
​https://bugs.webkit.org/show_bug.cgi?id=27595

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchWillSendRequest):

WebKitTools:

2009-07-23 Brady Eidson <​beidson@apple.com>

Reviewed by Geoff Garen.

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
​https://bugs.webkit.org/show_bug.cgi?id=27595

Add the ability to tell the LayoutTestController to return a null request for willSendRequest
redirect callbacks.


  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setWillSendRequestReturnsNullOnRedirectCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::willSendRequestReturnsNullOnRedirect): (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest):

LayoutTests:

2009-07-23 Brady Eidson <​beidson@apple.com>

Reviewed by Geoff Garen.

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
​https://bugs.webkit.org/show_bug.cgi?id=27595

  • http/tests/misc/resources/redirect-to-http-url.php: Added.
  • http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
  • http/tests/misc/will-send-request-returns-null-on-redirect.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
7:54 PM Changeset in webkit [46307] by pdherbemont@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

2009-07-23 Pierre d'Herbemont <​pdherbemont@apple.com>

Fix layout tests, no review.

Actually add the video-layer tests results for leopard, that were
forgotten in r46302. Also add test results for windows.

  • platform/mac-leopard/fast/layers/video-layer-expected.png: Added.
  • platform/mac-leopard/fast/layers/video-layer-expected.txt: Added.
  • platform/win/fast/layers/video-layer-expected.txt: Added.
7:38 PM Changeset in webkit [46306] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

7:38 PM Changeset in webkit [46305] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.8

New tag.

7:14 PM Changeset in webkit [46304] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix DumpRenderTree to not fail an assertion on launch on a new machine.

Reviewed Oliver Hunt.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting): Disable the XSS auditor. It being enabled
breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString,
which causes us to exit due to an assertion failure. It's not clear why the XSS auditor
decides to interfere with these tests.

6:40 PM Changeset in webkit [46303] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46246.

5:55 PM Changeset in webkit [46302] by pdherbemont@apple.com
  • 4 edits
    1 copy
    1 add in trunk/LayoutTests

2009-07-23 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

Following changes on the video controls, video-layer tests results need to
be updated in order to fix the layout tests.

  • platform/mac-leopard/fast/layers/video-layer-expected.checksum: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.checksum.
  • platform/mac-leopard/fast/layers/video-layer-expected.png: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.png.
  • platform/mac-leopard/fast/layers/video-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.txt.
  • platform/mac/fast/layers/video-layer-expected.checksum: Removed.
  • platform/mac/fast/layers/video-layer-expected.png: Removed.
  • platform/mac/fast/layers/video-layer-expected.txt: Updated.
5:35 PM Changeset in webkit [46301] by Chris Fleizach
  • 2 edits in trunk/WebCore

Bug 27633 - AXLoadComplete can be fired off to frequently
​https://bugs.webkit.org/show_bug.cgi?id=27633

5:11 PM Changeset in webkit [46300] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-07-23 Darin Adler <Darin Adler>

  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Landed a comment I forgot last time.
5:09 PM Changeset in webkit [46299] by mrowe@apple.com
  • 3 edits
    1 copy
    1 move in trunk/LayoutTests

Update layout test results for three tests related to text fields as their metrics
have changed slightly since the results were last updated.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Copied from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
  • platform/mac/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
5:09 PM Changeset in webkit [46298] by Darin Adler
  • 5 edits in trunk

WebCore:

2009-07-23 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

URL appears in back/forward button menu instead of title for items with custom representation
​https://bugs.webkit.org/show_bug.cgi?id=27586
rdar://problem/5060337

  • WebCore.base.exp: Exported DocumentLoader::setTitle for use by Mac WebKit.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didChangeTitle): Tightened code to check if the document loader is the correct one; previously this would never happen because we'd commit the load before any title changes could be registered, but now we can encounter a case where we get a title during a provisional load.

WebKit/mac:

2009-07-23 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

URL appears in back/forward button menu instead of title for items with custom representation
​https://bugs.webkit.org/show_bug.cgi?id=27586
rdar://problem/5060337

The problem is that DocumentLoader expects to store a title, but for custom representations
it is never passed to the document loader.

  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Added a call to DocumentLoader::setTitle. Works as long as the title does not change during the document's lifetime, which is good enough for the simple cases in Safari.
4:44 PM Changeset in webkit [46297] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows
in hopes of fixing some layout test failures seen on the build bot.

Reviewed by Oliver Hunt.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

4:08 PM Changeset in webkit [46296] by mrowe@apple.com
  • 1 edit
    2 copies in trunk/LayoutTests

Windows appears to match the Leopard results for the CSS 2.1 counter tests that were failing.

  • platform/win/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt.
  • platform/win/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt.
4:00 PM Changeset in webkit [46295] by mitz@apple.com
  • 17 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

[CSS3 Backgrounds and Borders] Add support for inset box shadows
​https://bugs.webkit.org/show_bug.cgi?id=27582

Test: fast/box-shadow/inset.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): Set the ShadowValue’s shadow style to 'inset'

as needed.

  • css/CSSParser.cpp: (WebCore::ShadowParseContext::ShadowParseContext): Added style and allowStyle

members. Initialize the allowStyle member.

(WebCore::ShadowParseContext::commitValue): Pass the style value to the

ShadowValue constructor. Reset allowStyle.

(WebCore::ShadowParseContext::commitLength): Update allowStyle.
(WebCore::ShadowParseContext::commitColor): Ditto.
(WebCore::ShadowParseContext::commitStyle): Added. Sets the style member and

updates the state.

(WebCore::CSSParser::parseShadow): Parse the 'inset' keyword.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Get the style value from the

shadow value and pass it to the ShadowData constructor.

  • css/ShadowValue.cpp: (WebCore::ShadowValue::ShadowValue): Added style. (WebCore::ShadowValue::cssText): Added style.
  • css/ShadowValue.h: (WebCore::ShadowValue::create): Added style.
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): Added a blend function for shadow styles. When blending

between normal and inset shadows, all intermediate values map to normal.

(WebCore::PropertyWrapperShadow::blend): Added normal style to the default

shadow.


  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxShadow): Added a shadow style parameter,

which is passed through to RenderBoxModelObject::paintBoxShadow().

(WebCore::InlineFlowBox::paintBoxDecorations): Paint inset shadows on top of

the background.

  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Paint inset shadows on top of the

background.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Added a shadow style

parameter, and code to paint inset shadows.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): Paint inset shadows on top of

the background.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): Ditto.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations): Ditto.
  • rendering/style/ShadowData.h: Added a ShadowStyle enum. (WebCore::ShadowData::ShadowData): Add and initialize a style member.

LayoutTests:

Reviewed by Dave Hyatt.

[CSS3 Backgrounds and Borders] Add support for inset box shadows
​https://bugs.webkit.org/show_bug.cgi?id=27582

  • fast/box-shadow/inset.html: Added.
  • platform/mac/fast/box-shadow/inset-expected.checksum: Added.
  • platform/mac/fast/box-shadow/inset-expected.png: Added.
  • platform/mac/fast/box-shadow/inset-expected.txt: Added.
3:53 PM Changeset in webkit [46294] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-23 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix false positives for switch statement indentation check in cpplint.
​https://bugs.webkit.org/show_bug.cgi?id=27615

Makes one-line case statements (e.g. "case foo: bar();") work.
Also a few general improvements to the robustness and readability of
the check, and more test cases.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
3:52 PM Changeset in webkit [46293] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-07-23 Simon Fraser <Simon Fraser>

Fix the build with UNUSED_PARAM(frame) for when ENABLE(3D_RENDERING) is not defined.

  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
3:49 PM Changeset in webkit [46292] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-23 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Add check for line-breaking rule #3 to cpplint.
​https://bugs.webkit.org/show_bug.cgi?id=27610

"An else if statement should be written as an if statement when
the prior if concludes with a return statement."

Implemented by a multi-line (kind of back-tracking) algorithm.
Comes with loads of unit tests. Fixes the check for label indentation
to be not so overzealous, as it didn't allow for completely unindented
goto labels (at the very start of a line).

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
3:37 PM Changeset in webkit [46291] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-07-23 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

3d-transforms media query needs to look check that accelerated compositing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=27621

When evaluating a media query with '-webkit-transform-3d', we need to check the
runtime switch that toggles accererated compositing, and therefore 3D.

No test because we can't disable the pref dynamically in DRT.

  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
3:31 PM Changeset in webkit [46290] by mrowe@apple.com
  • 3 edits
    1 copy
    2 moves in trunk/LayoutTests

Update layout test results for two international text tests that are failing due to font differences.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.checksum.
  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.png.
  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.txt.
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/thai-baht-space-expected.txt:
3:13 PM Changeset in webkit [46289] by mrowe@apple.com
  • 3 edits
    2 copies in trunk/LayoutTests

Update layout test results for two CSS 2.1 counter tests that are failing due to font differences.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
  • platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
  • platform/mac/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-04-b-expected.txt:
3:03 PM Changeset in webkit [46288] by pdherbemont@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-23 Pierre d'Herbemont <​pdherbemont@apple.com>

Layout test fix so no review.

Add audio-controls-rendering layout test results for windows and leopard.

  • platform/mac-leopard/media/audio-controls-rendering-expected.txt: Added.
  • platform/win/media/audio-controls-rendering-expected.txt: Added.
2:40 PM Changeset in webkit [46287] by mrowe@apple.com
  • 10 edits in trunk/LayoutTests

Update layout test results for the addition of a new computed style property in r46285.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:17 PM Changeset in webkit [46286] by rniwa@webkit.org
  • 6 edits
    3 adds in trunk

WebCore:

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline') can't remove <U> underlines
​https://bugs.webkit.org/show_bug.cgi?id=20215

This patch adds support for u, s, and strike to implicitlyStyledElementShouldBeRemovedWhenApplyingStyle so that
WebKit can remove those presentational tags when necessary.
It also modifies StyleChange::init not to add "text-decoration: none". Not only is this style meaningless
(does not override inherited styles) but it was also causing WebKit to generate extra spans with this style.

  • css/CSSValueList.cpp: (WebCore::CSSValueList::hasValue): True if the property contains the specified value
  • css/CSSValueList.h: Updated prototype
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): No longer adds "text-decoration: none" (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): Supports text-decoration-related elements

LayoutTests:

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline') can't remove <U> underlines
​https://bugs.webkit.org/show_bug.cgi?id=20215

This patch rebaselines toggle-styles.html because WebKit now passes three tests it used to fail.
toggle-style-2.html is added to test cases in which multiple styles are specified with tags.
We still fail some tests because WebKit doesn't properly support non-CSS mode but they are visually correct.

  • editing/execCommand/resources/toggle-style-2.js: Added. (testSingleToggle): (testDoubleToggle):
  • editing/execCommand/toggle-style-2-expected.txt: Added.
  • editing/execCommand/toggle-style-2.html: Added.
  • editing/execCommand/toggle-styles-expected.txt: Passes all the tests
2:03 PM Changeset in webkit [46285] by jberlin@apple.com
  • 3 edits
    2 adds in trunk

2009-07-23 Jessie Berlin <​jberlin@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=27554
Expose the value of text-overflow in getComputedStyle.


Reviewed by Dan Bernstein.

Test: fast/css/getComputedStyle/getComputedStyle-text-overflow.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): Add text-overflow to the list of computedProperties. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return the value of the text-overflow property.
  • fast/css/getComputedStyle/getComputedStyle-text-overflow-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-overflow.html: Added.
1:48 PM Changeset in webkit [46284] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-23 Yongjun Zhang <​yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=27510

[S60 QtWebKit] Don't put some intermediate generated files into the final mmp project
file for linking. This is a temporary workaround for qmake bug in Symbian port, should
be reverted after qmake is fixed.

  • WebCore.pro:
1:37 PM Changeset in webkit [46283] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-07-23 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

[V8] Fix an assert in running workers in Chrome.
​https://bugs.webkit.org/show_bug.cgi?id=27620

The fix is to change V8DOMMap::removeAllDOMObjectsInCurrentThreadHelper
to do not call removeObjectsFromWrapperMap for certain types of DOM
objects that exist only in main thread.

  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
12:24 PM Changeset in webkit [46282] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-23 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by David Hyatt.

Rebaseline for ​http://trac.webkit.org/changeset/46274
(The changeset rebaselined the expected results for mac but not for windows)

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
12:06 PM Changeset in webkit [46281] by hyatt@apple.com
  • 11 edits
    5 adds in trunk

WebCore:

2009-07-23 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=27572
Implement support for background-attachment:local.

Added new test fast/overflow/overflow-with-local-attachment.html.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseFillProperty):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFillAttachment):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapFillAttachment):
  • css/CSSValueKeywords.in:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  • rendering/style/FillLayer.h: (WebCore::FillLayer::attachment): (WebCore::FillLayer::setAttachment): (WebCore::FillLayer::hasFixedImage): (WebCore::FillLayer::initialFillAttachment):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::backgroundAttachment): (WebCore::InheritedFlags::maskAttachment):
  • rendering/style/RenderStyleConstants.h: (WebCore::):

LayoutTests:

2009-07-23 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=27572
Implement support for background-attachment:local.

Added new test fast/overflow/overflow-with-local-attachment.html.

  • fast/overflow/overflow-with-local-background-attachment.html: Added.
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum: Added.
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
11:55 AM Changeset in webkit [46280] by rniwa@webkit.org
  • 8 edits in trunk/WebCore

2009-07-23 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

copyInheritableProperties and removeComputedInheritablePropertiesFrom should be deprecated
​https://bugs.webkit.org/show_bug.cgi?id=27325

This patch deprecates copyInheritableProperties because it has been used for two different purposes:

  1. Calculating the typing style.
  2. Moving HTML subtrees and seeking to remove redundant styles. These tasks should be broken out into two separate functions. New code should not use this function.

It deletes removeComputedInheritablePropertiesFrom because it hasn't been used anywhere.

There is no test since the patch does not change any behavior.

  • css/CSSComputedStyleDeclaration.cpp: removeComputedInheritablePropertiesFrom has been removed (WebCore::CSSComputedStyleDeclaration::deprecatedCopyInheritableProperties): has been renamed from copyInheritableProperties
  • css/CSSComputedStyleDeclaration.h: ditto
  • editing/DeleteSelectionCommand.cpp: ditto (WebCore::removeEnclosingAnchorStyle): ditto (WebCore::DeleteSelectionCommand::saveTypingStyleState): ditto
  • editing/EditCommand.cpp: ditto (WebCore::EditCommand::styleAtPosition): ditto
  • editing/RemoveFormatCommand.cpp: ditto (WebCore::RemoveFormatCommand::doApply): ditto
  • editing/ReplaceSelectionCommand.cpp: ditto (WebCore::handleStyleSpansBeforeInsertion): ditto (WebCore::ReplaceSelectionCommand::handleStyleSpans): ditto
  • editing/markup.cpp: ditto (WebCore::removeEnclosingMailBlockquoteStyle): ditto (WebCore::removeDefaultStyles): ditto (WebCore::createMarkup): ditto
11:42 AM Changeset in webkit [46279] by pdherbemont@apple.com
  • 7 edits in trunk

WebCore:

2009-07-22 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

Audio element at default width shouldn't have time field.
​https://bugs.webkit.org/show_bug.cgi?id=27589

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimeDisplayElement::setVisible): Make sure we don't forget to remember the visibility if there is no renderer.

LayoutTests:

2009-07-22 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

Audio element at default width shouldn't have time field.
​https://bugs.webkit.org/show_bug.cgi?id=27589

  • platform/mac-snowleopard/Skipped: Enables back audio-controls-rendering.
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
11:29 AM Changeset in webkit [46278] by kenneth@webkit.org
  • 1 edit
    18 adds in trunk/LayoutTests

2009-07-23 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Adam Treat.

Added expected results for tests that we pass.

  • platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
  • platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
  • platform/qt/fast/box-shadow/transform-fringing-expected.txt: Added.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
  • platform/qt/fast/css/attribute-selector-dynamic-expected.txt: Added.
  • platform/qt/fast/css/nth-child-dynamic-expected.txt: Added.
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
  • platform/qt/fast/dynamic/anchor-lock-expected.txt: Added.
  • platform/qt/fast/frames/frameset-style-recalc-expected.txt: Added.
  • platform/qt/fast/frames/iframe-text-contents-expected.txt: Added, equal to mac.
  • platform/qt/fast/frames/viewsource-on-image-file-expected.txt: Added.
  • platform/qt/fast/repaint/background-generated-expected.txt: Added, equal to mac.
  • platform/qt/fast/repaint/background-misaligned-expected.txt: Added, equal to mac.
  • platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added, equal to mac.
  • platform/qt/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.txt: Added.
11:21 AM Changeset in webkit [46277] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix, adding missing header.

11:10 AM Changeset in webkit [46276] by Beth Dakin
  • 3 edits in trunk/WebCore

2009-07-23 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=27598 Clean up the
AccessibilityObject class

Mostly this is just moving empty stubs into the header rather than
muddying the cpp file with them. A few functions were made pure
virtual.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isARIAControl): (WebCore::AccessibilityObject::clickPoint): (WebCore::AccessibilityObject::documentFrameView): (WebCore::AccessibilityObject::actionVerb):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::intValue): (WebCore::AccessibilityObject::layoutCount): (WebCore::AccessibilityObject::doAccessibilityHitTest): (WebCore::AccessibilityObject::focusedUIElement): (WebCore::AccessibilityObject::firstChild): (WebCore::AccessibilityObject::lastChild): (WebCore::AccessibilityObject::previousSibling): (WebCore::AccessibilityObject::nextSibling): (WebCore::AccessibilityObject::parentObjectIfExists): (WebCore::AccessibilityObject::observableObject): (WebCore::AccessibilityObject::linkedUIElements): (WebCore::AccessibilityObject::titleUIElement): (WebCore::AccessibilityObject::ariaRoleAttribute): (WebCore::AccessibilityObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren): (WebCore::AccessibilityObject::roleValue): (WebCore::AccessibilityObject::ariaAccessiblityName): (WebCore::AccessibilityObject::ariaLabeledByAttribute): (WebCore::AccessibilityObject::ariaDescribedByAttribute): (WebCore::AccessibilityObject::accessibilityDescription): (WebCore::AccessibilityObject::ariaSelectedTextDOMRange): (WebCore::AccessibilityObject::axObjectCache): (WebCore::AccessibilityObject::axObjectID): (WebCore::AccessibilityObject::setAXObjectID): (WebCore::AccessibilityObject::anchorElement): (WebCore::AccessibilityObject::actionElement): (WebCore::AccessibilityObject::boundingBoxRect): (WebCore::AccessibilityObject::selectedTextRange): (WebCore::AccessibilityObject::selectionStart): (WebCore::AccessibilityObject::selectionEnd): (WebCore::AccessibilityObject::url): (WebCore::AccessibilityObject::selection): (WebCore::AccessibilityObject::stringValue): (WebCore::AccessibilityObject::title): (WebCore::AccessibilityObject::helpText): (WebCore::AccessibilityObject::textUnderElement): (WebCore::AccessibilityObject::text): (WebCore::AccessibilityObject::textLength): (WebCore::AccessibilityObject::selectedText): (WebCore::AccessibilityObject::accessKey): (WebCore::AccessibilityObject::widget): (WebCore::AccessibilityObject::widgetForAttachmentView): (WebCore::AccessibilityObject::setFocused): (WebCore::AccessibilityObject::setSelectedText): (WebCore::AccessibilityObject::setSelectedTextRange): (WebCore::AccessibilityObject::setValue): (WebCore::AccessibilityObject::setSelected): (WebCore::AccessibilityObject::makeRangeVisible): (WebCore::AccessibilityObject::childrenChanged): (WebCore::AccessibilityObject::addChildren): (WebCore::AccessibilityObject::hasChildren): (WebCore::AccessibilityObject::selectedChildren): (WebCore::AccessibilityObject::visibleChildren): (WebCore::AccessibilityObject::visiblePositionRange): (WebCore::AccessibilityObject::visiblePositionRangeForLine): (WebCore::AccessibilityObject::boundsForVisiblePositionRange): (WebCore::AccessibilityObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityObject::visiblePositionForPoint): (WebCore::AccessibilityObject::nextVisiblePosition): (WebCore::AccessibilityObject::previousVisiblePosition): (WebCore::AccessibilityObject::visiblePositionForIndex): (WebCore::AccessibilityObject::indexForVisiblePosition): (WebCore::AccessibilityObject::index): (WebCore::AccessibilityObject::doAXRangeForLine): (WebCore::AccessibilityObject::doAXRangeForIndex): (WebCore::AccessibilityObject::doAXStringForRange): (WebCore::AccessibilityObject::doAXBoundsForRange): (WebCore::AccessibilityObject::updateBackingStore):
11:05 AM Changeset in webkit [46275] by bweinstein@apple.com
  • 4 edits in trunk/WebCore

Fix of <rdar://4877658> Dragging from the area between the horizontal/vertical scrollbars when status bar is showing starts a selection and autoscroll.

10:20 AM Changeset in webkit [46274] by hyatt@apple.com
  • 10 edits in trunk

WebCore:

2009-07-23 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=27581
Drop the prefix from the box-shadow property.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::ShadowParseContext::commitLength): (WebCore::cssPropertyID):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):

LayoutTests:

2009-07-23 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein.


​https://bugs.webkit.org/show_bug.cgi?id=27581
Drop the prefix from the box-shadow property.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
9:55 AM Changeset in webkit [46273] by treat@webkit.org
  • 4 edits
    4 adds in trunk

WebCore:
2009-07-22 Viet-Trung Luu <​viettrungluu@gmail.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=27289
When a mouse click occurs on a scrollbar without a preceding mouse move
onto it, the release isn't handled correctly (since
EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
only on mouse move). (Side comment: That scrollbar-handling code
in EventHandler is ugly. It should be fixed properly.)

Tests: scrollbars/scrollbar-miss-mousemove.html

scrollbars/scrollbar-miss-mousemove-disabled.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateLastScrollbarUnderMouse):
  • page/EventHandler.h:

LayoutTests:
2009-07-22 Viet-Trung Luu <​viettrungluu@gmail.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=27289
Tests that mouse clicks/releases are handled properly on scrollbars
even when there is no mouse move onto the scrollbar (two cases: enabled
and disabled controls).

  • scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
  • scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
  • scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
  • scrollbars/scrollbar-miss-mousemove.html: Added.
9:52 AM Changeset in webkit [46272] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-23 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by David Levin.

Update WebCore/page/BarInfo.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
​https://bugs.webkit.org/show_bug.cgi?id=27606

  • page/BarInfo.cpp: (WebCore::BarInfo::visible):
9:52 AM Changeset in webkit [46271] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-23 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by David Levin.

Update WebCore/page/Console.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
​https://bugs.webkit.org/show_bug.cgi?id=27606

  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): (WebCore::Console::profile): (WebCore::Console::time):
9:32 AM Changeset in webkit [46270] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-23 Eli Fidler <​eli.fidler@torchmobile.com>

Reviewed by Adam Treat.

Improve git workflow by populating commit messages with ChangeLog entries.
​https://bugs.webkit.org/show_bug.cgi?id=27605

add --[no-]write option to optionally output new ChangeLog entries to
stdout instead of modifying ChangeLog files

fix Torch Mobile copyright

  • Scripts/prepare-ChangeLog:
9:13 AM Changeset in webkit [46269] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-23 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Enable cpplint for .c files.
​https://bugs.webkit.org/show_bug.cgi?id=27604

Also make sure that the check for NULL does not apply to .c files.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
8:51 AM Changeset in webkit [46268] by treat@webkit.org
  • 1 edit
    3 adds in trunk/JavaScriptCore

2009-07-22 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

Add wince specific memory files into wtf/wince
​https://bugs.webkit.org/show_bug.cgi?id=27550

  • wtf/wince/FastMallocWince.h: Added.
  • wtf/wince/MemoryManager.cpp: Added.
  • wtf/wince/MemoryManager.h: Added.
7:31 AM Changeset in webkit [46267] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-07-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Add simple proxy support for QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=27495

Picks up proxy settings from the http_proxy environment
variable.

  • QtLauncher/QtLauncher.pro: Add QtNetwork dependency for all platforms.
  • QtLauncher/main.cpp: (MainWindow::MainWindow):
7:28 AM Changeset in webkit [46266] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-07-23 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Fix for missing mmap features in Symbian
​https://bugs.webkit.org/show_bug.cgi?id=24540

Fix, conditionally for PLATFORM(SYMBIAN), as an alternative
to missing support for the MAP_ANON property flag in mmap.
It utilizes Symbian specific memory allocation features.

  • runtime/Collector.cpp
6:34 AM Changeset in webkit [46265] by Simon Hausmann
  • 6 edits in trunk

WebCore:

2009-07-23 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Fix crashes with the QObject bindings after garbage collection.

There is one QtInstance per wrapped QObject, and that QtInstance keeps
references to cached JSObjects for slots. When those objects get
deleted due to GC, then they becoming dangling pointers.

When a cached member dies, it is now removed from the QtInstance's
cache.

As we cannot track the lifetime of the children, we have to remove
them from QtInstance alltogether. They are not cached and were
only used for mark(), but we _want_ them to be subject to gc.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::~QtInstance): Minor coding style cleanup, use qDeleteAll(). (JSC::Bindings::QtInstance::removeCachedMethod): New function, to clean m_methods and m_defaultMethod. (JSC::Bindings::QtInstance::mark): Avoid marking already marked objects. (JSC::Bindings::QtField::valueFromInstance): Don't save children for marking.
  • bridge/qt/qt_instance.h: Declare removeCachedMethod.
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod): Call removeCachedMethod with this on the instance.

WebKit/qt:

2009-07-23 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Added a testcase to verify that cached methods in the QOBject bindings
remain alife even after garbage collection.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):
3:24 AM Changeset in webkit [46264] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-07-23 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Fixing two issues related to QtLauncher

  • MainWindow objects are not always freed after close
  • JavaScript window.close() sometimes crashes

​https://bugs.webkit.org/show_bug.cgi?id=27601

  • QtLauncher/main.cpp: (MainWindow::MainWindow): (main):
3:20 AM Changeset in webkit [46263] by Simon Hausmann
  • 3 edits in trunk/LayoutTests

2009-07-23 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Rebaseline the Qt results for computed-style.html and
computed-style-without-rendered.html after r46240, similar to r46252.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
2:57 AM Changeset in webkit [46262] by levin@chromium.org
  • 5 edits in trunk/LayoutTests

2009-07-23 David Levin <​levin@chromium.org>

Rubber-stamped by Oliver Hunt.

Improve keyboard navigation of Select elements.
Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
on non-Mac platforms.
​https://bugs.webkit.org/show_bug.cgi?id=22784

One more round of speculative fixes:

  • Really fix the general and win expected results. (They were missing a return.)
  • Disable the test for gtk (and remove the attempted workaround for that platform).
  • fast/forms/select-popup-pagekeys-expected.txt:
  • fast/forms/select-popup-pagekeys.html:
  • platform/gtk/Skipped:
  • platform/win/fast/forms/select-popup-pagekeys-expected.txt:
2:09 AM Changeset in webkit [46261] by levin@chromium.org
  • 3 edits
    1 copy in trunk/LayoutTests

2009-07-23 David Levin <​levin@chromium.org>

Rubber-stamped by Oliver Hunt.

3 (speculative) fixes for the new layout test: select-popup-pagekeys

  • Help Windows to pass by adding platform results.
  • Fix the general expected results.
  • Fix select-popup-pagekeys on gtk which doesn't seem to implement eventSender.
  • fast/forms/select-popup-pagekeys-expected.txt:
  • fast/forms/select-popup-pagekeys.html:
  • platform/win/fast/forms/select-popup-pagekeys-expected.txt: Added.
1:01 AM Changeset in webkit [46260] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=27599
'const unsigned' in return value

Remove const modifier from unsigned return value, as it does not
make sense.

  • dom/ErrorEvent.h:
12:52 AM Changeset in webkit [46259] by levin@chromium.org
  • 3 edits
    3 adds in trunk

2009-07-22 Jens Alfke <​snej@chromium.org>

Reviewed by David Levin.

Bug 22784: Improve keyboard navigation of Select elements.
Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
on non-Mac platforms.
​https://bugs.webkit.org/show_bug.cgi?id=22784
​http://code.google.com/p/chromium/issues/detail?id=4576

WebCore:

New test: LayoutTests/fast/forms/select-popup-pagekeys.html

  • dom/SelectElement.cpp: (WebCore::nextValidIndex): New utility fn for traversing items of a select's list. (WebCore::SelectElement::menuListDefaultEventHandler): Added code to handle Home/End and PageUp/PageDn when ARROW_KEYS_POP_MENU is false.

LayoutTests:

  • LayoutTests/fast/forms/select-popup-pagekeys.html: Added.
  • LayoutTests/fast/forms/select-popup-pagekeys-expected.txt: Added
  • LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt: Added.
12:36 AM Changeset in webkit [46258] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-07-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix a couple of compiler warnings.

  • platform/graphics/cairo/ImageBufferCairo.cpp: (copySurface):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::containsCharacters):
12:19 AM Changeset in webkit [46257] by Simon Hausmann
  • 4 edits in trunk

WebCore:

2009-07-22 Simon Hausmann <​simon.hausmann@nokia.com>

Rubber-stamped by David Levin.

Enable HTML5 Datagrid defines for the Qt build.

  • WebCore.pro:

LayoutTests:

2009-07-22 Simon Hausmann <​simon.hausmann@nokia.com>

Rubber-stamped by David Levin.

Unskip HTML 5 Datagrid tests for the Qt DRT, as they pass.

  • platform/qt/Skipped:
12:00 AM Changeset in webkit [46256] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-22 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix compiler warning.

  • tests/testwebsettings.c: (test_webkit_web_settings_user_agent):

Jul 22, 2009:

11:45 PM WebDevelopers edited by dbates@berkeley.edu
Removed outdated links to Safari version matrix, and FAQ. (diff)
11:32 PM Changeset in webkit [46255] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

[V8] Make Node wrappers go fast
​https://bugs.webkit.org/show_bug.cgi?id=27597

Profiles indicate we're spending a lot of time asking whether we're on
the main thread when looking up DOM wrappers for Nodes, but there isn't
much point in doing that work because Nodes only exist on the main
thread. I've also added an assert to keep us honest in this regard.

  • bindings/v8/V8DOMMap.cpp: (WebCore::): (WebCore::getDOMNodeMap): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread):
10:39 PM Changeset in webkit [46254] by sfalken@apple.com
  • 1 edit
    6 adds in trunk/WebKitTools

Checkpoint new Windows nightly launcher.


Reviewed by Mark Rowe.

  • WebKitLauncherWin: Added.
  • WebKitLauncherWin/Resource.h: Added.
  • WebKitLauncherWin/WebKitLauncherWin.cpp: Added. (getStringValue): Retrieve a string registry value. (applePathFromRegistry): Get an Apple-related path out of the registry. (copyEnvironmentVariable): Copy an environment variable. (safariInstallDir): Helper function to get the install directory for Safari. (safariBrowserExe): Helper function to get the full path of the Safari executable. (_tWinMain): Locate Safari and launch it after setting up an environment variable.
  • WebKitLauncherWin/WebKitLauncherWin.h: Added.
  • WebKitLauncherWin/WebKitLauncherWin.rc: Added.
  • WebKitLauncherWin/WebKitLauncherWin.vcproj: Added.
  • WebKitLauncherWin/webkit.ico: Added.
7:52 PM Changeset in webkit [46253] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove unneeded virtual destructor from ScriptSourceProvider
​https://bugs.webkit.org/show_bug.cgi?id=27563

  • bindings/js/ScriptSourceProvider.h:
7:29 PM Changeset in webkit [46252] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adam Barth.

REGRESSION (r46240): /fast/css/getComputedStyle/computed-style & computed-style-without-renderer needs rebaseline for Windows
​https://bugs.webkit.org/show_bug.cgi?id=27591

Rebaselines the tests.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
7:01 PM Changeset in webkit [46251] by rniwa@webkit.org
  • 7 edits
    8 adds in trunk

WebCore:

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=27476

executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
and adds removeAll member function to CSSValueList.

Tests: editing/execCommand/toggle-text-decorations.html

fast/css/getComputedStyle/getComputedStyle-text-decoration.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
  • css/CSSValueList.cpp: (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
  • css/CSSValueList.h:
  • editing/EditorCommand.cpp: (WebCore::applyCommandToFrame): Apply style to a frame using specified command (WebCore::executeApplyStyle): Uses applyCommandToFrame (WebCore::executeToggleStyleInList): Uses applyCommandToFrame (WebCore::executeToggleStyle): Toggles a style in CSSValueList (WebCore::executeStrikethrough): Uses executeToggleStyleInList (WebCore::executeUnderline): Uses executeToggleStyleInList

LayoutTests:

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=27476

toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"

getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.

  • editing/execCommand/resources/toggle-text-decorations.js: Added. (testSingleToggle):
  • editing/execCommand/toggle-text-decorations-expected.txt: Added.
  • editing/execCommand/toggle-text-decorations.html: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
  • fast/css/getComputedStyle/resources: Added.
  • fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
  • fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added. (expect):
4:27 PM Changeset in webkit [46250] by abarth@webkit.org
  • 4 edits
    9 adds in trunk

2009-07-22 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27174
And
​https://bugs.webkit.org/show_bug.cgi?id=26938

Tests prevention of attacks transformed by PHP Magic Quotes/PHP addslashes().

  • http/tests/security/xssAuditor/resources/echo-intertag-addslashes.pl: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html: Added.

2009-07-22 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27174
And
​https://bugs.webkit.org/show_bug.cgi?id=26938

Code cleanup. Implements support for detecting attacks transformed by
PHP Magic Quotes/PHP addslashes().

Tests: http/tests/security/xssAuditor/script-tag-addslashes-backslash.html

http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html
http/tests/security/xssAuditor/script-tag-addslashes-null-char.html
http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html

  • page/XSSAuditor.cpp: (WebCore::isInvalidCharacter): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::normalize): Decodes HTML entities, removes backslashes, and removes control characters that could otherwise cause a discrepancy between the source code of a script and the outgoing HTTP parameters. (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::decodeHTMLEntities): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:
3:48 PM Changeset in webkit [46249] by levin@chromium.org
  • 1 edit
    1 move in trunk/WebKitTools

2009-07-22 David Levin <​levin@chromium.org>

Reviewed by Adam Treat.

run-webkit-lint should be named check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=27568

This name better reflects the fact that it is about checking the style of files.

  • Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint.
3:31 PM Changeset in webkit [46248] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix false positives in namespace indentation checks.
​https://bugs.webkit.org/show_bug.cgi?id=27567

The regular expression detecting goto labels (in order
to skip those) was too permissive, which caused other
code like "Foo::Bar()" to be treated as a label too,
thereby not stopping the processing loop as expected.

Now comes with a stricter regexp, and more demanding
test cases to check for these issues.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
3:17 PM Changeset in webkit [46247] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

2009-07-22 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam Weinig.

With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once per repatch event.
( ​https://bugs.webkit.org/show_bug.cgi?id=27564 )

Currently we change permissions forwards and backwards for each instruction modified,
instead we should only change permissions once per complete repatching event.

2.5% progression running with ENABLE(ASSEMBLER_WX_EXCLUSIVE) enabled,
which recoups 1/3 of the penalty of running with this mode enabled.

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::linkBranch):
    • Replace usage of MakeWritable with cacheFlush.


  • assembler/ARMAssembler.h: (JSC::ARMAssembler::patchPointerInternal): (JSC::ARMAssembler::repatchLoadPtrToLEA):
    • Replace usage of MakeWritable with cacheFlush.
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::relinkJump): (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer): (JSC::ARMv7Assembler::repatchLoadPtrToLEA): (JSC::ARMv7Assembler::setInt32):
    • Replace usage of MakeWritable with cacheFlush.
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::performFinalization):
    • Make explicit call to cacheFlush.
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
    • Make size always available.
  • assembler/RepatchBuffer.h: (JSC::RepatchBuffer::RepatchBuffer): (JSC::RepatchBuffer::~RepatchBuffer):
    • Add calls to MakeWritable & makeExecutable.
  • assembler/X86Assembler.h: (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::repatchLoadPtrToLEA):
    • Remove usage of MakeWritable.
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getJITCode):
    • Provide access to CodeBlock's JITCode.
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeExecutable): (JSC::ExecutableAllocator::cacheFlush):
    • Remove MakeWritable, make cacheFlush public.
  • jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompile): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
    • Add CodeBlock argument to RepatchBuffer.
  • jit/JIT.h:
    • Pass CodeBlock argument for use by RepatchBuffer.
  • jit/JITCode.h: (JSC::JITCode::start): (JSC::JITCode::size):
    • Provide access to code start & size.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
    • Add CodeBlock argument to RepatchBuffer.
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
    • Pass CodeBlock argument for use by RepatchBuffer.
3:12 PM Changeset in webkit [46246] by oliver@apple.com
  • 2 edits in trunk/WebCore

Null deref in JSObject::mark due to null xhr wrapper
​https://bugs.webkit.org/show_bug.cgi?id=27565

Reviewed by Adele Peterson.

Make event target binding for appcache and xhr behave in the same way as
it does for all other events.

No test as I couldn't make a testcase which was remotely reliable.

3:10 PM Changeset in webkit [46245] by levin@chromium.org
  • 4 edits in trunk

2009-07-22 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Adler.

VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
​https://bugs.webkit.org/show_bug.cgi?id=26375

WebKit/win:

Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
with hex escape sequences.

VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
treated as an error and stopped build).

WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
represented in the current code page (932). Save the file in Unicode format to prevent data loss

A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
localized string generation process.

  • WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):

WebKitTools:

Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now,
the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals
in the macros before writing out them into the file to update.

By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian
strings in the Localizable.strings file.

Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide
users to update-webkit-localizable-strings.

  • Scripts/extract-localizable-strings:
3:09 PM Changeset in webkit [46244] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <​hamaji@google.com>

Reviewed by David Levin.

Tiny typo fixes for cpplint.py
​https://bugs.webkit.org/show_bug.cgi?id=27530

  • Scripts/modules/cpplint.py:
3:09 PM Changeset in webkit [46243] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

run-webkit-lint checks code which are not changed
​https://bugs.webkit.org/show_bug.cgi?id=27529

Add check if the line is newly added.

  • Scripts/run-webkit-lint:
3:09 PM Changeset in webkit [46242] by levin@chromium.org
  • 4 edits in trunk/WebKitTools

2009-07-22 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

run-webkit-lint should have --git-commit option
​https://bugs.webkit.org/show_bug.cgi?id=27528

  • Scripts/modules/cpplint.py:
  • Scripts/run-webkit-lint:
3:09 PM Changeset in webkit [46241] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Mads Ager <​ager@chromium.org>

Reviewed by David Levin.

Inform V8 of the amount of WebCore string memory it is keeping alive.
​https://bugs.webkit.org/show_bug.cgi?id=27537

V8 uses external strings that are backed by WebCore strings. Since
the external strings themselves are small, V8 has no way of
knowing how much memory it is actually holding on to. With this
change, we inform V8 of the amount of WebCore string data it is
holding on to with external strings.

  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource):
2:59 PM Changeset in webkit [46240] by hyatt@apple.com
  • 15 edits
    12 adds in trunk

WebCore:

2009-07-22 David Hyatt <​hyatt@apple.com>

Reviewed by Beth Dakin.

​https://bugs.webkit.org/show_bug.cgi?id=27562
Add the finalized versions of background-clip and background-origin. Remove background-clip from
the background shorthand and have it be auto-set based off background-origin's value.

Three new tests added in fast/backgrounds/size

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseFillProperty):
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:

LayoutTests:

2009-07-22 David Hyatt <​hyatt@apple.com>

Reviewed by Beth Dakin.

​https://bugs.webkit.org/show_bug.cgi?id=27562
Add some new layout tests that drop the prefix from the background properties and use origin
in a shorthand. Update shorthand results and computed style results to account for new properties.

  • fast/backgrounds/size/backgroundSize20.html: Added.
  • fast/backgrounds/size/backgroundSize21.html: Added.
  • fast/backgrounds/size/backgroundSize22.html: Added.
  • fast/css/background-position-serialize-expected.txt:
  • fast/css/remove-shorthand-expected.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/inspector/style-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:47 PM Changeset in webkit [46239] by jorlow@chromium.org
  • 16 edits
    3 adds in trunk

WebCore:

2009-07-22 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

Hook up V8 bindings for DataGrid elements.
​https://bugs.webkit.org/show_bug.cgi?id=27383
​http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • WebCore.gypi: Added new source files.
  • bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
  • bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
  • bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates. (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
  • bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::V8DataGridDataSource): (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
  • bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::create): (WebCore::V8DataGridDataSource::isJSDataGridDataSource): (WebCore::V8DataGridDataSource::jsDataSource): (WebCore::asV8DataGridDataSource):
  • bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
  • bindings/v8/V8Index.h: Conditionalize datagrid stuff.
  • bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):

LayoutTests:

2009-07-22 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

Hook up V8 bindings for DataGrid elements.
​https://bugs.webkit.org/show_bug.cgi?id=27383
​http://code.google.com/p/chromium/issues/detail?id=16730

Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
1:46 PM Changeset in webkit [46238] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2009-07-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

pushDownTextDecorationStyleAroundNode needs clean up
​https://bugs.webkit.org/show_bug.cgi?id=27556

Cleaned up. pushDownTextDecorationStyleAroundNode traverses tree vertically from highestAncestor to targetNode
While traversing, it will apply the specified style to all nodes but targetNode.
i.e. the style is applies to all ancestor nodes and their siblings of targetNode.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Cleaned up and added comments
  • editing/ApplyStyleCommand.h: Updated prototype
1:35 PM Changeset in webkit [46237] by pkasting@chromium.org
  • 4 edits in trunk/WebCore

2009-07-22 Peter Kasting <​pkasting@google.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any type of line endings in WebCore/css/*CSSPropertyNames.in.

  • DerivedSources.make:
  • css/makeprop.pl:
  • css/makevalues.pl:
1:32 PM Changeset in webkit [46236] by pkasting@chromium.org
  • 4 edits in trunk/WebKitTools

2009-07-22 Peter Kasting <​pkasting@google.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=27323
Factor svn-create-patch's "determineSvnRoot()" into a function in
VCSUtils.pm so commit-log-editor can use it too.

  • Scripts/VCSUtils.pm: Add determineSVNRoot().
  • Scripts/commit-log-editor: Use determineSVNRoot() instead of old code (which didn't work as well).
  • Scripts/svn-create-patch: Remove determineSvnRoot() (moved).
1:18 PM Changeset in webkit [46235] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

Revert bugfix for 27557 as this is invalid according to Darin Adler
who states that include order sorting should be case-sensitive.

1:06 PM Changeset in webkit [46234] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-22 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

expand prototype-inheritance test to cover constructors
​https://bugs.webkit.org/show_bug.cgi?id=27547

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/resources/prototype-inheritance.js:
1:05 PM Changeset in webkit [46233] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Case-insensitive comparison of include file order for cpplint.
​https://bugs.webkit.org/show_bug.cgi?id=27557

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
1:00 PM Changeset in webkit [46232] by ggaren@apple.com
  • 5 edits
    1 add in branches/nitro-extreme/WebCore

2009-07-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some trivial differences between the branch and r45633, to
facilitate the merge.

  • bindings/js/ScriptEventListener.cpp:
  • bridge/c/c_instance.cpp:
  • inspector/front-end/Images/resourcesSilhouette.png: Added.
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::paintObject):
  • rendering/RenderDataGrid.h:
12:51 PM Changeset in webkit [46231] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Fix cpplint generating false positives for
"primary" includes in headers.
​https://bugs.webkit.org/show_bug.cgi?id=27553

Doing so by only flagging includes in header files
as primary when the include filename exactly matches
the header filename.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
12:24 PM Changeset in webkit [46230] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-22 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

cpplint generates false positives for primary includes
​https://bugs.webkit.org/show_bug.cgi?id=27544

Fix false positives for instances when cpplint would
normally classify multiple includes as primary: After
the first primary include, classify subsequent ones as
"other" includes even if they look like primary ones.

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
11:55 AM Changeset in webkit [46229] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Paul Godavari <​paul@chromium.org>

Reviewed by Darin Fisher.

Chromium has a build break after removal of JSRGBColor bindings
​https://bugs.webkit.org/show_bug.cgi?id=27548

Fix a build break in Chromium V8 after the JSRGBColor bindings change:
​https://bugs.webkit.org/show_bug.cgi?id=27242

  • bindings/scripts/CodeGeneratorV8.pm:
11:46 AM Changeset in webkit [46228] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2009-07-22 Gabor Rapcsanyi <​rapcsanyi.gabor@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Pass XAUTHORITY environment variable to $dumpTool as well.

  • Scripts/run-webkit-tests:
10:02 AM Changeset in webkit [46227] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-07-20 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r39185): Safari adds ".jpeg" extension to images that already have ".JPG" extension
​https://bugs.webkit.org/show_bug.cgi?id=27472

  • WebView/WebHTMLView.mm: (matchesExtensionOrEquivalent): Changed category method into a C function. Made it require the leading dot when checking for the extension and do it in a non-case-sensitive way. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Changed to call the function.
9:56 AM Changeset in webkit [46226] by agl@chromium.org
  • 3 edits in trunk/WebCore

2009-07-22 Adam Langley <​agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: add static functions to FontPlatformData which allow
for setting the global font rendering preferences.

​https://bugs.webkit.org/show_bug.cgi?id=27513
​http://code.google.com/p/chromium/issues/detail?id=12179

This should not affect any layout tests.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setHinting): (WebCore::FontPlatformData::setAntiAlias): (WebCore::FontPlatformData::setSubpixelGlyphs): (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/FontPlatformDataLinux.h:
8:20 AM Changeset in webkit [46225] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Add check for correct wtf includes to cpplint.
​https://bugs.webkit.org/show_bug.cgi?id=27524

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
8:15 AM Changeset in webkit [46224] by treat@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-21 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by David Levin.

Add checks for multi-line boolean operator placement.
​https://bugs.webkit.org/show_bug.cgi?id=27496

  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
7:13 AM Changeset in webkit [46223] by zecke@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-22 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam Treat.

Mention the new webkit-help and webkit-jobs mailinglist. Change
the description of webkit-dev to be more strict.

  • contact.html:
6:34 AM Changeset in webkit [46222] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-22 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Move Inspector panels creation into a function to make possible introducing
custom panels.

6:33 AM Changeset in webkit [46221] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-22 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove unused variables.

  • webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event):
6:30 AM Changeset in webkit [46220] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Print console command message upon evaluate
selection request; Handle errors in evaluation request
properly.

​https://bugs.webkit.org/show_bug.cgi?id=27535

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
6:04 AM Changeset in webkit [46219] by kenneth@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-22 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Adam Treat.

Coding style - Clarify some cases with spacing
​https://bugs.webkit.org/show_bug.cgi?id=27499

Add explicit rule about no space before comma or semicolon.

  • coding/coding-style.html:
12:47 AM WebKit Team edited by rniwa@webkit.org
(diff)
12:46 AM WebKit Team edited by rniwa@webkit.org
(diff)
12:17 AM Changeset in webkit [46218] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Xan Lopez <​xlopez@igalia.com>

Attempt to fix the GTK+ build.

  • GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.