⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 25, 2009:

3:14 PM Changeset in webkit [46401] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-25 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Eric Seidel.

Allow custom memory allocation control for OpaqueJSPropertyNameArray struct
​https://bugs.webkit.org/show_bug.cgi?id=27342

Inherits OpaqueJSPropertyNameArray struct from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/API/JSObjectRef.cpp:473.

  • API/JSObjectRef.cpp:
3:11 PM Changeset in webkit [46400] by abarth@webkit.org
  • 2 edits in trunk

Fixup ChangeLog.

3:00 PM Changeset in webkit [46399] by abarth@webkit.org
  • 5 edits
    4 adds in trunk

2009-07-16 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Oliver Hunt.

Canvas: rotation of 'no-repeat' pattern still has small error
​https://bugs.webkit.org/show_bug.cgi?id=26749

Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.

Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.

  • fast/canvas/image-pattern-rotate.html: Added.
  • platform/mac/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/mac/fast/canvas/image-object-in-canvas-expected.png:
  • platform/mac/fast/canvas/image-pattern-rotate-expected.checksum: Added.
  • platform/mac/fast/canvas/image-pattern-rotate-expected.png: Added.
  • platform/mac/fast/canvas/image-pattern-rotate-expected.txt: Added.

2009-07-16 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Oliver Hunt.

Canvas: rotation of 'no-repeat' pattern still has small error
​https://bugs.webkit.org/show_bug.cgi?id=26749

Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.

Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.

Test: fast/canvas/image-pattern-rotate.html

  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
2:36 PM Changeset in webkit [46398] by abarth@webkit.org
  • 7 edits in trunk

2009-07-25 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Windows build break due to warning C4819
​https://bugs.webkit.org/show_bug.cgi?id=27416

Disable C4819 warning to fix build.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:

2009-07-25 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Windows build break due to warning C4819
​https://bugs.webkit.org/show_bug.cgi?id=27416

Disable C4819 warning to fix build.

  • WebKit.vcproj/WebKit.vcproj:

2009-07-25 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Windows build break due to warning C4819
​https://bugs.webkit.org/show_bug.cgi?id=27416

Disable C4819 warning to fix build.

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2:34 PM Changeset in webkit [46397] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-25 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Kevin McCullough.

Inspector: Keyboard Shortcuts to Switch Panels
​https://bugs.webkit.org/show_bug.cgi?id=27286

  • inspector/front-end/inspector.js: (WebInspector.loaded): save a list of the order of the panels (WebInspector.documentKeyDown): handle the keyboard shortcuts to traverse the panels
2:29 PM Changeset in webkit [46396] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-25 Laszlo Gombos <Laszlo Gombos>

Reviewed by George Staikos.

[Qt] Fix build break after r46369
​https://bugs.webkit.org/show_bug.cgi?id=27680

  • WebCore.pro:
9:43 AM Changeset in webkit [46395] by Nikolas Zimmermann
  • 8 edits
    4 adds in trunk

2009-07-25 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution is buggy
​https://bugs.webkit.org/show_bug.cgi?id=27677

Substitute variables upon attach() time instead of insertedIntoDocument(). Otherwhise variable substitution
won't work during inter-deck jumps (same URL, different fragment). Covered by new test fast/wml/newcontext-same-deck.html.

  • dom/Text.cpp: (WebCore::Text::attach):
  • dom/Text.h:

2009-07-25 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Variable substitution is buggy
​https://bugs.webkit.org/show_bug.cgi?id=27677

Always substitute variables regardless of their existance. If a variable doesn't exist, expand it to an empty string.
Correct several testcases, relying on the old buggy behaviour.

  • wml/newcontext-same-deck-expected.txt: Added.
  • wml/newcontext-same-deck.html: Added.
  • wml/resources/WMLTestCase.js: (createWMLTestCase.iframeElement.onload): (createWMLTestCase): (assureLayout): (startTest): (triggerMouseEvent):
  • wml/resources/newcontext-same-deck.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/newcontext-same-deck.wml: Added.
  • wml/resources/select-element-variables.js: (prepareTest):
  • wml/select-element-variables-expected.txt:
  • wml/variable-reference-invalid-character-expected.txt:
9:35 AM Changeset in webkit [46394] by Nikolas Zimmermann
  • 10 edits in trunk

2009-07-25 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] WMLDoElement doesn't update its RenderButton object upon attach()
​https://bugs.webkit.org/show_bug.cgi?id=27676

WMLDoElement needs to implement attach() and call updateFromElement() on its associated RenderButton.
Mimics HTMLButtonElement/HTMLFormControlElement behaviour and fixes several painting/styling issues covered by existing tests in fast/wml.

  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::attach):
  • wml/WMLDoElement.h:

2009-07-25 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] WMLDoElement doesn't update its RenderButton object upon attach()
​https://bugs.webkit.org/show_bug.cgi?id=27676

Update layout test results after fixing WMLDoElement::attach() not calling updateFromElement().

  • platform/mac/fast/wml/do-element-optional-attr-expected.txt:
  • platform/mac/fast/wml/do-shadow-expected.txt:
  • platform/mac/fast/wml/do-template-expected.txt:
  • platform/mac/fast/wml/err-invalid-location-for-varref-expected.txt:
  • platform/mac/fast/wml/err-invalid-variable-name-expected.txt:
  • platform/mac/fast/wml/err-samename-do-expected.txt:
9:23 AM Changeset in webkit [46393] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2009-07-25 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Make http/tests/wml/post-data-to-server.* more understable
​https://bugs.webkit.org/show_bug.cgi?id=27675

Slightly cleanup this patch so it's easier to figure out what the expected result for <select> element is.

  • http/tests/wml/post-data-to-server-expected.txt:
  • http/tests/wml/resources/post-data-to-server.js: (setupTestDocument): (prepareTest):
2:51 AM Changeset in webkit [46392] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-07-25 Pavel Feldman <​pfeldman@chromium.org>

Fix Windows build breakage introduced in 46390.

  • WebCore.vcproj/WebCore.vcproj:
2:44 AM Changeset in webkit [46391] by oliver@apple.com
  • 3 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Oliver Hunt.

Inspector: Properties Should be Sorted more Naturally
​https://bugs.webkit.org/show_bug.cgi?id=27329

  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): use the displaySort when showing properties (WebInspector.ObjectPropertiesSection.prototype._displaySort): alphaNumerical sort (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): use the displaySort when showing properties
  • inspector/front-end/utilities.js: (Object.sortedProperties): allow for an optional sorting function in Object.sortedProperties
2:22 AM Changeset in webkit [46390] by pfeldman@chromium.org
  • 22 edits
    3 moves
    2 adds in trunk/WebCore

2009-07-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Split InspectorController into InspectorController
and InspectorBackend. Everything frontend needs from InspectorController
will slowly migrate into the InspectorBackend.

​https://bugs.webkit.org/show_bug.cgi?id=27541

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSInspectorBackendCustom.cpp: Added. (WebCore::JSInspectorBackend::highlightDOMNode): (WebCore::JSInspectorBackend::search): (WebCore::JSInspectorBackend::databaseTableNames): (WebCore::JSInspectorBackend::inspectedWindow): (WebCore::JSInspectorBackend::setting): (WebCore::JSInspectorBackend::setSetting): (WebCore::JSInspectorBackend::wrapCallback): (WebCore::JSInspectorBackend::currentCallFrame): (WebCore::JSInspectorBackend::profiles):
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/js/JSInspectorControllerCustom.cpp: Removed.
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/ScriptObject.h:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/ScriptObject.h:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::windowScriptObjectAvailable):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorBackend):
  • inspector/InspectorBackend.cpp: Added.
  • inspector/InspectorBackend.h: Added. (WebCore::InspectorBackend::create): (WebCore::InspectorBackend::inspectorController):
  • inspector/InspectorBackend.idl: Added.
  • inspector/InspectorController.idl: Removed.
  • inspector/front-end/Resource.js:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h:
12:47 AM Changeset in webkit [46389] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-25 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by George Staikos.

Update WebCore/page/Frame.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
​https://bugs.webkit.org/show_bug.cgi?id=27654

  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::setDocument): (WebCore::Frame::firstRectForRange): (WebCore::createRegExpForLabels): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::setZoomFactor): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionStartStylePropertyValue): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::selectionBounds): (WebCore::Frame::currentForm): (WebCore::Frame::revealSelection): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::clearFormerDOMWindow): (WebCore::Frame::unfocusWindow): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::documentAtPoint):
  • page/Frame.h: (WebCore::Frame::create): (WebCore::Frame::displayStringModifiedByEncoding): (WebCore::Frame::pageZoomFactor): (WebCore::Frame::textZoomFactor):

Jul 24, 2009:

8:50 PM Changeset in webkit [46388] by mitz@apple.com
  • 21 edits in trunk/WebCore

Reviewed by Darin Adler.

Add functions to print the glyph page trees for debugging
​https://bugs.webkit.org/show_bug.cgi?id=27671

  • platform/graphics/FontData.h: Defined a description() method.
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::showSubtree): Added. Prints the node and

its descendants.

(showGlyphPageTrees): Added. Prints all glyph page trees.
(showGlyphPageTree): Added. Prints the glyph page tree for a given page.

  • platform/graphics/GlyphPageTreeNode.h:
  • platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::description): Added.
  • platform/graphics/SegmentedFontData.h:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::description): Added. Uses the platform data

as the description for non-svg, non-custom fonts.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/gtk/FontPlatformData.h:
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::description): Added. Returns the

description of the CGFont, the size and the synthetic style flags,
if set.

  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/win/FontPlatformData.h:
  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::description): Added. Returns a null string.
6:49 PM Changeset in webkit [46387] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

In preparation for ​https://bugs.webkit.org/show_bug.cgi?id=27236:
Remove TCMALLOC_TRACK_DECOMMITED_SPANS. We'll always track decommitted spans.
We have tested this and show it has little impact on performance.

Reviewed by Mark Rowe.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::New): (WTF::TCMalloc_PageHeap::AllocLarge): (WTF::propagateDecommittedState): (WTF::mergeDecommittedStates): (WTF::TCMalloc_PageHeap::Delete): (WTF::TCMalloc_PageHeap::IncrementalScavenge):
6:13 PM Changeset in webkit [46386] by Nikolas Zimmermann
  • 2 edits in trunk/WebKitTools

Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py

5:57 PM Changeset in webkit [46385] by Darin Adler
  • 1 edit in trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm

Dorument?

5:56 PM Changeset in webkit [46384] by Darin Adler
  • 3 edits in trunk/WebKit/mac

2009-07-24 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

REGRESSION (r46298): Exception after clicking on Bookmarks button in the Bookmarks Bar
​https://bugs.webkit.org/show_bug.cgi?id=27667

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Moved the code to set the title here. This is late enough that both the view and representation exist.
  • WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Removed the code to set the title from here. It's a bit too early.
4:46 PM Changeset in webkit [46383] by abarth@webkit.org
  • 23 edits in trunk/WebCore

2009-07-24 Mads Ager <​ager@chromium.org>

Reviewed by Adam Barth.

SVG and XPath memory leaks in V8 bindings
​https://bugs.webkit.org/show_bug.cgi?id=27488

Add proper 'create' methods to SVGPodTypeWrappers and
XPathNSResolvers in the V8 bindings to avoid memory leaks.

Introduce convertToV8Object methods that accept PassRefPtrs and
clean up the use of get() and release() on RefPtrs.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object):
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGPODTypeWrapperCreatorForList::create): (WebCore::V8SVGPODTypeWrapperCreatorForList::V8SVGPODTypeWrapperCreatorForList): (WebCore::V8SVGStaticPODTypeWrapper::create): (WebCore::V8SVGStaticPODTypeWrapper::V8SVGStaticPODTypeWrapper): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithPODTypeParent::V8SVGStaticPODTypeWrapperWithPODTypeParent): (WebCore::V8SVGStaticPODTypeWrapperWithParent::create): (WebCore::V8SVGStaticPODTypeWrapperWithParent::V8SVGStaticPODTypeWrapperWithParent): (WebCore::V8SVGDynamicPODTypeWrapper::create): (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper): (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ClientRectListCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp: (WebCore::V8CustomXPathNSResolver::create):
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
4:35 PM Changeset in webkit [46382] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test that is failing intermittently on the Windows build bot.

  • platform/win/Skipped:
4:26 PM Changeset in webkit [46381] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip a plug-in test that fails an assertion around 50% of the time.

  • platform/mac-snowleopard/Skipped:
4:02 PM Changeset in webkit [46380] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two SVG tests that are giving unexpected results.

  • platform/mac-snowleopard/Skipped:
3:45 PM UsingGitWithWebKit edited by treat@kde.org
(diff)
3:45 PM Changeset in webkit [46379] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two plug-in tests that are failing.

  • platform/mac-snowleopard/Skipped:
3:31 PM BuildingQtOnWindows edited by jpetso@gmx.at
Fix inconsistent instruction vs. corresponding explanation (paths were … (diff)
3:28 PM BuildingQtOnWindows edited by jpetso@gmx.at
I followed the guidelines here, and it seems make isn't shipped by Qt … (diff)
3:20 PM Changeset in webkit [46378] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Land correct results for a SnowLeopard-only accessibility test.

  • platform/mac/accessibility/table-multi-bodies-expected.txt:
2:57 PM Changeset in webkit [46377] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-07-24 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Jon Honeycutt.

Fix of <rdar://6310538> Middle-click panning should be springloaded while dragging
​https://bugs.webkit.org/show_bug.cgi?id=21794

Create two new booleans to determine whether we have done a springloaded pan scroll, and update
the name of setPanScrollCursor to updatePanScrollState to more accurately describe what the function
does.

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): Initialized two new booleans. (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::updatePanScrollState): Renamed from setPanScrollCursor. (WebCore::EventHandler::stopAutoscrollTimer): Clear the pan scrolling in progress flag. (WebCore::EventHandler::handleMouseReleaseEvent): Clear the pan scrolling button pressed flag.
  • page/EventHandler.h:
2:33 PM UsingGitWithWebKit edited by eli.fidler@torchmobile.com
(diff)
2:31 PM Changeset in webkit [46376] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-07-24 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

Changed WorkerContext destructor to not access possibly-freed WorkerThread.

Failed assertion in WorkerContext::~WorkerContext().
​https://bugs.webkit.org/show_bug.cgi?id=27665

  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
    • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Removed assertion that relies on WorkerThread still being alive (moved to DedicatedWorkerContext destructor).
2:18 PM Changeset in webkit [46375] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-24 Eli Fidler <​eli.fidler@torchmobile.com>

Reviewed by Adam Treat.

Improve git workflow by populating commit messages with ChangeLog entries.
​https://bugs.webkit.org/show_bug.cgi?id=27605

If the user doesn't manually modify the ChangeLog files, use
prepare-ChangeLog to populate the git commit message. This behaviour
can be disabled by the 'webkitGenerateCommitMessage' git configuration option.

  • Scripts/commit-log-editor:
2:13 PM Changeset in webkit [46374] by treat@webkit.org
  • 1 edit
    11 adds in trunk/WebCore

2009-07-24 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=27657
Add more wince port files to WebCore

Written by Yong Li <​yong.li@torchmobile.com> and Lyon Chen <​lyon.chen@torchmobile.com>

  • loader/icon/wince/IconDatabaseWince.cpp: Added.
  • rendering/RenderThemeWince.cpp: Added.
  • rendering/RenderThemeWince.h: Added.
  • storage/wince/DatabaseThreadWince.cpp: Added.
  • storage/wince/DatabaseThreadWince.h: Added.
  • storage/wince/LocalStorageThreadWince.cpp: Added.
  • storage/wince/LocalStorageThreadWince.h: Added.
  • svg/graphics/wince/SVGResourceFilterWince.cpp: Added.
2:12 PM Changeset in webkit [46373] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-07-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

execCommand('underline') can modify DOM outside of the contentEditable area
​https://bugs.webkit.org/show_bug.cgi?id=24333

highestAncestorWithTextDecoration stops at the closest unsplittable element so that if text-decoration is applied
outside of it, we don't accidently modify the style attribute.

Tests: editing/style/textdecoration-outside-of-rooteditable.html

editing/style/textdecoration-outside-of-unsplittable-element.html

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::highestAncestorWithTextDecoration):

LayoutTests:

2009-07-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

execCommand('underline') can modify DOM outside of the contentEditable area
​https://bugs.webkit.org/show_bug.cgi?id=24333

Tests to make sure we are not removing underline applied outside of root editable node or unsplittable element.

  • editing/style/textdecoration-outside-of-rooteditable-expected.txt: Added.
  • editing/style/textdecoration-outside-of-rooteditable.html: Added.
  • editing/style/textdecoration-outside-of-unsplittable-element-expected.txt: Added.
  • editing/style/textdecoration-outside-of-unsplittable-element.html: Added.
1:59 PM Changeset in webkit [46372] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2009-07-24 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27639

Tests that XSSAuditor does not prevent evaluation of scripts that only contain
non-canonical characters.

  • http/tests/security/xssAuditor/script-tag-safe-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-safe.html: Added.

2009-07-24 Daniel Bates <​dbates@intudata.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27639

Fixes false positives when evaluating certain strings that only contain
non-canonical characters.

Test: http/tests/security/xssAuditor/script-tag-safe.html

  • page/XSSAuditor.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::XSSAuditor::findInRequest):
12:54 PM Changeset in webkit [46371] by dimich@chromium.org
  • 5 edits
    3 adds in trunk

WebCore:

2009-07-24 Drew Wilson <​atwilson@google.com>

Reviewed by Adam Barth.

Updated code generator to properly generate bindings for WorkerContext exposed functions.

Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
​https://bugs.webkit.org/show_bug.cgi?id=27419

Test: fast/workers/worker-call.html

  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJSDedicatedWorkerContext): (WebCore::toJSWorkerContext): Functions that convert from JSValue to the appropriate WorkerContext/DedicatedWorkerContext object.
  • bindings/js/JSWorkerContextBase.h: Added toJS*WorkerContext APIs.
  • bindings/scripts/CodeGeneratorJS.pm: Added code to appropriately check the passed-in this object when invoking functions at global scope.

LayoutTests:

2009-07-24 Drew Wilson <​atwilson@google.com>

Reviewed by Adam Barth.

Added layout tests to exercise various use cases for calling functions defined on Worker global scope.

Storing a reference to WorkerContext.postMessage() and calling it later yields a TypeError
​https://bugs.webkit.org/show_bug.cgi?id=27419

  • fast/workers/resources/worker-call.js: Added.
  • fast/workers/worker-call-expected.txt: Added.
  • fast/workers/worker-call.html: Added.
12:28 PM Changeset in webkit [46370] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-07-24 Drew Wilson <​atwilson@google.com>

Reviewed by Adam Barth.

Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
​https://bugs.webkit.org/show_bug.cgi?id=27420

No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).

  • DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
  • DerivedSources.make: Added DerivedWorkerContext files
  • GNUmakefile.am: Added DerivedWorkerContext files
  • WebCore.gypi: Added DerivedWorkerContext files
  • WebCore.pro: Added DerivedWorkerContext files
  • WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
  • WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
  • bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
  • bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
  • bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
  • bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
  • bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
  • bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
  • dom/EventTarget.h:
  • workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
  • workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
  • workers/DedicatedWorkerContext.idl: Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
  • workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
  • workers/WorkerContext.idl:
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
12:23 PM Changeset in webkit [46369] by dimich@chromium.org
  • 28 edits
    5 adds in trunk/WebCore

2009-07-24 Drew Wilson <​atwilson@google.com>

Reviewed by Adam Barth.

Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext
​https://bugs.webkit.org/show_bug.cgi?id=27420

No new tests as the existing tests already provide sufficient coverage (this is just a refactoring with no new functionality).

  • DerivedSources.cpp: Added JSDerivedWorkerContext.cpp
  • DerivedSources.make: Added DerivedWorkerContext files
  • GNUmakefile.am: Added DerivedWorkerContext files
  • WebCore.gypi: Added DerivedWorkerContext files
  • WebCore.pro: Added DerivedWorkerContext files
  • WebCore.vcproj/WebCore.vcproj: Added DerivedWorkerContext files
  • WebCore.xcodeproj/project.pbxproj: Added DerivedWorkerContext files
  • bindings/js/JSDedicatedWorkerContextCustom.cpp: Added. (WebCore::JSDedicatedWorkerContext::mark): Custom mark function for onmessage event handler.
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Supports conversion to JSDedicatedWorkerContext. (WebCore::toEventTarget):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Moved onmessage mark handling into DedicatedWorkerContext.
  • bindings/js/WorkerScriptController.cpp: Added appropriate casts to DedicatedWorkerContext for postMessage(). (WebCore::WorkerScriptController::initScript): Manually sets up the prototype chain for the worker context.
  • bindings/scripts/CodeGeneratorJS.pm: Changed special case code for WorkerContext to be triggered by new IsWorkerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: Changed hard-coded tests for WorkerContext to support DedicatedWorkerContext.
  • bindings/v8/DOMObjectsInclude.h: Added DedicatedWorkerContext.h
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8DedicatedWorkerContext.cpp
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Added code to reserve extra fields for V8DedicatedWorkerContext.
  • bindings/v8/V8Index.cpp: Now includes V8DedicatedWorkerContext.h in addition to V8WorkerContext.h
  • bindings/v8/V8Index.h: Added DedicatedWorkerContext as a non-node wrapper type. Removed WORKERCONTEXT as a valid template type.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Creates DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): Returns DedicatedWorkerContext instead of WorkerContext. (WebCore::WorkerContextExecutionProxy::retrieve): Refactored to deal with DedicatedWorkerContext.
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: Added. Moved onmessage code from V8WorkerContextCustom.cpp (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Moved onmessage code to V8DedicatedWorkerContextCustom.cpp
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDedicatedWorkerContext):
  • dom/EventTarget.h:
  • workers/DedicatedWorkerContext.cpp: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext): (WebCore::DedicatedWorkerContext::reportException): (WebCore::DedicatedWorkerContext::postMessage): (WebCore::DedicatedWorkerContext::dispatchMessage):
  • workers/DedicatedWorkerContext.h: Added. Moved DedicatedWorker-only APIs from WorkerContext. (WebCore::DedicatedWorkerContext::create): (WebCore::DedicatedWorkerContext::toDedicatedWorkerContext): (WebCore::DedicatedWorkerContext::setOnmessage): (WebCore::DedicatedWorkerContext::onmessage):
  • workers/DedicatedWorkerContext.idl: Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Moved code that notifies parent that worker is closing down into DedicatedWorkerContext.
  • workers/WorkerContext.h: (WebCore::WorkerContext::isClosing): Exposed closing flag as an API so derived classes can access it.
  • workers/WorkerContext.idl:
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): Calls into DedicatedWorkerContext to handle message.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Creates a DedicatedWorkerContext when the thread starts up.
12:01 PM Changeset in webkit [46368] by eric@webkit.org
  • 10 edits in trunk

2009-07-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix the last of the x-frame constructor calls to have the right prototype chains
​https://bugs.webkit.org/show_bug.cgi?id=27645

I also had to add support for passing arguments to constructors
in order to test the Worker constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/resources/constructed-objects-prototypes.js:

2009-07-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix the last of the x-frame constructor calls to have the right prototype chains
​https://bugs.webkit.org/show_bug.cgi?id=27645

Fix the last few constructors to use their stored globalObject pointer when
constructing objects instead of the lexicalGlobalObject().

  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::constructWebKitPoint):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
11:05 AM Changeset in webkit [46367] by kenneth@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-07-24 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Adam Treat.

As per discussion on IRC, changed originalUrl by requestedUrl.

  • Api/qwebframe.cpp: (QWebFrame::requestedUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp:
10:57 AM Changeset in webkit [46366] by kenneth@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-07-24 Andre Pedralho <​andre.pedralho@openbossa.org>

Reviewed by Adam Treat.

Removed void QWebFrame::renderContents(...) and added the Q_PROPERTY
clipRenderToViewport to control whether QWebFrame::render would call
FrameView::paintContents rather than FrameView::paint and do not clip
the frame content to viewport.
​https://bugs.webkit.org/show_bug.cgi?id=26352

  • Api/qwebframe.cpp: (QWebFramePrivate::renderPrivate): (QWebFrame::clipRenderToViewport): (QWebFrame::setClipRenderToViewport):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
  • tests/qwebframe/tst_qwebframe.cpp:
10:56 AM Changeset in webkit [46365] by jianli@chromium.org
  • 4 edits in trunk/WebCore

2009-07-24 Jian Li <​jianli@chromium.org>

Reviewed by Adam Barth.

[V8] Cleanup exception handling in worker evaluation code.
​https://bugs.webkit.org/show_bug.cgi?id=27282

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate):
  • bindings/v8/WorkerContextExecutionProxy.h: (WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::setException):
10:55 AM Changeset in webkit [46364] by kenneth@webkit.org
  • 5 edits
    2 adds in trunk/WebKit/qt

2009-07-24 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[QT] Implement originalUrl getter method to the API
​https://bugs.webkit.org/show_bug.cgi?id=25867

  • Api/qwebframe.cpp: (QWebFrame::originalUrl):
  • Api/qwebframe.h:
  • tests/qwebframe/qwebframe.qrc:
  • tests/qwebframe/test1.html: Added.
  • tests/qwebframe/test2.html: Added.
  • tests/qwebframe/tst_qwebframe.cpp:
10:44 AM Changeset in webkit [46363] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-24 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Reverting r46157, since it may be causing problems with Chromium
reliability (see ​http://crbug.com/17569).

​https://bugs.webkit.org/show_bug.cgi?id=27388

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
10:39 AM Changeset in webkit [46362] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

REGRESSION: inspector seems broken in ToT WebKit
​https://bugs.webkit.org/show_bug.cgi?id=27646

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
10:34 AM Changeset in webkit [46361] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Add the shadow style member to the ShadowData constructor and ==
operator

  • rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::operator==):
10:30 AM Changeset in webkit [46360] by jianli@chromium.org
  • 6 edits in trunk/WebCore

2009-07-24 Jian Li <​jianli@chromium.org>

Reviewed by Eric Seidel.

[V8] More V8 bindings changes to use ErrorEvent.
​https://bugs.webkit.org/show_bug.cgi?id=27630

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
10:26 AM EFLWebKit edited by tonikitoo@gmail.com
(diff)
9:53 AM Changeset in webkit [46359] by bfulgham@webkit.org
  • 6 edits in trunk

WebCore:

2009-07-24 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Dave Hyatt.

Clean up dependencies on Apple support libraries for non-Apple build.
​http://bugs.webkit.org/show_bug.cgi?id=27532.

  • platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-24 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Dave Hyatt.

Clean up dependencies on Apple support libraries for non-Apple build.
​http://bugs.webkit.org/show_bug.cgi?id=27532.

  • DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
  • WebDownload.h: Conditionalize include of CFNetwork.h
  • WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
9:28 AM Changeset in webkit [46358] by mitz@apple.com
  • 2 edits in trunk/WebCore

Another attempted build fix

  • bindings/js/JSAbstractWorkerCustom.cpp:
9:28 AM Changeset in webkit [46357] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-24 David Levin <​levin@chromium.org>

Reviewed by Adam Treat.

cpplint crash when there is a duplicate header followed by another header.
​https://bugs.webkit.org/show_bug.cgi?id=27625

  • Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even there is a duplicate header, which resulted in some code rearrangement. Also, changed some if's in this function to return early. This avoids having nearly the whole function content being indented.
  • Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash.
9:27 AM Changeset in webkit [46356] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::toJS):
8:37 AM Changeset in webkit [46355] by treat@webkit.org
  • 4 edits in trunk/WebKitTools

2009-07-24 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Filetype support changes for cpplint and check_webkit_style
​https://bugs.webkit.org/show_bug.cgi?id=27653

Introduce .c support for check_webkit_style, and remove support for
.cc files in favor of .cpp.

  • Scripts/check-webkit-style:
  • Scripts/modules/cpplint.py:
  • Scripts/modules/cpplint_unittest.py:
7:26 AM Changeset in webkit [46354] by xan@webkit.org
  • 2 edits in trunk

2009-07-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove unneeded commas from PKG_CHECK_MODULES.

  • configure.ac:
6:44 AM Changeset in webkit [46353] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Build fix for 64 bit Linux.

int64_t is long on Linux 64 bit and not long long, thus
getFileSize with a int64_t out value fails to build.

Use a temporary to work around the problem.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
6:44 AM Changeset in webkit [46352] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-24 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Build fix for Qt.

Fix build issue introduced in 46344
([Bug 22700] ApplicationCache should have size limit)

Remove method only added to the Qt ChromeClient.

  • WebCoreSupport/ChromeClientQt.h:
5:55 AM Changeset in webkit [46351] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-24 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

ApplicationCache Layout test failing on GTK
​https://bugs.webkit.org/show_bug.cgi?id=27648

Add http/tests/appcache/max-size.html to the Skipped file for now.

  • platform/gtk/Skipped:
5:37 AM BuildingQtOnWindows edited by mails2jaffar@hotmail.com
(diff)
5:31 AM Changeset in webkit [46350] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-24 Priit Laes <​plaes@plaes.org>

Reviewed by Xan Lopez.

[Gtk] Password is saved into gnome-keyring even if auth. fails
​https://bugs.webkit.org/show_bug.cgi?id=27560

Check authentication result and save password only when authentication
succeeds.

  • webkit/webkitsoupauthdialog.c: (free_authData): (response_callback): (save_password_callback):
3:50 AM Changeset in webkit [46349] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2009-07-24 Eli Fidler <​eli.fidler@torchmobile.com>

Reviewed by David Levin.

Improve git workflow by populating commit messages with ChangeLog entries.
​https://bugs.webkit.org/show_bug.cgi?id=27605

add --[no-]write prepare-ChangeLog options to bash completion

  • Scripts/webkit-tools-completion.sh:
3:03 AM Changeset in webkit [46348] by eric@webkit.org
  • 21 edits in trunk

2009-07-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
​https://bugs.webkit.org/show_bug.cgi?id=27644

Make a bunch more tests pass. Still not all of them.
The rest will pass when the last bits of bug 27634 land.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:

2009-07-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
​https://bugs.webkit.org/show_bug.cgi?id=27644

This is another attempt at making the change for bug 27634 smaller.
I included the changes to make_names.pl as well as any file which
used CREATE_DOM_*_WRAPPER macros.

The changes to the construct* functions are what fix the cases in
fast/dom/constructed-objects-prototypes.html

The changes to passing globalObject through CREATE_* are what fix
fast/dom/prototype-inheritance-2.html

  • bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSDOMBinding.h: updated macros to pass globalObject.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttributeNode): use globalObject() for wrapping return value. (WebCore::JSElement::setAttributeNodeNS): use globalObject() for wrapping return value. (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSEventCustom.cpp: (WebCore::JSEvent::clipboardData): pass globalObject. (WebCore::toJS): pass globalObject.
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): use globalObject() for wrapping returned collection items. (WebCore::callHTMLCollection): use globalObject() for wrapping returned collection items. (WebCore::JSHTMLCollection::item): use globalObject() for wrapping returned collection items. (WebCore::toJS): pass globalObject.
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject.
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): pass globalObject.
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): pass globalObject.
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix): use constructors globalObject when constructing
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): use constructors globalObject when constructing
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::constructXSLTProcessor): use constructors globalObject when constructing
  • dom/make_names.pl:

Pass globalObject through CREATE_* macros and various support functions.

2:50 AM Changeset in webkit [46347] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-24 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Darin Adler and Adam Barth.

Build fix for x86 platforms.
​https://bugs.webkit.org/show_bug.cgi?id=27602

  • jit/JIT.cpp:
2:15 AM Changeset in webkit [46346] by eric@webkit.org
  • 31 edits in trunk

2009-07-24 Andrei Popescu <​andreip@google.com>

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.

  • http/tests/appcache/max-size-expected.txt: Added.
  • http/tests/appcache/max-size.html: Added.
  • http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls
​https://bugs.webkit.org/show_bug.cgi?id=27643

This is an attempt to make this change as small as possible.
I started by including all changes to CodeGeneratorJS.pm from bug 27634,
and then made the minimal amount of other changes needed to support that change.

Most toJS implementations ignore their passed JSDOMGlobalObject.
There are stub 2-argument toJS, toJSNewlyCreated implementations to help compiling.
All places where it is not clear what we should pass as the global object
(or where the global object is simply not available, like for some SVG bindings)
we pass deprecatedGlobalObjectForPrototype instead.

  • bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): pass the wrong globalObject for now
  • bindings/js/JSDOMBinding.h:

Pass the wrong global object to the CREATE_ macros for now.
In the next change we'll come back and pass the correct one.
That will require changes to make_names.pl.

(WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMObjectWithGlobalPointer::~DOMObjectWithGlobalPointer):
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper):
(WebCore::toJS): added to convert 2 arg calls to 3 arg calls to limit the scope of this change.
(WebCore::toJSNewlyCreated):

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::toJS): DOMWindow always uses its own prototype chain.
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSEventTarget.h:
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): pass globalObject to toJS(Document*) to avoid recursion (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject* (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::toJS): pass globalObject along
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): pass wrong globalObject for now. (WebCore::JSSVGMatrix::rotateFromVector): pass wrong globalObject for now.
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp:

All of these methods need a globalObject, but most SVG binding don't have
space for one, so we just pass the lexicalGlobalObject for now.

(WebCore::JSSVGPathSegList::initialize):
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):
(WebCore::JSSVGPathSegList::appendItem):

  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): pass wrong globalObject for now. (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): add ignored JSDOMGlobalObject*
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJS): WorkerContext always uses its own prototype chain since it's a GlobalObject subclass.
  • bindings/js/JSWorkerContextBase.h:
  • bindings/scripts/CodeGeneratorJS.pm:

All generated toJS calls now pass a globalObject.
All generated toJS implementations now expect a globalObject.
Simplified all the slot casts by using a "castedThis" local.
SVG bindings which don't have a globalObject() accessor pass the deprecated lexicalGlobalObject instead.
Simplified printing of constructor objects using a $constructorClassName variable.
All generated constructor functions follow the construct$className form to match the custom constructors.

2:14 AM Changeset in webkit [46345] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

typing "document.proto" in inspector throws exception
​https://bugs.webkit.org/show_bug.cgi?id=27169

  • inspector/front-end/utilities.js: (Object.type):
2:12 AM Changeset in webkit [46344] by abarth@webkit.org
  • 40 edits
    5 adds in trunk

2009-07-24 Andrei Popescu <​andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700

Adds the WebApplicationCache class that is
used by the DumpRenderTree test application to
configure the Application Cache maximum size.

  • WebCoreSupport/WebApplicationCache.h: Added.
  • WebCoreSupport/WebApplicationCache.mm: Added.
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebKit.exp:

2009-07-24 Andrei Popescu <​andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebCoreSupport/ChromeClientQt.h:

2009-07-24 Andrei Popescu <​andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::reachedMaxAppCacheSize): Adds empty implementation of reachedMaxAppCacheSize.
  • WebCoreSupport/ChromeClientGtk.h:

2009-07-24 Andrei Popescu <​andreip@google.com>

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700


Updated the project after adding WebApplicationCache.h/mm

  • WebKit.xcodeproj/project.pbxproj:

2009-07-24 Andrei Popescu <​andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebCoreSupport/WebChromeClient.h:

2009-07-24 Andrei Popescu <​andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700


  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::reachedMaxAppCacheSize): Adds empty implementation of the reachedMaxAppCacheSize callback.
  • WebKitSupport/ChromeClientWx.h:

2009-07-24 Andrei Popescu <​andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700

​https://lists.webkit.org/pipermail/webkit-dev/2009-May/007560.html

This change implements a mechanism for limiting the maximum size of
the application cache file. When this size is reached, a ChromeClient
callback is invoked asynchronously and the saving of the last (failed)
cache is retried automatically.


This change also extends the ApplicationCacheStorage API by allowing
a client to query or modify the application cache without having to
load any resources into memory.

Test: http/tests/appcache/max-size.html

  • WebCore.base.exp: Exports the symbols required by the DumpRenderTree test application.
  • loader/EmptyClients.h: Adds empty implementation of the new ChromeClient methods.
  • loader/appcache/ApplicationCache.cpp:
  • loader/appcache/ApplicationCache.h: Adds the ability to calculate the approximate size of an ApplicationCache object.
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h: Invokes the ChromeClient callback when the storage layer runs out of space. After the callback is invoked, we re-attempt to store the newest cache, in case the ChromeClient has freed some space.
  • loader/appcache/ApplicationCacheResource.cpp:
  • loader/appcache/ApplicationCacheResource.h: Adds the ability to calculate the approximate size of an ApplicationCacheResource object.
  • loader/appcache/ApplicationCacheStorage.cpp:
  • loader/appcache/ApplicationCacheStorage.h: Enforces a maximum size for the application cache file.
  • page/ChromeClient.h: Adds a new callback, invoked when the ApplicationCacheStorage reports that it has reached the maximum size for its database file.
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteDatabase.h: Adds a new method that allows querying for the amount of unused space inside the application cache database file.

2009-07-24 Andrei Popescu <​andreip@google.com>

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a unit test that ensures that the mechanism that
enforces the maximum size of the application cache is
working correctly.

  • http/tests/appcache/max-size-expected.txt: Added.
  • http/tests/appcache/max-size.html: Added.
  • http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24 Andrei Popescu <​andreip@google.com>

Reviewed by Anders Carlsson.

ApplicationCache should have size limit
​https://bugs.webkit.org/show_bug.cgi?id=22700

Adds a new method on the LayoutTestController that
allows a JS unit test to configure the maximum size
of the Application Cache.

  • DumpRenderTree/LayoutTestController.cpp: (setAppCacheMaximumSizeCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAppCacheMaximumSize):
1:42 AM Changeset in webkit [46343] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Use TextEncoding facilities to convert between UTF16 and UTF8
instead of rolling our own solution.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (convertUniCharToUTF8):
1:42 AM Changeset in webkit [46342] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-22 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Fix confusion in g_substr between length in bytes and length in
characters. Was causing crashes in some situations when dealing
with non-ASCII text encoded as UTF8.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (g_substr):
1:39 AM Changeset in webkit [46341] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-24 Adam Barth <​abarth@webkit.org>

Rubber stamped by Eric Seidel.

Added andersca to list of reviewers.

  • Scripts/modules/bugzilla.py:
1:33 AM Changeset in webkit [46340] by mrowe@apple.com
  • 26 edits
    1 add in trunk/WebKitTools

Fix dozens of "Deallocation of a pointer not malloced" messages seen while running layout tests on the build bot.

Reviewed by Xan Lopez.

Memory allocated via FastMalloc was being deleted via the system memory allocator
due to an inconsistent including of FastMalloc.h. We address this by including it
from config.h and including config.h from every implementation file, as in our other
projects.

  • DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h.
  • DumpRenderTree/config.h:
  • DumpRenderTree/mac/AccessibilityControllerMac.mm:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/mac/AppleScriptController.m:
  • DumpRenderTree/mac/CheckedMalloc.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/EditingDelegate.mm:
  • DumpRenderTree/mac/EventSendingController.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/GCControllerMac.mm:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/NavigationController.m:
  • DumpRenderTree/mac/ObjCController.m:
  • DumpRenderTree/mac/ObjCPlugin.m:
  • DumpRenderTree/mac/ObjCPluginFunction.m:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
  • DumpRenderTree/mac/PlainTextController.mm:
  • DumpRenderTree/mac/PolicyDelegate.mm:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:
  • DumpRenderTree/mac/TextInputController.m:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/mac/WorkQueueItemMac.mm:
1:33 AM Changeset in webkit [46339] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Impossible to add an attribute to a node without attributes
​https://bugs.webkit.org/show_bug.cgi?id=21108

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewButton): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._addNewAttribute): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/inspector.css:
1:31 AM Changeset in webkit [46338] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Adds support for Firebug's magic $0 variable to access inspected node
​https://bugs.webkit.org/show_bug.cgi?id=17907

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI.{

_inspectedNodes, _addInspectedNode, $0, $1, $n}

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): Stores the inspected node history

in _inspectorCommandLineAPI._inspectedNodes

(WebInspector.ElementsPanel):

1:22 AM Changeset in webkit [46337] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Dragging a resource in the sidebar should drag it's URL
​https://bugs.webkit.org/show_bug.cgi?id=14410

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
1:21 AM Changeset in webkit [46336] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Double click on a resource in the sidebar should open that resource in Safari
​https://bugs.webkit.org/show_bug.cgi?id=14409

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick): open a resource url
1:05 AM Changeset in webkit [46335] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

Revert "2009-07-24 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>"

This reverts commit 6a8ef1983c1dbfaebc636ba70a046d28b12b4aab.

12:59 AM Changeset in webkit [46334] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-24 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Build fix for x86 platforms.
​https://bugs.webkit.org/show_bug.cgi?id=27602

  • jit/JIT.cpp:
12:55 AM Changeset in webkit [46333] by jmalonzo@webkit.org
  • 6 edits in trunk

2009-07-24 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

Bump pango version requirement to 1.12 and remove unnecessary #ifdefs.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/gtk/Language.cpp:

Bump pango version requirement to 1.12 which is the version that
came with Gtk 2.10.

  • configure.ac:
12:52 AM Changeset in webkit [46332] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Missing UIString and other localizedString.js fixes
​https://bugs.webkit.org/show_bug.cgi?id=27288

  • English.lproj/localizedStrings.js:
12:51 AM Changeset in webkit [46331] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Should Syntax Highlight JSON
​https://bugs.webkit.org/show_bug.cgi?id=27503

  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
12:44 AM Changeset in webkit [46330] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
​https://bugs.webkit.org/show_bug.cgi?id=27624

  • page/DragController.cpp: (WebCore::DragController::~DragController): (WebCore::documentFragmentFromDragData): (WebCore::DragController::dragEnded): (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDrag): (WebCore::asFileInput): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::delegateDragSourceAction): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::mayStartDragAtEventLocation): (WebCore::getCachedImage): (WebCore::getImage): (WebCore::prepareClipboardForImageDrag): (WebCore::dragLocForDHTMLDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doImageDrag): (WebCore::DragController::doSystemDrag): (WebCore::DragController::placeDragCaret):
12:44 AM Changeset in webkit [46329] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/Chrome.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
​https://bugs.webkit.org/show_bug.cgi?id=27608

  • page/Chrome.cpp: (WebCore::Chrome::runBeforeUnloadConfirmPanel): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::shouldInterruptJavaScript): (WebCore::Chrome::setToolTip): (WebCore::Chrome::requestGeolocationPermissionForFrame): (WebCore::ChromeClient::generateReplacementFile): (WebCore::ChromeClient::paintCustomScrollbar):
12:43 AM Changeset in webkit [46328] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-24 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/Coordinates.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
​https://bugs.webkit.org/show_bug.cgi?id=27614

  • page/Coordinates.cpp: (WebCore::Coordinates::toString):
12:42 AM Changeset in webkit [46327] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMSelection.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
​https://bugs.webkit.org/show_bug.cgi?id=27614

  • page/DOMSelection.cpp: (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument):
  • page/DOMSelection.h:
12:42 AM Changeset in webkit [46326] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-07-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

x-frame constructor calls are instantiated with the wrong prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=27566

Add the test. Soon to be fixed by bug 27634.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • fast/dom/constructed-objects-prototypes.html: Added.
  • fast/dom/resources/constructed-objects-prototypes.js: Added. (classNameForObject): (constructorPropertiesOnWindow):
12:31 AM Changeset in webkit [46325] by mrowe@apple.com
  • 6 edits in trunk

Roll out r46321 as it broke the Windows build.

12:28 AM Changeset in webkit [46324] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-07-24 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
​https://bugs.webkit.org/show_bug.cgi?id=27618

  • page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::suspend): (WebCore::DOMTimer::resume): (WebCore::DOMTimer::canSuspend):
  • page/DOMTimer.h: (WebCore::DOMTimer::minTimerInterval): (WebCore::DOMTimer::setMinTimerInterval):
12:15 AM Changeset in webkit [46323] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore.

Reviewed by Simon Hausmann.

This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests,
leading to situations where the build system unnecessarily feels that the need to recompile.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-javascriptcore-tests:
12:14 AM Changeset in webkit [46322] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-07-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead
​https://bugs.webkit.org/show_bug.cgi?id=27641

Nothing uses globalObject() yet, but this was causing crashes
in the patch for bug 27634. This is covered by fast/dom/gc-6.html.

I decided to change these to Base
instead of DOMObjectWithGlobal:: for future-proofing. All autogenerated classes use a typedef Base
to avoid bugs like these. Sadly C++ does not have a built-in super
we could use.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::mark):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::mark):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::mark):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::mark):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::mark):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::mark):
12:04 AM Changeset in webkit [46321] by bfulgham@webkit.org
  • 6 edits in trunk

WebCore:

2009-07-23 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Eric Seidel.

Clean up dependencies on Apple support libraries for non-Apple build.
​http://bugs.webkit.org/show_bug.cgi?id=27532.

  • platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-23 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Eric Seidel.

Clean up dependencies on Apple support libraries for non-Apple build.
​http://bugs.webkit.org/show_bug.cgi?id=27532.

  • DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
  • WebDownload.h: Conditionalize include of CFNetwork.h
  • WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
Note: See TracTimeline for information about the timeline view.