Timeline
Jul 26, 2009:
- 11:39 PM Changeset in webkit [46407] by
-
- 2 edits in trunk/WebCore
2009-07-26 Brent Fulgham <bfulgham@webkit.org>
Build correction, no review.
Change in r46195 broke WinCairo build.
- WebCorePrefix.h: CoreServices should be ignored for non-Apple build.
- 12:47 PM Changeset in webkit [46406] by
-
- 2 edits in trunk/WebKit/qt
2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>
Reviewed by Simon Hausmann.
More documentation cleanups in the QWebElement class overview.
- Api/qwebelement.cpp:
- 12:47 PM Changeset in webkit [46405] by
-
- 3 edits in trunk/WebKit/qt
2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>
Reviewed by Simon Hausmann.
Clean up documentation of QWebElement's findFirst and findAll functions,
as well as their QWebFrame counterparts.
- Api/qwebelement.cpp:
- Api/qwebframe.cpp:
- 12:47 PM Changeset in webkit [46404] by
-
- 5 edits in trunk/WebKit/qt
2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>
Reviewed by Simon Hausmann.
Various documentation cleanups
- Fixed qdoc warnings
- Hide QWebNetworkInterface from the class overview
- Mention QWebElement in the module overview
- More cleanups
- Api/qwebframe.cpp:
- Api/qwebnetworkinterface.cpp:
- Api/qwebview.cpp:
- docs/qtwebkit.qdoc:
- 12:47 PM Changeset in webkit [46403] by
-
- 2 edits1 add in trunk/WebKit/qt
2009-07-26 Kavindra Palaraja <kavindra.palaraja@nokia.com>
Reviewed by Simon Hausmann.
Added missing class diagram referenced from the docs, taken from the Qt
documentation.
- docs/qtwebkit.qdocconf: Register the image directory with qdoc.
- docs/qwebview-diagram.png: Added.
- 8:36 AM Changeset in webkit [46402] by
-
- 6 edits in trunk/WebCore
2009-07-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement the breakpoints sidebar pane.
This change adds simple UI support into the existing
BreakpointSidebarPane.
- inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.get label): (WebInspector.Breakpoint.prototype.get id):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.labelClicked): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.scriptOrResourceForID):
- inspector/front-end/inspector.css:
Jul 25, 2009:
- 3:14 PM Changeset in webkit [46401] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-25 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for OpaqueJSPropertyNameArray struct
https://bugs.webkit.org/show_bug.cgi?id=27342
Inherits OpaqueJSPropertyNameArray struct from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/API/JSObjectRef.cpp:473.
- API/JSObjectRef.cpp:
- 3:11 PM Changeset in webkit [46400] by
-
- 2 edits in trunk
Fixup ChangeLog.
- 3:00 PM Changeset in webkit [46399] by
-
- 5 edits4 adds in trunk
2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749
Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.
Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.
- fast/canvas/image-pattern-rotate.html: Added.
- platform/mac/fast/canvas/image-object-in-canvas-expected.checksum:
- platform/mac/fast/canvas/image-object-in-canvas-expected.png:
- platform/mac/fast/canvas/image-pattern-rotate-expected.checksum: Added.
- platform/mac/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/mac/fast/canvas/image-pattern-rotate-expected.txt: Added.
2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749
Use (1<<23)/2 as steps of no-repeat pattern to make the error less
than 0.5. The previous value may cause 1 pixel errors.
Add another test to show this bug clearly.
Also add png expected image which was missing in the previous patch.
Test: fast/canvas/image-pattern-rotate.html
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- 2:36 PM Changeset in webkit [46398] by
-
- 7 edits in trunk
2009-07-25 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416
Disable C4819 warning to fix build.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCore.vcproj:
2009-07-25 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416
Disable C4819 warning to fix build.
- WebKit.vcproj/WebKit.vcproj:
2009-07-25 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416
Disable C4819 warning to fix build.
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 2:34 PM Changeset in webkit [46397] by
-
- 2 edits in trunk/WebCore
2009-07-25 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Kevin McCullough.
Inspector: Keyboard Shortcuts to Switch Panels
https://bugs.webkit.org/show_bug.cgi?id=27286
- inspector/front-end/inspector.js: (WebInspector.loaded): save a list of the order of the panels (WebInspector.documentKeyDown): handle the keyboard shortcuts to traverse the panels
- 2:29 PM Changeset in webkit [46396] by
-
- 2 edits in trunk/WebCore
2009-07-25 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
[Qt] Fix build break after r46369
https://bugs.webkit.org/show_bug.cgi?id=27680
- WebCore.pro:
- 9:43 AM Changeset in webkit [46395] by
-
- 8 edits4 adds in trunk
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677
Substitute variables upon attach() time instead of insertedIntoDocument(). Otherwhise variable substitution
won't work during inter-deck jumps (same URL, different fragment). Covered by new test fast/wml/newcontext-same-deck.html.
- dom/Text.cpp: (WebCore::Text::attach):
- dom/Text.h:
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677
Always substitute variables regardless of their existance. If a variable doesn't exist, expand it to an empty string.
Correct several testcases, relying on the old buggy behaviour.
- wml/newcontext-same-deck-expected.txt: Added.
- wml/newcontext-same-deck.html: Added.
- wml/resources/WMLTestCase.js: (createWMLTestCase.iframeElement.onload): (createWMLTestCase): (assureLayout): (startTest): (triggerMouseEvent):
- wml/resources/newcontext-same-deck.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/newcontext-same-deck.wml: Added.
- wml/resources/select-element-variables.js: (prepareTest):
- wml/select-element-variables-expected.txt:
- wml/variable-reference-invalid-character-expected.txt:
- 9:35 AM Changeset in webkit [46394] by
-
- 10 edits in trunk
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] WMLDoElement doesn't update its RenderButton object upon attach()
https://bugs.webkit.org/show_bug.cgi?id=27676
WMLDoElement needs to implement attach() and call updateFromElement() on its associated RenderButton.
Mimics HTMLButtonElement/HTMLFormControlElement behaviour and fixes several painting/styling issues covered by existing tests in fast/wml.
- wml/WMLDoElement.cpp: (WebCore::WMLDoElement::attach):
- wml/WMLDoElement.h:
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] WMLDoElement doesn't update its RenderButton object upon attach()
https://bugs.webkit.org/show_bug.cgi?id=27676
Update layout test results after fixing WMLDoElement::attach() not calling updateFromElement().
- platform/mac/fast/wml/do-element-optional-attr-expected.txt:
- platform/mac/fast/wml/do-shadow-expected.txt:
- platform/mac/fast/wml/do-template-expected.txt:
- platform/mac/fast/wml/err-invalid-location-for-varref-expected.txt:
- platform/mac/fast/wml/err-invalid-variable-name-expected.txt:
- platform/mac/fast/wml/err-samename-do-expected.txt:
- 9:23 AM Changeset in webkit [46393] by
-
- 3 edits in trunk/LayoutTests
2009-07-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Make http/tests/wml/post-data-to-server.* more understable
https://bugs.webkit.org/show_bug.cgi?id=27675
Slightly cleanup this patch so it's easier to figure out what the expected result for <select> element is.
- http/tests/wml/post-data-to-server-expected.txt:
- http/tests/wml/resources/post-data-to-server.js: (setupTestDocument): (prepareTest):
- 2:51 AM Changeset in webkit [46392] by
-
- 2 edits in trunk/WebCore
2009-07-25 Pavel Feldman <pfeldman@chromium.org>
Fix Windows build breakage introduced in 46390.
- WebCore.vcproj/WebCore.vcproj:
- 2:44 AM Changeset in webkit [46391] by
-
- 3 edits in trunk/WebCore
2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Oliver Hunt.
Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): use the displaySort when showing properties (WebInspector.ObjectPropertiesSection.prototype._displaySort): alphaNumerical sort (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): use the displaySort when showing properties
- inspector/front-end/utilities.js: (Object.sortedProperties): allow for an optional sorting function in Object.sortedProperties
- 2:22 AM Changeset in webkit [46390] by
-
- 22 edits3 moves2 adds in trunk/WebCore
2009-07-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Split InspectorController into InspectorController
and InspectorBackend. Everything frontend needs from InspectorController
will slowly migrate into the InspectorBackend.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSInspectorBackendCustom.cpp: Added. (WebCore::JSInspectorBackend::highlightDOMNode): (WebCore::JSInspectorBackend::search): (WebCore::JSInspectorBackend::databaseTableNames): (WebCore::JSInspectorBackend::inspectedWindow): (WebCore::JSInspectorBackend::setting): (WebCore::JSInspectorBackend::setSetting): (WebCore::JSInspectorBackend::wrapCallback): (WebCore::JSInspectorBackend::currentCallFrame): (WebCore::JSInspectorBackend::profiles):
- bindings/v8/custom/V8InspectorBackendCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- bindings/js/JSInspectorControllerCustom.cpp: Removed.
- bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/js/ScriptObject.h:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/v8/ScriptObject.h:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed.
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::windowScriptObjectAvailable):
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorBackend):
- inspector/InspectorBackend.cpp: Added.
- inspector/InspectorBackend.h: Added. (WebCore::InspectorBackend::create): (WebCore::InspectorBackend::inspectorController):
- inspector/InspectorBackend.idl: Added.
- inspector/InspectorController.idl: Removed.
- inspector/front-end/Resource.js:
- page/Page.cpp: (WebCore::Page::Page):
- page/Page.h:
- 12:47 AM Changeset in webkit [46389] by
-
- 3 edits in trunk/WebCore
2009-07-25 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by George Staikos.
Update WebCore/page/Frame.cpp/h to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27654
- page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::setDocument): (WebCore::Frame::firstRectForRange): (WebCore::createRegExpForLabels): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::setZoomFactor): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionStartStylePropertyValue): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::selectionBounds): (WebCore::Frame::currentForm): (WebCore::Frame::revealSelection): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::clearFormerDOMWindow): (WebCore::Frame::unfocusWindow): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::documentAtPoint):
- page/Frame.h: (WebCore::Frame::create): (WebCore::Frame::displayStringModifiedByEncoding): (WebCore::Frame::pageZoomFactor): (WebCore::Frame::textZoomFactor):