⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 27, 2009:

11:05 PM Changeset in webkit [46459] by abarth@webkit.org
  • 5 edits
    12 adds in trunk/WebCore

2009-07-25 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

[V8] Split up V8DOMMap.cpp by class
​https://bugs.webkit.org/show_bug.cgi?id=27685

No behavior change. Just copy-and-paste.

  • WebCore.gypi:
  • bindings/v8/ChildThreadDOMData.cpp: Added. (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore):
  • bindings/v8/ChildThreadDOMData.h: Added.
  • bindings/v8/DOMData.cpp: Added. (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::ensureDeref): (WebCore::DOMData::derefObject): (WebCore::DOMData::derefDelayedObjects): (WebCore::DOMData::derefDelayedObjectsInCurrentThread): (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/DOMData.h: Added. (WebCore::):
  • bindings/v8/DOMDataStore.cpp: Added. (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::allStores): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::getDOMWrapperMap): (WebCore::forget): (WebCore::DOMDataStore::weakDOMObjectCallback): (WebCore::DOMDataStore::weakActiveDOMObjectCallback): (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::weakSVGElementInstanceCallback): (WebCore::DOMDataStore::weakSVGObjectWithContextCallback):
  • bindings/v8/DOMDataStore.h: Added. (WebCore::DOMDataStore::): (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap): (WebCore::DOMDataStore::InternalDOMWrapperMap::forgetOnly): (WebCore::DOMDataStore::domData): (WebCore::DOMDataStore::domNodeMap): (WebCore::DOMDataStore::domObjectMap): (WebCore::DOMDataStore::activeDomObjectMap): (WebCore::DOMDataStore::domSvgElementInstanceMap): (WebCore::DOMDataStore::domSvgObjectWithContextMap):
  • bindings/v8/MainThreadDOMData.cpp: Added. (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getStore):
  • bindings/v8/MainThreadDOMData.h: Added.
  • bindings/v8/ScopedDOMDataStore.cpp: Added. (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
  • bindings/v8/ScopedDOMDataStore.h: Added.
  • bindings/v8/StaticDOMDataStore.cpp: Added. (WebCore::StaticDOMDataStore::StaticDOMDataStore):
  • bindings/v8/StaticDOMDataStore.h: Added.
  • bindings/v8/V8DOMMap.cpp:
10:24 PM Changeset in webkit [46458] by beidson@apple.com
  • 8 edits in trunk/LayoutTests

2009-07-27 Brady Eidson <​beidson@apple.com>

Update Tiger specific results for these 7 tests.

  • platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/mac-tiger/security/block-test-expected.txt:
  • platform/mac-tiger/security/block-test-no-port-expected.txt:
9:53 PM Changeset in webkit [46457] by beidson@apple.com
  • 6 edits in trunk/LayoutTests

2009-07-27 Brady Eidson <​beidson@apple.com>

Update Windows specific results for these 5 tests.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
9:50 PM Changeset in webkit [46456] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-27 Brady Eidson <​beidson@apple.com>

Didn't mean to check this guy in.

  • http/tests/appcache/max-size-expected.txt:
9:29 PM Changeset in webkit [46455] by beidson@apple.com
  • 21 edits in trunk

WebKitTools:

2009-07-27 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLResponse _drt_descriptionSuitableForTestResult]): (-[NSURLRequest _drt_descriptionSuitableForTestResult]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult):

LayoutTests:

2009-07-27 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=27755
Layout tests that dump resource load delegate calls should dump the request method and the response status code.

Update test results for the new info.

  • fast/loader/main-document-url-for-non-http-loads-expected.txt:
  • http/tests/appcache/max-size-expected.txt:
  • http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • http/tests/misc/window-dot-stop-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
  • platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • platform/mac/security/block-test-no-port-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
7:50 PM UsingGitWithWebKit edited by pdherbemont@apple.com
--regenerate-log (diff)
7:29 PM Changeset in webkit [46454] by pdherbemont@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-27 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by David Levin.

"bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
​https://bugs.webkit.org/show_bug.cgi?id=27747

modules.bugzilla is not found because not included.

  • Scripts/modules/scm.py: Properly import modules.bugzilla.
7:28 PM Changeset in webkit [46453] by pdherbemont@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-24 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by David Kilzer.

commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=27664

  • Scripts/commit-log-editor: Add --regenerate-log option. The user is asked if he wants to suppress previous ChangeLog and regenerate it, if this option is enabled.
7:25 PM Changeset in webkit [46452] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

7:24 PM Changeset in webkit [46451] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.9

New tag.

6:57 PM Changeset in webkit [46450] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch

Merge r46449.

6:49 PM Changeset in webkit [46449] by mrowe@apple.com
  • 6 edits in trunk

<rdar://problem/7091036> REGRESSION: Microsoft Messenger crashes during file send/receive due to use of WebKit on non-main thread

Reviewed by Darin Adler.

In some situations Microsoft Messenger can attempt to manipulate the DOM from a secondary thread while
updating its file transfer progress bar. This results in corruption of WebCore data structures that is
quickly followed by a crash. We can work around this by having -[WebFrame DOMDocument] return nil when
called from a secondary thread by Microsoft Messenger, which has the effect of turning its attempts at
DOM manipulation in to no-ops.

  • WebView/WebFrame.mm:

(needsMicrosoftMessengerDOMDocumentWorkaround):
(-[WebFrame DOMDocument]):

Add a method for detecting if we're being used within Microsoft Messenger.

  • WebCore.base.exp: Export applicationIsMicrosoftMessenger and sort existing entries.
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm:

(WebCore::applicationIsMicrosoftMessenger):

6:11 PM Changeset in webkit [46448] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-27 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

[V8] Implement EventListener::reportError for V8 event listeners in worker context.
​https://bugs.webkit.org/show_bug.cgi?id=27731

  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::reportError):
  • bindings/v8/V8WorkerContextEventListener.h:
5:50 PM Changeset in webkit [46447] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-27 Stephen White <​senorblanco@chromium.org>

Reviewed by Eric Seidel and David Levin.

Re-apply chromium/skia border fix (originally landed in r46157,
reverted in r46363), since it was not the cause of the reliability
failures in Chromium.

​http://bugs.webkit.org/show_bug.cgi?id=27388

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
5:47 PM Changeset in webkit [46446] by rniwa@webkit.org
  • 7 edits
    3 adds in trunk

WebCore:

2009-07-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

createMarkup does not handle CSS properly
​https://bugs.webkit.org/show_bug.cgi?id=27660

This patch isolates code that creates markup for styles in addStyleMarkup
It also makes all presentational elements (u, s, strike, i, em, b, strong) special ancestor in createMarkup
so that we can assume no text decoration style is passed to addStyleMarkup.

  • editing/markup.cpp: (WebCore::propertyMissingOrEqualToNone): Changed the first argument from CSSMutableStyleDecleration to CSSStyleDeclaration (WebCore::isElementPresentational): Used to be elementHasTextDecorationProperty, now supports presentational tags (WebCore::addStyleMarkup): Adds markup for style span and div (WebCore::createMarkup): Uses isElementPresentational and addStyleMarkup

LayoutTests:

2009-07-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

createMarkup does not handle CSS properly
​https://bugs.webkit.org/show_bug.cgi?id=27660


inline-style-after-indentoutdent tests whether the original inline style is preserved after outdentation
immediately after indentation.

  • editing/deleting/pruning-after-merge-2.html: Replaced b that contains div with a div with font-weight
  • editing/execCommand/inline-style-after-indentoutdent-expected.txt: Added.
  • editing/execCommand/inline-style-after-indentoutdent.html: Added.
  • editing/execCommand/resources/inline-style-after-indentoutdent.js: Added. (testCreateMarkup): (shouldBeSameAfterCreateMarkup):
  • platform/mac/editing/deleting/delete-3857753-fix-expected.txt: extra i tag is added (still passes pixel tests)
  • platform/mac/editing/deleting/pruning-after-merge-2-expected.txt: extra div as explained above
  • platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: bug 26483 appearing
5:35 PM Changeset in webkit [46445] by Nikolas Zimmermann
  • 7 edits in trunk/LayoutTests

Rubber-stamped by George Staikos.
Forgot to update pixel test results a while ago.

5:21 PM Changeset in webkit [46444] by eric@webkit.org
  • 13 edits in trunk/WebCore

2009-07-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

fix more obvious global object lookups
​https://bugs.webkit.org/show_bug.cgi?id=27745

No new tests for these changes. I believe in many cases
testing to be impossible. Lack of testing justification next to
each change below. The remaining pieces of bug 27634 will all
need tests.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::updateDocument): not testable.
  • bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::nameGetter): no testing for this incomplete feature.
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): would require outer frame to trigger an event in the inner frame
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): covered by other tests, always correct to pass the globalObject through.
  • bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope): unclear when this could be triggered.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::remove): toJS seems superfluous here to begin with.
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): would require outer frame to trigger inner frame event.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::jsObjectForPluginElement): only used for NPAPI binding, unclear how to test.
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): unclear how to test.
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set): unclear how to test/inspector only.
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject): unclear how to test.
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): unclear how to test.
5:16 PM Changeset in webkit [46443] by Nikolas Zimmermann
  • 9 edits in trunk/WebCore

2009-07-27 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'title' attribute handling not correct for <a> / <anchor> elements
​https://bugs.webkit.org/show_bug.cgi?id=27720

Unify title() implementation in WMLElement instead of several copies of the same logic.
We forgot WMLAnchorElement/WMLAElement, that lead to bugs. Fixes hovering links in the
WML manual-test suite.

  • wml/WMLCardElement.cpp:
  • wml/WMLCardElement.h:
  • wml/WMLElement.cpp: (WebCore::WMLElement::title):
  • wml/WMLElement.h:
  • wml/WMLOptGroupElement.cpp:
  • wml/WMLOptGroupElement.h:
  • wml/WMLSelectElement.cpp:
  • wml/WMLSelectElement.h:
4:28 PM Changeset in webkit [46442] by bweinstein@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix for Windows.

4:21 PM Changeset in webkit [46441] by bweinstein@apple.com
  • 5 edits in trunk

Build fix for Windows for JSC recent breakage.

4:21 PM Changeset in webkit [46440] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

prototypes-inheritance-2.html should crawl more types
​https://bugs.webkit.org/show_bug.cgi?id=27741

Now we evaluate the crawl targets lazily so as not to skew any JS binding caching with our test ordering.
We could get around all caching by always instantiating a new copy of the frame
but that would be super-slow. :)

We're now crawling a bunch more types, all of which we pass.

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/resources/prototype-inheritance-2.js: (evalToCrawlObject.LazyEvalCrawlObject): (evalToCrawlObject): (pushPropertyValuesWithUnseenTypes): (crawl):
4:19 PM Changeset in webkit [46439] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Adam Treat <​adam.treat@torchmobile.com>

Speculative build fix for Windows and WinCE.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
3:56 PM Changeset in webkit [46438] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-07-27 Gavin Barraclough <​barraclough@apple.com>

Rubber stamped by Oliver Hunt.

Fix tyop in JIT, renamed preverveReturnAddressAfterCall -> preserveReturnAddressAfterCall.

  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::preserveReturnAddressAfterCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
3:45 PM Changeset in webkit [46437] by ojan@chromium.org
  • 8 edits
    2 adds in trunk

2009-07-27 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=27474
Tests crashes when calling select, setSelectionRange or setting
selectionStart/selectionEnd on a textarea/input immediately after
setting display:none.

  • fast/dom/text-control-crash-on-select-expected.txt: Added.
  • fast/dom/text-control-crash-on-select.html: Added.

2009-07-27 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=27474
Fixes crashes due to renderer getting destroyed in updateLayout.
We need to call updateLayout before we call into the renderer.
Removed the updateLayout call from RenderTextControl and moved it
into the calling sites.

Also changes updateLayout to updateLayoutIgnorePendingStylesheets so
this works with pending stylesheets. Unfortunately, this seems to be
untestable. Loading an external stylesheet and then having an inline
script hit this code did not result in an pending stylesheets.

The are other cases of this bug in the rendering code. I'll file a
followup bug to audit the calls to updateLayout.

Test: fast/dom/text-control-crash-on-select.html

  • dom/Document.h: (WebCore::Document::inStyleRecalc): Added so the ASSERTs in updateFocusAppearance

and setSelectionRange could deal with cases of reentrancy into updateLayout
calls. This happens in a couple layout tests.

  • dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange):
  • html/HTMLInputElement.cpp: (WebCore::isTextFieldWithRendererAfterUpdateLayout): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select):
  • html/HTMLTextAreaElement.cpp: (WebCore::rendererAfterUpdateLayout): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::updateFocusAppearance):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange):
3:43 PM Changeset in webkit [46436] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Gtk build fix.

  • runtime/JSLock.cpp: (JSC::JSLock::JSLock): Fix "no threading" case.
3:40 PM Changeset in webkit [46435] by Dimitri Glazkov
  • 13 edits in trunk/WebCore

2009-07-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Dave Levin.

[V8] Remove parameterless frame/window retrieval methods from V8Proxy.
​https://bugs.webkit.org/show_bug.cgi?id=27737

Refactoring, no new behavior, covered by existing tests.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/V8NPUtils.cpp: (convertV8ObjectToNPVariant): Ditto.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve): Ditto. (WebCore::V8Proxy::canAccessPrivate): Ditto.
  • bindings/v8/V8Proxy.h: Removed parameterless retrieveWindow/retrieveProxy decls.
  • bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Changed to use V8Proxy::retrieveFrameForCurrentContext().
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Ditto.
3:36 PM Changeset in webkit [46434] by ap@webkit.org
  • 2 edits in trunk/WebKit/gtk

Gtk build fix.

  • webkit/webkitwebframe.cpp: (webkit_gc_count_javascript_objects): Added a namespace to SilenceAssertionsOnly.
3:26 PM Changeset in webkit [46433] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Release build fix.

  • runtime/JSLock.h: (JSC::JSLock::~JSLock):
3:18 PM Changeset in webkit [46432] by Nikolas Zimmermann
  • 3 edits
    3 adds in trunk

WebCore:

2009-07-27 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'onpick' intrinsic event handling missing
​https://bugs.webkit.org/show_bug.cgi?id=27723

Trigger 'onpick' intrinsic events from WMLOptionElement::setSelectedState().
All was in place, just forgot to enable the relevant code.

Fixes manual-tests/wml/select-onpick-event.wml
Test: wml/option-element-onpick.html

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::setSelectedState):

LayoutTests:

2009-07-27 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] 'onpick' intrinsic event handling missing
​https://bugs.webkit.org/show_bug.cgi?id=27723

Add a new WML layout test covering 'onpick' support.

  • wml/option-element-onpick-expected.txt: Added.
  • wml/option-element-onpick.html: Added.
  • wml/resources/option-element-onpick.js: Added. (setupTestDocument): (prepareTest): (executeTest):
3:07 PM Changeset in webkit [46431] by ap@webkit.org
  • 84 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=27735
Give a helpful name to JSLock constructor argument

3:00 PM Changeset in webkit [46430] by treat@webkit.org
  • 4 edits in trunk/WebCore

2009-07-27 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: Make plugin work for WINCE
​https://bugs.webkit.org/show_bug.cgi?id=27713

  • plugins/win/PluginDatabaseWin.cpp: (SHGetValue): (PathRemoveFileSpec): (WebCore::addWindowsMediaPlayerPluginDirectory): (WebCore::addMacromediaPluginDirectories):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginView::wndProc): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintWindowedPluginIntoContext): (WebCore::PluginView::paint): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::stop): (WebCore::PluginView::init):
2:58 PM Changeset in webkit [46429] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds support to the Web Inspector for tabbing through element attributes and CSS properties when editing.

2009-07-27 Joseph Pecoraro <​joepeck02@gmail.com>

Inspector: Tab Through Element Attributes and CSS Properties When Editing

​https://bugs.webkit.org/show_bug.cgi?id=27673

Reviewed by Timothy Hatcher.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._startEditing): refactored parameter (WebInspector.ElementsTreeElement.prototype._addNewAttribute): refactored to remove excess (WebInspector.ElementsTreeElement.prototype._triggerEditAttribute): provide an attribute name and this will start editing it (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): move between attributes (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.findTreeElementWithName): search through treeElements for a style property name (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): initialize a blank property for adding new properties (WebInspector.StylePropertyTreeElement.prototype.updateTitle): add references to the name and value elements (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.editingCommitted): include the move direction as a parameter to the commit callback (WebInspector.startEditing.element.handleKeyEvent): handle the tab key to specify the move direction (WebInspector.startEditing):
2:31 PM Changeset in webkit [46428] by treat@webkit.org
  • 4 edits in trunk/WebCore

2009-07-27 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add mapping FontWeight to QFont::Weight values as requested via FIXME.
​https://bugs.webkit.org/show_bug.cgi?id=27663

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::toQFontWeight):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
2:21 PM WebKit Team edited by abarth@webkit.org
(diff)
2:21 PM Changeset in webkit [46427] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Adam Treat.

When clearing the plugin database, clear also the timestamp map.

​https://bugs.webkit.org/show_bug.cgi?id=27651

Currently, if we clear the database, it will still think that it is up
to date with the plugin directories so refreshing the database again
after changing the search paths may not work.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::clear):
2:17 PM Changeset in webkit [46426] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-07-27 Albert J. Wong <​ajwong@chromium.org>

Reviewed by David Levin.

Add in trivial implementation of FontPlatformData::description() for
linux to fix build bustage in chromium.

Fix chromium linux build by adding missing function implementation.
​https://bugs.webkit.org/show_bug.cgi?id=27732

Tested with a build of chromium on linux.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::description):
  • platform/graphics/chromium/FontPlatformDataLinux.h:
12:45 PM QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
12:09 PM Changeset in webkit [46425] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Brent Fulgham <​bfulgham@webkit.org>

Build correct, no review.

Final correction for WinCairo builds.
CoreServices only exists in Apple builds, but
some of its internal includes (e.g., <windows.h>) are needed
for other Windows targets.

  • WebCorePrefix.h: When building for WinCairo, make sure to include <windows.h>, <stdio.h>, and <ConditionalMacros.h>
11:54 AM Changeset in webkit [46424] by pkasting@chromium.org
  • 2 edits in trunk/WebKitLibraries

2009-07-27 Peter Kasting <​pkasting@google.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=27323
Correctly parse command output, even when the line endings are not LF,
so that we don't create an autoversion.h that MSVC chokes on.

  • win/tools/scripts/auto-version.sh:
11:32 AM Changeset in webkit [46423] by pkasting@chromium.org
  • 8 edits
    22 adds in trunk

WebCore:

2009-07-27 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25552
Added new "pattern" attribute to HTMLInputElement and validation code
(validity.patternMismatch) as per HTML5 specs.
​http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-pattern

Tests: fast/forms/ValidityState-002.html

fast/forms/ValidityState-patternMismatch-001.html
fast/forms/ValidityState-patternMismatch-002.html
fast/forms/ValidityState-patternMismatch-003.html
fast/forms/ValidityState-patternMismatch-004.html
fast/forms/ValidityState-patternMismatch-005.html
fast/forms/ValidityState-patternMismatch-006.html
fast/forms/ValidityState-patternMismatch-007.html
fast/forms/pattern-attribute-001.html
fast/forms/pattern-attribute-002.html
fast/forms/pattern-attribute-003.html

  • html/HTMLAttributeNames.in: pattern attribute
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::patternMismatch): method definition
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::patternMismatch): validation method
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.h: (WebCore::ValidityState::patternMismatch): validation flag

LayoutTests:

2009-07-27 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25552
First series of tests for the "pattern" attribute and related validation
code

  • fast/forms/ValidityState-002-expected.txt: Copied from LayoutTests/fast/forms/willvalidate-001-expected.txt.
  • fast/forms/ValidityState-002.html: Added.
  • fast/forms/ValidityState-patternMismatch-001-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-001.html: Added.
  • fast/forms/ValidityState-patternMismatch-002-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-002.html: Added.
  • fast/forms/ValidityState-patternMismatch-003-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-003.html: Added.
  • fast/forms/ValidityState-patternMismatch-004-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-004.html: Added.
  • fast/forms/ValidityState-patternMismatch-005-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-005.html: Added.
  • fast/forms/ValidityState-patternMismatch-006-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-006.html: Added.
  • fast/forms/ValidityState-patternMismatch-007-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch-007.html: Added.
  • fast/forms/pattern-attribute-001-expected.txt: Added.
  • fast/forms/pattern-attribute-001.html: Added.
  • fast/forms/pattern-attribute-002-expected.txt: Added.
  • fast/forms/pattern-attribute-002.html: Added.
  • fast/forms/pattern-attribute-003-expected.txt: Added.
  • fast/forms/pattern-attribute-003.html: Added.
11:22 AM Changeset in webkit [46422] by Nikolas Zimmermann
  • 31 edits
    3 adds
    7 deletes in trunk/WebCore

Reviewed by George Staikos.

[WML] Manual WML tests aren't properly working
​https://bugs.webkit.org/show_bug.cgi?id=27718

Fix file paths in the manual WML layout tests, remove unneeded tests (already covered by DRT tests).
Add missing resources directory and test image. Reformat all testcases to a common style.
Add new StartTests.wml file, which should be used as starting point to crawl through the manual tests.

Filing bugs soon for all tests exposing bugs (7 in total).

11:17 AM Changeset in webkit [46421] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-07-27 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Fix a regression introduced in r42671, which caused the js event
object to be hidden (some websites depend on being able to access it).

​https://bugs.webkit.org/show_bug.cgi?id=27719

11:08 AM Changeset in webkit [46420] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-07-27 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Removing a no-op block of code in DatabaseTracker.cpp that
should've been removed in the patch for bug 26054.

​https://bugs.webkit.org/show_bug.cgi?id=27666

All tests in WebCore/storage pass.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Removed a no-op block of code that was moved to SQLiteFileSystem.cpp and should have been removed from DatabaseTracker.cpp
10:45 AM Changeset in webkit [46419] by jianli@chromium.org
  • 13 edits
    7 adds in trunk

WebCore:

2009-07-27 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

Fix error handling in dedicated worker and worker context.
​https://bugs.webkit.org/show_bug.cgi?id=27525

The following problems have been fixed:
1) The uncaught runtime script error is not reported using the
WorkerGlobalScope object's onerror attribute.
2) If the error is still not handled afterwards (onerror attribute
is not defined as a function or it returns true), the error should
be reported back to the associated Worker object by firing an
ErrorEvent.
3) If the error is still not handled by the associated Worker
object, the error should be reported to the user.

Test: fast/workers/worker-script-error.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::reportError):
  • bindings/js/JSEventListener.h:
  • dom/EventListener.h: (WebCore::EventListener::reportError): adds a function to call EventListener as a function with 3 arguments to report an error.
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
  • workers/AbstractWorker.h:
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::reportException):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::performTask):
  • workers/WorkerMessagingProxy.h:

LayoutTests:

2009-07-27 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

Layout tests for fixing error handling in dedicated worker and worker
context.
​https://bugs.webkit.org/show_bug.cgi?id=27525

  • fast/workers/resources/worker-error-in-handling-script-error.js: Added
  • fast/workers/resources/worker-invalid-syntax.js: Added.
  • fast/workers/resources/worker-script-error-bubbled.js: Added.
  • fast/workers/resources/worker-script-error-handled.js: Added.
  • fast/workers/resources/worker-script-error-unhandled.js: Added.
  • fast/workers/worker-constructor.html:
  • fast/workers/worker-script-error-expected.txt: Added.
  • fast/workers/worker-script-error.html: Added. Add test cases to cover different script error handling scenarios.
10:04 AM Changeset in webkit [46418] by Nikolas Zimmermann
  • 13 edits
    8 adds in trunk

[WML] History handling / page cache / loading is buggy and depends on several hacks
​https://bugs.webkit.org/show_bug.cgi?id=27707

Redesign WML history/loading handling. See ChangeLog for details.

8:09 AM Changeset in webkit [46417] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-07-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Adam Roben.

Fix Chromium build breakage introduced in 46388.

​https://bugs.webkit.org/show_bug.cgi?id=27705

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::description):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
6:41 AM Changeset in webkit [46416] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2009-07-27 Gabor Rapcsanyi <​rapcsanyi.gabor@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Generating remote links causes a lot of unnecessary spew on Qt build bot too

  • Scripts/run-webkit-tests:
4:34 AM Changeset in webkit [46415] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-07-27 Volker Hilsheimer <​volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

QWebView's "enabled" parameter should default to true, as with QGraphicsView and
QPainter.

  • Api/qwebview.cpp: Add reference to QPainter::renderHints().
  • Api/qwebview.h: Add default for enabled argument.
4:29 AM Changeset in webkit [46414] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Add some more debug logging to PluginViewMac.

  • plugins/mac/PluginViewMac.cpp:
4:27 AM Changeset in webkit [46413] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Jan Michael Alonzo.

Remove dead code from the GTK NPAPI implementation.

  • plugins/gtk/PluginViewGtk.cpp:
4:06 AM Changeset in webkit [46412] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-27 Jan Michael Alonzo <​jmalonzo@webkit.org>

Add fast/canvas/image-pattern-rotate.html to Skipped as it needs
platform-specific expected results.

  • platform/gtk/Skipped:
3:39 AM Changeset in webkit [46411] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-27 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Buildfix on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=27702

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::hookedEndPaint):

Constraint of (*endPaint) operand modified from "g" to "m" (memory) in inline
assembly, because with "g" constraint, wrong assembly code generated.

2:06 AM Changeset in webkit [46410] by pfeldman@chromium.org
  • 6 edits
    4 adds in trunk/WebCore

2009-07-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebCore bindings: Implement ScriptArray bindings.

​https://bugs.webkit.org/show_bug.cgi?id=27691

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::handleException): (WebCore::ScriptArray::set): (WebCore::length): (WebCore::ScriptArray::createNew):
  • bindings/js/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::jsArray):
  • bindings/v8/ScriptArray.cpp: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::set): (WebCore::ScriptArray::length): (WebCore::ScriptArray::createNew):
  • bindings/v8/ScriptArray.h: Added. (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::~ScriptArray):
12:17 AM Changeset in webkit [46409] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Brent Fulgham <​bfulgham@webkit.org>

Build correct, no review.

Change in r46407 broke Apple Windows build.
Switch to WinCairo-only test, to avoid any
other platform break.

  • WebCorePrefix.h:
12:02 AM Changeset in webkit [46408] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-26 Brent Fulgham <​bfulgham@webkit.org>

Build correct, no review.

Change in r46407 broke Apple Windows build.

  • WebCorePrefix.h: Use WTF_PLATFORM_CG to decide if CoreServices.h should be included.

Jul 26, 2009:

11:39 PM Changeset in webkit [46407] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-07-26 Brent Fulgham <​bfulgham@webkit.org>

Build correction, no review.

Change in r46195 broke WinCairo build.

  • WebCorePrefix.h: CoreServices should be ignored for non-Apple build.
12:47 PM Changeset in webkit [46406] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-07-26 Kavindra Palaraja <​kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

More documentation cleanups in the QWebElement class overview.

  • Api/qwebelement.cpp:
12:47 PM Changeset in webkit [46405] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-07-26 Kavindra Palaraja <​kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Clean up documentation of QWebElement's findFirst and findAll functions,
as well as their QWebFrame counterparts.

  • Api/qwebelement.cpp:
  • Api/qwebframe.cpp:
12:47 PM Changeset in webkit [46404] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

2009-07-26 Kavindra Palaraja <​kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Various documentation cleanups

  • Fixed qdoc warnings
  • Hide QWebNetworkInterface from the class overview
  • Mention QWebElement in the module overview
  • More cleanups
  • Api/qwebframe.cpp:
  • Api/qwebnetworkinterface.cpp:
  • Api/qwebview.cpp:
  • docs/qtwebkit.qdoc:
12:47 PM Changeset in webkit [46403] by Simon Hausmann
  • 2 edits
    1 add in trunk/WebKit/qt

2009-07-26 Kavindra Palaraja <​kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Added missing class diagram referenced from the docs, taken from the Qt
documentation.

  • docs/qtwebkit.qdocconf: Register the image directory with qdoc.
  • docs/qwebview-diagram.png: Added.
8:36 AM Changeset in webkit [46402] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2009-07-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement the breakpoints sidebar pane.
This change adds simple UI support into the existing
BreakpointSidebarPane.

​https://bugs.webkit.org/show_bug.cgi?id=11175

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.get label): (WebInspector.Breakpoint.prototype.get id):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.labelClicked): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.scriptOrResourceForID):
  • inspector/front-end/inspector.css:
Note: See TracTimeline for information about the timeline view.