⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 3, 2009:

11:34 PM Changeset in webkit [46747] by abarth@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixup ChangeLog

11:14 PM Changeset in webkit [46746] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-03 Harald Fernengel <​harald.fernengel@nokia.com>

Reviewed by NOBODY

Fix ambiguity in abs(long int) call by calling labs() instead

  • wtf/DateMath.cpp: replace call to abs() with labs()
10:39 PM Changeset in webkit [46745] by levin@chromium.org
  • 5 edits in trunk/WebCore

2009-08-03 Christian Plesner Hansen <​christian.plesner.hansen@gmail.com>

Reviewed by David Levin.

[V8] Cache atomic strings in externalized v8 strings
​https://bugs.webkit.org/show_bug.cgi?id=27762

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::webcoreString): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::toStringResource): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString):
  • bindings/v8/V8Binding.h: (WebCore::):
  • dom/Document.idl:
7:24 PM UsingGitWithWebKit edited by joepeck02@gmail.com
Added Section on Ignores (diff)
7:21 PM Changeset in webkit [46744] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-03 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: DOM Storage Live Updating Should Not Affect Tabbing
​https://bugs.webkit.org/show_bug.cgi?id=27957

  • inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._startEditing): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): enable storage event listener
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): quick return if no listener
7:14 PM Changeset in webkit [46743] by abarth@webkit.org
  • 6 edits in trunk

2009-08-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
​https://bugs.webkit.org/show_bug.cgi?id=27934

2009-08-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
​https://bugs.webkit.org/show_bug.cgi?id=27934

  • WebCore.pro:

2009-08-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
​https://bugs.webkit.org/show_bug.cgi?id=27934

  • WebKit.pri:
6:29 PM Changeset in webkit [46742] by pkasting@chromium.org
  • 3 edits in trunk/WebKitTools

2009-08-03 Peter Kasting <​pkasting@google.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any kind of line endings in svn-apply and svn-unapply, instead
of assuming LF.

  • Scripts/svn-apply:
  • Scripts/svn-unapply:
6:08 PM Changeset in webkit [46741] by jorlow@chromium.org
  • 7 edits in trunk/WebCore

2009-08-03 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Chromium code sometimes isn't sandboxed and needs to access the FS.
​https://bugs.webkit.org/show_bug.cgi?id=27954

These changes are the WebKit side of ​http://codereview.chromium.org/159778 which
aims to make LocalStorage persistent.

This change runs all FileSystem routines through the ChromiumBridge so that
WebKitClients can handle them if they choose to. For now, the only such client
will be the one running in the browser process.

It also adds a method called sandboxEnabled to the Chromium bridge so that the
SQLite file system code can shift its behavior depending on whether we're
inside a sandbox or not.

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileModificationTime): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists):
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
5:43 PM Changeset in webkit [46740] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2009-08-03 Alpha Lam <​hclam@chromium.org>

Reviewed by David Levin.

[chromium] Implement media slider for chromium
​https://bugs.webkit.org/show_bug.cgi?id=27859

Implemented the media slider for chromium port. The implementation
is using Skia for drawing the thumb and buffered region instead of
using any native system controls so different platforms would have
the same look and feel.

No new tests because this is covered by existing tests.

  • css/mediaControlsChromium.css:
  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp:
5:28 PM Changeset in webkit [46739] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool land-patches needs --queue mode
​https://bugs.webkit.org/show_bug.cgi?id=27961

Add a --commit-queue command line option to suppress user interaction.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
4:48 PM Changeset in webkit [46738] by pkasting@chromium.org
  • 12 edits in trunk/WebCore

2009-07-27 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26460
Plumbing and cleanup in advance of returning multiple frames from the
ICOImageDecoder:

  • Make ImageDecoder::frameCount() return a size_t like ImageSource::frameCount() and BitmapImage::frameCount() already do.
  • Add ImageDecoder::frameSizeAtIndex() alongside size(), to report the size of a particular frame. Hook all the ImageSource::frameSizeAtIndex() implementations to this. No ImageDecoder implements this yet; that will come in my next change.
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::frameCount): returns size_t.
  • platform/graphics/qt/ImageDecoderQt.h: frameCount() returns size_t.
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
  • platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::size): Clarify comment. (WebCore::ImageDecoder::frameSizeAtIndex): Add. (WebCore::ImageDecoder::frameCount): returns size_t. (WebCore::ImageDecoder::frameBufferAtIndex): Remove unneeded param name.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameCount): returns size_t. (WebCore::GIFImageDecoder::frameBufferAtIndex): frameCount() returns size_t.
  • platform/image-decoders/gif/GIFImageDecoder.h: frameCount() returns size_t.
4:42 PM Changeset in webkit [46737] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Build fix. Add installsrc, installhdrs and install targets.

  • DumpRenderTree/mac/PerlSupport/Makefile:
3:59 PM Changeset in webkit [46736] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-08-03 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Darin Adler.

Fix a bug that could cause an ASSERT to fail incorrectly, leading
to a renderer crash in Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=27947

All tests in storage/ pass.

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::~SQLiteTransaction): (WebCore::SQLiteTransaction::begin):
3:05 PM Changeset in webkit [46735] by mrowe@apple.com
  • 4 edits in trunk/WebKitSite

Update two WordPress plug-ins that we use.

  • blog/wp-content/plugins/akismet/akismet.php:
  • blog/wp-content/plugins/akismet/readme.txt:
  • blog/wp-content/plugins/commentcontrol.php:
3:02 PM Changeset in webkit [46734] by mrowe@apple.com
  • 1 edit
    2 copies
    15 moves
    114 adds
    129 deletes in trunk/WebKitSite

Add some missing files and delete some obsolete files.

  • blog:
2:55 PM Changeset in webkit [46733] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

Based on work by Yael Aharon.

Implement keyboard event forwarding for windowless plugins
for the Qt port.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::setSharedXEventFields): (WebCore::setXKeyEventSpecificFields): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • xml/NativeXPathNSResolver.cpp:
2:28 PM Changeset in webkit [46732] by timothy@apple.com
  • 8 edits
    1 move
    2 adds in trunk/WebCore

Make the bottom "drawer" of the Web Inspector more extensible to support other views.

2009-08-03 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Make Bottom "Drawer" More Extensible To Support Other Views
​https://bugs.webkit.org/show_bug.cgi?id=27928

  • English.lproj/localizedStrings.js:

"Show changes view", "Hide changes view", "Clear changes log", "%d style change", "%d style changes"

To be a new view to show Changes made via the inspector. DOM, CSS, or otherwise.

  • inspector/front-end/Console.js: Removed.

Sliding View aspect moved to Drawer.js. The "console" itself has moved to ConsoleView.js

  • inspector/front-end/ConsoleView.js: Added.

Little has changed from its move from Console.js other then support for working with the Drawer.

Allow for multiple views inside the Sliding Drawer.

Starting work on the "Changes" Panel. The ability to generate a Stylesheet from Styles added via the Inspector.

  • inspector/front-end/Images/styleIcon.png: Added.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isInspectorStylesheet): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): (WebInspector.StylePropertyTreeElement.prototype):

Interface with ElementsPanel for generating a Stylesheet of Changes.

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: Refactored to allow for multiple views in the drawer.
  • inspector/front-end/inspector.html: Refactored to allow for multiple views in the drawer.

Support for the drawer and "styles changed icon" similar to the "errors and warnings" icons.

2:24 PM Changeset in webkit [46731] by mrowe@apple.com
  • 338 edits
    18 copies
    1 move
    133 adds
    14 deletes in trunk/WebKitSite

Update WordPress to the latest version.

  • blog:
2:00 PM Changeset in webkit [46730] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Dean McNamee <​deanm@chromium.org>

Reviewed by Adam Barth.

Correct an assert on a PassRefPtr in the v8 svg bindings.
​https://bugs.webkit.org/show_bug.cgi?id=27951

  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper):
1:23 PM Changeset in webkit [46729] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-03 Jan Michael Alonzo <​jmalonzo@webkit.org>

[Gtk] Skip accessibility/input-slider.html as it needs
Accessibility support in DRT which the Gtk do not have an
implementation at the moment.

  • platform/gtk/Skipped:
1:00 PM Changeset in webkit [46728] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2009-08-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly

Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.

Test: fast/css/large-list-of-rules-crash.html

  • css/CSSStyleSelector.h: (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleDataList::~CSSRuleDataList):

LayoutTests:

2009-08-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Sam Weinig.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly

Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.

  • fast/css/large-list-of-rules-crash-expected.txt: Added.
  • fast/css/large-list-of-rules-crash.html: Added.
  • fast/css/resources/large-list-of-rules-crash.css: Added.
12:40 PM Changeset in webkit [46727] by Simon Fraser
  • 20 edits in trunk

2009-08-03 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Make the DRT APIs to pause transitions and animations work for accelerated animations
<​https://bugs.webkit.org/show_bug.cgi?id=27627>
<rdar://problem/6442932>

Fix the 'pauseAnimationAtTimeOnElementWithId' and 'pauseTransitionAtTimeOnElementWithId' APIs
available to LayoutTests to work with accelerated animations and transitions. Done by sending
the pause time down to the GraphicsLayer, and using it to stop time on the layer.

I also added an assertion to check that the animation has actually started when we
try to pause it, to check that the pause time we compute is valid. This revealed a number
of tests that tried to pause before animations started, required some amount of test fixing.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::freezeAtTime):
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::suspendAnimations):
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::suspendAnimations):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::suspendAnimations):
  • rendering/RenderLayerBacking.h:
11:47 AM Changeset in webkit [46726] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Fix Chromium build by removing PluginView.h from Page.cpp.
Chromium doesn't use PluginView and the pointer is never
dereferenced so the header doesn't need to be included.
​https://bugs.webkit.org/show_bug.cgi?id=27946

No new tests because this is a build fix.

  • page/Page.cpp:
11:46 AM Changeset in webkit [46725] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed the Tiger build.

  • wtf/FastMalloc.cpp:
11:34 AM Changeset in webkit [46724] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Don't use background thread to scavenge memory on Tiger until we figure out why it causes a crash.
​https://bugs.webkit.org/show_bug.cgi?id=27900

  • wtf/FastMalloc.cpp:
11:00 AM Changeset in webkit [46723] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

One more build fix after ​https://bugs.webkit.org/show_bug.cgi?id=46720.

Unreviewed.

  • WebCoreSources.bkl:
10:34 AM Changeset in webkit [46722] by eric.carlson@apple.com
  • 5 edits in trunk/WebCore

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

Build fix after ​https://bugs.webkit.org/show_bug.cgi?id=46720.

Unreviewed.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
10:13 AM Changeset in webkit [46721] by Chris Fleizach
  • 6 edits
    2 adds in trunk

Bug 27943 - Need to implement ARIA role="radiogroup"
​https://bugs.webkit.org/show_bug.cgi?id=27943

10:07 AM Changeset in webkit [46720] by eric.carlson@apple.com
  • 14 edits
    4 adds in trunk

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
​https://bugs.webkit.org/show_bug.cgi?id=27941

Test: accessibility/input-slider.html

  • WebCore.xcodeproj/project.pbxproj:

Add AccessibilitySlider.cpp/.h

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate):

Create AccessibilitySlider and AccessibilitySliderThumb.

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):

Add default, do nothing, base class methods.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):

Correct typo.

  • accessibility/AccessibilitySlider.cpp: Added. (WebCore::AccessibilitySlider::AccessibilitySlider): (WebCore::AccessibilitySlider::create): (WebCore::AccessibilitySlider::children): (WebCore::AccessibilitySlider::addChildren): (WebCore::AccessibilitySlider::getAttribute): (WebCore::AccessibilitySlider::valueForRange): (WebCore::AccessibilitySlider::maxValueForRange): (WebCore::AccessibilitySlider::minValueForRange): (WebCore::AccessibilitySlider::changeValue): (WebCore::AccessibilitySlider::setValue): (WebCore::AccessibilitySlider::increment): (WebCore::AccessibilitySlider::decrement): (WebCore::AccessibilitySlider::element): (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::create): (WebCore::AccessibilitySliderThumb::elementRect): (WebCore::AccessibilitySliderThumb::size):
  • accessibility/AccessibilitySlider.h: Added. (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
  • accessibility/mac/AccessibilityObjectWrapper.mm: (RoleEntry::):

SliderThumbRole -> NSAccessibilityValueIndicatorRole

(-[AccessibilityObjectWrapper roleDescription]):

Return role description for NSAccessibilitySliderRole and NSAccessibilityValueIndicatorRole.

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Minor coding style correction.

(-[AccessibilityObjectWrapper accessibilityPerformPressAction]):

If attachement view handles press action, don't also call object wrapper.

(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):

New, call object's increment() method.

(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):

New, call object's decrement() method.

(-[AccessibilityObjectWrapper accessibilityPerformAction:]):

Respond to NSAccessibilityIncrementAction and NSAccessibilityDecrementAction.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::thumbRect):

Factor logic out of layout so AccessibilitySliderThumb can get thumb location/size.

(WebCore::RenderSlider::layout):

Move code to thumbRect().

  • rendering/RenderSlider.h:

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
​https://bugs.webkit.org/show_bug.cgi?id=27941

Accessibility control of a slider required adding increment() and decrement()
methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.

  • DumpRenderTree/AccessibilityUIElement.cpp: (incrementCallback): New, call UI element increment method. (decrementCallback): New, call UI element decrement method. (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper. (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::increment): New, do nothing. (AccessibilityUIElement::decrement): New, do nothing.

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
​https://bugs.webkit.org/show_bug.cgi?id=27941


Add test for <input type=range> accessibility .

  • accessibility/input-slider.html: Added.
  • platform/mac/accessibility/input-slider-expected.txt: Added.
10:00 AM Changeset in webkit [46719] by kenneth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Build fix if Netscape plugin support is turned off
​https://bugs.webkit.org/show_bug.cgi?id=27940

  • plugins/PluginView.cpp: (WebCore::PluginView::stop): Do not call NPN_MemFree if NPAPI is disabled
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::platformStart): Empty stub.
9:12 AM Changeset in webkit [46718] by ben@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Joe Mason <​joe.mason@torchmobile.com>

Reviewed by George Staikos.

WINCE port: LOAD_WITH_ALTERED_SEARCH_PATH param of
LoadLibraryEx not supported on WINCE
​https://bugs.webkit.org/show_bug.cgi?id=27917

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):use LoadLibrary instead of LoadLibraryEx
7:50 AM Changeset in webkit [46717] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-08-03 Balazs Kelemen <​kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Do memory cleanup when running robotized QtLauncher in debug as well.

  • QtLauncher/main.cpp: (launcherMain): (main):
5:03 AM Changeset in webkit [46716] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Jan Alonzo.

Fix build break on Gtk/x86_64.
​https://bugs.webkit.org/show_bug.cgi?id=27936

Use JSVALUE64 for X86_64 LINUX, except Qt.

  • wtf/Platform.h:
3:27 AM Changeset in webkit [46715] by jmalonzo@webkit.org
  • 1 edit in trunk/ChangeLog

Fix ChangeLog - r46714 was rubber-stamped by Eric

3:23 AM Changeset in webkit [46714] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-08-03 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Eric Seidel.

[Gtk] macros in webkit.m4 should be defined once only
​https://bugs.webkit.org/show_bug.cgi?id=27929

The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.

  • autotools/webkit.m4:
2:14 AM Changeset in webkit [46713] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Remove extra linebreaks in WebCore/ChangeLog introduced in r46711

Aug 2, 2009:

11:33 PM Changeset in webkit [46712] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Xan Lopez <​xlopez@igalia.com>

Fix the GTK+ build.

  • wtf/Platform.h:
9:12 PM Changeset in webkit [46711] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-02 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

SVGElementInstance::scriptExecutionContext should call document() instead of scriptExecutionContext()

​https://bugs.webkit.org/show_bug.cgi?id=27932

There's no reason to pay for a virtual function call in this case. We

can just call document() directly because we know that element is a

Node*.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::scriptExecutionContext):

8:49 PM Changeset in webkit [46710] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-08-02 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

JSNodeCustom should call document() instead of scriptExecutionContext()
​https://bugs.webkit.org/show_bug.cgi?id=27931

We want to call document() because it's in inline function, instead of
scriptExecutionContext() because it's a virtual function. If we have a
Node*, then we know that the virtual function will always return the
document anyway.

There are more instance of this bug, but I'd like to start with a small
patch and work up.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
4:10 PM Changeset in webkit [46709] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Disabled JSVALUE32_64 on Qt builds, since all layout tests mysteriously
crash with it enabled.

  • wtf/Platform.h:
4:08 PM Changeset in webkit [46708] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-02 Sam Weinig <​sam@webkit.org>

Land updated expected result.

  • fast/js/array-filter-expected.txt:
3:48 PM Changeset in webkit [46707] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-02 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Speed up fast/js/array-filter.html by 10x in debug builds by not using an
unnecessarily large sparse array.

  • fast/js/resources/array-filter.js:
3:10 PM Changeset in webkit [46706] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <​ggaren@apple.com>

Qt build fix.

Added JSAPIValueWrapper.cpp to the build.

3:00 PM Changeset in webkit [46705] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <​ggaren@apple.com>

Windows build fix.

Exported symbols for JSAPIValueWrapper.

2:56 PM Changeset in webkit [46704] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <​ggaren@apple.com>

GTK build fix.

  • jit/JITStubs.cpp: #include <stdarg.h>, for a definition of va_start.
2:52 PM Changeset in webkit [46703] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <​ggaren@apple.com>

Qt build fix.


  • runtime/Collector.cpp: #include <limits.h>, for a definition of ULONG_MAX.
2:45 PM Changeset in webkit [46702] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <​ggaren@apple.com>

Windows build fix: Nixed JSImmediate::prototype, JSImmediate::toObject,
and JSImmediate::toThisObject, and removed their exported symbols.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • runtime/JSImmediate.cpp:
  • runtime/JSImmediate.h:
2:33 PM Changeset in webkit [46701] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Mark Rowe.

Enabled JSVALUE32_64 by default on all platforms other than x86_64 (which uses JSVALUE64).

  • wtf/Platform.h:
7:26 AM Changeset in webkit [46700] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2009-08-02 David D. Kilzer <​ddkilzer@webkit.org>

<​http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø

Reviewed by Tor Arne Vestbø.

  • Scripts/bugzilla-tool: (set_reviewer_in_changelog): Made sure reviewer is properly encoded when calling replace().
7:09 AM Changeset in webkit [46699] by vestbo@webkit.org
  • 7 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Anders Carlsson.

Share implementation of PluginView::userAgent() and userAgentStatic()

​https://bugs.webkit.org/show_bug.cgi?id=27706

Differences to the original implementation are as follows:

  • The Win port used to return 0 for userAgentStatic, but now returns the quirk mode MozillaUserAgent as the other ports.
  • plugins/PluginView.cpp: (WebCore::PluginView::userAgent): (WebCore::PluginView::userAgentStatic):
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
7:00 AM Changeset in webkit [46698] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Anders Carlsson.

Unregister plugin from PluginMainThreadScheduler if NPP_New fails

​https://bugs.webkit.org/show_bug.cgi?id=27706

Since the plugin has not been started yet (m_isStarted is not set),
calling stop() will not have any affect, so we manually unregister
in start() before returning.

  • plugins/PluginView.cpp: (WebCore::PluginView::start):
6:47 AM Changeset in webkit [46697] by vestbo@webkit.org
  • 7 edits in trunk/WebCore

2009-07-27 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Anders Calsson.

Join the various versions of PluginView::stop() into one shared implementation

​https://bugs.webkit.org/show_bug.cgi?id=27706

The platform-dependent bits are now ifdef'ed in the shared implementation,
using the XP_ defines (XP_WIN, XP_MACOSX, XP_UNIX) from npapi.h

Differences to the original implementation are as follows:

  • The Qt port unregistered the plugin before calling NP_SetWindow with a 0 window handle. Now it's done after (similar to Win)
  • The GTK and Qt ports unregistered the plugin before clearing the m_npWindow.ws_info struct. Now it's done after.
  • The Win port constructed the DropAllLocks after unsubclassing the window. Now it's done before.
  • The Mac, Qt, and GTK ports did not pass a NPSavedData struct to NP_Destroy (like the Win port). Now all ports do.
  • The Win port did not call PluginView::setCurrentPluginView() before calling to NP-functions. Now it does.
  • plugins/PluginView.cpp: (WebCore::PluginView::start): (WebCore::PluginView::~PluginView): (WebCore::PluginView::stop):
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::getValueStatic):
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePostReadFile):
1:54 AM Changeset in webkit [46696] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-08-02 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by David Levin.

Script for building the wxBrowser sample app for wx.
​https://bugs.webkit.org/show_bug.cgi?id=27619

  • wx/browser/wscript: Added.
1:54 AM Changeset in webkit [46695] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKit/wx

2009-08-02 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Jan Alonzo.

Script for building the WebKit library for wx.
​https://bugs.webkit.org/show_bug.cgi?id=27619

  • wscript: Added.
1:54 AM Changeset in webkit [46694] by abarth@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2009-08-02 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Jan Alonzo.

Script for building the JavaScriptCore library for wx.
​https://bugs.webkit.org/show_bug.cgi?id=27619

  • wscript: Added.
1:54 AM Changeset in webkit [46693] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/WebKitTools

2009-08-02 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Jan Alonzo.

Scripts needed for the waf build.
​https://bugs.webkit.org/show_bug.cgi?id=27619

  • wx/build: Added.
  • wx/build/build_utils.py: Added.
  • wx/build/settings.py: Added.
  • wx/build/waf_extensions.py: Added.
  • wx/build/wxpresets.py: Added.
1:05 AM Changeset in webkit [46692] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-02 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

DateMath depends on strftime and localtime, which need to be imported manually on WinCE
​https://bugs.webkit.org/show_bug.cgi?id=26558

  • wtf/DateMath.cpp:
12:58 AM Changeset in webkit [46691] by abarth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by Tor Arne Vestbø.

[Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible default
​https://bugs.webkit.org/show_bug.cgi?id=27866

  • Api/qwebpage.cpp: (initializeApplicationCachePathIfNecessary): (QWebPagePrivate::QWebPagePrivate):
12:41 AM Changeset in webkit [46690] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2009-07-30 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: let me *edit* css styles in the web inspector.
​https://bugs.webkit.org/show_bug.cgi?id=27124

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): added property stylesheet pointing to 1 stylesheet added to the page if needed
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): handle blank sections (WebInspector.StylesSidebarPane.prototype.addBlankSection): blank section in the correct position (WebInspector.StylesSidebarPane.prototype.appropriateSelectorForNode): helper to get a nice selector for the selectd node (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.expand): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype._dblclickEmptySpace): easily create new properties (WebInspector.StylePropertiesSection.prototype._dblclickSelector): (WebInspector.StylePropertiesSection.prototype.startEditingSelector): allow for editing selectors (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): (WebInspector.StylePropertiesSection.prototype._doesSelectorAffectSelectedNode): helper to check if a selector applies to the selected node (WebInspector.BlankStylePropertiesSection.prototype._dblclick): (WebInspector.BlankStylePropertiesSection.prototype.startEditing): (WebInspector.BlankStylePropertiesSection.prototype.editingCancelled): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): morph into a StylePropertiesSection (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
  • inspector/front-end/inspector.css:
12:33 AM Changeset in webkit [46689] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] check if proxy is present before invoking a handler
​https://bugs.webkit.org/show_bug.cgi?id=27883

Do not invoke handler function if proxy is null pointer (that would lead to access violation
anyway)

  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::callListenerFunction):
Note: See TracTimeline for information about the timeline view.