⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 4, 2009:

10:50 PM Changeset in webkit [46795] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-08-04 Simon Hausmann <Simon Hausmann>

Prospective build fix for Qt build bot: Fix dependency of HTMLNames.cpp
to both source files, HTMLTagNames.in and HTMLAttributeNames.in

  • WebCore.pro:
10:40 PM Changeset in webkit [46794] by abarth@webkit.org
  • 18 edits in trunk/LayoutTests

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] Teach ScheduledAction::execute about isolated worlds
​https://bugs.webkit.org/show_bug.cgi?id=27703

Rename queueScriptInIsolatedWorld to evaluateScriptInIsolatedWorld
because I've changed this API to be synchronous instead of asynchronous
to work around some strange behavior in the work_queue_. Turns out we
don't need the complexity of an asynchronous API to test this feature.

  • http/tests/security/isolatedWorld/all-window-properties.html:
  • http/tests/security/isolatedWorld/all-window-prototypes.html:
  • http/tests/security/isolatedWorld/body-properties.html:
  • http/tests/security/isolatedWorld/body-prototype.html:
  • http/tests/security/isolatedWorld/click-event.html:
  • http/tests/security/isolatedWorld/document-open.html:
  • http/tests/security/isolatedWorld/document-properties.html:
  • http/tests/security/isolatedWorld/document-prototype.html:
  • http/tests/security/isolatedWorld/global-variables.html:
  • http/tests/security/isolatedWorld/image-properties.html:
  • http/tests/security/isolatedWorld/image-prototype.html:
  • http/tests/security/isolatedWorld/location-properties.html:
  • http/tests/security/isolatedWorld/location-prototype.html:
  • http/tests/security/isolatedWorld/number-prototype.html:
  • http/tests/security/isolatedWorld/object-prototype.html:
  • http/tests/security/isolatedWorld/string-prototype.html:
  • http/tests/security/isolatedWorld/window-properties.html:
10:20 PM Changeset in webkit [46793] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

2009-08-04 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Adele Peterson.

Keypress should exit from pan scrolling mode.
​https://bugs.webkit.org/show_bug.cgi?id=28005

Change the logic from only exiting pan scrolling on escape to exiting on any key press,
making it easier for users to back out of an accidental pan scroll.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
9:36 PM Changeset in webkit [46792] by eric@webkit.org
  • 5 edits
    1 add in trunk

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION (r45064): Drop caret remains in text control after the mouse exits
​https://bugs.webkit.org/show_bug.cgi?id=26787

Fix some bogus comments noticed during testing.

  • fast/forms/drag-into-textarea.html:
  • fast/forms/drag-out-of-textarea.html:

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION (r45064): Drop caret remains in text control after the mouse exits
​https://bugs.webkit.org/show_bug.cgi?id=26787

Add back missing dragController()->clear() call.

  • manual-tests/drag-caret.html: Added.
  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
7:22 PM Changeset in webkit [46791] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/win

2009-08-04 Alice Liu <​alice.liu@apple.com>

"Shift + Enter" should behave like "Enter" in editable fields.
Affects backward search in find-in-page in Safari for Windows

Reviewed by Jon Honeycutt.

  • WebView.cpp: Register shift+enter as InsertNewline command, similar to other modifier+Enter combinations.
6:34 PM Changeset in webkit [46790] by eric@webkit.org
  • 2 edits
    1 add
    5 deletes in trunk/LayoutTests

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

  • platform/mac/accessibility/aria-valuetext-expected.txt: Added.
  • platform/mac/accessibility/aria-valuetext.html: Added.
5:32 PM Changeset in webkit [46789] by Chris Fleizach
  • 2 edits in trunk/WebCore

2009-08-04 Chris Fleizach <Chris Fleizach>

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

Forgot to commit attribute names.

  • html/HTMLAttributeNames.in:
5:29 PM Changeset in webkit [46788] by Chris Fleizach
  • 11 edits
    2 adds in trunk

WebCore:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

Test: platform/mac/accessibility/aria-valuetext.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::valueDescription):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::valueDescription):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  • html/HTMLAttributeNames.in:

WebKitTools:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

Expose valueDescription for accessibility.

  • DumpRenderTree/AccessibilityUIElement.cpp: (getValueDescriptionCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::valueDescription):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::valueDescription):

LayoutTests:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

  • platform/mac/accessibility/aria-valuetext-expected.txt: Added.
  • platform/mac/accessibility/aria-valuetext.html: Added.
5:21 PM Changeset in webkit [46787] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH
​https://bugs.webkit.org/show_bug.cgi?id=28006

Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig

  • DumpRenderTree/mac/PerlSupport/Makefile:
5:18 PM Changeset in webkit [46786] by darin@chromium.org
  • 19 edits in trunk

2009-08-04 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=27821

No new features, no new tests. Existing layout tests pass.

  • WebCore.base.exp:

Export AppliationCacheGroup::storeCopyOfCache

  • WebCore.xcodeproj/project.pbxproj:

Restore DOMApplicationCache.h and ApplicationCacheHost.h to 'project' headers
instead of 'private' headers since they're no longer in the DocumentLoader.h
include graph.

  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):

Reinstate the test for manifest.isNull instead of .isEmtpty().
Added a FIXME to revisit once the spec gets clarified.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::detachFromFrame):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCacheHost):

ApplicationCacheHost is held in an OwnPtr<> by DocumentLoader. This was done
for compile time friendliness, it results in a smaller include graph for files
dependent on DocumentLoader.h.

  • loader/FrameLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/ResourceLoader.cpp:

Cleanup ussage of ENABLE(xxx) around includes, generally remove those guards.
This was done for readability at the include site. The included files contain appropriate guards,
so they're not needed at the include site.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheGroup.h:

Use ApplicationCachHost defined constants, no longer depends on DOMApplicationCache.

  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): (WebCore::ApplicationCacheHost::setDOMApplicationCache): (WebCore::ApplicationCacheHost::notifyEventListener): (WebCore::ApplicationCacheHost::status):
  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeCopyOfCache):
  • loader/appcache/ApplicationCacheStorage.h:

Merge recently added transferApplicationCache and pre-existing storeCopyOfCache methods.

  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::status): (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::callListener): (WebCore::DOMApplicationCache::toEventType): (WebCore::DOMApplicationCache::toEventID):
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::setAttributeEventListener): (WebCore::DOMApplicationCache::getAttributeEventListener): (WebCore::DOMApplicationCache::clearAttributeEventListener): (WebCore::DOMApplicationCache::callEventListener): (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete):

Use ApplicationCachHost defined constants for Status and EventIDs.

4:31 PM Changeset in webkit [46785] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Add pkasting to bugzilla-tool as a committer
​https://bugs.webkit.org/show_bug.cgi?id=28002

  • Scripts/modules/committers.py:
4:20 PM Changeset in webkit [46784] by Nate Chapin
  • 3 edits in trunk/WebCore

2009-08-04 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Revert r46421 and r46769, which appear to have totally hosed the v8 bindings.

​https://bugs.webkit.org/show_bug.cgi?id=27719

4:04 PM Changeset in webkit [46783] by Chris Fleizach
  • 15 edits
    2 adds in trunk

WebCore:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27993 - AXSliders are missing required attributes and actions
​https://bugs.webkit.org/show_bug.cgi?id=27993

Expose appropriate actions and attributes for sliders.

Test: platform/mac/accessibility/slider-supports-actions.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::orientation):
  • accessibility/AccessibilityObject.h: (WebCore::):
  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
  • accessibility/AccessibilitySlider.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityActionNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

WebKitTools:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27993 - AXSliders are missing required attributes and actions
​https://bugs.webkit.org/show_bug.cgi?id=27993

Add ability to check if any arbitrary action is supported.

  • DumpRenderTree/AccessibilityUIElement.cpp: (isActionSupportedCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isActionSupported):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isActionSupported):

LayoutTests:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27993 - AXSliders are missing required attributes and actions
​https://bugs.webkit.org/show_bug.cgi?id=27993

Update tests to use more generic isActionSupported.

  • accessibility/aria-link-supports-press.html:
  • accessibility/button-press-action.html:
  • accessibility/onclick-handlers.html:
  • platform/mac/accessibility/slider-supports-actions-expected.txt: Added.
  • platform/mac/accessibility/slider-supports-actions.html: Added.
3:52 PM Changeset in webkit [46782] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-08-04 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

[V8] Fix an assert in WebCoreStringResource that causes worker script
evaluation failed.
​https://bugs.webkit.org/show_bug.cgi?id=27996

The fix is to check for the same thread, instead of the main thread.
This is because Chromium's workers use v8 in a single thread that is
not the main thread.

  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::atomicString):
3:46 PM Changeset in webkit [46781] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool unit tests need a test harness
​https://bugs.webkit.org/show_bug.cgi?id=27977

  • Scripts/run-webkit-unittests: Added.
3:19 PM Changeset in webkit [46780] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wx build fix after InspectorClient API change.

2:43 PM Changeset in webkit [46779] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

LayoutTests are too slow
​https://bugs.webkit.org/show_bug.cgi?id=27995

Shave 5 seconds off of run-webkit-tests.

  • fast/events/click-count.html: use eventSender.leapForward instead of setTimeout
2:35 PM Changeset in webkit [46778] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-04 Gavin Barraclough <​barraclough@apple.com>

Rubber Stamped by Oiver Hunt.

Revert r46643 since this breaks the Yarr::Interpreter running the v8 tests.
​https://bugs.webkit.org/show_bug.cgi?id=27874

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
1:59 PM BuildingOnWindows edited by jessieberlin@gmail.com
Move the information about setting the WebKitLibrariesDir out of the … (diff)
1:54 PM Changeset in webkit [46777] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

PPC64 Build fix

12:57 PM Changeset in webkit [46776] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-08-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Add support for transitions/animations of text-indent.

Test: transitions/text-indent-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
12:52 PM Changeset in webkit [46775] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions
by listing the DumpRenderTree binary as a dependency. Xcode has the smarts to rebuild
DumpRenderTree itself when switching OS versions so this dependency removes the need
for any smarts in the Makefile.

Rubber-stamped by Gavin "Gavvy" Barraclough.

  • DumpRenderTree/mac/PerlSupport/Makefile:
12:46 PM Changeset in webkit [46774] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Update test results after addition of AXRequired in r46768.

  • platform/mac/accessibility/lists-expected.txt:
12:38 PM Changeset in webkit [46773] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-08-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Add support for transitions of min- and max-width, and min- and max-height.
​https://bugs.webkit.org/show_bug.cgi?id=27990

Test: transitions/min-max-width-height-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
12:17 PM Changeset in webkit [46772] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs unit tests
​https://bugs.webkit.org/show_bug.cgi?id=26916

Add some basic unit testing for scm.py.

  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py: Added.
12:06 PM Changeset in webkit [46771] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking
to make sure the Skipped entries are not in the $ignoredDirectories array. Directories commonly included
are (http, media, compositing, wml, wcss).

​https://bugs.webkit.org/show_bug.cgi?id=27893

  • Scripts/run-webkit-tests:
11:15 AM Changeset in webkit [46770] by Chris Fleizach
  • 8 edits
    2 adds in trunk

Bug 27964 - WAI-ARIA: radio button does not determine its label from text content
​https://bugs.webkit.org/show_bug.cgi?id=27964

10:28 AM Changeset in webkit [46769] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-08-04 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Missed a place that expects window.event to be hidden when it shouldn't be.

​https://bugs.webkit.org/show_bug.cgi?id=27719

9:15 AM Changeset in webkit [46768] by Chris Fleizach
  • 16 edits
    2 adds in trunk

Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
​https://bugs.webkit.org/show_bug.cgi?id=27958

8:20 AM Changeset in webkit [46767] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-08-04 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslErrors.
​https://bugs.webkit.org/show_bug.cgi?id=27804

  • Api/qwebframe.cpp: (QWebFrame::requestedUrl):
  • tests/qwebframe/tst_qwebframe.cpp:
7:58 AM Changeset in webkit [46766] by ben@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-04 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Adam Treat

Explicitly include limits.h header when using INT_MAX and INT_MIN

  • interpreter/Interpreter.cpp
7:51 AM Changeset in webkit [46765] by ariya@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

2009-08-04 Ariya Hidayat <​ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Add passed test results, with pixel tests.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-composite-expected.png: Added.
  • platform/qt/fast/canvas/canvas-composite-expected.txt: Added.
  • platform/qt/fast/canvas/drawImage-expected.checksum: Added.
  • platform/qt/fast/canvas/drawImage-expected.png: Added.
  • platform/qt/fast/canvas/drawImage-expected.txt: Added.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
7:50 AM Changeset in webkit [46764] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

2009-08-04 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Rename QWebPlugin to QWebPluginInfo, as discussed on IRC.

  • Api/qwebplugindatabase.cpp: (QWebPluginInfoPrivate::QWebPluginInfoPrivate): (QWebPluginInfo::QWebPluginInfo): (QWebPluginInfo::~QWebPluginInfo): (QWebPluginInfo::name): (QWebPluginInfo::description): (QWebPluginInfo::mimeTypes): (QWebPluginInfo::supportsMimeType): (QWebPluginInfo::path): (QWebPluginInfo::isNull): (QWebPluginInfo::setEnabled): (QWebPluginInfo::isEnabled): (QWebPluginInfo::operator==): (QWebPluginInfo::operator!=): (QWebPluginInfo::operator=): (QWebPluginDatabase::plugins): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
  • Api/qwebplugindatabase.h:
  • Api/qwebplugindatabase_p.h:
  • tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
7:50 AM Changeset in webkit [46763] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

2009-08-04 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Adam Treat.

Replace QWebPlugin::MimeType with a typedef to
QWebPluginFactory::MimeType.

  • Api/qwebplugindatabase.cpp:
  • Api/qwebplugindatabase.h:
  • Api/qwebpluginfactory.cpp: (QWebPluginFactory::MimeType::operator==):
  • Api/qwebpluginfactory.h:
7:50 AM Changeset in webkit [46762] by Simon Hausmann
  • 7 edits
    6 adds in trunk

WebCore:

2009-08-04 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

Add QWebPluginDatabase API to the Qt API.

​https://bugs.webkit.org/show_bug.cgi?id=27651

  • WebCore.pro:

WebKit/qt:

2009-08-04 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

Add QWebPluginDatabase API to the Qt API.

​https://bugs.webkit.org/show_bug.cgi?id=27651

  • Api/headers.pri:
  • Api/qwebplugindatabase.cpp: Added. (QWebPluginPrivate::QWebPluginPrivate): (QWebPluginDatabasePrivate::QWebPluginDatabasePrivate): (QWebPlugin::MimeType::operator==): (QWebPlugin::QWebPlugin): (QWebPlugin::~QWebPlugin): (QWebPlugin::name): (QWebPlugin::description): (QWebPlugin::mimeTypes): (QWebPlugin::supportsMimeType): (QWebPlugin::path): (QWebPlugin::isNull): (QWebPlugin::setEnabled): (QWebPlugin::isEnabled): (QWebPlugin::operator==): (QWebPlugin::operator!=): (QWebPlugin::operator=): (QWebPluginDatabase::QWebPluginDatabase): (QWebPluginDatabase::~QWebPluginDatabase): (QWebPluginDatabase::plugins): (QWebPluginDatabase::defaultSearchPaths): (QWebPluginDatabase::searchPaths): (QWebPluginDatabase::setSearchPaths): (QWebPluginDatabase::addSearchPath): (QWebPluginDatabase::refresh): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
  • Api/qwebplugindatabase.h: Added.
  • Api/qwebplugindatabase_p.h: Added.
  • Api/qwebsettings.cpp: (QWebSettings::pluginDatabase):
  • Api/qwebsettings.h:
  • tests/qwebplugindatabase/qwebplugindatabase.pro: Added.
  • tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: Added. (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
  • tests/tests.pro:
7:34 AM Changeset in webkit [46761] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-08-04 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Adam Treat.

[Qt] PlusDarker is not supported. Fall back to CompositionMode_Darken
(as it is the closest match) instead of CompositionMode_SourceOver.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
7:24 AM Changeset in webkit [46760] by ariya@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Adam Treat.

[Qt] Fix the metrics.

  • platform/qt/fast/canvas/canvas-before-css-expected.txt:
6:30 AM Changeset in webkit [46759] by ariya@webkit.org
  • 3 edits
    14 adds in trunk/LayoutTests

2009-08-04 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Add pixel tests result.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-as-image-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-as-image-expected.png: Added.
  • platform/qt/fast/canvas/canvas-as-image-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-before-css-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/qt/fast/canvas/canvas-before-css-expected.txt:
  • platform/qt/fast/canvas/canvas-bg-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-bg-expected.png: Added.
  • platform/qt/fast/canvas/canvas-bg-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-bg-zoom-expected.png: Added.
  • platform/qt/fast/canvas/canvas-bg-zoom-expected.txt: Added.
6:26 AM Changeset in webkit [46758] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Adam Treat <​adam.treat@torchmobile.com>

Fix buildbot. This was supposed to be part of the last commit r46757, but the hunk never made it in.

  • platform/qt/fast/block/float/033-expected.txt:
5:45 AM EFLWebKit edited by tonikitoo@gmail.com
(diff)
5:22 AM Changeset in webkit [46757] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2009-08-04 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Remove LayoutTests/fast/block/float/033.html from the Qt Skipped list

The expected value was incorrect and it has been modified. The new expected value is similar to the MAC version as well.

  • platform/qt/Skipped:
  • platform/qt/fast/block/float/033-expected.txt:
2:28 AM Changeset in webkit [46756] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-04 Christian Plesner Hansen <​christian.plesner.hansen@gmail.com>

Reviewed by Adam Barth.

[v8] Fix crash when converting empty v8 string to atomic webkit string.
​https://bugs.webkit.org/show_bug.cgi?id=27975

collection-null-like-arguments.html tests for this.

  • bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
2:26 AM Changeset in webkit [46755] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool --commit-queue should validate commit-queue setter is a committer
​https://bugs.webkit.org/show_bug.cgi?id=27974

With a test!

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py:
1:59 AM Changeset in webkit [46754] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=27973

The trailing comma (suppresses newlines) was lost in r46700.

  • Scripts/bugzilla-tool:
1:54 AM Changeset in webkit [46753] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool has too many fatal errors
​https://bugs.webkit.org/show_bug.cgi?id=27969

Replace several fatal errors with ScriptError exceptions.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
1:34 AM Changeset in webkit [46752] by eric@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

2009-08-04 Eric Seidel <​eric@webkit.org>

No review, ChangeLog fix only.

Fix a ChangeLog line-spacing disaster caused by:
​https://bugs.webkit.org/show_bug.cgi?id=27973

Still unsure what the fix for bugzilla-tool will be.

1:18 AM Changeset in webkit [46751] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool --commit-queue should only land commit-queue+ patches
​https://bugs.webkit.org/show_bug.cgi?id=27970

commit-queue mode for bugzilla-tool
​https://bugs.webkit.org/show_bug.cgi?id=27918

Make bugzilla tool smart enough to find the commit-queue+ flags and
land those patches.
When we call land-patches with --commit-queue, we should filter the
patches we land to only those that have the commit-queue+ flag set.
That way, when we call bugzilla-tool from a main commit queue process,
we won't land the wrong patches.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
1:14 AM Changeset in webkit [46750] by eric@webkit.org
  • 2 edits
    3 adds in trunk/WebKitTools

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

committer logic should be split out of bugzilla.py into its own module

​https://bugs.webkit.org/show_bug.cgi?id=27972

I also added unit tests for the functionality I added.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py: Added.
  • Scripts/modules/commiters_unittest.py: Added.
  • Scripts/modules/committers.py: Added.
12:13 AM Changeset in webkit [46749] by rniwa@webkit.org
  • 4 edits in trunk/WebCore

2009-08-04 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

selectionHasStyle needs clean up to fix Bug 27858
​https://bugs.webkit.org/show_bug.cgi?id=27865

This patch cleans up selectionStartHasStyle and selectionHasStyle.
No test is added because the patch does not change any behavior.

  • editing/ApplyStyleCommand.cpp: (WebCore::getPropertiesNotInComputedStyle): Used in triStateOfStyleInComputedStyle but will be used here as well
  • editing/ApplyStyleCommand.h: Added the prototype of getPropertiesNotInComputedStyle
  • editing/Editor.cpp: (WebCore::triStateOfStyleInComputedStyle): Determines if the specified style is present in the specified computed style. (WebCore::Editor::selectionStartHasStyle): Uses triStateOfStyleInComputedStyle (WebCore::Editor::selectionHasStyle): Uses triStateOfStyleInComputedStyle instead of updateState
12:06 AM Changeset in webkit [46748] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-08-03 John Abd-El-Malek <​jam@chromium.org>

Reviewed by David Levin.

Fix MessagePort construction in worker process. Also make the other object constructions match this.

​https://bugs.webkit.org/show_bug.cgi?id=27906

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToV8Object):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):

Aug 3, 2009:

11:34 PM Changeset in webkit [46747] by abarth@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixup ChangeLog

11:14 PM Changeset in webkit [46746] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-03 Harald Fernengel <​harald.fernengel@nokia.com>

Reviewed by NOBODY

Fix ambiguity in abs(long int) call by calling labs() instead

  • wtf/DateMath.cpp: replace call to abs() with labs()
10:39 PM Changeset in webkit [46745] by levin@chromium.org
  • 5 edits in trunk/WebCore

2009-08-03 Christian Plesner Hansen <​christian.plesner.hansen@gmail.com>

Reviewed by David Levin.

[V8] Cache atomic strings in externalized v8 strings
​https://bugs.webkit.org/show_bug.cgi?id=27762

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::webcoreString): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::toStringResource): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString):
  • bindings/v8/V8Binding.h: (WebCore::):
  • dom/Document.idl:
7:24 PM UsingGitWithWebKit edited by joepeck02@gmail.com
Added Section on Ignores (diff)
7:21 PM Changeset in webkit [46744] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-03 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: DOM Storage Live Updating Should Not Affect Tabbing
​https://bugs.webkit.org/show_bug.cgi?id=27957

  • inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._startEditing): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): enable storage event listener
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): quick return if no listener
7:14 PM Changeset in webkit [46743] by abarth@webkit.org
  • 6 edits in trunk

2009-08-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
​https://bugs.webkit.org/show_bug.cgi?id=27934

2009-08-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
​https://bugs.webkit.org/show_bug.cgi?id=27934

  • WebCore.pro:

2009-08-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Consolidate common gcc flags to WebKit.pri
​https://bugs.webkit.org/show_bug.cgi?id=27934

  • WebKit.pri:
6:29 PM Changeset in webkit [46742] by pkasting@chromium.org
  • 3 edits in trunk/WebKitTools

2009-08-03 Peter Kasting <​pkasting@google.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any kind of line endings in svn-apply and svn-unapply, instead
of assuming LF.

  • Scripts/svn-apply:
  • Scripts/svn-unapply:
6:08 PM Changeset in webkit [46741] by jorlow@chromium.org
  • 7 edits in trunk/WebCore

2009-08-03 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Chromium code sometimes isn't sandboxed and needs to access the FS.
​https://bugs.webkit.org/show_bug.cgi?id=27954

These changes are the WebKit side of ​http://codereview.chromium.org/159778 which
aims to make LocalStorage persistent.

This change runs all FileSystem routines through the ChromiumBridge so that
WebKitClients can handle them if they choose to. For now, the only such client
will be the one running in the browser process.

It also adds a method called sandboxEnabled to the Chromium bridge so that the
SQLite file system code can shift its behavior depending on whether we're
inside a sandbox or not.

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileModificationTime): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists):
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
5:43 PM Changeset in webkit [46740] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2009-08-03 Alpha Lam <​hclam@chromium.org>

Reviewed by David Levin.

[chromium] Implement media slider for chromium
​https://bugs.webkit.org/show_bug.cgi?id=27859

Implemented the media slider for chromium port. The implementation
is using Skia for drawing the thumb and buffered region instead of
using any native system controls so different platforms would have
the same look and feel.

No new tests because this is covered by existing tests.

  • css/mediaControlsChromium.css:
  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp:
5:28 PM Changeset in webkit [46739] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool land-patches needs --queue mode
​https://bugs.webkit.org/show_bug.cgi?id=27961

Add a --commit-queue command line option to suppress user interaction.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
4:48 PM Changeset in webkit [46738] by pkasting@chromium.org
  • 12 edits in trunk/WebCore

2009-07-27 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26460
Plumbing and cleanup in advance of returning multiple frames from the
ICOImageDecoder:

  • Make ImageDecoder::frameCount() return a size_t like ImageSource::frameCount() and BitmapImage::frameCount() already do.
  • Add ImageDecoder::frameSizeAtIndex() alongside size(), to report the size of a particular frame. Hook all the ImageSource::frameSizeAtIndex() implementations to this. No ImageDecoder implements this yet; that will come in my next change.
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::frameCount): returns size_t.
  • platform/graphics/qt/ImageDecoderQt.h: frameCount() returns size_t.
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
  • platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::size): Clarify comment. (WebCore::ImageDecoder::frameSizeAtIndex): Add. (WebCore::ImageDecoder::frameCount): returns size_t. (WebCore::ImageDecoder::frameBufferAtIndex): Remove unneeded param name.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameCount): returns size_t. (WebCore::GIFImageDecoder::frameBufferAtIndex): frameCount() returns size_t.
  • platform/image-decoders/gif/GIFImageDecoder.h: frameCount() returns size_t.
4:42 PM Changeset in webkit [46737] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Build fix. Add installsrc, installhdrs and install targets.

  • DumpRenderTree/mac/PerlSupport/Makefile:
3:59 PM Changeset in webkit [46736] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-08-03 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Darin Adler.

Fix a bug that could cause an ASSERT to fail incorrectly, leading
to a renderer crash in Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=27947

All tests in storage/ pass.

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::~SQLiteTransaction): (WebCore::SQLiteTransaction::begin):
3:05 PM Changeset in webkit [46735] by mrowe@apple.com
  • 4 edits in trunk/WebKitSite

Update two WordPress plug-ins that we use.

  • blog/wp-content/plugins/akismet/akismet.php:
  • blog/wp-content/plugins/akismet/readme.txt:
  • blog/wp-content/plugins/commentcontrol.php:
3:02 PM Changeset in webkit [46734] by mrowe@apple.com
  • 1 edit
    2 copies
    15 moves
    114 adds
    129 deletes in trunk/WebKitSite

Add some missing files and delete some obsolete files.

  • blog:
2:55 PM Changeset in webkit [46733] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

Based on work by Yael Aharon.

Implement keyboard event forwarding for windowless plugins
for the Qt port.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::setSharedXEventFields): (WebCore::setXKeyEventSpecificFields): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • xml/NativeXPathNSResolver.cpp:
2:28 PM Changeset in webkit [46732] by timothy@apple.com
  • 8 edits
    1 move
    2 adds in trunk/WebCore

Make the bottom "drawer" of the Web Inspector more extensible to support other views.

2009-08-03 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Make Bottom "Drawer" More Extensible To Support Other Views
​https://bugs.webkit.org/show_bug.cgi?id=27928

  • English.lproj/localizedStrings.js:

"Show changes view", "Hide changes view", "Clear changes log", "%d style change", "%d style changes"

To be a new view to show Changes made via the inspector. DOM, CSS, or otherwise.

  • inspector/front-end/Console.js: Removed.

Sliding View aspect moved to Drawer.js. The "console" itself has moved to ConsoleView.js

  • inspector/front-end/ConsoleView.js: Added.

Little has changed from its move from Console.js other then support for working with the Drawer.

Allow for multiple views inside the Sliding Drawer.

Starting work on the "Changes" Panel. The ability to generate a Stylesheet from Styles added via the Inspector.

  • inspector/front-end/Images/styleIcon.png: Added.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isInspectorStylesheet): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): (WebInspector.StylePropertyTreeElement.prototype):

Interface with ElementsPanel for generating a Stylesheet of Changes.

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: Refactored to allow for multiple views in the drawer.
  • inspector/front-end/inspector.html: Refactored to allow for multiple views in the drawer.

Support for the drawer and "styles changed icon" similar to the "errors and warnings" icons.

2:24 PM Changeset in webkit [46731] by mrowe@apple.com
  • 338 edits
    18 copies
    1 move
    133 adds
    14 deletes in trunk/WebKitSite

Update WordPress to the latest version.

  • blog:
2:00 PM Changeset in webkit [46730] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Dean McNamee <​deanm@chromium.org>

Reviewed by Adam Barth.

Correct an assert on a PassRefPtr in the v8 svg bindings.
​https://bugs.webkit.org/show_bug.cgi?id=27951

  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper):
1:23 PM Changeset in webkit [46729] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-03 Jan Michael Alonzo <​jmalonzo@webkit.org>

[Gtk] Skip accessibility/input-slider.html as it needs
Accessibility support in DRT which the Gtk do not have an
implementation at the moment.

  • platform/gtk/Skipped:
1:00 PM Changeset in webkit [46728] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2009-08-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly

Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.

Test: fast/css/large-list-of-rules-crash.html

  • css/CSSStyleSelector.h: (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleDataList::~CSSRuleDataList):

LayoutTests:

2009-08-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Sam Weinig.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly

Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.

  • fast/css/large-list-of-rules-crash-expected.txt: Added.
  • fast/css/large-list-of-rules-crash.html: Added.
  • fast/css/resources/large-list-of-rules-crash.css: Added.
12:40 PM Changeset in webkit [46727] by Simon Fraser
  • 20 edits in trunk

2009-08-03 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Make the DRT APIs to pause transitions and animations work for accelerated animations
<​https://bugs.webkit.org/show_bug.cgi?id=27627>
<rdar://problem/6442932>

Fix the 'pauseAnimationAtTimeOnElementWithId' and 'pauseTransitionAtTimeOnElementWithId' APIs
available to LayoutTests to work with accelerated animations and transitions. Done by sending
the pause time down to the GraphicsLayer, and using it to stop time on the layer.

I also added an assertion to check that the animation has actually started when we
try to pause it, to check that the pause time we compute is valid. This revealed a number
of tests that tried to pause before animations started, required some amount of test fixing.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::freezeAtTime):
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::suspendAnimations):
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::suspendAnimations):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::suspendAnimations):
  • rendering/RenderLayerBacking.h:
11:47 AM Changeset in webkit [46726] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-03 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Fix Chromium build by removing PluginView.h from Page.cpp.
Chromium doesn't use PluginView and the pointer is never
dereferenced so the header doesn't need to be included.
​https://bugs.webkit.org/show_bug.cgi?id=27946

No new tests because this is a build fix.

  • page/Page.cpp:
11:46 AM Changeset in webkit [46725] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed the Tiger build.

  • wtf/FastMalloc.cpp:
11:34 AM Changeset in webkit [46724] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Don't use background thread to scavenge memory on Tiger until we figure out why it causes a crash.
​https://bugs.webkit.org/show_bug.cgi?id=27900

  • wtf/FastMalloc.cpp:
11:00 AM Changeset in webkit [46723] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

One more build fix after ​https://bugs.webkit.org/show_bug.cgi?id=46720.

Unreviewed.

  • WebCoreSources.bkl:
10:34 AM Changeset in webkit [46722] by eric.carlson@apple.com
  • 5 edits in trunk/WebCore

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

Build fix after ​https://bugs.webkit.org/show_bug.cgi?id=46720.

Unreviewed.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
10:13 AM Changeset in webkit [46721] by Chris Fleizach
  • 6 edits
    2 adds in trunk

Bug 27943 - Need to implement ARIA role="radiogroup"
​https://bugs.webkit.org/show_bug.cgi?id=27943

10:07 AM Changeset in webkit [46720] by eric.carlson@apple.com
  • 14 edits
    4 adds in trunk

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
​https://bugs.webkit.org/show_bug.cgi?id=27941

Test: accessibility/input-slider.html

  • WebCore.xcodeproj/project.pbxproj:

Add AccessibilitySlider.cpp/.h

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate):

Create AccessibilitySlider and AccessibilitySliderThumb.

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):

Add default, do nothing, base class methods.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):

Correct typo.

  • accessibility/AccessibilitySlider.cpp: Added. (WebCore::AccessibilitySlider::AccessibilitySlider): (WebCore::AccessibilitySlider::create): (WebCore::AccessibilitySlider::children): (WebCore::AccessibilitySlider::addChildren): (WebCore::AccessibilitySlider::getAttribute): (WebCore::AccessibilitySlider::valueForRange): (WebCore::AccessibilitySlider::maxValueForRange): (WebCore::AccessibilitySlider::minValueForRange): (WebCore::AccessibilitySlider::changeValue): (WebCore::AccessibilitySlider::setValue): (WebCore::AccessibilitySlider::increment): (WebCore::AccessibilitySlider::decrement): (WebCore::AccessibilitySlider::element): (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::create): (WebCore::AccessibilitySliderThumb::elementRect): (WebCore::AccessibilitySliderThumb::size):
  • accessibility/AccessibilitySlider.h: Added. (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
  • accessibility/mac/AccessibilityObjectWrapper.mm: (RoleEntry::):

SliderThumbRole -> NSAccessibilityValueIndicatorRole

(-[AccessibilityObjectWrapper roleDescription]):

Return role description for NSAccessibilitySliderRole and NSAccessibilityValueIndicatorRole.

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Minor coding style correction.

(-[AccessibilityObjectWrapper accessibilityPerformPressAction]):

If attachement view handles press action, don't also call object wrapper.

(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):

New, call object's increment() method.

(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):

New, call object's decrement() method.

(-[AccessibilityObjectWrapper accessibilityPerformAction:]):

Respond to NSAccessibilityIncrementAction and NSAccessibilityDecrementAction.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::thumbRect):

Factor logic out of layout so AccessibilitySliderThumb can get thumb location/size.

(WebCore::RenderSlider::layout):

Move code to thumbRect().

  • rendering/RenderSlider.h:

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
​https://bugs.webkit.org/show_bug.cgi?id=27941

Accessibility control of a slider required adding increment() and decrement()
methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.

  • DumpRenderTree/AccessibilityUIElement.cpp: (incrementCallback): New, call UI element increment method. (decrementCallback): New, call UI element decrement method. (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper. (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::increment): New, do nothing. (AccessibilityUIElement::decrement): New, do nothing.

2009-08-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLInputElement is not controllable by assistive technologies
​https://bugs.webkit.org/show_bug.cgi?id=27941


Add test for <input type=range> accessibility .

  • accessibility/input-slider.html: Added.
  • platform/mac/accessibility/input-slider-expected.txt: Added.
10:00 AM Changeset in webkit [46719] by kenneth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Build fix if Netscape plugin support is turned off
​https://bugs.webkit.org/show_bug.cgi?id=27940

  • plugins/PluginView.cpp: (WebCore::PluginView::stop): Do not call NPN_MemFree if NPAPI is disabled
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::platformStart): Empty stub.
9:12 AM Changeset in webkit [46718] by ben@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Joe Mason <​joe.mason@torchmobile.com>

Reviewed by George Staikos.

WINCE port: LOAD_WITH_ALTERED_SEARCH_PATH param of
LoadLibraryEx not supported on WINCE
​https://bugs.webkit.org/show_bug.cgi?id=27917

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):use LoadLibrary instead of LoadLibraryEx
7:50 AM Changeset in webkit [46717] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-08-03 Balazs Kelemen <​kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Do memory cleanup when running robotized QtLauncher in debug as well.

  • QtLauncher/main.cpp: (launcherMain): (main):
5:03 AM Changeset in webkit [46716] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Jan Alonzo.

Fix build break on Gtk/x86_64.
​https://bugs.webkit.org/show_bug.cgi?id=27936

Use JSVALUE64 for X86_64 LINUX, except Qt.

  • wtf/Platform.h:
3:27 AM Changeset in webkit [46715] by jmalonzo@webkit.org
  • 1 edit in trunk/ChangeLog

Fix ChangeLog - r46714 was rubber-stamped by Eric

3:23 AM Changeset in webkit [46714] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-08-03 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Eric Seidel.

[Gtk] macros in webkit.m4 should be defined once only
​https://bugs.webkit.org/show_bug.cgi?id=27929

The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.

  • autotools/webkit.m4:
2:14 AM Changeset in webkit [46713] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Remove extra linebreaks in WebCore/ChangeLog introduced in r46711

Note: See TracTimeline for information about the timeline view.