⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 5, 2009:

11:57 PM Changeset in webkit [46837] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-05 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct
​https://bugs.webkit.org/show_bug.cgi?id=27875

Inherits ScopeNodeData struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/parser/Nodes.cpp:1848.

  • parser/Nodes.h:
11:53 PM Changeset in webkit [46836] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-05 Xan Lopez <​xlopez@igalia.com>

Skip new test using eventSender, since the GTK+ port does not have
it yet.

  • platform/gtk/Skipped:
11:10 PM Changeset in webkit [46835] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

11:10 PM Changeset in webkit [46834] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.10

New tag.

11:08 PM Changeset in webkit [46833] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebKit/win

Merge r46638.

10:33 PM Changeset in webkit [46832] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-08-05 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Add floating point support for generic ARM port.
​https://bugs.webkit.org/show_bug.cgi?id=24986

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::doubleTransfer):
  • assembler/ARMAssembler.h: (JSC::ARM::): (JSC::ARMAssembler::): (JSC::ARMAssembler::faddd_r): (JSC::ARMAssembler::fsubd_r): (JSC::ARMAssembler::fmuld_r): (JSC::ARMAssembler::fcmpd_r): (JSC::ARMAssembler::fdtr_u): (JSC::ARMAssembler::fdtr_d): (JSC::ARMAssembler::fmsr_r): (JSC::ARMAssembler::fsitod_r): (JSC::ARMAssembler::fmstat):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::): (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::storeDouble): (JSC::MacroAssemblerARM::addDouble): (JSC::MacroAssemblerARM::subDouble): (JSC::MacroAssemblerARM::mulDouble): (JSC::MacroAssemblerARM::convertInt32ToDouble): (JSC::MacroAssemblerARM::branchDouble):
  • jit/JIT.h:
10:22 PM Changeset in webkit [46831] by barraclough@apple.com
  • 11 edits in trunk/JavaScriptCore

2009-08-05 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Add JIT support for generic ARM port without optimizations.
​https://bugs.webkit.org/show_bug.cgi?id=24986

All JIT optimizations are disabled.

Signed off by Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <​loki@inf.u-szeged.hu>

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::baseIndexTransfer32):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::load32):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
  • wtf/Platform.h:
10:19 PM Changeset in webkit [46830] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2009-08-05 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

Need to test throwing exceptions from Workers after calling close().
​https://bugs.webkit.org/show_bug.cgi?id=27924

  • fast/workers/resources/worker-close.js:
  • fast/workers/worker-close-expected.txt:
  • fast/workers/worker-close.html:
8:50 PM Changeset in webkit [46829] by Dimitri Glazkov
  • 5 edits in trunk/WebCore

2009-08-05 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[V8] Revert ​http://trac.webkit.org/changeset/46821, which was
landed to supplement ​http://trac.webkit.org/changeset/46816, but
now that the latter is reverted, the former needs the same.

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
8:27 PM Changeset in webkit [46828] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2009-08-05 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Color is only reported in rgb() format; should toggle between rgb() and hex
​https://bugs.webkit.org/show_bug.cgi?id=13516

New Class to Parse and Change Between Color Representations:

Representations of Colors in Raw Form. (May be Lazy Loaded):

(WebInspector.Color.prototype.get shorthex):
(WebInspector.Color.prototype.get hex):
(WebInspector.Color.prototype.set hex):
(WebInspector.Color.prototype.get rgb):
(WebInspector.Color.prototype.set rgb):
(WebInspector.Color.prototype.get hsl):
(WebInspector.Color.prototype.set hsl):
(WebInspector.Color.prototype.get nickname):
(WebInspector.Color.prototype.set nickname):
(WebInspector.Color.prototype.get rgba):
(WebInspector.Color.prototype.set rgba):
(WebInspector.Color.prototype.get hsla):
(WebInspector.Color.prototype.set hsla):

Helpers and Standard String Representations:

(WebInspector.Color.prototype.hasShortHex):
(WebInspector.Color.prototype.toRgb):
(WebInspector.Color.prototype.toHsl):
(WebInspector.Color.prototype.toShortHex):
(WebInspector.Color.prototype.toHex):
(WebInspector.Color.prototype.toRgba):
(WebInspector.Color.prototype.toHsla):
(WebInspector.Color.prototype.toNickname):

Conversion Functions to Determine Other Representations:
My Sources for all algorithms and sample data:
Wikipedia: ​http://en.wikipedia.org/wiki/HSV_color_space
CSS Specification: ​http://www.w3.org/TR/css3-color/#hsla-color

(WebInspector.Color.prototype.rgbToHex):
(WebInspector.Color.prototype.hexToRgb):
(WebInspector.Color.prototype.rgbToHsl):
(WebInspector.Color.prototype.hslToRgb.hueToRgb):
(WebInspector.Color.prototype.hslToRgb):
(WebInspector.Color.prototype.rgbaToHsla):
(WebInspector.Color.prototype.hslaToRgba):

Called from the constructor, attempts to parse and will throw an error
if it cannot parse. If simple then the "hex" value is guarenteed.
If advanced then both the "rgba" and "hsla" are guarenteed. If it is
a nickname in any way (e.g. "transparent", "black") then this is
guarenteed to be set as well.

(WebInspector.Color.prototype.parse):

Clicking on the swatch will rotate through Color Representations.

Simple: rgb -> hsl -> nickname? -> shorthex? -> hex -> (loop around)
Advanced: rgba -> hsla -> nickname? -> (loop around)

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.value.): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

Load Color.js:

  • inspector/front-end/inspector.html:
8:05 PM Changeset in webkit [46827] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-08-05 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Dimitri Glazkov.

Support setting event listeners for message ports in the worker process.

​https://bugs.webkit.org/show_bug.cgi?id=28004

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
7:39 PM Changeset in webkit [46826] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-05 Stephen White <​senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

​http://bugs.webkit.org/show_bug.cgi?id=28022

Minor fix for media code on chromium/skia.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack):
6:37 PM Changeset in webkit [46825] by Darin Adler
  • 3 edits
    2 adds in trunk

WebCore:

2009-08-05 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.

Test: fast/images/image-map-zoom.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Compute the values to pass in to the map element using the content box and the effective zoom.

LayoutTests:

2009-08-05 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.

  • fast/images/image-map-zoom-expected.txt: Added.
  • fast/images/image-map-zoom.html: Added.
6:30 PM Changeset in webkit [46824] by beidson@apple.com
  • 5 edits in trunk

Add more missing ResourceLoadDelegate methods for WinDRT, and remove another test from the skipped list.

5:52 PM WebKit Team edited by atwilson@chromium.org
(diff)
5:12 PM Changeset in webkit [46823] by mrowe@apple.com
  • 14 edits
    5 deletes in trunk

Roll out r46816 as it broke many tests.

5:11 PM Changeset in webkit [46822] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=28027
<rdar://7064428> Files with accents in names are submitted incorrectly due to use of
precomposed Unicode

  • platform/network/mac/FormDataStreamMac.mm: (WebCore::setHTTPBody): Use getFileSize() from FileSystem.h instead of custom code for getting file size. This adds path normalization necessary with some file systems on Mac. This also loses a S_IFMT check, which didn't seem important anyway.
4:47 PM Changeset in webkit [46821] by Dimitri Glazkov
  • 5 edits in trunk/WebCore

2009-08-05 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[V8] Include Media into V8 bindings.

  • bindings/v8/DOMObjectsInclude.h: Added Media include.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8Media include.
  • bindings/v8/V8Index.cpp: Added decl for V8Media.
  • bindings/v8/V8Index.h: Added V8Media include.
4:41 PM Changeset in webkit [46820] by beidson@apple.com
  • 5 edits
    1 delete in trunk

WebKitTools:
2009-08-05 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

Win DRT's resource load delegate is missing didReceiveResponse
​https://bugs.webkit.org/show_bug.cgi?id=28033

  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveResponse):
  • DumpRenderTree/win/ResourceLoadDelegate.h:

LayoutTests:
2009-08-05 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

Win DRT's resource load delegate is missing didReceiveResponse
​https://bugs.webkit.org/show_bug.cgi?id=28033

  • platform/win/Skipped: Remove a test that now passes


Remove platform specific results for the XFrameOptions suite which now matches cross platform results:

  • platform/win/http/tests/security: Removed.
  • platform/win/http/tests/security/XFrameOptions: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Removed.
4:18 PM Changeset in webkit [46819] by jhoneycutt@apple.com
  • 4 edits in trunk/WebCore

2009-08-04 Jon Honeycutt <​jhoneycutt@apple.com>

Fix Windows layout test crashes.

PluginView::removeFromUnstartedListIfNecessary() would try to remove
any unstarted PluginView from the Page's set of unstarted plug-ins,
regardless of why the PluginView wasn't started. If we tried to start a
plug-in, but it failed to start, we would hit an assertion in
Page::removeUnstartedPlugin() that asserts that we would only modify the
unstarted plug-ins set if we were not currently starting plug-ins.

Fix this by having PluginView track whether it's waiting to be started,
and to check this before trying to remove itself from the Page's
unstarted plug-ins set.

Reviewed by Darin Adler.

  • page/Page.cpp: (WebCore::Page::removeUnstartedPlugin): Assert that the passed PluginView is in the unstarted set.
  • plugins/PluginView.cpp: (WebCore::PluginView::start): Set that we are not waiting to be started. (WebCore::PluginView::startOrAddtoUnstartedList): Set that we are waiting to be started. (WebCore::PluginView::removeFromUnstartedListIfNecessary): Check not whether we are started, but whether we are waiting to be started. (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
3:48 PM Changeset in webkit [46818] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2009-08-05 Jeremy Orlow <​jorlow@chromium.org>

Fix DOM Storage memory leak
​https://bugs.webkit.org/show_bug.cgi?id=28029

Forgot to use adoptRef in one place. This caused the = operator to
increment the ref count when it shouldn't have, so StorageAreaImpl's were
never freed.

  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
2:51 PM Changeset in webkit [46817] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-08-05 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Let CodeGeneratorV8.pm know that Media is ref-counted.

  • bindings/scripts/CodeGeneratorV8.pm: Added Media check to IsRefPtrType.
2:26 PM Changeset in webkit [46816] by Simon Fraser
  • 14 edits
    2 copies
    3 adds in trunk

2009-08-05 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Implement the matchMedium method on the Media interface described in the CSSOM View Module.
​https://bugs.webkit.org/show_bug.cgi?id=22495

Add a new Media interface, obtainable via the AbstractView, that can
evaluate queries via its matchesMedium() method.

Test: fast/media/matchmedium-query-api.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add Media.* files to the build.
  • css/Media.cpp: Added. (WebCore::Media::Media): (WebCore::Media::type): (WebCore::Media::matchMedium):
  • css/Media.h: Added. (WebCore::Media::create): (WebCore::Media::document):
  • css/Media.idl: Added. Media::matchMedium() uses a MediaQueryEvaluator() to test the query.
  • page/AbstractView.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::media):
  • page/DOMWindow.h:
  • page/DOMWindow.idl: Add a readonly attribute for Media.
2:25 PM Changeset in webkit [46815] by Darin Adler
  • 96 edits in trunk/WebCore

2009-08-05 Darin Adler <Darin Adler>

Reviewed by David Levin.

Use checked casts for render tree
​https://bugs.webkit.org/show_bug.cgi?id=23522

Last patch. Makes all the casts of RenderObject use checked
casts instead of using static_cast directly.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::visibleChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  • accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::elementRect):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::textUnderElement): (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::titleUIElement): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect):
  • dom/InputElement.cpp: (WebCore::InputElement::updatePlaceholderVisibility):
  • dom/SelectElement.cpp: (WebCore::SelectElement::scrollToSelection): (WebCore::SelectElement::recalcStyle): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::attach):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler):
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::addSearchResult): (WebCore::HTMLInputElement::onSearch):
  • html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::parseMappedAttribute): (WebCore::HTMLLIElement::attach):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated): (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer): (WebCore::HTMLMediaElement::defaultEventHandler): (WebCore::HTMLMediaElement::finishParsingChildren):
  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::defaultEventHandler):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::capsLockStateMayHaveChanged):
  • page/Frame.cpp: (WebCore::Frame::ownerRenderer):
  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars):
  • page/wince/FrameWince.cpp: (WebCore::computePageRectsForFrame):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
  • rendering/RenderCounter.cpp: (WebCore::planCounter):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::computeEdgeInfo): (WebCore::RenderFrameSet::setIsResizing):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::contentsBox):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
  • rendering/RenderListItem.cpp: (WebCore::previousListItem): (WebCore::RenderListItem::explicitValueChanged):
  • rendering/RenderObject.cpp: (WebCore::updateListMarkerNumbers):
  • rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::invalidateCountersInContainer):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::minimumThumbLength): (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect): (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces): (WebCore::RenderScrollbarTheme::paintScrollbarBackground): (WebCore::RenderScrollbarTheme::paintTrackBackground): (WebCore::RenderScrollbarTheme::paintTrackPiece): (WebCore::RenderScrollbarTheme::paintButton): (WebCore::RenderScrollbarTheme::paintThumb):
  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::defaultEventHandler):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineSliderThumbState):
  • rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
  • rendering/SVGRootInlineBox.cpp: (WebCore::findSVGRootObject):
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint): (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
  • svg/SVGTextContentElement.cpp: (WebCore::rootInlineBoxForTextContentElement):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler): Use checked casts.
  • rendering/RenderApplet.h:
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderPart.h:
  • rendering/RenderPartObject.h:
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGTextPath.h:
  • rendering/RenderSVGViewportContainer.h:
  • rendering/RenderScrollbar.h:
  • rendering/RenderSlider.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderVideo.h: Added a checked cast. Also made most members protected or private.
  • rendering/RenderBlock.h:
  • rendering/RenderInline.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGText.h:
  • rendering/RenderTextControl.h: Made most members protected or private.
  • rendering/RenderInline.cpp:
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGImage.cpp:
  • rendering/RenderSVGRoot.cpp: Removed unneeded destructor.
  • rendering/RenderSVGHiddenContainer.h: Removed unneeded virtual function overrides that did the same as the default and base class.
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::paint): Updated to use m_viewport directly instead of using a function call. (WebCore::RenderSVGViewportContainer::applyViewportClip): Ditto. (WebCore::RenderSVGViewportContainer::viewportTransform): Ditto. (WebCore::RenderSVGViewportContainer::localToParentTransform): Ditto. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Ditto.
  • rendering/RenderScrollbar.cpp: (WebCore::pseudoForScrollbarPart): Changed switch statement to use cases for all values instead of using a default case.
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<): Removed dependency on casting to types that don't have any public members we need to get at. Instead, use function names to identify the type rather than doing so much overloading. Changed to use checked casts. (WebCore::write): Ditto.
  • rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): Changed to use a checked cast and also added a comment about the fact that the code does not do sufficient type checking before doing the cast.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderSVGTextBox): Renamed this from operator<<. (WebCore::writeSVGInlineTextBoxes): Renamed this from writeSVGInlineText. (WebCore::writeSVGText): Renamed this from write. (WebCore::writeSVGInlineText): Ditto. (WebCore::writeSVGImage): Ditto.
  • rendering/SVGRenderTreeAsText.h: Updated for name changes. Removed unneeded default arguments.
2:14 PM Changeset in webkit [46814] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

2009-08-05 Peter Kasting <​pkasting@google.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=27851
Fix a pair of compiler warnings on the GTK Linux buildbot.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader): Don't use multi-character constants, they're not portable.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::setSize): Simpler code that also doesn't compare signed with unsigned.
2:00 PM Changeset in webkit [46813] by beidson@apple.com
  • 1 edit
    4 copies in trunk/LayoutTests

2009-08-05 Brady Eidson <​beidson@apple.com>

Rubberstamped by Mark Rowe.

As a followup to ​http://trac.webkit.org/changeset/46811, Windows-specific results *did* have some differences, so restoring those results.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
1:46 PM Changeset in webkit [46812] by beidson@apple.com
  • 1 edit
    6 deletes in trunk/LayoutTests

2009-08-05 Brady Eidson <​beidson@apple.com>

Rubberstamped by Mark Rowe.

Actually, for all 6 of these tests Tiger now matches the cross-platform results, so removing all the Tiger results.

  • platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Removed.
  • platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
1:31 PM Changeset in webkit [46811] by beidson@apple.com
  • 1 edit
    4 deletes in trunk/LayoutTests

2009-08-05 Brady Eidson <​beidson@apple.com>

Rubberstamped by Mark Rowe.

As a followup to ​http://trac.webkit.org/changeset/46809, Windows-specific results now match the cross-platform results,
so I'm removing them.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
1:26 PM Changeset in webkit [46810] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

2009-08-05 Brady Eidson <​beidson@apple.com>

Rubberstamped by Mark Rowe.

As a followup to ​http://trac.webkit.org/changeset/46809, update Tiger platform specific results for these tests.

  • platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt:
  • platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
1:16 PM Changeset in webkit [46809] by darin@chromium.org
  • 12 edits in trunk

2009-08-05 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

Add layoutTestController.dumpWillCacheResponse
​https://bugs.webkit.org/show_bug.cgi?id=28010

willCacheResponse is only interesting for embedders of mainline WebKit on Mac.
Splitting off a new dumpWillCacheResponse allows a number of existings tests
to run across platforms.

The test that was specifically verifying willCacheResponse now calls
dumpWillCacheResponse.

  • DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse (LayoutTestController::LayoutTestController): (dumpWillCacheResponseCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpWillCacheResponse): (LayoutTestController::setDumpWillCacheResponse):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse instead of dumpResourceLoadCallbacks. (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
12:56 PM Changeset in webkit [46808] by mrowe@apple.com
  • 4 edits in trunk/LayoutTests

Fix two tests to not load a resource that takes five seconds to load.

Reviewed by Brady Eidson.

We achieve this by making the delay in slow-resource.pl configurable in a query parameter.
This drops the run time of each of the tests from over five seconds to less than a third
of a second.

  • http/tests/misc/DOMContentLoaded-event.html:
  • http/tests/navigation/multiple-back-forward-entries.html:
  • http/tests/navigation/resources/slow-resource.pl:
12:36 PM Changeset in webkit [46807] by pkasting@chromium.org
  • 7 edits
    1 delete in trunk/WebCore

2009-08-05 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26460
Return multiple icon entries from the ICO decoder as separate frames,
sorted by decreasing quality (much like the CG ICO decoder does).

As a result of this change, we can eliminate the Skia-specific setData()
hack that the Chromium port used to select the desired icon size -- now
callers can just enumerate the frames and ask for the data from the one
they like.


Under the hood, the ICO decoder now keeps vectors for a number of things
(including directory entries and image decoders) where it used to have
single members. However, callers (that I have seen) will only request
one frame from the icon, so practically there aren't going to be lots of
instantiated image decoders.

  • platform/graphics/ImageSource.h: Move |m_decoder| back to private now that Skia no longer needs to access it.
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation. (WebCore::ImageSource::setData): Remove function to ask for a particular icon size.
  • platform/graphics/skia/ImageSourceSkia.h: Removed.
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::~ICOImageDecoder): Delete all instantiated per-frame decoders. (WebCore::ICOImageDecoder::setData): Send data to all instantiated per-frame decoders. (WebCore::ICOImageDecoder::isSizeAvailable): Use size from icon directory instead of PNG decoder (if applicable) so we can report it without decoding the PNG frames. (WebCore::ICOImageDecoder::size): Report frame-specific size if BMP decoder is calling. Otherwise, use size from icon directory instead of PNG decoder (if applicable). (WebCore::ICOImageDecoder::frameSizeAtIndex): Implement. (WebCore::ICOImageDecoder::setSize): Sanity check value if BMP decoder is calling. (WebCore::ICOImageDecoder::frameCount): Implement. (WebCore::ICOImageDecoder::frameBufferAtIndex): Sanity check size for PNG frames. (WebCore::ICOImageDecoder::compareEntries): Add utility function for sorting entries. (WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex): Factor out utility function for passing correct data blob to a PNG decoder. (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): Split decode() into two pieces. (WebCore::ICOImageDecoder::decodeDirectory): The first part of the old decode(). (WebCore::ICOImageDecoder::decodeAtIndex): The second part of the old decode(), split off so we avoid decoding an entry until it's requested. (WebCore::ICOImageDecoder::processDirectory): Add resizing of internal data structures based on directory contents. (WebCore::ICOImageDecoder::processDirectoryEntries): Sort entries by quality. (WebCore::ICOImageDecoder::imageTypeAtIndex): Return type to caller instead of setting a member.
  • platform/image-decoders/ico/ICOImageDecoder.h:
11:38 AM Changeset in webkit [46806] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2009-08-05 Szabo Carol <​carol.szabo@nokia.com>

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=27942
Form Reset does not work per w3c standard when single selection
SELECT element has more than one option marked as selected.

  • fast/forms/select-reset-multiple-selections-4-single-selection-expected.txt: Added.
  • fast/forms/select-reset-multiple-selections-4-single-selection.html: Added.

2009-08-05 Szabo Carol <​carol.szabo@nokia.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=27942

Test: fast/forms/select-reset-multiple-selections-4-single-selection.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::reset):

Added HTML 4.01 compliant handling of broken webpages that
specify more than one selected option for single selection SELECT
element, in a manner that emulates Firefox and is similar to IE 7

11:22 AM Changeset in webkit [46805] by jorlow@chromium.org
  • 2 edits in trunk/WebKitTools

2009-08-05 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Add my name to committers.py
​https://bugs.webkit.org/show_bug.cgi?id=28013

Add my name to committers.py.

  • Scripts/modules/committers.py:
8:17 AM Changeset in webkit [46804] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-08-05 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

WebCore.pro bugfix

Fix the gperf lines to properly include the string.h header at compilation with gperf version 3.0.3 and newer.

  • WebCore.pro:
8:14 AM Changeset in webkit [46803] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-08-05 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Fix build error caused by ​http://trac.webkit.org/changeset/46763

  • Api/qwebpluginfactory.h: Export macro added.
7:56 AM Changeset in webkit [46802] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-05 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

A minor refactoring of the Qt DRT to be a bit more similar to
the other DRTs, as well as more understandable.

Splitting up resetJSObjects into a LayoutTestController->reset()
plus a new closeRemainingWindows() method.

Added a resetToConsistentStateBeforeTesting() method to keep
the code in one place, making it easier to verify that we are
doing things properly.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::closeRemainingWindows):
  • DumpRenderTree/qt/DumpRenderTree.h:
7:51 AM Changeset in webkit [46801] by kenneth@webkit.org
  • 5 edits in trunk/WebKitTools

2009-08-05 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

Make the Qt DRT WorkQueue work similarily to the cross platform
one. This means that all items return true if they started
loading.

This change paves the way for unforking the WorkQueue, if we [Qt]
would like that.

  • DumpRenderTree/qt/WorkQueue.cpp: (WorkQueue::processWork):
  • DumpRenderTree/qt/WorkQueue.h:
  • DumpRenderTree/qt/WorkQueueItem.h:
  • DumpRenderTree/qt/jsobjects.cpp: (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): (LayoutTestController::processWork): (LayoutTestController::maybeDump):
7:48 AM Changeset in webkit [46800] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

If load of a test fails, don't dump as it will be dumped
in the preceding test, resulting in a invalid incorrect layout.

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::maybeDump):
7:46 AM Changeset in webkit [46799] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

Make the Qt DumpRenderTree more similar to the mac one.

Changes include:
1) Reset zoom factor before each test
2) Only dump the backforward list when we got other dump result
3) When we dump the render tree, and got zero result print out:

[mainFrame renderTreeAsExternalRepresentation]
and not:
[frame renderTreeAsExternalRepresentation]

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): (WebCore::methodNameStringForFailedTest): (WebCore::DumpRenderTree::dump):
7:39 AM Changeset in webkit [46798] by Chris Fleizach
  • 4 edits in trunk

WebCore:

2009-08-05 Chris Fleizach <Chris Fleizach>

Fix Tiger build breakage.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

WebKitTools:

2009-08-05 chris fleizach <Chris Fleizach>

Fix Tiger build breakage.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
5:40 AM EFLWebKit edited by tonikitoo@gmail.com
(diff)
4:40 AM Changeset in webkit [46797] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-08-05 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] macros in webkit.m4 should be defined once only
​https://bugs.webkit.org/show_bug.cgi?id=27929

The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.

Lastly, make sure CXXFLAGS and CFLAGS are defined before
AC_PROG_CXX gets expanded so it doesn't add "-g -O2" on Release builds.

  • autotools/webkit.m4:
1:13 AM Changeset in webkit [46796] by xan@webkit.org
  • 2 edits in trunk

2009-08-05 Xan Lopez <​xlopez@igalia.com>

Revert r46714, it was making us build debug images by default.

  • autotools/webkit.m4:

Aug 4, 2009:

10:50 PM Changeset in webkit [46795] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-08-04 Simon Hausmann <Simon Hausmann>

Prospective build fix for Qt build bot: Fix dependency of HTMLNames.cpp
to both source files, HTMLTagNames.in and HTMLAttributeNames.in

  • WebCore.pro:
10:40 PM Changeset in webkit [46794] by abarth@webkit.org
  • 18 edits in trunk/LayoutTests

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] Teach ScheduledAction::execute about isolated worlds
​https://bugs.webkit.org/show_bug.cgi?id=27703

Rename queueScriptInIsolatedWorld to evaluateScriptInIsolatedWorld
because I've changed this API to be synchronous instead of asynchronous
to work around some strange behavior in the work_queue_. Turns out we
don't need the complexity of an asynchronous API to test this feature.

  • http/tests/security/isolatedWorld/all-window-properties.html:
  • http/tests/security/isolatedWorld/all-window-prototypes.html:
  • http/tests/security/isolatedWorld/body-properties.html:
  • http/tests/security/isolatedWorld/body-prototype.html:
  • http/tests/security/isolatedWorld/click-event.html:
  • http/tests/security/isolatedWorld/document-open.html:
  • http/tests/security/isolatedWorld/document-properties.html:
  • http/tests/security/isolatedWorld/document-prototype.html:
  • http/tests/security/isolatedWorld/global-variables.html:
  • http/tests/security/isolatedWorld/image-properties.html:
  • http/tests/security/isolatedWorld/image-prototype.html:
  • http/tests/security/isolatedWorld/location-properties.html:
  • http/tests/security/isolatedWorld/location-prototype.html:
  • http/tests/security/isolatedWorld/number-prototype.html:
  • http/tests/security/isolatedWorld/object-prototype.html:
  • http/tests/security/isolatedWorld/string-prototype.html:
  • http/tests/security/isolatedWorld/window-properties.html:
10:20 PM Changeset in webkit [46793] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

2009-08-04 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Adele Peterson.

Keypress should exit from pan scrolling mode.
​https://bugs.webkit.org/show_bug.cgi?id=28005

Change the logic from only exiting pan scrolling on escape to exiting on any key press,
making it easier for users to back out of an accidental pan scroll.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
9:36 PM Changeset in webkit [46792] by eric@webkit.org
  • 5 edits
    1 add in trunk

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION (r45064): Drop caret remains in text control after the mouse exits
​https://bugs.webkit.org/show_bug.cgi?id=26787

Fix some bogus comments noticed during testing.

  • fast/forms/drag-into-textarea.html:
  • fast/forms/drag-out-of-textarea.html:

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION (r45064): Drop caret remains in text control after the mouse exits
​https://bugs.webkit.org/show_bug.cgi?id=26787

Add back missing dragController()->clear() call.

  • manual-tests/drag-caret.html: Added.
  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
7:22 PM Changeset in webkit [46791] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/win

2009-08-04 Alice Liu <​alice.liu@apple.com>

"Shift + Enter" should behave like "Enter" in editable fields.
Affects backward search in find-in-page in Safari for Windows

Reviewed by Jon Honeycutt.

  • WebView.cpp: Register shift+enter as InsertNewline command, similar to other modifier+Enter combinations.
6:34 PM Changeset in webkit [46790] by eric@webkit.org
  • 2 edits
    1 add
    5 deletes in trunk/LayoutTests

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

  • platform/mac/accessibility/aria-valuetext-expected.txt: Added.
  • platform/mac/accessibility/aria-valuetext.html: Added.
5:32 PM Changeset in webkit [46789] by Chris Fleizach
  • 2 edits in trunk/WebCore

2009-08-04 Chris Fleizach <Chris Fleizach>

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

Forgot to commit attribute names.

  • html/HTMLAttributeNames.in:
5:29 PM Changeset in webkit [46788] by Chris Fleizach
  • 11 edits
    2 adds in trunk

WebCore:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

Test: platform/mac/accessibility/aria-valuetext.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::valueDescription):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::valueDescription):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  • html/HTMLAttributeNames.in:

WebKitTools:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

Expose valueDescription for accessibility.

  • DumpRenderTree/AccessibilityUIElement.cpp: (getValueDescriptionCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::valueDescription):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::valueDescription):

LayoutTests:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
​https://bugs.webkit.org/show_bug.cgi?id=27994

  • platform/mac/accessibility/aria-valuetext-expected.txt: Added.
  • platform/mac/accessibility/aria-valuetext.html: Added.
5:21 PM Changeset in webkit [46787] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH
​https://bugs.webkit.org/show_bug.cgi?id=28006

Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig

  • DumpRenderTree/mac/PerlSupport/Makefile:
5:18 PM Changeset in webkit [46786] by darin@chromium.org
  • 19 edits in trunk

2009-08-04 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=27821

No new features, no new tests. Existing layout tests pass.

  • WebCore.base.exp:

Export AppliationCacheGroup::storeCopyOfCache

  • WebCore.xcodeproj/project.pbxproj:

Restore DOMApplicationCache.h and ApplicationCacheHost.h to 'project' headers
instead of 'private' headers since they're no longer in the DocumentLoader.h
include graph.

  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):

Reinstate the test for manifest.isNull instead of .isEmtpty().
Added a FIXME to revisit once the spec gets clarified.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::detachFromFrame):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCacheHost):

ApplicationCacheHost is held in an OwnPtr<> by DocumentLoader. This was done
for compile time friendliness, it results in a smaller include graph for files
dependent on DocumentLoader.h.

  • loader/FrameLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/ResourceLoader.cpp:

Cleanup ussage of ENABLE(xxx) around includes, generally remove those guards.
This was done for readability at the include site. The included files contain appropriate guards,
so they're not needed at the include site.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheGroup.h:

Use ApplicationCachHost defined constants, no longer depends on DOMApplicationCache.

  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): (WebCore::ApplicationCacheHost::setDOMApplicationCache): (WebCore::ApplicationCacheHost::notifyEventListener): (WebCore::ApplicationCacheHost::status):
  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeCopyOfCache):
  • loader/appcache/ApplicationCacheStorage.h:

Merge recently added transferApplicationCache and pre-existing storeCopyOfCache methods.

  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::status): (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::callListener): (WebCore::DOMApplicationCache::toEventType): (WebCore::DOMApplicationCache::toEventID):
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::setAttributeEventListener): (WebCore::DOMApplicationCache::getAttributeEventListener): (WebCore::DOMApplicationCache::clearAttributeEventListener): (WebCore::DOMApplicationCache::callEventListener): (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete):

Use ApplicationCachHost defined constants for Status and EventIDs.

4:31 PM Changeset in webkit [46785] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Add pkasting to bugzilla-tool as a committer
​https://bugs.webkit.org/show_bug.cgi?id=28002

  • Scripts/modules/committers.py:
4:20 PM Changeset in webkit [46784] by Nate Chapin
  • 3 edits in trunk/WebCore

2009-08-04 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Revert r46421 and r46769, which appear to have totally hosed the v8 bindings.

​https://bugs.webkit.org/show_bug.cgi?id=27719

4:04 PM Changeset in webkit [46783] by Chris Fleizach
  • 15 edits
    2 adds in trunk

WebCore:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27993 - AXSliders are missing required attributes and actions
​https://bugs.webkit.org/show_bug.cgi?id=27993

Expose appropriate actions and attributes for sliders.

Test: platform/mac/accessibility/slider-supports-actions.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::orientation):
  • accessibility/AccessibilityObject.h: (WebCore::):
  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
  • accessibility/AccessibilitySlider.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityActionNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

WebKitTools:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27993 - AXSliders are missing required attributes and actions
​https://bugs.webkit.org/show_bug.cgi?id=27993

Add ability to check if any arbitrary action is supported.

  • DumpRenderTree/AccessibilityUIElement.cpp: (isActionSupportedCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isActionSupported):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isActionSupported):

LayoutTests:

2009-08-04 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 27993 - AXSliders are missing required attributes and actions
​https://bugs.webkit.org/show_bug.cgi?id=27993

Update tests to use more generic isActionSupported.

  • accessibility/aria-link-supports-press.html:
  • accessibility/button-press-action.html:
  • accessibility/onclick-handlers.html:
  • platform/mac/accessibility/slider-supports-actions-expected.txt: Added.
  • platform/mac/accessibility/slider-supports-actions.html: Added.
3:52 PM Changeset in webkit [46782] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2009-08-04 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

[V8] Fix an assert in WebCoreStringResource that causes worker script
evaluation failed.
​https://bugs.webkit.org/show_bug.cgi?id=27996

The fix is to check for the same thread, instead of the main thread.
This is because Chromium's workers use v8 in a single thread that is
not the main thread.

  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::atomicString):
3:46 PM Changeset in webkit [46781] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool unit tests need a test harness
​https://bugs.webkit.org/show_bug.cgi?id=27977

  • Scripts/run-webkit-unittests: Added.
3:19 PM Changeset in webkit [46780] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wx build fix after InspectorClient API change.

2:43 PM Changeset in webkit [46779] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

LayoutTests are too slow
​https://bugs.webkit.org/show_bug.cgi?id=27995

Shave 5 seconds off of run-webkit-tests.

  • fast/events/click-count.html: use eventSender.leapForward instead of setTimeout
2:35 PM Changeset in webkit [46778] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-08-04 Gavin Barraclough <​barraclough@apple.com>

Rubber Stamped by Oiver Hunt.

Revert r46643 since this breaks the Yarr::Interpreter running the v8 tests.
​https://bugs.webkit.org/show_bug.cgi?id=27874

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
1:59 PM BuildingOnWindows edited by jessieberlin@gmail.com
Move the information about setting the WebKitLibrariesDir out of the … (diff)
1:54 PM Changeset in webkit [46777] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

PPC64 Build fix

12:57 PM Changeset in webkit [46776] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-08-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Add support for transitions/animations of text-indent.

Test: transitions/text-indent-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
12:52 PM Changeset in webkit [46775] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions
by listing the DumpRenderTree binary as a dependency. Xcode has the smarts to rebuild
DumpRenderTree itself when switching OS versions so this dependency removes the need
for any smarts in the Makefile.

Rubber-stamped by Gavin "Gavvy" Barraclough.

  • DumpRenderTree/mac/PerlSupport/Makefile:
12:46 PM Changeset in webkit [46774] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Update test results after addition of AXRequired in r46768.

  • platform/mac/accessibility/lists-expected.txt:
12:38 PM Changeset in webkit [46773] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-08-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Add support for transitions of min- and max-width, and min- and max-height.
​https://bugs.webkit.org/show_bug.cgi?id=27990

Test: transitions/min-max-width-height-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
12:17 PM Changeset in webkit [46772] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs unit tests
​https://bugs.webkit.org/show_bug.cgi?id=26916

Add some basic unit testing for scm.py.

  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py: Added.
12:06 PM Changeset in webkit [46771] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking
to make sure the Skipped entries are not in the $ignoredDirectories array. Directories commonly included
are (http, media, compositing, wml, wcss).

​https://bugs.webkit.org/show_bug.cgi?id=27893

  • Scripts/run-webkit-tests:
11:15 AM Changeset in webkit [46770] by Chris Fleizach
  • 8 edits
    2 adds in trunk

Bug 27964 - WAI-ARIA: radio button does not determine its label from text content
​https://bugs.webkit.org/show_bug.cgi?id=27964

10:28 AM Changeset in webkit [46769] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-08-04 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Missed a place that expects window.event to be hidden when it shouldn't be.

​https://bugs.webkit.org/show_bug.cgi?id=27719

9:15 AM Changeset in webkit [46768] by Chris Fleizach
  • 16 edits
    2 adds in trunk

Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
​https://bugs.webkit.org/show_bug.cgi?id=27958

8:20 AM Changeset in webkit [46767] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-08-04 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslErrors.
​https://bugs.webkit.org/show_bug.cgi?id=27804

  • Api/qwebframe.cpp: (QWebFrame::requestedUrl):
  • tests/qwebframe/tst_qwebframe.cpp:
7:58 AM Changeset in webkit [46766] by ben@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-04 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Adam Treat

Explicitly include limits.h header when using INT_MAX and INT_MIN

  • interpreter/Interpreter.cpp
7:51 AM Changeset in webkit [46765] by ariya@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

2009-08-04 Ariya Hidayat <​ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Add passed test results, with pixel tests.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-composite-expected.png: Added.
  • platform/qt/fast/canvas/canvas-composite-expected.txt: Added.
  • platform/qt/fast/canvas/drawImage-expected.checksum: Added.
  • platform/qt/fast/canvas/drawImage-expected.png: Added.
  • platform/qt/fast/canvas/drawImage-expected.txt: Added.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
7:50 AM Changeset in webkit [46764] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

2009-08-04 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Rename QWebPlugin to QWebPluginInfo, as discussed on IRC.

  • Api/qwebplugindatabase.cpp: (QWebPluginInfoPrivate::QWebPluginInfoPrivate): (QWebPluginInfo::QWebPluginInfo): (QWebPluginInfo::~QWebPluginInfo): (QWebPluginInfo::name): (QWebPluginInfo::description): (QWebPluginInfo::mimeTypes): (QWebPluginInfo::supportsMimeType): (QWebPluginInfo::path): (QWebPluginInfo::isNull): (QWebPluginInfo::setEnabled): (QWebPluginInfo::isEnabled): (QWebPluginInfo::operator==): (QWebPluginInfo::operator!=): (QWebPluginInfo::operator=): (QWebPluginDatabase::plugins): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
  • Api/qwebplugindatabase.h:
  • Api/qwebplugindatabase_p.h:
  • tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
7:50 AM Changeset in webkit [46763] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

2009-08-04 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Adam Treat.

Replace QWebPlugin::MimeType with a typedef to
QWebPluginFactory::MimeType.

  • Api/qwebplugindatabase.cpp:
  • Api/qwebplugindatabase.h:
  • Api/qwebpluginfactory.cpp: (QWebPluginFactory::MimeType::operator==):
  • Api/qwebpluginfactory.h:
7:50 AM Changeset in webkit [46762] by Simon Hausmann
  • 7 edits
    6 adds in trunk

WebCore:

2009-08-04 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

Add QWebPluginDatabase API to the Qt API.

​https://bugs.webkit.org/show_bug.cgi?id=27651

  • WebCore.pro:

WebKit/qt:

2009-08-04 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

Add QWebPluginDatabase API to the Qt API.

​https://bugs.webkit.org/show_bug.cgi?id=27651

  • Api/headers.pri:
  • Api/qwebplugindatabase.cpp: Added. (QWebPluginPrivate::QWebPluginPrivate): (QWebPluginDatabasePrivate::QWebPluginDatabasePrivate): (QWebPlugin::MimeType::operator==): (QWebPlugin::QWebPlugin): (QWebPlugin::~QWebPlugin): (QWebPlugin::name): (QWebPlugin::description): (QWebPlugin::mimeTypes): (QWebPlugin::supportsMimeType): (QWebPlugin::path): (QWebPlugin::isNull): (QWebPlugin::setEnabled): (QWebPlugin::isEnabled): (QWebPlugin::operator==): (QWebPlugin::operator!=): (QWebPlugin::operator=): (QWebPluginDatabase::QWebPluginDatabase): (QWebPluginDatabase::~QWebPluginDatabase): (QWebPluginDatabase::plugins): (QWebPluginDatabase::defaultSearchPaths): (QWebPluginDatabase::searchPaths): (QWebPluginDatabase::setSearchPaths): (QWebPluginDatabase::addSearchPath): (QWebPluginDatabase::refresh): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
  • Api/qwebplugindatabase.h: Added.
  • Api/qwebplugindatabase_p.h: Added.
  • Api/qwebsettings.cpp: (QWebSettings::pluginDatabase):
  • Api/qwebsettings.h:
  • tests/qwebplugindatabase/qwebplugindatabase.pro: Added.
  • tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: Added. (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
  • tests/tests.pro:
7:34 AM Changeset in webkit [46761] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-08-04 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Adam Treat.

[Qt] PlusDarker is not supported. Fall back to CompositionMode_Darken
(as it is the closest match) instead of CompositionMode_SourceOver.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
7:24 AM Changeset in webkit [46760] by ariya@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Adam Treat.

[Qt] Fix the metrics.

  • platform/qt/fast/canvas/canvas-before-css-expected.txt:
6:30 AM Changeset in webkit [46759] by ariya@webkit.org
  • 3 edits
    14 adds in trunk/LayoutTests

2009-08-04 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Add pixel tests result.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-as-image-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-as-image-expected.png: Added.
  • platform/qt/fast/canvas/canvas-as-image-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-before-css-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/qt/fast/canvas/canvas-before-css-expected.txt:
  • platform/qt/fast/canvas/canvas-bg-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-bg-expected.png: Added.
  • platform/qt/fast/canvas/canvas-bg-expected.txt: Added.
  • platform/qt/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-bg-zoom-expected.png: Added.
  • platform/qt/fast/canvas/canvas-bg-zoom-expected.txt: Added.
6:26 AM Changeset in webkit [46758] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-04 Adam Treat <​adam.treat@torchmobile.com>

Fix buildbot. This was supposed to be part of the last commit r46757, but the hunk never made it in.

  • platform/qt/fast/block/float/033-expected.txt:
5:45 AM EFLWebKit edited by tonikitoo@gmail.com
(diff)
5:22 AM Changeset in webkit [46757] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2009-08-04 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Remove LayoutTests/fast/block/float/033.html from the Qt Skipped list

The expected value was incorrect and it has been modified. The new expected value is similar to the MAC version as well.

  • platform/qt/Skipped:
  • platform/qt/fast/block/float/033-expected.txt:
2:28 AM Changeset in webkit [46756] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-04 Christian Plesner Hansen <​christian.plesner.hansen@gmail.com>

Reviewed by Adam Barth.

[v8] Fix crash when converting empty v8 string to atomic webkit string.
​https://bugs.webkit.org/show_bug.cgi?id=27975

collection-null-like-arguments.html tests for this.

  • bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
2:26 AM Changeset in webkit [46755] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool --commit-queue should validate commit-queue setter is a committer
​https://bugs.webkit.org/show_bug.cgi?id=27974

With a test!

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py:
1:59 AM Changeset in webkit [46754] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=27973

The trailing comma (suppresses newlines) was lost in r46700.

  • Scripts/bugzilla-tool:
1:54 AM Changeset in webkit [46753] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool has too many fatal errors
​https://bugs.webkit.org/show_bug.cgi?id=27969

Replace several fatal errors with ScriptError exceptions.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
  • Scripts/modules/scm.py:
1:34 AM Changeset in webkit [46752] by eric@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

2009-08-04 Eric Seidel <​eric@webkit.org>

No review, ChangeLog fix only.

Fix a ChangeLog line-spacing disaster caused by:
​https://bugs.webkit.org/show_bug.cgi?id=27973

Still unsure what the fix for bugzilla-tool will be.

1:18 AM Changeset in webkit [46751] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool --commit-queue should only land commit-queue+ patches
​https://bugs.webkit.org/show_bug.cgi?id=27970

commit-queue mode for bugzilla-tool
​https://bugs.webkit.org/show_bug.cgi?id=27918

Make bugzilla tool smart enough to find the commit-queue+ flags and
land those patches.
When we call land-patches with --commit-queue, we should filter the
patches we land to only those that have the commit-queue+ flag set.
That way, when we call bugzilla-tool from a main commit queue process,
we won't land the wrong patches.

  • Scripts/bugzilla-tool:
  • Scripts/modules/bugzilla.py:
1:14 AM Changeset in webkit [46750] by eric@webkit.org
  • 2 edits
    3 adds in trunk/WebKitTools

2009-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

committer logic should be split out of bugzilla.py into its own module

​https://bugs.webkit.org/show_bug.cgi?id=27972

I also added unit tests for the functionality I added.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py: Added.
  • Scripts/modules/commiters_unittest.py: Added.
  • Scripts/modules/committers.py: Added.
12:13 AM Changeset in webkit [46749] by rniwa@webkit.org
  • 4 edits in trunk/WebCore

2009-08-04 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

selectionHasStyle needs clean up to fix Bug 27858
​https://bugs.webkit.org/show_bug.cgi?id=27865

This patch cleans up selectionStartHasStyle and selectionHasStyle.
No test is added because the patch does not change any behavior.

  • editing/ApplyStyleCommand.cpp: (WebCore::getPropertiesNotInComputedStyle): Used in triStateOfStyleInComputedStyle but will be used here as well
  • editing/ApplyStyleCommand.h: Added the prototype of getPropertiesNotInComputedStyle
  • editing/Editor.cpp: (WebCore::triStateOfStyleInComputedStyle): Determines if the specified style is present in the specified computed style. (WebCore::Editor::selectionStartHasStyle): Uses triStateOfStyleInComputedStyle (WebCore::Editor::selectionHasStyle): Uses triStateOfStyleInComputedStyle instead of updateState
12:06 AM Changeset in webkit [46748] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-08-03 John Abd-El-Malek <​jam@chromium.org>

Reviewed by David Levin.

Fix MessagePort construction in worker process. Also make the other object constructions match this.

​https://bugs.webkit.org/show_bug.cgi?id=27906

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToV8Object):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):
Note: See TracTimeline for information about the timeline view.