Context Navigation

Add [DontEnum] to WML specific initializeWMLPageState/resetWMLPageState methods, to assure
fast/dom/Window/window-properties.html doesn't show any differences when WML is enabled.

1:34 PM Changeset in webkit [46958] by krit@webkit.org

2 edits in trunk/WebCore

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Filter need feColorMatrix implementation
https://bugs.webkit.org/show_bug.cgi?id=27711

Adds the filter effect feColorMatrix to SVG filters.

There is already a test in the w3c directory.
Test: svg/W3C-SVG-1.1/filters-color-01-b.svg

platform/graphics/filters/FEColorMatrix.cpp: (WebCore::matrix): (WebCore::saturate): (WebCore::huerotate): (WebCore::luminance): (WebCore::FEColorMatrix::apply):

12:32 PM Changeset in webkit [46957] by krit@webkit.org

2 edits in trunk/WebCore

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Build fix for Tiger.

platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):

12:11 PM Changeset in webkit [46956] by krit@webkit.org

27 edits
1 add in trunk/WebCore

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

This is an initial implementation for linearRGB and sRGB support for all
platforms. Some platforms like Cg support different color spaces
natively, others like Qt, Cairo and Skia do not. This patch uses the
native implementation of platforms if possible and offers a common version
if not.

Different color spaces are used in SVG Filters. Nearly every Filter test
case is a test for this patch and will be enabled, once Filters are enabled.

GNUmakefile.am:
WebCore.pro:
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
platform/graphics/ImageBuffer.cpp: Added. (WebCore::ImageBuffer::transformColorSpace):
platform/graphics/ImageBuffer.h: (WebCore::): (WebCore::ImageBuffer::create):
platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::getEffectContext):
platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
platform/graphics/skia/SkiaUtils.cpp: (WebCore::scratchContext):
platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::ImageBuffer):
platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

10:13 AM Changeset in webkit [46955] by xan@webkit.org

2 edits
3 deletes in trunk

WebCore:

2009-08-08 Xan Lopez <xlopez@igalia.com>

Roll out r46928, since it wasn't done in accordance with the
agreed naming.

bindings/gdom/GdomDOMObject.cpp: Removed.

WebKit/gtk:

2009-08-08 Xan Lopez <xlopez@igalia.com>

Roll out r46928, since it wasn't done in accordance with the
agreed naming.

ChangeLog:

Remove the ChangeLog entry, since it was added at the bottom of
the file.

gdom/GdomDOMObject.h: Removed.
gdom/GdomDOMObjectPrivate.h: Removed.

9:01 AM Changeset in webkit [46954] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-08-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool needs a --quiet option
https://bugs.webkit.org/show_bug.cgi?id=28060

A first pass at a --quiet option. This doesn't do all the excting
things we might want, but it addresses 80% of the use case.

Scripts/bugzilla-tool:

2:29 AM Changeset in webkit [46953] by Simon Hausmann

2 edits in trunk/WebKit/qt

Doc: there is no group of explicitly shared classes, only one class uses this.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-08-08
Reviewed by Simon Hausmann.

Explain the implications in the QWebHistoryItem documentation, and get rid
of the "group".

Api/qwebhistory.cpp:

12:39 AM Changeset in webkit [46952] by jmalonzo@webkit.org

12 edits
2 adds in trunk

2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Enable accessibility in Gtk DRT
https://bugs.webkit.org/show_bug.cgi?id=25989

Add SPI to get the focused accessible element to be used by DRT.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_focused_element):
accessibility/gtk/AccessibilityObjectWrapperAtk.h:
webkit/webkitprivate.h:
webkit/webkitwebframe.cpp: (webkit_web_frame_get_focused_accessible_element):

Remove passing accessibility tests from the Skipped list

platform/gtk/Skipped:

Add Accessibility support to the GTK DRT.

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): (AccessibilityController::rootElement):
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added. (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getDocumentLinks): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::childrenCount): (AccessibilityUIElement::elementAtPoint): (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::allAttributes): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfDocumentLinks): (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (AccessibilityUIElement::attributesOfChildren): (AccessibilityUIElement::parameterizedAttributeNames): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::language): (AccessibilityUIElement::x): (AccessibilityUIElement::y): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::clickPointX): (AccessibilityUIElement::clickPointY): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue): (AccessibilityUIElement::valueDescription): (AccessibilityUIElement::isEnabled): (AccessibilityUIElement::insertionPointLineNumber): (AccessibilityUIElement::isActionSupported): (AccessibilityUIElement::isRequired): (AccessibilityUIElement::attributesOfColumnHeaders): (AccessibilityUIElement::attributesOfRowHeaders): (AccessibilityUIElement::attributesOfColumns): (AccessibilityUIElement::attributesOfRows): (AccessibilityUIElement::attributesOfVisibleCells): (AccessibilityUIElement::attributesOfHeader): (AccessibilityUIElement::indexInTable): (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::lineForIndex): (AccessibilityUIElement::boundsForRange): (AccessibilityUIElement::cellForColumnAndRow): (AccessibilityUIElement::selectedTextRange): (AccessibilityUIElement::setSelectedTextRange): (AccessibilityUIElement::attributeValue): (AccessibilityUIElement::isAttributeSettable): (AccessibilityUIElement::increment): (AccessibilityUIElement::decrement):
DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): (main):
GNUmakefile.am:

Aug 7, 2009:

11:08 PM Changeset in webkit [46951] by jmalonzo@webkit.org

2 edits in trunk/WebCore

Gtk build fix - add html/canvas to the binding generator's include path

10:17 PM Changeset in webkit [46950] by oliver@apple.com

1 edit
3 adds in trunk/LayoutTests

Test function declaration parsing

Reviewed by Cameron Zwarich

9:42 PM Changeset in webkit [46949] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-08-07 Simon Fraser <Simon Fraser>

Fix the build on 10.6.

WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]):

9:14 PM Changeset in webkit [46948] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-08-07 Simon Fraser <Simon Fraser>

Fix a stylistic nit related to the location of the *, which, for some
ridiculous reason, WebKit style dictates to be different between Objective-C and C++.

WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

9:08 PM Changeset in webkit [46947] by Simon Fraser

4 edits in trunk/WebKit/mac

2009-08-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Work around an issue on Leopard where composited layers are misplaced and squished when the page
gets over 4096px tall.
https://bugs.webkit.org/show_bug.cgi?id=27272
<rdar://problem/7067892> [Leopard] Composisted layers are misplaced and squished on on long pages
<rdar://problem/7068252> [Leopard] When switching to a tab with HW layers, they fade in

WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Call -_updateLayerHostingViewPosition after scrolling.

WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Call -_updateLayerHostingViewPosition after the view changes size.

(-[WebHTMLView attachRootLayer:]):
Turn off default animations, to avoid animations of sublayer transform, and fading-in
when tab switching.

WebView/WebHTMLViewInternal.h: (-[WebHTMLView _updateLayerHostingViewPosition]): New method that constrains the height of the layer-hosting view to a max height of 4096px, and compensates for the height restriction by placing the layer-hosting view at the top of the visible part of the WebHTMLView, and adjusting the position of the hosted layers via sublayer transform.

8:31 PM Changeset in webkit [46946] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip two new tests (from r46896) needing gtk-specific results.

platform/gtk/Skipped:

8:06 PM Changeset in webkit [46945] by oliver@apple.com

2 edits in trunk/WebKitSite

2009-08-07 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Oliver Hunt.

Fix webkit-jobs link

contact.html:

7:33 PM Changeset in webkit [46944] by jmalonzo@webkit.org

2 edits in trunk/WebKitTools

Unreviewed Gtk build fix

7:22 PM Changeset in webkit [46943] by oliver@apple.com

3 edits in trunk/WebCore

Another windows build fix attempt

7:11 PM Changeset in webkit [46942] by oliver@apple.com

2 edits in trunk/WebCore

Windows build fix

6:57 PM Changeset in webkit [46941] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix - add html/canvas to the include path.

GNUmakefile.am:

6:43 PM Changeset in webkit [46940] by treat@webkit.org

2 edits in trunk/WebCore

Prospective build fix for Qt following r46937.

Patch by Adam Treat <adam.treat@torchmobile.com> on 2009-08-07

WebCore.pro:

6:25 PM Changeset in webkit [46939] by abarth@webkit.org

2 edits in trunk/WebCore

2009-08-07 Yong Li <yong.li@torchmobile.com>

WINCE PORT: store only width for GlyphBufferAdvance, to save space on low-memory devices
https://bugs.webkit.org/show_bug.cgi?id=27734

platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::advanceData): (WebCore::GlyphBuffer::add):

6:24 PM Changeset in webkit [46938] by abarth@webkit.org

2 edits in trunk/WebCore

2009-08-07 Yong Li <yong.li@torchmobile.com>

Reviewed by Eric Seidel.

WINCE PORT: pass unrecognized glyphs to GDI to handle
https://bugs.webkit.org/show_bug.cgi?id=27734

platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):

6:01 PM Changeset in webkit [46937] by cmarrin@apple.com

8 edits
14 moves
1 add in trunk/WebCore

Move Canvas related file to a subdirectories
https://bugs.webkit.org/show_bug.cgi?id=28026

5:54 PM Changeset in webkit [46936] by abarth@webkit.org

2 edits in trunk/WebCore

2009-08-07 Szabo Carol <carol.szabo@nokia.com>

Reviewed by David Hyatt.

QtWebkit ignores letter-spacing and word-spacing styles.
QtWebkit handles custom letter-spacing and word-spacing in the native QFont
class, but the values for these options are not not passed on from
the platform independent part of the Font class.
Fixed QtWebkit behavior by applying the options to QFont when it is
returned via Font::font()

http://bugs.webkit.org/show_bug.cgi?id=27988

LayoutTests:
fast/css/word-space-extra.html
css2.1/t1604-c542-letter-sp-00-b-a.html
css2.1/t1604-c541-word-sp-01-b-a.html
css1/text_properties/word_spacing.html

platform/graphics/qt/FontQt.cpp: (WebCore::Font::font):

5:52 PM Changeset in webkit [46935] by abarth@webkit.org

3 edits in trunk/WebCore

2009-08-07 Nicolas Weber <thakis@chromium.org>

Reviewed by Darin Adler.

Use correct highlight color for listboxes and completion popups.

https://bugs.webkit.org/show_bug.cgi?id=28090

rendering/RenderThemeChromiumMac.h:
rendering/RenderThemeChromiumMac.mm: Rename activeListBoxSelectionBackgroundColor to platformActiveListBoxSelectionBackgroundColor, so that it actually overrides a virtual method.

5:48 PM Changeset in webkit [46934] by abarth@webkit.org

1 edit
4 adds in trunk/WebCore

2009-08-07 Maxime Simon <Maxime Simon>

Reviewed by Eric Seidel.

Added a fourth bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26988

platform/haiku/PasteboardHaiku.cpp: Added. (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::clear):
platform/haiku/PlatformKeyboardEventHaiku.cpp: Added. (WebCore::keyIdentifierForHaikuKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
platform/haiku/PlatformMouseEventHaiku.cpp: Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
platform/haiku/PlatformWheelEventHaiku.cpp: Added. (WebCore::PlatformWheelEvent::PlatformWheelEvent):

5:41 PM Changeset in webkit [46933] by abarth@webkit.org

2 edits in trunk/JavaScriptCore

2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Eric Seidel.

Allow custom memory allocation control for Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879

Several classes which are inherited from Noncopyable are instantiated by
operator new, so Noncopyable class has been inherited from FastAllocBase.

wtf/Noncopyable.h:

2009-08-07 George Staikos <george.staikos@torchmobile.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27305
Implement WinCE-specific unicode layer.
Written by George Staikos <george.staikos@torchmobile.com>
with bug fixes by Yong Li <yong.li@torchmobile.com>
refactored by Joe Mason <joe.mason@torchmobile.com>

wtf/Platform.h:
wtf/unicode/Unicode.h:
wtf/unicode/wince/UnicodeWince.cpp: Added. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::toTitleCase): (WTF::Unicode::direction): (WTF::Unicode::category): (WTF::Unicode::decompositionType): (WTF::Unicode::combiningClass): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
wtf/unicode/wince/UnicodeWince.h: Added. (WTF::Unicode::): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::isArabicChar): (WTF::Unicode::hasLineBreakingPropertyComplexContext): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):

5:06 PM Changeset in webkit [46932] by Darin Adler

2 edits in trunk/LayoutTests

platform/gtk/Skipped: Skip a newly-failing test. I filed a bug about it too.

5:03 PM Changeset in webkit [46931] by abarth@webkit.org

2 edits in trunk/WebCore

2009-08-07 Nicolas Weber <thakis@chromium.org>

Teach WebKit how to decode jpegs in cmyk and ycck color spaces.
Heavily inspired by Firefox's take on this issue.

https://bugs.webkit.org/show_bug.cgi?id=27909

Reviewed by Eric Seidel.

platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): Tell jpeglib to convert ycck to cmyk and keep cmyk. (WebCore::convertCMYKToRGBA): Added function to convert cmyk to rgb. (WebCore::convertRGBToRGBA): Extracted existing conversion logic into its own function. (WebCore::JPEGImageDecoder::outputScanlines): Call convertCMYKToRGBA for cmyk images, convertRGBToRGBA for rgb images.

5:03 PM Changeset in webkit [46930] by Darin Adler

2 edits in trunk/LayoutTests

platform/gtk/Skipped: Updated since textarea-arrow-navigation.html moved.

5:02 PM Changeset in webkit [46929] by bweinstein@apple.com

2 edits in trunk/LayoutTests

2009-08-07 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Mark Rowe.

Add http/tests/misc/favicon-loads-with-images-disabled.html to get the
Windows Debug bot back green.

platform/win/Skipped:

4:51 PM Changeset in webkit [46928] by abarth@webkit.org

1 edit
4 adds in trunk

2009-07-30 Martin Robinson <mrobinson@appcelerator.com>

Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.

[GTK] new-window-policy-decision-requested provides no information about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792

Add frameName property to the WebKitWebNavigation object.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_property): (webkit_web_navigation_action_set_property): (webkit_web_navigation_action_class_init): (webkit_web_navigation_action_get_target_frame): (webkit_web_navigation_action_set_target_frame):
webkit/webkitwebnavigationaction.h:

4:34 PM Changeset in webkit [46927] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/commit-log-editor: Fix unchecked access to environment

variable that may not be there.

4:25 PM Changeset in webkit [46926] by Darin Adler

16 edits
2 moves
1 add
5 deletes in trunk/LayoutTests

"Shadow tree" DOM nodes are being accidentally exposed to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=28086

Patch by Darin Adler <Darin Adler> on 2009-08-07
Reviewed by Adele Peterson.

Rewrite tests that depend on selection inside <input> and <textarea> elements
from showing up with getSelection(), since does not match Firefox and needs to
change soon.

editing/deleting/delete-ligature-002-expected.txt: Updated.
editing/deleting/delete-ligature-002.html: Changed to use a contenteditable