Context Navigation

Correct behaviour of stringify when using a replacer function that returns
undefined. This is a simple change to move the undefined value check to
after the replacer function is called. This means that the replacer function
is now called for properties with the value undefined, however i've confirmed
that this behaviour is correct.

In addition I've made the cyclic object exception have a more useful error
message.

4:33 PM Changeset in webkit [46966] by Nikolas Zimmermann

21 edits
24 adds in trunk

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.

WebView/WebFramePrivate.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.

Interfaces/IWebFramePrivate.idl:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Rewrite WML deck access control, actually works now standalone and within LayoutTests.
Added several new layout tests covering local & remote access support.

In order to detect WML task execution failures from within the WML layout tests a new
method Console::lastWMLErrorMessage() has been added, returning the last recorded WML
error message. Change WML log messages to dump to InspectorClient, just like it's done
for HTML - we used to behave like JSMessageSource, which is wrong.

Tests: http/tests/wml/access-target-domain-deny.html

http/tests/wml/access-target-path-deny.html
http/tests/wml/access-target.html
wml/access-target-deny.html
wml/access-target.html

inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::source): Added public method to fetch the message source type. (WebCore::ConsoleMessage::message): Added public method to access the error message.
inspector/InspectorController.h: (WebCore::InspectorController::consoleMessages): Added for Console::lastWMLErrorMessage(), to be able to crawl through the list of dumped messages.
loader/FrameLoader.cpp: Recognize 'FrameLoadTypeBackWMLDeckNotAccessible', all guarded by ENABLE(WML). (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::loadItem):
loader/FrameLoaderTypes.h: (WebCore::): Add new load type 'FrameLoadTypeBackWMLDeckNotAccessible', behaving like FrameLoadTypeBack plus WML specific information.
page/Console.cpp: (WebCore::Console::addMessage): Don't dump WML messages using ChromeClient (as it's done for JSMessageSource), but go through InspectorController. (WebCore::Console::lastWMLErrorMessage): Crawl InspectorController::consoleMssages() to look up the last WML error message, if present.
page/Console.h:
page/Console.idl: Add "[DontEnum] DOMString lastWMLErrorMessage()".
wml/WMLAccessElement.cpp: Store path/domain as member variables and pass them to WMLPageState once in insertedIntoDocument(). (WebCore::WMLAccessElement::parseMappedAttribute): (WebCore::WMLAccessElement::insertedIntoDocument):
wml/WMLAccessElement.h:
wml/WMLCardElement.cpp: Handle 'FrameLoadTypeBackWMLDeckNotAccessible' as deck-entry method. Report WML error in current deck. (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
wml/WMLDocument.cpp: Enable deck-access control in finishedParsing. Take care of method name changes in WMLPageState. (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
wml/WMLErrorHandling.cpp: Never report 'WMLErrorDeckNotAccessible' messages through the tokenizer, that would alter the page into error state. (WebCore::reportWMLError):
wml/WMLPageState.cpp: Completly rewrote access path/domain parsing & deck-access control, strictly following the WML spec. All covered by tests. (WebCore::WMLPageState::WMLPageState): (WebCore::normalizedHostName): (WebCore::hostFromURL): (WebCore::urlForHistoryItem): (WebCore::tryAccessHistoryURLs): (WebCore::WMLPageState::processAccessControlData): (WebCore::WMLPageState::resetAccessControlData): (WebCore::WMLPageState::canAccessDeck): (WebCore::WMLPageState::hostIsAllowedToAccess): (WebCore::WMLPageState::pathIsAllowedToAccess):
wml/WMLPageState.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Add several new tests covering WML deck-access control.
Update variable-reference-invalid-character.html result, as console messages aren't dump to the results anymore.

http/tests/wml/access-target-domain-deny-expected.txt: Added.
http/tests/wml/access-target-domain-deny.html: Added.
http/tests/wml/access-target-expected.txt: Added.
http/tests/wml/access-target-path-deny-expected.txt: Added.
http/tests/wml/access-target-path-deny.html: Added.
http/tests/wml/access-target.html: Added.
http/tests/wml/resources/access-target-domain-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
http/tests/wml/resources/access-target-domain-deny.wml: Added.
http/tests/wml/resources/access-target-path-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
http/tests/wml/resources/access-target-path-deny.wml: Added.
http/tests/wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
http/tests/wml/resources/access-target.wml: Added.
http/tests/wml/resources/locked-deck.wml: Added.
http/tests/wml/resources/unreachable-domain.wml: Added.
http/tests/wml/resources/unreachable-path.wml: Added.
wml/access-target-deny-expected.txt: Added.
wml/access-target-deny.html: Added.
wml/access-target-expected.txt: Added.
wml/access-target.html: Added.
wml/resources/access-target-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
wml/resources/access-target-deny.wml: Added.
wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
wml/resources/access-target.wml: Added.
wml/resources/locked-deck.wml: Added.
wml/variable-reference-invalid-character-expected.txt:

3:04 PM Changeset in webkit [46965] by Nikolas Zimmermann

4 edits in trunk

Reviewed by Maciej Stachowiak.

FrameLoadType / WebFrameLoadType enums are out of sync
https://bugs.webkit.org/show_bug.cgi?id=28132

Modify FrameLoadType enum to match the order of WebFrameLoadType in WebFramePrivate.h / IWebFramePrivate.idl.
The mac/win public API exposes the old 'FrameLoadTypeReloadAllowingStaleData' value, which resides between
'FrameLoadTypeReload' and 'FrameLoadTypeSame'. Work around this problem, by assigning 'FrameLoadTypeSame = FrameLoadTypeReload + 2'.

Add a note to the FrameLoadType enum to keep it in sync with WebFramePrivate.h & IWebFramePrivate.idl.

8:41 AM Changeset in webkit [46964] by Nikolas Zimmermann

25 edits in trunk

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722

Fix intrinsic event execution, leading to crashes.
First finish parsing the document, then execute the events. Not the other way round.
-> exposes bugs all over the WML layout tests, which relied on that quirk.

Fixes manual-tests/wml/onevent-prev.wml.

wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument): (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
wml/WMLDocument.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722

Reorganize WML testcases to not rely on the fact that intrinsic events are executed before the document finished parsing.

http/tests/wml/resources/go-task-get-method-accept-charset.js:
http/tests/wml/resources/go-task-get-method.js:
http/tests/wml/resources/go-task-post-method-accept-charset.js:
http/tests/wml/resources/go-task-post-method.js:
http/tests/wml/resources/post-data-to-server.js:
wml/resources/WMLTestCase.js: (onloadHandler): (createStaticWMLTestCase): (createDynamicWMLTestCase): (createWMLTestCase.iframeElement.onload): (createWMLTestCase):
wml/resources/enter-card-with-events.js: (executeTest):
wml/resources/enter-first-card-with-events.js: (setupTestDocument): (prepareTest): (executeTest):
wml/resources/go-task-get-method-external-deck-with-href.js:
wml/resources/go-task-get-method-external-deck.js:
wml/resources/go-task-get-method-same-deck.js:
wml/resources/input-format.js:
wml/resources/newcontext-same-deck.js: (setupTestDocument): (executeTest):
wml/resources/onenterforward-event.js: (executeTest):
wml/resources/onenterforward-inline-event.js:
wml/resources/ontimer-event.js: (executeTest):
wml/resources/ontimer-inline-event.js: (executeTest):
wml/resources/option-element-onpick.js:
wml/resources/select-element-variables.js:
wml/resources/variable-reference-invalid-character.js:
wml/resources/variable-reference-valid.js:

3:33 AM Changeset in webkit [46963] by oliver@apple.com

8 edits in trunk

[ES5] Implement Object.getPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=28114

Reviewed by Eric Seidel and Sam Weinig.

Implement getPrototypeOf

Aug 8, 2009:

6:36 PM Changeset in webkit [46962] by Dimitri Glazkov

1 edit in trunk/WebCore/ChangeLog

Updated ChangeLog with bug URLs.

6:31 PM Changeset in webkit [46961] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-08-08 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Update WebCore.gyp to add ImageBuffer.cpp,
introduced by http://trac.webkit.org/changeset/46956.

WebCore.gypi: Added ImageBuffer.cpp.

4:28 PM Changeset in webkit [46960] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip media/controls-right-click-on-timebar.html as it needs
eventSender which we don't have at the moment.

platform/gtk/Skipped:

3:39 PM Changeset in webkit [46959] by Nikolas Zimmermann

2 edits in trunk/WebCore

Rubber-stamped by Jan Michael Alonzo.

Add [DontEnum] to WML specific initializeWMLPageState/resetWMLPageState methods, to assure
fast/dom/Window/window-properties.html doesn't show any differences when WML is enabled.

1:34 PM Changeset in webkit [46958] by krit@webkit.org

2 edits in trunk/WebCore

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Filter need feColorMatrix implementation
https://bugs.webkit.org/show_bug.cgi?id=27711

Adds the filter effect feColorMatrix to SVG filters.

There is already a test in the w3c directory.
Test: svg/W3C-SVG-1.1/filters-color-01-b.svg

platform/graphics/filters/FEColorMatrix.cpp: (WebCore::matrix): (WebCore::saturate): (WebCore::huerotate): (WebCore::luminance): (WebCore::FEColorMatrix::apply):

12:32 PM Changeset in webkit [46957] by krit@webkit.org

2 edits in trunk/WebCore

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Build fix for Tiger.

platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):

12:11 PM Changeset in webkit [46956] by krit@webkit.org

27 edits
1 add in trunk/WebCore

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

This is an initial implementation for linearRGB and sRGB support for all
platforms. Some platforms like Cg support different color spaces
natively, others like Qt, Cairo and Skia do not. This patch uses the
native implementation of platforms if possible and offers a common version
if not.

Different color spaces are used in SVG Filters. Nearly every Filter test
case is a test for this patch and will be enabled, once Filters are enabled.

GNUmakefile.am:
WebCore.pro:
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
platform/graphics/ImageBuffer.cpp: Added. (WebCore::ImageBuffer::transformColorSpace):
platform/graphics/ImageBuffer.h: (WebCore::): (WebCore::ImageBuffer::create):
platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::getEffectContext):
platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
platform/graphics/skia/SkiaUtils.cpp: (WebCore::scratchContext):
platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::ImageBuffer):
platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

10:13 AM Changeset in webkit [46955] by xan@webkit.org

2 edits
3 deletes in trunk

WebCore:

2009-08-08 Xan Lopez <xlopez@igalia.com>

Roll out r46928, since it wasn't done in accordance with the
agreed naming.

bindings/gdom/GdomDOMObject.cpp: Removed.

WebKit/gtk:

2009-08-08 Xan Lopez <xlopez@igalia.com>

Roll out r46928, since it wasn't done in accordance with the
agreed naming.

ChangeLog:

Remove the ChangeLog entry, since it was added at the bottom of
the file.

gdom/GdomDOMObject.h: Removed.
gdom/GdomDOMObjectPrivate.h: Removed.

9:01 AM Changeset in webkit [46954] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-08-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool needs a --quiet option
https://bugs.webkit.org/show_bug.cgi?id=28060

A first pass at a --quiet option. This doesn't do all the excting
things we might want, but it addresses 80% of the use case.

Scripts/bugzilla-tool:

2:29 AM Changeset in webkit [46953] by Simon Hausmann

2 edits in trunk/WebKit/qt

Doc: there is no group of explicitly shared classes, only one class uses this.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-08-08
Reviewed by Simon Hausmann.

Explain the implications in the QWebHistoryItem documentation, and get rid
of the "group".

Api/qwebhistory.cpp:

12:39 AM Changeset in webkit [46952] by jmalonzo@webkit.org

12 edits
2 adds in trunk

2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Enable accessibility in Gtk DRT
https://bugs.webkit.org/show_bug.cgi?id=25989

Add SPI to get the focused accessible element to be used by DRT.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_focused_element):
accessibility/gtk/AccessibilityObjectWrapperAtk.h:
webkit/webkitprivate.h:
webkit/webkitwebframe.cpp: (webkit_web_frame_get_focused_accessible_element):

Remove passing accessibility tests from the Skipped list

platform/gtk/Skipped:

Add Accessibility support to the GTK DRT.

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): (AccessibilityController::rootElement):
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added. (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getDocumentLinks): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::childrenCount): (AccessibilityUIElement::elementAtPoint): (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::allAttributes): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfDocumentLinks): (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (AccessibilityUIElement::attributesOfChildren): (AccessibilityUIElement::parameterizedAttributeNames): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::language): (AccessibilityUIElement::x): (AccessibilityUIElement::y): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::clickPointX): (AccessibilityUIElement::clickPointY): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue): (AccessibilityUIElement::valueDescription): (AccessibilityUIElement::isEnabled): (AccessibilityUIElement::insertionPointLineNumber): (AccessibilityUIElement::isActionSupported): (AccessibilityUIElement::isRequired): (AccessibilityUIElement::attributesOfColumnHeaders): (AccessibilityUIElement::attributesOfRowHeaders): (AccessibilityUIElement::attributesOfColumns): (AccessibilityUIElement::attributesOfRows): (AccessibilityUIElement::attributesOfVisibleCells): (AccessibilityUIElement::attributesOfHeader): (AccessibilityUIElement::indexInTable): (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::lineForIndex): (AccessibilityUIElement::boundsForRange): (AccessibilityUIElement::cellForColumnAndRow): (AccessibilityUIElement::selectedTextRange): (AccessibilityUIElement::setSelectedTextRange): (AccessibilityUIElement::attributeValue): (AccessibilityUIElement::isAttributeSettable): (AccessibilityUIElement::increment): (AccessibilityUIElement::decrement):
DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): (main):
GNUmakefile.am:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed