Context Navigation

The object is appended to the MarkStack, this sets the marked bit for the object using the new markDirect() function, and then returns
When the MarkStack is drain()ed the object is popped off the stack and markChildren(MarkStack&) is called on the object to collect all of its children. drain() then repeats until the stack is empty.

Additionally I renamed a number of methods from 'mark' to 'markAggregate'
in order to make it more clear that marking of those object was not
going to result in an actual recursive mark.

9:17 PM Changeset in webkit [47021] by jorlow@chromium.org

7 edits in trunk/WebCore

2009-08-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

Renamed all V8 NPN_ functions to _NPN_ to match JSC and make them "private".
https://bugs.webkit.org/show_bug.cgi?id=28089

Rename all the NPN_foo functions to _NPN_foo so that they can't directly be
called by mistake. This roughly matches the way JSC does it, which is an
additional advantage.

bindings/v8/NPV8Object.cpp: (npCreateV8ScriptObject): (_NPN_Invoke): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_EvaluateHelper): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException): (_NPN_Enumerate): (_NPN_Construct):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearScriptObjects): (WebCore::ScriptController::createScriptInstanceForWidget): (WebCore::ScriptController::cleanupScriptObjectsForPlugin):
bindings/v8/V8NPObject.cpp: (npObjectInvokeImpl): (npObjectGetProperty): (npObjectIndexedPropertyGetter): (npObjectGetIndexedProperty): (npObjectSetProperty): (npObjectIndexedPropertySetter): (npObjectSetIndexedProperty): (weakNPObjectCallback): (createV8ObjectForNPObject): (forgetV8ObjectForNPObject):
bindings/v8/V8NPUtils.cpp: (getStringIdentifier):
bindings/v8/npruntime.cpp:
bindings/v8/npruntime_impl.h:

9:02 PM Changeset in webkit [47020] by jorlow@chromium.org

16 edits in trunk

2009-08-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Brady Eidson.

Change _Storage.key() to match current spec behavior.
https://bugs.webkit.org/show_bug.cgi?id=28112

The current WebStorage spec says that _Storage.key() should return null when
the index is out of bounds, rather than an exception. A bunch of logic can be
simplified after this change.

bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getPropertyNames):
bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator):
storage/Storage.cpp: (WebCore::Storage::key):
storage/Storage.h:
storage/Storage.idl:
storage/StorageArea.h:
storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::key):
storage/StorageAreaImpl.h:
storage/StorageMap.cpp: (WebCore::StorageMap::key):
storage/StorageMap.h:

2009-08-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Brady Eidson.

_Storage.key() changed to match new spec behavior; update layout tests.
https://bugs.webkit.org/show_bug.cgi?id=28112

The current WebStorage spec says that _Storage.key() should return null when
the index is out of bounds, rather than an exception. Change the one layout
test that verified this behavior.

storage/domstorage/localstorage/simple-usage-expected.txt:
storage/domstorage/localstorage/simple-usage.html:
storage/domstorage/sessionstorage/simple-usage-expected.txt:
storage/domstorage/sessionstorage/simple-usage.html:

8:59 PM Changeset in webkit [47019] by jorlow@chromium.org

1 edit in trunk/WebCore/ChangeLog

Fix silly change log bustage.

8:49 PM Changeset in webkit [47018] by jorlow@chromium.org

4 edits in trunk/WebCore

2009-08-07 Michael Nordman <Michael Nordman>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=28087

Mods for a chrome specific impl of ApplicationCacheHost.

The public section of the interface is the same, but we use PLATFORM(CHROMIUM) to identify which parts of the private section are shared. The chrome specific internals are encapsulated in a seperate ApplicationCacheHostInternal class. WebCore common code only contains a forward reference to this class.

Cleanup a couple of stale comments.

Have window.applicationCache return null to script when the feature is disabled in the preferences.

No new tests.

loader/appcache/ApplicationCacheHost.cpp:
loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::documentLoader):
page/DOMWindow.cpp: (WebCore::DOMWindow::applicationCache):

<<<<<<< .mine

7:55 PM Changeset in webkit [47017] by dimich@chromium.org

19 edits
6 deletes in trunk

Revert r47015 "Added support for overriding default preferences per-test."
https://bugs.webkit.org/show_bug.cgi?id=20534

Ir broke too many Windows tests and I don't have a simple fix right now.

7:53 PM Changeset in webkit [47016] by ben@webkit.org

3 edits in trunk/WebCore

2009-08-10 Crystal Zhang <crystal.zhang@staikos.net>

Reviewed by George Staikos.

Implement GraphicsContext::fillRoundRect() for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27842

platform/graphics/GraphicsContext.h:
platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::rectCenterPoint): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawRoundCorner):

7:18 PM Changeset in webkit [47015] by dimich@chromium.org

19 edits
7 adds in trunk

WebKit/mac: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added new methods for overriding default WebPreference values
and for resetting preferences to their defaults.
https://bugs.webkit.org/show_bug.cgi?id=20534

WebView/WebPreferences.mm:

(-[WebPreferences _setPreferenceForTestWithValue:withKey:]): added.

WebView/WebPreferencesPrivate.h: same.

WebKit/win: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
https://bugs.webkit.org/show_bug.cgi?id=20534

Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
WebPreferences.cpp: same.
WebPreferences.h: same.

WebKitTools: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
https://bugs.webkit.org/show_bug.cgi?id=20534

DumpRenderTree/LayoutTestController.cpp:

(overridePreferenceCallback): add wiring for layoutTestController.overridePreference.
(LayoutTestController::staticFunctions): same.

DumpRenderTree/LayoutTestController.h: same.
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference): added empty overridePreference method.

DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override.

(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time DRT starts.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::overridePreference):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
(createWebViewAndOffscreenWindow): same.
(main): same.

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::overridePreference):

DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::overridePreference):

LayoutTests: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added tests to verify that default preferences can be overridden per-test
and that overridden values are reset between each test.
https://bugs.webkit.org/show_bug.cgi?id=20534

fast/harness/override-preferences-2-expected.txt: Added.
fast/harness/override-preferences-2.html: Added. Verifies overridePreverence("WebKitDefaultFontSize", "24").
fast/harness/override-preferences-expected.txt: Added.
fast/harness/override-preferences.html: Added. Verifies overridePreference("WebKitJavaScriptEnabled", false).
fast/harness/override-zzz-reset-expected.txt: Added.
fast/harness/override-zzz-reset.html: Added. Because of 'zzz' this test will run after the tests above and

verify that override of preferences does not 'spill' to the subsequent tests in a batch.

platform/gtk/Skipped: Tests above disabled for GTK until GTK DRT implements preference override.
platform/qt/Skipped: same for QT.

6:11 PM Coding Style Guidelines edited by atwilson@chromium.org

(diff)

5:34 PM Changeset in webkit [47014] by mitz@apple.com

2 edits in trunk/WebKit/win

Link drag images specify Lucida Grande on Windows and end up using Times
New Roman
<rdar://problem/7117835>

Reviewed by Darin Adler.

WebCoreSupport/WebDragClient.cpp:

(dragLabelFont): Added a RenderingMode parameter and changed to use the

same typeface as the Windows small caption font.

(WebDragClient::createDragImageForLink): Changed to respect the

page’s rendering mode.

5:15 PM Changeset in webkit [47013] by sfalken@apple.com

2 edits in trunk/WebKitTools

Windows nightly fix.

Reviewed by Ada Chan.

FindSafari/FindSafari.cpp:

(_tmain): Copy Safari.dll if it exists.

4:47 PM Changeset in webkit [47012] by pkasting@chromium.org

2 edits in trunk/WebKitLibraries

https://bugs.webkit.org/show_bug.cgi?id=27323
Even more line ending-stripping for auto-version.sh, based on output
provided by Jessie Berlin.

Reviewed by George Staikos.

win/tools/scripts/auto-version.sh:

4:29 PM Changeset in webkit [47011] by rik@webkit.org

5 edits in trunk/WebCore

Inspector Resources / Graphs should support filtering
https://bugs.webkit.org/show_bug.cgi?id=20629

Patch by Anthony Ricaud <rik@webkit.org> on 2009-08-10
Reviewed by Timothy Hatcher.

Introduces a filter bar for resources.

Thanks to Matt Lilek for the CSS scope bar.

English.lproj/localizedStrings.js:
inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.createFilterElement):
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.toolbarItemClass.categoryOrder.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):
(WebInspector.ResourcesPanel.prototype._updateSummaryGraph):

inspector/front-end/inspector.css:
inspector/front-end/inspector.js:

(WebInspector.loaded):

4:17 PM Changeset in webkit [47010] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Fix hundreds of "pointer being freed was not allocated" errors seen on the build bot.

Reviewed by Darin Adler.

wtf/FastMalloc.h: Implement nothrow variants of the delete and delete[] operators since

we implement the nothrow variants of new and new[]. The nothrow variant of delete is called
explicitly in the implementation of std::sort which was resulting in FastMalloc-allocated
memory being passed to the system allocator to free.

3:37 PM Changeset in webkit [47009] by bfulgham@webkit.org

2 edits in trunk/WebCore

Unreviewed build correction after http://trac.webkit.org/changeset/46978

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle): Correct

deprecated removeRef to new removeFragmentIdentifier.

3:27 PM Changeset in webkit [47008] by rniwa@webkit.org

5 edits
2 adds in trunk

WebCore: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch makes background color be preserved during editing.
In particular, editingStyleAtPosition would include the background color when obtaining styles.

editing/ApplyStyleCommand.cpp:

(WebCore::): Added CSSPropertyBackgroundColor to editingStyleProperties

LayoutTests: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch adds a test to make sure WebKit preserves background color when inserting a new paragraph.

editing/inserting/5994480-2-expected.txt: Because input element has explicit white background and the enclosing div has

transparent background, WebKit adds white background color in DeleteSelectionCommand::calculateTypingStyleAfterDelete upon deletion.

editing/style/highlight-insert-paragraph-expected.txt: Added.
editing/style/highlight-insert-paragraph.html: Added.
platform/mac/editing/pasteboard/select-element-1-expected.txt: Because select element has explicit white background color

and div has transparent background, WebKit adds white background color in calculateTypingStyleAfterDelete upon cut.

3:14 PM Changeset in webkit [47007] by Nikolas Zimmermann

3 edits in trunk/LayoutTests

Rubber-stamped by George Staikos.
Forgot to update pixel test result in my last commit.

3:13 PM Changeset in webkit [47006] by levin@chromium.org

3 edits in trunk/WebKitTools

2009-08-10 David Levin <levin@chromium.org>

Reviewed by David Kilzer.

check-webkit-style doesn't catch braces around single line statements when followed by else.
https://bugs.webkit.org/show_bug.cgi?id=28164

Scripts/modules/cpp_style.py: Added else to the regex that finds ending }'s when checking the no braces for "single lines" rule.
Scripts/modules/cpp_style_unittest.py: Added test case.

2:53 PM Changeset in webkit [47005] by ddkilzer@apple.com

3 edits in trunk/WebKitTools

<http://webkit.org/b/28163> bugzilla-tool: scm module should not import bugzilla module

Reviewed by David Levin.

Scripts/bugzilla-tool: (parse_bug_id): Added. Moved from CommitMessage.parse_bug_id() in scm module.
Scripts/modules/scm.py: Removed import of bugzilla module. (CommitMessage.parse_bug_id): Deleted.

2:17 PM Changeset in webkit [47004] by kenneth@webkit.org

2 edits in trunk/WebCore

Stop sending QEvent::CursorChange to Qt for mouse move.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-10
Reviewed by Simon Hausmann.

Verify if the cursor didn't change in WidgetQt::setCursor,
just like the mac port does.

Thanks to Adriano Rezendo for spotting and debugging the
issue.

platform/qt/WidgetQt.cpp:

(WebCore::Widget::setCursor):

2:04 PM Changeset in webkit [47003] by jmalonzo@webkit.org

2 edits in trunk/JavaScriptCore

2009-08-10 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Unreviewed build fix. Move JSAPIValueWrapper.cpp/.h in the debug
section. This file is already part of AllInOneFile in Release builds.

GNUmakefile.am:

1:58 PM BuildingOnWindows edited by jberlin@apple.com

Add information about not being able to find debugging symbols (diff)

1:51 PM Changeset in webkit [47002] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=28165
Application cache maximum size cannot be set before the database is opened

loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::vacuumDatabaseFile): Open appcache database if it isn't open yet.

1:37 PM Changeset in webkit [47001] by Dimitri Glazkov

11 edits in trunk/WebCore

2009-08-10 Vitaly Repeshko <vitalyr@quad.spb.corp.google.com>

Reviewed by Dimitri Glazkov.

[V8] Fix memory leak in node event listeners. See http://crbug.com/17400.
https://bugs.webkit.org/show_bug.cgi?id=28156

bindings/scripts/CodeGeneratorV8.pm: Custom event handler accessors now apply to all Node descendants.
bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::isObjectListener): Added virtual method to detect listeners that have weak references to JS objects.
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
bindings/v8/V8ObjectEventListener.cpp:
bindings/v8/V8ObjectEventListener.h: (WebCore::V8ObjectEventListener::isObjectListener):
bindings/v8/V8Utilities.cpp: (WebCore::removeHiddenDependency):
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8ElementCustom.cpp:
bindings/v8/custom/V8NodeCustom.cpp: Moved custom accessors from V8ElementCustom.cpp. (WebCore::toEventType): (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): Made static.

12:46 PM Changeset in webkit [47000] by Darin Adler

2 edits in trunk/JavaScriptCore

wtf/FastMalloc.h: Fix build.

12:42 PM Changeset in webkit [46999] by Darin Adler

3 edits in trunk/JavaScriptCore

FastMalloc.h has cross-platform code but marked as WinCE-only
https://bugs.webkit.org/show_bug.cgi?id=28160

Patch by Darin Adler <Darin Adler> on 2009-08-10
Reviewed by Mark Rowe.

1) The support for nothrow was inside #if PLATFORM(WINCE) even though it is

not platform-specific.

2) The code tried to override operator delete nothrow, which does not exist.
3) The code in the header checks the value of USE_SYSTEM_MALLOC, but the code

in FastMalloc.cpp checks only if the macro is defined.

wtf/FastMalloc.h: See above.
wtf/FastMalloc.cpp: Ditto.

12:37 PM Changeset in webkit [46998] by jorlow@chromium.org

1 edit in trunk/WebCore/ChangeLog

Fix date in ChangeLog

12:34 PM Changeset in webkit [46997] by jorlow@chromium.org

5 edits in trunk/WebCore

2009-08-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Cleanup DOM Storage namespace shutdown code + usage of security origin.
https://bugs.webkit.org/show_bug.cgi?id=28094

If a storage namespace is not explicitly closed, be sure to do so on
destruction of the object. In addition, the close call should wait
on the background thread finishing its syncing. (Not doing so is actually
a regression from the original LocalStorage code.)

There's no point to passing in the SecurityOrigin when copying a storage
area since what was passed in is exactly what is stored within each
storage area. In addition, the non-copy constructor should take in a
PassRefPtr rather than a pointer since that pointer was only passed into
the constuctor for RefPtr's anyway.

storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy):
storage/StorageAreaImpl.h:
storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::close):
storage/StorageNamespaceImpl.h:

12:30 PM Changeset in webkit [46996] by Nikolas Zimmermann

4 edits in trunk/WebCore

Not reviewed, build fix.
Rename ref() to fragmentIdentifier() in the wml/ subdirectory.

12:15 PM Changeset in webkit [46995] by sfalken@apple.com

2 edits in trunk/WebCore

Windows build fix.

Exclude JSMedia.cpp from build since it is included in DerivedSources.cpp.
Fixes linker warnings.

Corrected spelling of JSInspectorBackend.cpp.

Other changes related to actually using a Visual Studio to open/save the vcproj file.

WebCore.vcproj/WebCore.vcproj:

11:39 AM Changeset in webkit [46994] by weinig@apple.com

2 edits in trunk/WebCore

Remove a dead #define.

Reviewed by Anders Carlsson.

bindings/js/JSDOMBinding.cpp:

11:36 AM Changeset in webkit [46993] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-08-10 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Update KURLGoogle for ref* method renames in
http://trac.webkit.org/changeset/46978.
https://bugs.webkit.org/show_bug.cgi?id=28084

bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): Renamed ref and setRef to fragmentIdentifier and

setFragmentIdentifier, respectively.

platform/KURLGoogle.cpp: Ditto, plus all other ref* method names.

11:30 AM Changeset in webkit [46992] by weinig@apple.com

2 edits in trunk/JavaScriptCore

Fix an annoying indentation issue.

Reviewed by Anders Carlsson.

runtime/DateConstructor.cpp:

(JSC::constructDate):

11:26 AM Changeset in webkit [46991] by jmalonzo@webkit.org

2 edits in trunk/WebCore

[Gtk] Unreviewed. Fix the nit as suggested by Darin in bug #28144 for r46989.

11:22 AM Changeset in webkit [46990] by bfulgham@webkit.org

4 edits
1 add in trunk

WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=28048.
Move various WinCairo build settings into *.vsprops file.

Reviewed by Adam Roben.

WebKit.vcproj/WebKit.vcproj: Add new cURL.vsprops property sheet (which contains link settings for cURL and its dependencies), and remove the corresponding entries from the vcproj file. Remove png, jpeg, cairo library linking flags from vcproj, now that they are in the WinCairo.vsprops file.

WebKitLibraries: https://bugs.webkit.org/show_bug.cgi?id=28048.
Move various WinCairo build settings into *.vsprops file.

Reviewed by Adam Roben.

win/tools/vsprops/cURL.vsprops: Added.

11:20 AM Changeset in webkit [46989] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2009-08-10 John Kjellberg <john.kjellberg@power.alstom.com>

Reviewed by Darin Adler.

Memory leak in error handling code for SOUP interface
https://bugs.webkit.org/show_bug.cgi?id=28144

Freed memory leaked in error handling code for soup requests.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback): (WebCore::):

11:18 AM Changeset in webkit [46988] by pkasting@chromium.org

2 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=18599
Work around apparent bug in abs2rel() with symlinked directories.

Reviewed by David Kilzer.

Scripts/resolve-ChangeLogs:

11:10 AM Changeset in webkit [46987] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-08-10 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Provide graceful handling of the situation when an embedder invokes
visited link update methods before a Page constructor has been called.
https://bugs.webkit.org/show_bug.cgi?id=28149

page/Page.cpp: (WebCore::Page::allVisitedStateChanged): Added a null-check for allPages. (WebCore::Page::visitedStateChanged): Ditto.

11:03 AM Changeset in webkit [46986] by xan@webkit.org

2 edits in trunk/WebCore

2009-08-10 Xan Lopez <xlopez@igalia.com>

Fix GTK+ build.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):

10:56 AM Changeset in webkit [46985] by mitz@apple.com

3 edits in trunk/WebCore

Remove the redundant, Windows CE-only GlyphBuffer::advnaceData()

Reviewed by Anders Carlsson.

platform/graphics/GlyphBuffer.h: Removed advanceData().
platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::drawText): Changed to use advances(from)

instead of advanceData() + from.

10:37 AM Changeset in webkit [46984] by xan@webkit.org

2 edits in trunk/WebCore

2009-08-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove workaround for older libsoup versions.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):

10:37 AM Changeset in webkit [46983] by xan@webkit.org

2 edits in trunk/WebCore

2009-08-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Let startHttp validate the URI instead of doing it, with potential
crashes, in ::start.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):

10:28 AM Changeset in webkit [46982] by Darin Adler

6 edits
3 adds in trunk

WebCore: When empty <input> is focused, getSelection() exposes shadow tree nodes
https://bugs.webkit.org/show_bug.cgi?id=15903

Patch by Darin Adler <Darin Adler> on 2009-08-10
Reviewed by Dan Bernstein.

Test: fast/forms/shadow-tree-exposure.html

page/DOMSelection.cpp:

(WebCore::selectionShadowAncestor): Added.
(WebCore::DOMSelection::anchorNode): Return the parent of the shadow
ancestor if the selection is in a shadow tree. Matches Firefox.
(WebCore::DOMSelection::anchorOffset): Return the index of the shadow
ancestor if the selection is in a shadow tree. Matches Firefox.
(WebCore::DOMSelection::focusNode): Ditto.
(WebCore::DOMSelection::focusOffset): Ditto.
(WebCore::DOMSelection::baseNode): More of the same, but since this
is a WebKit-invented property, it does not match Firefox.
(WebCore::DOMSelection::baseOffset): Ditto.
(WebCore::DOMSelection::extentNode): Ditto.
(WebCore::DOMSelection::extentOffset): Ditto.
(WebCore::DOMSelection::isCollapsed): Return true even when the
selection is a range, if the selection is in the shadow tree.
Matches Firefox. Also changed behavior when called and the frame
is gone to return true instead of false which makes more sense.
(WebCore::DOMSelection::empty): Use clear() just like the other
selection-clearing function in this file does.
(WebCore::DOMSelection::getRangeAt): Return a range that starts
and ends before the shadow ancestor. Matches Firefox.

LayoutTests: When empty <input> is focused, getSelection() exposes shadow tree nodes
https://bugs.webkit.org/show_bug.cgi?id=15903

Patch by Darin Adler <Darin Adler> on 2009-08-07
Reviewed by Dan Bernstein.

Also updated a recently introduced non-standard test to work in a more
standard way.

fast/forms/resources/shadow-tree-exposure.js: Added.
fast/forms/shadow-tree-exposure-expected.txt: Added.
fast/forms/shadow-tree-exposure.html: Added.

fast/js/method-check-expected.txt: Updated.
fast/js/method-check.html: Regenerated using the make-js-test-wrappers script.
fast/js/resources/method-check.js: Replaced a comment talking about the lack

of a gc() function with a call to GCController.collect(). Also removed the
shouldBeTrue call at the end of the fiel that wasn't needed.

10:25 AM Changeset in webkit [46981] by mitz@apple.com

2 edits in trunk/WebKitTools

Build fix

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(NPP_New):

10:07 AM Changeset in webkit [46980] by beidson@apple.com

2 edits in trunk/WebKit/gtk

GTK build fix.

webkit/webkitdownload.cpp:

(webkit_download_get_suggested_filename):

9:53 AM Changeset in webkit [46979] by pfeldman@chromium.org

10 edits
15 adds
12 deletes in trunk/WebCore

2009-08-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Make all status bar button images glyph-based.

https://bugs.webkit.org/show_bug.cgi?id=28124

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
inspector/front-end/Images/clearConsoleButtonGlyph.png: Added.
inspector/front-end/Images/clearConsoleButtons.png: Removed.
inspector/front-end/Images/consoleButtonGlyph.png: Added.
inspector/front-end/Images/consoleButtons.png: Removed.
inspector/front-end/Images/dockButtonGlyph.png: Added.
inspector/front-end/Images/dockButtons.png: Removed.
inspector/front-end/Images/enableButtons.png: Removed.
inspector/front-end/Images/enableOutlineButtonGlyph.png: Added.
inspector/front-end/Images/enableSolidButtonGlyph.png: Added.
inspector/front-end/Images/excludeButtonGlyph.png: Added.
inspector/front-end/Images/excludeButtons.png: Removed.
inspector/front-end/Images/focusButtonGlyph.png: Added.
inspector/front-end/Images/focusButtons.png: Removed.
inspector/front-end/Images/largerResourcesButtonGlyph.png: Added.
inspector/front-end/Images/largerResourcesButtons.png: Removed.
inspector/front-end/Images/nodeSearchButtonGlyph.png: Added.
inspector/front-end/Images/nodeSearchButtons.png: Removed.
inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Added.
inspector/front-end/Images/pauseOnExceptionButtons.png: Removed.
inspector/front-end/Images/percentButtonGlyph.png: Added.
inspector/front-end/Images/percentButtons.png: Removed.
inspector/front-end/Images/recordButtonGlyph.png: Added.
inspector/front-end/Images/recordButtons.png: Removed.
inspector/front-end/Images/recordToggledButtonGlyph.png: Added.
inspector/front-end/Images/reloadButtonGlyph.png: Added.
inspector/front-end/Images/reloadButtons.png: Removed.
inspector/front-end/Images/undockButtonGlyph.png: Added.
inspector/front-end/Panel.js: (WebInspector.Panel.prototype.createStatusBarButton):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:

9:49 AM QtWebKitFeatures46 edited by kenneth@webkit.org

(diff)

9:35 AM Changeset in webkit [46978] by beidson@apple.com

19 edits in trunk/WebCore

KURL ref() methods should be fragmentIdentifier() methods
https://bugs.webkit.org/show_bug.cgi?id=28084

Reviewed by Darin Adler.

In addition to the renames, also took the chance to replace all use of:
setRef(String());
with:
removeFragmentIdentifier();

platform/KURL.cpp:

(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::setFragmentIdentifier):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore::KURL::prettyURL):
(WebCore::equalIgnoringFragmentIdentifier):

platform/KURL.h:

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setHash): Rework with new names, and to use the new equalIgnoringNullity() method.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement):

css/CSSCursorImageValue.cpp:

(WebCore::isSVGCursorIdentifier):

history/HistoryItem.cpp:

(WebCore::HistoryItem::isCurrentDocument):

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::hash):

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::begin):
(WebCore::FrameLoader::gotoAnchor):
(WebCore::FrameLoader::scheduleLocationChange):
(WebCore::FrameLoader::scrollToAnchor):
(WebCore::FrameLoader::shouldReload):
(WebCore::FrameLoader::urlsMatchItem):

loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::resourceForURL):
(WebCore::ApplicationCache::resourceForRequest):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::cacheForMainRequest):
(WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::addEntry):

loader/appcache/ApplicationCacheResource.h:

(WebCore::ApplicationCacheResource::create):

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):

loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

page/Location.cpp:

(WebCore::Location::hash):

page/Page.cpp:

(WebCore::Page::goToItem):

rendering/RenderPartObject.cpp:

(WebCore::isURLAllowed):

workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::hash):

9:19 AM Changeset in webkit [46977] by vestbo@webkit.org

2 edits in trunk/WebKitTools

2009-08-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Adam Roben.

Allow TestNetscapePlugIn to fall back to the Carbon event model

Previously the plugin would fail, even though the Carbon event
model was available. The only way to get the Carbon event model
was to pass the "forcecarbon" argument in the test markup, but no
tests were using this.

Now the plugin uses carbon either if it's forced, or if the Cocoa
event model is not supported.

This helps us run most of the plugin tests on Qt/Mac, which still
does not support the Cocoa event model.

8:45 AM QtWebKitFeatures46 edited by ben@webkit.org

(diff)

8:27 AM QtWebKitJournal edited by Simon Hausmann

(diff)

8:26 AM QtWebKitFeatures46 created by Simon Hausmann

8:22 AM QtWebKitJournal edited by Simon Hausmann

(diff)

8:07 AM QtWebKitJournal edited by Simon Hausmann

(diff)

7:51 AM QtWebKitJournal edited by Simon Hausmann

(diff)

7:47 AM Changeset in webkit [46976] by xan@webkit.org

2 edits in trunk/JavaScriptCore

2009-08-10 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Add new files to makefile.

GNUmakefile.am:

7:29 AM QtWebKitJournal edited by Simon Hausmann

(diff)

7:10 AM QtWebKitJournal edited by Simon Hausmann

(diff)

7:05 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:39 AM Changeset in webkit [46975] by Simon Hausmann

3 edits in trunk/WebKit/qt

Various fixes and improvements to the QWebPluginInfo, QWebPluginDatabase and QWebSettings documentation.

Patch by Kavindra Palaraja <kavindra.palaraja@nokia.com> on 2009-08-10
Reviewed by Simon Hausmann.

Api/qwebplugindatabase.cpp:
Api/qwebsettings.cpp:

5:49 AM QtWebKit edited by Simon Hausmann

(diff)

5:46 AM Changeset in webkit [46974] by Simon Hausmann

12 edits
1 add in trunk/LayoutTests

[Qt] After ChangeSet https://bugs.webkit.org/show_bug.cgi?id=26896, the
DefaultFontSize was changed in Qt DumpRenderTree from 14 to 13. But
any expected file works with the original value. The expected values
should follow this change. This patch contains the new expected
files.

Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-08-10
Reviewed by Simon Hausmann.

platform/qt/Skipped:
platform/qt/editing/pasteboard/5780697-2-expected.txt: Add.
platform/qt/fast/block/float/009-expected.txt:
platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
platform/qt/fast/images/image-in-map-expected.txt:
platform/qt/fast/inline-block/004-expected.txt:
platform/qt/fast/inline-block/005-expected.txt:
platform/qt/fast/table/giantRowspan-expected.txt:
platform/qt/fast/table/height-percent-test-expected.txt:
platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
platform/qt/tables/mozilla/bugs/bug50695-2-expected.txt:
platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:

5:36 AM Changeset in webkit [46973] by Simon Hausmann

2 edits in trunk/WebCore

Fix endless loop when the application is quit by a secondary thread during a sync xml http request.

Patch by Andy Shaw <andy.shaw@nokia.com> on 2009-08-10
Reviewed by Simon Hausmann.

Replace the m_finished state variable and the call to QCoreApplication::processEvents() with
a dedicated QEventLoop, that can be terminated from within WebCoreSynchronousLoader as well
as from Qt through its knowledge of globally registered eventloops.

There is no unit test for this bug as it would require exporting additional symbols and
introduce the synchronous loader as global variable just for the test.

platform/network/qt/ResourceHandleQt.cpp:

(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::waitForCompletion):

3:02 AM Changeset in webkit [46972] by pfeldman@chromium.org

10 edits
1 add in trunk/WebCore

2009-08-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Make properties inspection serialized.

https://bugs.webkit.org/show_bug.cgi?id=28078

inspector/front-end/DOMAgent.js: (InspectorController.getPrototypes): (InspectorController.getProperties):
inspector/front-end/InjectedScript.js: (InjectedScript.getPrototypes): (InjectedScript.getProperties): (InjectedScript.setPropertyValue):
inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectRef): (WebInspector.ObjectPropertyRef): (WebInspector.ObjectPropertiesSection.prototype.onpopulate): (WebInspector.ObjectPropertiesSection.prototype.update.callback): (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype._update): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.onattach): (WebInspector.ObjectPropertyTreeElement.prototype.update):
inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):

1:16 AM Changeset in webkit [46971] by Simon Hausmann

2 edits in trunk/LayoutTests

Rebase Qt letter spacing DRT result after r46936

Reviewed by Ariya Hidayat.

platform/qt/fast/text/text-letter-spacing-expected.txt:

1:01 AM Changeset in webkit [46970] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Fix compilation with the interpreter instead of the JIT by including
PrototypeFunction.h as forward-declared through NativeFunctionWrapper.h.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-10

runtime/ObjectConstructor.cpp:

Aug 9, 2009:

5:47 PM Changeset in webkit [46969] by Nikolas Zimmermann

5 edits in trunk

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] wml.css lacks <pre> support
https://bugs.webkit.org/show_bug.cgi?id=28135

Add <pre> support for WML.
Extended fast/wml/text-emphasis.wml to cover <pre> support.

css/wml.css: <pre> section copied from html.css

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] wml.css lacks <pre> support
https://bugs.webkit.org/show_bug.cgi?id=28135

Extend fast/wml/text-emphasis.wml test, to cover <pre> formatting.

fast/wml/text-emphasis.wml:
platform/mac/fast/wml/text-emphasis-expected.txt:

5:01 PM Changeset in webkit [46968] by Nikolas Zimmermann

2 edits in trunk/WebCore

Reviewed by Oliver Hunt.
Fix non-WML enabled builds. Remove ENABLE(WML) guards around the switch cases 'FrameLoadTypeBackWMLDeckNotAccessible'.

4:55 PM Changeset in webkit [46967] by oliver@apple.com

4 edits
3 adds in trunk

JSON.stringify replacer returning undefined does not omit object properties
https://bugs.webkit.org/show_bug.cgi?id=28118

Reviewed by George Staikos

Correct behaviour of stringify when using a replacer function that returns
undefined. This is a simple change to move the undefined value check to
after the replacer function is called. This means that the replacer function
is now called for properties with the value undefined, however i've confirmed
that this behaviour is correct.

In addition I've made the cyclic object exception have a more useful error
message.

4:33 PM Changeset in webkit [46966] by Nikolas Zimmermann

21 edits
24 adds in trunk

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.

WebView/WebFramePrivate.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.

Interfaces/IWebFramePrivate.idl:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Rewrite WML deck access control, actually works now standalone and within LayoutTests.
Added several new layout tests covering local & remote access support.

In order to detect WML task execution failures from within the WML layout tests a new
method Console::lastWMLErrorMessage() has been added, returning the last recorded WML
error message. Change WML log messages to dump to InspectorClient, just like it's done
for HTML - we used to behave like JSMessageSource, which is wrong.

Tests: http/tests/wml/access-target-domain-deny.html

http/tests/wml/access-target-path-deny.html
http/tests/wml/access-target.html
wml/access-target-deny.html
wml/access-target.html

inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::source): Added public method to fetch the message source type. (WebCore::ConsoleMessage::message): Added public method to access the error message.
inspector/InspectorController.h: (WebCore::InspectorController::consoleMessages): Added for Console::lastWMLErrorMessage(), to be able to crawl through the list of dumped messages.
loader/FrameLoader.cpp: Recognize 'FrameLoadTypeBackWMLDeckNotAccessible', all guarded by ENABLE(WML). (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::loadItem):
loader/FrameLoaderTypes.h: (WebCore::): Add new load type 'FrameLoadTypeBackWMLDeckNotAccessible', behaving like FrameLoadTypeBack plus WML specific information.
page/Console.cpp: (WebCore::Console::addMessage): Don't dump WML messages using ChromeClient (as it's done for JSMessageSource), but go through InspectorController. (WebCore::Console::lastWMLErrorMessage): Crawl InspectorController::consoleMssages() to look up the last WML error message, if present.
page/Console.h:
page/Console.idl: Add "[DontEnum] DOMString lastWMLErrorMessage()".
wml/WMLAccessElement.cpp: Store path/domain as member variables and pass them to WMLPageState once in insertedIntoDocument(). (WebCore::WMLAccessElement::parseMappedAttribute): (WebCore::WMLAccessElement::insertedIntoDocument):
wml/WMLAccessElement.h:
wml/WMLCardElement.cpp: Handle 'FrameLoadTypeBackWMLDeckNotAccessible' as deck-entry method. Report WML error in current deck. (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
wml/WMLDocument.cpp: Enable deck-access control in finishedParsing. Take care of method name changes in WMLPageState. (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
wml/WMLErrorHandling.cpp: Never report 'WMLErrorDeckNotAccessible' messages through the tokenizer, that would alter the page into error state. (WebCore::reportWMLError):
wml/WMLPageState.cpp: Completly rewrote access path/domain parsing & deck-access control, strictly following the WML spec. All covered by tests. (WebCore::WMLPageState::WMLPageState): (WebCore::normalizedHostName): (WebCore::hostFromURL): (WebCore::urlForHistoryItem): (WebCore::tryAccessHistoryURLs): (WebCore::WMLPageState::processAccessControlData): (WebCore::WMLPageState::resetAccessControlData): (WebCore::WMLPageState::canAccessDeck): (WebCore::WMLPageState::hostIsAllowedToAccess): (WebCore::WMLPageState::pathIsAllowedToAccess):
wml/WMLPageState.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Add several new tests covering WML deck-access control.
Update variable-reference-invalid-character.html result, as console messages aren't dump to the results anymore.

http/tests/wml/access-target-domain-deny-expected.txt: Added.
http/tests/wml/access-target-domain-deny.html: Added.
http/tests/wml/access-target-expected.txt: Added.
http/tests/wml/access-target-path-deny-expected.txt: Added.
http/tests/wml/access-target-path-deny.html: Added.
http/tests/wml/access-target.html: Added.
http/tests/wml/resources/access-target-domain-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
http/tests/wml/resources/access-target-domain-deny.wml: Added.
http/tests/wml/resources/access-target-path-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
http/tests/wml/resources/access-target-path-deny.wml: Added.
http/tests/wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
http/tests/wml/resources/access-target.wml: Added.
http/tests/wml/resources/locked-deck.wml: Added.
http/tests/wml/resources/unreachable-domain.wml: Added.
http/tests/wml/resources/unreachable-path.wml: Added.
wml/access-target-deny-expected.txt: Added.
wml/access-target-deny.html: Added.
wml/access-target-expected.txt: Added.
wml/access-target.html: Added.
wml/resources/access-target-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
wml/resources/access-target-deny.wml: Added.
wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
wml/resources/access-target.wml: Added.
wml/resources/locked-deck.wml: Added.
wml/variable-reference-invalid-character-expected.txt:

3:04 PM Changeset in webkit [46965] by Nikolas Zimmermann

4 edits in trunk

Reviewed by Maciej Stachowiak.

FrameLoadType / WebFrameLoadType enums are out of sync
https://bugs.webkit.org/show_bug.cgi?id=28132

Modify FrameLoadType enum to match the order of WebFrameLoadType in WebFramePrivate.h / IWebFramePrivate.idl.
The mac/win public API exposes the old 'FrameLoadTypeReloadAllowingStaleData' value, which resides between
'FrameLoadTypeReload' and 'FrameLoadTypeSame'. Work around this problem, by assigning 'FrameLoadTypeSame = FrameLoadTypeReload + 2'.

Add a note to the FrameLoadType enum to keep it in sync with WebFramePrivate.h & IWebFramePrivate.idl.

8:41 AM Changeset in webkit [46964] by Nikolas Zimmermann

25 edits in trunk

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722

Fix intrinsic event execution, leading to crashes.
First finish parsing the document, then execute the events. Not the other way round.
-> exposes bugs all over the WML layout tests, which relied on that quirk.

Fixes manual-tests/wml/onevent-prev.wml.

wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument): (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
wml/WMLDocument.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722

Reorganize WML testcases to not rely on the fact that intrinsic events are executed before the document finished parsing.

http/tests/wml/resources/go-task-get-method-accept-charset.js:
http/tests/wml/resources/go-task-get-method.js:
http/tests/wml/resources/go-task-post-method-accept-charset.js:
http/tests/wml/resources/go-task-post-method.js:
http/tests/wml/resources/post-data-to-server.js:
wml/resources/WMLTestCase.js: (onloadHandler): (createStaticWMLTestCase): (createDynamicWMLTestCase): (createWMLTestCase.iframeElement.onload): (createWMLTestCase):
wml/resources/enter-card-with-events.js: (executeTest):
wml/resources/enter-first-card-with-events.js: (setupTestDocument): (prepareTest): (executeTest):
wml/resources/go-task-get-method-external-deck-with-href.js:
wml/resources/go-task-get-method-external-deck.js:
wml/resources/go-task-get-method-same-deck.js:
wml/resources/input-format.js:
wml/resources/newcontext-same-deck.js: (setupTestDocument): (executeTest):
wml/resources/onenterforward-event.js: (executeTest):
wml/resources/onenterforward-inline-event.js:
wml/resources/ontimer-event.js: (executeTest):
wml/resources/ontimer-inline-event.js: (executeTest):
wml/resources/option-element-onpick.js:
wml/resources/select-element-variables.js:
wml/resources/variable-reference-invalid-character.js:
wml/resources/variable-reference-valid.js:

3:33 AM Changeset in webkit [46963] by oliver@apple.com

8 edits in trunk

[ES5] Implement Object.getPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=28114

Context Navigation

Timeline

Aug 10, 2009:

Aug 9, 2009:

Download in other formats: