Timeline
Aug 16, 2009:
- 10:26 PM Changeset in webkit [47350] by
-
- 2 edits in trunk/WebCore
StyledElement should use ASCIICType instead of having its own toHex function
https://bugs.webkit.org/show_bug.cgi?id=28377
Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.
- dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSColor): Use isASCIIHexDigit and toASCIIHexValue.
- 10:24 PM Changeset in webkit [47349] by
-
- 2 edits in trunk/WebKit/mac
<http://webkit.org/b/28366> WebHTMLViewInternal.h: add @class CALayer declaration
Reviewed by Simon Fraser.
Without WebKitPrefix.h, the missing @class CALayer declaration
causes a compile-time error.
- WebView/WebHTMLViewInternal.h: Added @class CALayer declaration with USE(ACCELERATED_COMPOSITING).
- 10:24 PM Changeset in webkit [47348] by
-
- 5 edits in trunk
WebCore: execCommand("InsertHorizontalRule") inserts a broken <hr> element
https://bugs.webkit.org/show_bug.cgi?id=28375
Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.
- editing/EditorCommand.cpp:
(WebCore::executeInsertHorizontalRule): Create an HTMLHRElement
instead of just an HTMLElement.
LayoutTests: execCommand("InsertHorizontalRule") inserts a broken <hr> element
https://bugs.webkit.org/show_bug.cgi?id=28375
Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.
- editing/execCommand/arguments-combinations-expected.txt: Updated.
- editing/execCommand/arguments-combinations.html: Updated to expect
the <hr> element to be self-closing rather than having a separate
</hr> in the markup.
- 5:45 PM Changeset in webkit [47347] by
-
- 7 edits4 adds in trunk
2009-08-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] <option> element & 'onpick' events - history navigation is broken
https://bugs.webkit.org/show_bug.cgi?id=28371
After selecting an option element with an 'onpick' event associated with a 'go' task,
the navigation is executed. When going back in history, the same 'onpick' event is fired
again. Fix that problem, add wml/option-element-onpick-recursion.html covering the bug.
Test: wml/option-element-onpick-recursion.html
- wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::handleIntrinsicEventIfNeeded):
- wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::WMLSelectElement): (WebCore::WMLSelectElement::selectInitialOptions):
- wml/WMLSelectElement.h: (WebCore::WMLSelectElement::initialized):
2009-08-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] <option> element & 'onpick' events - history navigation is broken
https://bugs.webkit.org/show_bug.cgi?id=28371
Add new test covering history navigation & 'onpick' event handling.
- wml/option-element-onpick-recursion-expected.txt: Added.
- wml/option-element-onpick-recursion.html: Added.
- wml/resources/WMLTestCase.js: (createStaticWMLTestCase): (createDynamicWMLTestCase):
- wml/resources/option-element-onpick-recursion.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/option-element-onpick-recursion.wml: Added.
- wml/resources/option-element-onpick.js: (prepareTest):
- 5:44 PM Changeset in webkit [47346] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
Reviewed by David Levin.
In <http://webkit.org/b/28355#c1>, it was noted that new source
files use 'using namespace std;' instead of individual
'using std::foo;' statements. This adds a level 4 check for
such statements.
- Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'build/using_std'. (check_using_std): Added. (check_style): Added call to check_using_std().
- Scripts/modules/cpp_style_unittest.py: (WebKitStyleTest.test_using_std): Added unit test.
- 5:32 PM Changeset in webkit [47345] by
-
- 3 edits in trunk/WebKitTools
Backed out r47343 which was mistakenly committed
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 5:30 PM Changeset in webkit [47344] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
Reviewed by David Levin.
The ScriptError class doesn't exist in bugzilla.py, so any
errors print error messages about ScriptError instead of the
actual error:
NameError: global name 'ScriptError' is not defined
- Scripts/modules/bugzilla.py: (BugzillaError): Added class. Modeled after ScriptError class in scm.py. (Bugzilla.authenticate): Changed to use BugzillaError instead of ScriptError. (Bugzilla._check_create_bug_response): Ditto.
- 5:30 PM Changeset in webkit [47343] by
-
- 2 edits in trunk/WebKitTools/Scripts
WIP: bugzilla-tool: add land-commits command
- 4:24 PM Changeset in webkit [47342] by
-
- 2 edits in trunk/WebCore
Inspector Resource filtering: keyboard Navigation always uses ALL resources
https://bugs.webkit.org/show_bug.cgi?id=28231
Patch by Anthony Ricaud <rik@webkit.org> on 2009-08-16
Reviewed by Timothy Hatcher.
Determine if a resource is selectable on user action.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceSidebarTreeElement.prototype.get selectable):
- 3:57 PM Changeset in webkit [47341] by
-
- 10 edits in trunk
<http://webkit.org/b/28355> Replace MAX()/MIN() macros with type-safe std::max()/min() templates
Reviewed by Dan Bernstein.
WebCore:
- accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetSpelling): Changed MIN() to min().
- platform/graphics/mac/FontMacATSUI.mm: (WebCore::Font::selectionRectForComplexText): Changed MAX() to max() and MIN() to min(). (WebCore::Font::floatWidthForComplexText): Ditto.
- platform/graphics/mac/SimpleFontDataMac.mm: Added using std::max statement. (WebCore::SimpleFontData::platformInit): Changed MAX() to max().
- platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode): Changed MIN() to min().
WebKit/mac:
- Plugins/WebBaseNetscapePluginStream.mm: Added using std::min statement. (WebNetscapePluginStream::deliverData): Changed MIN() to min(). Changed C-style cast to a static_cast.
- Plugins/WebNetscapePluginView.mm: Added using std::min statement. (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): Changed MIN() to min(). Changed C-style cast to a static_cast.
- WebView/WebHTMLView.mm: Added using std::max statement. (-[WebHTMLView _dragImageForURL:withLabel:]): Changed MAX() to max(). (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
- WebView/WebTextCompletionController.mm: Added using std::max and using std::min statements. (-[WebTextCompletionController _placePopupWindow:]): Changed type of maxWidth variable from float to CGFloat to prevent a type mismatch on x86_64. Changed MAX() to max() and MIN() to min(). Added static_cast for a constant value since CGFloat is defined as a float on i386 and as a double on x86_64.
- 12:27 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:25 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:25 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:25 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:24 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:23 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:22 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:21 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:20 PM Flow chart edited by
- (diff)
- 12:18 PM Flow chart edited by
- (diff)
- 12:16 PM Flow chart edited by
- adding picture (diff)
- 12:15 PM Flow chart created by
- initial creation
- 10:35 AM Changeset in webkit [47340] by
-
- 11 edits in trunk/WebCore
2009-08-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Cleanup WMLIntrinsicEventHandling code
https://bugs.webkit.org/show_bug.cgi?id=28358
Remove superflous "Event* evt" parameter from executeTask() methods. It's a leftover from the initial WML merge.
- wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::defaultEventHandler):
- wml/WMLDoElement.cpp: (WebCore::WMLDoElement::defaultEventHandler):
- wml/WMLGoElement.cpp: (WebCore::WMLGoElement::executeTask):
- wml/WMLGoElement.h:
- wml/WMLIntrinsicEventHandler.cpp: (WebCore::WMLIntrinsicEventHandler::triggerIntrinsicEvent):
- wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::executeTask):
- wml/WMLPrevElement.h:
- wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::executeTask):
- wml/WMLRefreshElement.h:
- wml/WMLTaskElement.h:
- 9:15 AM Changeset in webkit [47339] by
-
- 21 edits in trunk/WebCore
2009-08-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: A handful of DOMAgent-related fixes and cleanups.
- renamed elementId to nodeId in operations on nodes.
- added load listeners to frame owners in InspectorDOMAgent.
- removed InspectorController::inspectedWindowScriptObjectCleared event.
- preserved isViaInspector flag for 'via inspector' marker to survive styles update.
- removed contentDocument-related logic from ElementsPanel since it is handled in
the InspectorDOMAgent.
- removed DOM listeners unregistration and corresponding events from InspectorController.
- made this.styles 'private' in ElementsPanel.
- added TODO for the handleCopy processing.
- WebCore.order:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setTextNodeValue):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerParentNode):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMDocument.prototype.addEventListener): (WebInspector.DOMDocument.prototype.removeEventListener): (WebInspector.DOMDocument.prototype._fireDomEvent): (WebInspector.DOMAgent.prototype.getChildNodesAsync.mycallback): (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.CSSStyleDeclaration.parseRule): (WebInspector.childNodeInserted): (WebInspector.childNodeRemoved):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.addStyleChange): (WebInspector.ElementsPanel.prototype.removeStyleChange): (WebInspector.ElementsPanel.prototype._updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.handleCopyEvent):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.findTreeElement): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.onexpand):
- inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector): (InjectedScript._serializeRule):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
- inspector/front-end/inspector.js: (WebInspector.set hoveredDOMNode):
- inspector/front-end/treeoutline.js: (TreeOutline.prototype.findTreeElement):
- inspector/front-end/utilities.js: (Node.prototype.enclosingNodeOrSelfWithNodeNameInArray): (Node.prototype.enclosingNodeOrSelfWithClass): (isAncestorNode): (firstCommonNodeAncestor): (traverseNextNode): (traversePreviousNode): ():
- loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable):
- page/android/InspectorControllerAndroid.cpp:
- 6:14 AM Changeset in webkit [47338] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Fix crash on ./ecma_2/RegExp/exec-002.js.
https://bugs.webkit.org/show_bug.cgi?id=28353
Change the order of freeParenthesesDisjunctionContext and
popParenthesesDisjunctionContext on all call sites as the pop
method is accessing backTrack->lastContext which is the context
that is about to be freed.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses):
- 6:14 AM Changeset in webkit [47337] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Fix coding style violations. Use m_ for C++ class members. Remove
trailing whitespace on empty lines.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::tryConsumeCharacter): (JSC::Yarr::Interpreter::tryConsumeBackReference): (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::ByteCompiler::ByteCompiler): (JSC::Yarr::ByteCompiler::compile): (JSC::Yarr::ByteCompiler::checkInput): (JSC::Yarr::ByteCompiler::assertionBOL): (JSC::Yarr::ByteCompiler::assertionEOL): (JSC::Yarr::ByteCompiler::assertionWordBoundary): (JSC::Yarr::ByteCompiler::atomPatternCharacter): (JSC::Yarr::ByteCompiler::atomCharacterClass): (JSC::Yarr::ByteCompiler::atomBackReference): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::popParenthesesStack): (JSC::Yarr::ByteCompiler::closeAlternative): (JSC::Yarr::ByteCompiler::closeBodyAlternative): (JSC::Yarr::ByteCompiler::atomParenthesesEnd): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction): (JSC::Yarr::ByteCompiler::alterantiveDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
- 5:33 AM Changeset in webkit [47336] by
-
- 1 edit1 add in trunk/LayoutTests
Not reviewed. Add missing WML specific layout test result.
Aug 15, 2009:
- 11:49 PM Changeset in webkit [47335] by
-
- 2 edits in trunk/LayoutTests
Make Mark Rowe a bit less grumpy.
- http/tests/history/back-to-post.php:
- 11:43 PM Changeset in webkit [47334] by
-
- 3 edits in trunk/LayoutTests
Make http/tests/history/back-to-post.php's output a bit more reliable.
- http/tests/history/back-to-post-expected.txt:
- http/tests/history/back-to-post.php:
- 9:40 PM Changeset in webkit [47333] by
-
- 2 edits in trunk/WebCore
2009-08-15 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Optimize updateFillImages() to not add/remove clients every time
https://bugs.webkit.org/show_bug.cgi?id=28334
Optimize the case where old and new just have a single layer pointing to the same (or no)
image.
- rendering/RenderObject.cpp: (WebCore::RenderObject::updateFillImages):
- 6:32 PM Changeset in webkit [47332] by
-
- 4 edits2 adds in trunk
2009-08-15 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Implement animations of multiple text-shadows and -webkit-box-shadows.
https://bugs.webkit.org/show_bug.cgi?id=28266
Test: transitions/multiple-shadow-transitions.html
- page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::equals): (WebCore::PropertyWrapperShadow::blend):
- 6:32 PM Changeset in webkit [47331] by
-
- 4 edits6 adds in trunk
2009-08-15 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Make transitions work for position and size of multiple backgrounds and masks.
https://bugs.webkit.org/show_bug.cgi?id=28266
Make background-position, background-size, -webkit-mask-position and -webkit-mask-size
properties animatable with multiple backgrounds, rather than just animating the first one.
Tests: transitions/multiple-background-size-transitions.html
transitions/multiple-background-transitions.html
transitions/multiple-mask-transitions.html
- page/animation/AnimationBase.cpp: (WebCore::FillLayerPropertyWrapperBase::FillLayerPropertyWrapperBase): (WebCore::FillLayerPropertyWrapperBase::~FillLayerPropertyWrapperBase): (WebCore::FillLayerPropertyWrapperGetter::FillLayerPropertyWrapperGetter): (WebCore::FillLayerPropertyWrapperGetter::equals): (WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper): (WebCore::FillLayerPropertyWrapper::blend): (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper): (WebCore::FillLayersPropertyWrapper::equals): (WebCore::FillLayersPropertyWrapper::blend): (WebCore::ensurePropertyMap):
- rendering/style/FillLayer.h: (WebCore::FillLayer::setXPosition): (WebCore::FillLayer::setYPosition): (WebCore::FillLayer::setSize):
- 5:23 PM Changeset in webkit [47330] by
-
- 3 edits in trunk/JavaScriptCore
Fix the build with JIT disabled.
- runtime/Arguments.h: Only compile the jitCode method when the JIT is enabled.
- runtime/Executable.h: Include PrototypeFunction.h so the compiler knows what
NativeFunctionWrapper is when the JIT is disabled.
- 5:16 PM Changeset in webkit [47329] by
-
- 3 edits1 add in trunk
2009-08-15 George Staikos <george.staikos@torchmobile.com>
Reviewed by Jan Alonzo.
Don't crash in fieldset code when WML is enabled.
https://bugs.webkit.org/show_bug.cgi?id=28012
Test: fast/wml/html-fieldset-crash.html
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::findLegend): ++brackets
- 4:01 PM Changeset in webkit [47328] by
-
- 3 edits in trunk/WebCore
Try and enable EventSource on Windows.
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/build-generated-files.sh:
- 3:54 PM Changeset in webkit [47327] by
-
- 1 edit2 deletes in trunk/LayoutTests
Remove no longer correct and now failing test. document.body.onunload
has now been spec'ed in HTML5.
- fast/events/onunload-body-property-expected.txt: Removed.
- fast/events/onunload-body-property.html: Removed.
- 3:14 PM Changeset in webkit [47326] by
-
- 4 edits6 adds in trunk
WebCore: Setting attribute event listeners to the body does not set them on the window
https://bugs.webkit.org/show_bug.cgi?id=28343
Reviewed by Dan Bernstein.
Tests: fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::setOnblur): Use setWindowAttributeEventListener instead of setAttributeEventListener.
(WebCore::HTMLBodyElement::setOnerror): Ditto.
(WebCore::HTMLBodyElement::setOnfocus): Ditto.
(WebCore::HTMLBodyElement::setOnload): Ditto.
(WebCore::HTMLBodyElement::setOnbeforeunload): Ditto.
(WebCore::HTMLBodyElement::setOnmessage): Ditto.
(WebCore::HTMLBodyElement::setOnoffline): Ditto.
(WebCore::HTMLBodyElement::setOnonline): Ditto.
(WebCore::HTMLBodyElement::setOnresize): Ditto.
(WebCore::HTMLBodyElement::setOnstorage): Ditto.
(WebCore::HTMLBodyElement::setOnunload): Ditto.
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::setOnblur): Ditto.
(WebCore::HTMLFrameSetElement::setOnerror): Ditto.
(WebCore::HTMLFrameSetElement::setOnfocus): Ditto.
(WebCore::HTMLFrameSetElement::setOnload): Ditto.
(WebCore::HTMLFrameSetElement::setOnbeforeunload): Ditto.
(WebCore::HTMLFrameSetElement::setOnmessage): Ditto.
(WebCore::HTMLFrameSetElement::setOnoffline): Ditto.
(WebCore::HTMLFrameSetElement::setOnonline): Ditto.
(WebCore::HTMLFrameSetElement::setOnresize): Ditto.
(WebCore::HTMLFrameSetElement::setOnstorage): Ditto.
(WebCore::HTMLFrameSetElement::setOnunload): Ditto.
LayoutTests: Setting attribute event listeners to the body does not set them on the window
https://bugs.webkit.org/show_bug.cgi?id=28343
Reviewed by Dan Bernstein.
- fast/dom/Window/HTMLBodyElement-window-eventListener-attributes-expected.txt: Added.
- fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html: Added.
- fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes-expected.txt: Added.
- fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html: Added.
- fast/dom/Window/resources/HTMLBodyElement-window-eventListener-attributes.js: Added.
- fast/dom/Window/resources/HTMLFrameSetElement-window-eventListener-attributes.js: Added.
- 2:35 PM Changeset in webkit [47325] by
-
- 3 edits in trunk/WebCore
Fix up some IDL comments.
Reviewed by Dan Bernstein.
- html/HTMLBodyElement.idl:
- html/HTMLFrameSetElement.idl:
- 2:25 PM Changeset in webkit [47324] by
-
- 2 edits in trunk
[GTK] Added EventSource to the build (default on).
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.
- configure.ac:
- 2:04 PM Changeset in webkit [47323] by
-
- 27 edits31 adds in trunk
JavaScriptCore: Added ENABLE_EVENTSOURCE flag.
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.
- Configurations/FeatureDefines.xcconfig:
WebCore: Added implementation of the EventSource object that enables
server-sent events from HTML5.
http://dev.w3.org/html5/eventsource/
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.
Tests: fast/eventsource/eventsource-attribute-listeners.html
fast/eventsource/eventsource-constructor.html
http/tests/eventsource/eventsource-bad-mime-type.html
http/tests/eventsource/eventsource-parse-event-stream.html
http/tests/eventsource/eventsource-reconnect.html
http/tests/eventsource/eventsource-status-code-states.html
http/tests/eventsource/workers/eventsource-simple.html
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::eventSource):
- bindings/js/JSEventSourceConstructor.cpp: Added.
(WebCore::):
(WebCore::JSEventSourceConstructor::JSEventSourceConstructor):
(WebCore::constructEventSource):
(WebCore::JSEventSourceConstructor::getConstructData):
- bindings/js/JSEventSourceConstructor.h: Added.
(WebCore::JSEventSourceConstructor::classInfo):
- bindings/js/JSEventSourceCustom.cpp: Added.
(WebCore::JSEventSource::markChildren):
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
(WebCore::toEventTarget):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::eventSource):
- dom/EventNames.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::toEventSource):
- dom/EventTarget.h:
- page/DOMWindow.idl:
- page/EventSource.cpp: Added.
(WebCore::EventSource::EventSource):
(WebCore::EventSource::~EventSource):
(WebCore::EventSource::connect):
(WebCore::EventSource::endRequest):
(WebCore::EventSource::scheduleReconnect):
(WebCore::EventSource::reconnectTimerFired):
(WebCore::EventSource::url):
(WebCore::EventSource::readyState):
(WebCore::EventSource::close):
(WebCore::EventSource::scriptExecutionContext):
(WebCore::EventSource::addEventListener):
(WebCore::EventSource::removeEventListener):
(WebCore::EventSource::dispatchEvent):
(WebCore::EventSource::didReceiveResponse):
(WebCore::EventSource::didReceiveData):
(WebCore::EventSource::didFinishLoading):
(WebCore::EventSource::didFail):
(WebCore::EventSource::didFailRedirectCheck):
(WebCore::EventSource::parseEventStream):
(WebCore::EventSource::parseEventStreamLine):
(WebCore::EventSource::dispatchGenericEvent):
(WebCore::EventSource::dispatchMessageEvent):
(WebCore::EventSource::stop):
- page/EventSource.h: Added.
(WebCore::EventSource::create):
(WebCore::EventSource::):
(WebCore::EventSource::setOnopen):
(WebCore::EventSource::onopen):
(WebCore::EventSource::setOnmessage):
(WebCore::EventSource::onmessage):
(WebCore::EventSource::setOnerror):
(WebCore::EventSource::onerror):
(WebCore::EventSource::toEventSource):
(WebCore::EventSource::eventListeners):
(WebCore::EventSource::refEventTarget):
(WebCore::EventSource::derefEventTarget):
- page/EventSource.idl: Added.
- workers/WorkerContext.idl:
WebKit/mac: Added ENABLE_EVENTSOURCE flag.
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.
- Configurations/FeatureDefines.xcconfig:
WebKitTools: Added EventSource to the build script (default on).
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.
- Scripts/build-webkit:
LayoutTests: Tests for EventSource.
https://bugs.webkit.org/show_bug.cgi?id=14997
Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.
- fast/eventsource: Added.
- fast/eventsource/eventsource-attribute-listeners-expected.txt: Added.
- fast/eventsource/eventsource-attribute-listeners.html: Added.
- fast/eventsource/eventsource-constructor-expected.txt: Added.
- fast/eventsource/eventsource-constructor.html: Added.
- http/tests/eventsource: Added.
- http/tests/eventsource/eventsource-bad-mime-type-expected.txt: Added.
- http/tests/eventsource/eventsource-bad-mime-type.html: Added.
- http/tests/eventsource/eventsource-parse-event-stream-expected.txt: Added.
- http/tests/eventsource/eventsource-parse-event-stream.html: Added.
- http/tests/eventsource/eventsource-reconnect-expected.txt: Added.
- http/tests/eventsource/eventsource-reconnect.html: Added.
- http/tests/eventsource/eventsource-status-code-states-expected.txt: Added.
- http/tests/eventsource/eventsource-status-code-states.html: Added.
- http/tests/eventsource/resources: Added.
- http/tests/eventsource/resources/bad-mime-type.asis: Added.
- http/tests/eventsource/resources/event-stream.php: Added.
- http/tests/eventsource/resources/reconnect.php: Added.
- http/tests/eventsource/resources/simple-event-stream.asis: Added.
- http/tests/eventsource/resources/status-codes.php: Added.
- http/tests/eventsource/workers: Added.
- http/tests/eventsource/workers/eventsource-simple-expected.txt: Added.
- http/tests/eventsource/workers/eventsource-simple.html: Added.
- http/tests/eventsource/workers/resources: Added.
- http/tests/eventsource/workers/resources/simple-worker.js: Added.
(es.onmessage):
(es.onerror):
- 1:53 PM Changeset in webkit [47322] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Xan Lopez.
Fix compiler warnings.
- webkit/webkitwebview.cpp: (clipboard_contents_received): (webkit_web_view_drag_data_get):
- 11:30 AM Changeset in webkit [47321] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-15
Add myself to list of committers.
- Scripts/modules/committers.py:
- 4:25 AM Changeset in webkit [47320] by
-
- 12 edits in trunk/WebKitTools
WebKitTools: Fix layout test failures after r47312.
Reviewed by Cameron Zwarich.
- DumpRenderTree/AccessibilityController.h:
Replaced logFocusEvents() with setLogFocusEvents(), which takes a
boolean argument to turn logging of focus events on or off.
Added a function to reset the AccessibilityController to a consistent
state.
- DumpRenderTree/AccessibilityController.cpp:
(logFocusEventsCallback):
Call setLogFocusEvents() to enable logging.
(AccessibilityController::resetToConsistentState):
Call setLogFocusEvents() to disable logging.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::setLogFocusEvents):
Update stub.
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::setLogFocusEvents):
Update stub.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
Call the FrameLoadDelegate's resetToConsistentState method.
- DumpRenderTree/mac/FrameLoadDelegate.h:
Declare the resetToConsistentState method.
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate resetToConsistentState]):
Call the AccessibilityController's resetToConsistentState() function.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::~AccessibilityController):
Turn off focus event logging when the controller is destroyed.
(AccessibilityController::setLogFocusEvents):
If the caller passes false, unhook the focus event, and clear
m_focusEventHook.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
Call the FrameLoadDelegate's resetToConsistentState function.
- DumpRenderTree/win/FrameLoadDelegate.h:
Declare the resetToConsistentState() function.
- DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::resetToConsistentState):
Call the AccessibilityController's resetToConsistentState() function.
- 2:02 AM Changeset in webkit [47319] by
-
- 4 edits in trunk/WebCore
2009-08-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Minor DOMAgent bugfixes.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::nodeForId):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
- 1:56 AM Changeset in webkit [47318] by
-
- 3 edits in trunk/WebCore
2009-08-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Evaluating objects while on a breakpoint dumps string
representation instead of live object.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.this._evalInInspectedWindow): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame.delayedEvaluation): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame): (WebInspector.ScriptsPanel.prototype.variablesInSelectedCallFrame):
- 12:31 AM Changeset in webkit [47317] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-15 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding two new files to WebCore/platform/haiku:
LocalizedStringsHaiku.cpp and LoggingHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28129
- platform/haiku/LocalizedStringsHaiku.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::imageTitle): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::AXButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText):
- platform/haiku/LoggingHaiku.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):
- 12:27 AM Changeset in webkit [47316] by
-
- 2 edits in trunk/WebCore
Fix GTK build.
Patch by Darin Adler <Darin Adler> on 2009-08-15
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(fallbackObject): Pass 0 for document. Should be OK at least for now.
- 12:09 AM Changeset in webkit [47315] by
-
- 2 edits in trunk/WebCore
Fix Qt build.
Patch by Darin Adler <Darin Adler> on 2009-08-15
- dom/XMLTokenizerQt.cpp: Use create functions instead of calling new
directly to make CDATASection and Comment nodes.
