⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 17, 2009:

11:35 PM Changeset in webkit [47419] by eric@webkit.org
  • 8 edits in trunk

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Some HTMLs are modified by make-script-test-wrappers
​https://bugs.webkit.org/show_bug.cgi?id=28213

Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
re-generated wml/* and Geolocation/* .

  • fast/dom/Geolocation/enabled.html:
  • fast/dom/Geolocation/resources/TEMPLATE.html:
  • http/tests/wml/access-target-domain-deny.html:
  • http/tests/wml/access-target-path-deny.html:
  • http/tests/wml/access-target.html:

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Some HTMLs are modified by make-script-test-wrappers
​https://bugs.webkit.org/show_bug.cgi?id=28213

Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
re-generated wml/* and Geolocation/* .

  • Scripts/make-script-test-wrappers:
11:26 PM Changeset in webkit [47418] by eric@webkit.org
  • 8 edits
    3 adds in trunk

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

-webkit-box-orient:horizontal doesn't work on <button> tag
​https://bugs.webkit.org/show_bug.cgi?id=34445

Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.

Also, added a renderName for anonymous flexible boxes.

  • fast/flexbox/box-orient-button-expected.txt: Added.
  • fast/flexbox/box-orient-button.html: Added.
  • fast/flexbox/resources/box-orient-button.js: Added. (setBoxOrient): (gebi):

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

-webkit-box-orient:horizontal doesn't work on <button> tag
​https://bugs.webkit.org/show_bug.cgi?id=34445

Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.

Also, added a renderName for anonymous flexible boxes.

Test: fast/flexbox/box-orient-button.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::createAnonymousBlock):
  • rendering/RenderBlock.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::addChild): (WebCore::RenderButton::setupInnerStyle):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::renderName):

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

-webkit-box-orient:horizontal doesn't work on <button> tag
​https://bugs.webkit.org/show_bug.cgi?id=34445

Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.

Also, added a renderName for anonymous flexible boxes.

  • Scripts/make-script-test-wrappers:
11:20 PM Changeset in webkit [47417] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.pri

add THE CORRECT new file to lunix builds (you idiot).

11:08 PM Changeset in webkit [47416] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

add new file to lunix builds.

10:56 PM Changeset in webkit [47415] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/runtime/Executable.cpp

speculative interpretoid build fixeration.

10:49 PM Changeset in webkit [47414] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore

speculative 'doze build fixeration II.

10:42 PM Changeset in webkit [47413] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/runtime/Collector.cpp

speculative 'doze build fixeration.

10:34 PM Changeset in webkit [47412] by barraclough@apple.com
  • 41 edits
    1 add in trunk/JavaScriptCore

No, silly runtime, AST nodes are not for you.

Reviewed by Sam Weinig.

We still use AST nodes (ScopeNodes, particularly FunctionBodyNodes) within
the runtime, which means that these nodes must be persisted outside of the
arena, contain both parser & runtime data, etc. This is all a bit of a mess.

Move functionality into a new FunctionExecutable class.

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::markAggregate):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::discardBytecode):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::CodeBlock::ownerExecutable):
(JSC::CodeBlock::extractExceptionInfo):
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::functionDecl):
(JSC::CodeBlock::numberOfFunctionDecls):
(JSC::CodeBlock::addFunctionExpr):
(JSC::CodeBlock::functionExpr):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):

  • bytecode/EvalCodeCache.h:
  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::doRun):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):

  • bytecompiler/BytecodeGenerator.h:
  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):

  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

  • interpreter/CallFrameClosure.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::debug):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_func_exp):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC::):

  • parser/Nodes.cpp:

(JSC::FunctionBodyNode::reparseDataIfNecessary):

  • parser/Nodes.h:

(JSC::EvalNode::partialDestroyData):

  • parser/Parser.h:
  • profiler/ProfileGenerator.cpp:
  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):

  • runtime/Arguments.h:

(JSC::Arguments::getArgumentsData):
(JSC::Arguments::Arguments):
(JSC::JSActivation::copyRegisters):

  • runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):

  • runtime/CallData.h:

(JSC::):

  • runtime/Collector.cpp:

(JSC::Heap::collect):

  • runtime/ConstructData.h:

(JSC::):

  • runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • runtime/Executable.cpp: Added.

(JSC::EvalExecutable::generateBytecode):
(JSC::ProgramExecutable::generateBytecode):
(JSC::FunctionExecutable::generateBytecode):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::isHostFunction):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::FunctionExecutable):

  • runtime/Executable.h:

(JSC::ExecutableBase::~ExecutableBase):
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::source):
(JSC::ExecutableBase::sourceID):
(JSC::ExecutableBase::lastLine):
(JSC::ExecutableBase::usesEval):
(JSC::ExecutableBase::usesArguments):
(JSC::ExecutableBase::needsActivation):
(JSC::ExecutableBase::astNode):
(JSC::ExecutableBase::generatedJITCode):
(JSC::ExecutableBase::getExecutablePool):
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::varStack):
(JSC::EvalExecutable::evalNode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::programNode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::generatedBytecode):
(JSC::FunctionExecutable::usesEval):
(JSC::FunctionExecutable::usesArguments):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::paramString):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::body):
(JSC::FunctionExecutable::jitCode):
(JSC::FunctionExecutable::createNativeThunk):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):
(JSC::JSActivation::markChildren):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::argumentsGetter):

  • runtime/JSActivation.h:

(JSC::JSActivation::JSActivationData::JSActivationData):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::isHostFunction):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):

  • runtime/JSFunction.h:

(JSC::JSFunction::executable):
(JSC::FunctionExecutable::make):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::numericCompareFunction):

  • runtime/JSGlobalData.h:
10:12 PM Changeset in webkit [47411] by mrowe@apple.com
  • 1 edit
    1 delete in trunk

Revert r47399 as Eric landed it in the wrong directory.

8:57 PM Changeset in webkit [47410] by Simon Fraser
  • 15 edits
    12 adds in trunk

2009-08-17 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Render -webkit-mask via compositing layers when possible
​https://bugs.webkit.org/show_bug.cgi?id=28414

Implement accelerated compositing of -webkit-mask, when combined
with already-composited content.

RenderLayerBacking now creates an additional GraphicsLayer for the mask contents,
and sets this as the mask on another GraphicsLayer via the setMaskLayer() method.
GraphicsLayerCA then applies the mask using -[CALayer setMask:].

The enum values for GraphicsLayerPaintingPhase were renamed to avoid the
confusion with "mask", and a new value, GraphicsLayerPaintMask, was added which
indicates that just the mask is painting.

When painting the composited mask, we need to paint with the normal compositing
mode rather than CompositeDestinationIn, so InlineFlowBox and RenderBox now consult
layer()->hasCompositedMask() to pick the mode. If the mask is composited, they no longer
need to make transparency layers.

We no longer have to throw video rendering into software because of masks.

When a masked element has composited descendants, that element needs to
become composited so that the mask can be applied via compositing.

Tests: compositing/masks/masked-ancestor.html

compositing/masks/simple-composited-mask.html

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer):
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::maskLayer): (WebCore::GraphicsLayer::setMaskLayer): (WebCore::GraphicsLayer::paintingPhase): (WebCore::GraphicsLayer::setPaintingPhase):
  • platform/graphics/GraphicsLayerClient.h: (WebCore::):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setMaskLayer): (WebCore::GraphicsLayerCA::recursiveCommitChanges): (WebCore::GraphicsLayerCA::commitLayerChanges): (WebCore::GraphicsLayerCA::updateMaskLayer):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hasCompositedMask):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasCompositedMask):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::destroyGraphicsLayer): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::updateMaskLayer): (WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer): (WebCore::RenderLayerBacking::setContentsNeedDisplay): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
  • rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::hasMaskLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::canAccelerateVideoRendering): (WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing):
  • rendering/RenderLayerCompositor.h:
8:31 PM Changeset in webkit [47409] by Simon Fraser
  • 5 edits
    4 adds in trunk

2009-08-17 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Layer content misplaced with compositing, z-index and overflow
​https://bugs.webkit.org/show_bug.cgi?id=28361

The foreground GraphicsLayer (used to render element foreground when the element has
negative z-order children) was misplaced when there is a clipping layer (which clips
children). The foreground layer is parented under the clipping layer so that the foreground
depth-sorts with the layer's children, so its geometry needs to be computed relative to
that clipping layer.

Also clarified some FIXME comments, and corrected a debug-only layer name.

Test: compositing/geometry/clipping-foreground.html

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateSublayerList):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateForegroundLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
7:58 PM Changeset in webkit [47408] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Fix leaks of SVGElementInstance seen during regression tests.

Reviewed by Sam Weinig.

r47313 made TreeShared types start with a ref-count of 1, but SVGElementInstance was mistakenly
not updated to have a create method that adopted the initial reference. This lead to the instances
of SVGElementInstance allocated by SVGUseElement being leaked.

  • svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::create):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::handleDeepUseReferencing):

6:37 PM Changeset in webkit [47407] by beidson@apple.com
  • 6 edits in trunk/WebCore

Some cleanup towards ​https://bugs.webkit.org/show_bug.cgi?id=13631
Page Cache should support pages with frames.

Reviewed by Sam Weinig.

  • Re-factor all remaining page cache code out of DocumentLoader, as CachedPage/CacheFrame loads are solely the responsibility of FrameLoader.
  • Enhance some page cache related Logging to help development.
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::identifierForInitialRequest):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::isLoadingFromCachedPage):

6:18 PM Changeset in webkit [47406] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-17 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Adele Peterson.

http/tests/misc/favicon-loads-with-images-disabled.html was passing on my machine
(when I ran all http tests), but failed on the bot, so adding it back to the
Skipped list.

  • platform/win/Skipped:
6:05 PM Changeset in webkit [47405] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

Fix 300,000+ leaks seen during the regression tests.

Reviewed by Darin Adler.

EvalCodeCache::get was heap-allocating an EvalExecutable instance without adopting the initial reference.
While fixing this we noticed that EvalExecutable was a RefCounted type that was sometimes stack allocated.
To make this cleaner and to prevent clients from attempting to ref a stack-allocated instance, we move the
refcounting down to a new CacheableEvalExecutable class that derives from EvalExecutable. EvalCodeCache::get
now uses CacheableEvalExecutable::create and avoids the leak.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):

  • runtime/Executable.h:

(JSC::CacheableEvalExecutable::create):
(JSC::CacheableEvalExecutable::CacheableEvalExecutable):

6:00 PM Changeset in webkit [47404] by oliver@apple.com
  • 10 edits in trunk

REGRESSION (r47292): Prototype.js is broken by ES5 Arguments changes
​https://bugs.webkit.org/show_bug.cgi?id=28341
<rdar://problem/7145615>

RS=Mark Rowe

Reverting r47292. Alas Prototype.js breaks with Arguments inheriting
from Array as ES5 attempted. Prototype.js defines $A in terms of a
function it places on (among other global objects) the Array prototype,
thus breaking $A for arrays.

5:58 PM Changeset in webkit [47403] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-08-17 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Eric Seidel.

Moved implementation of isAfterContent to RenderObject
(as inline method to avoid potential performance regressions).

BUG 28376 - [Cleanup] isAfterContent() implemented twice, should be member of RenderObject
(​https://bugs.webkit.org/show_bug.cgi?id=28376)

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:
  • rendering/RenderObject.h: (WebCore::RenderObject::isAfterContent):
5:49 PM Changeset in webkit [47402] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-17 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Can no longer --reset-results of a layout test directory
​https://bugs.webkit.org/show_bug.cgi?id=28336

--reset-results and --exit-after-n-failures are incompatible.

  • Scripts/run-webkit-tests:
5:40 PM Changeset in webkit [47401] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-17 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Adele Peterson.

http/tests/misc/favicon-loads-with-images-disabled.html is passing on my
machine, trying to remove it from the Skipped list on Windows.

  • platform/win/Skipped:
5:24 PM Changeset in webkit [47400] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Assertion failure in WebCore::RenderHTMLCanvas::layout
​https://bugs.webkit.org/show_bug.cgi?id=12052

Don't handle run-in if the element is not a block element.

  • fast/runin/canvas-runin-expected.txt: Added.
  • fast/runin/canvas-runin.html: Added.

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Assertion failure in WebCore::RenderHTMLCanvas::layout
​https://bugs.webkit.org/show_bug.cgi?id=12052

Don't handle run-in if the element is not a block element.

Test: fast/runin/nonblock-runin.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
5:16 PM Changeset in webkit [47399] by eric@webkit.org
  • 1 edit
    6 adds in trunk

2009-08-17 Christian Plesner Hansen <​christian.plesner.hansen@gmail.com>

Reviewed by Darin Adler.

Regression test for bug fixed in
​http://codereview.chromium.org/171039. Regexps created in one
frame were not callable outside that frame.
​https://bugs.webkit.org/show_bug.cgi?id=28387

  • fast/regex/regexp-cross-frame-callable-expected.txt: Added.
  • fast/regex/regexp-cross-frame-callable.html: Added.
  • fast/regex/resources/regexp-cross-frame-callable-child.html: Added.
5:05 PM Changeset in webkit [47398] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2009-08-17 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Darin Adler.

Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
either of the arguments are not finite.

According to
​http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
"If any of the arguments to createImageData() or getImageData() are
infinite or NaN, or if the createImageData() method is invoked with
only one argument but that argument is null, the method must instead
raise a NOT_SUPPORTED_ERR exception."

Test: ​http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html

  • fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt: Added.
  • fast/canvas/canvas-2d-imageData-create-nonfinite.html: Added.
  • fast/canvas/resources/canvas-2d-imageData-create-nonfinite.js: Added.

2009-08-17 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Darin Adler.

Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
either of the arguments are not finite.

According to
​http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
"If any of the arguments to createImageData() or getImageData() are
infinite or NaN, or if the createImageData() method is invoked with
only one argument but that argument is null, the method must instead
raise a NOT_SUPPORTED_ERR exception."

Test: ​http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
4:28 PM Changeset in webkit [47397] by jorlow@chromium.org
  • 11 edits in trunk

2009-08-17 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Add a way to release the storage lock
​https://bugs.webkit.org/show_bug.cgi?id=28411

Two scripts within the same origin that are accessing LocalStorage must not do
it simultaneously, according to the spec. There are some cases, however, where
a script might want to override this behavior. navigator.getStorageUpdates()
was added for this reason:
​http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex

Add this function to navigator and hook it up to DOM Storage.

  • page/Navigator.cpp: (WebCore::Navigator::getStorageUpdates):
  • page/Navigator.h:
  • page/Navigator.idl:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::unlock):
  • storage/StorageNamespaceImpl.h:

2009-08-17 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Add a way to release the storage lock
​https://bugs.webkit.org/show_bug.cgi?id=28411

Two scripts within the same origin that are accessing LocalStorage must not do
it simultaneously, according to the spec. There are some cases, however, where
a script might want to override this behavior. navigator.getStorageUpdates()
was added for this reason:
​http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex

Update the test expectations to include this new element.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:
4:11 PM Changeset in webkit [47396] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Build fix.

CFNetwork isn't present in the framework search path on Mac OS X so we can't directly include its headers.
We include CoreServices.h, the umbrella framework that contains CFNetwork, from the prefix header which
results in the CFNetwork headers being included on Mac OS X. CoreServices.h doesn't include CFNetwork.h on
Windows though so we explicitly include this header from the prefix header when on Windows.

  • WebCorePrefix.h:
  • platform/network/cf/DNSCFNet.cpp: Remove #include that is no longer needed.
3:48 PM Changeset in webkit [47395] by ap@apple.com
  • 2 edits in trunk/WebCore

Trying a better build fix (the previous one broke Leopard bots, although it did build for me).

  • platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFNetwork.h instead.
3:30 PM Changeset in webkit [47394] by ap@apple.com
  • 2 edits in trunk/WebCore

Trying to fix Windows build.

  • platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFHost.h.
3:17 PM Changeset in webkit [47393] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git

Reviewed by Adam Roben.

New commit message:

Committed r12345: <​http://trac.webkit.org/changeset/12345>

  • Scripts/bugzilla-tool: (bug_comment_from_commit_text): Print out a compact, standardized commit message for both git and svn.
3:12 PM Changeset in webkit [47392] by pkasting@chromium.org
  • 19 edits in trunk

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win: ​https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesGenerated.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools: ​https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3:08 PM Changeset in webkit [47391] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=28401
Add support for DNS prefetching with CFNetwork

This is just an optimization, no behavior change, so no tests.

  • platform/network/cf/DNSCFNet.cpp: (WebCore::clientCallback): (WebCore::prefetchDNS): Use async CFHostStartInfoResolution() for implementation.
2:48 PM Changeset in webkit [47390] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Skip new tests.

  • platform/gtk/Skipped:
2:14 PM Changeset in webkit [47389] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=28403
Update Apache2 module list from Leopard defaults

No change in functionality, only commented out modules needed an update.

  • http/conf/apache2-httpd.conf:
1:54 PM WikiStart edited by Dimitri Glazkov
Linked to Chromium port page (diff)
1:43 PM Changeset in webkit [47388] by eric@webkit.org
  • 11 edits
    2 adds in trunk

2009-08-17 Aaron Boodman <​aa@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.

Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented redirects
for access control, so we should never redirect across origins. But in two edge cases, we were:

  • Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to a resource on origin A.
  • Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to another resource on origin B (this time sending access control authorization headers).
  • http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-and-redirects.html: Added.

2009-08-17 Aaron Boodman <​aa@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.

Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented
redirects access control, so we should never redirect across origins. But in two edge cases, we were:

  • Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to a resource on origin A.
  • Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to another resource on origin B (this time sending access control authorization headers).

Test: http/tests/xmlhttprequest/access-control-and-redirects.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): Refactor redirect checking code into shared location. (WebCore::DocumentThreadableLoader::loadRequest): Ditto. (WebCore::DocumentThreadableLoader::isAllowedRedirect): Ditto.
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Remove ThreadableLoaderOptions::crossOriginRedirectPolicy.
  • page/EventSource.cpp: (WebCore::EventSource::connect): Ditto.
  • workers/Worker.cpp: Ditto. (WebCore::Worker::Worker): Ditto.
  • workers/WorkerContext.cpp: Ditto. (WebCore::WorkerContext::importScripts): Ditto.
  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): Ditto. (WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.
  • workers/WorkerScriptLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): Ditto.
1:41 PM Changeset in webkit [47387] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Try to fix Qt build again.

Patch by Darin Adler <Darin Adler> on 2009-08-17

  • WebCoreSupport/EditorClientQt.cpp: Move "using namespace".
1:36 PM Changeset in webkit [47386] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-08-17 Adam Langley <​agl@google.com>

Reviewed by Dan Bernstein (relanding of r47157).

Fix a typo in platform/graphics/skia/PlatformContextSkia.cpp

​https://bugs.webkit.org/show_bug.cgi?id=28172

This was originally fixed in r47157, however it triggered a bug in
Skia which caused Chromium Linux to fail layout tests in debug mode.
It was reverted in r47189 while we sorted it out.

The Skia bug was fixed in Skia's r321 [1] and rolled into Chromium in
Chromium's r23523. This is a reland of the original patch.

No new tests because it's a just typo fix.

[1] ​http://code.google.com/p/skia/source/detail?r=321

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
1:33 PM Changeset in webkit [47385] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<​http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()

Reviewed by David Levin.

  • Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'. (check_max_min_macros): Added. Returns level 4 error when MAX() and MIN() macros are used in header files and C++ source files. (check_style): Added call to check_max_min_macros().
  • Scripts/modules/cpp_style_unittest.py: Added unit tests. (test_max_macro): Added. (test_min_macro): Added.
1:29 PM Changeset in webkit [47384] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-08-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Protect ResourceHandle for g_file_query_info_async call, using the
same technique we already use for HTTP requests that take the soup
path.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::finishedCallback): (WebCore::):
1:21 PM Changeset in webkit [47383] by mitz@apple.com
  • 2 edits in trunk/WebCore

REGRESSION (r47255): MediaWiki's (including Wikipedia) navigation pane
appears below the main content
​https://bugs.webkit.org/show_bug.cgi?id=28350

Reviewed by Darin Adler.

A particular version of the MediaWiki software detects WebKit through
user agent sniffing and imports a style sheet called KHTMLFixes.css,
which contains a single rule that was meant to work around some KHTML
bug, but currently has the sole effect of causing the float containing
the main article content to extend all the way to the left and thus push
down the left navigation pane.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet): If site specific hacks are
enabled, check if the imported style sheet is the MediaWiki
KHTMLFixes.css. If so, remove the offending rule.

1:20 PM Changeset in webkit [47382] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-17 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix build with FAST_MALLOC_MATCH_VALIDATION enabled.

  • wtf/FastMalloc.cpp: (WTF::fastMalloc): (WTF::fastCalloc): (WTF::fastRealloc):
1:11 PM Changeset in webkit [47381] by yong.li@torchmobile.com
  • 5 edits
    1 add in trunk/WebCore/platform

2009-08-17 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Treat.

Allow image decoders to down-sample the image directly
to scaled output buffer. This can be enabled/disabled by
macro ENABLE(IMAGE_DECODER_DOWN_SAMPLING).
Only JPEG and PNG decoders are modified to support it now.
​https://bugs.webkit.org/show_bug.cgi?id=28308

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
  • platform/image-decoders/ImageDecoder.cpp: Added.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::setMaxNumPixels):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setSize):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
12:56 PM Changeset in webkit [47380] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Try to fix Qt build.

Patch by Darin Adler <Darin Adler> on 2009-08-17

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::shouldShowDeleteInterface):
Use getAttribute(classAttr) instead of className() function.

12:47 PM Changeset in webkit [47379] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Correct crash when processing local cancelled requests.

Reviewed by Kevin Ollivier.

No new tests. Existing fast/images/favicon-as-image.html
displays the problem.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::writeCallback): Add check for m_cancelled after

performing local-file processing.

(WebCore::ResourceHandleManager::downloadTimerCallback): Add

check for m_cancelled after performing local-file processing.

12:27 PM Changeset in webkit [47378] by kov@webkit.org
  • 6 edits
    1 delete in trunk/WebCore

2009-08-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Reverts 47371, since it breaks GTK+.

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
  • platform/image-decoders/ImageDecoder.cpp: Removed.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
12:07 PM Changeset in webkit [47377] by sfalken@apple.com
  • 1 copy in tags/Safari-6531.11

New tag.

12:04 PM Changeset in webkit [47376] by Simon Fraser
  • 2 edits in trunk/WebKit/win

2009-08-17 Simon Fraser <Simon Fraser>

Speculative fix for Windows build bustage.

  • DOMHTMLClasses.cpp: (DOMHTMLElement::idName):
12:00 PM Changeset in webkit [47375] by sfalken@apple.com
  • 11 edits in branches/safari-4-branch/WebKitTools

Merge r47320.

11:51 AM Changeset in webkit [47374] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-08-17 Simon Fraser <Simon Fraser>

Build fix: fix float literals to avoid casting warnings.

  • rendering/MediaControlElements.cpp:
11:50 AM Changeset in webkit [47373] by sfalken@apple.com
  • 7 edits
    2 copies in branches/safari-4-branch

Merge r47312.

11:43 AM Changeset in webkit [47372] by sfalken@apple.com
  • 9 edits in branches/safari-4-branch

Merge r47311.

11:37 AM Changeset in webkit [47371] by yong.li@torchmobile.com
  • 6 edits
    1 add in trunk/WebCore

2009-08-17 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Treat.

Allow image decoders to down-sample the image directly
to scaled output buffer. This can be enabled/disabled by
macro ENABLE(IMAGE_DECODER_DOWN_SAMPLING).
Only JPEG and PNG decoders are modified to support it now.
​https://bugs.webkit.org/show_bug.cgi?id=28308

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
  • platform/image-decoders/ImageDecoder.cpp: Added.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::setMaxNumPixels):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setSize):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
11:29 AM Changeset in webkit [47370] by Simon Fraser
  • 7 edits in trunk/WebCore

2009-08-17 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

Use OwnPtrs for GraphicsLayers
​https://bugs.webkit.org/show_bug.cgi?id=28399

Convert RenderLayerBacking and RenderLayerCompositor to use OwnPtrs
for their references to GraphicsLayers.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayer::create):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::destroyGraphicsLayer): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateInternalHierarchy): (WebCore::RenderLayerBacking::updateClippingLayers): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
  • rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::graphicsLayer): (WebCore::RenderLayerBacking::clippingLayer): (WebCore::RenderLayerBacking::ancestorClippingLayer): (WebCore::RenderLayerBacking::foregroundLayer): (WebCore::RenderLayerBacking::parentForSublayers): (WebCore::RenderLayerBacking::childForSuperlayers):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::~RenderLayerCompositor): (WebCore::RenderLayerCompositor::rootPlatformLayer): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): (WebCore::RenderLayerCompositor::destroyRootPlatformLayer):
  • rendering/RenderLayerCompositor.h:
10:44 AM Changeset in webkit [47369] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2009-08-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Reset InjectedScript styles cache on document change.

​https://bugs.webkit.org/show_bug.cgi?id=28390

  • inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::resetInjectedScript):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/InjectedScript.js: (InjectedScript._reset):
10:41 AM Changeset in webkit [47368] by Darin Adler
  • 2 edits in trunk/WebCore
  • rendering/MediaControlElements.cpp: Removed unneeded include of CString.h,

resorted includes, renamed "doc" to "document" and fixed formatting.

Reviewed by Sam Weinig.

10:30 AM Changeset in webkit [47367] by Darin Adler
  • 12 edits in trunk/WebCore

Removed functions now unneeded due to use of Reflect to create
language bindings.

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
Get at usemap attribute directly.

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):
Get at id attribute directly.

  • editing/EditorCommand.cpp:

(WebCore::executeInsertHorizontalRule): Ditto.

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir): Get at dir attribute of body directly.
(WebCore::HTMLDocument::setDir): Ditto.

  • html/HTMLElement.cpp: Deleted unused functions.
  • html/HTMLElement.h: Ditto.
  • html/HTMLImageElement.cpp: Deleted unused functions.

(WebCore::HTMLImageElement::alt): Changed to return const AtomicString&.
(WebCore::HTMLImageElement::addSubresourceAttributeURLs): Changed to
get at usemap attribute directly, but added a FIXME because although
it is what the old code did, it looks to not be entirely correct.

  • html/HTMLImageElement.h: Deleted unused functions.
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString): Get at alt attribute directly.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageMap): Get at usemap attribute directly.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createGraphicsLayer): Get at id attribute
directly.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Removed
explicit HTMLNames namespace qualification.

10:12 AM Changeset in webkit [47366] by Darin Adler
  • 2 edits in trunk/WebKit/mac

Use a HashMap instead of a list of if statements for the command
name exception map.

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.

  • WebView/WebHTMLView.mm:

(createSelectorExceptionMap): Added.
(commandNameForSelector): Use createSelectorExceptionMap.

10:03 AM Changeset in webkit [47365] by Darin Adler
  • 2 edits in trunk/WebCore
  • dom/Document.cpp:

(WebCore::Document::setFocusedNode): Removed unneeded calls
to RefPtr::get.

Reviewed by Sam Weinig.

9:24 AM Changeset in webkit [47364] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-08-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Discard DOM Node bindings on any document change.

​https://bugs.webkit.org/show_bug.cgi?id=28389

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
8:57 AM Changeset in webkit [47363] by ariya@webkit.org
  • 23 edits
    1 delete in trunk/WebCore

2009-08-13 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Improve Cookie DataGrid to Show Hidden Data
​https://bugs.webkit.org/show_bug.cgi?id=28269

  • English.lproj/localizedStrings.js: DataGrid Headers "Name", "Value", "Size", ...
  • WebCore.gypi: added missing files

Implemented Bindings for InspectorController.deleteCookie(name)

  • inspector/InspectorBackend.idl:
  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies): (WebCore::JSInspectorBackend::deleteCookie):

v8 Bindings Stubs

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

Removed WebInspector.Cookie

  • inspector/front-end/Cookie.js: Removed.
  • inspector/front-end/inspector.html:
  • inspector/front-end/WebKit.qrc:

Improved DataGrid and Kept Fallback Behavior for Platforms that don't
yet provide access to raw cookies.

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.buildCookies): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype.fallbackUpdate.callback): (WebInspector.CookieItemsView.prototype.fallbackUpdate): (WebInspector.CookieItemsView.prototype.fallbackBuildCookiesFromString): (WebInspector.CookieItemsView.prototype.fallbackDataGridForCookies): (WebInspector.CookieItemsView.prototype._deleteButtonClicked):

Interaction with the page through Injected Script (for fallback behavior)

  • inspector/front-end/DOMAgent.js: (InspectorController.getCookies):
  • inspector/front-end/InjectedScript.js: (InjectedScript.setStyleProperty): style fix (InjectedScript.getCookies):

Allow alignment of text inside DataGrids.

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGridNode.prototype.createCell):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
  • inspector/front-end/inspector.css:

Added deleteCookie(., ., String name)
Modified getRawCookies to return a bool to know if its implemented

  • platform/CookieJar.h:

Implemented deleteCookie for Macs

  • platform/mac/CookieJar.mm: (WebCore::getRawCookies): (WebCore::deleteCookie):

Stub Implementations for Other Platforms

  • platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
8:37 AM Changeset in webkit [47362] by treat@webkit.org
  • 2 edits in trunk/WebCore

Blind build fix for Leopard.

Patch by Adam Treat <​adam.treat@torchmobile.com> on 2009-08-17

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::adjustLineToPixelBoundaries):

8:07 AM Changeset in webkit [47361] by treat@webkit.org
  • 5 edits in trunk

Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.

Patch by Mike Fenton <​mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=28268

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::adjustLineToPixelBoundaries):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
7:19 AM Changeset in webkit [47360] by treat@webkit.org
  • 2 edits in trunk/WebCore

Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContextCG.cpp

Patch by Mike Fenton <​mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=28268

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipOutEllipseInRect):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setCompositeOperation):

7:01 AM Changeset in webkit [47359] by treat@webkit.org
  • 5 edits in trunk/WebCore

Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContext.cpp/h, GraphicsContextCairo.cpp and GraphicsContextQt.cpp.

Patch by Mike Fenton <​mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=28268

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(GraphicsContext::drawText):
(GraphicsContext::initFocusRing):
(GraphicsContext::focusRingBoundingRect):
(GraphicsContext::drawImage):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::toCairoOperator):

  • platform/graphics/qt/GraphicsContextQt.cpp:
6:51 AM Changeset in webkit [47358] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
WebKit style guide.

Patch by Mike Fenton <​mike.fenton@torchmobile.com> on 2009-08-10
Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=28161

  • DumpRenderTree/qt/jsobjects.cpp:

(findFrameNamed):
(LoadItem::invoke):
(LayoutTestController::provisionalLoad):
(LayoutTestController::timerEvent):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::numberOfActiveAnimations):
(EventSender::keyDown):
(EventSender::frameUnderMouse):
(TextInputController::doCommand):

3:38 AM Writing Layout Tests for DumpRenderTree edited by cam@mcc.id.au
make-js-test-wrappers renamed to make-script-test-wrappers (diff)
12:43 AM Changeset in webkit [47357] by Darin Adler
  • 3 edits in trunk/WebCore

Change HTMLAreaElement to use OwnArrayPtr
​https://bugs.webkit.org/show_bug.cgi?id=28386

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::HTMLAreaElement): Removed unneeded initializer.
(WebCore::HTMLAreaElement::~HTMLAreaElement): Removed unneeded delete call.
(WebCore::HTMLAreaElement::parseMappedAttribute): Use the set function
instead of deletion followed by assignment.

  • html/HTMLAreaElement.h: Use OwnArrayPtr.
12:41 AM Changeset in webkit [47356] by Darin Adler
  • 2 edits in trunk/WebCore

Fix Windows build.

Patch by Darin Adler <Darin Adler> on 2009-08-17

  • dom/make_names.pl: Add back cast to (void*) needed on Windows.
12:38 AM Changeset in webkit [47355] by Darin Adler
  • 5 edits in trunk/WebCore

Move noResize from HTMLFrameElementBase to HTMLFrameElement
​https://bugs.webkit.org/show_bug.cgi?id=28384

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::HTMLFrameElement): Initialize m_noResize.
(WebCore::HTMLFrameElement::parseMappedAttribute): Set m_noResize to true
here if noresizeAttr is changed. This code was moved here from
HTMLFrameElementBase, but I added some FIXME comments.
(WebCore::HTMLFrameElement::setNoResize): Set the attribute based on
boolean argument. Moved here from HTMLFrameElementBase.

  • html/HTMLFrameElement.h: Moved noResize, setNoResize, and m_noResize

here from HTMLFrameElementBase.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed m_noResize.
(WebCore::HTMLFrameElementBase::parseMappedAttribute): Removed code to parse
noresizeAttr.

  • html/HTMLFrameElementBase.h: Removed noResize, setNoResize, and m_noResize.
12:35 AM Changeset in webkit [47354] by Darin Adler
  • 5 edits in trunk/WebCore

Tweak HTMLFrameElementBase so that m_URL can be private
​https://bugs.webkit.org/show_bug.cgi?id=28385

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::rendererIsNeeded): Removed m_URL argument.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed): Use m_URL instead of
taking an argument.
(WebCore::HTMLFrameElementBase::openURL): Removed m_URL argument.

  • html/HTMLFrameElementBase.h: Removed argument from isURLAllowed function.
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::rendererIsNeeded): Removed m_URL argument.

12:14 AM Changeset in webkit [47353] by Darin Adler
  • 3 edits in trunk/WebCore

HTMLViewSourceDocument should use smart pointers
​https://bugs.webkit.org/show_bug.cgi?id=28378

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): Don't initialize
pointers any more since RefPtr starts 0 by default.
(WebCore::HTMLViewSourceDocument::createContainingTable): Use more specific
types for local variables.
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Return a PassRefPtr,
and use a RefPtr of a more specific type for a local variable.
(WebCore::HTMLViewSourceDocument::addLine): Use more specific types for local
variables, and use RefPtr as well.
(WebCore::HTMLViewSourceDocument::addLink): Return a PassRefPtr, and use a
RefPtr of a more specific type for a local variable.

  • html/HTMLViewSourceDocument.h: Change return types to PassRefPtr and

data member types to RefPtr.

12:12 AM Changeset in webkit [47352] by Darin Adler
  • 5 edits in trunk/WebCore

DOM attribute getter/setter functions should use const AtomicString& type
​https://bugs.webkit.org/show_bug.cgi?id=25425

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.

Convert 4 more classes. These are classes I am going to make other changes
to soon, so it's good to have this use of Reflect in the IDL out of the way.

  • html/HTMLEmbedElement.idl: Use Reflect for many attributes.
  • html/HTMLFrameElement.idl: Ditto.
  • html/HTMLIFrameElement.idl: Ditto.
  • html/HTMLObjectElement.idl: Ditto.
12:09 AM Changeset in webkit [47351] by Darin Adler
  • 2 edits in trunk/WebCore

Script to create element factory needs changes to accommodate calling create
​https://bugs.webkit.org/show_bug.cgi?id=28379

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.

  • dom/make_names.pl: Tweak formatting. Remove lots of unneeded quotes

around names used inside {}. Added new createWithNew property for tags
that makes the factory use a create function instead of calling new.
Renamed functions with initialize in their name to have default in their
name, since they return an array full of default values and don't themselves
initialize anything.

Aug 16, 2009:

10:26 PM Changeset in webkit [47350] by Darin Adler
  • 2 edits in trunk/WebCore

StyledElement should use ASCIICType instead of having its own toHex function
​https://bugs.webkit.org/show_bug.cgi?id=28377

Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSColor): Use isASCIIHexDigit and toASCIIHexValue.

10:24 PM Changeset in webkit [47349] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

<​http://webkit.org/b/28366> WebHTMLViewInternal.h: add @class CALayer declaration

Reviewed by Simon Fraser.

Without WebKitPrefix.h, the missing @class CALayer declaration
causes a compile-time error.

  • WebView/WebHTMLViewInternal.h: Added @class CALayer declaration with USE(ACCELERATED_COMPOSITING).
10:24 PM Changeset in webkit [47348] by Darin Adler
  • 5 edits in trunk

WebCore: execCommand("InsertHorizontalRule") inserts a broken <hr> element
​https://bugs.webkit.org/show_bug.cgi?id=28375

Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.

  • editing/EditorCommand.cpp:

(WebCore::executeInsertHorizontalRule): Create an HTMLHRElement
instead of just an HTMLElement.

LayoutTests: execCommand("InsertHorizontalRule") inserts a broken <hr> element
​https://bugs.webkit.org/show_bug.cgi?id=28375

Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.

  • editing/execCommand/arguments-combinations-expected.txt: Updated.
  • editing/execCommand/arguments-combinations.html: Updated to expect

the <hr> element to be self-closing rather than having a separate
</hr> in the markup.

5:45 PM Changeset in webkit [47347] by Nikolas Zimmermann
  • 7 edits
    4 adds in trunk

2009-08-16 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <option> element & 'onpick' events - history navigation is broken
​https://bugs.webkit.org/show_bug.cgi?id=28371

After selecting an option element with an 'onpick' event associated with a 'go' task,
the navigation is executed. When going back in history, the same 'onpick' event is fired
again. Fix that problem, add wml/option-element-onpick-recursion.html covering the bug.

Test: wml/option-element-onpick-recursion.html

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::handleIntrinsicEventIfNeeded):
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::WMLSelectElement): (WebCore::WMLSelectElement::selectInitialOptions):
  • wml/WMLSelectElement.h: (WebCore::WMLSelectElement::initialized):

2009-08-16 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <option> element & 'onpick' events - history navigation is broken
​https://bugs.webkit.org/show_bug.cgi?id=28371

Add new test covering history navigation & 'onpick' event handling.

  • wml/option-element-onpick-recursion-expected.txt: Added.
  • wml/option-element-onpick-recursion.html: Added.
  • wml/resources/WMLTestCase.js: (createStaticWMLTestCase): (createDynamicWMLTestCase):
  • wml/resources/option-element-onpick-recursion.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/option-element-onpick-recursion.wml: Added.
  • wml/resources/option-element-onpick.js: (prepareTest):
5:44 PM Changeset in webkit [47346] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<​http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements

Reviewed by David Levin.

In <​http://webkit.org/b/28355#c1>, it was noted that new source
files use 'using namespace std;' instead of individual
'using std::foo;' statements. This adds a level 4 check for
such statements.

  • Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'build/using_std'. (check_using_std): Added. (check_style): Added call to check_using_std().
  • Scripts/modules/cpp_style_unittest.py: (WebKitStyleTest.test_using_std): Added unit test.
5:32 PM Changeset in webkit [47345] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Backed out r47343 which was mistakenly committed

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
5:30 PM Changeset in webkit [47344] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class

Reviewed by David Levin.

The ScriptError class doesn't exist in bugzilla.py, so any
errors print error messages about ScriptError instead of the
actual error:

NameError: global name 'ScriptError' is not defined

  • Scripts/modules/bugzilla.py: (BugzillaError): Added class. Modeled after ScriptError class in scm.py. (Bugzilla.authenticate): Changed to use BugzillaError instead of ScriptError. (Bugzilla._check_create_bug_response): Ditto.
5:30 PM Changeset in webkit [47343] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools/Scripts

WIP: bugzilla-tool: add land-commits command

4:24 PM Changeset in webkit [47342] by rik@webkit.org
  • 2 edits in trunk/WebCore

Inspector Resource filtering: keyboard Navigation always uses ALL resources
​https://bugs.webkit.org/show_bug.cgi?id=28231

Patch by Anthony Ricaud <​rik@webkit.org> on 2009-08-16
Reviewed by Timothy Hatcher.

Determine if a resource is selectable on user action.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceSidebarTreeElement.prototype.get selectable):

3:57 PM Changeset in webkit [47341] by ddkilzer@apple.com
  • 10 edits in trunk

<​http://webkit.org/b/28355> Replace MAX()/MIN() macros with type-safe std::max()/min() templates

Reviewed by Dan Bernstein.

WebCore:

  • accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetSpelling): Changed MIN() to min().
  • platform/graphics/mac/FontMacATSUI.mm: (WebCore::Font::selectionRectForComplexText): Changed MAX() to max() and MIN() to min(). (WebCore::Font::floatWidthForComplexText): Ditto.
  • platform/graphics/mac/SimpleFontDataMac.mm: Added using std::max statement. (WebCore::SimpleFontData::platformInit): Changed MAX() to max().
  • platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode): Changed MIN() to min().

WebKit/mac:

  • Plugins/WebBaseNetscapePluginStream.mm: Added using std::min statement. (WebNetscapePluginStream::deliverData): Changed MIN() to min(). Changed C-style cast to a static_cast.
  • Plugins/WebNetscapePluginView.mm: Added using std::min statement. (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): Changed MIN() to min(). Changed C-style cast to a static_cast.
  • WebView/WebHTMLView.mm: Added using std::max statement. (-[WebHTMLView _dragImageForURL:withLabel:]): Changed MAX() to max(). (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
  • WebView/WebTextCompletionController.mm: Added using std::max and using std::min statements. (-[WebTextCompletionController _placePopupWindow:]): Changed type of maxWidth variable from float to CGFloat to prevent a type mismatch on x86_64. Changed MAX() to max() and MIN() to min(). Added static_cast for a constant value since CGFloat is defined as a float on i386 and as a double on x86_64.
12:27 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:27 PM HowToSubmitPatch.png attached to Creating and Submitting Layout Tests and Patches by rniwa@webkit.org
Flow chart on how to submit a patch
12:25 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:25 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:25 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:24 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:23 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:22 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:21 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:20 PM Flow chart edited by rniwa@webkit.org
(diff)
12:18 PM Flow chart edited by rniwa@webkit.org
(diff)
12:16 PM Flow chart edited by rniwa@webkit.org
adding picture (diff)
12:16 PM flowchart5.png attached to Flow chart by rniwa@webkit.org
Flow chart on how to submit a patch
12:15 PM Flow chart created by rniwa@webkit.org
initial creation
10:35 AM Changeset in webkit [47340] by Nikolas Zimmermann
  • 11 edits in trunk/WebCore

2009-08-16 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Cleanup WMLIntrinsicEventHandling code
​https://bugs.webkit.org/show_bug.cgi?id=28358

Remove superflous "Event* evt" parameter from executeTask() methods. It's a leftover from the initial WML merge.

  • wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::defaultEventHandler):
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::defaultEventHandler):
  • wml/WMLGoElement.cpp: (WebCore::WMLGoElement::executeTask):
  • wml/WMLGoElement.h:
  • wml/WMLIntrinsicEventHandler.cpp: (WebCore::WMLIntrinsicEventHandler::triggerIntrinsicEvent):
  • wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::executeTask):
  • wml/WMLPrevElement.h:
  • wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::executeTask):
  • wml/WMLRefreshElement.h:
  • wml/WMLTaskElement.h:
9:15 AM Changeset in webkit [47339] by pfeldman@chromium.org
  • 21 edits in trunk/WebCore

2009-08-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: A handful of DOMAgent-related fixes and cleanups.

  • renamed elementId to nodeId in operations on nodes.
  • added load listeners to frame owners in InspectorDOMAgent.
  • removed InspectorController::inspectedWindowScriptObjectCleared event.
  • preserved isViaInspector flag for 'via inspector' marker to survive styles update.
  • removed contentDocument-related logic from ElementsPanel since it is handled in

the InspectorDOMAgent.

  • removed DOM listeners unregistration and corresponding events from InspectorController.
  • made this.styles 'private' in ElementsPanel.
  • added TODO for the handleCopy processing.

​https://bugs.webkit.org/show_bug.cgi?id=28356

  • WebCore.order:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setTextNodeValue):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerParentNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMDocument.prototype.addEventListener): (WebInspector.DOMDocument.prototype.removeEventListener): (WebInspector.DOMDocument.prototype._fireDomEvent): (WebInspector.DOMAgent.prototype.getChildNodesAsync.mycallback): (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.CSSStyleDeclaration.parseRule): (WebInspector.childNodeInserted): (WebInspector.childNodeRemoved):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.addStyleChange): (WebInspector.ElementsPanel.prototype.removeStyleChange): (WebInspector.ElementsPanel.prototype._updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.handleCopyEvent):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.findTreeElement): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.onexpand):
  • inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector): (InjectedScript._serializeRule):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
  • inspector/front-end/inspector.js: (WebInspector.set hoveredDOMNode):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype.findTreeElement):
  • inspector/front-end/utilities.js: (Node.prototype.enclosingNodeOrSelfWithNodeNameInArray): (Node.prototype.enclosingNodeOrSelfWithClass): (isAncestorNode): (firstCommonNodeAncestor): (traverseNextNode): (traversePreviousNode): ():
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable):
  • page/android/InspectorControllerAndroid.cpp:
6:14 AM Changeset in webkit [47338] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-16 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

Fix crash on ./ecma_2/RegExp/exec-002.js.
​https://bugs.webkit.org/show_bug.cgi?id=28353

Change the order of freeParenthesesDisjunctionContext and
popParenthesesDisjunctionContext on all call sites as the pop
method is accessing backTrack->lastContext which is the context
that is about to be freed.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses):
6:14 AM Changeset in webkit [47337] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-16 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=28352

Fix coding style violations. Use m_ for C++ class members. Remove
trailing whitespace on empty lines.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::tryConsumeCharacter): (JSC::Yarr::Interpreter::tryConsumeBackReference): (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::ByteCompiler::ByteCompiler): (JSC::Yarr::ByteCompiler::compile): (JSC::Yarr::ByteCompiler::checkInput): (JSC::Yarr::ByteCompiler::assertionBOL): (JSC::Yarr::ByteCompiler::assertionEOL): (JSC::Yarr::ByteCompiler::assertionWordBoundary): (JSC::Yarr::ByteCompiler::atomPatternCharacter): (JSC::Yarr::ByteCompiler::atomCharacterClass): (JSC::Yarr::ByteCompiler::atomBackReference): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::popParenthesesStack): (JSC::Yarr::ByteCompiler::closeAlternative): (JSC::Yarr::ByteCompiler::closeBodyAlternative): (JSC::Yarr::ByteCompiler::atomParenthesesEnd): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction): (JSC::Yarr::ByteCompiler::alterantiveDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
5:33 AM Changeset in webkit [47336] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed. Add missing WML specific layout test result.

Note: See TracTimeline for information about the timeline view.