Timeline
Aug 18, 2009:
- 11:49 PM Changeset in webkit [47496] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-18 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28443
Fix build break with gtk older than 2.14.
WebKit gtk port requires gtk 2.10 or later, but DragClientGtk.cpp
uses gtk_widget_get_window that is introduced in 2.14.
- WebCoreSupport/DragClientGtk.cpp: define gtk_widget_get_window for gtk older than 2.14.
- 11:31 PM Changeset in webkit [47495] by
-
- 2 edits in trunk/WebCore
2009-08-18 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContextSkia.cpp
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::setLineDash): (WebCore::GraphicsContext::setPlatformShadow):
- 11:08 PM Changeset in webkit [47494] by
-
- 3 edits5 adds in trunk
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=28446
Custom request headers shouldn't be sent with cross-origin preflight request
Tests: http/tests/xmlhttprequest/access-control-preflight-headers-async.html
http/tests/xmlhttprequest/access-control-preflight-headers-sync.html
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): Don't copy headers to OPTIONS request. The spec is vague about this, but the intention was that they shouldn't be sent, and Firefox doesn't send them.
- 10:57 PM Changeset in webkit [47493] by
-
- 3 edits in trunk/WebKit/gtk
2009-08-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Oliver Hunt.
[Gtk] crash when closing page from javascript
https://bugs.webkit.org/show_bug.cgi?id=27439
Do not unref the WebView in ChromeClientGtk::closeWindowSoon
because (1) a create-web-view handler can return a NULL WebView,
(2) the created WebView is owned by its containing widget, and (3)
clients may not handle the close-web-view signal so this avoids
unreffing a WebView more than once.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- 10:50 PM Changeset in webkit [47492] by
-
- 14 edits1 add in trunk/WebCore
2009-08-18 John Gregg <johnnyg@google.com>
Reviewed by Dimitri Glazkov.
V8 Bindings for Desktop Notifications feature.
https://bugs.webkit.org/show_bug.cgi?id=28271
- WebCore.gypi: added notification files to build (all still behind a flag that's not on)
- bindings/scripts/CodeGeneratorV8.pm: added special case in DOMWindow/AppCache style for named event handlers
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/V8Proxy.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::convertToV8Object):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8NotificationCenterCustom.cpp: Added.
- notifications/Notification.h: made event handler routines public (as they are in DOMWindow, eg) for binding access.
- notifications/NotificationCenter.idl: needed to make methods V8Custom to support different behaviors in worker/page context in chromium.
- workers/WorkerThread.h: (WebCore::WorkerThread::getNotificationPresenter): (WebCore::WorkerThread::setNotificationPresenter): needed to make these methods public as well so chromium can inject the notification presenter into the worker thread.
- 10:24 PM Changeset in webkit [47491] by
-
- 2 edits in trunk/WebKitTools
2009-08-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Kilzer.
run-webkit-tests hangs when WebCore tries to log too much
https://bugs.webkit.org/show_bug.cgi?id=15743
Read stdout and stderr in parallel.
- Scripts/run-webkit-tests:
- 10:16 PM Changeset in webkit [47490] by
-
- 2 edits in trunk
2009-08-18 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Holger Freyther.
Require at least libsoup 2.27.91 for the new password
manager/authentication APIs.
- configure.ac:
- 10:09 PM Changeset in webkit [47489] by
-
- 7 edits2 adds in trunk
2009-08-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
- Implement HTML5 nav element https://bugs.webkit.org/show_bug.cgi?id=27937
<nav> should behave essentially the same as <div> for parsing
etc. This is implemented by the changes below.
Tests: fast/html/nav-element.html
- css/html.css:
- editing/htmlediting.cpp: (WebCore::validBlockTag):
- html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): (WebCore::blockTagList):
- html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
- html/HTMLTagNames.in:
2009-08-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
- Tests for: Implement HTML5 nav element https://bugs.webkit.org/show_bug.cgi?id=27937
Test aspects of <nav>, including residual style, <p> closing, and FormatBlock.
- fast/html/nav-element-expected.txt: Added.
- fast/html/nav-element.html: Added.
- 9:42 PM Changeset in webkit [47488] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 9:42 PM Changeset in webkit [47487] by
-
- 1 copy in tags/Safari-6531.13
New tag.
- 9:41 PM Changeset in webkit [47486] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r47482.
- 9:41 PM Changeset in webkit [47485] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 9:39 PM Changeset in webkit [47484] by
-
- 3 edits in trunk/LayoutTests/platform/win
Land updated Windows layout test results.
- 9:19 PM Changeset in webkit [47483] by
-
- 3 edits in trunk/WebKitTools
Add a new build configuration that checks for leaks during the layout tests,
and hook a new machine up to it.
Rubber-stamped by Oliver Hunt.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 9:01 PM Changeset in webkit [47482] by
-
- 3 edits in trunk/WebCore
- Fix <rdar://problem/7152727>
Patch by Anders Carlsson <andersca@apple.com> on 2009-08-18
Reviewed by Adele Peterson, David Hyatt and Dan Bernstein.
If a page has custom scroll bars, they will not update correctly when the window is activated/deactivated.
- page/FrameView.cpp:
(WebCore::FrameView::hasCustomScrollbars):
Check if the frame view or any of its subviews have custom scroll bars.
(WebCore::FrameView::updateControlTints):
Go ahead and update control tints if the frame view has custom scroll bars.
- page/FrameView.h:
- 8:42 PM Changeset in webkit [47481] by
-
- 12 edits2 deletes in trunk/WebCore
Roll out r47477 as it introduced assertion failures and crashes on the build bots.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/Database.cpp:
- storage/Database.h:
- storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::DatabaseThread):
- storage/DatabaseThread.h:
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::postflightAndCommit):
- storage/SQLTransactionClient.cpp: Removed.
- storage/SQLTransactionClient.h: Removed.
- 8:32 PM Changeset in webkit [47480] by
-
- 1 edit1 add in trunk/WebCore
2009-08-18 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding the SharedTimer file for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28126
- platform/haiku/SharedTimerHaiku.cpp: Added. (WebCore::): (WebCore::SharedTimerHaiku::SharedTimerHaiku): (WebCore::SharedTimerHaiku::~SharedTimerHaiku): (WebCore::SharedTimerHaiku::instance): (WebCore::SharedTimerHaiku::start): (WebCore::SharedTimerHaiku::stop): (WebCore::SharedTimerHaiku::Filter): (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
- 8:13 PM Changeset in webkit [47479] by
-
- 2 edits in trunk/WebCore
Release build fix.
- xml/XMLHttpRequest.cpp: Sprinkle some #ifndef NDEBUG around.
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::~XMLHttpRequest):
- 8:01 PM Changeset in webkit [47478] by
-
- 4 edits in trunk
Leak of WebCore::XMLHttpRequest object during layout tests (<https://bugs.webkit.org/show_bug.cgi?id=28412>).
2009-08-18 Aaron Boodman <aa@chromium.org>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
No new tests: Already covered by existing tests.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): Add instrumentation for this kind of leak. (WebCore::XMLHttpRequest::~XMLHttpRequest): Ditto. (WebCore::XMLHttpRequest::createRequest): Only setPendingActivity() if we actually started a request. Also, restore a call to nonCacheRequestInFlight() that got lost in a recent refactor.
- Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
- 7:56 PM Changeset in webkit [47477] by
-
- 12 edits2 adds in trunk/WebCore
2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Added a client to SQLTransaction. In addition to being a place to
get notifications about certain events in a transaction, it is
also an abstraction layer that allows us to plug in different
implementations for each port for how transactions interract with
the main DB. For example, WebCore's default implementation will
make direct calls to DatabaseTracker's methods. At the same time,
Chromium's implementation will send IPCs to the browser process
whenever a transaction needs something from the main DB.
All storage tests pass.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/Database.cpp: (WebCore::Database::transactionClient):
- storage/Database.h:
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread):
- storage/DatabaseThread.h: (WebCore::DatabaseThread::transactionClient):
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::runCurrentStatement): (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): (WebCore::SQLTransaction::postflightAndCommit):
- storage/SQLTransactionClient.cpp: Added.
- storage/SQLTransactionClient.h: Added.
- 7:44 PM Changeset in webkit [47476] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix for Chromium.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-18
Final change for v8 corresponding to http://trac.webkit.org/changeset/47469.
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added missing using statment
- 7:32 PM Changeset in webkit [47475] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix for Chromium.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-18
More corresponding changes to V8 from http://trac.webkit.org/changeset/47469.
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
(WebCore::ACCESSOR_SETTER): Use srcAttr instead of the src function.
- 7:19 PM Changeset in webkit [47474] by
-
- 2 edits in trunk/JavaScriptCore
Assigning a function to an object should always use the existing transition, even if the transition is not specialized
https://bugs.webkit.org/show_bug.cgi?id=28442
Reviewed by Gavin Barraclough.
Check for an unspecialized transition as an alternative to always failing if specialisation does not match.
- 7:18 PM Changeset in webkit [47473] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix for Chromium.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-18
Make corresponding changes to V8 from http://trac.webkit.org/changeset/47469.
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
(WebCore::ACCESSOR_SETTER): Use srcAttr instead of the src function.
- 7:15 PM Changeset in webkit [47472] by
-
- 2 edits in trunk/LayoutTests
Remove accidentally committed logging
- 7:12 PM BuildingGtk edited by
- Add a couple of packges that are needed to build (diff)
- 7:12 PM UsingGitWithWebKit edited by
- Make it better! (diff)
- 7:07 PM UsingGitWithWebKit edited by
- Clear up the section about git-svn (diff)
- 6:36 PM Changeset in webkit [47471] by
-
- 2 edits in trunk/LayoutTests
Make test faster so leaks bot won't time out.
Reviewed by Mark Rowe
- 5:26 PM Changeset in webkit [47470] by
-
- 2 edits in trunk/WebCore
Build fix.
- editing/ApplyStyleCommand.cpp:
(WebCore::getIdentifierValue):
- 5:17 PM Changeset in webkit [47469] by
-
- 28 edits in trunk/WebCore
More work on making DOM classes start with reference count of 1
https://bugs.webkit.org/show_bug.cgi?id=28068
Patch by Darin Adler <Darin Adler> on 2009-08-18
Reviewed by Sam Weinig.
Some related clean-up and preparation steps so the subsequent
patches will be as small as possible.
- WebCore.base.exp: Sorted this file.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescription):
Use nameAttr instead of the name function.
- bindings/js/JSHTMLFrameElementCustom.cpp:
(WebCore::JSHTMLFrameElement::setSrc):
Use srcAttr instead of the src function.
- bindings/js/JSHTMLIFrameElementCustom.cpp:
(WebCore::JSHTMLIFrameElement::setSrc):
Use srcAttr instead of the src function.
- bindings/objc/DOM.mm: Sorted includes.
- dom/Document.cpp: Ditto.
- dom/StyledElement.cpp: Made invalidateStyleAttribute inline.
- dom/StyledElement.h: Ditto.
- dom/make_names.pl: Changed default of createWithNew to 0.
Eventually all elements will be created with create instead of new.
- html/HTMLTagNames.in:
- svg/svgtags.in:
- wml/WMLTagNames.in:
Added createWithNew for every tag. We'll remove it as we convert
element classes to use create.
- html/HTMLAppletElement.h: Removed unneeded forward declarations.
- html/HTMLFrameElement.h: Ditto.
- html/HTMLEmbedElement.cpp: Removed many attribute get and
set functions.
- html/HTMLEmbedElement.h: Ditto.
- html/HTMLIFrameElement.cpp: Ditto.
- html/HTMLIFrameElement.h: Ditto.
- html/HTMLObjectElement.cpp: Ditto.
- html/HTMLObjectElement.h: Ditto.
- html/HTMLPlugInElement.cpp: Ditto.
- html/HTMLPlugInElement.h: Ditto.
- html/HTMLFrameElementBase.cpp: Removed many attribute get and
set functions.
(WebCore::HTMLFrameElementBase::location): Changed to use
srcAttr instead of src.
- html/HTMLFrameElementBase.h: Removed many attribute get and set
functions.
- loader/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
Use srcAttr and typeAttr instead of setSrc and setType.
- loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::createDocumentStructure): Ditto.
- rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget): Use nameAttr instead
of name -- this avoids an extra AtomicString round trip and a little
ref count churn too.
- 5:05 PM Changeset in webkit [47468] by
-
- 5 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe
Update Windows and Qt results after r47462.
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 5:04 PM Changeset in webkit [47467] by
-
- 14 edits1 copy19 adds in trunk
WebCore: SharedWorkers need to support loading.
https://bugs.webkit.org/show_bug.cgi?id=28342
Reviewed by David Levin.
Added loader support to shared workers, and refactored worker tests to also test SharedWorkers
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
Forwards load requests to an arbitrary document from the list of worker's documents.
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
Posts responses back to the shared worker thread.
LayoutTests: SharedWorkers need to support loading
https://bugs.webkit.org/show_bug.cgi?id=28342
Reviewed by David Levin.
Refactored worker network tests to also test SharedWorkers.
- http/tests/workers/resources/worker-importScripts.js:
Refactored to run in either a dedicated or shared worker.
(handleConnect.self.postMessage):
(handleConnect):
(runTests.try.resetLoadFlags):
(runTests):
- http/tests/workers/resources/worker-redirect-target.js:
Refactored to run in either a dedicated or shared worker.
(else.self.onconnect):
- http/tests/workers/resources/worker-redirect.js: Added.
Moved test code out of worker-redirect.html so it can be shared with shared worker tests.
(log):
(runNextTest):
(testCrossOriginLoad.try.worker.onerror):
(testCrossOriginLoad.try.worker.onmessage):
(testCrossOriginLoad):
(testCrossOriginRedirectedLoad.try.worker.onerror):
(testCrossOriginRedirectedLoad.try.worker.onmessage):
(testCrossOriginRedirectedLoad):
- http/tests/workers/shared-worker-importScripts-expected.txt: Added.
- http/tests/workers/shared-worker-importScripts.html-disabled: Added.
- http/tests/workers/shared-worker-redirect-expected.txt: Added
- http/tests/workers/shared-worker-redirect.html-disabled: Added.
- http/tests/workers/worker-redirect.html:
Moved test code into worker-redirect.js.
- http/tests/xmlhttprequest/workers/close.html:
Moved test code into close-test.js.
- http/tests/xmlhttprequest/workers/methods-async.html:
Moved test code into methods-async-test.js.
- http/tests/xmlhttprequest/workers/methods.html:
Moved test code into methods.js.
- http/tests/xmlhttprequest/workers/resources/close-test.js: Added.
Contains test code moved from close.html, so tests can be shared with SharedWorkers.
(log):
(testAsync.worker.onmessage.else):
(testAsync.worker.onmessage):
(testAsync):
(testSync.worker.onmessage.else):
(testSync.worker.onmessage):
(testSync):
(done):
(handleException):
- http/tests/xmlhttprequest/workers/resources/close.js:
Modified worker code so it runs in shared workers also.
- http/tests/xmlhttprequest/workers/resources/file-not-found.js: Added.
Contains test code moved from xmlhttprequest-file-not-found.html (now shared with shared worker tests).
(log):
(worker.onmessage):
- http/tests/xmlhttprequest/workers/resources/methods-async-test.js: Added.
Contains test code moved from methods-async.html (now shared with shared worker tests).
(log):
(worker.onmessage):
- http/tests/xmlhttprequest/workers/resources/methods-async.js:
Changed code to run in shared workers also.
- http/tests/xmlhttprequest/workers/resources/methods-test.js: Added.
Contains test code moved from methods.html (now shared with shared worker tests).
(log):
(worker.onmessage):
- http/tests/xmlhttprequest/workers/resources/methods.js:
Now can run in either dedicated or shared workers.
(init):
- http/tests/xmlhttprequest/workers/resources/shared-worker-create.js: Added.
Utility code to allow shared workers to look like dedicated workers to enable sharing test code.
(createWorker.worker.port.onmessage):
(createWorker.worker.postMessage):
(createWorker):
- http/tests/xmlhttprequest/workers/resources/worker-create.js: Added.
(createWorker):
- http/tests/xmlhttprequest/workers/resources/worker-pre.js: Added.
Utility code to make SharedWorkerGlobalScope look like DedicatedWorkerGlobalScope, to enable test code sharing.
(else.self.onconnect.self.postMessage):
(else.self.onconnect.event.messagePort.onmessage):
(else.self.onconnect):
- http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js:
(init):
Updated code so it runs in shared workers also.
- http/tests/xmlhttprequest/workers/shared-worker-close-expected.txt: Added.
- http/tests/xmlhttprequest/workers/shared-worker-close.html-disabled: Added.
- http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
- http/tests/xmlhttprequest/workers/shared-worker-methods-async.html-disabled: Added.
- http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Added.
- http/tests/xmlhttprequest/workers/shared-worker-methods.html-disabled: Added.
- http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found-expected.txt: Added.
- http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html-disabled: Added.
- http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html:
Moved test code into file-not-found.js.
- 5:01 PM Changeset in webkit [47466] by
-
- 2 edits in trunk/WebCore
2009-08-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
StyleChange::init needs clean up before fixing the bug 23892
https://bugs.webkit.org/show_bug.cgi?id=27749
This patch simplifies StyleChange::init by removing the iteration on CSS properties,
and adding functions reconcileTextDecorationProperties and extractTextStyle to handle the style.
Because there is a bug in how text decorations are processes in getPropertiesNotInComputedStyle,
this patch simplifies the treatment in order to preserve the original behavior of WebKit.
However, the current implementation is not best (adds redundant text-decorations) and we should fix it later.
No test is added since there is no change in behavior.
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Uses getPropertiesNotInComputedStyle instead of iterating through the properties (WebCore::StyleChange::reconcileTextDecorationProperties): Removes -webkit-text-decorations-in-effects and redundant "none" (WebCore::getIdentifierValue): Obtains the identifier of a CSSPrimitiveValue (WebCore::StyleChange::extractTextStyles): Converts properties in style to m_apply* and removes the property (WebCore::getPropertiesNotInComputedStyle): Fixed a bug with how text decorations are treated
- 5:00 PM Changeset in webkit [47465] by
-
- 3 edits in trunk/WebKitTools
Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
Rubber-stamped by Geoff Garen.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- 4:54 PM Changeset in webkit [47464] by
-
- 2 edits in trunk/WebCore
2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Fixing a DB file naming bug in Chromium. The origin should come
before the DB name in the file name.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase):
- 4:47 PM Changeset in webkit [47463] by
-
- 2 edits4 adds in trunk/WebCore
2009-08-18 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
[Haiku] Adding four image-specific files to WebCore:
IconHaiku.cpp, ImageBufferData.h, ImageBufferHaiku.cpp, ImageHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28130
- platform/graphics/Icon.h:
- platform/graphics/haiku/IconHaiku.cpp: Added. (WebCore::Icon::~Icon): (WebCore::Icon::createIconForFile): (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
- platform/graphics/haiku/ImageBufferData.h: Added.
- platform/graphics/haiku/ImageBufferHaiku.cpp: Added. (WebCore::ImageBufferData::ImageBufferData): (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::~ImageBuffer): (WebCore::ImageBuffer::context): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageBuffer::image): (WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/haiku/ImageHaiku.cpp: Added. (WebCore::FrameData::clear): (WebCore::Image::loadPlatformResource): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::getBBitmap):
- 4:36 PM Changeset in webkit [47462] by
-
- 10 edits in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=27575 [CSS3
Backgrounds and Borders] Drop the prefix from background-size
Reviewed by Dan Bernstein.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
(WebCore::cssPropertyID):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp:
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::ensurePropertyMap):
LayoutTests: Test result changes for https://bugs.webkit.org/show_bug.cgi?id=27575
[CSS3 Backgrounds and Borders] Drop the prefix from background-size
Reviewed by Dan Bernstein.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 4:21 PM WebCoreRendering edited by
- add class hierarchy (diff)
- 4:09 PM Changeset in webkit [47461] by
-
- 2 edits in trunk/WebKitTools
2009-08-18 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
and removed include to fix building on VC++ Express.
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::exceededDatabaseQuota):
- 3:15 PM Changeset in webkit [47460] by
-
- 5 edits3 adds in trunk
2009-08-18 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
SharedWorkers need to forward exceptions to parent documents
https://bugs.webkit.org/show_bug.cgi?id=28320
Wrote test to generate exception and make sure it gets logged to the console.
Started switching over to using the same test utilities that the tests under fast/js use.
- fast/workers/resources/shared-worker-common.js: (generateError): (handleMessage):
- fast/workers/resources/shared-worker-exception.js: Added. (worker.onmessage): (done):
- fast/workers/shared-worker-exception-expected.txt: Added.
- fast/workers/shared-worker-exception.html-disabled: Added.
2009-08-18 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
SharedWorkers need to forward exceptions to parent documents
https://bugs.webkit.org/show_bug.cgi?id=28320
Changed SharedWorkerProxy to have individual mutexes (so workers can interact with their parent documents without contention).
Updated SharedWorkerProxy to forward exceptions/console messages to all parent documents.
- bindings/js/JSSharedWorkerConstructor.cpp: Cleaned up bitrot - added missing include.
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::postExceptionTask): Callback used to deliver exceptions to a document. (WebCore::SharedWorkerProxy::postExceptionToWorkerObject): Forwards exceptions to all parent documents for presentation to the user. (WebCore::postConsoleMessageTask): (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject): Forwards console messages to all parent documents for presentation to the user. (WebCore::SharedWorkerProxy::addToWorkerDocuments): Grabs the mutex before accessing workerDocuments. (WebCore::SharedWorkerProxy::documentDetached): Grabs the mutex before accessing workerDocuments.
- 3:06 PM Changeset in webkit [47459] by
-
- 7 edits in trunk
WebCore: <rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource
Reviewed by Adele Peterson.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isSafeToLoadURL):
Call FrameLoaderClient::shouldLoadMediaElementURL.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::shouldLoadMediaElementURL):
Return true by default.
WebKit/mac: Mac specific part of
Reviewed by Adele Peterson.
<rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
Implement shouldLoadMediaElementURL by asking the policy delegate.
- WebView/WebPolicyDelegatePrivate.h:
Add new delegate method, remove some unused cruft.
- 2:58 PM Changeset in webkit [47458] by
-
- 3 edits2 adds in trunk
2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adding a test to verify that openDatabase() does not execute
SQL statements on the database it's trying to open, unless we're
opening the first handle to that database.
- storage/open-database-while-transaction-in-progress-expected.txt: Added.
- storage/open-database-while-transaction-in-progress.html: Added.
2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
openDatabase() should not execute any SQL statement on the
database it's trying to open, unless there are no other open
handles to the same database. Otherwise, we might run into a
deadlock.
Test: storage/open-database-while-transaction-in-progress.html
- storage/Database.cpp: (WebCore::Database::performOpenAndVerify):
- 2:48 PM Changeset in webkit [47457] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=19360
Frags on current page don't generate "navigation-requested" events
Fix order of parameters for the creation of SubstituteData object,
so that normal data loads do not have an unreachable URL. Also
remove a confusion about the purpose of the last parameter.
- webkit/webkitwebframe.cpp: (webkit_web_frame_load_data):
- 2:37 PM Changeset in webkit [47456] by
-
- 8 edits in trunk
2009-08-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG Filter feBlend implementation missing
https://bugs.webkit.org/show_bug.cgi?id=28133
Implementation of SVG Filter feBlend.
FilterEffect.cp needed changes to optimize the rendering. With the old code
we drew a subEffect on the current FilterEffect by drawImage, got the PixelArray,
cleared the drawing area, drew the next FilterEffect with drawImage and picked this
PixelArray again. This was unefficient and slow. Now we calculate the requested area
of the subEffect and ask the FilterEffect's ImageBuffer for the PixelArray directly,
without any drawing operations on GraphicsContext.
There is already a test case
Test: svg/W3C-SVG-1.1/filters-blend-01-b.svg
- html/canvas/CanvasPixelArray.h: (WebCore::CanvasPixelArray::set): (WebCore::CanvasPixelArray::get):
- platform/graphics/filters/FEBlend.cpp: (WebCore::unknown): (WebCore::normal): (WebCore::multiply): (WebCore::screen): (WebCore::darken): (WebCore::lighten): (WebCore::FEBlend::apply):
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingIntRect):
- platform/graphics/filters/FilterEffect.h:
2009-08-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
Added additional getter to ByteArray with an unsigned char as return.
ByteArray can take unsigned char directly now.
- wtf/ByteArray.h: (WTF::ByteArray::set): (WTF::ByteArray::get):
- 2:09 PM Changeset in webkit [47455] by
-
- 2 edits in trunk/WebCore
2009-08-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Fix array formatter followup: node formatter.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format):
- 2:05 PM Changeset in webkit [47454] by
-
- 4 edits in trunk/LayoutTests
Update SnowLeopard-specific layout test results after r47440.
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.txt:
- 1:44 PM Changeset in webkit [47453] by
-
- 2 edits in trunk/WebCore
2009-08-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Metrics sidebar broken
- inspector/front-end/MetricsSidebarPane.js:
- 1:21 PM Changeset in webkit [47452] by
-
- 1 edit in trunk/WebCore/page/PrintContext.cpp
Fix GTK bustage.
- 1:20 PM Changeset in webkit [47451] by
-
- 1 edit in trunk/WebCore/page/chromium/FrameChromium.cpp
Fix Chromium bustage.
- 1:15 PM Changeset in webkit [47450] by
-
- 9 edits in trunk/LayoutTests
Land updated results after my last patch.
- platform/mac/compositing/geometry/clipping-foreground-expected.txt:
- platform/mac/compositing/masks/masked-ancestor-expected.txt:
- platform/mac/compositing/masks/multiple-masks-expected.txt:
- platform/mac/compositing/masks/simple-composited-mask-expected.txt:
- platform/mac/fast/clip/008-expected.txt:
- platform/mac/fast/clip/011-expected.txt:
- platform/mac/fast/clip/012-expected.txt:
- platform/mac/fast/overflow/scrollRevealButton-expected.txt:
- 1:01 PM Changeset in webkit [47449] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=28432
String::createCFString() returns a non-retained empty string
No known change in functionality, so no test.
- platform/text/cf/StringCF.cpp: (WebCore::String::createCFString): Retain the CFSTR result.
- 12:58 PM Changeset in webkit [47448] by
-
- 1 edit in trunk/WebCore/page/win/FrameWin.cpp
Fix Windows build bustage.
- 12:53 PM Changeset in webkit [47447] by
-
- 11 edits in trunk
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Oliver Hunt.
Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setDatabaseQuota):
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::exceededDatabaseQuota):
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Oliver Hunt.
Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
Added a setQuota interface method to IWebDatabaseManager and implemented it.
- Interfaces/IWebDatabaseManager.idl:
- WebDatabaseManager.cpp: (WebDatabaseManager::setQuota):
- WebDatabaseManager.h:
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Oliver Hunt.
Removed now passing storage tests from the Skipped list, now we pass all storage tests on Windows.
- platform/win/Skipped:
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Oliver Hunt.
Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
Removed an early return that can cause deleteOrigin or deleteAllDatabases to fail when
it doesn't have to.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteOrigin):
- 12:53 PM Changeset in webkit [47446] by
-
- 1 copy in tags/Safari-6531.12
New tag.
- 12:50 PM Changeset in webkit [47445] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r47438.
- 12:50 PM Changeset in webkit [47444] by
-
- 12 edits18 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=27357
Support for :valid and :invalid CSS selectors, from HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/#selector-valid
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-18
Reviewed by Adele Peterson.
Tests: fast/css/pseudo-invalid-001.html
fast/css/pseudo-invalid-002.html
fast/css/pseudo-valid-001.html
fast/css/pseudo-valid-002.html
fast/css/pseudo-valid-003.html
fast/css/pseudo-valid-004.html
fast/css/pseudo-valid-005.html
fast/css/pseudo-valid-006.html
fast/css/pseudo-valid-007.html
- css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType): extracts new pseudo-classes
- css/CSSSelector.h:
(WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Make sure we don't share style between
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=27357
Tests for :valid and :invalid CSS selectors, from HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/#selector-valid
Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-18
Reviewed by Adele Peterson.
- fast/css/pseudo-invalid-001-expected.txt: Added.
- fast/css/pseudo-invalid-001.html: Added.
- fast/css/pseudo-invalid-002-expected.txt: Added.
- fast/css/pseudo-invalid-002.html: Added.
- fast/css/pseudo-valid-001-expected.txt: Added.
- fast/css/pseudo-valid-001.html: Added.
- fast/css/pseudo-valid-002-expected.txt: Added.
- fast/css/pseudo-valid-002.html: Added.
- fast/css/pseudo-valid-003-expected.txt: Added.
- fast/css/pseudo-valid-003.html: Added.
- fast/css/pseudo-valid-004-expected.txt: Added.
- fast/css/pseudo-valid-004.html: Added.
- fast/css/pseudo-valid-005-expected.txt: Added.
- fast/css/pseudo-valid-005.html: Added.
- fast/css/pseudo-valid-006-expected.txt: Added.
- fast/css/pseudo-valid-006.html: Added.
- fast/css/pseudo-valid-007-expected.txt: Added.
- fast/css/pseudo-valid-007.html: Added.
- fast/dom/plugin-attributes-enumeration-expected.txt:
- 12:47 PM Changeset in webkit [47443] by
-
- 3 edits in trunk/WebCore
2009-08-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Fix array formatter.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatarray):
- 12:43 PM Changeset in webkit [47442] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 12:39 PM Changeset in webkit [47441] by
-
- 2 edits in trunk/WebCore
2009-08-17 Joe Mason <joe.mason@torchmobile.com>
Reviewed by George Staikos
Replace repeated string of PLATFORM(FOO) with a single define
https://bugs.webkit.org/show_bug.cgi?id=27734
- loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
- 12:15 PM Changeset in webkit [47440] by
-
- 119 edits5 adds4 deletes in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=20329, shadows and reflections incorrectly
considered part of scrollable overflow.
Reviewed by Dan Bernstein.
This patch takes the engine's concept of overflow and splits it into two types:
layout overflow and visual overflow.
Layout overflow is about other boxes that spill out of an enclosing box, For example,
in the inline flow case a tall image could spill out of a line box. Examples of
visual overflow are shadows, text stroke (and eventually outline and
border-image).
Three objects tracked overflow before this patch: RenderBlock had
m_overflowLeft/Top/Width/Height variables. RootInlineBox had an Overflow*
that also had four overflow values. Finally RenderReplaced elements tracked shadow/reflection
overflow using a map that cached four values.
This patch takes all of these different overflow models and unifies them into a single
new class called RenderOverflow. This class is now a member variable in RenderBox and
InlineFlowBoxes. It is only allocated if overflow actually exists. Instead of tracking
four values, it tracks eight: left/top/right/bottom for layout overflow and
left/top/right/bottom for visual overflow.
Overflow computation is now done after layout is finished rather than during layout
(when child objects can be churning and moving around). A number of layout tests progressed
by deferring overflow computation to a separate pass.
All inline flow boxes now track overflow (and not just the root line box). This allows
repainting of line boxes to actually be tight and bail early if the overflow rect of a box
doesn't intersect. The old code always visited all object on a line if the root line box
intersected at all.
Line box overflow no longer propagates across self-painting layers. This fixes a number of
issues with incorrect scrollbars appearing when relative positioned inlines were used in a page.
Layer bounds have been modified to exclude visual overflow. The width/height members only really
have one reason for continued existence, and that is that they happen to be used in repaint()
when an overflow clip object's height isn't accurate. In this case, the bounds should exclude
visual overflow anyway, so this change tightens that repaint up.
Root lines have renamed m_selectionTop/Bottom to m_lineTop/Bottom and positionForPoint methods have
been changed to use these instead of relying on overflow (which was totally wrong).
Significant changes have been made to the "almost strict mode" line box quirk where objects with no
text children have no effect on the height of a line. Instead of making the height() of the objects
variable and dependent on overflow, the objects now have their full height and get placed on
the baseline properly. They simply don't contribute to overflow above lineTop/Bottom.
Reflections are no longer considered overflow of any kind. Because reflections have their own layers,
it is not necessary to treat them as visual or layout overflow in the RenderObject tree. The end result
of not incorporating them into RenderOverflow is that they have no effect on scrolling. transparencyClipBox
has been extended to support fully reflecting the entire clip box when a reflection exists. This fixes
numerous repaint bugs in transparent objects with reflections when the transparent objects had self-painting
sublayers.
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
- editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
- page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::adjustPageHeight):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::height):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::topCombinedOverflow):
(WebCore::InlineFlowBox::bottomCombinedOverflow):
(WebCore::InlineFlowBox::leftCombinedOverflow):
(WebCore::InlineFlowBox::rightCombinedOverflow):
(WebCore::InlineFlowBox::combinedOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromBlockChildren):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::fillInlineSelectionGaps):
(WebCore::RenderBlock::floatRect):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::layoutColumns):
(WebCore::getHeightForLineCount):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::destroy):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::addShadowAndReflectionOverflow):
(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::clearLayoutOverflow):
- rendering/RenderBox.h:
(WebCore::RenderBox::combinedOverflowRect):
(WebCore::RenderBox::topCombinedOverflow):
(WebCore::RenderBox::bottomCombinedOverflow):
(WebCore::RenderBox::leftCombinedOverflow):
(WebCore::RenderBox::rightCombinedOverflow):
(WebCore::RenderBox::layoutOverflowRect):
(WebCore::RenderBox::topLayoutOverflow):
(WebCore::RenderBox::bottomLayoutOverflow):
(WebCore::RenderBox::leftLayoutOverflow):
(WebCore::RenderBox::rightLayoutOverflow):
(WebCore::RenderBox::visualOverflowRect):
(WebCore::RenderBox::topVisualOverflow):
(WebCore::RenderBox::bottomVisualOverflow):
(WebCore::RenderBox::leftVisualOverflow):
(WebCore::RenderBox::rightVisualOverflow):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::localBoundingBox):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
- rendering/RenderObject.h:
- rendering/RenderOverflow.h: Added.
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::topLayoutOverflow):
(WebCore::RenderOverflow::bottomLayoutOverflow):
(WebCore::RenderOverflow::leftLayoutOverflow):
(WebCore::RenderOverflow::rightLayoutOverflow):
(WebCore::RenderOverflow::topVisualOverflow):
(WebCore::RenderOverflow::bottomVisualOverflow):
(WebCore::RenderOverflow::leftVisualOverflow):
(WebCore::RenderOverflow::rightVisualOverflow):
(WebCore::RenderOverflow::setTopLayoutOverflow):
(WebCore::RenderOverflow::setBottomLayoutOverflow):
(WebCore::RenderOverflow::setLeftLayoutOverflow):
(WebCore::RenderOverflow::setRightLayoutOverflow):
(WebCore::RenderOverflow::setTopVisualOverflow):
(WebCore::RenderOverflow::setBottomVisualOverflow):
(WebCore::RenderOverflow::setLeftVisualOverflow):
(WebCore::RenderOverflow::setRightVisualOverflow):
(WebCore::RenderOverflow::layoutOverflowRect):
(WebCore::RenderOverflow::visualOverflowRect):
(WebCore::RenderOverflow::combinedOverflowRect):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::resetLayoutOverflow):
- rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::layout):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::~RenderReplaced):
(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::positionForPoint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- rendering/RenderReplaced.h:
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::layout):
(WebCore::RenderScrollbarPart::paintIntoRect):
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderTableSection.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::localCaretRect):
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::adjustPosition):
(WebCore::RootInlineBox::verticallyAlignBoxes):
(WebCore::RootInlineBox::selectionTop):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):
(WebCore::RootInlineBox::lineTop):
(WebCore::RootInlineBox::lineBottom):
(WebCore::RootInlineBox::selectionBottom):
(WebCore::RootInlineBox::selectionHeight):
(WebCore::RootInlineBox::floats):
(WebCore::RootInlineBox::floatsPtr):
(WebCore::RootInlineBox::setLineTopBottomPositions):
- rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutInlineBoxes):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=20329, shadows and reflections incorrectly being included
as part of scrollable overflow.
Reviewed by Dan Bernstein.
Update layout tests to account for all of the changes made to overflow to split it into two types. Remove the layout
tests that were recently added that assumed that shadows and reflections should be part of scrollable overflow.
- fast/box-shadow/box-shadow-overflow-scroll-expected.txt: Removed.
- fast/box-shadow/box-shadow-overflow-scroll.html: Removed.
- fast/reflections/reflection-overflow-scroll-expected.txt: Removed.
- fast/reflections/reflection-overflow-scroll.html: Removed.
- platform/mac/compositing/overflow/ancestor-overflow-expected.txt:
- platform/mac/compositing/reflections/reflection-on-composited-expected.txt:
- platform/mac/editing/deleting/delete-br-011-expected.txt:
- platform/mac/editing/deleting/delete-br-012-expected.txt:
- platform/mac/editing/pasteboard/select-element-1-expected.txt:
- platform/mac/fast/block/positioning/relative-overflow-block-expected.txt:
- platform/mac/fast/body-propagation/background-color/002-expected.txt:
- platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt:
- platform/mac/fast/body-propagation/background-image/002-expected.txt:
- platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt:
- platform/mac/fast/body-propagation/overflow/001-expected.txt:
- platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt:
- platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt:
- platform/mac/fast/body-propagation/overflow/005-expected.txt:
- platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt:
- platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
- platform/mac/fast/box-shadow/transform-fringing-expected.txt:
- platform/mac/fast/clip/008-expected.txt:
- platform/mac/fast/clip/011-expected.txt:
- platform/mac/fast/clip/012-expected.txt:
- platform/mac/fast/dynamic/genContentDestroyChildren-expected.txt:
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt:
- platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/images/image-in-map-expected.txt:
- platform/mac/fast/inline-block/003-expected.txt:
- platform/mac/fast/inline/inline-text-quirk-bpm-expected.txt:
- platform/mac/fast/invalid/012-expected.txt:
- platform/mac/fast/layers/normal-flow-hit-test-expected.txt:
- platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/mac/fast/overflow/scrollRevealButton-expected.txt:
- platform/mac/fast/reflections/reflection-direction-expected.txt:
- platform/mac/fast/reflections/reflection-masks-expected.checksum:
- platform/mac/fast/reflections/reflection-masks-expected.png:
- platform/mac/fast/reflections/reflection-masks-expected.txt:
- platform/mac/fast/reflections/reflection-masks-opacity-expected.checksum:
- platform/mac/fast/reflections/reflection-masks-opacity-expected.png:
- platform/mac/fast/reflections/reflection-masks-opacity-expected.txt:
- platform/mac/fast/reflections/reflection-nesting-expected.txt:
- platform/mac/fast/reflections/reflection-overflow-hidden-expected.png:
- platform/mac/fast/reflections/reflection-overflow-hidden-expected.txt:
- platform/mac/fast/repaint/box-shadow-h-expected.txt:
- platform/mac/fast/repaint/box-shadow-v-expected.txt:
- platform/mac/fast/repaint/reflection-redraw-expected.txt:
- platform/mac/fast/repaint/reflection-repaint-test-expected.txt:
- platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
- platform/mac/fast/repaint/transform-replaced-shadows-expected.txt:
- platform/mac/fast/replaced/border-radius-clip-expected.txt:
- platform/mac/fast/transforms/shadows-expected.txt:
- platform/mac/fast/transforms/transforms-with-opacity-expected.txt:
- platform/mac/media/video-layer-crash-expected.txt:
- platform/mac/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10565-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22513-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3309-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4427-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
- platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
- platform/mac/tables/mozilla/bugs/bug8381-expected.txt:
- platform/mac/tables/mozilla/bugs/bug86708-expected.txt:
- platform/mac/tables/mozilla/core/bloomberg-expected.txt:
- platform/mac/tables/mozilla/other/ms-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
- 12:03 PM Changeset in webkit [47439] by
-
- 3 edits7 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=28431
<rdar://problem/7137610> Application Cache doesn't work with HTTP authentication
Test: http/tests/appcache/auth.html
- loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::shouldUseCredentialStorage): If appcache is enabled, always allow it to use stored credentials (we can't ask WebKit client, and maybe we shouldn't ask it, because it's not a document that's loading these resources).
- 11:56 AM Changeset in webkit [47438] by
-
- 3 edits in trunk/WebCore
Fix <rdar://problem/7147996>
Reviewed by John Sullivan and David Hyatt.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Update the style of the scroll bars.
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::RenderScrollbar):
Calculate the size of the scrollbar and set it as the frame size.
- 11:54 AM Changeset in webkit [47437] by
-
- 1 edit2 adds in trunk/LayoutTests
Not reviewed. Forgot to add pixel test results for html-fieldset-crash.html some time ago.
- 11:44 AM Changeset in webkit [47436] by
-
- 3 edits in trunk/LayoutTests
Unreviewed (Updating skipped tests).
Re-enabled test on GTK platform (DRT supports layoutTestController.workerThreadCount on GTK).
Disabled test on QT platform (DRT does not support workerThreadCount on QT).
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 11:42 AM Changeset in webkit [47435] by
-
- 5 edits in trunk/LayoutTests
2009-08-18 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (build fix).
Update results added for https://bugs.webkit.org/show_bug.cgi?id=28314 to
not log 'progress' event as the timing relative to other media events
isn't important and varies according to the behavior of the media engine.
- media/event-attributes-expected.txt:
- media/event-attributes.html:
- media/progress-event-at-least-one-expected.txt:
- media/progress-event-at-least-one.html:
- 11:40 AM Changeset in webkit [47434] by
-
- 2 edits in trunk/WebKit/win
Unreviewed (build break).
Added missing include for WebWorkersPrivate.h.
- WebKitClassFactory.cpp:
- 11:35 AM Changeset in webkit [47433] by
-
- 2 edits in trunk/LayoutTests
Unreviewed - skipping test on GTK.
Added worker-lifecycle.html tests to skipped tests on GTK platform due to missing DRT functionality.
- platform/gtk/Skipped:
- 11:14 AM Changeset in webkit [47432] by
-
- 2 edits in trunk
Speculative fix for GTK DumpRenderTree.
Reviewed by NOBODY (Build Break).
- GNUmakefile.am:
- 10:46 AM Changeset in webkit [47431] by
-
- 4 edits2 adds in trunk
2009-08-18 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTMLMediaElement should fire 'progress' event before 'load'
https://bugs.webkit.org/show_bug.cgi?id=28314
Test: media/progress-event-at-least-one.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState):
Schedule 'progress' event before 'load'.
2009-08-18 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTMLMediaElement should fire 'progress' event before 'load'
https://bugs.webkit.org/show_bug.cgi?id=28314
- media/event-attributes-expected.txt:
Update results to include 'progress' event fired before 'load'.
- media/progress-event-at-least-one-expected.txt: Added.
- media/progress-event-at-least-one.html: Added.
- 10:44 AM Changeset in webkit [47430] by
-
- 14 edits in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
Reviewed by Eric Seidel.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
Reviewed by Eric Seidel.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreGenerated.vcproj:
WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
Reviewed by Eric Seidel.
- WebKit.vcproj/InterfacesGenerated.vcproj:
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
Reviewed by Eric Seidel.
- record-memory-win/record-memory-win.vcproj:
- WinLauncher/WinLauncher.vcproj:
- WebKitLauncherWin/WebKitLauncherWin.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- FindSafari/FindSafari.vcproj:
- 10:35 AM Changeset in webkit [47429] by
-
- 25 edits12 adds in trunk
WebCore: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
Expose WorkerThread::workerThreadCount() for DumpRenderTree so we can write worker lifecycle tests.
Tests: fast/workers/shared-worker-lifecycle.html-disabled
fast/workers/worker-lifecycle.html
- WebCore.base.exp:
Exported WorkerThread::workerThreadCount().
- WebCore.xcodeproj/project.pbxproj:
- workers/WorkerThread.cpp:
Added tracking of the number of worker threads.
(WebCore::threadCountMutex):
(WebCore::WorkerThread::workerThreadCount):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::~WorkerThread):
- workers/WorkerThread.h:
WebKit: Need to extend DumpRenderTree to expose number of worker threads.
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
- WebKit.xcodeproj/project.pbxproj:
Added WebWorkersPrivate APIs to mac WebKit to expose workerThreadCount() for DumpRenderTree.
WebKit/gtk: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
- webkit/webkitprivate.h:
- webkit/webkitworkers.cpp: Added.
(webkit_worker_thread_count):
Exposed WebCore::WorkerThread::workerThreadCount() for the gtk version of DumpRenderTree.
WebKit/mac: Need to extend DumpRenderTree to expose number of worker threads.
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
- WebKit.exp:
Exported WebWorkersPrivate so DumpRenderTree can access it.
- Workers/WebWorkersPrivate.h: Added.
- Workers/WebWorkersPrivate.mm: Added.
(+[WebWorkersPrivate workerThreadCount]):
Added WebWorkersPrivate::workerThreadCount() API for DumpRenderTree.
WebKit/win: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
Defined/implemented COM interfaces to expose WorkerThread::workerThreadCount() for DumpRenderTree.
- ForEachCoClass.h:
Added WebWorkersPrivate.
- Interfaces/IWebWorkersPrivate.idl: Added.
- Interfaces/WebKit.idl:
Added WebWorkersPrivate.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebWorkersPrivate.cpp: Added.
Implementation of the IWebWorkersPrivate COM interface, to expose workerThreadCount() for DumpRenderTree.
(WebWorkersPrivate::QueryInterface):
(WebWorkersPrivate::AddRef):
(WebWorkersPrivate::Release):
(WebWorkersPrivate::workerThreadCount):
(WebWorkersPrivate::createInstance):
(WebWorkersPrivate::WebWorkersPrivate):
(WebWorkersPrivate::~WebWorkersPrivate):
- WebWorkersPrivate.h: Added.
WebKitTools: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
- DumpRenderTree/LayoutTestController.cpp:
(getWorkerThreadCountCallback):
(LayoutTestController::staticValues):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::workerThreadCount):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::workerThreadCount):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::workerThreadCount):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::workerThreadCount):
LayoutTests: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Reviewed by Eric Seidel.
Added simple layout tests that use the new layoutTestController.workerThreadCount() API
- fast/workers/resources/shared-worker-common.js:
Added support for "close" command to match worker-common.js.
- fast/workers/resources/worker-lifecycle.js: Added.
- fast/workers/shared-worker-lifecycle-expected.txt: Added.
- fast/workers/shared-worker-lifecycle.html-disabled: Added.
- fast/workers/worker-lifecycle-expected.txt: Added.
- fast/workers/worker-lifecycle.html: Added.
- 8:21 AM Changeset in webkit [47428] by
-
- 2 edits in trunk/WebKitSite
2009-08-18 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Mention handy --bug flag of prepare-ChangeLog script.
https://bugs.webkit.org/show_bug.cgi?id=28425
- coding/contributing.html: Add a reference for --bug flag
- 7:31 AM Changeset in webkit [47427] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix the ATK unit test.
We now support line boundaries in the get_text functions, so we
need to make sure the test has the layout we expect by giving it
enough space to fit in one line.
- tests/testatk.c: (test_webkit_atk_get_text_at_offset):
- 5:49 AM Changeset in webkit [47426] by
-
- 5 edits2 copies4 adds in trunk/LayoutTests
2009-08-18 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] These tests pass now. Fixed metrics related to default font size and added some expected files for new tests.
- platform/qt/Skipped:
- platform/qt/fast/images/animated-gif-with-offsets-expected.txt:
- platform/qt/fast/images/animated-svg-as-image-expected.txt: Added.
- platform/qt/fast/images/embed-image-expected.txt: Added.
- platform/qt/fast/images/favicon-as-image-expected.txt: Added.
- platform/qt/fast/images/object-image-expected.txt: Added.
- platform/qt/fast/images/svg-as-background-expected.txt:
- platform/qt/fast/images/svg-as-image-expected.txt:
- platform/qt/fast/images/svg-as-relative-image-expected.txt: Added.
- platform/qt/fast/images/svg-width-100p-as-background-expected.txt: Added.
- 5:44 AM Changeset in webkit [47425] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-18 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreviewed, build fix.
[Qt] Add new files I forgot to add in r47424.
- 5:23 AM Changeset in webkit [47424] by
-
- 6 edits in trunk
WebCore/ChangeLog:
2009-08-18 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Implement prefetchDNS() function.
- WebCore.pro:
- platform/qt/TemporaryLinkStubs.cpp:
WebKit/qt/ChangeLog:
2009-08-18 Markus Goetz <Markus.Goetz@nokia.com>
Reviwed by Ariya Hidayat.
[Qt] For prefecthDNS, the pre-fetching has to be enabled in the
WebSettings.
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
- 5:02 AM Changeset in webkit [47423] by
-
- 2 edits in trunk/WebKitTools
2009-08-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Initialize x and y in the GtkAllocation structure to shut up
valgrind.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):
- 12:35 AM Changeset in webkit [47422] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-18 Xan Lopez <xlopez@igalia.com>
Try to fix the GTK+ build.
- GNUmakefile.am:
- 12:33 AM Changeset in webkit [47421] by
-
- 2 edits in trunk/LayoutTests
2009-08-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Assertion failure in WebCore::RenderHTMLCanvas::layout
https://bugs.webkit.org/show_bug.cgi?id=12052
Remove string "foo" in <video> tag. This made Qt layout test fail.
Qt doesn't support video yet and the string will be rendered.
- fast/runin/nonblock-runin.html:
- 12:16 AM Changeset in webkit [47420] by
-
- 21 edits7 adds in trunk
2009-08-18 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Add --enable-datalist option.
- configure.ac:
2009-08-18 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Tests for <datalist> element.
https://bugs.webkit.org/show_bug.cgi?id=26915
- fast/forms/datalist-expected.txt: Added.
- fast/forms/datalist-nonoption-child-expected.txt: Added.
- fast/forms/datalist-nonoption-child.html: Added.
- fast/forms/datalist.html: Added.
2009-08-18 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Support for parsing <datalist> element and generating HTMLDataListElement nodes.
https://bugs.webkit.org/show_bug.cgi?id=26915
Tests: fast/forms/datalist-nonoption-child.html
fast/forms/datalist.html
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/build-generated-files.sh:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/html.css:
- html/CollectionType.h: (WebCore::):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::itemAfter):
- html/HTMLDataListElement.cpp: Added. (WebCore::HTMLDataListElement::HTMLDataListElement): (WebCore::HTMLDataListElement::~HTMLDataListElement): (WebCore::HTMLDataListElement::checkDTD): (WebCore::HTMLDataListElement::options):
- html/HTMLDataListElement.h: Added.
- html/HTMLDataListElement.idl: Added.
- html/HTMLElement.cpp: (WebCore::inlineTagList):
- html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
- html/HTMLTagNames.in:
Aug 17, 2009:
- 11:35 PM Changeset in webkit [47419] by
-
- 8 edits in trunk
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Some HTMLs are modified by make-script-test-wrappers
https://bugs.webkit.org/show_bug.cgi?id=28213
Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
re-generated wml/* and Geolocation/* .
- fast/dom/Geolocation/enabled.html:
- fast/dom/Geolocation/resources/TEMPLATE.html:
- http/tests/wml/access-target-domain-deny.html:
- http/tests/wml/access-target-path-deny.html:
- http/tests/wml/access-target.html:
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Some HTMLs are modified by make-script-test-wrappers
https://bugs.webkit.org/show_bug.cgi?id=28213
Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
re-generated wml/* and Geolocation/* .
- Scripts/make-script-test-wrappers:
- 11:26 PM Changeset in webkit [47418] by
-
- 8 edits3 adds in trunk
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
-webkit-box-orient:horizontal doesn't work on <button> tag
https://bugs.webkit.org/show_bug.cgi?id=34445
Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.
Also, added a renderName for anonymous flexible boxes.
- fast/flexbox/box-orient-button-expected.txt: Added.
- fast/flexbox/box-orient-button.html: Added.
- fast/flexbox/resources/box-orient-button.js: Added. (setBoxOrient): (gebi):
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
-webkit-box-orient:horizontal doesn't work on <button> tag
https://bugs.webkit.org/show_bug.cgi?id=34445
Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.
Also, added a renderName for anonymous flexible boxes.
Test: fast/flexbox/box-orient-button.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::createAnonymousBlock):
- rendering/RenderBlock.h:
- rendering/RenderButton.cpp: (WebCore::RenderButton::addChild): (WebCore::RenderButton::setupInnerStyle):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::renderName):
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
-webkit-box-orient:horizontal doesn't work on <button> tag
https://bugs.webkit.org/show_bug.cgi?id=34445
Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.
Also, added a renderName for anonymous flexible boxes.
- Scripts/make-script-test-wrappers:
- 11:20 PM Changeset in webkit [47417] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.pri
add THE CORRECT new file to lunix builds (you idiot).
- 11:08 PM Changeset in webkit [47416] by
-
- 2 edits in trunk/JavaScriptCore
add new file to lunix builds.
- 10:56 PM Changeset in webkit [47415] by
-
- 1 edit in trunk/JavaScriptCore/runtime/Executable.cpp
speculative interpretoid build fixeration.
- 10:49 PM Changeset in webkit [47414] by
-
- 2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore
speculative 'doze build fixeration II.
- 10:42 PM Changeset in webkit [47413] by
-
- 1 edit in trunk/JavaScriptCore/runtime/Collector.cpp
speculative 'doze build fixeration.
- 10:34 PM Changeset in webkit [47412] by
-
- 41 edits1 add in trunk/JavaScriptCore
No, silly runtime, AST nodes are not for you.
Reviewed by Sam Weinig.
We still use AST nodes (ScopeNodes, particularly FunctionBodyNodes) within
the runtime, which means that these nodes must be persisted outside of the
arena, contain both parser & runtime data, etc. This is all a bit of a mess.
Move functionality into a new FunctionExecutable class.
- API/JSCallbackFunction.cpp:
- API/JSObjectRef.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::markAggregate):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::discardBytecode):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::CodeBlock::ownerExecutable):
(JSC::CodeBlock::extractExceptionInfo):
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::functionDecl):
(JSC::CodeBlock::numberOfFunctionDecls):
(JSC::CodeBlock::addFunctionExpr):
(JSC::CodeBlock::functionExpr):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):
- bytecode/EvalCodeCache.h:
- bytecode/SamplingTool.cpp:
(JSC::SamplingTool::doRun):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
- bytecompiler/BytecodeGenerator.h:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- interpreter/CallFrameClosure.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::debug):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
- interpreter/Interpreter.h:
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::compile):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
(JSC::):
- parser/Nodes.cpp:
(JSC::FunctionBodyNode::reparseDataIfNecessary):
- parser/Nodes.h:
(JSC::EvalNode::partialDestroyData):
- parser/Parser.h:
- profiler/ProfileGenerator.cpp:
- profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
- runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
(JSC::Arguments::Arguments):
(JSC::JSActivation::copyRegisters):
- runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
- runtime/CallData.h:
(JSC::):
- runtime/Collector.cpp:
(JSC::Heap::collect):
- runtime/ConstructData.h:
(JSC::):
- runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
- runtime/Executable.cpp: Added.
(JSC::EvalExecutable::generateBytecode):
(JSC::ProgramExecutable::generateBytecode):
(JSC::FunctionExecutable::generateBytecode):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::isHostFunction):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::FunctionExecutable):
- runtime/Executable.h:
(JSC::ExecutableBase::~ExecutableBase):
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::source):
(JSC::ExecutableBase::sourceID):
(JSC::ExecutableBase::lastLine):
(JSC::ExecutableBase::usesEval):
(JSC::ExecutableBase::usesArguments):
(JSC::ExecutableBase::needsActivation):
(JSC::ExecutableBase::astNode):
(JSC::ExecutableBase::generatedJITCode):
(JSC::ExecutableBase::getExecutablePool):
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::varStack):
(JSC::EvalExecutable::evalNode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::programNode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::generatedBytecode):
(JSC::FunctionExecutable::usesEval):
(JSC::FunctionExecutable::usesArguments):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::paramString):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::body):
(JSC::FunctionExecutable::jitCode):
(JSC::FunctionExecutable::createNativeThunk):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::markChildren):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
- runtime/JSFunction.cpp:
(JSC::JSFunction::isHostFunction):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):
- runtime/JSFunction.h:
(JSC::JSFunction::executable):
(JSC::FunctionExecutable::make):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::numericCompareFunction):
- runtime/JSGlobalData.h:
- 10:12 PM Changeset in webkit [47411] by
-
- 1 edit1 delete in trunk
Revert r47399 as Eric landed it in the wrong directory.
- 8:57 PM Changeset in webkit [47410] by
-
- 15 edits12 adds in trunk
2009-08-17 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Render -webkit-mask via compositing layers when possible
https://bugs.webkit.org/show_bug.cgi?id=28414
Implement accelerated compositing of -webkit-mask, when combined
with already-composited content.
RenderLayerBacking now creates an additional GraphicsLayer for the mask contents,
and sets this as the mask on another GraphicsLayer via the setMaskLayer() method.
GraphicsLayerCA then applies the mask using -[CALayer setMask:].
The enum values for GraphicsLayerPaintingPhase were renamed to avoid the
confusion with "mask", and a new value, GraphicsLayerPaintMask, was added which
indicates that just the mask is painting.
When painting the composited mask, we need to paint with the normal compositing
mode rather than CompositeDestinationIn, so InlineFlowBox and RenderBox now consult
layer()->hasCompositedMask() to pick the mode. If the mask is composited, they no longer
need to make transparency layers.
We no longer have to throw video rendering into software because of masks.
When a masked element has composited descendants, that element needs to
become composited so that the mask can be applied via compositing.
Tests: compositing/masks/masked-ancestor.html
compositing/masks/simple-composited-mask.html
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::maskLayer): (WebCore::GraphicsLayer::setMaskLayer): (WebCore::GraphicsLayer::paintingPhase): (WebCore::GraphicsLayer::setPaintingPhase):
- platform/graphics/GraphicsLayerClient.h: (WebCore::):
- platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setMaskLayer): (WebCore::GraphicsLayerCA::recursiveCommitChanges): (WebCore::GraphicsLayerCA::commitLayerChanges): (WebCore::GraphicsLayerCA::updateMaskLayer):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hasCompositedMask):
- rendering/RenderLayer.h: (WebCore::RenderLayer::hasCompositedMask):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::destroyGraphicsLayer): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::updateMaskLayer): (WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer): (WebCore::RenderLayerBacking::setContentsNeedDisplay): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::hasMaskLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::canAccelerateVideoRendering): (WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing):
- rendering/RenderLayerCompositor.h:
- 8:31 PM Changeset in webkit [47409] by
-
- 5 edits4 adds in trunk
2009-08-17 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Layer content misplaced with compositing, z-index and overflow
https://bugs.webkit.org/show_bug.cgi?id=28361
The foreground GraphicsLayer (used to render element foreground when the element has
negative z-order children) was misplaced when there is a clipping layer (which clips
children). The foreground layer is parented under the clipping layer so that the foreground
depth-sorts with the layer's children, so its geometry needs to be computed relative to
that clipping layer.
Also clarified some FIXME comments, and corrected a debug-only layer name.
Test: compositing/geometry/clipping-foreground.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateSublayerList):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateForegroundLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- 7:58 PM Changeset in webkit [47408] by
-
- 3 edits in trunk/WebCore
Fix leaks of SVGElementInstance seen during regression tests.
Reviewed by Sam Weinig.
r47313 made TreeShared types start with a ref-count of 1, but SVGElementInstance was mistakenly
not updated to have a create method that adopted the initial reference. This lead to the instances
of SVGElementInstance allocated by SVGUseElement being leaked.
- svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::create):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::handleDeepUseReferencing):
- 6:37 PM Changeset in webkit [47407] by
-
- 6 edits in trunk/WebCore
Some cleanup towards https://bugs.webkit.org/show_bug.cgi?id=13631
Page Cache should support pages with frames.
Reviewed by Sam Weinig.
- Re-factor all remaining page cache code out of DocumentLoader, as CachedPage/CacheFrame loads are solely the responsibility of FrameLoader.
- Enhance some page cache related Logging to help development.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::identifierForInitialRequest):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
- loader/FrameLoader.h:
(WebCore::FrameLoader::isLoadingFromCachedPage):
- 6:18 PM Changeset in webkit [47406] by
-
- 2 edits in trunk/LayoutTests
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adele Peterson.
http/tests/misc/favicon-loads-with-images-disabled.html was passing on my machine
(when I ran all http tests), but failed on the bot, so adding it back to the
Skipped list.
- platform/win/Skipped:
- 6:05 PM Changeset in webkit [47405] by
-
- 4 edits in trunk/JavaScriptCore
Fix 300,000+ leaks seen during the regression tests.
Reviewed by Darin Adler.
EvalCodeCache::get was heap-allocating an EvalExecutable instance without adopting the initial reference.
While fixing this we noticed that EvalExecutable was a RefCounted type that was sometimes stack allocated.
To make this cleaner and to prevent clients from attempting to ref a stack-allocated instance, we move the
refcounting down to a new CacheableEvalExecutable class that derives from EvalExecutable. EvalCodeCache::get
now uses CacheableEvalExecutable::create and avoids the leak.
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
- runtime/Executable.h:
(JSC::CacheableEvalExecutable::create):
(JSC::CacheableEvalExecutable::CacheableEvalExecutable):
- 6:00 PM Changeset in webkit [47404] by
-
- 10 edits in trunk
REGRESSION (r47292): Prototype.js is broken by ES5 Arguments changes
https://bugs.webkit.org/show_bug.cgi?id=28341
<rdar://problem/7145615>
RS=Mark Rowe
Reverting r47292. Alas Prototype.js breaks with Arguments inheriting
from Array as ES5 attempted. Prototype.js defines $A in terms of a
function it places on (among other global objects) the Array prototype,
thus breaking $A for arrays.
- 5:58 PM Changeset in webkit [47403] by
-
- 5 edits in trunk/WebCore
2009-08-17 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
Moved implementation of isAfterContent to RenderObject
(as inline method to avoid potential performance regressions).
BUG 28376 - [Cleanup] isAfterContent() implemented twice, should be member of RenderObject
(https://bugs.webkit.org/show_bug.cgi?id=28376)
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
- rendering/RenderObject.h: (WebCore::RenderObject::isAfterContent):
- 5:49 PM Changeset in webkit [47402] by
-
- 2 edits in trunk/WebKitTools
2009-08-17 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Can no longer --reset-results of a layout test directory
https://bugs.webkit.org/show_bug.cgi?id=28336
--reset-results and --exit-after-n-failures are incompatible.
- Scripts/run-webkit-tests:
- 5:40 PM Changeset in webkit [47401] by
-
- 2 edits in trunk/LayoutTests
2009-08-17 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adele Peterson.
http/tests/misc/favicon-loads-with-images-disabled.html is passing on my
machine, trying to remove it from the Skipped list on Windows.
- platform/win/Skipped:
- 5:24 PM Changeset in webkit [47400] by
-
- 3 edits2 adds in trunk
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Assertion failure in WebCore::RenderHTMLCanvas::layout
https://bugs.webkit.org/show_bug.cgi?id=12052
Don't handle run-in if the element is not a block element.
- fast/runin/canvas-runin-expected.txt: Added.
- fast/runin/canvas-runin.html: Added.
2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Assertion failure in WebCore::RenderHTMLCanvas::layout
https://bugs.webkit.org/show_bug.cgi?id=12052
Don't handle run-in if the element is not a block element.
Test: fast/runin/nonblock-runin.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
- 5:16 PM Changeset in webkit [47399] by
-
- 1 edit6 adds in trunk
2009-08-17 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by Darin Adler.
Regression test for bug fixed in
http://codereview.chromium.org/171039. Regexps created in one
frame were not callable outside that frame.
https://bugs.webkit.org/show_bug.cgi?id=28387
- fast/regex/regexp-cross-frame-callable-expected.txt: Added.
- fast/regex/regexp-cross-frame-callable.html: Added.
- fast/regex/resources/regexp-cross-frame-callable-child.html: Added.
- 5:05 PM Changeset in webkit [47398] by
-
- 5 edits3 adds in trunk
2009-08-17 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Darin Adler.
Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
either of the arguments are not finite.
According to
http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
"If any of the arguments to createImageData() or getImageData() are
infinite or NaN, or if the createImageData() method is invoked with
only one argument but that argument is null, the method must instead
raise a NOT_SUPPORTED_ERR exception."
Test: http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html
- fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt: Added.
- fast/canvas/canvas-2d-imageData-create-nonfinite.html: Added.
- fast/canvas/resources/canvas-2d-imageData-create-nonfinite.js: Added.
2009-08-17 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Darin Adler.
Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
either of the arguments are not finite.
According to
http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
"If any of the arguments to createImageData() or getImageData() are
infinite or NaN, or if the createImageData() method is invoked with
only one argument but that argument is null, the method must instead
raise a NOT_SUPPORTED_ERR exception."
Test: http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
- 4:28 PM Changeset in webkit [47397] by
-
- 11 edits in trunk
2009-08-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add a way to release the storage lock
https://bugs.webkit.org/show_bug.cgi?id=28411
Two scripts within the same origin that are accessing LocalStorage must not do
it simultaneously, according to the spec. There are some cases, however, where
a script might want to override this behavior. navigator.getStorageUpdates()
was added for this reason:
http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex
Add this function to navigator and hook it up to DOM Storage.
- page/Navigator.cpp: (WebCore::Navigator::getStorageUpdates):
- page/Navigator.h:
- page/Navigator.idl:
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::unlock):
- storage/StorageNamespaceImpl.h:
2009-08-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add a way to release the storage lock
https://bugs.webkit.org/show_bug.cgi?id=28411
Two scripts within the same origin that are accessing LocalStorage must not do
it simultaneously, according to the spec. There are some cases, however, where
a script might want to override this behavior. navigator.getStorageUpdates()
was added for this reason:
http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex
Update the test expectations to include this new element.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/navigator-detached-no-crash-expected.txt:
- platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:
- 4:11 PM Changeset in webkit [47396] by
-
- 3 edits in trunk/WebCore
Build fix.
CFNetwork isn't present in the framework search path on Mac OS X so we can't directly include its headers.
We include CoreServices.h, the umbrella framework that contains CFNetwork, from the prefix header which
results in the CFNetwork headers being included on Mac OS X. CoreServices.h doesn't include CFNetwork.h on
Windows though so we explicitly include this header from the prefix header when on Windows.
- WebCorePrefix.h:
- platform/network/cf/DNSCFNet.cpp: Remove #include that is no longer needed.
- 3:48 PM Changeset in webkit [47395] by
-
- 2 edits in trunk/WebCore
Trying a better build fix (the previous one broke Leopard bots, although it did build for me).
- platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFNetwork.h instead.
- 3:30 PM Changeset in webkit [47394] by
-
- 2 edits in trunk/WebCore
Trying to fix Windows build.
- platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFHost.h.
- 3:17 PM Changeset in webkit [47393] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
Reviewed by Adam Roben.
New commit message:
Committed r12345: <http://trac.webkit.org/changeset/12345>
- Scripts/bugzilla-tool: (bug_comment_from_commit_text): Print out a compact, standardized commit message for both git and svn.
- 3:12 PM Changeset in webkit [47392] by
-
- 19 edits in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
Reviewed by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
WebCore: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
Reviewed by Steve Falkenburg.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/WebCoreGenerated.vcproj:
WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
Reviewed by Steve Falkenburg.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/InterfacesGenerated.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
Reviewed by Steve Falkenburg.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 3:08 PM Changeset in webkit [47391] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=28401
Add support for DNS prefetching with CFNetwork
This is just an optimization, no behavior change, so no tests.
- platform/network/cf/DNSCFNet.cpp: (WebCore::clientCallback): (WebCore::prefetchDNS): Use async CFHostStartInfoResolution() for implementation.
- 2:48 PM Changeset in webkit [47390] by
-
- 2 edits in trunk/LayoutTests
2009-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Skip new tests.
- platform/gtk/Skipped:
- 2:14 PM Changeset in webkit [47389] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=28403
Update Apache2 module list from Leopard defaults
No change in functionality, only commented out modules needed an update.
- http/conf/apache2-httpd.conf:
- 1:54 PM WikiStart edited by
- Linked to Chromium port page (diff)
- 1:43 PM Changeset in webkit [47388] by
-
- 11 edits2 adds in trunk
2009-08-17 Aaron Boodman <aa@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.
Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented redirects
for access control, so we should never redirect across origins. But in two edge cases, we were:
- Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to a resource on origin A.
- Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to another resource on origin B (this time sending access control authorization headers).
- http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-and-redirects.html: Added.
2009-08-17 Aaron Boodman <aa@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.
Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented
redirects access control, so we should never redirect across origins. But in two edge cases, we were:
- Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to a resource on origin A.
- Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to another resource on origin B (this time sending access control authorization headers).
Test: http/tests/xmlhttprequest/access-control-and-redirects.html
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): Refactor redirect checking code into shared location. (WebCore::DocumentThreadableLoader::loadRequest): Ditto. (WebCore::DocumentThreadableLoader::isAllowedRedirect): Ditto.
- loader/DocumentThreadableLoader.h:
- loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Remove ThreadableLoaderOptions::crossOriginRedirectPolicy.
- page/EventSource.cpp: (WebCore::EventSource::connect): Ditto.
- workers/Worker.cpp: Ditto. (WebCore::Worker::Worker): Ditto.
- workers/WorkerContext.cpp: Ditto. (WebCore::WorkerContext::importScripts): Ditto.
- workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): Ditto. (WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.
- workers/WorkerScriptLoader.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): Ditto.
- 1:41 PM Changeset in webkit [47387] by
-
- 2 edits in trunk/WebKit/qt
Try to fix Qt build again.
Patch by Darin Adler <Darin Adler> on 2009-08-17
- WebCoreSupport/EditorClientQt.cpp: Move "using namespace".
- 1:36 PM Changeset in webkit [47386] by
-
- 2 edits in trunk/WebCore
2009-08-17 Adam Langley <agl@google.com>
Reviewed by Dan Bernstein (relanding of r47157).
Fix a typo in platform/graphics/skia/PlatformContextSkia.cpp
This was originally fixed in r47157, however it triggered a bug in
Skia which caused Chromium Linux to fail layout tests in debug mode.
It was reverted in r47189 while we sorted it out.
The Skia bug was fixed in Skia's r321 [1] and rolled into Chromium in
Chromium's r23523. This is a reland of the original patch.
No new tests because it's a just typo fix.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
- 1:33 PM Changeset in webkit [47385] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
Reviewed by David Levin.
- Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'. (check_max_min_macros): Added. Returns level 4 error when MAX() and MIN() macros are used in header files and C++ source files. (check_style): Added call to check_max_min_macros().
- Scripts/modules/cpp_style_unittest.py: Added unit tests. (test_max_macro): Added. (test_min_macro): Added.
- 1:29 PM Changeset in webkit [47384] by
-
- 2 edits in trunk/WebCore
2009-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Protect ResourceHandle for g_file_query_info_async call, using the
same technique we already use for HTTP requests that take the soup
path.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::finishedCallback): (WebCore::):
- 1:21 PM Changeset in webkit [47383] by
-
- 2 edits in trunk/WebCore
REGRESSION (r47255): MediaWiki's (including Wikipedia) navigation pane
appears below the main content
https://bugs.webkit.org/show_bug.cgi?id=28350
Reviewed by Darin Adler.
A particular version of the MediaWiki software detects WebKit through
user agent sniffing and imports a style sheet called KHTMLFixes.css,
which contains a single rule that was meant to work around some KHTML
bug, but currently has the sole effect of causing the float containing
the main article content to extend all the way to the left and thus push
down the left navigation pane.
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet): If site specific hacks are
enabled, check if the imported style sheet is the MediaWiki
KHTMLFixes.css. If so, remove the offending rule.
- 1:20 PM Changeset in webkit [47382] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
Fix build with FAST_MALLOC_MATCH_VALIDATION enabled.
- wtf/FastMalloc.cpp: (WTF::fastMalloc): (WTF::fastCalloc): (WTF::fastRealloc):
- 1:11 PM Changeset in webkit [47381] by
-
- 5 edits1 add in trunk/WebCore/platform
2009-08-17 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Treat.
Allow image decoders to down-sample the image directly
to scaled output buffer. This can be enabled/disabled by
macro ENABLE(IMAGE_DECODER_DOWN_SAMPLING).
Only JPEG and PNG decoders are modified to support it now.
https://bugs.webkit.org/show_bug.cgi?id=28308
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
- platform/image-decoders/ImageDecoder.cpp: Added.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::setMaxNumPixels):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setSize):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- 12:56 PM Changeset in webkit [47380] by
-
- 2 edits in trunk/WebKit/qt
Try to fix Qt build.
Patch by Darin Adler <Darin Adler> on 2009-08-17
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::shouldShowDeleteInterface):
Use getAttribute(classAttr) instead of className() function.
- 12:47 PM Changeset in webkit [47379] by
-
- 2 edits in trunk/WebCore
Correct crash when processing local cancelled requests.
Reviewed by Kevin Ollivier.
No new tests. Existing fast/images/favicon-as-image.html
displays the problem.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::writeCallback): Add check for m_cancelled after
performing local-file processing.
(WebCore::ResourceHandleManager::downloadTimerCallback): Add
check for m_cancelled after performing local-file processing.
- 12:27 PM Changeset in webkit [47378] by
-
- 6 edits1 delete in trunk/WebCore
2009-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Reverts 47371, since it breaks GTK+.
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
- platform/image-decoders/ImageDecoder.cpp: Removed.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- 12:07 PM Changeset in webkit [47377] by
-
- 1 copy in tags/Safari-6531.11
New tag.
- 12:04 PM Changeset in webkit [47376] by
-
- 2 edits in trunk/WebKit/win
2009-08-17 Simon Fraser <Simon Fraser>
Speculative fix for Windows build bustage.
- DOMHTMLClasses.cpp: (DOMHTMLElement::idName):
- 12:00 PM Changeset in webkit [47375] by
-
- 11 edits in branches/safari-4-branch/WebKitTools
Merge r47320.
- 11:51 AM Changeset in webkit [47374] by
-
- 2 edits in trunk/WebCore
2009-08-17 Simon Fraser <Simon Fraser>
Build fix: fix float literals to avoid casting warnings.
- rendering/MediaControlElements.cpp:
- 11:50 AM Changeset in webkit [47373] by
-
- 7 edits2 copies in branches/safari-4-branch
Merge r47312.
- 11:43 AM Changeset in webkit [47372] by
-
- 9 edits in branches/safari-4-branch
Merge r47311.
- 11:37 AM Changeset in webkit [47371] by
-
- 6 edits1 add in trunk/WebCore
2009-08-17 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Treat.
Allow image decoders to down-sample the image directly
to scaled output buffer. This can be enabled/disabled by
macro ENABLE(IMAGE_DECODER_DOWN_SAMPLING).
Only JPEG and PNG decoders are modified to support it now.
https://bugs.webkit.org/show_bug.cgi?id=28308
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
- platform/image-decoders/ImageDecoder.cpp: Added.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::setMaxNumPixels):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setSize):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- 11:29 AM Changeset in webkit [47370] by
-
- 7 edits in trunk/WebCore
2009-08-17 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel.
Use OwnPtrs for GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=28399
Convert RenderLayerBacking and RenderLayerCompositor to use OwnPtrs
for their references to GraphicsLayers.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayer::create):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::destroyGraphicsLayer): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateInternalHierarchy): (WebCore::RenderLayerBacking::updateClippingLayers): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
- rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::graphicsLayer): (WebCore::RenderLayerBacking::clippingLayer): (WebCore::RenderLayerBacking::ancestorClippingLayer): (WebCore::RenderLayerBacking::foregroundLayer): (WebCore::RenderLayerBacking::parentForSublayers): (WebCore::RenderLayerBacking::childForSuperlayers):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::~RenderLayerCompositor): (WebCore::RenderLayerCompositor::rootPlatformLayer): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): (WebCore::RenderLayerCompositor::destroyRootPlatformLayer):
- rendering/RenderLayerCompositor.h:
- 10:44 AM Changeset in webkit [47369] by
-
- 6 edits in trunk/WebCore
2009-08-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Reset InjectedScript styles cache on document change.
- inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::resetInjectedScript):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/InjectedScript.js: (InjectedScript._reset):
- 10:41 AM Changeset in webkit [47368] by
-
- 2 edits in trunk/WebCore
- rendering/MediaControlElements.cpp: Removed unneeded include of CString.h,
resorted includes, renamed "doc" to "document" and fixed formatting.
Reviewed by Sam Weinig.
- 10:30 AM Changeset in webkit [47367] by
-
- 12 edits in trunk/WebCore
Removed functions now unneeded due to use of Reflect to create
language bindings.
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
Get at usemap attribute directly.
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
Get at id attribute directly.
- editing/EditorCommand.cpp:
(WebCore::executeInsertHorizontalRule): Ditto.
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::dir): Get at dir attribute of body directly.
(WebCore::HTMLDocument::setDir): Ditto.
- html/HTMLElement.cpp: Deleted unused functions.
- html/HTMLElement.h: Ditto.
- html/HTMLImageElement.cpp: Deleted unused functions.
(WebCore::HTMLImageElement::alt): Changed to return const AtomicString&.
(WebCore::HTMLImageElement::addSubresourceAttributeURLs): Changed to
get at usemap attribute directly, but added a FIXME because although
it is what the old code did, it looks to not be entirely correct.
- html/HTMLImageElement.h: Deleted unused functions.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString): Get at alt attribute directly.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageMap): Get at usemap attribute directly.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer): Get at id attribute
directly.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Removed
explicit HTMLNames namespace qualification.
- 10:12 AM Changeset in webkit [47366] by
-
- 2 edits in trunk/WebKit/mac
Use a HashMap instead of a list of if statements for the command
name exception map.
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.
- WebView/WebHTMLView.mm:
(createSelectorExceptionMap): Added.
(commandNameForSelector): Use createSelectorExceptionMap.
- 10:03 AM Changeset in webkit [47365] by
-
- 2 edits in trunk/WebCore
- dom/Document.cpp:
(WebCore::Document::setFocusedNode): Removed unneeded calls
to RefPtr::get.
Reviewed by Sam Weinig.
- 9:24 AM Changeset in webkit [47364] by
-
- 2 edits in trunk/WebCore
2009-08-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Discard DOM Node bindings on any document change.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
- 8:57 AM Changeset in webkit [47363] by
-
- 23 edits1 delete in trunk/WebCore
2009-08-13 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Improve Cookie DataGrid to Show Hidden Data
https://bugs.webkit.org/show_bug.cgi?id=28269
- English.lproj/localizedStrings.js: DataGrid Headers "Name", "Value", "Size", ...
- WebCore.gypi: added missing files
Implemented Bindings for InspectorController.deleteCookie(name)
- inspector/InspectorBackend.idl:
- bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies): (WebCore::JSInspectorBackend::deleteCookie):
v8 Bindings Stubs
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
Removed WebInspector.Cookie
- inspector/front-end/Cookie.js: Removed.
- inspector/front-end/inspector.html:
- inspector/front-end/WebKit.qrc:
Improved DataGrid and Kept Fallback Behavior for Platforms that don't
yet provide access to raw cookies.
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.buildCookies): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype.fallbackUpdate.callback): (WebInspector.CookieItemsView.prototype.fallbackUpdate): (WebInspector.CookieItemsView.prototype.fallbackBuildCookiesFromString): (WebInspector.CookieItemsView.prototype.fallbackDataGridForCookies): (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
Interaction with the page through Injected Script (for fallback behavior)
- inspector/front-end/DOMAgent.js: (InspectorController.getCookies):
- inspector/front-end/InjectedScript.js: (InjectedScript.setStyleProperty): style fix (InjectedScript.getCookies):
Allow alignment of text inside DataGrids.
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGridNode.prototype.createCell):
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
- inspector/front-end/inspector.css:
Added deleteCookie(., ., String name)
Modified getRawCookies to return a bool to know if its implemented
- platform/CookieJar.h:
Implemented deleteCookie for Macs
- platform/mac/CookieJar.mm: (WebCore::getRawCookies): (WebCore::deleteCookie):
Stub Implementations for Other Platforms
- platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- 8:37 AM Changeset in webkit [47362] by
-
- 2 edits in trunk/WebCore
Blind build fix for Leopard.
Patch by Adam Treat <adam.treat@torchmobile.com> on 2009-08-17
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::adjustLineToPixelBoundaries):
- 8:07 AM Changeset in webkit [47361] by
-
- 5 edits in trunk
Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28268
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::adjustLineToPixelBoundaries):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- 7:19 AM Changeset in webkit [47360] by
-
- 2 edits in trunk/WebCore
Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContextCG.cpp
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=28268
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipOutEllipseInRect):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setCompositeOperation):
- 7:01 AM Changeset in webkit [47359] by
-
- 5 edits in trunk/WebCore
Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContext.cpp/h, GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=28268
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(GraphicsContext::drawText):
(GraphicsContext::initFocusRing):
(GraphicsContext::focusRingBoundingRect):
(GraphicsContext::drawImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::toCairoOperator):
- platform/graphics/qt/GraphicsContextQt.cpp:
- 6:51 AM Changeset in webkit [47358] by
-
- 2 edits in trunk/WebKitTools
Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
WebKit style guide.
Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-10
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=28161
- DumpRenderTree/qt/jsobjects.cpp:
(findFrameNamed):
(LoadItem::invoke):
(LayoutTestController::provisionalLoad):
(LayoutTestController::timerEvent):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::numberOfActiveAnimations):
(EventSender::keyDown):
(EventSender::frameUnderMouse):
(TextInputController::doCommand):
- 3:38 AM Writing Layout Tests for DumpRenderTree edited by
- make-js-test-wrappers renamed to make-script-test-wrappers (diff)
- 12:43 AM Changeset in webkit [47357] by
-
- 3 edits in trunk/WebCore
Change HTMLAreaElement to use OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=28386
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::HTMLAreaElement): Removed unneeded initializer.
(WebCore::HTMLAreaElement::~HTMLAreaElement): Removed unneeded delete call.
(WebCore::HTMLAreaElement::parseMappedAttribute): Use the set function
instead of deletion followed by assignment.
- html/HTMLAreaElement.h: Use OwnArrayPtr.
- 12:41 AM Changeset in webkit [47356] by
-
- 2 edits in trunk/WebCore
Fix Windows build.
Patch by Darin Adler <Darin Adler> on 2009-08-17
- dom/make_names.pl: Add back cast to (void*) needed on Windows.
- 12:38 AM Changeset in webkit [47355] by
-
- 5 edits in trunk/WebCore
Move noResize from HTMLFrameElementBase to HTMLFrameElement
https://bugs.webkit.org/show_bug.cgi?id=28384
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.
- html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::HTMLFrameElement): Initialize m_noResize.
(WebCore::HTMLFrameElement::parseMappedAttribute): Set m_noResize to true
here if noresizeAttr is changed. This code was moved here from
HTMLFrameElementBase, but I added some FIXME comments.
(WebCore::HTMLFrameElement::setNoResize): Set the attribute based on
boolean argument. Moved here from HTMLFrameElementBase.
- html/HTMLFrameElement.h: Moved noResize, setNoResize, and m_noResize
here from HTMLFrameElementBase.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed m_noResize.
(WebCore::HTMLFrameElementBase::parseMappedAttribute): Removed code to parse
noresizeAttr.
- html/HTMLFrameElementBase.h: Removed noResize, setNoResize, and m_noResize.
- 12:35 AM Changeset in webkit [47354] by
-
- 5 edits in trunk/WebCore
Tweak HTMLFrameElementBase so that m_URL can be private
https://bugs.webkit.org/show_bug.cgi?id=28385
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.
- html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::rendererIsNeeded): Removed m_URL argument.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed): Use m_URL instead of
taking an argument.
(WebCore::HTMLFrameElementBase::openURL): Removed m_URL argument.
- html/HTMLFrameElementBase.h: Removed argument from isURLAllowed function.
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::rendererIsNeeded): Removed m_URL argument.
- 12:14 AM Changeset in webkit [47353] by
-
- 3 edits in trunk/WebCore
HTMLViewSourceDocument should use smart pointers
https://bugs.webkit.org/show_bug.cgi?id=28378
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): Don't initialize
pointers any more since RefPtr starts 0 by default.
(WebCore::HTMLViewSourceDocument::createContainingTable): Use more specific
types for local variables.
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Return a PassRefPtr,
and use a RefPtr of a more specific type for a local variable.
(WebCore::HTMLViewSourceDocument::addLine): Use more specific types for local
variables, and use RefPtr as well.
(WebCore::HTMLViewSourceDocument::addLink): Return a PassRefPtr, and use a
RefPtr of a more specific type for a local variable.
- html/HTMLViewSourceDocument.h: Change return types to PassRefPtr and
data member types to RefPtr.
- 12:12 AM Changeset in webkit [47352] by
-
- 5 edits in trunk/WebCore
DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.
Convert 4 more classes. These are classes I am going to make other changes
to soon, so it's good to have this use of Reflect in the IDL out of the way.
- html/HTMLEmbedElement.idl: Use Reflect for many attributes.
- html/HTMLFrameElement.idl: Ditto.
- html/HTMLIFrameElement.idl: Ditto.
- html/HTMLObjectElement.idl: Ditto.
- 12:09 AM Changeset in webkit [47351] by
-
- 2 edits in trunk/WebCore
Script to create element factory needs changes to accommodate calling create
https://bugs.webkit.org/show_bug.cgi?id=28379
Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.
- dom/make_names.pl: Tweak formatting. Remove lots of unneeded quotes
around names used inside {}. Added new createWithNew property for tags
that makes the factory use a create function instead of calling new.
Renamed functions with initialize in their name to have default in their
name, since they return an array full of default values and don't themselves
initialize anything.
