Context Navigation

← Previous Period
Next Period →

Timeline

Aug 23, 2009:

11:00 PM Changeset in webkit [47698] by krit@webkit.org

6 edits in trunk/WebCore

2009-08-23 Dirk Schulze <krit@webkit.org>

Reviewed by Mark Rowe.

Code clean-up and build fix for filters enabled builds. Moved SVGNames.h
into #if ENABLE(SVG) for Document.cpp and added SVGNames.h to the other
files. They are needed there after r47688.

dom/Document.cpp:
svg/SVGComponentTransferFunctionElement.h:
svg/SVGFELightElement.h:
svg/SVGFEMergeNodeElement.h:
svg/SVGFilterPrimitiveStandardAttributes.h:

8:44 PM Changeset in webkit [47697] by kov@webkit.org

8 edits in trunk

WebCore:

2009-08-23 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed, build fix for make distcheck on GTK+.

GNUmakefile.am: Added files needed for the build.
bindings/js/JSDOMWindowCustom.cpp: Protect SharedWorker include with #if clause.
bindings/js/JSEventTarget.cpp: Dito.
dom/Document.cpp: Dito.
loader/FrameLoader.cpp: Dito.

JavaScriptCore:

2009-08-23 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix for make distcheck.

GNUmakefile.am: Added files required for the build.

2:42 PM Changeset in webkit [47696] by eric@webkit.org

3 edits in trunk/WebCore

2009-08-23 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Inspector: Throws an Error on "null"
https://bugs.webkit.org/show_bug.cgi?id=28665

inspector/front-end/InjectedScript.js: (InjectedScript.evaluate):

12:49 PM Changeset in webkit [47695] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-08-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often

https://bugs.webkit.org/show_bug.cgi?id=28666

inspector/front-end/InjectedScript.js: (InjectedScript.getProperties): (InjectedScript.createProxyObject):

12:24 PM Changeset in webkit [47694] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-08-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update editing-behavior property here too.

webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):

10:04 AM Changeset in webkit [47693] by jmalonzo@webkit.org

2 edits in trunk/WebKit/gtk

2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubberstamped by Gustavo Noronha.

Fix regressions introduced by http://trac.webkit.org/changeset/47690.

Update the setting whenever the property gets set.

webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):

3:08 AM Changeset in webkit [47692] by jmalonzo@webkit.org

2 edits in trunk/WebKitTools

2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] API for disabling local file access to web URLs
https://bugs.webkit.org/show_bug.cgi?id=28663

Enable this setting for DRT.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):

2:05 AM Changeset in webkit [47691] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Not reviewed. Skip new tests from
http://trac.webkit.org/changeset/47678 and the appcache HTTP
authentication tests (https://bugs.webkit.org/show_bug.cgi?id=28668)

platform/gtk/Skipped:

1:45 AM Changeset in webkit [47690] by jmalonzo@webkit.org

3 edits in trunk/WebKit/gtk

2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] API for disabling local file access to web URLs
https://bugs.webkit.org/show_bug.cgi?id=28663

Add a setting to enable or disable file access to web URLs. It's
disabled by default for security reasons.

webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
webkit/webkitwebview.cpp: (webkit_web_view_update_settings):

12:18 AM Changeset in webkit [47689] by xan@webkit.org

2 edits in trunk/WebCore

2009-08-22 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly
https://bugs.webkit.org/show_bug.cgi?id=28345

When doing the conversion between cairo_surface_t* and GdkPixbuf*
account for the differences in the respective formats' in-memory
image format.

platform/graphics/gtk/ImageGtk.cpp: (WebCore::getCairoSurfacePixel): (WebCore::getGdkPixbufPixel): (WebCore::BitmapImage::getGdkPixbuf):

Aug 22, 2009:

11:55 PM Changeset in webkit [47688] by Darin Adler

43 edits in trunk/WebCore

Make DOM classes start with a reference count of 1, like all other RefCounted

Patch by Darin Adler <Darin Adler> on 2009-08-22
Reviewed by Oliver Hunt.

Next step: Element, HTMLElement, HTMLAnchorElement, HTMLAppletElement,
HTMLAreaElement, HTMLEmbedElement, HTMLFrameElement, HTMLIFrameElement,
HTMLObjectElement, HTMLPlugInElement, HTMLPlugInImageElement.

DerivedSources.make: Fix error seen every time we build by escaping the $

in the build rule, since you have to use $$ for that in make.

WebCore.base.exp: Updated.

bindings/objc/DOM.mm:

Added now-needed include of SVGNames.h.

dom/Document.cpp: Added now-needed include of SVGNames.h.

(WebCore::Document::createElement): Use create instead of new.

dom/Element.cpp:

(WebCore::Element::Element): Added ConstructionType argument so the caller
can determine whether this starts with a reference count of either 0 or 1.
Later we will remove this again once they are all 1.
(WebCore::Element::create): Added.

dom/Element.h: Added create and made constructor protected.

dom/StyledElement.cpp:

(WebCore::StyledElement::StyledElement): Added ConstructionType argument.

dom/StyledElement.h: Made many functions protected or private, including

the constructor.

dom/make_names.pl: Use create to create the base elements HTMLElement,

SVGElement, and WMLElement.

editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply): Use create instead of new.

editing/UnlinkCommand.cpp:

(WebCore::UnlinkCommand::doApply): Ditto.

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::create): Added.

html/HTMLAnchorElement.h: Made constructor protected and added create.

Also made m_rootEditableElementForSelectionOnMouseDown a RefPtr.

html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::create): Added.

html/HTMLAppletElement.h: Made constructor private and added create.

html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::create): Added.

html/HTMLAreaElement.h: Made constructor private and added create.

html/HTMLElement.cpp:

(WebCore::HTMLElement::create): Added.

html/HTMLElement.h: Made constructor protected and added create.

Made other functions protected and private. Also added inline
definition of constructor.

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::create): Added.

html/HTMLEmbedElement.h: Made constructor private and added create.

Made other functions private.

html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::create): Added.
(WebCore::HTMLFrameElement::parseMappedAttribute):

html/HTMLFrameElement.h: Made constructor private and added create.

Made other functions private.

html/HTMLFrameElementBase.h: Made functions protected and private.

html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Pass
CreateElement so reference count starts at 1.

html/HTMLFrameOwnerElement.h: Made functions protected and private.

html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::create): Added.

html/HTMLIFrameElement.h: Made constructor private and added create.

Made other functions private.

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::create): Added.
(WebCore::HTMLObjectElement::containsJavaApplet): Changed while loop
into a for loop and tweaked formatting.

html/HTMLObjectElement.h: Made constructor private and added create.

Made other functions private.

html/HTMLPlugInElement.h: Made constructor protected.

Made other functions protected and private.

html/HTMLPlugInImageElement.h: Made constructor and another function

protected.

html/HTMLTagNames.in: Removed createWithNew from all classes that

now have create functions. Moved conditional noscript to a separate
paragraph.

html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Use create.
(WebCore::HTMLViewSourceDocument::addLink): Ditto.

page/DragController.cpp:

(WebCore::documentFragmentFromDragData): Ditto.

svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement): Pass CreateElementZeroRefCount
so reference count still starts at 0. Will change this class later.
(WebCore::SVGElement::create): Added.

svg/SVGElement.h: Added create, made constructor protected, and

made other functions protected and private. Removed unneeded
SVGNames.h include.

svg/SVGExternalResourcesRequired.h: Added now-needed SVGNames.h

include.

svg/SVGStopElement.h: Added now-needed SVGNames.h include.

Made functions private.

wml/WMLElement.cpp:

(WebCore::WMLElement::WMLElement): Pass CreateElementZeroRefCount
so reference count still starts at 0. Will change this class later.
(WebCore::WMLElement::create): Added.

wml/WMLElement.h: Added create and made constructor protected.

wml/WMLTagNames.in: Removed createWithNew from WMLElement.

11:36 PM Changeset in webkit [47687] by xan@webkit.org

6 edits in trunk/WebKit/gtk

2009-08-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=28154
clicking below end of text in a textarea moves cursor to wrong position

Expose the EditingBehavior setting and set it by default to Mac,
since that what matches the GTK+ default behavior.

webkit/webkitprivate.cpp: (WebKit::core):
webkit/webkitprivate.h:
webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
webkit/webkitwebsettings.h:
webkit/webkitwebview.cpp: (webkit_web_view_update_settings):

10:04 PM Changeset in webkit [47686] by mjs@apple.com

2 edits in trunk/JavaScriptCore

REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC
https://bugs.webkit.org/show_bug.cgi?id=28655

Reviewed by Mark Rowe.

runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction): Initialize properly with a VPtrHackExecutable.

wtf/Platform.h:

9:43 PM Changeset in webkit [47685] by abarth@webkit.org

11 edits in trunk

WebKit/mac: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22

Misc/WebKitVersionChecks.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebKit/qt: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22

Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

WebKit/win: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22

WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

WebKitTools: Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22

DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

9:24 PM Changeset in webkit [47684] by abarth@webkit.org

11 edits in trunk

2009-08-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

Misc/WebKitVersionChecks.m:
WebView/WebPreferences.mm: (+[WebPreferences initialize]):

2009-08-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

Api/qwebsettings.cpp: (QWebSettings::QWebSettings):

2009-08-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

2009-08-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

A bunch of our LayoutTests rely on our old behavior, so we explicitly
grant local files universal access during testing. Mainly, these tests
involve making XMLHttpRequests for data URLs.

DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):
DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

5:48 PM Changeset in webkit [47683] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

5:47 PM Changeset in webkit [47682] by mrowe@apple.com

1 copy in tags/Safari-6531.16

New tag.

5:47 PM Changeset in webkit [47681] by mrowe@apple.com

3 edits in branches/safari-4-branch/WebCore

Merge r47679.

5:47 PM Changeset in webkit [47680] by mrowe@apple.com

2 edits in branches/safari-4-branch/WebCore

Merge r47663.

5:43 PM Changeset in webkit [47679] by adele@apple.com

3 edits in trunk/WebCore

Fix for <rdar://problem/7161656> Crash in RenderObject::destroy when using custom scrollbars

Reviewed by Anders Carlsson.

Custom scrollbars normally get detached when a document gets detached. In this case, a crash was happening when the document had gone into the page cache
and then was getting destroyed without proper scrollbar teardown. This change makes custom scrollbars get detached when the document enters the cache.

I couldn't figure out a way to reliably cause this to happen in DRT, since the reproducible case relies on the cache being purged at a particular time.

history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Detach custom scrollbars when the CachedFrame is created. They'll get reattached when the document comes out of the page cache.
page/FrameView.cpp: (WebCore::FrameView::~FrameView): Added some asserts to catch this problem earlier in debug builds.

4:26 PM Changeset in webkit [47678] by hyatt@apple.com

4 edits
74 adds in trunk

WebCore: Make sure self-collapsing blocks that clear floats are still able to collapse their bottom margins with
the bottom of their parent blocks. The old code prevented all collapsing, but all CSS2.1 states is that:
"An element that has had clearance applied to it never collapses its top margin with its parent block's bottom margin."

Reviewed by Dan Bernstein.

The implication is that the bottom margin can still collapse, and the block-inside-inline form of
fast/block/margin-collapse/025.html (added as fast/block/margin-collapse/block-inside-inline/025.html) depends
on it to get comparable results.

Added block-inside-inline tests (a whole slew of them) in fast/block/margin-collapse/block-inside-inline/

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::handleBottomOfBlock):

rendering/RenderBlock.h:

(WebCore::RenderBlock::MarginInfo::clearMargin):
(WebCore::RenderBlock::MarginInfo::canCollapseBottomWithChildren):

LayoutTests: Add a bunch of tests for the block-inside-inline cases of margin-collapsing. The same test
suite but converted to wrap all the blocks inside inlines to make sure they still collapse
the same way.

Reviewed by Dan Bernstein.

fast/block/margin-collapse/block-inside-inline: Added.
fast/block/margin-collapse/block-inside-inline/001.html: Added.
fast/block/margin-collapse/block-inside-inline/002.html: Added.
fast/block/margin-collapse/block-inside-inline/003.html: Added.
fast/block/margin-collapse/block-inside-inline/004.html: Added.
fast/block/margin-collapse/block-inside-inline/005.html: Added.
fast/block/margin-collapse/block-inside-inline/006.html: Added.
fast/block/margin-collapse/block-inside-inline/010.html: Added.
fast/block/margin-collapse/block-inside-inline/011.html: Added.
fast/block/margin-collapse/block-inside-inline/012.html: Added.
fast/block/margin-collapse/block-inside-inline/015.html: Added.
fast/block/margin-collapse/block-inside-inline/016.html: Added.
fast/block/margin-collapse/block-inside-inline/017.html: Added.
fast/block/margin-collapse/block-inside-inline/018.html: Added.
fast/block/margin-collapse/block-inside-inline/019.html: Added.
fast/block/margin-collapse/block-inside-inline/020.html: Added.
fast/block/margin-collapse/block-inside-inline/021.html: Added.
fast/block/margin-collapse/block-inside-inline/022.html: Added.
fast/block/margin-collapse/block-inside-inline/025.html: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.checksum: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.png: Added.
platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.

3:56 PM Changeset in webkit [47677] by mrowe@apple.com

4 edits
1 add in trunk/WebKitTools

Bring signed updates to the Mac nightly builds.

Rubber-stamped by Anders Carlsson.

WebKitLauncher/Info.plist:
WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
WebKitLauncher/WebKitNightlyEnablerSparkle.m:

(initializeSparkle):

WebKitLauncher/nightly.webkit.org.public.pem: Added.

10:54 AM Changeset in webkit [47676] by Chris Fleizach

1 edit
1 copy
1 move in trunk/LayoutTests

Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606

Fixing LayoutTest bustage.

The SnowLeopard results are the latest, so they need to move to platform/mac
The Tiger/Leopard results will default to the SnowLeopard results, so we need to move
the current test from platform/mac to platform/mac-leopard

platform/mac-leopard/accessibility/aria-roles-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-roles-expected.txt.
platform/mac-snowleopard/accessibility/aria-roles-expected.txt: Removed.
platform/mac/accessibility/aria-roles-expected.txt: Replaced with LayoutTests/platform/mac-snowleopard/accessibility/aria-roles-expected.txt.

10:03 AM Changeset in webkit [47675] by Chris Fleizach

5 edits
4 adds in trunk

WebCore: Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606

Reviewed by Darin Adler.

Test: platform/mac-snowleopard/accessibility/aria-list-and-listitem.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::isUnorderedList):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::RoleEntry::):

LayoutTests: Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606

Reviewed by Darin Adler.

Also added a SnowLeopard specific result for aria-roles-expected.

platform/mac-snowleopard/accessibility: Added.
platform/mac-snowleopard/accessibility/aria-list-and-listitem-expected.txt: Added.
platform/mac-snowleopard/accessibility/aria-list-and-listitem.html: Added.
platform/mac-snowleopard/accessibility/aria-roles-expected.txt: Added.

9:32 AM Changeset in webkit [47674] by mitz@apple.com

3 edits in trunk/WebCore

Clean up fill image geometry calculation
https://bugs.webkit.org/show_bug.cgi?id=28652

Reviewed by Darin Adler.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize): Renamed

calculateBackgroundSize() to this. Replaced separate scaledWidth and
scaledHeight parameters with a single scaledSize parameter. Renamed
parameters and local variables.

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Changed