⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 28, 2009:

11:56 PM Changeset in webkit [47882] by jmalonzo@webkit.org
  • 6 edits in trunk

2009-08-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Gtk Build broken for OSX Quartz
​https://bugs.webkit.org/show_bug.cgi?id=28727

Define XP_UNIX for non-Win OS builds.

  • GNUmakefile.am:

Check for XP_UNIX instead of GTK or X11 to ease building of the Gtk
port in Mac and Unix/Linux.

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::getValue): (WebCore::PluginView::init):
6:51 PM Changeset in webkit [47881] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-08-28 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue needs a master process
​https://bugs.webkit.org/show_bug.cgi?id=28040

Add a bugzilla-tool commit-queue command
Keeps per-bug logs, but doesn't yet upload them anywhere.

  • Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
  • Scripts/modules/buildbot.py: remove noisy log message
  • Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
4:37 PM Changeset in webkit [47880] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Define _CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1
to automatically use secure versions of C runtime lib calls on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=28824

Reviewed by Adam Roben.

  • win/tools/vsprops/common.vsprops:
4:31 PM Changeset in webkit [47879] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Re-skipping tests that still fail on the bot.

  • platform/gtk/Skipped:
4:13 PM Changeset in webkit [47878] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unskip some passing tests, skip new tests that are failing.

  • platform/gtk/Skipped:
4:08 PM Changeset in webkit [47877] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-08-28 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe

Wrap WebkitCSSTransformValues in the correct class of DOM wrapper.
​https://bugs.webkit.org/show_bug.cgi?id=27727

When fetching the DOM wrapper for a WebkitCSSTransformValue (which is a kind of
CSSValueList), we need to ask the value list whether it's a WebkitCSSTransformValue,
because there is not a unique enum value for WebkitCSSTransformValue.

  • bindings/objc/DOMCSS.mm: (kitClass):
3:09 PM Changeset in webkit [47876] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=28308
Fix some warnings introduced by r47381.

Reviewed by Jan Michael Alonzo.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::convertCMYKToRGBA):
(WebCore::convertRGBToRGBA):

3:03 PM Changeset in webkit [47875] by adachan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=21442
Make sure filesystemPathFromUrlOrTitle() returns a string with length
<= MAX_PATH - 1.

  • platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle):
2:44 PM Changeset in webkit [47874] by ojan@chromium.org
  • 5 edits
    1 copy
    2 deletes in trunk/WebCore

2009-08-28 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding Chromium's VFS for Linux and Mac.

​https://bugs.webkit.org/show_bug.cgi?id=28750

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase): (WebCore::SQLiteFileSystem::deleteDatabaseFile):
  • platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Removed.
  • platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Removed.
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
2:16 PM Changeset in webkit [47873] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

set-dangerous-headers.html shouldn't set allowed header to same value
as forbidden headers. AUTHORIZATION is an allowed header, and the
value is being set to "foobar" like the forbidden headers, which causes
the test to fail when run using http server that doesn't strip the
AUTHORIZATION header.
​https://bugs.webkit.org/show_bug.cgi?id=28818

Patch by Julie Parent <​jparent@chromium.org> on 2009-08-28
Reviewed by Alexey Proskuryakov.

  • http/tests/xmlhttprequest/set-dangerous-headers.html:
11:59 AM Changeset in webkit [47872] by Dimitri Glazkov
  • 8 edits in trunk/WebCore

2009-08-28 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Made bindings use Node::setOnEvent functions for Node descendants
instead of Node::setAttributeEventListener.

Node::setAttributeEventListener is an internal function and
doesn't do the forwarding to DOM window that is required for some
HTML elements.
​https://bugs.webkit.org/show_bug.cgi?id=28709

Tests added in ​http://trac.webkit.org/changeset/47326 now pass with V8.

  • bindings/scripts/CodeGeneratorV8.pm: Now generates EventListener accessors for Node descendants instead of using custom callbacks.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener): Moved from V8NodeCustom.cpp.
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Fixed a bug in signature.
  • bindings/v8/V8Utilities.cpp: (WebCore::createHiddenDependency): (WebCore::removeHiddenDependency): Changed signature to accept Handle instead of Local.
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Removed custom callbacks for EventListener accessors.
11:40 AM Changeset in webkit [47871] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-28 Ben Murdoch <​benm@google.com>

​https://bugs.webkit.org/show_bug.cgi?id=28803


Implements V8CustomVoidCallback reporting any exceptions that were thrown from the callback function.

  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback): Checks if the callback raised an exception and reports it to WebCore if so.
11:34 AM Changeset in webkit [47870] by Chris Fleizach
  • 4 edits in trunk/WebKit

WebKit: update-webkit-localizable-strings script can no longer complete
​https://bugs.webkit.org/show_bug.cgi?id=28792

Reviewed by John Sullivan.

  • English.lproj/Localizable.strings:

WebKit/mac: update-webkit-localizable-strings script can no longer complete
​https://bugs.webkit.org/show_bug.cgi?id=28792

Reviewed by John Sullivan.

  • WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

11:29 AM Changeset in webkit [47869] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

Not reviewed (build fix).

  • platform/graphics/qt/ImageDecoderQt.cpp: Accidentally added some spaces.

(WebCore::ImageDecoder::create):
(WebCore::ImageDecoderQt::ImageDecoderQt):

  • platform/graphics/qt/ImageDecoderQt.h: Make constructor public so factory function can access it (this seemed better than making ImageDecoder a friend).
11:08 AM Changeset in webkit [47868] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=27965
Move ImageDecoder creation function to a factory function on
ImageDecoder. This is arguably where it makes the most sense anyway,
and it will (soon) allow ImageSourceQt.cpp to have one less dedicated
function.

Reviewed by Eric Seidel.

  • platform/graphics/ImageSource.cpp:
  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoder::create):

  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/qt/ImageSourceQt.cpp:

(WebCore::ImageSource::setData):

  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
11:00 AM Changeset in webkit [47867] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=28785
Combine duplicated code from ImageDecoder*.cpp into the main
ImageDecoder.cpp.

Reviewed by Eric Seidel.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):

  • platform/image-decoders/cairo/ImageDecoderCairo.cpp:
  • platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
  • platform/image-decoders/wx/ImageDecoderWx.cpp:
8:24 AM Changeset in webkit [47866] by kov@webkit.org
  • 25 edits
    1 add in trunk

2009-08-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Adding files for the new test for window-related issues (starting
with scrollbar policy).

  • GNUmakefile.am:

WebCore

2009-08-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Override setScrollbarModes to correctly forward scrollbar modes
policy changes to client code, via a new platform-specific method,
scrollbarsPolicyDidChange.

  • page/ChromeClient.h: (WebCore::ChromeClient::scrollbarsPolicyDidChange):
  • platform/ScrollView.cpp: (WebCore::ScrollView::createScrollbar):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setScrollbarModes):

WebKit/gtk

2009-08-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Add properties and a signal to report scrollbar policy changes to
client code, and a default handler that does the right thing when
using GtkScrolledWindow.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scrollbarsModeDidChange):
  • WebCoreSupport/ChromeClientGtk.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_property): (webkit_web_frame_class_init): (webkit_web_frame_get_horizontal_scrollbar_policy): (webkit_web_frame_get_vertical_scrollbar_policy):
  • webkit/webkitwebframe.h:
  • tests/testwindow.c: Added. (load_finished_cb): (test_webkit_window_scrollbar_policy): (main):

WebKit/*

Added empty implementation of new ChromeClient method.

8:12 AM Changeset in webkit [47865] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-08-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Add view source mode API
​https://bugs.webkit.org/show_bug.cgi?id=28805

Implement setter and getter for "view source" mode.

  • webkit/webkitwebview.cpp: (webkit_web_view_set_view_source_mode): (webkit_web_frame_get_view_source_mode):
  • webkit/webkitwebview.h:
7:27 AM Changeset in webkit [47864] by jmalonzo@webkit.org
  • 4 edits
    5 adds in trunk

2009-08-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[GTK] Geolocation needs permission API before being enabled by default

Unskip the Geolocation tests and rebaseline three DOM tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Added.
  • platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Added.

Build the Gtk port with geolocation enabled. This option is only
enabled for the buildbot. The autotools option will be enabled by
default once the permissions API is implemented.

  • Scripts/build-webkit:
6:58 AM Changeset in webkit [47863] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

[Qt/Mac] Un-blacklist the QuickTime plugin

Patch by Cédric Luthi <​cedric.luthi@gmail.com> on 2009-08-28
Reviewed by Tor Arne Vestbø

​https://bugs.webkit.org/show_bug.cgi?id=28768

Now that the drawing model is properly negotiated, there is no need the
blacklist the QuickTime plugin anymore.

This revealed a bug in PluginView::performRequest: it should not initiate a
request if the plugin has been stopped, which is what happens when a plugin
only supports the QuickDraw drawing model.

  • plugins/PluginView.cpp:
  • plugins/mac/PluginPackageMac.cpp:
6:42 AM Changeset in webkit [47862] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-08-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

Set DOM agent document to 0 in InspectorController::close to
make DOM agent remove DOM listeners from the inspected document.

Replace windowVisible checks with m_frontend checks to as inspector
window lives in a different process in Chromium while frontend proxy
is in the inspected page process.

​https://bugs.webkit.org/show_bug.cgi?id=28800

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspect): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::close): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::addProfile):
  • inspector/InspectorController.h:
6:23 AM Changeset in webkit [47861] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-08-28 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Remove dependency of SummaryBar on WebInspector.resourceCategories.

​https://bugs.webkit.org/show_bug.cgi?id=28801

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get categories):
  • inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.update):
5:28 AM Changeset in webkit [47860] by ariya@webkit.org
  • 41 edits in trunk/LayoutTests

2009-08-28 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Adapt expecteds of css2.1/t0401* to new metrics. Remove these files from Skipped. (39 files)

  • platform/qt/Skipped:
  • platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
  • platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
  • platform/qt/css2.1/t040103-case-00-b-expected.txt:
  • platform/qt/css2.1/t040103-case-01-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
  • platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
  • platform/qt/css2.1/t040103-ident-00-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-01-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-02-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-03-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-04-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-05-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-06-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-07-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-08-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-09-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-10-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-11-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-12-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-13-c-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
  • platform/qt/css2.1/t040105-import-00-b-expected.txt:
  • platform/qt/css2.1/t040105-import-01-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:
2:00 AM Changeset in webkit [47859] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-08-28 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed (patching in l18n change that was missing due to
the git binary diff format).

​https://bugs.webkit.org/show_bug.cgi?id=28429

  • English.lproj/localizedStrings.js:
1:08 AM Changeset in webkit [47858] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make XSSAuditor go fast
​https://bugs.webkit.org/show_bug.cgi?id=28667

Make the XSSAuditor go faster by implementing two optimizations:

1) We avoid canonicalizing scripts that are larger than the page's URL.

This saves a bunch of time for large inline scripts.

2) We memoize canonicalizing the page's URL because it's silly to

canonicalize repeated for each inline event listener.

These optimizations have a measurable affect on the intl1 page cycler.

No behavior change.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::MemoizingURLCanonicalizer::canonicalizeURL): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:

Aug 27, 2009:

11:17 PM Changeset in webkit [47857] by oliver@apple.com
  • 5 edits in trunk

JSON Stringifier does not follow ES5 spec for handling of Number, String and Boolean objects
​https://bugs.webkit.org/show_bug.cgi?id=28797

Reviewed by Maciej Stachowiak

Fixed unwrapBoxedPrimitive to do the right thing, which necessitated a couple of new exception
checks, and corrected the logic in gap to correctly convert Number and String objects.

9:54 PM Changeset in webkit [47856] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skipping worker-lifecycle.html test since it generates a deadlock on snowleopard.
Tracked as ​https://bugs.webkit.org/show_bug.cgi?id=28795.

  • platform/mac-snowleopard/Skipped:
8:09 PM Changeset in webkit [47855] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-08-27 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Removed ASSERT_NOT_REACHED, because indeed this ASSERT is reached in
fast/canvas/change-context.html. And it's alright to reach it.

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Removed assertion.
7:03 PM Changeset in webkit [47854] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2009-08-27 Jeremy Orlow <​jorlow@chromium.org>

Not reviewed. Build fix for ​http://trac.webkit.org/changeset/47840

Peter's change forgot one m_decoder->

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::frameSizeAtIndex):
6:58 PM Changeset in webkit [47853] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-08-27 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[V8] Add NULL-check, since the context ain't changeable no more, and
thus getContext could return 0.

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Added NULL-check.
6:38 PM Changeset in webkit [47852] by eric@webkit.org
  • 6 edits in trunk

2009-08-27 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Eric Seidel.

dataTransfer.types() should include type "Files" when files are present in the clipboard.
​https://bugs.webkit.org/show_bug.cgi?id=28780

Add dataTransfer type "Files" to the chromium port. Add eseidel's
patch for same for the mac port.

  • platform/chromium/ClipboardChromium.cpp:

2009-08-27 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Eric Seidel.

dataTransfer.types() should include type "Files" when files are present in the clipboard.
​https://bugs.webkit.org/show_bug.cgi?id=28780

Test dataTransfer.types "Files" access for all ports.

  • http/tests/security/clipboard/clipboard-file-access-expected.txt:
  • http/tests/security/clipboard/resources/clipboard-file-access.js:
6:20 PM Changeset in webkit [47851] by cmarrin@apple.com
  • 7 edits in trunk/WebCore

Removed GL_ from all constants, and gl prefix from all calls
​https://bugs.webkit.org/show_bug.cgi?id=28773

This was done for the external API in CanvasRenderingContext3D and
the internal API in GraphicsContext3D.

6:08 PM Changeset in webkit [47850] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Tweak to force worker object to get GC'd.

Reviewed by Oliver Hunt.

  • fast/workers/resources/dedicated-worker-lifecycle.js:
6:00 PM Changeset in webkit [47849] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2009-08-27 Jan Michael Alonzo <​jmalonzo@webkit.org>

Qt and Gtk build fixes. Not reviewed.

Add CanvasRenderingContext3D.idl to the build scripts.

  • GNUmakefile.am:
  • WebCore.pro:
5:31 PM Changeset in webkit [47848] by sullivan@apple.com
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt:

Brought up to date, other than the problem mentioned in ​https://bugs.webkit.org/show_bug.cgi?id=28792

5:27 PM Changeset in webkit [47847] by oliver@apple.com
  • 6 edits in trunk

JSON.stringify replacer array does not accept values that are not string primitives.
​https://bugs.webkit.org/show_bug.cgi?id=28788

Reviewed by Adam Roben

Update the JSON stringifier to initialise its replacer array according to the most
recent version of the spec.

5:13 PM Changeset in webkit [47846] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2009-08-27 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Release the storage mutex whenever leaving JavaScript execution.
​https://bugs.webkit.org/show_bug.cgi?id=28789

​http://dev.w3.org/html5/spec/Overview.html#storage-mutex describes the
required behavior. After we leave JavaScript, we must be sure the storage
mutex has been released. At the end of evaluate(), if localStorage has been
instantiated, tell it to release any locks that may be applicable.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
5:11 PM Changeset in webkit [47845] by ap@apple.com
  • 4 edits in trunk

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=28753
<rdar://problem/7173448> Excessive number of threads (and a crash)

Coalesce DNS prefetch requests to reduce strain on CFHost. Currently, the algorithm is as follows:

  • when resolver is idle, the first few requests are sent immediately (they may or may not hit the wire);
  • if there are a few requests in flight already, coalesce all requests for one second;
  • to avoid pathological cases with lots of links to different sites on a page, only ask CFHost about a handful of names (dropping the rest).

Coalescing reduces the number of requests dramatically, as prefetchDNS is called for each
link, and these tend to have identical host name.

  • platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::DNSResolveQueue): (WebCore::DNSResolveQueue::shared): (WebCore::DNSResolveQueue::add): (WebCore::DNSResolveQueue::decrementRequestCount): (WebCore::DNSResolveQueue::fired): (WebCore::clientCallback): (WebCore::DNSResolveQueue::resolve): (WebCore::prefetchDNS):
5:08 PM Changeset in webkit [47844] by bfulgham@webkit.org
  • 5 edits in trunk

JavaScriptCore: Link the testapi against CFLite when building the WinCairo port.

Reviewed by Adam Roben.

  • JavaScriptCore.vcproj/testapi/testapi.vcproj: Add new Release_CFLite target. Update all targets to inherit from either the JavaScriptCF.vsprops (Apple target) or the JavaScriptCFLite.vsprops file (WinCairo target).
  • JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Remove input file CoreFoundation.lib. This is provided by either the JavaScriptCF.vsprops or JavaScriptCFLite.vsprops file.

WebKit/win: Modify Release_Cairo target to build testapi using the
Release_CFLite target so that the correct CoreFoundation
(in this case, CFLite.dll) is linked.

Reviewed by Adam Roben.

  • WebKit.vcproj/WebKit.sln:
4:55 PM Changeset in webkit [47843] by cmarrin@apple.com
  • 43 edits
    2 adds in trunk

Final patch for Canvas 3D support
​https://bugs.webkit.org/show_bug.cgi?id=28018

This hooks everything up and provides a working implementation of
Canvas 3D. I plumb the creation of the 3D canvas down to GraphicsLayer,
passing the opaque context and texture pointers so a Canvas3DLayer can be
created (more on that later). It also plumbs changes to the 3D canvas so
that Canvas3DLayer can recomposite the results.


A 3D Canvas element needs a RenderLayer and compositing layer to render.
This is because it renders to an off-screen texture in the GPU and then
hands it to a Canvas3DLayer, which is a subclass of CAOpenGLLayer, to
render that texture as a 3D quad. This keeps everything in GPU memory to
maximize performance. When a CanvasRenderingContext3D is created it
forces a style recalc which creates the RenderLayer and compositing
layer if needed.


I repurposed an existing flag which was put in place for animation to accomplish
this. This flag is passed to setNeedsStyleRecalc(), and I renamed it from
AnimationStyleChange to SyntheticStyleChange. It essentially says that you need
to do a complete style recalc, even though the style itself has not really
changed.


This patch also fixes a couple of bugs discovered when testing with 3d-canvas
turned on. I also added a constructor DOMWindow.idl for CanvasRenderingContext3D.
This is needed when making a JS wrapper for the object so the prototype
property can be set.

4:35 PM Changeset in webkit [47842] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Windows-specific crash due to missing memory clearing call.

Reviewed by Geoff Garen.

  • runtime/Collector.cpp:

(JSC::Heap::allocateBlock):

4:16 PM Changeset in webkit [47841] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=28751
Clean up ImageDecoder*.cpp a bit.

Reviewed by Eric Seidel.

  • platform/image-decoders/ImageDecoder.cpp: Put functions in the same order as in the header file. Also, since there's already an anonymous namespace in this file, use it to enclose the local helper functions.

(WebCore::):
(WebCore::ImageDecoder::upperBoundScaledX):
(WebCore::ImageDecoder::lowerBoundScaledX):
(WebCore::ImageDecoder::scaledY):

  • platform/image-decoders/cairo/ImageDecoderCairo.cpp:

(WebCore::RGBA32Buffer::width): Style fix.
(WebCore::RGBA32Buffer::height): Style fix.

  • platform/image-decoders/haiku/ImageDecoderHaiku.cpp:

(WebCore::RGBA32Buffer::copyBitmapData): Ensure m_size is set correctly.
(WebCore::RGBA32Buffer::asNewNativeImage): Remove unneeded temp.
(WebCore::RGBA32Buffer::operator=): Simplify.

  • platform/image-decoders/wx/ImageDecoderWx.cpp:

(WebCore::RGBA32Buffer::asNewNativeImage): Try and collect spaced-out temps under loop comment to show they're all related. Use size_t for iterating over elements of a Vector.
(WebCore::RGBA32Buffer::width): Style fix.
(WebCore::RGBA32Buffer::height): Style fix.

4:14 PM Changeset in webkit [47840] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=28751
Clean up ImageSource.* in preparation for more fixes on bug 27965.

Reviewed by Eric Seidel.

  • platform/graphics/ImageSource.cpp: Put functions in the same order as in header file.

(WebCore::ImageSource::isSizeAvailable): Shorten.
(WebCore::ImageSource::size): Shorten.
(WebCore::ImageSource::frameSizeAtIndex): Shorten.
(WebCore::ImageSource::repetitionCount): Shorten.
(WebCore::ImageSource::frameIsCompleteAtIndex):

  • platform/graphics/ImageSource.h: Shorten #ifdef section a bit by sharing common typedefs.
3:58 PM Changeset in webkit [47839] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Skip HTML5 worker lifecycle test added in r47837 as it depends on unimplemented functionality in DRT.

  • platform/qt/Skipped:
3:05 PM Changeset in webkit [47838] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix: JavaScriptCore_debug.def missing some exports. Apple
Windows build does not use this file, so it was not noticed previously.

2:57 PM Changeset in webkit [47837] by atwilson@chromium.org
  • 4 edits
    8 adds in trunk/LayoutTests

Need to write tests for worker lifecycle mechanisms.
​https://bugs.webkit.org/show_bug.cgi?id=28714

Reviewed by David Levin.

  • fast/workers/dedicated-worker-lifecycle-expected.txt: Added.
  • fast/workers/dedicated-worker-lifecycle.html: Added.
  • fast/workers/resources/create-shared-worker-frame.html: Added.
  • fast/workers/resources/dedicated-worker-lifecycle.js: Added.

Broke out "orphaned worker" lifecycle tests because they only apply to dedicated workers.
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
(orphanedTimeoutWorkerExited):

  • fast/workers/resources/shared-worker-lifecycle.js: Added.

Added tests for the various shared worker lifecycle cases (makes sure that refcounts are properly updated when documents close).
(runTests):
(createWorkerFrame):
(closeFrame):
(closeFrame1):
(closeFrame2):
(closeFrame3):
(closeFrame4):
(complete):

  • fast/workers/resources/worker-lifecycle.js:

Updated test so it can run in a browser (with incorrect output) to aid in debugging.
(runTests.worker.onmessage):
(runTests):
(workerExited):

  • fast/workers/resources/worker-util.js: Added.

Moved some common utilities out of worker-lifecycle.js and into this file so they can be shared with other tests.
(log):
(gc):
(waitUntilWorkerThreadsExit):
(waitUntilThreadCountMatches.return):
(waitUntilThreadCountMatches):
(ensureThreadCountMatches):
(done):

  • fast/workers/shared-worker-frame-lifecycle-expected.txt: Added.
  • fast/workers/shared-worker-frame-lifecycle.html-disabled: Added.
  • fast/workers/shared-worker-lifecycle.html-disabled:
  • fast/workers/worker-lifecycle.html:
2:38 PM Changeset in webkit [47836] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=28785
Add ImageDecoder.cpp to various build files so platforms will be able to
use it. Move an ENABLE to not cover the whole file, in preparation for
adding a bunch of code. Simplify #ifdefs in ImageDecoder.h to be "Skia
vs. everyone else", which also gives new platforms a reasonable default
behavior.

Reviewed by Eric Seidel.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::RGBA32Buffer::getAddr):

1:55 PM Changeset in webkit [47835] by Antti Koivisto
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=28784

Reviewed by Dave Kilzer.

Add an exported method to flush pending repaints.

  • WebCore.base.exp:
  • page/FrameView.cpp:

(WebCore::FrameView::layoutIfNeededRecursive):
(WebCore::FrameView::flushDeferredRepaints):

  • page/FrameView.h:
1:45 PM Changeset in webkit [47834] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
​https://bugs.webkit.org/show_bug.cgi?id=28317

Reviewed by Oliver Hunt.

Missed one, fix part II.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::move):

  • assembler/X86Assembler.h:

(JSC::CAN_SIGN_EXTEND_8_32):

1:39 PM Changeset in webkit [47833] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-27 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Eric Seidel.

[V8] Expose files from the pasteboard in drop events.
​https://bugs.webkit.org/show_bug.cgi?id=28782

Update chromium port to expose dataTransfer.files() as per
HTML5 drag drop (Aug 2009 edition).

  • platform/chromium/ClipboardChromium.cpp:
1:29 PM Changeset in webkit [47832] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-08-27 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Eric Seidel.

clipboard file access tests use "dragentered" instead of "dragenter"
​https://bugs.webkit.org/show_bug.cgi?id=28761


Use dragenter and log these events. Add a dragleave test to check
that drag files are not visible in dragleave events.

  • http/tests/security/clipboard/clipboard-file-access-expected.txt:
  • http/tests/security/clipboard/resources/clipboard-file-access.js:
12:40 PM Changeset in webkit [47831] by pfeldman@chromium.org
  • 9 edits in trunk/WebCore

2009-08-27 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Dmitry Glazkov.

ScriptState now keeps explicit Handle of devtools front-end
utility context instead of trying to retrieve it from inspected
Frame.

​https://bugs.webkit.org/show_bug.cgi?id=28772

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope):
  • bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::~ScriptState): (WebCore::scriptStateFromPage):
  • bindings/v8/ScriptState.h: (WebCore::ScriptState::context):
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::~ScriptValue):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
12:37 PM Changeset in webkit [47830] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-08-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Console won't close.

​https://bugs.webkit.org/show_bug.cgi?id=28778

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._updateModifiedNodes):
  • inspector/front-end/utilities.js: (Node.prototype.isAncestor):
12:16 PM Changeset in webkit [47829] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-08-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add a test to make sure that image/link drags don't contain junk file arrays.
​https://bugs.webkit.org/show_bug.cgi?id=28755

  • editing/pasteboard/files-during-page-drags-expected.txt: Added.
  • editing/pasteboard/files-during-page-drags.html: Added.
  • editing/pasteboard/resources/files-during-page-drags.js: Added.

2009-08-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix a typo in files() causing image drags to have junk file arrays.
​https://bugs.webkit.org/show_bug.cgi?id=28755

Test: editing/pasteboard/files-during-page-drags.html

  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::files):
12:15 PM Changeset in webkit [47828] by oliver@apple.com
  • 5 edits in trunk

JSON parser accepts trailing comma in array literals
​https://bugs.webkit.org/show_bug.cgi?id=28779

Reviewed by Alexey Proskuryakov.

Update parser to correctly fail if there's a trailing comma.

11:46 AM Changeset in webkit [47827] by jorlow@chromium.org
  • 5 edits in trunk/WebCore

Not reviewed. Build fix for Chromium.

Patch by Jeremy Orlow <​jorlow@chromium.org> on 2009-08-27

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
11:07 AM Changeset in webkit [47826] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • DerivedSources.cpp: Added JSPageTransitionEvent.cpp to DerivedSources.cpp.
10:52 AM Changeset in webkit [47825] by ap@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Zap gremlins from a recent ChangeLog entry.

10:46 AM Changeset in webkit [47824] by ap@apple.com
  • 25 edits
    13 adds in trunk

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=28758
<rdar://problem/6440869> Implement pageshow and pagehide events for b/f cache (28758)

Tests: fast/events/pageshow-pagehide-on-back-cached.html

fast/events/pageshow-pagehide-on-back-uncached.html
fast/events/pageshow-pagehide.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Dispatch pagehide event (this function is called both when a document goes away, and when it goes to b/f cache).
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Dispatch pagehide right before unload. (WebCore::DOMWindow::dispatchPageTransitionEvent): Do what it takes to add a new event handler that can be installed on Window object. (WebCore::DOMWindow::onpagehide): Ditto. (WebCore::DOMWindow::setOnpagehide): Ditto. (WebCore::DOMWindow::onpageshow): Ditto. (WebCore::DOMWindow::setOnpageshow): Ditto.
  • history/CachedFrame.cpp: (WebCore::CachedFrame::restore): Dispatch pageshow for a page that isn't being restored from cache.
  • dom/PageTransitionEvent.cpp: Added. (WebCore::PageTransitionEvent::PageTransitionEvent): (WebCore::PageTransitionEvent::~PageTransitionEvent): (WebCore::PageTransitionEvent::initPageTransitionEvent):
  • dom/PageTransitionEvent.h: Added. (WebCore::PageTransitionEvent::create): (WebCore::PageTransitionEvent::isPageTransitionEvent): (WebCore::PageTransitionEvent::persisted):
  • dom/PageTransitionEvent.idl: Added. Add event class implementation.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Support inline listener definition (note that adding listeners to document.body programmatically is not supported, matching Firefox).
  • dom/Document.cpp: (WebCore::Document::implicitClose): Dispatch pageshow event right before load event. (WebCore::Document::dispatchPageTransitionEvent): Do what it takes to add a new event for Docuemnt. (WebCore::Document::createEvent): Ditto.
  • dom/Document.h: Added dispatchPageTransitionEvent.
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/Event.cpp: (WebCore::Event::isPageTransitionEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • html/HTMLAttributeNames.in:
  • page/DOMWindow.h:
  • page/DOMWindow.idl: Do what it takes to add a new event type.
9:35 AM Changeset in webkit [47823] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-08-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by NOBODY (build fix).

Adding missing file from previous commit.

​https://bugs.webkit.org/show_bug.cgi?id=28740

9:09 AM Changeset in webkit [47822] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2009-08-27 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Factor out Factor out summary bar from Resources panel.

​https://bugs.webkit.org/show_bug.cgi?id=28740

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): (WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition): (WebInspector.ResourcesPanel.prototype._changeSortingFunction):
  • inspector/front-end/SummaryBar.js: Added. (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.get calculator): (WebInspector.SummaryBar.prototype.set calculator): (WebInspector.SummaryBar.prototype.reset): (WebInspector.SummaryBar.prototype.update): (WebInspector.SummaryBar.prototype._drawSwatch.drawSwatchSquare): (WebInspector.SummaryBar.prototype._drawSwatch): (WebInspector.SummaryBar.prototype._drawSummaryGraph.var): (WebInspector.SummaryBar.prototype._drawSummaryGraph): (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._fadeOutRect): (WebInspector.SummaryBar.prototype._makeLegendElement):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
8:38 AM Changeset in webkit [47821] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-08-26 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Start adding heap profiler to Inspector (hidden behind a flag.)

​https://bugs.webkit.org/show_bug.cgi?id=28429

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.addProfile): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._snapshotClicked):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: added Preferences.heapProfilerPresent flag.
8:24 AM Changeset in webkit [47820] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-08-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Metrics sidebar editing is broken.

​https://bugs.webkit.org/show_bug.cgi?id=28434

  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update):
7:54 AM Changeset in webkit [47819] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-27 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=28767

Make KURLGoogle.cpp's decodeURLEscapeSequences decode %00 to match
KURL.cpp. This makes the XSSAuditor tests pass when using KURLGoogle.

  • platform/KURLGoogle.cpp: (WebCore::decodeURLEscapeSequences):
7:43 AM BuildingQtOnOSX edited by ironstorm@gmail.com
(diff)
7:38 AM BuildingQtOnOSX edited by ironstorm@gmail.com
(diff)
5:27 AM Changeset in webkit [47818] by ariya@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-08-27 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Ariya Hidayat.

QWebHistory::clear() modifications.

Clear() method was changed. If QWebHistory is empty (there is no
elements even current) clear() do nothing. If there at least one
element clear() will delete everything apart of current.

New autotests in QWebHistory

New autotests were added to QWebHistory. They should check some crashes
in save and restore state process and clear() method and general
behavior on where QWebHistory::count() == 0 or QWebHistory::count() == 1

Bugzilla: ​https://bugs.webkit.org/show_bug.cgi?id=28711

  • Api/qwebhistory.cpp: (QWebHistory::clear):
  • tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::back): (tst_QWebHistory::forward): (tst_QWebHistory::saveAndRestore_crash_1): (tst_QWebHistory::saveAndRestore_crash_2): (tst_QWebHistory::saveAndRestore_crash_3): (tst_QWebHistory::clear):
4:40 AM Changeset in webkit [47817] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-08-27 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Cleanup, old and commented part of source code was removed.
Fix some formatting problems.

​https://bugs.webkit.org/show_bug.cgi?id=28712

  • Api/qwebhistory_p.h: (QWebHistoryPrivate::QWebHistoryPrivate):
4:18 AM Changeset in webkit [47816] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-08-27 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Build fix, missing functions after r47763.

  • platform/qt/Localizations.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
2:44 AM Changeset in webkit [47815] by ariya@webkit.org
  • 21 edits in trunk/LayoutTests

2009-08-27 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt]Update expecteds (t150*) in css2.1 and remove from Skipped. This affects 20 files.

  • platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
  • platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
  • platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt:
  • platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
  • platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-09-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
2:42 AM Changeset in webkit [47814] by ariya@webkit.org
  • 18 edits in trunk/LayoutTests

2009-08-27 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated font metrics in these css1 tests since we pass them.

  • platform/qt/Skipped:
  • platform/qt/css1/box_properties/clear-expected.txt:
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_margin-expected.txt:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/qt/css1/box_properties/height-expected.txt:
  • platform/qt/css1/box_properties/width-expected.txt:
  • platform/qt/css1/cascade/cascade_order-expected.txt:
  • platform/qt/css1/cascade/important-expected.txt:
  • platform/qt/css1/classification/display-expected.txt:
  • platform/qt/css1/classification/list_style-expected.txt:
  • platform/qt/css1/classification/list_style_image-expected.txt:
  • platform/qt/css1/classification/list_style_position-expected.txt:
  • platform/qt/css1/classification/list_style_type-expected.txt:
  • platform/qt/css1/classification/white_space-expected.txt:
2:07 AM Changeset in webkit [47813] by ariya@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-26 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Skip HTML5 input-list tests added in r47767.

  • platform/qt/Skipped:
1:39 AM Changeset in webkit [47812] by oliver@apple.com
  • 4 edits
    3 adds in trunk

'this' in JSON.parse reviver is the global object
​https://bugs.webkit.org/show_bug.cgi?id=28752

Reviewed by Gavin Barraclough.

This is a technically simple change, we merely update the code for calling
the reviver function to pass the correct this object. Doing so however
exposes the holder to arbitrary mutation by the reviver function so it is
necessary for us to now guard all property accesses against the possibility
of failure.

12:26 AM Changeset in webkit [47811] by xan@webkit.org
  • 3 edits in trunk

2009-08-27 Priit Laes <​plaes@plaes.org>

Reviewed by Xan Lopez.

[GTK] Out-of-srcdir build problem
​https://bugs.webkit.org/show_bug.cgi?id=28741

  • GNUmakefile.am, autotools/webkit.m4: Fix problem with out-of-srcdir builds. Also bump required glib version.
Note: See TracTimeline for information about the timeline view.