⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 29, 2009:

4:59 PM Changeset in webkit [47883] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=28829
Crash in AccessibilityRenderObject::activeDescendant when trying to set aria-activedescendant to something without a renderer

Reviewed by Dan Bernstein.

Test: accessibility/aria-activedescendant-crash.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::activeDescendant): Nil check.

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=28829
Crash in AccessibilityRenderObject::activeDescendant when trying to set aria-activedescendant to something without a renderer

Reviewed by Dan Bernstein.

  • accessibility/aria-activedescendant-crash-expected.txt: Added.
  • accessibility/aria-activedescendant-crash.html: Added.

Aug 28, 2009:

11:56 PM Changeset in webkit [47882] by jmalonzo@webkit.org
  • 6 edits in trunk

2009-08-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Gtk Build broken for OSX Quartz
​https://bugs.webkit.org/show_bug.cgi?id=28727

Define XP_UNIX for non-Win OS builds.

  • GNUmakefile.am:

Check for XP_UNIX instead of GTK or X11 to ease building of the Gtk
port in Mac and Unix/Linux.

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::getValue): (WebCore::PluginView::init):
6:51 PM Changeset in webkit [47881] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-08-28 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue needs a master process
​https://bugs.webkit.org/show_bug.cgi?id=28040

Add a bugzilla-tool commit-queue command
Keeps per-bug logs, but doesn't yet upload them anywhere.

  • Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
  • Scripts/modules/buildbot.py: remove noisy log message
  • Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
4:37 PM Changeset in webkit [47880] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Define _CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1
to automatically use secure versions of C runtime lib calls on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=28824

Reviewed by Adam Roben.

  • win/tools/vsprops/common.vsprops:
4:31 PM Changeset in webkit [47879] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Re-skipping tests that still fail on the bot.

  • platform/gtk/Skipped:
4:13 PM Changeset in webkit [47878] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unskip some passing tests, skip new tests that are failing.

  • platform/gtk/Skipped:
4:08 PM Changeset in webkit [47877] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-08-28 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe

Wrap WebkitCSSTransformValues in the correct class of DOM wrapper.
​https://bugs.webkit.org/show_bug.cgi?id=27727

When fetching the DOM wrapper for a WebkitCSSTransformValue (which is a kind of
CSSValueList), we need to ask the value list whether it's a WebkitCSSTransformValue,
because there is not a unique enum value for WebkitCSSTransformValue.

  • bindings/objc/DOMCSS.mm: (kitClass):
3:09 PM Changeset in webkit [47876] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=28308
Fix some warnings introduced by r47381.

Reviewed by Jan Michael Alonzo.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::convertCMYKToRGBA):
(WebCore::convertRGBToRGBA):

3:03 PM Changeset in webkit [47875] by adachan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=21442
Make sure filesystemPathFromUrlOrTitle() returns a string with length
<= MAX_PATH - 1.

  • platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle):
2:44 PM Changeset in webkit [47874] by ojan@chromium.org
  • 5 edits
    1 copy
    2 deletes in trunk/WebCore

2009-08-28 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding Chromium's VFS for Linux and Mac.

​https://bugs.webkit.org/show_bug.cgi?id=28750

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase): (WebCore::SQLiteFileSystem::deleteDatabaseFile):
  • platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Removed.
  • platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Removed.
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: Added.
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
2:16 PM Changeset in webkit [47873] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

set-dangerous-headers.html shouldn't set allowed header to same value
as forbidden headers. AUTHORIZATION is an allowed header, and the
value is being set to "foobar" like the forbidden headers, which causes
the test to fail when run using http server that doesn't strip the
AUTHORIZATION header.
​https://bugs.webkit.org/show_bug.cgi?id=28818

Patch by Julie Parent <​jparent@chromium.org> on 2009-08-28
Reviewed by Alexey Proskuryakov.

  • http/tests/xmlhttprequest/set-dangerous-headers.html:
11:59 AM Changeset in webkit [47872] by Dimitri Glazkov
  • 8 edits in trunk/WebCore

2009-08-28 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Made bindings use Node::setOnEvent functions for Node descendants
instead of Node::setAttributeEventListener.

Node::setAttributeEventListener is an internal function and
doesn't do the forwarding to DOM window that is required for some
HTML elements.
​https://bugs.webkit.org/show_bug.cgi?id=28709

Tests added in ​http://trac.webkit.org/changeset/47326 now pass with V8.

  • bindings/scripts/CodeGeneratorV8.pm: Now generates EventListener accessors for Node descendants instead of using custom callbacks.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener): Moved from V8NodeCustom.cpp.
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Fixed a bug in signature.
  • bindings/v8/V8Utilities.cpp: (WebCore::createHiddenDependency): (WebCore::removeHiddenDependency): Changed signature to accept Handle instead of Local.
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Removed custom callbacks for EventListener accessors.
11:40 AM Changeset in webkit [47871] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-28 Ben Murdoch <​benm@google.com>

​https://bugs.webkit.org/show_bug.cgi?id=28803


Implements V8CustomVoidCallback reporting any exceptions that were thrown from the callback function.

  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback): Checks if the callback raised an exception and reports it to WebCore if so.
11:34 AM Changeset in webkit [47870] by Chris Fleizach
  • 4 edits in trunk/WebKit

WebKit: update-webkit-localizable-strings script can no longer complete
​https://bugs.webkit.org/show_bug.cgi?id=28792

Reviewed by John Sullivan.

  • English.lproj/Localizable.strings:

WebKit/mac: update-webkit-localizable-strings script can no longer complete
​https://bugs.webkit.org/show_bug.cgi?id=28792

Reviewed by John Sullivan.

  • WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

11:29 AM Changeset in webkit [47869] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

Not reviewed (build fix).

  • platform/graphics/qt/ImageDecoderQt.cpp: Accidentally added some spaces.

(WebCore::ImageDecoder::create):
(WebCore::ImageDecoderQt::ImageDecoderQt):

  • platform/graphics/qt/ImageDecoderQt.h: Make constructor public so factory function can access it (this seemed better than making ImageDecoder a friend).
11:08 AM Changeset in webkit [47868] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=27965
Move ImageDecoder creation function to a factory function on
ImageDecoder. This is arguably where it makes the most sense anyway,
and it will (soon) allow ImageSourceQt.cpp to have one less dedicated
function.

Reviewed by Eric Seidel.

  • platform/graphics/ImageSource.cpp:
  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoder::create):

  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/qt/ImageSourceQt.cpp:

(WebCore::ImageSource::setData):

  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
11:00 AM Changeset in webkit [47867] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=28785
Combine duplicated code from ImageDecoder*.cpp into the main
ImageDecoder.cpp.

Reviewed by Eric Seidel.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):

  • platform/image-decoders/cairo/ImageDecoderCairo.cpp:
  • platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
  • platform/image-decoders/wx/ImageDecoderWx.cpp:
8:24 AM Changeset in webkit [47866] by kov@webkit.org
  • 25 edits
    1 add in trunk

2009-08-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Adding files for the new test for window-related issues (starting
with scrollbar policy).

  • GNUmakefile.am:

WebCore

2009-08-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Override setScrollbarModes to correctly forward scrollbar modes
policy changes to client code, via a new platform-specific method,
scrollbarsPolicyDidChange.

  • page/ChromeClient.h: (WebCore::ChromeClient::scrollbarsPolicyDidChange):
  • platform/ScrollView.cpp: (WebCore::ScrollView::createScrollbar):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setScrollbarModes):

WebKit/gtk

2009-08-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Add properties and a signal to report scrollbar policy changes to
client code, and a default handler that does the right thing when
using GtkScrolledWindow.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scrollbarsModeDidChange):
  • WebCoreSupport/ChromeClientGtk.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_property): (webkit_web_frame_class_init): (webkit_web_frame_get_horizontal_scrollbar_policy): (webkit_web_frame_get_vertical_scrollbar_policy):
  • webkit/webkitwebframe.h:
  • tests/testwindow.c: Added. (load_finished_cb): (test_webkit_window_scrollbar_policy): (main):

WebKit/*

Added empty implementation of new ChromeClient method.

8:12 AM Changeset in webkit [47865] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-08-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Add view source mode API
​https://bugs.webkit.org/show_bug.cgi?id=28805

Implement setter and getter for "view source" mode.

  • webkit/webkitwebview.cpp: (webkit_web_view_set_view_source_mode): (webkit_web_frame_get_view_source_mode):
  • webkit/webkitwebview.h:
7:27 AM Changeset in webkit [47864] by jmalonzo@webkit.org
  • 4 edits
    5 adds in trunk

2009-08-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[GTK] Geolocation needs permission API before being enabled by default

Unskip the Geolocation tests and rebaseline three DOM tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Added.
  • platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Added.

Build the Gtk port with geolocation enabled. This option is only
enabled for the buildbot. The autotools option will be enabled by
default once the permissions API is implemented.

  • Scripts/build-webkit:
6:58 AM Changeset in webkit [47863] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

[Qt/Mac] Un-blacklist the QuickTime plugin

Patch by Cédric Luthi <​cedric.luthi@gmail.com> on 2009-08-28
Reviewed by Tor Arne Vestbø

​https://bugs.webkit.org/show_bug.cgi?id=28768

Now that the drawing model is properly negotiated, there is no need the
blacklist the QuickTime plugin anymore.

This revealed a bug in PluginView::performRequest: it should not initiate a
request if the plugin has been stopped, which is what happens when a plugin
only supports the QuickDraw drawing model.

  • plugins/PluginView.cpp:
  • plugins/mac/PluginPackageMac.cpp:
6:42 AM Changeset in webkit [47862] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-08-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

Set DOM agent document to 0 in InspectorController::close to
make DOM agent remove DOM listeners from the inspected document.

Replace windowVisible checks with m_frontend checks to as inspector
window lives in a different process in Chromium while frontend proxy
is in the inspected page process.

​https://bugs.webkit.org/show_bug.cgi?id=28800

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspect): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::close): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::addProfile):
  • inspector/InspectorController.h:
6:23 AM Changeset in webkit [47861] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-08-28 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Remove dependency of SummaryBar on WebInspector.resourceCategories.

​https://bugs.webkit.org/show_bug.cgi?id=28801

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get categories):
  • inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.update):
5:28 AM Changeset in webkit [47860] by ariya@webkit.org
  • 41 edits in trunk/LayoutTests

2009-08-28 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Adapt expecteds of css2.1/t0401* to new metrics. Remove these files from Skipped. (39 files)

  • platform/qt/Skipped:
  • platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
  • platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
  • platform/qt/css2.1/t040103-case-00-b-expected.txt:
  • platform/qt/css2.1/t040103-case-01-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
  • platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
  • platform/qt/css2.1/t040103-ident-00-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-01-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-02-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-03-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-04-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-05-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-06-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-07-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-08-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-09-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-10-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-11-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-12-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-13-c-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
  • platform/qt/css2.1/t040105-import-00-b-expected.txt:
  • platform/qt/css2.1/t040105-import-01-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:
2:00 AM Changeset in webkit [47859] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-08-28 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed (patching in l18n change that was missing due to
the git binary diff format).

​https://bugs.webkit.org/show_bug.cgi?id=28429

  • English.lproj/localizedStrings.js:
1:08 AM Changeset in webkit [47858] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-08-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make XSSAuditor go fast
​https://bugs.webkit.org/show_bug.cgi?id=28667

Make the XSSAuditor go faster by implementing two optimizations:

1) We avoid canonicalizing scripts that are larger than the page's URL.

This saves a bunch of time for large inline scripts.

2) We memoize canonicalizing the page's URL because it's silly to

canonicalize repeated for each inline event listener.

These optimizations have a measurable affect on the intl1 page cycler.

No behavior change.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::MemoizingURLCanonicalizer::canonicalizeURL): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:
Note: See TracTimeline for information about the timeline view.