⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 31, 2009:

8:45 PM Changeset in webkit [47917] by beidson@apple.com
  • 2 edits in trunk/WebCore

Rubberstamped by Sam Weinig

  • WebCore.base.exp: Removed an unneeded symbol export.
6:34 PM Changeset in webkit [47916] by kov@webkit.org
  • 7 edits in trunk

WebCore

2009-08-31 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=28466
When downloading a file, two GET requests are sent to the HTTP server

Can't think of a way to test this.

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): only nullify the handle's client when it is the ResourceLoader, to support the case in which a download API uses a different client

WebKit/gtk

2009-08-31 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=28466
When downloading a file, two GET requests are sent to the HTTP server

Support reusing a connection that is already ongoing, instead of
cancelling the connection and creating another.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download):
  • webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_request_download):
4:44 PM Changeset in webkit [47915] by bweinstein@apple.com
  • 5 edits in trunk

2009-08-31 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Darin Adler.

Text Fields and Text Areas are reported as read-only by inspect32.exe.
​https://bugs.webkit.org/show_bug.cgi?id=28854

Added another case in AcccessibiltyRenderObject::isReadOnly to test if text fields
and texts areas are read-only.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly): (WebCore::AccessibilityRenderObject::canSetValueAttribute):

2009-08-31 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Darin Adler.

Added a case to check for readonly and non-readonly set through the readonly attribute
instead of through aria-readonly. This tests our new case in AccessibilityRenderObject::isReadOnly.

  • accessibility/aria-readonly-expected.txt:
  • accessibility/aria-readonly.html:
4:40 PM Changeset in webkit [47914] by atwilson@chromium.org
  • 12 edits in trunk

WebCore: fast/workers/worker-lifecycle.html crashes intermittently on snowleopard
​https://bugs.webkit.org/show_bug.cgi?id=28795

Reviewed by Alexey Proskuryakov.

Changed WorkerContext::close() to no longer stop the worker thread.
It is now the parent's responsibility to shut down the worker thread when it is notified that the context is closed.

  • workers/AbstractWorker.cpp:

Updated dispatchScriptErrorEvent to pass-through the "handled" value from dispatchEvent(), to allow event handlers added with addEventListener() to mark events as handled.

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::workerContextClosed):
Now shuts down the worker thread when notified that the context is closed.
(WebCore::SharedWorkerProxy::close):
Now handles being invoked when the context is already in the process of shutting down.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::close):
No longer calls WorkerThread::stop() to avoid race conditions with shutting down the thread while the parent is still interacting with it.

  • workers/WorkerContext.h:

(WebCore::WorkerContext::isClosing):
isClosing() is now public so WorkerRunLoop can call it to determine whether to process tasks.

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::performTask):
Error events should still be delivered even if the worker thread is closing.
Also fixed problem where error events were not dispatched if error handlers were added via addEventListener().
(WebCore::WorkerTerminateTask::create):
New task that invokes terminateWorkerContext() on the parent thread when the context is closed.
(WebCore::WorkerTerminateTask::WorkerTerminateTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::WorkerMessagingProxy::workerContextClosed):
Now fires off a WorkerTerminateTask to shut down the thread when the context is closed.

  • workers/WorkerMessagingProxy.h:

WorkerMessagingProxy now overrides workerContextClosed().

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):
Now drops tasks on the floor if the WorkerContext is closing.

LayoutTests: fast/workers/worker-lifecycle.html crashes intermittently on snowleopard
​https://bugs.webkit.org/show_bug.cgi?id=28795

Reviewed by Alexey Proskuryakov.

Removed worker-lifecycle.html from the list of Skipped tests since it no longer crashes.
Added test for case where we capture script errors via an event listener added via addEventListener().

  • fast/workers/worker-script-error.html
  • fast/workers/worker-script-error-expected.txt

Added testScriptErrorAddEventListener to test catching script errors via addEventListener().

  • platform/mac-snowleopard/Skipped:
4:36 PM Changeset in webkit [47913] by Beth Dakin
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Meant to update these results with my earlier check-in, but I
forgot!

  • platform/mac/fast/inspector/style-expected.txt:
4:30 PM Changeset in webkit [47912] by ojan@chromium.org
  • 4 edits in trunk/WebCore

Not reviewed (build fix)

Build fix for Chromium to match r49707.

  • bindings/v8/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::ScriptCallFrame):

  • bindings/v8/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):

  • platform/KURLGoogle.cpp:

(WebCore::KURL::KURL):
(WebCore::blankURL):

4:01 PM Changeset in webkit [47911] by ap@apple.com
  • 2 edits in trunk/WebKit/gtk

Gtk build fix.

This is also a behavior fix, at least on debug builds - a caller of
webkit_web_history_item_new_with_data() could pass an URL that could cause an assertion
failure in KURL.

  • webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_new_with_data): Pass a null KURL as base to parse properly.
3:49 PM Changeset in webkit [47910] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=28858
Element.baseURI parses xml:base attribute incorrectly

Test: fast/dom/base-attribute-parsing.xhtml

  • dom/Element.cpp: (WebCore::Element::baseURI): Avoid assertion failure (no change in release mode).
3:27 PM Changeset in webkit [47909] by Dimitri Glazkov
  • 4 edits in trunk

WebCore:

2009-08-31 Dimitri Glazkov <Dimitri Glazkov>

Reverting ​http://trac.webkit.org/changeset/47904, because it caused
layout test failure.

Test: fast/dom/Window/new-window-opener.html

WebKit/mac:

2009-08-31 Dimitri Glazkov <Dimitri Glazkov>

Reverting ​http://trac.webkit.org/changeset/47904, because it caused
layout test failure.

3:09 PM Changeset in webkit [47908] by mrowe@apple.com
  • 2 edits
    2 deletes in trunk/WebKit

Remove WebViewEditingContextMenu.nib and WebViewEditingContextMenuOld.nib.

Rubber-stamped by Beth Dakin.

We stopped using these back in r18592 when we switched over to context menus
driven by WebCore.

  • English.lproj/WebViewEditingContextMenu.nib/classes.nib: Removed.
  • English.lproj/WebViewEditingContextMenu.nib/info.nib: Removed.
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib: Removed.
  • English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Removed.
  • English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Removed.
  • English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Removed.
  • WebKit.xcodeproj/project.pbxproj:
3:07 PM Changeset in webkit [47907] by ap@apple.com
  • 50 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=28852
Rename KURL single argument constructor to avoid confusion

  • platform/KURL.h: The constructor that used to be single argument should now be invoked as KURL(ParsedURLString, myString).
3:05 PM Changeset in webkit [47906] by Beth Dakin
  • 22 edits
    2 deletes in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=28635 [CSS3
Backgrounds and Borders] Add support for 2-keyword values for
background-repeat

Reviewed by Darin Adler.

This patch allows background-repeat to take two values by making
background-repeat just like background-position internally. There
is a little extra legwork for background-repeat because the spec
indicates that its computed value should be equivalent to how it
was specified. I keep track of the specified thing by setting the
implicit flag whenever background-repeat is defined with only one
value (since internally, we now store this as 2 values.)

Here we can't access the implicit flag, so for backwards-
compatibility's sake, we always return one value when that makes
sense.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::fillRepeatToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Here we check for the implicit flag and return one value when it is
set.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::getPropertyValue):
(WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
(WebCore::CSSMutableStyleDeclaration::cssText):

Add support for CSSPropertyBackgroundRepeatX and
CSSPropertyBackgroundRepeatY

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillProperty):

  • css/CSSParser.h:

Get rid of mappings to RepeatXFill and RepeatYFill since we don't
need those parts of the EFillRepeat enum anymore.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):

Add CSSPropertyBackgroundRepeatX and CSSPropertyBackgroundRepeatY

  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap):

Add background-repeat-x and -y.

  • css/CSSPropertyNames.in:

Break repeat into x and y.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillRepeatX):
(WebCore::CSSStyleSelector::mapFillRepeatY):

  • css/CSSStyleSelector.h:

There is no more RepeatXFill. Instead, look for
fillLayer->repeatX() == RepeatFill

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

Break m_repeat into m_repeatX and m_repeatY

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):
(WebCore::FillLayer::cullEmptyLayers):

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::repeatX):
(WebCore::FillLayer::repeatY):
(WebCore::FillLayer::isRepeatXSet):
(WebCore::FillLayer::isRepeatYSet):
(WebCore::FillLayer::setRepeatX):
(WebCore::FillLayer::setRepeatY):
(WebCore::FillLayer::clearRepeatX):
(WebCore::FillLayer::clearRepeatY):
(WebCore::FillLayer::initialFillRepeatX):
(WebCore::FillLayer::initialFillRepeatY):

Again, break backgroundRepeat into backgroundRepeatX and
backgroundRepeatY

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::maskRepeatX):
(WebCore::InheritedFlags::maskRepeatY):

We don't need RepeatXFill or RepeatYFill. Now that we store two
values, they are represented by Repeat-NoRepeat and NoRepeat-
Repeat, respectively.

  • rendering/style/RenderStyleConstants.h:

(WebCore::):

LayoutTests: Tests for ​https://bugs.webkit.org/show_bug.cgi?id=28635 [CSS3
Backgrounds and Borders] Add support for 2-keyword values for
background-repeat

Reviewed by Darin Adler.

This test is updated to test for two values.

  • fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
  • fast/backgrounds/repeat/resources/parsing-background-repeat.js:

These tests are updated to reflect new order.

  • fast/css/background-position-serialize-expected.txt:
  • fast/css/remove-shorthand-expected.txt:

Reflect new order in results, and make the test dump as text.

  • fast/inspector/style.html:
  • platform/mac/fast/inspector/style-expected.checksum: Removed.
  • platform/mac/fast/inspector/style-expected.png: Removed.
  • platform/mac/fast/inspector/style-expected.txt:
2:00 PM Changeset in webkit [47905] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-08-31 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Compositing layer size needs to take into account software reflections on children.
​https://bugs.webkit.org/show_bug.cgi?id=28837

When computing the bounds of a composited layer, take software-rendered
reflections into account.

Test: compositing/reflections/reflection-in-composited.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds):
1:37 PM Changeset in webkit [47904] by Dimitri Glazkov
  • 4 edits in trunk

WebCore:

2009-08-31 Mark Mentovai <​mark@chromium.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=28614

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

  • platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):

WebKit/mac:

2009-08-31 Mark Mentovai <​mark@chromium.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=28614

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView updateScrollers]):
1:15 PM Changeset in webkit [47903] by eric@webkit.org
  • 8 edits
    1 add in trunk/WebCore

2009-08-31 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Inspector Request Headers Should Show Data Sent With Request
​https://bugs.webkit.org/show_bug.cgi?id=22920

Manual test added - see below.

  • English.lproj/localizedStrings.js:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateRequest): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
  • inspector/InspectorResource.h:
  • inspector/front-end/Resource.js: (WebInspector.Resource):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._refreshURL): (WebInspector.ResourceView.prototype._refreshQueryString): (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshRequestPayload): (WebInspector.ResourceView.prototype._refreshParms): (WebInspector.ResourceView.prototype._toggleURLdecoding): (WebInspector.ResourceView.prototype._getHeaderValue): (WebInspector.ResourceView.prototype._refreshRequestHeaders):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.updateResource):
  • manual-tests/inspector/display-form-data.html: Added.
12:31 PM Changeset in webkit [47902] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed typo.
​https://bugs.webkit.org/show_bug.cgi?id=28691

Patch by Robert Agoston <​Agoston.Robert@stud.u-szeged.hu> on 2009-08-31
Reviewed by Gavin Barraclough.

  • parser/Parser.h:

(JSC::Parser::parse):

12:01 PM Changeset in webkit [47901] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2009-08-31 Simon Fraser <Simon Fraser>

Followup from r47877; add test for the Obj-C wrapper class for WebkitCSSTransformValue
​https://bugs.webkit.org/show_bug.cgi?id=27727

  • platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
11:37 AM Changeset in webkit [47900] by Simon Fraser
  • 3 edits
    8 adds in trunk

2009-08-28 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix positioning error when a compositing, absolutely-positioned element has an ancestor with opacity.
​https://bugs.webkit.org/show_bug.cgi?id=28754

For absolutely-positioned layers, convertToLayerCoords() jumps to the positioned
ancestor, since the layer x and y are relative to that ancestor. However, this could
skip over the ancestorLayer, thus giving the wrong result.

Fix by duplicating the enclosingPositionedAncestor() logic in convertToLayerCoords(),
and checking for ancestorLayer along the way. If found, compute offset of both to
the enclosingPositionedAncestor() and subtract.

This also fixes a positioning bug with abs. positioned elements in reflections,
so there is a new reflection test with a pixel result.

Tests: compositing/geometry/abs-position-inside-opacity.html

fast/reflections/abs-position-in-reflection.html

  • rendering/RenderLayer.cpp: (WebCore::isPositionedContainer): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor): (WebCore::RenderLayer::convertToLayerCoords):
11:12 AM Changeset in webkit [47899] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fall back to a Release version of Safari if a Debug one doesn't exist

<​http://webkit.org/b/28849>

Reviewed by Sam Weinig.

  • Scripts/webkitdirs.pm:

(safariPath): If the user is working with a Debug build, but there's
no Debug version of Safari present, fall back to using a Release
version of Safari.

10:54 AM Changeset in webkit [47898] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make safariPath() work for Debug builds of Safari on Windows

<​http://webkit.org/b/28849>

Reviewed by Sam Weinig.

  • Scripts/webkitdirs.pm:

(safariPath): If the user is working with a Debug build, add the
_debug suffix to Safari.exe.

10:20 AM Changeset in webkit [47897] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2009-08-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: pass call frames into the frontend as a part of
pausedScript event.

​https://bugs.webkit.org/show_bug.cgi?id=28847

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didPause):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::pausedScript):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript):
8:06 AM Changeset in webkit [47896] by Adam Roben
  • 4 edits in trunk/WebKit/win

Give WebKit clients access to the window features specified in window.open

Reviewed by Steve Falkenburg.

  • COMVariantSetter.h: Added COMVariantSetters for bool and float.
  • Interfaces/IWebUIDelegatePrivate.idl: Added IWebUIDelegatePrivate2,

which contains a new version of createWebViewWithRequest that also
passes the window features as an IPropertyBag. This is analagous to
the -createWebViewWithRequest:windowFeatures: method added to
WebUIDelegate on Mac in r27452. Also added key strings for use with
the window features property bag.

  • WebCoreSupport/WebChromeClient.cpp:

(createWindowFeaturesPropertyBag): Added this helper function to turn
a WebCore::WindowFeatures into an IPropertyBag for passing to WebKit
clients.
(WebChromeClient::createWindow): If the UI delegate implements
IWebUIDelegatePrivate2, call the new createWebViewWithRequest function
that takes a window features property bag. If the delegate doesn't
implement the new function, fall back to the old functions.

8:05 AM Changeset in webkit [47895] by Adam Roben
  • 2 edits in trunk/WebKit/win

A little clean-up in WebChromeClient::createWindow

Reviewed by Steve Falkenburg.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::createWindow): Refactored to share more code between
the dialog and non-dialog cases.

5:50 AM Changeset in webkit [47894] by zoltan@webkit.org
  • 14 edits in trunk/LayoutTests

2009-08-31 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated font metrics in the remaining css1 tests. All tests pass.

  • platform/qt/Skipped:
  • platform/qt/css1/text_properties/letter_spacing-expected.txt:
  • platform/qt/css1/text_properties/line_height-expected.txt:
  • platform/qt/css1/text_properties/text_align-expected.txt:
  • platform/qt/css1/text_properties/text_decoration-expected.txt:
  • platform/qt/css1/text_properties/text_indent-expected.txt:
  • platform/qt/css1/text_properties/text_transform-expected.txt:
  • platform/qt/css1/text_properties/vertical_align-expected.txt:
  • platform/qt/css1/text_properties/word_spacing-expected.txt:
  • platform/qt/css1/units/color_units-expected.txt:
  • platform/qt/css1/units/length_units-expected.txt:
  • platform/qt/css1/units/percentage_units-expected.txt:
  • platform/qt/css1/units/urls-expected.txt:
5:15 AM Changeset in webkit [47893] by zoltan@webkit.org
  • 14 edits in trunk/LayoutTests

2009-08-31 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update font metrics for these css1 tests.

  • platform/qt/Skipped:
  • platform/qt/css1/formatting_model/canvas-expected.txt:
  • platform/qt/css1/formatting_model/floating_elements-expected.txt:
  • platform/qt/css1/formatting_model/height_of_lines-expected.txt:
  • platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/qt/css1/formatting_model/inline_elements-expected.txt:
  • platform/qt/css1/formatting_model/replaced_elements-expected.txt:
  • platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/qt/css1/pseudo/anchor-expected.txt:
  • platform/qt/css1/pseudo/firstletter-expected.txt:
  • platform/qt/css1/pseudo/firstline-expected.txt:
  • platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
5:09 AM Changeset in webkit [47892] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Un-blacklist Silverlight on Mac

Reviewed by Ariya Hidayat.

Does not seem to crash anymore, probably due to how we now handle
drawing and event model handshake better.

  • plugins/mac/PluginPackageMac.cpp:

(WebCore::PluginPackage::isPluginBlacklisted):

4:17 AM Changeset in webkit [47891] by zoltan@webkit.org
  • 10 edits in trunk/LayoutTests

2009-08-31 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated font metrics for these css1 tests.

  • platform/qt/Skipped:
  • platform/qt/css1/color_and_background/background-expected.txt:
  • platform/qt/css1/color_and_background/background_attachment-expected.txt:
  • platform/qt/css1/color_and_background/background_color-expected.txt:
  • platform/qt/css1/color_and_background/background_image-expected.txt:
  • platform/qt/css1/color_and_background/background_position-expected.txt:
  • platform/qt/css1/color_and_background/background_repeat-expected.txt:
  • platform/qt/css1/color_and_background/color-expected.txt:
  • platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
4:06 AM Changeset in webkit [47890] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-08-31 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=28827
SVGSVGElement.unsuspendRedraw() shouldn't throw

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::unsuspendRedraw):
  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl:
3:55 AM Changeset in webkit [47889] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-08-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::list): (WebCore::HTMLInputElement::dataList): (WebCore::HTMLInputElement::selectedOption):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
3:45 AM Changeset in webkit [47888] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-31 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

Remove ASSERT(frame) in ResourceHandle::start (ResourceHandleCurl.cpp)
​https://bugs.webkit.org/show_bug.cgi?id=28802

Remove ASSERT because the frame could be null if the
ResourceHandle is not associated with any frame, e.g. if we are
downloading a file.
If the frame is not null but the page is null this must be an
attempted load from an onUnload handler, so let's just block it.

  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::start):
3:18 AM Changeset in webkit [47887] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-08-31 Maxime Simon <Maxime Simon>

Reviewed by Eric Seidel.

Build fix for platforms which don't enable DOM_STORAGE.
​https://bugs.webkit.org/show_bug.cgi?id=28834

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
2:59 AM Changeset in webkit [47886] by vestbo@webkit.org
  • 1 edit in trunk/WebKitTools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro

Fix the Qt/Mac build of TestNetscapePlugin after Qt change 3940f25

2:53 AM Changeset in webkit [47885] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/WebCore.pro

Fix the Qt/Mac build after Qt change 3940f25 (LIBS_PRIVATE)

We no longer pick up the libraries/frameworks that Qt was built
against, so we have to add them manually for our targets.

12:49 AM Changeset in webkit [47884] by zoltan@webkit.org
  • 23 edits in trunk/LayoutTests

2009-08-31 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t040*. (19 files)
Fix relative path in .css files.

  • css2.1/support/css1test64a.css:
  • css2.1/support/css1test64b.css:
  • platform/qt/Skipped:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-02-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-03-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-04-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-05-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-06-f-expected.txt:
  • platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
  • platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040303-c62-percent-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
  • platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t040307-syntax-01-b-expected.txt:
Note: See TracTimeline for information about the timeline view.