⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 3, 2009:

10:24 PM Changeset in webkit [48038] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2009-09-03 Kent Tamura <​tkent@chromium.org>

Reviewed by David Levin.

Test for HTMLTextAreaElement.textLength
​https://bugs.webkit.org/show_bug.cgi?id=28929

  • fast/forms/resources/textarea-textlength.js: Added.
  • fast/forms/textarea-textlength-expected.txt: Added.
  • fast/forms/textarea-textlength.html: Added.

2009-09-03 Kent Tamura <​tkent@chromium.org>

Reviewed by David Levin.

Add support for HTMLTextAreaElement.textLength
​https://bugs.webkit.org/show_bug.cgi?id=28929

Test: fast/forms/textarea-textlength.html

  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::textLength):
  • html/HTMLTextAreaElement.idl:
5:27 PM Changeset in webkit [48037] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

<rdar://problem/7180197>, ​https://bugs.webkit.org/show_bug.cgi?id=28822
REGRESSION(r31231): Creating document with current document's DOCTYPE causes crashes

Test: fast/dom/DOMImplementation/createDocument-with-used-doctype.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Even though we cannot raise an exception immediately out of fear of breaking Acid3, we shouldn't use a DocumentType node in two documents.
4:57 PM Changeset in webkit [48036] by beidson@apple.com
  • 3 edits
    9 adds in trunk

WebCore: Page Cache should support pages with Frames.
​https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

Tests: fast/events/pageshow-pagehide-on-back-cached-with-frames.html

fast/loader/frames-with-unload-handlers-in-page-cache.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests: Page Cache should support pages with Frames.
​https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

  • fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Added.
  • fast/events/pageshow-pagehide-on-back-cached-with-frames.html: Added.
  • fast/events/resources/pageshow-pagehide-subframe-cachable.html: Added.
  • fast/events/resources/pageshow-pagehide-subsubframe-cachable.html: Added.
  • fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt: Added.
  • fast/loader/frames-with-unload-handlers-in-page-cache.html: Added.
  • fast/loader/resources/notify-done.html: Added.
  • fast/loader/resources/subframe-with-subsubframe-with-unload-handler.html: Added.
  • fast/loader/resources/subframe-with-unload-handler.html: Added.
4:23 PM Changeset in webkit [48035] by eric@webkit.org
  • 7 edits
    5 adds in trunk

2009-09-03 Steve VanDeBogart <​vandebo@chromium.org>

Reviewed by Eric Seidel.

Check that middle click triggers an onpaste event in Linux.
​https://bugs.webkit.org/show_bug.cgi?id=28696

  • platform/gtk/editing/pasteboard: Added.
  • platform/gtk/editing/pasteboard/middle-click-onpaste-expected.txt: Added.
  • platform/gtk/editing/pasteboard/resources: Added.
  • platform/gtk/editing/pasteboard/resources/TEMPLATE.html: Added.
  • platform/gtk/editing/pasteboard/resources/middle-click-onpaste.js: Added. (handlePaste):

2009-09-03 Steve VanDeBogart <​vandebo@chromium.org>

Reviewed by Eric Seidel.

Handle middle click in Chromium like QT
​https://bugs.webkit.org/show_bug.cgi?id=28696

Tested by middle-click-onpaste.html.

  • platform/Pasteboard.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::isSelectionMode): (WebCore::Pasteboard::setSelectionMode): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
  • platform/chromium/PasteboardPrivate.h: (WebCore::PasteboardPrivate::):
4:10 PM Changeset in webkit [48034] by beidson@apple.com
  • 2 edits in trunk/WebCore

More partial work towards "Page Cache should support pages with Frames"
​https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

Fix a bug where subframes weren't asked if they were cacheable.

No new tests, especially since page caching for frames isn't turned on yet.
A layout test will come in my next patch, which enables frames in the page cache.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):

4:08 PM Changeset in webkit [48033] by abarth@webkit.org
  • 2 edits in trunk/WebKit/mac

2009-09-03 Adam Barth <​abarth@webkit.org>

Unreviewed build fix.

Change notImplemented() to a FIXME.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
3:59 PM Changeset in webkit [48032] by abarth@webkit.org
  • 18 edits in trunk

2009-09-03 Adam Barth <​abarth@webkit.org>

Reviewed by ​eric@webkit.org.

​https://bugs.webkit.org/show_bug.cgi?id=24696

Added mixed content methods to FrameLoaderClient.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didDisplayInsecureContent): (WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
  • loader/FrameLoaderClient.h:

2009-09-03 Adam Barth <​abarth@webkit.org>

Reviewed by ​eric@webkit.org.

​https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didDisplayInsecureContent): (WebKit::FrameLoaderClient::didRunInsecureContent):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2009-09-03 Adam Barth <​abarth@webkit.org>

Reviewed by ​eric@webkit.org.

​https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):

2009-09-03 Adam Barth <​abarth@webkit.org>

Reviewed by ​eric@webkit.org.

​https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didDisplayInsecureContent): (WebCore::FrameLoaderClientQt::didRunInsecureContent):
  • WebCoreSupport/FrameLoaderClientQt.h:

2009-09-03 Adam Barth <​abarth@webkit.org>

Reviewed by ​eric@webkit.org.

​https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
  • WebCoreSupport/WebFrameLoaderClient.h:

2009-09-03 Adam Barth <​abarth@webkit.org>

Reviewed by ​eric@webkit.org.

​https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::didDisplayInsecureContent): (WebCore::FrameLoaderClientWx::didRunInsecureContent):
  • WebKitSupport/FrameLoaderClientWx.h:
2:37 PM Changeset in webkit [48031] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-09-03 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Access private member variables directly instead of using the
accessor.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::windowObjectCleared):
1:25 PM Changeset in webkit [48030] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Exception.toString() on Qt seems to print out a different value than other platforms.
​https://bugs.webkit.org/show_bug.cgi?id=28952

Reviewed by Dave Levin.

  • platform/qt/Skipped:

Disabled new worker tests that rely on the string format of DOM exceptions until bug #28952 is resolved.

12:38 PM Changeset in webkit [48029] by kevino@webkit.org
  • 19 edits
    6 adds in trunk

Reviewed by Kevin Ollivier.

[wx] Frames support
​https://bugs.webkit.org/show_bug.cgi?id=19041

12:35 PM Changeset in webkit [48028] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

[Qt] Page content is not displayed in case of HTTP status error
​https://bugs.webkit.org/show_bug.cgi?id=28949

Patch by Yael Aharon <​yael.aharon@nokia.com> on 2009-09-03
Reviewed by Simon Hausmann.

If the server sent content, show it to the user instead of an error,
even if the HTTP status code is not success.

  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/QNetworkReplyHandler.h:
12:07 PM Changeset in webkit [48027] by ddkilzer@apple.com
  • 4 edits in trunk/WebKitTools

<​http://webkit.org/b/28880> svn-apply --force doesn't actually work

Reviewed by Eric Seidel.

This fixes "svn-apply --force" and adds unit tests for the
scm.apply_patch() method which uses this script.

  • Scripts/svn-apply: Created $globalExitCode variable that defaults to 0. Exit with a value of $globalExitCode when the script is finished. (applyPatch): Ignore a non-zero $exitCode if $force is true, but set $globalExitCode to $exitCode so that svn-apply exits with a non-zero status if any patches did not apply cleanly. Also print out the actual patch command if $force was not true.
  • Scripts/modules/scm.py: (scripts_directory): Added. Extracted from script_path(). (script_path): Extracted scripts_directory().
  • Scripts/modules/scm_unittest.py: Import urllib. (SVNTestRepository.setup): Save the original working directory in test_object since this represents the WebKit repository from where the unit tests are run. (SCMTest): Created new super class to hold utility methods. (SCMTest._create_patch): Creates a patch file on disk and a dictionary for use with scm.svn_apply(). (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink back to WebKitTools/Scripts in the test repository so that scm.apply_patch() is able to find the svn-apply script. (SVNTest): Inherit from SCMTest instead of unittest.TestCase. (SVNTest.tearDown): Make sure to change directories back to the original_path before the next test. (SVNTest.test_apply_svn_patch): New test case for applying an svn patch with scm.apply_patch(). (SVNTest.test_apply_svn_patch_force): New test case for applying an svn patch with scm.apply_patch() that conflicts. (GitTest): Inherit from SCMTest instead of unittest.TestCase. (GitTest.tearDown): Make sure to change directories back to the original_path before the next test. (GitTest.test_apply_git_patch): New test case for applying a git patch with scm.apply_patch(). (GitTest.test_apply_git_patch_force): New test case for applying a git patch with scm.apply_patch() that conflicts.
11:36 AM Changeset in webkit [48026] by atwilson@chromium.org
  • 7 edits
    2 adds in trunk/WebCore

Need to update v8 bindings to support passing multiple ports to postMessage()
​https://bugs.webkit.org/show_bug.cgi?id=28839

Reviewed by Dimitri Glazkov.

Added support for passing MessagePortArray to v8 bindings.

New tests that now pass with V8:

fast/events/message-port-multi.html
fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html

  • WebCore.gypi:

Added V8MessageEventCustom.cpp and V8MessagePortCustom.h

  • bindings/v8/custom/V8CustomBinding.h:

Added custom postMessage() handlers for various classes.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::DOMWindowPostMessage):
Added custom handler that supports MessagePortArray.

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::DedicatedWorkerContextPostMessage):
Added custom handler that supports MessagePortArray.

  • bindings/v8/custom/V8MessageEventCustom.cpp: Added.

(WebCore::MessageEventPorts):
Added getter for ports attribute.
(WebCore::MessageEventInitMessageEvent):
Added custom handler that supports MessagePortArray.

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::MessagePortPostMessage):
Added custom handler that supports MessagePortArray.
(WebCore::getMessagePortArray):
Added helper function that supports converting from a sequence-like object to a MessagePortArray.

  • bindings/v8/custom/V8MessagePortCustom.h: Added.

Added declaration for getMessagePortArray().

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::WorkerPostMessage):
Added custom handler that supports MessagePortArray.

11:36 AM Changeset in webkit [48025] by atwilson@chromium.org
  • 47 edits
    1 copy
    12 adds in trunk

WebCore: Need to update JS bindings and IDL files to support multiple message ports in postMessage()
​https://bugs.webkit.org/show_bug.cgi?id=28460

Reviewed by Sam Weinig.

Added new toJSSequence() API which validates that a JSValue meets the WebIDL criteria for a sequence.

Tests: fast/events/message-port-multi.html

fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Added JSMessagePortCustom.h and JSMessageEventCustom.cpp.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::toJSSequence):
Added toJSSequence() API to do validation on sequence-like objects per WebIDL.

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArrays.

  • bindings/js/JSDedicatedWorkerContextCustom.cpp:

(WebCore::JSDedicatedWorkerContext::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArrays.

  • bindings/js/JSMessageEventCustom.cpp: Added.

(WebCore::JSMessageEvent::ports):
Added custom ports() getter that converts from MessagePortArray to JSArray.
(WebCore::JSMessageEvent::initMessageEvent):
Added support for passing a MessagePortArray.

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArray.
(WebCore::fillMessagePortArray):
New helper routine that validates/converts from a JS sequence o a WebCore::MessagePortArray.

  • bindings/js/JSMessagePortCustom.h: Added.
  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorker::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArray.

  • dom/MessageEvent.cpp:
  • dom/MessageEvent.h:

(WebCore::MessageEvent::ports):
Changed ports() to return a MessagePortArray* since this value can be null.

  • dom/MessageEvent.idl:

Updated IDL to match HTML5 spec (now accepts MessagePortArrays instead of a solitary MessagePort).

  • dom/MessagePort.cpp:
  • dom/MessagePort.h:
  • dom/MessagePort.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

  • workers/DedicatedWorkerContext.cpp:
  • workers/DedicatedWorkerContext.h:
  • workers/DedicatedWorkerContext.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

  • workers/Worker.cpp:
  • workers/Worker.h:
  • workers/Worker.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

LayoutTests: Need to update JS bindings and IDL files to support multiple message ports in postMessage()
​https://bugs.webkit.org/show_bug.cgi?id=28460

Reviewed by Sam Weinig.

Updated layout tests to match new postMessage() and MessageEvent APIs.

Added new layout tests to test sending/receiving multiple ports.

  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-postmessage-args.html:

Updated to match new postMessage API.

  • fast/events/init-events-expected.txt:
  • fast/events/message-channel-gc-4.html:

Updated to match new postMessage API.

  • fast/events/message-port-clone.html:

Updated to match new postMessage API.

  • fast/events/message-port-deleted-document.html:

Updated to match new postMessage API.

  • fast/events/message-port-deleted-frame.html:

Updated to match new postMessage API.

  • fast/events/message-port-inactive-document.html:

Updated to match new postMessage API.

  • fast/events/message-port-multi-expected.txt: Added.
  • fast/events/message-port-multi.html: Added.

Added tests for various cases of sending multiple ports.

  • fast/events/message-port.html:

Updated to match new postMessage API.

  • fast/events/resources/init-events.js:

Added tests for sending ports to initMessageEvent()

  • fast/events/resources/message-port-iframe.html:
  • fast/events/resources/message-port-multi.js: Added.

Added tests for various cases of sending multiple ports.

  • fast/workers/resources/shared-worker-common.js:

(onconnect):
Updated to reflect new MessageEvent API.

  • fast/workers/resources/shared-worker-script-error.js:

(onconnect):
Updated to reflect new MessageEvent API.

  • fast/workers/resources/worker-cloneport.js:

(onmessage):
Updated to reflect new MessageEvent API.

  • fast/workers/resources/worker-context-multi-port.js: Added.

(worker.onmessage):
Added tests for various cases of sending multiple ports.

  • fast/workers/resources/worker-context-thread-multi-port.js: Added.

Added tests for various cases of sending multiple ports.

  • fast/workers/resources/worker-messageport.js:

(onmessage):
Updated to reflect new MessageEvent API.

  • fast/workers/resources/worker-multi-port.js: Added.

(worker.onmessage):
Added tests for various cases of sending multiple ports.

  • fast/workers/resources/worker-thread-multi-port.js: Added.

(onmessage):
Worker-thread side of multiple port layout test.
(testPassed):
(testFailed):

  • fast/workers/worker-cloneport.html:
  • fast/workers/worker-context-multi-port-expected.txt: Added.
  • fast/workers/worker-context-multi-port.html: Added.

Added tests for sending multiple ports from the worker thread.

  • fast/workers/worker-messageport-expected.txt:
  • fast/workers/worker-messageport-gc.html:
  • fast/workers/worker-messageport.html:
  • fast/workers/worker-multi-port-expected.txt: Added.
  • fast/workers/worker-multi-port.html: Added.
9:54 AM Changeset in webkit [48024] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-09-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Do not query non-function call frames for function name.

​https://bugs.webkit.org/show_bug.cgi?id=28799

  • inspector/front-end/InjectedScript.js: (InjectedScript.CallFrameProxy): (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
9:52 AM Changeset in webkit [48023] by sullivan@apple.com
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt:

Brought this file up to date.

Reviewed by Adam Roben

9:51 AM Changeset in webkit [48022] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-09-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Crash after typing "clear" and pressing return in inspector console.

​https://bugs.webkit.org/show_bug.cgi?id=28684

  • inspector/front-end/InjectedScript.js: (InjectedScript._clearConsoleMessages): (InjectedScript._inspectObject): (InjectedScript._ensureCommandLineAPIInstalled):
9:09 AM Changeset in webkit [48021] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip a couple of failing layout-tests

Rubber-stamped by Ariya Hidayat.

We skip most of the D&D tests already, and the animation test
seems to be flakey on our platform since the commit that triggered
it only touched V8 bindings.

  • platform/qt/Skipped:
6:56 AM Changeset in webkit [48020] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-03 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Squeezed out some performance from string conversion.
​https://bugs.webkit.org/show_bug.cgi?id=28945

  • bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::string): Avoid calling virtual length method. Be more explicit with external memory computation. Avoid function calls in data and length. (WebCore::): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8NonStringValueToWebCoreString): (WebCore::v8NonStringValueToAtomicWebCoreString): Avoid extra calls of WebCoreStringResource::toString. When AtomicString is computed pass it immediately when constructing WebCoreStringResource. Use inline buffer for small strings.
  • bindings/v8/V8Binding.h: (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString): (WebCore::toString): Inline dispatch of string vs. non-string values.
6:49 AM Changeset in webkit [48019] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-03 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Inlined common case of V8IsolatedWorld::getEntered to speed
up V8Proxy lookup.
​https://bugs.webkit.org/show_bug.cgi?id=28946

  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::getEnteredImpl):
  • bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::getEntered):
6:40 AM Changeset in webkit [48018] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-09-03 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Remove bogus asserts that break Debug builds at runtime.

  • WebCoreSupport/DocumentLoaderGtk.cpp: (WebKit::DocumentLoader::detachFromFrame): (WebKit::DocumentLoader::decreaseLoadCount):
5:57 AM Changeset in webkit [48017] by zoltan@webkit.org
  • 52 edits in trunk/LayoutTests

2009-09-03 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t170602-bdr-conflct-w-* (50 files).
Remove these files from Skipped.

  • platform/qt/Skipped:
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
4:53 AM Changeset in webkit [48016] by zoltan@webkit.org
  • 19 edits in trunk/LayoutTests

2009-09-03 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t1202-counters-* (17 files).
Remove these files from Skipped.

  • platform/qt/Skipped:
  • platform/qt/css2.1/t1202-counters-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-09-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-15-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-16-c-expected.txt:
  • platform/qt/css2.1/t1202-counters-17-d-expected.txt:
  • platform/qt/css2.1/t1202-counters-18-f-expected.txt:
3:50 AM Changeset in webkit [48015] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Disable a few tests that require new controller features

Reviewed by Ariya Hidayat.

  • platform/qt/Skipped:
3:44 AM Changeset in webkit [48014] by vestbo@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Qt/Linux] Add platform-spesific result for plugin-javascript-access

Rubber-stamped by Simon Hausmann..

  • platform/qt-linux/plugins/plugin-javascript-access-expected.txt: Added.
2:47 AM Changeset in webkit [48013] by zoltan@webkit.org
  • 18 edits in trunk/LayoutTests

2009-09-03 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t140201* (16 files).
Remove these files from Skipped.

  • platform/qt/Skipped:
  • platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgre-01-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-00-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-01-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-02-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-03-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-04-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgreps-05-c-ag-expected.txt:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c536-bgpos-01-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.txt:
2:38 AM Changeset in webkit [48012] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

Add strnstr for Linux and Windows in StringExtras.h
​https://bugs.webkit.org/show_bug.cgi?id=28901

  • wtf/StringExtras.h: (strnstr):
2:29 AM Changeset in webkit [48011] by eric@webkit.org
  • 8 edits
    6 adds in trunk

2009-09-03 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for maxLength and IME input.
​https://bugs.webkit.org/show_bug.cgi?id=25253

  • fast/forms/input-maxlength-ime-completed-expected.txt: Added.
  • fast/forms/input-maxlength-ime-completed.html: Added.
  • fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
  • fast/forms/input-maxlength-ime-preedit.html: Added.
  • fast/forms/resources/input-maxlength-ime-completed.js: Added.
  • fast/forms/resources/input-maxlength-ime-preedit.js: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:

2009-09-03 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a regression bug that maxLength doesn't work for IME input.
​https://bugs.webkit.org/show_bug.cgi?id=25253

Tests: fast/forms/input-maxlength-ime-completed.html

fast/forms/input-maxlength-ime-preedit.html

  • dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
  • dom/InputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
2:12 AM Changeset in webkit [48010] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-09-03 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement title/media/type setters do something
​https://bugs.webkit.org/show_bug.cgi?id=28828

  • svg/dom/resources/style-reflect.js: Added.
  • svg/dom/style-reflect-expected.txt: Added.
  • svg/dom/style-reflect.html: Added.

2009-09-03 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement title/media/type setters do something
​https://bugs.webkit.org/show_bug.cgi?id=28828

Test: svg/dom/style-reflect.html

  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::setXmlspace): Actually change the attribute. (WebCore::SVGStyleElement::setType): Ditto. (WebCore::SVGStyleElement::setMedia): Ditto. (WebCore::SVGStyleElement::setTitle): Ditto.
2:08 AM Changeset in webkit [48009] by vestbo@webkit.org
  • 3 edits in trunk/WebKitTools

[Qt] Add support for platform-spesific layout-test results

Reviewed by Mark Rowe.

For the Qt port we use the qt-[mac|linux|win] directories and then fall
back to the generic qt directory for both test results and skipped list.

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
2:04 AM Changeset in webkit [48008] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-09-03 Ben Murdoch <​benm@google.com>

​https://bugs.webkit.org/show_bug.cgi?id=28872
Test to verify statement error callbacks behave as expected when they return true or throw an exception.

  • storage/statement-error-callback-expected.txt: Added with properties svn:eol-style.
  • storage/statement-error-callback.html: Added with properties svn:eol-style.

2009-09-03 Ben Murdoch <​benm@google.com>

​https://bugs.webkit.org/show_bug.cgi?id=28872

Fixes a bug where handleEvent() in the V8 Custom SQL Statement Error binding would not return the correct result to WebCore after invoking the callback.

Test: storage/statement-error-callback.html

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent): Return true from handleEvent() if the callback raised an exception or the callback itself returned true.
1:57 AM Changeset in webkit [48007] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-09-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Add a setting to turn SessionStorage on/off
​https://bugs.webkit.org/show_bug.cgi?id=28836

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
  • tests/qwebpage/tst_qwebpage.cpp: (testFlag): (tst_QWebPage::testOptionalJSObjects):
1:50 AM Changeset in webkit [48006] by eric@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-09-03 Maxime Simon <Maxime Simon>

Reviewed by Eric Seidel.

[Haiku] Adding three font-specific files to WebCore:
FontCustomPlatformData.cpp, FontCustomPlatformData.h,
and FontPlatformData.h
​https://bugs.webkit.org/show_bug.cgi?id=28131

  • platform/graphics/haiku/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/haiku/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
  • platform/graphics/haiku/FontPlatformData.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::oblique): (WebCore::FontPlatformData::hashTableDeletedFontValue):
12:14 AM Changeset in webkit [48005] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-03 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's HashEntry class
​https://bugs.webkit.org/show_bug.cgi?id=27830

Inherits HashEntry class from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/runtime/Lookup.cpp:32.

  • runtime/Lookup.h:

Sep 2, 2009:

7:31 PM Changeset in webkit [48004] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-02 Laurent Cerveau <​lcerveau@me.com>

Reviewed by David Kilzer.

<​http://webkit.org/b/25517> build-webkit script should print build time at end

  • Scripts/build-webkit: Added startTime and endTime variable so that the build time is computed and printed as part of the build message; display formatting has been separated in a dedicated subroutine.
6:44 PM Changeset in webkit [48003] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root

Reviewed by Eric Seidel.

  • Scripts/VCSUtils.pm: (determineSvnRoot): Added back check for repository root that was removed in r46134 when this code lived in svn-create-patch. It's necessary to check both the repository root and the repository UUID in case two different working directories are checked out from the same repository.
6:10 PM Changeset in webkit [48002] by timothy@apple.com
  • 2 edits in trunk/WebKitTools

Use new 512x512 icons for nightly builds.

Rubber-stamped by Mark Rowe.

  • WebKitLauncher/webkit.icns:
5:55 PM Changeset in webkit [48001] by beidson@apple.com
  • 5 edits in trunk/WebCore

More partial work towards "Page Cache should support pages with Frames"
​https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Darin Adler.

No new tests. (No change in behavior, current tests pass).

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading): Adopt the new enum form for FrameLoader::stopLoading().

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): Take an enum to decide whether to dispatch no unload events,

only unload, or unload and pagehide.

(WebCore::FrameLoader::closeURL):
(WebCore::FrameLoader::scheduleRedirection):
(WebCore::FrameLoader::cachePageForHistoryItem): Call pageHidden().
(WebCore::FrameLoader::pageHidden): Add to dispatch the pagehide event to all frames in the case

where a page is added to the PageCache.

  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h: Add an UnloadEventPolicy enum.
5:18 PM Changeset in webkit [48000] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Should crash if JIT code buffer allocation fails.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-09-02
​https://bugs.webkit.org/show_bug.cgi?id=28926
<rdar://problem/7031922>

  • jit/ExecutableAllocatorPosix.cpp:

(JSC::ExecutablePool::systemAlloc):

  • jit/ExecutableAllocatorWin.cpp:

(JSC::ExecutablePool::systemAlloc):

5:07 PM Changeset in webkit [47999] by beidson@apple.com
  • 8 edits in trunk

WebCore: More partial work towards "Page Cache should support pages with Frames"
​https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Darin Adler.

  • More CachedFrame destruction work.
  • Including related Frame and FrameLoader changes and cleanup.

No new tests. (No change in behavior, current tests pass).

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Rebuild up the whole FrameTree when restoring.
(WebCore::CachedFrame::CachedFrame): Tear down the entire FrameTree when caching.
(WebCore::CachedFrame::destroy): For child frames that are being destroyed while in

the PageCache, do lightweight cleanup to:
A - Prevent referring to a stale Page object.
B - Prevent World Leaks of WebKit objects.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopAllLoaders): stopAllLoaders() should never be called on Frames that are

in the PageCache. ASSERT that fact.

(WebCore::FrameLoader::open): Remove a bogus release-build workaround, as the comment right above it

explains it is not effective, and it'd be better to see the crash locally instead of downstream.

(WebCore::FrameLoader::closeAndRemoveChild): Make sure the owner element has a page pointer before

referencing it.

(WebCore::FrameLoader::detachFromParent): Use the new detachViewsAndDocumentLoader() call
(WebCore::FrameLoader::detachViewsAndDocumentLoader): Does lightweight cleanup of client (WebKit) objects.

  • loader/FrameLoader.h:
  • page/Frame.cpp:

(WebCore::Frame::detachFromPage): Simply clear the Page pointer without doing any other work.
(WebCore::Frame::pageDestroyed): Use the new detachFromPage().

  • page/Frame.h:

WebKit/mac: More partial work towards "Page Cache should support pages with Frames"
​https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _topHTMLView]): Rework the ASSERT in this method to reflect the

reality of calling this method for pages currently in the PageCache.

4:41 PM Changeset in webkit [47998] by jshin@chromium.org
  • 2 edits in trunk/WebCore

2009-09-02 Jungshik Shin <​jshin@chromium.org>

Reviewed by Dimitri Glazkov

[Chromium] Add 'icu::' qualifier in preparation for ICU upgrade to 4.2
in Chromium. This is to fix a new file added in r28742 since the
last patch for this issue.

​https://bugs.webkit.org/show_bug.cgi?id=28410

No change in the test result.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::getNormalizedTextRun):
4:01 PM Changeset in webkit [47997] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

waf build fix. Remove local variable shadowing global.

3:21 PM Changeset in webkit [47996] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-09-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Correct a typo to fix bustage, caused by r47991.
​https://bugs.webkit.org/show_bug.cgi?id=27933

  • platform/graphics/skia/ImageBufferSkia.cpp: Changed "Unpremultipled" to "Unmultiplied".
2:31 PM Changeset in webkit [47995] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-09-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Add a missing include to fix bustage, caused by r47991.
​https://bugs.webkit.org/show_bug.cgi?id=27933

  • platform/graphics/skia/ImageBufferSkia.cpp: Added SkColorPriv include.
2:30 PM Changeset in webkit [47994] by jianli@chromium.org
  • 2 edits in trunk/WebCore

[Chromium] Implement file support for DragData.
​https://bugs.webkit.org/show_bug.cgi?id=28896

Reviewed by Dimitri Glazkov.

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsCompatibleContent):

2:07 PM Changeset in webkit [47993] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Protect libcurl shared data with Mutex objects via curl_set_share_opt.
​https://bugs.webkit.org/show_bug.cgi?id=28920

1:45 PM Changeset in webkit [47992] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-02 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

Expose functions to change the focus ring color for Linux Chromium

​https://bugs.webkit.org/show_bug.cgi?id=28887

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::setFocusRingColor): (WebCore::RenderThemeChromiumLinux::platformFocusRingColor):
  • rendering/RenderThemeChromiumLinux.h:
1:38 PM Changeset in webkit [47991] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-02 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

SVG Filter premultiplied color support for getImageDate/putImageData
​https://bugs.webkit.org/show_bug.cgi?id=27933

Patch to get premultiplied color support for Skia on getImageDate/putImageData.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::putImageData):
1:23 PM Changeset in webkit [47990] by beidson@apple.com
  • 4 edits in trunk/WebCore

Forget to rename openInFrameloader() to open(), which was requested in Darin's review of my last patch.

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::open):

  • history/CachedFrame.h:
  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

1:16 PM Changeset in webkit [47989] by beidson@apple.com
  • 7 edits in trunk/WebCore

In ​http://trac.webkit.org/changeset/47943 I added new header dependencies to FrameLoader.h.
Removing them is a little trouble, but worth it going forward.
The pattern of creating a "CachedFrameBase" as the interface CachedFrame provides to FrameLoader
was suggested by Darin Adler.

Reviewed by Darin Adler.

No new tests. (No change in behavior)

Make CachedFrame inherit privately from CachedFrameBase, which becomes the interface FrameLoader uses:

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::CachedFrameBase):
(WebCore::CachedFrameBase::~CachedFrameBase):
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::openInFrameLoader):

  • history/CachedFrame.h:

(WebCore::CachedFrameBase::document):
(WebCore::CachedFrameBase::view):
(WebCore::CachedFrameBase::domWindow):
(WebCore::CachedFrame::create):
(WebCore::CachedFrame::documentLoader):
(WebCore::CachedFrame::mousePressNode):

Call the new ::openInFrameLoader() method on the CachedFrame, as CachedFrameBase is now the only
thing capable of interacting with FrameLoader::open(CachedFrameBase):

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

  • history/CachedPage.h:

(WebCore::CachedPage::documentLoader):

Make ::open(CachedFrame) public, and change it to ::open(CachedFrameBase):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

  • loader/FrameLoader.h:
1:13 PM Changeset in webkit [47988] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2009-09-02 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by David Kilzer.

Calls exitStatus function from the main package where it is also defined.

  • Scripts/VCSUtils.pm:
1:13 PM Changeset in webkit [47987] by rniwa@webkit.org
  • 3 edits
    3 adds in trunk

WebCore: Cannot pres Enter to escape from bulleted list when <ul> is a child of <li>.
​https://bugs.webkit.org/show_bug.cgi?id=24866

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2009-09-02
Reviewed by Eric Seidel.

This patch modifies breakOutOfEmptyListItem to break out of a properly nested list
(a list to break out of is inside another list item).

When the empty list item appears at the end of another list item, WebKit breaks out of
the outer list item, and adds new item below the outer list item.
Otherwise, WebKit breaks out of the the inner list item and inserts new paragraph.

Test: editing/execCommand/break-out-of-empty-list-item.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

LayoutTests: Cannot press Enter to escape from bulleted list when <ul> is a child of <li>.
​https://bugs.webkit.org/show_bug.cgi?id=24866

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2009-09-02
Reviewed by Eric Seidel.

This patch adds a test to make sure WebKit break out of an empty list item.

  • editing/execCommand/break-out-of-empty-list-item-expected.txt: Added.
  • editing/execCommand/break-out-of-empty-list-item.html: Added.
  • editing/execCommand/resources/break-out-of-empty-list-item.js: Added.

(pressKey):
(enterAtTarget):
(testBreakOutOfEmptyListItem):

12:55 PM Changeset in webkit [47986] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Brady Eidson.

Fix the test to pass on Tiger.

Tiger's ICU decodes the invalid text differently. Moved it inside the comment - this also
matches the original from the Web better.

  • fast/encoding/japanese-encoding-mix-expected.txt:
  • fast/encoding/japanese-encoding-mix.html:
12:32 PM Changeset in webkit [47985] by beidson@apple.com
  • 5 edits in trunk/WebCore

More partial work towards "Page Cache should support pages with Frames"
​https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

This patch is primarily about the "CachedFrame tree" and making slightly different decisions
based on whether a CachedFrame is the main frame or a subframe.

  • Store whether a CachedFrame represents the main frame or a subframe.
  • "Chop off the frame tree" for the main frame when creating its CachedFrame, as main frames are reused and need to start new page loads with an empty frame tree.
  • Reattach the frame tree to the main frame when restoring it.
  • open() the cached subframes in their respective loaders when restoring.
  • Properly clear() and destroy() cached subframes.
  • When committing to a new page load, and after caching the previous page, only clear the FrameView for the main frame.

Note that all of above will eventually be necessary as I continue to land this work in pieces,
but doesn't actually change any behavior right now because we still refuse to even *try* to
cache pages with frames.

No new tests. No change in behavior, and current tests continue to pass.

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::restore):
(WebCore::CachedFrame::clear):
(WebCore::CachedFrame::destroy):

  • history/CachedFrame.h:

(WebCore::CachedFrame::isMainFrame):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::open):

  • loader/FrameLoader.h:
11:32 AM Changeset in webkit [47984] by beidson@apple.com
  • 2 edits in trunk/WebCore

No review, build fix.

​http://trac.webkit.org/changeset/47976 broke the build.
Let's try compiling before we land things, shall we?

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData): Order the initialization list correctly.

11:28 AM Changeset in webkit [47983] by kevino@webkit.org
  • 11 edits in trunk

waf build fixes for Windows/MSVC and Mac/Snow Leopard.

11:14 AM Changeset in webkit [47982] by benm@google.com
  • 2 edits in trunk/WebCore

Unreviewed build fix for Chromium.

Missed #including V8Proxy.h in WebCore/bindings/v8/V8Binding.cpp.

  • bindings/v8/V8Binding.cpp: add V8Proxy.h as an include
11:03 AM Changeset in webkit [47981] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

wx port: Call WTF::initializeThreading().
​https://bugs.webkit.org/show_bug.cgi?id=28912

10:41 AM Changeset in webkit [47980] by kevino@webkit.org
  • 2 edits in trunk/WebCore

waf build fix, don't define symbols we now grab from other sources.

10:39 AM Changeset in webkit [47979] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix for building on Windows.

10:34 AM Changeset in webkit [47978] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Build fixes for PluginViewNone.cpp and a wx build fix for PluginView.cpp.

10:32 AM Changeset in webkit [47977] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Use the 2 param KURL constructor.

10:10 AM Changeset in webkit [47976] by yong.li@torchmobile.com
  • 3 edits in trunk/WebCore

2009-09-02 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by Eric Seidel.

Fix the build failure of WebKit for Linux/Qt when WML is enabled

No test cases needed since this just fixes the build problem.

  • wml/WMLElement.cpp: (WebCore::WMLElement::create):
  • wml/WMLTableElement.cpp: (WebCore::WMLTableElement::joinSuperflousColumns): (WebCore::WMLTableElement::padWithEmptyColumns):
9:37 AM Changeset in webkit [47975] by yong.li@torchmobile.com
  • 5 edits in trunk/WebCore

2009-09-02 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Barth.

WINCE PORT: use shared buffer for custom font data
​https://bugs.webkit.org/show_bug.cgi?id=27734

Refactored by Joe Mason <​joe.mason@torchmobile.com>

  • loader/CachedFont.cpp: add WINCE to platforms using cached custom data
  • platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::renameFont): implement for WinCE
  • platform/graphics/opentype/OpenTypeUtilities.h: build fixes
  • platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::setCustomFontCache): add accessor (WebCore::createFontCustomPlatformData): change param to SharedBuffer
  • platform/graphics/wince/FontCustomPlatformData.h: update function signatures
9:32 AM Changeset in webkit [47974] by yong.li@torchmobile.com
  • 5 edits in trunk/WebCore

2009-09-02 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Barth.

WINCE PORT: font-related build fixes and minor bugfixes
​https://bugs.webkit.org/show_bug.cgi?id=27734

  • platform/graphics/FontCache.h: declare functions added in ​https://bugs.webkit.org/show_bug.cgi?id=27509
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): fix ambiguous overload error in min/max on Windows
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): initialize member vars
  • platform/graphics/SimpleFontData.h: disable unused members on Wince to save space
8:54 AM Changeset in webkit [47973] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2009-09-02 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Another pass at releasing the storage mutex.
​https://bugs.webkit.org/show_bug.cgi?id=28904

Another pass at releasing the storage mutex (when applicable) when we finish
executing JavaScript. ​http://dev.w3.org/html5/spec/Overview.html#storage-mutex
describes the required behavior.

As it turns out, ​https://bugs.webkit.org/show_bug.cgi?id=28789 didn't solve
the problem correctly. First of all, I missed that events and timeouts go
through a different call path. Second of all, I didn't consider recursion
correctly. Third of all, my check to see if LocalStorage is alive actually
instantiates it if it isn't yet. Fourth, I forgot DOM_STORAGE guards around
it. So I'm reverting that change completely and doing it more cleanly.
Unfortunately, the solution isn't as portable (and thus I've left out the JSC
implementation for now).

NOTE: This change now tracks recursion on function callbacks in V8. I ran this
by Mads Ager and Mike Belshe and they seemed to think adding the checks were
fine. Most callbacks are asynchronous and thus wouldn't be nested. The few
scenareos where you can have nested callbacks probably should have always been
protected by a recursion guard.

Unfortunately, this can't be tested without a hook added to the layout test
controllers since the lock is (by design) not supposed to be observable by
JavaScript. ​https://bugs.webkit.org/show_bug.cgi?id=28906

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): revert
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): revert
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript):

Add releaseStorageMutex call. A small amount of clean up.

(WebCore::V8Proxy::callFunction):

Add releaseStorageMutex call. A small amount of clean up.

(WebCore::V8Proxy::releaseStorageMutex):

Check to see if localStorage has been instantiated. If so, tell it to
unlock all storage areas.

  • bindings/v8/V8Proxy.h:
  • page/PageGroup.h: (WebCore::PageGroup::hasLocalStorage): Make hasLocalStorage public.
8:48 AM Changeset in webkit [47972] by kevino@webkit.org
  • 4 edits in trunk/WebKitTools

Reviewed by Eric Seidel.

Changes needed for build-webkit to support the waf build system for the wx port.

​https://bugs.webkit.org/show_bug.cgi?id=27619

8:24 AM Changeset in webkit [47971] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts

Reviewed by Eric Seidel.

  • Scripts/update-webkit: Added "--accept postpone" to @svnOptions when running with svn-1.6 or newer.
8:24 AM Changeset in webkit [47970] by ddkilzer@apple.com
  • 5 edits in trunk/WebKitTools

Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()

Reviewed by Eric Seidel.

  • Scripts/VCSUtils.pm: (@EXPORT): Added &isSVNVersion16OrNewer. (svnVersion): Added. Internal method that gets the SVN version and caches it. (isSVNVersion16OrNewer): Added. Method that does the SVN 1.6 version check.
  • Scripts/prepare-ChangeLog: Switched to use new isSVNVersion16OrNewer() method.
  • Scripts/resolve-ChangeLogs: Ditto.
  • Scripts/svn-create-patch: Ditto.
8:24 AM Changeset in webkit [47969] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Clean up VCSUtils.pm

Reviewed by Eric Seidel.

  • Scripts/VCSUtils.pm: Added proper package statement. Fixed indentation of BEGIN block. Listed each exported method on a line by itself. Added methods to the export list after adding the package statement. Sorted module variables. Moved definiton of $gitRoot next to other module variables.
8:19 AM Changeset in webkit [47968] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-09-02 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Barth.

WINCE PORT: Implement ImageBuffer for WINCE
Implement Image interface with a light class BufferedImage
for rendering ImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=28167

  • platform/graphics/wince/ImageBufferData.h: Added.
  • platform/graphics/wince/ImageBufferWince.cpp: Added.
7:24 AM Changeset in webkit [47967] by vestbo@webkit.org
  • 8 edits in trunk/WebCore

Join the various PluginView destructors into one shared implementation

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=27706

The Qt port used to delete the platform plugin widget as the last step.
Now this is done before cleaning up the script objects and unloading the
plugin package, similar to how the Win port does it.

  • plugins/PluginView.cpp:
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
6:50 AM Changeset in webkit [47966] by vestbo@webkit.org
  • 8 edits in trunk/WebCore

Share PluginView::init() between ports

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=27706

The port-spesific bits are moved to platformStart(), which now returns
a bool based on the success of the platformStart.

m_hasPendingGeometryChange is now initialized in the initializer list
instead of in PluginViewQt's init()

PluginViewMac (currently used only by the Qt port) used to manually call
stop() in the case where an unsupported drawing or event model was detected.
This was wrong, as the m_status and m_isStarted fields should be used to
guard against doing operations on a plugin in this intermediate state.

  • plugins/PluginView.cpp:
  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginViewMac.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
6:06 AM Changeset in webkit [47965] by jmalonzo@webkit.org
  • 5 edits
    1 add in trunk

2009-09-02 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez and Gustavo Noronha.

[Gtk] Implement a WebDataSource for the gtk port
​https://bugs.webkit.org/show_bug.cgi?id=24758

Add data source API getters to WebKitWebFrame.
Also add WebKitWebDataSource unit test.

  • tests/testwebdatasource.c: Added.
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:

Add WebKitWebDataSource unit test to the build script

  • GNUmakefile.am:
5:58 AM Changeset in webkit [47964] by jmalonzo@webkit.org
  • 8 edits
    4 adds in trunk

2009-09-02 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez and Gustavo Noronha.

[Gtk] Implement a WebDataSource for the gtk port
​https://bugs.webkit.org/show_bug.cgi?id=24758

Subclass DocumentLoader for Gtk and implement it under the WebKit
namespace. Add WebKitWebDataSource implementation that closely
follows the mac implementation of the API.

  • WebCoreSupport/DocumentLoaderGtk.cpp: Added.
  • WebCoreSupport/DocumentLoaderGtk.h: Added.
  • webkit/webkitwebdatasource.cpp: Added.
  • webkit/webkitwebdatasource.h: Added.

Add WebKitWebDataSource and DocumentLoaderGtk to the build script.

  • GNUmakefile.am:
5:40 AM Changeset in webkit [47963] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Make sure we relayout the page after evaluating JS

Patch by Richard Moore <​rich@kde.org> on 2009-09-02
Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=28235

QtWebKit does not always seem to reflow the page when evaluating
javascript. This patch changes the way evaluateJavaScript works to
use the frameloader which ensures that this is done properly.

  • Api/qwebframe.cpp:

(QWebFrame::evaluateJavaScript):

  • tests/qwebframe/tst_qwebframe.cpp:
4:38 AM Changeset in webkit [47962] by benm@google.com
  • 7 edits in trunk

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=28737

Patch by Ben Murdoch <​benm@google.com> on 2009-09-02
Update JavaScript bindings in JSC and V8 for SQLTransaction to throw exceptions in the right places.

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql): Throw an exception if no parameters are passed to executeSql().

  • bindings/v8/V8Binding.cpp:

(WebCore::v8ValueToWebCoreString): Catch an exception if thrown from toString().

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL): Allow "arrayish objects" to be passed to executeSql.

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=28737

Patch by Ben Murdoch <​benm@google.com> on 2009-09-02
Update the execute-sql-args.html to be agnostic to exception message formatting between JSC and V8 and throw an exception when no parameters are passed to the executeSql() function.

  • storage/execute-sql-args-expected.txt:
  • storage/execute-sql-args.html:
3:16 AM Changeset in webkit [47961] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Fix layout-test plugins/plugin-javascript-access.html

Rubber-stamped by Simon Hausmann.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • platform/qt/Skipped:
2:59 AM Changeset in webkit [47960] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2009-09-01 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Migrate Databases tab to InjectedScript /
serialized interaction.

​https://bugs.webkit.org/show_bug.cgi?id=28873

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.isDB): (WebInspector.Database.prototype.runWithTableNames.sortingCallback): (WebInspector.Database.prototype.runWithTableNames): (WebInspector.Database.prototype.executeSql): (WebInspector.Database.prototype.executeSql.errorCallback): (WebInspector.Database.prototype.executeSql.queryTransaction):
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): (WebInspector.DatabaseQueryView.prototype._queryFinished):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.selectDatabase): (WebInspector.StoragePanel.prototype.updateDatabaseTables.withTableNames): (WebInspector.StoragePanel.prototype.updateDatabaseTables): (WebInspector.DatabaseSidebarTreeElement.prototype.onpopulate.withTableNames): (WebInspector.DatabaseSidebarTreeElement.prototype.onpopulate):
2:49 AM Changeset in webkit [47959] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-09-02 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Eric Seidel.

Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled

RegisterFile constructor currently throws #error when both
MMAP and VIRTUALALLOC conditions fail.
On any platform that does not provide these features
(for instance, Symbian),
the fallback should be regular malloc (or fastMalloc).
It is functionally equivalent in this case, even though it may
have certain drawbacks such as lack of dynamic pre-allocation.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::~RegisterFile):
  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
2:46 AM Changeset in webkit [47958] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-09-02 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed (trivial followup fix).


Web Inspector: Trivial follow up fix to r47944.

​https://bugs.webkit.org/show_bug.cgi?id=28800

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::nodeForId):
2:44 AM Changeset in webkit [47957] by zoltan@webkit.org
  • 24 edits in trunk/LayoutTests

2009-09-02 Renata Hodovan <​hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update css2.1/t1202-counter-* and css2.1/t1205* tests after new metrics.
Remove these files from Skipped (and fixed Skipped according to Changeset 47815).

  • platform/qt/Skipped:
  • platform/qt/css2.1/t1202-counter-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-04-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-09-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-15-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-16-f-expected.txt:
  • platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-01-b-expected.txt:
  • platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
1:08 AM Changeset in webkit [47956] by eric@webkit.org
  • 5 edits
    2 moves
    1 add in trunk

2009-09-02 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
​https://bugs.webkit.org/show_bug.cgi?id=25880

make-script-wrappers supports both resources and script-tests directories.
run-webkit-tests ignores files in script-tests.
Move script tests of animations to check the new script is working.

  • animations/animation-css-rule-types.html:
  • animations/resources/TEMPLATE.html: Removed.
  • animations/resources/animation-css-rule-types.js: Removed.
  • animations/script-tests: Added.
  • animations/script-tests/TEMPLATE.html: Copied from LayoutTests/animations/resources/TEMPLATE.html.
  • animations/script-tests/animation-css-rule-types.js: Copied from LayoutTests/animations/resources/animation-css-rule-types.js.

2009-09-02 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
​https://bugs.webkit.org/show_bug.cgi?id=25880

make-script-wrappers supports both resources and script-tests directories.
run-webkit-tests ignores files in script-tests.
Move script tests of animations to check the new script is working.

  • Scripts/make-script-test-wrappers:
  • Scripts/run-webkit-tests:
1:01 AM Changeset in webkit [47955] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2009-09-02 Szabo Carol <​carol.szabo@nokia.com>

Reviewed by David Levin.

check-webkit-style uses python from /usr/bin instead of the PATH
​https://bugs.webkit.org/show_bug.cgi?id=28225

  • Scripts/bugzilla-tool:
  • Scripts/check-webkit-style:
  • Scripts/run-webkit-unittests:
  • Scripts/update-sources-list.py: Changed the first line from #!/usr/bin/python to #!/usr/bin/env python which causes python to be invoked from the path location returned by "which python" when any of these scripts are launched. these are currently all the python scripts in WebKitTools/Scripts.
Note: See TracTimeline for information about the timeline view.