Context Navigation

Tests for https://bugs.webkit.org/show_bug.cgi?id=27099
Make hidden elements not focusable. This is important becaue we should
not allow tabbing to a hidden element.

The patch also makes a element without href behave like generic elements
when it comes to focus. Added tests that asserts that this works as
expected.

fast/events/click-focus-anchor-expected.txt: Added.
fast/events/click-focus-anchor.html: Added.
fast/events/resources/tabindex-focus-blur-all.js: (test): (testProgrammaticFocus):
fast/events/tab-focus-anchor-expected.txt: Added.
fast/events/tab-focus-anchor.html: Added.
fast/events/tab-focus-hidden-expected.txt: Added.
fast/events/tab-focus-hidden.html: Added.
fast/events/tabindex-focus-blur-all-expected.txt:

2009-09-06 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Make hidden elements not focusable.

Clean up supportsFocus and isFocusable.
supportsFocus now strictly means that the node can be focused by default.
This is true for links, form controls and content editable elements for example.
isFocusable means that the user can actually focus it.
All (2) calls to supportsFocus have been updated to take this into account.

Make a elements without href work correctly as well.

https://bugs.webkit.org/show_bug.cgi?id=27099

Tests: fast/events/click-focus-anchor.html

fast/events/tab-focus-anchor.html
fast/events/tab-focus-hidden.html

dom/Element.cpp: (WebCore::Element::focus):
dom/Node.cpp: (WebCore::Node::supportsFocus): (WebCore::Node::isFocusable):
dom/Node.h:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::isMouseFocusable): (WebCore::HTMLAnchorElement::isKeyboardFocusable):
html/HTMLAnchorElement.h:
html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::supportsFocus):
html/HTMLAreaElement.h:
html/HTMLElement.cpp: (WebCore::HTMLElement::supportsFocus):
html/HTMLElement.h:
html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::supportsFocus):
html/HTMLFieldSetElement.h:
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::supportsFocus): (WebCore::HTMLFormControlElement::isFocusable):
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::supportsFocus):
html/HTMLFrameElementBase.h:
html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::supportsFocus):
html/HTMLLegendElement.h:
html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::supportsFocus): (WebCore::HTMLOptGroupElement::isFocusable):
html/HTMLOptGroupElement.h:
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::supportsFocus): (WebCore::HTMLOptionElement::isFocusable):
html/HTMLOptionElement.h:
page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
page/FocusController.cpp: (WebCore::FocusController::advanceFocus):
svg/SVGAElement.cpp: (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable):
wml/WMLAElement.cpp: (WebCore::WMLAElement::supportsFocus):
wml/WMLAElement.h:
wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::supportsFocus): (WebCore::WMLFormControlElement::isFocusable):
wml/WMLFormControlElement.h:

9:15 PM Changeset in webkit [48105] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-06 Joel Stanley <joel@jms.id.au>

Reviewed by Dimitri Glazkov.

Expose functions to set the caret blink interval for Linux Chromium.
Default value is set to that of RenderTheme::caretBlankInterval().
Uses caretBlinkIntervalInternal to avoid overriding
RenderThemeChromiumSkia::caretBlankInterval to preserve the disabling
of blinking caret required for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=28931

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
rendering/RenderThemeChromiumLinux.h:

7:27 PM Changeset in webkit [48104] by adachan@apple.com

2 edits in trunk/WebCore

Remove an extra </File> in WebCore.vcproj.

WebCore.vcproj/WebCore.vcproj:

3:44 PM Changeset in webkit [48103] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update the unitests to latest changes wrt scrollbar policy.

tests/testwindow.c: (test_webkit_window_scrollbar_policy):

1:43 PM Changeset in webkit [48102] by timothy@apple.com

6 edits
1 add in trunk/WebCore

Adds a persistent setting for color format in the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=28889

Reviewed by Dan Bernstein.

English.lproj/localizedStrings.js: New strings.
inspector/front-end/Color.js: Minor style fixes.

(WebInspector.Color.prototype.toString): Added. Replaces the individual
"toFoo" functions. Takes a optional arguments for the color format to return.

inspector/front-end/Images/paneSettingsButtons.png: Added.
inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._changeColorFormat): Update the sections to show
the new color format.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay):
Use the new toString function on Color.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Use the persistent setting
to format colors by default. Add a tooltip for the color swatch.

inspector/front-end/inspector.css: New styles for the settings menu.
inspector/front-end/inspector.js:

(WebInspector.loaded): Initilize the colorFormat preference.

7:31 AM Changeset in webkit [48101] by xan@webkit.org

15 edits
4 adds in trunk

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

GNUmakefile.am:

LayoutTests:

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

platform/gtk/Skipped:

WebKit/gtk:

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
webkit/webkit.h:
webkit/webkitdefines.h:
webkit/webkitprivate.cpp: (webkit_init):
webkit/webkitprivate.h:
webkit/webkitsecurityorigin.cpp: Added. (webkit_security_origin_finalize): (webkit_security_origin_dispose): (webkit_security_origin_set_property): (webkit_security_origin_get_property): (webkit_security_origins): (webkit_security_origin_class_init): (webkit_security_origin_init): (webkit_security_origin_get_protocol): (webkit_security_origin_get_host): (webkit_security_origin_get_port): (webkit_security_origin_get_web_database_usage): (webkit_security_origin_get_web_database_quota): (webkit_security_origin_set_web_database_quota): (webkit_security_origin_get_all_web_databases): (WebKit::kit): (WebKit::core): (webkit_security_origin_get_web_database):
webkit/webkitsecurityorigin.h: Added.
webkit/webkitwebdatabase.cpp: Added. (webkit_web_database_finalize): (webkit_web_database_dispose): (webkit_web_database_set_property): (webkit_web_database_get_property): (webkit_web_database_class_init): (webkit_web_database_init): (webkit_web_database_set_security_origin): (webkit_web_database_set_name): (webkit_web_database_get_security_origin): (webkit_web_database_get_name): (webkit_web_database_get_display_name): (webkit_web_database_get_expected_size): (webkit_web_database_get_size): (webkit_web_database_get_filename): (webkit_web_database_remove): (webkit_remove_all_web_databases): (webkit_get_web_database_directory_path): (webkit_set_web_database_directory_path): (webkit_get_default_web_database_quota):
webkit/webkitwebdatabase.h: Added.
webkit/webkitwebframe.cpp: (webkit_web_frame_new): (webkit_web_frame_get_focused_accessible_element): (webkit_web_frame_get_horizontal_scrollbar_policy):
webkit/webkitwebframe.h:
webkit/webkitwebview.cpp: (webkit_web_view_class_init):

5:38 AM Changeset in webkit [48100] by Laszlo Gombos

3 edits in trunk/WebCore

2009-09-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Remove Qt v4.6 check from the prefetchDNS implementation
https://bugs.webkit.org/show_bug.cgi?id=28993

platform/network/qt/DnsPrefetchHelper.cpp:
platform/network/qt/DnsPrefetchHelper.h:

12:24 AM Changeset in webkit [48099] by eric@webkit.org

24 edits
3 deletes in trunk

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

Update test not to expect a <definition-src> element to be of type
SVGDefinitionSrcElement.

svg/dom/font-face-elements-expected.txt:
svg/dom/font-face-elements.html:

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

http://dev.w3.org/SVG/profiles/1.1F2/publish/changes.html#FontsChapter

DerivedSources.cpp: Remove references to definition-src.
DerivedSources.make: Ditto.
GNUmakefile.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/objc/DOM.mm: (WebCore::createElementClassMap): Ditto.
bindings/objc/DOMSVG.h: Ditto.
bindings/v8/DerivedSourcesAllInOne.cpp: Ditto.
bindings/v8/V8DOMWrapper.cpp: Ditto.
bindings/v8/V8Index.cpp: Ditto.
bindings/v8/V8Index.h: Ditto.
svg/SVGAllInOne.cpp: Ditto.
svg/SVGDefinitionSrcElement.cpp: Removed.
svg/SVGDefinitionSrcElement.h: Removed.
svg/SVGDefinitionSrcElement.idl: Removed.
svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): Don't search for definition-src child.
svg/svgtags.in: Remove definition-src.

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

MigrateHeaders.make: Remove reference to ObjC definition-src binding class.

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

When SVG 1.1 Second Edition is a Recommendation we can remove the
entry altogether.

projects/svg/status.xml: Update page to state that <definition-src> is not supported.

Sep 5, 2009:

9:09 PM Changeset in webkit [48098] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-09-05 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Roll out http://trac.webkit.org/changeset/48094, because the
logic of retrieving default caret blink interval was incorrect (non-existent)
and caused layout test flakiness.

rendering/RenderThemeChromiumLinux.cpp:
rendering/RenderThemeChromiumLinux.h:

8:57 PM MathML Goals edited by alex@milowski.com

(diff)

4:47 PM Changeset in webkit [48097] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-05 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] r47424 broke binary compatibility
https://bugs.webkit.org/show_bug.cgi?id=28996

Append the new DnsPrefetchEnabled attribute at the end of the enum.

Api/qwebsettings.h:

10:42 AM Changeset in webkit [48096] by jianli@chromium.org

2 edits in trunk/WebCore

Back up partial change in r48072 in order to fix chromium reliability build break.

Reviewed by NOBODY (Chromium reliability build break).

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

2:13 AM Changeset in webkit [48095] by eric@webkit.org

6 edits in trunk/WebCore

2009-09-05 Nicolas Weber <thakis@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=28975
Fix file upload on chrome/mac. Images that have "Hide Extension" set,
such as screenshots by default, can now be uploaded to sites such as
imgur.com.

platform/FileSystem.h: Add pathGetDisplayFileName().
platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth): Call pathGetDisplayFileName() instead of pathGetFileName().
platform/chromium/FileSystemChromiumLinux.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().
platform/chromium/FileSystemChromiumMac.mm: (WebCore::pathGetFileName): Now returns a real filename instead of a presentational one, which fixes the problem addressed by this change. (WebCore::pathGetDisplayFileName): New function that returns a presentational filename; does what pathGetDisplayFileName() did prior to this patch.
platform/chromium/FileSystemChromiumWin.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().

2:05 AM Changeset in webkit [48094] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-05 Joel Stanley <joel@jms.id.au>

Reviewed by David Levin.

Expose functions to set the caret blink interval for Linux Chromium.
https://bugs.webkit.org/show_bug.cgi?id=28931

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkInterval):
rendering/RenderThemeChromiumLinux.h:

1:43 AM Changeset in webkit [48093] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-09-05 Eric Seidel <eric@webkit.org>

No review, results update only.

Update results after r48043.

fast/js/JSON-stringify-expected.txt:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed