⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 9, 2009:

11:58 PM Changeset in webkit [48246] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Call the right base class function QGraphicsWidget::event() instead
of skipping it and using QObject::event() instead.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-09
Reviewed by Tor Arne Vestbø.

  • Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::event):

11:47 PM Changeset in webkit [48245] by Chris Fleizach
  • 2 edits in trunk/WebCore

AX notifications should be an ENUM type instead of strings
​https://bugs.webkit.org/show_bug.cgi?id=28963

Build fix for Qt.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):

11:38 PM Changeset in webkit [48244] by Chris Fleizach
  • 15 edits in trunk/WebCore

AX notifications should be an ENUM type instead of strings
​https://bugs.webkit.org/show_bug.cgi?id=28963

Reviewed by Darin Adler.

Moves AX notifications over to an ENUM type instead of
using the actual string values that are used on OS X.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):

  • editing/mac/SelectionControllerMac.mm:

(WebCore::SelectionController::notifyAccessibilityForSelectionChange):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::setInnerTextValue):

10:25 PM Changeset in webkit [48243] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-09-09 Eric Seidel <​eric@webkit.org>

Reviewed by Eric Carlson.

reviewer/committer lookups are backwards
​https://bugs.webkit.org/show_bug.cgi?id=29113

I also moved Eric Carlson from the committer list to the reviewer list now that he is one.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/committers.py:
10:17 PM Changeset in webkit [48242] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-09-09 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

svn-unapply doesn't revert directories correctly
​https://bugs.webkit.org/show_bug.cgi?id=29065

  • Scripts/svn-unapply: Make svnStatus consistently return status lines including a newline.
  • Scripts/svn-apply: Keep svnStatus in sync with the one in svn-unapply, in lieu of moving it to a common file.
9:52 PM Changeset in webkit [48241] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Update data/params parameters

  • data/params: Updated 'attachment_base' parameter for secure attachments. Updated 'mybugstemplate' parameter to search for bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to NEW status.
7:54 PM Changeset in webkit [48240] by abarth@webkit.org
  • 3 edits
    5 adds in trunk

2009-09-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Missing checkout for getSVGDocument()
​https://bugs.webkit.org/show_bug.cgi?id=29064

The V8 code generator didn't understand SVGCheckSecurityDocument.

Tests: http/tests/security/xss-DENIED-getSVGDocument-iframe.html

http/tests/security/xss-DENIED-getSVGDocument-object.html

  • bindings/scripts/CodeGeneratorV8.pm:

2009-09-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Missing checkout for getSVGDocument()
​https://bugs.webkit.org/show_bug.cgi?id=29064

Add tests that getSVGDocument() has the proper checks.

  • http/tests/security/resources/flag.php: Added.
  • http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt: Added.
  • http/tests/security/xss-DENIED-getSVGDocument-iframe.html: Added.
  • http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt: Added.
  • http/tests/security/xss-DENIED-getSVGDocument-object.html: Added.
5:55 PM Changeset in webkit [48239] by eric@webkit.org
  • 5 edits
    6 adds in trunk

2009-09-09 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement inherit from SVGLangSpace
​https://bugs.webkit.org/show_bug.cgi?id=29058

Required by SVG 1.1 Second Edition:
​http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement

  • svg/dom/SVGStyleElement: Added.
  • svg/dom/SVGStyleElement/resources: Added.
  • svg/dom/SVGStyleElement/resources/TEMPLATE.html: Copied from LayoutTests/svg/dom/resources/TEMPLATE.html with some "../"s added.
  • svg/dom/SVGStyleElement/resources/style-langspace.js: Added.
  • svg/dom/SVGStyleElement/style-langspace-expected.txt: Added.
  • svg/dom/SVGStyleElement/style-langspace.html: Added.

2009-09-09 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement inherit from SVGLangSpace
​https://bugs.webkit.org/show_bug.cgi?id=29058

Required by SVG 1.1 Second Edition:
​http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement

Test: svg/dom/SVGStyleElement/style-langspace.html

  • svg/SVGStyleElement.cpp: Drop methods xmlspace and setXmlspace. (WebCore::SVGStyleElement::SVGStyleElement): Add SVGLangSpace() initializer. (WebCore::SVGStyleElement::parseMappedAttribute): Call parseMappedAttribute on SVGLangSpace.
  • svg/SVGStyleElement.h: Drop xmlspace and setXmlspace declarations.
  • svg/SVGStyleElement.idl: Drop xmlspace attribute and add SVGLangSpace as a superinterface.
5:39 PM Changeset in webkit [48238] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-09 Nate Chapin <Nate Chapin>

Reviewed by David Levin.

Remove unnecessary includes and forward declarations in V8Proxy.h

​https://bugs.webkit.org/show_bug.cgi?id=29111

  • bindings/v8/V8Proxy.h:
4:55 PM Changeset in webkit [48237] by eric@webkit.org
  • 11 edits
    1 add in trunk/LayoutTests

2009-09-09 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

Media layout tests should have a way to provide test files in different formats
​https://bugs.webkit.org/show_bug.cgi?id=28327

Added media-file.js which has a findMediaFile(type, name) method
to find a proper media file to load according to supported codecs.

Also changed 10 layout tests to use above method to locate the test file.

  • media/controls-strict.html: Use findMediaFile(type, name).
  • media/controls-styling.html: ditto.
  • media/media-file.js: Added. Provide findMediaFile(type, name).
  • media/video-append-source.html: Use findMediaFile(type, name).
  • media/video-aspect-ratio.html: ditto.
  • media/video-autoplay.html: ditto.
  • media/video-buffered.html: ditto.
  • media/video-controls-rendering.html: ditto.
  • media/video-layer-crash.html: ditto.
  • media/video-transformed.html: Use findMediaFile(type, name).
  • media/video-zoom-controls.html: ditto.
4:41 PM Changeset in webkit [48236] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-09 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

svn-apply doesn't handle changes to files copied to new directories properly
​https://bugs.webkit.org/show_bug.cgi?id=29059

  • Scripts/svn-apply: Don't treat "--- revision 0" patches as being additions if we know that we've just copied a file to this name.
4:25 PM Changeset in webkit [48235] by eric@webkit.org
  • 6 edits in trunk/WebCore

2009-07-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add more position constructors
positionBeforeNode, positionAfterNode
firstPositionInNode, lastPositionInNode
​https://bugs.webkit.org/show_bug.cgi?id=25494

I also added a lastOffsetInNode and deployed it to a couple places.

There are no callers to these new constructors yet, but those
will be coming in future patches.

  • dom/Position.cpp: (WebCore::Position::computeOffsetInContainerNode):
  • dom/Position.h: (WebCore::positionBeforeNode): (WebCore::positionAfterNode): (WebCore::lastOffsetInNode): (WebCore::firstPositionInNode): (WebCore::lastPositionInNode):
  • editing/ApplyStyleCommand.cpp:
  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
  • editing/htmlediting.cpp: (WebCore::lastOffsetForEditing):
4:25 PM Changeset in webkit [48234] by eric@webkit.org
  • 16 edits
    1 add in trunk/WebCore

2009-07-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename positionBeforeNode to positionInParentBeforeNode
and positionAfterNode to positionInParentAfterNode
in preparation for adding a positionBeforeNode
which returns a neighbor-anchored position.
​https://bugs.webkit.org/show_bug.cgi?id=25494

No functional changes, thus no tests.

  • dom/PositionConstructors.h: (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply):
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::deleteTarget):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::updatePositionForNodeRemoval):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::rangeCompliantEquivalent): (WebCore::positionBeforeContainingSpecialElement): (WebCore::positionAfterContainingSpecialElement): (WebCore::positionBeforeTabSpan):
4:25 PM Changeset in webkit [48233] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-07-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Re-organize position creation functions in preparation for adding more
​https://bugs.webkit.org/show_bug.cgi?id=25494

Make position functions inline to avoid ref-churn.
Remove startPosition/endPosition as they were only used in one place.

No functional changes, thus no tests.

  • dom/Position.cpp:
  • dom/Position.h: (WebCore::positionBeforeNode): (WebCore::positionAfterNode):
  • editing/SelectionController.cpp: (WebCore::SelectionController::moveTo):
  • editing/TypingCommand.cpp:
  • editing/htmlediting.cpp:
  • editing/htmlediting.h: (WebCore::firstDeepEditingPositionForNode): (WebCore::lastDeepEditingPositionForNode):
  • rendering/RenderObject.cpp:
3:50 PM Changeset in webkit [48232] by kevino@webkit.org
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Add wxSize conversions for IntSize.
​https://bugs.webkit.org/show_bug.cgi?id=29104

3:35 PM Changeset in webkit [48231] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-09 Yaar Schnitman <​yaar@chromium.org>

Reviewed by David Levin.

Chromium uses its own config.h file that was forked from webkit's config.h.
By merging in Chromium's defines, Chromium would again be able to use webkit's
config.h.

​https://bugs.webkit.org/show_bug.cgi?id=28882

  • config.h: Added chromium-specific defines.
3:21 PM Changeset in webkit [48230] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-09-09 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

commit-queue hangs if a builder has never built
​https://bugs.webkit.org/show_bug.cgi?id=29091

  • Scripts/modules/buildbot.py:
  • Scripts/modules/buildbot_unittest.py:
3:19 PM Changeset in webkit [48229] by eric@webkit.org
  • 10 edits
    2 adds in trunk

2009-09-09 Jens Alfke <​snej@chromium.org>

Reviewed by Eric Seidel.

Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
​https://bugs.webkit.org/show_bug.cgi?id=26700

  • fast/events/drag-dropeffect-expected.txt: Added.
  • fast/events/drag-dropeffect.html: Added.

2009-09-09 Jens Alfke <​snej@chromium.org>

Reviewed by Eric Seidel.

Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
​https://bugs.webkit.org/show_bug.cgi?id=26700

  • At the start of a drag operation, the value of effectAllowed should be the string "uninitialized".
  • At end of dragstart handler, if effectAllowed hasn't been set yet, it should be set to "copy".
  • on dragenter and dragover event, dropEffect should be initialized to a default value based on the value of effectAllowed.
  • at end of dragenter and dragover the dropEffect should be set to "none" if the value set by the handler doesn't match the effectAllowed.
  • on dragleave event, dropEffect should be "none".
  • on drop event, dropEffect should be the previously negotiated value.

Test: fast/events/drag-dropeffect.html

  • WebCore.base.exp:

Added a parameter to EventHandler::dragSourceMovedTo.

  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):

Initialize m_effectAllowed to "uninitialized".

(WebCore::Clipboard::sourceOperation):

Treat "uninitialized" as meaning no value has been set.

  • page/DragController.cpp: (WebCore::DragController::DragController):

Initialize new member m_destinationDragOperation.

(WebCore::DragController::dragExited):

Set m_destinationDragOperation to none on dragExit.

(WebCore::DragController::performDrag):

Set m_destinationDragOperation to current dropEffect.

(WebCore::DragController::dragEnteredOrUpdated):

Make sure to clear the operation if drag source doesn't allow it.

(WebCore::DragController::tryDHTMLDrag):

Set a default value for the dst drag op before sending dragEnter/Over.

(WebCore::DragController::startDrag):

Clear m_destinationDragOperation at start of drag.

  • page/DragController.h: (WebCore::DragController::destinationDragOperation):

Added new member m_destinationDragOperation, and its public getter.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop):

dropEffect should be 'none' during dropleave handler, per spec.

(WebCore::EventHandler::dragSourceMovedTo):

Added DragOperation parameter, so the handler sees the current dropEffect.

(WebCore::EventHandler::handleDrag):

Assume DragOperationEvery for non-DHTML drags.

  • page/EventHandler.h:

Added DragOperation parameter to dragSourceMovedTo().

2009-09-09 Jens Alfke <​snej@chromium.org>

Reviewed by Eric Seidel.

Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
​https://bugs.webkit.org/show_bug.cgi?id=26700

  • WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]):

Pass current drag operation (if known) to EventHandler::dragSourceMovedTo().

3:10 PM Changeset in webkit [48228] by eric@webkit.org
  • 8 edits
    2 adds in trunk

2009-09-09 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] DumpRenderTree needs eventSender object and implementation
​https://bugs.webkit.org/show_bug.cgi?id=25990

Enable plenty of tests that now pass thanks to (only) partial
EventSender implementation.

  • platform/gtk/Skipped:

2009-09-09 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] DumpRenderTree needs eventSender object and implementation
​https://bugs.webkit.org/show_bug.cgi?id=25990

Creates a function that is accessible from the DumpRenderTree tool
and calls the layout method on the frame view.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_layout):

2009-09-09 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] DumpRenderTree needs eventSender object and implementation
​https://bugs.webkit.org/show_bug.cgi?id=25990

Implements most of the EventSender object's functionality for
the DumpRenderTree tool. Implementation still lacks support
for drag and drop tests and forward leaps.

Based on work by Holger Hans Peter Freyther.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Focus on the view before loading a new test. (webViewWindowObjectCleared):
  • DumpRenderTree/gtk/EventSender.cpp: Added. (getDragModeCallback): (setDragModeCallback): (leapForwardCallback): (contextClickCallback): (updateClickCount): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (beginDragWithFilesCallback): (replaySavedEvents): (keyDownCallback): (textZoomInCallback): (textZoomOutCallback): (zoomPageInCallback): (zoomPageOutCallback): (getClass): (makeEventSender):
  • DumpRenderTree/gtk/EventSender.h: Added.
  • GNUmakefile.am: Add build rules for EventSender.
2:35 PM Changeset in webkit [48227] by eric@webkit.org
  • 14 edits
    2 adds in trunk

2009-09-09 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding a test for the database authorizer.

​https://bugs.webkit.org/show_bug.cgi?id=28918

  • storage/test-authorizer-expected.txt: Added.
  • storage/test-authorizer.html: Added.

2009-09-09 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Dimitri Glazkov.

  1. Adding support/bindings for read-only transactions.
  2. Disallowing the SQLITE_*_VIEW and REINDEX operations in the private browsing mode.
  3. Adding an authorizer test.

​https://bugs.webkit.org/show_bug.cgi?id=28918

Test: storage/test-authorizer.html

  • bindings/js/JSDatabaseCustom.cpp: (WebCore::createTransaction): Parses all arguments and executes a transaction. (WebCore::JSDatabase::transaction): Refactored to use createTransaction(). (WebCore::JSDatabase::readTransaction): Added to execute read-only transactions using createTransaction().
  • bindings/v8/custom/V8CustomBinding.h: Added the binding for Database::readTransaction().
  • bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::createTransaction): Parses all arguments and executes a transaction. (WebCore::transaction): Refactored to use createTransaction(). (WebCore::readTransaction): Added to execute read-only transactions using createTransaction().
  • storage/Database.cpp: (WebCore::Database::transaction): Added support for read-only transactions.
  • storage/Database.h: Added support for read-only transactions.
  • storage/Database.idl: Added support for read-only transactions.
  • storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::createTempTable): Make it obvious that the statement will be denied in private browsing mode and read-only transactions. (WebCore::DatabaseAuthorizer::dropTempTable): Same. (WebCore::DatabaseAuthorizer::createTempIndex): Same. (WebCore::DatabaseAuthorizer::dropTempIndex): Same. (WebCore::DatabaseAuthorizer::createTempTrigger): Same. (WebCore::DatabaseAuthorizer::dropTempTrigger): Same. (WebCore::DatabaseAuthorizer::createView): Deny in private browsing mode and read-only transactions. (WebCore::DatabaseAuthorizer::createTempView): Same. (WebCore::DatabaseAuthorizer::dropView): Same. (WebCore::DatabaseAuthorizer::dropTempView): Same. (WebCore::DatabaseAuthorizer::allowReindex): Same.
  • storage/DatabaseAuthorizer.h:
  • storage/SQLTransaction.cpp: Added support for read-only transactions. (WebCore::SQLTransaction::create): (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::acquireLock):
  • storage/SQLTransaction.h:
  • storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::acquireLock): Added a new parameter in preparation for a change that will allow multiple read-only transactions on the same DB to run concurrently.
  • storage/SQLTransactionCoordinator.h:
2:30 PM QtWebKitContrib edited by vestbo@webkit.org
(diff)
2:28 PM Changeset in webkit [48226] by vestbo@webkit.org
  • 2 edits in trunk/WebKitSite

Add instructions to bug reporting guidlines on how and when
to apply port-specific keywords.

Reviewed by Mark Rowe.

  • quality/bugwriting.html:
2:21 PM Changeset in webkit [48225] by hyatt@apple.com
  • 4 edits in trunk/WebCore/page

Fix namespace typos.

2:21 PM Changeset in webkit [48224] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/FrameTree.cpp

Fix namespace typos.

2:18 PM Changeset in webkit [48223] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix comment at Tor Arne Vestbø's request.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09

  • Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):

2:12 PM Changeset in webkit [48222] by hyatt@apple.com
  • 23 edits
    4 adds in trunk

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

  • css/CSSStyleSelector.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::attach):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
  • loader/PlaceholderDocument.cpp:

(WebCore::PlaceholderDocument::attach):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentForWorld):
(WebCore::PageGroup::removeAllUserContent):

  • page/PageGroup.h:

(WebCore::PageGroup::userStyleSheets):

  • page/UserStyleSheet.h: Added.

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::source):
(WebCore::UserStyleSheet::url):
(WebCore::UserStyleSheet::patterns):
(WebCore::UserStyleSheet::worldID):

  • page/UserStyleSheetTypes.h: Added.

WebKit/mac: ​https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

  • WebView/WebView.mm:

(+[WebView _addUserStyleSheetToGroup:source:url:worldID:patterns:]):

  • WebView/WebViewPrivate.h:

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

  • platform/mac/userscripts/simple-stylesheet-expected.checksum: Added.
  • platform/mac/userscripts/simple-stylesheet-expected.png: Added.
  • platform/mac/userscripts/simple-stylesheet-expected.txt: Added.
  • userscripts/simple-stylesheet.html: Added.
2:11 PM Changeset in webkit [48221] by kenneth@webkit.org
  • 3 edits in trunk/WebKit/qt

Implement some virtual event methods so that we can fix
event-related bugs in Qt patch releases.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09
Reviewed by Tor Arne Vestbø.

  • Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):

  • Api/qwebgraphicsitem.h:
1:40 PM Changeset in webkit [48220] by Laszlo Gombos
  • 5 edits
    6 adds in trunk

2009-09-09 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] CSS Style -webkit-box-shadow is not rendered correctly on
Qt platform
​https://bugs.webkit.org/show_bug.cgi?id=23291

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): Added the ability to draw shadows for all these curves.

2009-09-09 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] -webkit-box-shadow CSS Style is not rendered correctly on
Qt platform
​https://bugs.webkit.org/show_bug.cgi?id=23291

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
  • platform/qt/fast/box-shadow/inset-expected.checksum:
  • platform/qt/fast/box-shadow/inset-expected.png:
  • platform/qt/fast/box-shadow/spread-expected.checksum:
  • platform/qt/fast/box-shadow/spread-expected.png: Updated to show the new shadows.
1:15 PM Changeset in webkit [48219] by kenneth@webkit.org
  • 8 edits
    5 adds in trunk

.: [Qt] Add the alternative QtLauncher (based on QGraphicsView) to the build.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=28862

  • WebKit.pro:

WebCore: Add the qwebgraphicsitem.cpp to the build system.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=28862

  • WebCore.pro:

WebKit/qt: Add a new QGraphicsWidget based version of the "QWebView"
under the name "QWebGraphicsItem".

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org>, Antonio Gomes <​antonio.gomes@openbossa.org> on 2009-09-09
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=28862

Includes an alternative Qt launcher using the QGraphicsView.

  • Api/headers.pri:
  • Api/qwebgraphicsitem.cpp: Added.
  • Api/qwebgraphicsitem.h: Added.
  • Api/qwebpage.h:
  • QGVLauncher/QGVLauncher.pro: Copied from WebKit/qt/QtLauncher/QtLauncher.pro.
  • QGVLauncher/main.cpp: Added.
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::scroll):

11:41 AM Changeset in webkit [48218] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-09 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Roben.


​https://bugs.webkit.org/show_bug.cgi?id=28953

Added pre- and post- build events so that on build failure, the file
buildfailed is written to the directory $(WebKitOutputDir).

  • WinLauncher/WinLauncher.vcproj:
11:09 AM Changeset in webkit [48217] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2009-09-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Change reinterpret_cast to static_cast in r48212.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
10:56 AM Changeset in webkit [48216] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove WTF_PLATFORM_FORCE_PACK as it is no longer used
​https://bugs.webkit.org/show_bug.cgi?id=29066

  • wtf/Platform.h:
10:42 AM Changeset in webkit [48215] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09
Add myself to list of committers.

  • Scripts/modules/committers.py:
10:36 AM Changeset in webkit [48214] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2009-09-08 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

commit-queue gets stuck if a non-committer sets commit-queue+ or review+
​https://bugs.webkit.org/show_bug.cgi?id=28605
​https://bugs.webkit.org/show_bug.cgi?id=28916

  • Scripts/bugzilla-tool:
    • Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit" comment now that it's used for rejecting patches for invalid committers too.
    • Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
    • Make the commit queue print patches count instead of bugs count, this also fixes ​https://bugs.webkit.org/show_bug.cgi?id=28916.
  • Scripts/modules/bugzilla.py:
    • Make _parse_attachment_element not validate reviewer/committer.
    • Share flag parsing code in _parse_attachment_flag.
    • Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
    • Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
    • Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
  • Scripts/modules/bugzilla_unittest.py:
    • Update this test to no longer expect committer/reviewer validation.
  • Scripts/modules/committers.py:
    • Return None on failed lookups instead of raising Exceptions.
  • Scripts/modules/committers_unittest.py:
    • Update tests to expect None returns instead of exceptions.
10:35 AM Changeset in webkit [48213] by kevino@webkit.org
  • 7 edits
    8 adds in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx port] Move functions in TemporaryLinkStubs.cpp out to files where
they belong.

​https://bugs.webkit.org/show_bug.cgi?id=29088

9:46 AM Changeset in webkit [48212] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2009-09-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

Implement flushing the instruction cache for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=29075

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush): Call IMB_Range to flush the instruction cache on Symbian
9:44 AM Changeset in webkit [48211] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-09-09 Erik Arvidsson <​arv@chromium.org>

Reviewed by David Levin.

Fix preference name in layout test.
​https://bugs.webkit.org/show_bug.cgi?id=29038

  • fast/events/click-focus-anchor.html:
  • fast/events/tab-focus-anchor.html:
9:27 AM Changeset in webkit [48210] by eric@webkit.org
  • 8 edits
    3 adds in trunk

2009-09-09 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Geolocation incorrectly calls error callback in case of exception in success callback.
​https://bugs.webkit.org/show_bug.cgi?id=27255

  • fast/dom/Geolocation/resources/callback-exception.js: Added. Tests that when an exception is thrown from the success callback, the error callback is not invoked.
  • fast/dom/Geolocation/callback-exception.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/callback-exception-expected.txt: Added. Expected result for above test.
  • platform/gtk/Skipped: Modified. Adds the above tests to the skipped list.

2009-09-09 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Geolocation incorrectly calls error callback in case of exception in success callback.
​https://bugs.webkit.org/show_bug.cgi?id=27255

Test: fast/dom/Geolocation/callback-exception.html

  • bindings/js/JSCustomPositionCallback.cpp: Modified. (WebCore::JSCustomPositionCallback::handleEvent): Modified. Removed raisedException out param.
  • bindings/js/JSCustomPositionCallback.h: Modified. Removed raisedException out param from handleEvent method and made handleEvent private.
  • bindings/js/JSCustomPositionErrorCallback.h: Modified. Made handleEvent private.
  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::sendPosition): Modified. No longer call error callback in case of exception in success callback.
  • page/PositionCallback.h: Modified. Removed raisedException out param from handleEvent method.
8:59 AM Changeset in webkit [48209] by benm@google.com
  • 5 edits
    6 adds in trunk

WebCore: When Geolocation permission is denied, stops watches as well as one-shots.
​https://bugs.webkit.org/show_bug.cgi?id=28305.

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

Tests: fast/dom/Geolocation/watch.html

fast/dom/Geolocation/permission-denied-stops-watches.html

  • page/Geolocation.cpp: Modified.

(WebCore::Geolocation::setIsAllowed): Modified. Marks the permission error as fatal.
(WebCore::Geolocation::handleError): Modified. If the error is fatal, stops watchers as well as one-shots.

  • page/PositionError.h: Modified.

(WebCore::PositionError::setIsFatal): Added. Marks an error as fatal.
(WebCore::PositionError::isFatal): Added. Determines whether an error is fatal.

LayoutTests: When Geolocation permission is denied, stops watches as well as one-shots.
​https://bugs.webkit.org/show_bug.cgi?id=28305.

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

  • fast/dom/Geolocation/resources/watch.js: Added. Tests that a watch correctly reports updates from the Geolocation service.
  • fast/dom/Geolocation/watch.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/watch-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Added. Tests that when Geolocation permission is denied, watches are stopped, as well as one-shots.
  • fast/dom/Geolocation/permission-denied-stops-watches.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Added. Expected result for above test.
8:15 AM Changeset in webkit [48208] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-09 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Eric Seidel.

Bug 28964 - [Chromium] ChromiumDataObject should have getter/setter interface

Added getter/setter methods and trivial inline implementations for each.
(Note that they are not yet actually used.)
Once the Chromium code is changed to use them instead of directly accessing the
member variables, the member variables should be made private and cleaned up.

No new tests (no functional behavior changed).

  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::mainURL): (WebCore::ChromiumDataObject::setMainURL): (WebCore::ChromiumDataObject::mainURLTitle): (WebCore::ChromiumDataObject::setMainURLTitle): (WebCore::ChromiumDataObject::textPlain): (WebCore::ChromiumDataObject::setTextPlain): (WebCore::ChromiumDataObject::textHTML): (WebCore::ChromiumDataObject::setTextHTML): (WebCore::ChromiumDataObject::htmlBaseURL): (WebCore::ChromiumDataObject::setHTMLBaseURL): (WebCore::ChromiumDataObject::content): (WebCore::ChromiumDataObject::releaseContent): (WebCore::ChromiumDataObject::setContent): (WebCore::ChromiumDataObject::contentFileExtension): (WebCore::ChromiumDataObject::setContentFileExtension): (WebCore::ChromiumDataObject::contentFileName): (WebCore::ChromiumDataObject::setContentFileName): (WebCore::ChromiumDataObject::fileNames): (WebCore::ChromiumDataObject::setFileNames): (WebCore::ChromiumDataObject::takeFileNames):
7:56 AM Changeset in webkit [48207] by Simon Hausmann
  • 4 edits
    1 move in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=29024
Make JavaScriptCore compile on platforms with case-insensitive file systems and typeinfo.h in STL

Patch by Kent Hansen <​khansen@trolltech.com> on 2009-09-09
Reviewed by Darin Adler.

These platforms include Microsoft Visual Studio 2003, and Symbian with Metrowerks compiler.

7:49 AM Changeset in webkit [48206] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()

Reviewed by Mark Rowe.

No change to layout test results.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::clickPointY): Changed to return y value instead of x value.
6:26 AM Changeset in webkit [48205] by yael.aharon@nokia.com
  • 2 edits in trunk

[Qt] locale date displays incorrect date format in symbian.
​https://bugs.webkit.org/show_bug.cgi?id=29032

Patch by Pat Bradley <​vincent.bradley@nokia.com> on 2009-09-08
Reviewed by Ariya Hidayat.

strftime() in Symbian does not support #
Layout tests cannot be run on Symbian yet, so they are not updated.

  • runtime/DatePrototype.cpp:
2:53 AM Changeset in webkit [48204] by Simon Hausmann
  • 2 edits in trunk/WebCore

NPAPI Plugin NPP_AsFile not working on Qt Webkit
​https://bugs.webkit.org/show_bug.cgi?id=29068

Patch by Rohini Ananth <​rohini.ananth@nokia.com> on 2009-09-09
Reviewed by Simon Hausmann.

  • platform/qt/FileSystemQt.cpp:

(WebCore::openTemporaryFile)
Autoremove property of QTemporaryFile has been set to false. Hence closeFile() just closes and does not delete the file.
This solves the deletion of created temp file in PluginStream::destroyStream() before passing to plugin in NPP_AsFile.

12:13 AM Changeset in webkit [48203] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Adjust WinCairo-specific property sheet to use static versions of
libjpeg.lib and libpng.lib. Change to libpng.lib required addition
of zlib.lib to link.

Reviewed by Dave Levin.

  • win/tools/vsprops/WinCairo.vsprops:
12:02 AM Changeset in webkit [48202] by oliver@apple.com
  • 5 edits in trunk

JSON.stringify(Date) loses the milliseconds information
​https://bugs.webkit.org/show_bug.cgi?id=29063

Reviewed by Maciej Stachowiak.

Make sure we include milliseconds in the output of toISOString.

Sep 8, 2009:

10:55 PM Changeset in webkit [48201] by oliver@apple.com
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (Build fix).

Remove a few incorrect changes I left in.

9:32 PM Changeset in webkit [48200] by oliver@apple.com
  • 24 edits in trunk/WebCore

Support numeric index getters in bindings
​https://bugs.webkit.org/show_bug.cgi?id=29067

Reviewed by Sam Weinig.

Add HasNumericIndexGetter to indicate a non-custom getter that
returns a number. The numeric index getter also uses PropertySlot's
setValue rather than setCustomIndex to avoid an additional indirect
call.

8:03 PM Changeset in webkit [48199] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2009-09-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Mark Rowe.

Reduce dglazkov's boboiness by properly concatenating revision value.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution

rather than "+".

7:25 PM Changeset in webkit [48198] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wxWebKit Python extension build fix - get swig.py if it doesn't exist.

7:20 PM Changeset in webkit [48197] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix for 2.8.

6:45 PM Changeset in webkit [48196] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

shared-worker-exception.html needs to pause to let console messages get written out
​https://bugs.webkit.org/show_bug.cgi?id=29043

Reviewed by Maciej Stachowiak.

  • fast/workers/resources/shared-worker-exception.js:

(worker.onmessage):
Now invokes layoutTestController.notifyDone() via a timer so any pending ReportException tasks get a chance to fire.

5:29 PM Changeset in webkit [48195] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-08 Jens Alfke <​snej@chromium.org>

Reviewed by Eric Seidel.

In Mac Chromium, clicking below the last line of an editable area (textarea or
contenteditable) should put the caret at the end of the last line, as in Mac Safari.

Tests: LayoutTests/editing/selection/click-in-margins-inside-editable-div.html

LayoutTests/editing/selection/click-in-padding-with-multiple-line-boxes.html

  • page/Settings.cpp: (WebCore::Settings::Settings): Change #if PLATFORM_MAC to be Mac-Chrome-inclusive.
5:01 PM Changeset in webkit [48194] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix an incorrect variable name in UpdateChromiumSource.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
3:51 PM Changeset in webkit [48193] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Don't check for leaks on the release SnowLeopard builder.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:39 PM Changeset in webkit [48192] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Add a SnowLeopard release builder.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:17 PM Changeset in webkit [48191] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Make sure not to do an early return when a data URL stylesheet successfully loads. We need to still
clear the old cached sheet out of all existing Frames. Fixes the data URL stylesheet layout test failure.

Reviewed by Mark Rowe.

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

3:14 PM Changeset in webkit [48190] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix windows build.

  • dom/Document.idl:
3:11 PM Changeset in webkit [48189] by kevino@webkit.org
  • 2 edits in trunk/WebCore

More robust wx build fix for 2.9.

3:02 PM Changeset in webkit [48188] by weinig@apple.com
  • 6 edits
    5 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint

Reviewed by Timothy Hatcher.

Tests: fast/dom/Document/CaretRangeFromPoint/basic.html

fast/dom/Document/CaretRangeFromPoint/replace-element.html

  • dom/Document.cpp:

(WebCore::Document::caretRangeFromPoint):

  • dom/Document.h:
  • dom/Document.idl:

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint

Reviewed by Timothy Hatcher.

  • fast/dom/Document/CaretRangeFromPoint: Added.
  • fast/dom/Document/CaretRangeFromPoint/basic-expected.txt: Added.
  • fast/dom/Document/CaretRangeFromPoint/basic.html: Added.
  • fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt: Added.
  • fast/dom/Document/CaretRangeFromPoint/replace-element.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
2:46 PM Changeset in webkit [48187] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

Remove end of line whitespace check from check-webkit-style.
​https://bugs.webkit.org/show_bug.cgi?id=29053

Patch by David Levin <​levin@chromium.org> on 2009-09-08
Reviewed by Darin Adler.

  • Scripts/modules/cpp_style.py:
2:32 PM Changeset in webkit [48186] by kevino@webkit.org
  • 4 edits in trunk

wx build fix, generate derived sources earlier in order to make sure
they're found by the build system when generating the list of sources to build.

2:11 PM Changeset in webkit [48185] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-09-08 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

<iterator> include in V8Proxy.h is spurious and causing ObjC compile issues for Chromium.

Test: Chromium mac canary build is fixed.

2:05 PM Changeset in webkit [48184] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

2009-09-08 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Updated results for media/audio-controls-rendering.html, and added 3 failing
tests to the Skipped list to investigate further <​http://webkit.org/b/29047>.

  • platform/win/Skipped:
  • platform/win/media/audio-controls-rendering-expected.txt:
2:01 PM Changeset in webkit [48183] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-09-08 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=29044
[GTK] Should update suggested-filename when the response is received

Set suggested filename also when the response only comes after the
download has started.

  • webkit/webkitdownload.cpp: (webkit_download_set_response): (webkit_download_set_suggested_filename):
  • webkit/webkitwebview.cpp: (webkit_web_view_request_download):
1:34 PM Changeset in webkit [48182] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-09-08 Xan Lopez <​xlopez@igalia.com>

Unreviewed attempt to fix the GTK+ build.

  • GNUmakefile.am:
1:26 PM Changeset in webkit [48181] by hyatt@apple.com
  • 9 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=28987, make the Document cache the page's user stylesheet in
parsed form. Allows the sheet to survive across destruction/re-creation of the CSSStyleSelector.

Reviewed by Eric Seidel.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

  • css/CSSStyleSelector.h:
  • dom/Document.cpp:

(WebCore::Document::attach):
(WebCore::Document::pageUserSheet):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
  • loader/PlaceholderDocument.cpp:

(WebCore::PlaceholderDocument::attach):

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

  • page/Settings.cpp:

(WebCore::Settings::setUserStyleSheetLocation):

1:23 PM Changeset in webkit [48180] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed buildfix.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-08
Fix Qt build after 48167, by adding the new cpp/h files
added to WebCore.gypi to WebCore.pro as well.

  • WebCore.pro:
1:11 PM Changeset in webkit [48179] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Unreviewed build fix.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-08
Potential build fix for Qt 4.5

  • Api/qwebpage.cpp:

(QWebPagePrivate::mousePressEvent):

1:06 PM Changeset in webkit [48178] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-09-08 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

should not pass URI fragments to libsoup
​https://bugs.webkit.org/show_bug.cgi?id=28687

Strip the fragment from the URI before passing it to soup, since
it forwards it to servers in some cases (like when using a proxy)
which confuses them and makes them return 403/404.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): (WebCore::):
12:40 PM Changeset in webkit [48177] by kenneth@webkit.org
  • 8 edits in trunk

WebCore: Add QGraphicsScene events support to the Qt platform events.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/qt/PlatformMouseEventQt.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/qt/WheelEventQt.cpp:

(WebCore::PlatformWheelEvent::applyDelta):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/qt: Add support for handling QGraphicsScene events.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::handleClipboard):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):
(QWebPage::event):

  • Api/qwebpage_p.h:
12:40 PM Changeset in webkit [48176] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Update Security Group Members list.

Reviewed by Adele Peterson.

  • security/security-group-members.html:
12:28 PM Changeset in webkit [48175] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-08 Michael Nordman <Michael Nordman>

Reviewed by Eric Seidel.

[Chromium] Cleanup: remove a few deprecated methods.
​https://bugs.webkit.org/show_bug.cgi?id=28960

No new tests, just syntactic sugar.

  • platform/network/chromium/ResourceRequest.h:
  • platform/network/chromium/ResourceResponse.h:
12:21 PM Changeset in webkit [48174] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-08 Yongjun Zhang <​yongjun.zhang@nokia.com>

Reviewed by Ariya Hidayat.

​https://bugs.webkit.org/show_bug.cgi?id=28981

[Qt] make npapi.h compile in winscw compiler.

Add XP_SYMBIAN macro to identify Symbian OS; this macro should be used for Symbian
specific changes in npapi.h.
Undefine XP_WIN when building for Symbian to avoid including Windows specific code.

  • bridge/npapi.h:
12:06 PM Changeset in webkit [48173] by kov@webkit.org
  • 6 edits in trunk/WebKit/gtk

2009-09-08 Priit Laes <​plaes@plaes.org>

Reviewed by Gustavo Noronha.

Fix up erroneus 'Since: @version@' tags in documentation.

  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebresource.cpp: (webkit_web_resource_class_init):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
  • webkit/webkitwebwindowfeatures.cpp:
12:02 PM Changeset in webkit [48172] by oliver@apple.com
  • 2 edits in trunk/WebCore

Web Inspector assertion failure related to marking
​https://bugs.webkit.org/show_bug.cgi?id=28997

Reviewed by Geoff Garen.

When wrapping the callback the JSInspectorCallbackWrapper creator was using
inheritorID for the prototype structure which is unsafe for anything other
than a pure JS object. Instead we now create a new structure, which while
inefficient is not problematic as this code is not hit frequently.

11:34 AM Changeset in webkit [48171] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-09-08 Kelly Norton <​knorton@google.com>

Reviewed by Dimitri Glazkov.

Add missing extension to the file entry in WebCore.vcproj.

  • WebCore.vcproj/WebCore.vcproj: Added "cpp".
11:02 AM Changeset in webkit [48170] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-08 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Darin Adler.

Fix DumpRenderTree build from clean tree on Tiger
​https://bugs.webkit.org/show_bug.cgi?id=28927

  • DumpRenderTree/mac/PerlSupport/Makefile: Ensure the DerivedSources/DumpRenderTree directory exists when building on Tiger.
11:02 AM Changeset in webkit [48169] by jianli@chromium.org
  • 5 edits in trunk

WebCore: dataTransfer.types() should not return Files if file list is empty in the clipboard.
​https://bugs.webkit.org/show_bug.cgi?id=28891

Reviewed by David Levin.

We change the behavior to handle the empty file list in order to match the spec.

Tested by clipboard-file-access.html.

  • platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

LayoutTests: dataTransfer.types() should not return Files if file list is empty in the clipboard.
​https://bugs.webkit.org/show_bug.cgi?id=28891

Reviewed by David Levin.

Update the test script and expected result to reflect the behavior change.

  • http/tests/security/clipboard/clipboard-file-access-expected.txt:
  • http/tests/security/clipboard/resources/clipboard-file-access.js:
10:58 AM Changeset in webkit [48168] by Nate Chapin
  • 7 edits
    3 adds in trunk

2009-09-08 Steve VanDeBogart <​vandebo@chromium.org>

Reviewed by Eric Seidel.

Handle middle click in Chromium like QT
​https://bugs.webkit.org/show_bug.cgi?id=28696

Tested by middle-click-onpaste.html.

10:55 AM Changeset in webkit [48167] by eric@webkit.org
  • 20 edits
    7 adds in trunk/WebCore

2009-09-08 Kelly Norton <​knorton@google.com>

Reviewed by Eric Seidel.

WebInspector: Adds a timeline agent to InspectorController that collects
high-level timing data about event dispatch, layout, painting and HTML
parsing and makes it available to Inspector.
​https://bugs.webkit.org/show_bug.cgi?id=25503

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Document.h: (WebCore::Document::inspectorTimelineAgent):
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • inspector/DOMDispatchTimelineItem.cpp: Added. (WebCore::DOMDispatchTimelineItem::DOMDispatchTimelineItem): (WebCore::DOMDispatchTimelineItem::convertToScriptObject):
  • inspector/DOMDispatchTimelineItem.h: Added. (WebCore::DOMDispatchTimelineItem::~DOMDispatchTimelineItem):
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::enableTimeline): (WebCore::InspectorBackend::disableTimeline): (WebCore::InspectorBackend::timelineEnabled):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::enableTimeline): (WebCore::InspectorController::disableTimeline): (WebCore::InspectorController::timelineEnabled):
  • inspector/InspectorController.h: (WebCore::InspectorController::timelineAgent):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::timelineWasEnabled): (WebCore::InspectorFrontend::timelineWasDisabled): (WebCore::InspectorFrontend::addItemToTimeline):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorTimelineAgent.cpp: Added. (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::currentTimeInMilliseconds): (WebCore::InspectorTimelineAgent::sessionTimeInMilliseconds):
  • inspector/InspectorTimelineAgent.h: Added.
  • inspector/TimelineItem.cpp: Added. (WebCore::TimelineItem::TimelineItem): (WebCore::TimelineItem::addToTimeline): (WebCore::TimelineItem::convertToScriptObject): (WebCore::TimelineItem::convertChildrenToScriptArray): (WebCore::TimelineItem::addChildItem):
  • inspector/TimelineItem.h: Added. (WebCore::): (WebCore::TimelineItem::~TimelineItem): (WebCore::TimelineItem::previous): (WebCore::TimelineItem::releasePrevious): (WebCore::TimelineItem::setEndTime): (WebCore::TimelineItem::type):
  • inspector/front-end/TimelineAgent.js: Added. (WebInspector.TimelineAgent): (WebInspector.addItemToTimeline): (WebInspector.timelineWasEnabled): (WebInspector.timelineWasDisabled):
  • inspector/front-end/inspector.html:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
  • page/FrameView.h: (WebCore::FrameView::inspectorTimelineAgent):
  • page/Page.cpp: (WebCore::Page::inspectorTimelineAgent):
  • page/Page.h:
10:44 AM Changeset in webkit [48166] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-09-08 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=29007
Add a test for the signal QWebFrame::javaScriptWindowObjectCleared()

  • tests/qwebframe/tst_qwebframe.cpp:
10:37 AM Changeset in webkit [48165] by eric@webkit.org
  • 7 edits in trunk

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Fix unused variable warnings
​https://bugs.webkit.org/show_bug.cgi?id=29018

No functional change, no tests.

  • history/qt/HistoryItemQt.cpp: (WebCore::HistoryItem::restoreState):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::putImageData):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMenuList):

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Fix unused variable warnings
​https://bugs.webkit.org/show_bug.cgi?id=29018

  • Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::startDownload): (WebCore::FrameLoaderClientQt::createFrame):
10:30 AM Changeset in webkit [48164] by eric@webkit.org
  • 5 edits in trunk

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

[Qt] Use the declaration order in initializer lists
​https://bugs.webkit.org/show_bug.cgi?id=29017

No functional change, no new tests.

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

[Qt] Use the declaration order in initializer lists
​https://bugs.webkit.org/show_bug.cgi?id=29017

  • Api/qwebframe_p.h:
10:23 AM Changeset in webkit [48163] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2009-09-08 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for ValidityState::typeMismatch() for <input type=number>.
​https://bugs.webkit.org/show_bug.cgi?id=28934

  • fast/forms/ValidityState-typeMismatch-number-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-number.html: Added.
  • fast/forms/resources/ValidityState-typeMismatch-number.js: Added.

2009-09-08 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Implement ValidityState::typeMismatch() for <input type=number>.
​https://bugs.webkit.org/show_bug.cgi?id=28934

Test: fast/forms/ValidityState-typeMismatch-number.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::formStringToDouble):
  • html/HTMLInputElement.h:
  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
  • html/ValidityState.h:
10:19 AM Changeset in webkit [48162] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix after introduction of platform/mock directory.

10:15 AM Changeset in webkit [48161] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
​https://bugs.webkit.org/show_bug.cgi?id=29011

  • wtf/Threading.h: Use LOCKFREE_THREADSAFESHARED guard for atomicIncrement and atomicDecrement
9:39 AM Changeset in webkit [48160] by yael.aharon@nokia.com
  • 2 edits in trunk/WebKitTools

Unreviewed.

Patch by Yael Aharon <​yael.aharon@nokia.com> on 2009-09-08
Add myself to list of committers.

  • Scripts/modules/committers.py:
9:08 AM Changeset in webkit [48159] by Laszlo Gombos
  • 2 edits in trunk/WebKitTools

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

Add myself to list of committers.

  • Scripts/modules/committers.py:
8:51 AM Changeset in webkit [48158] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-08 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Darin Adler.

prepare-ChangeLog too chatty on file additions
​https://bugs.webkit.org/show_bug.cgi?id=29019

  • Scripts/prepare-ChangeLog: Omit description of added properties on newly added files.
8:49 AM Changeset in webkit [48157] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-09-08 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Gustavo Noronha.

[Gtk] Another attempt of a buildfix.

  • GNUmakefile.am: Modified. Remove some extra IDL files added in r48153.
8:43 AM Changeset in webkit [48156] by eric@webkit.org
  • 6 edits
    6 adds in trunk

2009-09-08 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Adds a LayoutTestController method to set the permission state for Geolocation.
This is required to use the mock Geolocation service for testing.
​https://bugs.webkit.org/show_bug.cgi?id=29027

  • fast/dom/Geolocation/resources/permission-denied.js: Added. Tests that the error callback is invoked with a permission error code when Geolocation permission is denied and the Geolocation service provides a good position fix.
  • fast/dom/Geolocation/permission-denied-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/permission-denied.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/resources/success.js: Added. Tests that the success callback is invoked when the Geolocation service provides a good position fix.
  • fast/dom/Geolocation/success-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/success.html: Added. Wrapper for above test.
  • platform/gtk/Skipped:

2009-09-08 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Adds a LayoutTestController method to set the permission state for Geolocation.
This is required to use the mock Geolocation service for testing.
​https://bugs.webkit.org/show_bug.cgi?id=29027

  • DumpRenderTree/LayoutTestController.cpp: Modified. (setDatabaseQuotaCallback): Modified. Style fix. (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state. (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
  • DumpRenderTree/LayoutTestController.h: Modified. (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state. (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set. (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
  • DumpRenderTree/mac/UIDelegate.mm: Modified. (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
8:17 AM WebKit Team edited by oszi@inf.u-szeged.hu
(diff)
8:00 AM Changeset in webkit [48155] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-07 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control in Yarr's RegexInterpreter
​https://bugs.webkit.org/show_bug.cgi?id=29025

Inherits RegexInterpreter classes from FastAllocBase (bug #20422), which has
been instantiated by 'new':

class ByteDisjunction
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1462

struct BytecodePattern
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1279

  • yarr/RegexInterpreter.h:
7:58 AM WebKit Team edited by oszi@inf.u-szeged.hu
(diff)
7:43 AM Changeset in webkit [48154] by Simon Hausmann
  • 6 edits in trunk

WebCore: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.
​https://bugs.webkit.org/show_bug.cgi?id=28865

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

Save the QCursor as a property in WidgetQt::setCursor
and actually change the cursor in QWebView::event() by making use
of the QEvent::DynamicPropertyChange event type.
When unsetCursor() is called on the QWidget we can fallback to
the cursor set by WebCore.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> and

Antonio Gomes <​antonio.gomes@openbossa.org> on 2009-09-07

  • platform/qt/WidgetQt.cpp:

(WebCore::Widget::setCursor):

WebKit/qt: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.
​https://bugs.webkit.org/show_bug.cgi?id=28865

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

Clean up the unserCursor hack to use the QCursor set
as a property of the QWidget by WebCore::WidgetQt.

Remove all code that are no longer necessary for getting
cursor change events.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> and

Antonio Gomes <​antonio.gomes@openbossa.org> on 2009-09-07

  • Api/qwebpage.cpp:
  • Api/qwebpage_p.h:
  • Api/qwebview.cpp:

(QWebViewPrivate::QWebViewPrivate):
(QWebView::event):

7:34 AM Changeset in webkit [48153] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-09-08 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Gustavo Noronha.

[Gtk] Buildfix for build error introduced in r48150.

  • GNUmakefile.am: Modified. Added missing IDL files.
7:05 AM Changeset in webkit [48152] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Buildfix. Build error caused by r48150.

Patch by Csaba Osztrogonac <​oszi@inf.u-szeged.hu> on 2009-09-08
Reviewed by Tor Arne Vestbø.

  • WebCore.pro: missing IDL files added
6:44 AM QtWebKitContrib edited by vestbo@webkit.org
(diff)
6:31 AM QtWebKitContrib edited by vestbo@webkit.org
(diff)
6:27 AM Changeset in webkit [48151] by Laszlo Gombos
  • 8 edits in trunk

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] QtWebKit single API to enable persistency
​https://bugs.webkit.org/show_bug.cgi?id=28682

Disable LocalStorage, ApplicationCache, HTML5 offline storage by
default.

If persistency is enabled the default directory for LocalStorage and
ApplicationCache is now based on QDesktopServices::DataLocation and not
QDesktopServices::CacheLocation (as it is expected to keep this data
around after a reboot).

If persistency is enabled initialize HTML5 offline storage as well - this
fixed offline Storage for QtLauncher.

6:01 AM Changeset in webkit [48150] by cmarrin@apple.com
  • 17 edits
    48 adds in trunk/WebCore

Update Canvas 3D implementation to match spec
​https://bugs.webkit.org/show_bug.cgi?id=29010

This adds several new CanvasXXXArray classes each of which has a custom constructor
and custom getters and setters. Also changed CanvasRenderingContext3D and GraphicsContext3D
to match the new and changed API.

5:35 AM Changeset in webkit [48149] by vestbo@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Add expected files for new tests since we pass them.

Patch by Andras Becsi <​becsi.andras@stud.u-szeged.hu> on 2009-09-08
Reviewed by Tor Arne Vestbø.

  • platform/qt/fast/reflections/abs-position-in-reflection-expected.txt: Added.
  • platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt: Added.
5:27 AM Changeset in webkit [48148] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

Refactor --strict switch to --ignore-metrics and correct the
implementation to make the feature usable on all platforms.
​https://bugs.webkit.org/show_bug.cgi?id=28907

Patch by Andras Becsi <​becsi.andras@stud.u-szeged.hu> on 2009-09-07
Reviewed by Tor Arne Vestbø.

run-webkit-tests --ignore-metrics strips the font related metrics from
the actual and expected data before comparing them.
In this way the render trees can be checked for obvious differences but
a successful test implies by no means that the layout is actually correct.

  • Scripts/run-webkit-tests:
2:51 AM Changeset in webkit [48147] by hamaji@chromium.org
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

Unreviewed.

Change my mail address on the list of committers.

12:45 AM Changeset in webkit [48146] by Simon Hausmann
  • 2 edits in trunk/WebCore

Make m_windowVisible more consistent with the actual visibility of the inspector.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2009-09-08
Reviewed by Timothy Hatcher.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::setWindowVisible):

Note: See TracTimeline for information about the timeline view.