⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 10, 2009:

10:48 PM Changeset in webkit [48284] by abarth@webkit.org
  • 6 edits
    44 adds in trunk

2009-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Detect mixed content
​https://bugs.webkit.org/show_bug.cgi?id=29003

Add some tests for mixed content. All but one of these tests pass
currently. The one that fails is pretty tricky, but I wanted to get it
into the tree with a FIXME so we won't forget it. I'll file a followup
bug about fixing it.

  • http/tests/security/mixedContent/about-blank-iframe-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html: Added.
  • http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/data-url-iframe-in-main-frame.html: Added.
  • http/tests/security/mixedContent/data-url-script-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/data-url-script-in-iframe.html: Added.
  • http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-css-in-iframe.html: Added.
  • http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-css-in-main-frame.html: Added.
  • http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-iframe-in-iframe.html: Added.
  • http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-iframe-in-main-frame.html: Added.
  • http/tests/security/mixedContent/insecure-image-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-image-in-iframe.html: Added.
  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-image-in-main-frame.html: Added.
  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-script-in-iframe.html: Added.
  • http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html: Added.
  • http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html: Added.
  • http/tests/security/mixedContent/resources/boring.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-about-blank-frame.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-data-url-frame.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-data-url-script.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-frame.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-image.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-script.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-script.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-script.html: Added.
  • http/tests/security/mixedContent/resources/script.js: Added.
  • http/tests/security/mixedContent/resources/style.css: Added.

2009-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Detect mixed content
​https://bugs.webkit.org/show_bug.cgi?id=29003

Detect some basic kinds of mixed content (HTTP content loaded into an
HTTPS context). This new detection logic isn't perfect, but it's a
place to start.

Tests: http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html

http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-css-in-main-frame.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-main-frame.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html

  • loader/DocLoader.cpp: (WebCore::DocLoader::canRequest): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent): (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest):
9:03 PM Changeset in webkit [48283] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Revert ​http://trac.webkit.org/changeset/48277, as it wasn't the right way to fix the build.

8:34 PM Changeset in webkit [48282] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the Windows build.

Restore platform/mock to the header search path after it was removed in r48270.

  • WebCore.vcproj/WebCoreCommon.vsprops:
8:17 PM Changeset in webkit [48281] by timothy@apple.com
  • 3 edits in trunk/WebCore

Web Inspector: Move the option to create a new style rule under the Styles' gear menu.

​https://bugs.webkit.org/show_bug.cgi?id=29039

Reviewed by Sam Weinig.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane): Add "New Style Rule" option to the gear menu.
(WebInspector.StylesSidebarPane.prototype._update): Check instanceof BlankStylePropertiesSection instead.
(WebInspector.StylesSidebarPane.prototype._changeSetting): Added. Keeps the color format setting selected
while calling the correct action.
(WebInspector.StylesSidebarPane.prototype._createNewRule): Creates a new section and edits the selector.
(WebInspector.StylesSidebarPane.prototype.addBlankSection): Insert the section in a cleaner way.
(WebInspector.StylesSidebarPane.prototype.removeSection): Added. Removes the passed in section.
(WebInspector.StylesSidebarPane.prototype.appropriateSelectorForNode): Return an empty string if there is no node.
(WebInspector.StylePropertiesSection.prototype.expand): Removed the check for _blank.
(WebInspector.StylePropertiesSection.prototype.startEditingSelector): No need for the context, the original selector
is remembered by the editing code.
(WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): Do nothing. The original text is already
restored by the editing code.
(WebInspector.BlankStylePropertiesSection): Call the StylePropertiesSection constructor with appropriate data.
Remove event listener code.
(WebInspector.BlankStylePropertiesSection.prototype.expand): Added. Does nothing to prevent expanding.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.callback): Correctly construct the
WebInspector.CSSStyleDeclaration. Call editingSelectorCancelled instead of editingCancelled.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): Renamed from editingCommitted to
override the base class.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled): Remove the section.
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal): Removed event listener code. Removed the delete lines
since they were doing nothing (deleting nonexistent properties that exist only on the prototype.) Change prototypes at
the end to correctly swtich to a real StylePropertiesSection.

  • inspector/front-end/inspector.js:

(WebInspector.startEditing.editingCancelled): Ceck for null/undefined callbacks.
(WebInspector.startEditing.editingCommitted): Ditto.

8:10 PM Changeset in webkit [48280] by Laszlo Gombos
  • 12 edits in trunk

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Fix comparison between signed and unsigned integer warnings
​https://bugs.webkit.org/show_bug.cgi?id=29162

No functional change.

  • Api/qwebelement.cpp: (QWebElement::findAll):
  • Api/qwebhistory.cpp: (QWebHistory::items): (QWebHistory::backItems): (QWebHistory::forwardItems): (QWebHistory::saveState):
  • Api/qwebplugindatabase.cpp: (QWebPluginDatabase::setSearchPaths):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Fix comparison between signed and unsigned integer warnings
​https://bugs.webkit.org/show_bug.cgi?id=29162

No functional change.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::findMethodIndex):
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::duration): (WebCore::ImageDecoderQt::imageAtIndex):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo):
7:45 PM Changeset in webkit [48279] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-09-10 Martin Robinson <​martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha.

Build fix for GTK+ after r48267.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::buffered):
7:14 PM Changeset in webkit [48278] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/29147> run-webkit-tests: make -h show help

Reviewed by Mark Rowe.

  • Scripts/run-webkit-tests: Updated to make -h switch show help.
7:13 PM Changeset in webkit [48277] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Attemped Windows build fix by adding platform/mock headers to be copied.

6:22 PM MathML edited by alex@milowski.com
(diff)
6:16 PM WikiStart edited by alex@milowski.com
(diff)
4:59 PM Changeset in webkit [48276] by jam@chromium.org
  • 1 edit in trunk/WebCore/rendering/RenderPartObject.cpp

Sorry, one more unused paramater breaking Mac build. Will test on my Mac first next time.

4:57 PM Changeset in webkit [48275] by jam@chromium.org
  • 1 edit in trunk/WebCore/rendering/RenderPartObject.cpp

Fix build break on Mac

4:38 PM Changeset in webkit [48274] by jam@chromium.org
  • 4 edits in trunk

JavaScriptCore:

2009-09-08 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Dimitri Glazkov.

Remove unneeded define for ActiveX.
​https://bugs.webkit.org/show_bug.cgi?id=29054

  • wtf/Platform.h:

WebCore:

2009-09-08 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Dimitri Glazkov.

Remove unneeded define for ActiveX.
​https://bugs.webkit.org/show_bug.cgi?id=29054

  • rendering/RenderPartObject.cpp: (WebCore::createClassIdToTypeMap): (WebCore::serviceTypeForClassId): (WebCore::RenderPartObject::updateWidget):
4:16 PM Changeset in webkit [48273] by mrowe@apple.com
  • 4 edits in trunk

Update JavaScriptCore and WebKit's FeatureDefines.xcconfig so that they are in sync with WebCore as they need to be.

Rubber-stamped by Sam Weinig.

4:06 PM Changeset in webkit [48272] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Don't copy IDL files in to the built framework.

Rubber-stamped by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj:
4:00 PM Changeset in webkit [48271] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2009-09-10 Xiaomei Ji <​xji@chromium.org>

Reviewed by Eric Seidel.

Implement Range.expand().
​https://bugs.webkit.org/show_bug.cgi?id=27632

  • fast/dom/Range/range-expand-expected.txt: Added.
  • fast/dom/Range/range-expand.html: Added.
  • fast/dom/Window/window-properties-expected.txt:

2009-09-10 Xiaomei Ji <​xji@chromium.org>

Reviewed by Eric Seidel.

Implment Range.expand().
​https://bugs.webkit.org/show_bug.cgi?id=27632

Test: fast/dom/Range/range-expand.html

  • dom/Range.cpp: (WebCore::Range::expand):
  • dom/Range.h:
  • dom/Range.idl:
3:45 PM Changeset in webkit [48270] by ap@apple.com
  • 25 edits
    5 adds in trunk

Reviewed by Alexey Proskuryakov.

WebSocket API implementation.
​https://bugs.webkit.org/show_bug.cgi?id=28038


Add build systems for GNUmakefile.am, WebCore.xcodeproj and
WebCore.vcproj.
Add websockets directory and WebSocket.idl in qt build system.
Tests will be landed once the code is completed and functional.

3:28 PM Changeset in webkit [48269] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

2009-09-10 Albert J. Wong <​ajwong@chromium.org>

No review, windows build fix only.

Spurious semicolon causing parse error in chromium build on windows.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::buffered): Removed semicolon.
3:15 PM Changeset in webkit [48268] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

2009-09-10 Albert J. Wong <​ajwong@chromium.org>

No review, build fix only.

Adding in a missed include from the last patch that is breaking the
chromium build.

  • rendering/RenderThemeChromiumMac.mm: include TimeRanges.h
2:46 PM Changeset in webkit [48267] by ajwong@chromium.org
  • 17 edits in trunk/WebCore

HTMLMediaElement buffered attribute should report a list of time ranges
​https://bugs.webkit.org/show_bug.cgi?id=29041

Patch by Alpha Lam <​hclam@chromium.org> on 2009-09-10
Reviewed by Eric Carlson.

Changed MediaPlayerPrivateInterface and MediaPlayer's definition to
report a list of buffered time ranges as WebCore::TimeRanges. This
change also got rid of the maxTimeBuffered() method.

No new tests since this is a API change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::percentLoaded):
Use MediaPlaier::buffered() instead of maxTimeBuffered().
(WebCore::HTMLMediaElement::buffered):
ditto.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::buffered):
Use MediaPlayerPrivateInterface::buffered() instead of maxTimeBuffered().
(WebCore::MediaPlayer::buffered):
ditto.

  • platform/graphics/MediaPlayer.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

  • platform/graphics/MediaPlayerPrivate.h:

ditto.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:

Implements PassRefPtr<TimeRanges> buffered();

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivate::buffered):
Implementation of buffered().

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

Implements PassRefPtr<TimeRanegs> buffered().

  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

Implements PassRefPtr<TimeRanges> buffered().

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

  • platform/graphics/wince/MediaPlayerPrivateWince.h:

ditto.

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
Use buffered() instead of maxTimeBuffered().

  • rendering/RenderThemeChromiumSkia.cpp:

ditto.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaSliderTrack):
ditto.

2:34 PM Changeset in webkit [48266] by eric@webkit.org
  • 6 edits in trunk/WebCore

2009-09-10 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

Make bindings generators more aware of IDL dependencies
​https://bugs.webkit.org/show_bug.cgi?id=29114

Make the JS and ObjC bindings generators able to output dependency
rules for DerivedSources.make to consume. These rules make a given
generated binding class file header, JSWhatever.h, depend on Whatever's
ancestor interfaces.

  • DerivedSources.make: Pass --write-dependencies to generate-bindings.pl when generating JS and ObjC bindings. Include dependency fies that are generated due to that.
  • bindings/scripts/CodeGenerator.pm: Make AddMethodsConstantsAndAttributesFromParentClasses accumulate a list of the ancestor interfaces that were visited.
  • bindings/scripts/CodeGeneratorJS.pm: Optionally write out a dependency file.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/generate-bindings.pl: Add a --write-dependencies option.
1:49 PM Changeset in webkit [48265] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

Make StructureTransitionTable use an enum for the PtrAndFlags member
used for the single transition slot optimisation.

1:01 PM Changeset in webkit [48264] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Refactor StructureTransitionTable and Structure to unify handling of the single slot optimization
​https://bugs.webkit.org/show_bug.cgi?id=29141

Reviewed by Geoff Garen

Make StructureTransitionTable encapsulate the single transition slot optimization.

12:52 PM Changeset in webkit [48263] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Rubber-stamped by Ariya Hidayat.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-10
Fix a bunch of qdoc warnings: Invalid references, non-standard
wording, etc.

  • Api/qwebelement.cpp:
  • Api/qwebgraphicsitem.cpp:
  • Api/qwebsecurityorigin.cpp:
12:42 PM Changeset in webkit [48262] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Fix context menu event delivery with QWebGraphicsItem.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-10
Reviewed by Ariya Hidayat.

Re-implement the correct context menu virtual function using
a QGraphicsSceneContextMenuEvent and forward & handle it in
QWebPage.

  • Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::contextMenuEvent):

  • Api/qwebgraphicsitem.h:
  • Api/qwebpage.cpp:

(QWebPagePrivate::contextMenuEvent):
(QWebPage::event):

  • Api/qwebpage_p.h:
11:24 AM MathML edited by alex@milowski.com
(diff)
11:24 AM MathML edited by alex@milowski.com
(diff)
11:19 AM MathML edited by alex@milowski.com
(diff)
11:18 AM MathML created by alex@milowski.com
10:58 AM Changeset in webkit [48261] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-09-10 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez and Dan Winship.

Give all requests to libsoup, to let it queue, and schedule them
itself, instead of throttling the number of requests in WebCore.

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
10:39 AM Changeset in webkit [48260] by jianli@chromium.org
  • 3 edits
    5 adds in trunk

WebCore: [V8] Make XMLHttpRequest.send handle File object.
​https://bugs.webkit.org/show_bug.cgi?id=28924

Reviewed by Eric Seidel.

Test: http/tests/local/send-dragged-file.html

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

LayoutTests: [V8] Make XMLHttpRequest.send handle File object.
​https://bugs.webkit.org/show_bug.cgi?id=28924

Reviewed by Eric Seidel.

Add a new layout test.

  • http/tests/local/resources/file-for-drag-to-send.txt: Added.
  • http/tests/local/resources/send-dragged-file.js: Added.
  • http/tests/local/send-dragged-file-expected.txt: Added.
  • http/tests/local/send-dragged-file.html: Added.
10:33 AM Changeset in webkit [48259] by zoltan@webkit.org
  • 6 edits in trunk

2009-09-10 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Implement fastDeleteSkippingDestructor for FastAllocBase and fastDeleteAllValues for HashSet
​https://bugs.webkit.org/show_bug.cgi?id=25930

FastAllocBase has been extended with fastDeleteSkippingDestructor function which
releases memory without destructor call. fastDeleteAllValues has been implemented
similar as deleteAllValues but it uses fastDelete function to release memory.

  • wtf/FastAllocBase.h: (WTF::fastDeleteSkippingDestructor):
  • wtf/HashSet.h: (WTF::fastDeleteAllValues):

2009-09-10 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Use fastNew and fastDelete instead of operator new and delete for CSSSelector class.
​https://bugs.webkit.org/show_bug.cgi?id=25930

Change using of operator new to fastNew and operator delete to
fastDeleteSkippingDestructor for CSSSelector class to avoid mismatched function call.

This change fixes valgrind's 'mismatched free' notification.

  • css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::createFloatingSelector):
  • css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::adoptSelectorVector):
10:16 AM Changeset in webkit [48258] by benm@google.com
  • 5 edits
    6 adds in trunk

WebCore: Geolocation does not correctly handle reentrant calls from callbacks.
​https://bugs.webkit.org/show_bug.cgi?id=29040

Patch by Steve Block <​steveblock@google.com> on 2009-09-10
Reviewed by Darin Adler.

Tests: fast/dom/Geolocation/reentrant-error.html

fast/dom/Geolocation/reentrant-success.html

  • page/Geolocation.cpp: Modified.

(WebCore::Geolocation::handleError): Modified. Call sendError directly, clearing notifier lists before making callback.
(WebCore::Geolocation::makeSuccessCallbacks): Modified. Call sendPosition directly, clearing notifier lists before making callback.

  • page/Geolocation.h: Modified. Deleted sendErrorToXX and sendPositionToXXX methods.

LayoutTests: Geolocation does not correctly handle reentrant calls from callbacks.
​https://bugs.webkit.org/show_bug.cgi?id=29040

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

  • fast/dom/Geolocation/resources/reentrant-error.js: Added. Tests that reentrant calls from the error callback are OK.
  • fast/dom/Geolocation/reentrant-error.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/reentrant-error-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/reentrant-success.js: Added. Tests that reentrant calls from the success callback are OK.
  • fast/dom/Geolocation/reentrant-success.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/reentrant-success-expected.txt: Added. Expected result for above test.
  • platform/gtk/Skipped: Modified. Skips above tests.
10:03 AM Changeset in webkit [48257] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2009-09-10 Erik Arvidsson <​arv@chromium.org>

Reviewed by Eric Seidel.

Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
​https://bugs.webkit.org/show_bug.cgi?id=27105

  • fast/events/blur-focus-window-should-blur-focus-element-expected.txt: Added.
  • fast/events/blur-focus-window-should-blur-focus-element.html: Added.
  • fast/events/resources/blur-focus-window-should-blur-focus-element.js: Added. (divElement.onfocus.divElement.onblur.window.onfocus.window.onblur.innerDiv.onfocus.innerDiv.onblur.iframe.onfocus.iframe.onblur): (testNextEvent):
  • fast/events/resources/tabindex-focus-blur-all.js: (test):
  • fast/events/tabindex-focus-blur-all-expected.txt:

2009-09-10 Erik Arvidsson <​arv@chromium.org>

Reviewed by Eric Seidel.

Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
​https://bugs.webkit.org/show_bug.cgi?id=27105

Test: fast/events/blur-focus-window-should-blur-focus-element.html

  • page/FocusController.cpp: (WebCore::dispatchEventsOnWindowAndFocusedNode): (WebCore::FocusController::setFocused): (WebCore::FocusController::setActive):
9:41 AM Changeset in webkit [48256] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-09-10 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24205

Added a test case for inserting a new line character into the
request-uri.

  • http/tests/xmlhttprequest/newline-in-request-uri-expected.txt: Added.
  • http/tests/xmlhttprequest/newline-in-request-uri.html: Added.
8:56 AM Changeset in webkit [48255] by Adam Roben
  • 2 edits in trunk/WebCore

Make the play/pause button in <video> controls indicate the button's action, not the movie state

This matches the Mac behavior, iTunes, and many other media players.

No test possible.

Fixes <​http://webkit.org/b/29126> Play/pause button in <video>
controls shows the wrong image

Reviewed by Eric Carlson.

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart): Reversed when
we show the play vs. pause artwork, so that the button reflects what
will happen when you click it, rather than the current state of the
movie.

8:34 AM Changeset in webkit [48254] by Laszlo Gombos
  • 3 edits in trunk/WebKit/qt

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

Build fix for QtWebKit for Mac after r48219.

qevent and qstyleoption are QtGui interfaces.

  • Api/qwebgraphicsitem.cpp:
  • Api/qwebgraphicsitem.h:
7:04 AM Changeset in webkit [48253] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-10 Martin Robinson <​martin.james.robinson@gmail.com>

[GTK] EventSender does not properly convert some keyDown strings
​https://bugs.webkit.org/show_bug.cgi?id=29119

Add more keyDown string to character code conversions for GTK+ EventSender.

  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
6:26 AM Changeset in webkit [48252] by benm@google.com
  • 15 edits
    3 adds
    2 deletes in trunk

WebCore: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
​https://bugs.webkit.org/show_bug.cgi?id=29080

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.

Test: fast/dom/Geolocation/position-string.html

  • GNUmakefile.am: Modified. Removes Geoposition.cpp and Coordinates.cpp.
  • WebCore.gypi: Modified. Removes Geoposition.cpp and Coordinates.cpp.
  • WebCore.pro: Modified. Removes Geoposition.cpp and Coordinates.cpp.
  • WebCore.vcproj/WebCore.vcproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
  • WebCore.xcodeproj/project.pbxproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
  • WebCoreSources.bkl: Modified. Removes Geoposition.cpp and Coordinates.cpp.
  • page/Coordinates.cpp: Removed.
  • page/Coordinates.h: Modified. Removes toString method.
  • page/Coordinates.idl: Modified. Removes toString method.
  • page/Geoposition.cpp: Removed.
  • page/Geoposition.h: Modified. Removes toString method.
  • page/Geoposition.idl: Modified. Removes toString method.

WebKitTools: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
​https://bugs.webkit.org/show_bug.cgi?id=29080

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.

  • Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.

LayoutTests: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
​https://bugs.webkit.org/show_bug.cgi?id=29080

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.

  • fast/dom/Geolocation/resources/position-string.js: Added. Tests output of position.toString().
  • fast/dom/Geolocation/position-string.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/position-string-expected.txt: Added. Expected result for above test.
  • platform/gtk/Skipped: Modified. Skips above test.
5:45 AM Changeset in webkit [48251] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

ARM compiler does not understand GCC visibility attribute
​https://bugs.webkit.org/show_bug.cgi?id=29079

  • API/JSBase.h: Make the test more specific to hit only the GCC compiler
4:59 AM Changeset in webkit [48250] by Laszlo Gombos
  • 2 edits in trunk

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

Disable some ARM compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=29083

The following ARM compiler warnings are disabled

  • #68-D: integer conversion resulted in a change of sign
  • #111-D: statement is unreachable
  • #177-D: variable XXX was declared but never referenced
  • #368-D: class XXX defines no constructor to initialize the following: YYY
  • #830-D: function XXX "XXX::operator new" has no corresponding operator delete
  • #1293-D: assignment in condition
  • WebKit.pri:
4:32 AM Changeset in webkit [48249] by benm@google.com
  • 5 edits
    6 adds in trunk

WebCore: Correctly applies the Geolocation timeout property.
​https://bugs.webkit.org/show_bug.cgi?id=27256

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.

If a timeout is specified, the timer is started as soon as the location acquistion process starts.
If a position fix is not obtained within the timeout interval, the position request is cancelled
and the error callback (if specified) is invoked. If a position fix is obtained within the timeout
interval, the timer is stopped. Permissions are then requested from the user if required. See
​http://www.w3.org/TR/geolocation-API/#position-options.

Note that this logic means that the time required to obtain permissions from the user is not
included in the timeout interval.

Tests: fast/dom/Geolocation/timeout.html

fast/dom/Geolocation/timeout-zero.html

  • page/Geolocation.cpp: Modified.

(WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. Takes Geolocation object as parameter.
(WebCore::Geolocation::GeoNotifier::hasZeroTimeout): Added. Determines whether this request has a zero timeout.
(WebCore::Geolocation::GeoNotifier::startTimerIfNeeded): Renamed from startTimer. Starts the timer if a timeout was specified.
(WebCore::Geolocation::GeoNotifier::timerFired): Modified. Calls the error callback if specified, and reports the timeout to the Geolocation object.
(WebCore::Geolocation::getCurrentPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::watchPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::requestTimedOut): Added. Cancels a request when it times out.
(WebCore::Geolocation::setIsAllowed): Modified. No longer starts timers.
(WebCore::Geolocation::sendPosition): Modified. No longer stops timers.
(WebCore::Geolocation::stopTimer): Added. Stops the timers for a vector of notifiers.
(WebCore::Geolocation::stopTimersForOneShots): Added. Stops the timers for all one-shots.
(WebCore::Geolocation::stopTimersForWatchers): Added. Stops the timers for all watchers.
(WebCore::Geolocation::stopTimers): Added. Stops the timers for all requests.
(WebCore::Geolocation::geolocationServicePositionChanged): Modfified. Stops the timers for all requests.

  • page/Geolocation.h: Modified.

(WebCore::Geolocation::GeoNotifier::create): Modified. Takes Geolocation object as parameter.

LayoutTests: Correctly applies the Geolocation timeout property.
​https://bugs.webkit.org/show_bug.cgi?id=27256

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.

  • fast/dom/Geolocation/resources/timeout.js: Added. Tests that when a non-zero timeout is used, the success callback is invoked as expected.
  • fast/dom/Geolocation/timeout.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/timeout-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/timeout-zero.js: Added. Tests that when a zero timeout is used, the error callback is invoked with code TIMEOUT.
  • fast/dom/Geolocation/timeout-zero.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/timeout-zero-expected.txt: Added. Expected result for above test.
  • platform/gtk/Skipped: Modified. Skips the above tests.
2:08 AM Changeset in webkit [48248] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-10 Adam Barth <​abarth@webkit.org>

Unreviewed revert of the previous change. It broke the tests.

  • wtf/dtoa.cpp: (WTF::dtoa):
1:51 AM Changeset in webkit [48247] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-10 Ben Laurie <​benl@google.com>

Reviewed by Adam Barth.

<​https://bugs.webkit.org/show_bug.cgi?id=26836>

If dtoa was given a small buffer and the number was either infinite or
NaN, then the buffer would be overflowed.

  • wtf/dtoa.cpp:

Sep 9, 2009:

11:58 PM Changeset in webkit [48246] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Call the right base class function QGraphicsWidget::event() instead
of skipping it and using QObject::event() instead.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-09
Reviewed by Tor Arne Vestbø.

  • Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::event):

11:47 PM Changeset in webkit [48245] by Chris Fleizach
  • 2 edits in trunk/WebCore

AX notifications should be an ENUM type instead of strings
​https://bugs.webkit.org/show_bug.cgi?id=28963

Build fix for Qt.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):

11:38 PM Changeset in webkit [48244] by Chris Fleizach
  • 15 edits in trunk/WebCore

AX notifications should be an ENUM type instead of strings
​https://bugs.webkit.org/show_bug.cgi?id=28963

Reviewed by Darin Adler.

Moves AX notifications over to an ENUM type instead of
using the actual string values that are used on OS X.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):

  • editing/mac/SelectionControllerMac.mm:

(WebCore::SelectionController::notifyAccessibilityForSelectionChange):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::setInnerTextValue):

10:25 PM Changeset in webkit [48243] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-09-09 Eric Seidel <​eric@webkit.org>

Reviewed by Eric Carlson.

reviewer/committer lookups are backwards
​https://bugs.webkit.org/show_bug.cgi?id=29113

I also moved Eric Carlson from the committer list to the reviewer list now that he is one.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/committers.py:
10:17 PM Changeset in webkit [48242] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-09-09 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

svn-unapply doesn't revert directories correctly
​https://bugs.webkit.org/show_bug.cgi?id=29065

  • Scripts/svn-unapply: Make svnStatus consistently return status lines including a newline.
  • Scripts/svn-apply: Keep svnStatus in sync with the one in svn-unapply, in lieu of moving it to a common file.
9:52 PM Changeset in webkit [48241] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Update data/params parameters

  • data/params: Updated 'attachment_base' parameter for secure attachments. Updated 'mybugstemplate' parameter to search for bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to NEW status.
7:54 PM Changeset in webkit [48240] by abarth@webkit.org
  • 3 edits
    5 adds in trunk

2009-09-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Missing checkout for getSVGDocument()
​https://bugs.webkit.org/show_bug.cgi?id=29064

The V8 code generator didn't understand SVGCheckSecurityDocument.

Tests: http/tests/security/xss-DENIED-getSVGDocument-iframe.html

http/tests/security/xss-DENIED-getSVGDocument-object.html

  • bindings/scripts/CodeGeneratorV8.pm:

2009-09-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Missing checkout for getSVGDocument()
​https://bugs.webkit.org/show_bug.cgi?id=29064

Add tests that getSVGDocument() has the proper checks.

  • http/tests/security/resources/flag.php: Added.
  • http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt: Added.
  • http/tests/security/xss-DENIED-getSVGDocument-iframe.html: Added.
  • http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt: Added.
  • http/tests/security/xss-DENIED-getSVGDocument-object.html: Added.
5:55 PM Changeset in webkit [48239] by eric@webkit.org
  • 5 edits
    6 adds in trunk

2009-09-09 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement inherit from SVGLangSpace
​https://bugs.webkit.org/show_bug.cgi?id=29058

Required by SVG 1.1 Second Edition:
​http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement

  • svg/dom/SVGStyleElement: Added.
  • svg/dom/SVGStyleElement/resources: Added.
  • svg/dom/SVGStyleElement/resources/TEMPLATE.html: Copied from LayoutTests/svg/dom/resources/TEMPLATE.html with some "../"s added.
  • svg/dom/SVGStyleElement/resources/style-langspace.js: Added.
  • svg/dom/SVGStyleElement/style-langspace-expected.txt: Added.
  • svg/dom/SVGStyleElement/style-langspace.html: Added.

2009-09-09 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement inherit from SVGLangSpace
​https://bugs.webkit.org/show_bug.cgi?id=29058

Required by SVG 1.1 Second Edition:
​http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement

Test: svg/dom/SVGStyleElement/style-langspace.html

  • svg/SVGStyleElement.cpp: Drop methods xmlspace and setXmlspace. (WebCore::SVGStyleElement::SVGStyleElement): Add SVGLangSpace() initializer. (WebCore::SVGStyleElement::parseMappedAttribute): Call parseMappedAttribute on SVGLangSpace.
  • svg/SVGStyleElement.h: Drop xmlspace and setXmlspace declarations.
  • svg/SVGStyleElement.idl: Drop xmlspace attribute and add SVGLangSpace as a superinterface.
5:39 PM Changeset in webkit [48238] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-09 Nate Chapin <Nate Chapin>

Reviewed by David Levin.

Remove unnecessary includes and forward declarations in V8Proxy.h

​https://bugs.webkit.org/show_bug.cgi?id=29111

  • bindings/v8/V8Proxy.h:
4:55 PM Changeset in webkit [48237] by eric@webkit.org
  • 11 edits
    1 add in trunk/LayoutTests

2009-09-09 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

Media layout tests should have a way to provide test files in different formats
​https://bugs.webkit.org/show_bug.cgi?id=28327

Added media-file.js which has a findMediaFile(type, name) method
to find a proper media file to load according to supported codecs.

Also changed 10 layout tests to use above method to locate the test file.

  • media/controls-strict.html: Use findMediaFile(type, name).
  • media/controls-styling.html: ditto.
  • media/media-file.js: Added. Provide findMediaFile(type, name).
  • media/video-append-source.html: Use findMediaFile(type, name).
  • media/video-aspect-ratio.html: ditto.
  • media/video-autoplay.html: ditto.
  • media/video-buffered.html: ditto.
  • media/video-controls-rendering.html: ditto.
  • media/video-layer-crash.html: ditto.
  • media/video-transformed.html: Use findMediaFile(type, name).
  • media/video-zoom-controls.html: ditto.
4:41 PM Changeset in webkit [48236] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-09 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

svn-apply doesn't handle changes to files copied to new directories properly
​https://bugs.webkit.org/show_bug.cgi?id=29059

  • Scripts/svn-apply: Don't treat "--- revision 0" patches as being additions if we know that we've just copied a file to this name.
4:25 PM Changeset in webkit [48235] by eric@webkit.org
  • 6 edits in trunk/WebCore

2009-07-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add more position constructors
positionBeforeNode, positionAfterNode
firstPositionInNode, lastPositionInNode
​https://bugs.webkit.org/show_bug.cgi?id=25494

I also added a lastOffsetInNode and deployed it to a couple places.

There are no callers to these new constructors yet, but those
will be coming in future patches.

  • dom/Position.cpp: (WebCore::Position::computeOffsetInContainerNode):
  • dom/Position.h: (WebCore::positionBeforeNode): (WebCore::positionAfterNode): (WebCore::lastOffsetInNode): (WebCore::firstPositionInNode): (WebCore::lastPositionInNode):
  • editing/ApplyStyleCommand.cpp:
  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
  • editing/htmlediting.cpp: (WebCore::lastOffsetForEditing):
4:25 PM Changeset in webkit [48234] by eric@webkit.org
  • 16 edits
    1 add in trunk/WebCore

2009-07-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename positionBeforeNode to positionInParentBeforeNode
and positionAfterNode to positionInParentAfterNode
in preparation for adding a positionBeforeNode
which returns a neighbor-anchored position.
​https://bugs.webkit.org/show_bug.cgi?id=25494

No functional changes, thus no tests.

  • dom/PositionConstructors.h: (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply):
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::deleteTarget):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::updatePositionForNodeRemoval):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::rangeCompliantEquivalent): (WebCore::positionBeforeContainingSpecialElement): (WebCore::positionAfterContainingSpecialElement): (WebCore::positionBeforeTabSpan):
4:25 PM Changeset in webkit [48233] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-07-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Re-organize position creation functions in preparation for adding more
​https://bugs.webkit.org/show_bug.cgi?id=25494

Make position functions inline to avoid ref-churn.
Remove startPosition/endPosition as they were only used in one place.

No functional changes, thus no tests.

  • dom/Position.cpp:
  • dom/Position.h: (WebCore::positionBeforeNode): (WebCore::positionAfterNode):
  • editing/SelectionController.cpp: (WebCore::SelectionController::moveTo):
  • editing/TypingCommand.cpp:
  • editing/htmlediting.cpp:
  • editing/htmlediting.h: (WebCore::firstDeepEditingPositionForNode): (WebCore::lastDeepEditingPositionForNode):
  • rendering/RenderObject.cpp:
3:50 PM Changeset in webkit [48232] by kevino@webkit.org
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Add wxSize conversions for IntSize.
​https://bugs.webkit.org/show_bug.cgi?id=29104

3:35 PM Changeset in webkit [48231] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-09 Yaar Schnitman <​yaar@chromium.org>

Reviewed by David Levin.

Chromium uses its own config.h file that was forked from webkit's config.h.
By merging in Chromium's defines, Chromium would again be able to use webkit's
config.h.

​https://bugs.webkit.org/show_bug.cgi?id=28882

  • config.h: Added chromium-specific defines.
3:21 PM Changeset in webkit [48230] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-09-09 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

commit-queue hangs if a builder has never built
​https://bugs.webkit.org/show_bug.cgi?id=29091

  • Scripts/modules/buildbot.py:
  • Scripts/modules/buildbot_unittest.py:
3:19 PM Changeset in webkit [48229] by eric@webkit.org
  • 10 edits
    2 adds in trunk

2009-09-09 Jens Alfke <​snej@chromium.org>

Reviewed by Eric Seidel.

Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
​https://bugs.webkit.org/show_bug.cgi?id=26700

  • fast/events/drag-dropeffect-expected.txt: Added.
  • fast/events/drag-dropeffect.html: Added.

2009-09-09 Jens Alfke <​snej@chromium.org>

Reviewed by Eric Seidel.

Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
​https://bugs.webkit.org/show_bug.cgi?id=26700

  • At the start of a drag operation, the value of effectAllowed should be the string "uninitialized".
  • At end of dragstart handler, if effectAllowed hasn't been set yet, it should be set to "copy".
  • on dragenter and dragover event, dropEffect should be initialized to a default value based on the value of effectAllowed.
  • at end of dragenter and dragover the dropEffect should be set to "none" if the value set by the handler doesn't match the effectAllowed.
  • on dragleave event, dropEffect should be "none".
  • on drop event, dropEffect should be the previously negotiated value.

Test: fast/events/drag-dropeffect.html

  • WebCore.base.exp:

Added a parameter to EventHandler::dragSourceMovedTo.

  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):

Initialize m_effectAllowed to "uninitialized".

(WebCore::Clipboard::sourceOperation):

Treat "uninitialized" as meaning no value has been set.

  • page/DragController.cpp: (WebCore::DragController::DragController):

Initialize new member m_destinationDragOperation.

(WebCore::DragController::dragExited):

Set m_destinationDragOperation to none on dragExit.

(WebCore::DragController::performDrag):

Set m_destinationDragOperation to current dropEffect.

(WebCore::DragController::dragEnteredOrUpdated):

Make sure to clear the operation if drag source doesn't allow it.

(WebCore::DragController::tryDHTMLDrag):

Set a default value for the dst drag op before sending dragEnter/Over.

(WebCore::DragController::startDrag):

Clear m_destinationDragOperation at start of drag.

  • page/DragController.h: (WebCore::DragController::destinationDragOperation):

Added new member m_destinationDragOperation, and its public getter.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop):

dropEffect should be 'none' during dropleave handler, per spec.

(WebCore::EventHandler::dragSourceMovedTo):

Added DragOperation parameter, so the handler sees the current dropEffect.

(WebCore::EventHandler::handleDrag):

Assume DragOperationEvery for non-DHTML drags.

  • page/EventHandler.h:

Added DragOperation parameter to dragSourceMovedTo().

2009-09-09 Jens Alfke <​snej@chromium.org>

Reviewed by Eric Seidel.

Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
​https://bugs.webkit.org/show_bug.cgi?id=26700

  • WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]):

Pass current drag operation (if known) to EventHandler::dragSourceMovedTo().

3:10 PM Changeset in webkit [48228] by eric@webkit.org
  • 8 edits
    2 adds in trunk

2009-09-09 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] DumpRenderTree needs eventSender object and implementation
​https://bugs.webkit.org/show_bug.cgi?id=25990

Enable plenty of tests that now pass thanks to (only) partial
EventSender implementation.

  • platform/gtk/Skipped:

2009-09-09 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] DumpRenderTree needs eventSender object and implementation
​https://bugs.webkit.org/show_bug.cgi?id=25990

Creates a function that is accessible from the DumpRenderTree tool
and calls the layout method on the frame view.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_layout):

2009-09-09 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] DumpRenderTree needs eventSender object and implementation
​https://bugs.webkit.org/show_bug.cgi?id=25990

Implements most of the EventSender object's functionality for
the DumpRenderTree tool. Implementation still lacks support
for drag and drop tests and forward leaps.

Based on work by Holger Hans Peter Freyther.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Focus on the view before loading a new test. (webViewWindowObjectCleared):
  • DumpRenderTree/gtk/EventSender.cpp: Added. (getDragModeCallback): (setDragModeCallback): (leapForwardCallback): (contextClickCallback): (updateClickCount): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (beginDragWithFilesCallback): (replaySavedEvents): (keyDownCallback): (textZoomInCallback): (textZoomOutCallback): (zoomPageInCallback): (zoomPageOutCallback): (getClass): (makeEventSender):
  • DumpRenderTree/gtk/EventSender.h: Added.
  • GNUmakefile.am: Add build rules for EventSender.
2:35 PM Changeset in webkit [48227] by eric@webkit.org
  • 14 edits
    2 adds in trunk

2009-09-09 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding a test for the database authorizer.

​https://bugs.webkit.org/show_bug.cgi?id=28918

  • storage/test-authorizer-expected.txt: Added.
  • storage/test-authorizer.html: Added.

2009-09-09 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Dimitri Glazkov.

  1. Adding support/bindings for read-only transactions.
  2. Disallowing the SQLITE_*_VIEW and REINDEX operations in the private browsing mode.
  3. Adding an authorizer test.

​https://bugs.webkit.org/show_bug.cgi?id=28918

Test: storage/test-authorizer.html

  • bindings/js/JSDatabaseCustom.cpp: (WebCore::createTransaction): Parses all arguments and executes a transaction. (WebCore::JSDatabase::transaction): Refactored to use createTransaction(). (WebCore::JSDatabase::readTransaction): Added to execute read-only transactions using createTransaction().
  • bindings/v8/custom/V8CustomBinding.h: Added the binding for Database::readTransaction().
  • bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::createTransaction): Parses all arguments and executes a transaction. (WebCore::transaction): Refactored to use createTransaction(). (WebCore::readTransaction): Added to execute read-only transactions using createTransaction().
  • storage/Database.cpp: (WebCore::Database::transaction): Added support for read-only transactions.
  • storage/Database.h: Added support for read-only transactions.
  • storage/Database.idl: Added support for read-only transactions.
  • storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::createTempTable): Make it obvious that the statement will be denied in private browsing mode and read-only transactions. (WebCore::DatabaseAuthorizer::dropTempTable): Same. (WebCore::DatabaseAuthorizer::createTempIndex): Same. (WebCore::DatabaseAuthorizer::dropTempIndex): Same. (WebCore::DatabaseAuthorizer::createTempTrigger): Same. (WebCore::DatabaseAuthorizer::dropTempTrigger): Same. (WebCore::DatabaseAuthorizer::createView): Deny in private browsing mode and read-only transactions. (WebCore::DatabaseAuthorizer::createTempView): Same. (WebCore::DatabaseAuthorizer::dropView): Same. (WebCore::DatabaseAuthorizer::dropTempView): Same. (WebCore::DatabaseAuthorizer::allowReindex): Same.
  • storage/DatabaseAuthorizer.h:
  • storage/SQLTransaction.cpp: Added support for read-only transactions. (WebCore::SQLTransaction::create): (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::acquireLock):
  • storage/SQLTransaction.h:
  • storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::acquireLock): Added a new parameter in preparation for a change that will allow multiple read-only transactions on the same DB to run concurrently.
  • storage/SQLTransactionCoordinator.h:
2:30 PM QtWebKitContrib edited by vestbo@webkit.org
(diff)
2:28 PM Changeset in webkit [48226] by vestbo@webkit.org
  • 2 edits in trunk/WebKitSite

Add instructions to bug reporting guidlines on how and when
to apply port-specific keywords.

Reviewed by Mark Rowe.

  • quality/bugwriting.html:
2:21 PM Changeset in webkit [48225] by hyatt@apple.com
  • 4 edits in trunk/WebCore/page

Fix namespace typos.

2:21 PM Changeset in webkit [48224] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/FrameTree.cpp

Fix namespace typos.

2:18 PM Changeset in webkit [48223] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix comment at Tor Arne Vestbø's request.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09

  • Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):

2:12 PM Changeset in webkit [48222] by hyatt@apple.com
  • 23 edits
    4 adds in trunk

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

  • css/CSSStyleSelector.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::attach):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
  • loader/PlaceholderDocument.cpp:

(WebCore::PlaceholderDocument::attach):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentForWorld):
(WebCore::PageGroup::removeAllUserContent):

  • page/PageGroup.h:

(WebCore::PageGroup::userStyleSheets):

  • page/UserStyleSheet.h: Added.

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::source):
(WebCore::UserStyleSheet::url):
(WebCore::UserStyleSheet::patterns):
(WebCore::UserStyleSheet::worldID):

  • page/UserStyleSheetTypes.h: Added.

WebKit/mac: ​https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

  • WebView/WebView.mm:

(+[WebView _addUserStyleSheetToGroup:source:url:worldID:patterns:]):

  • WebView/WebViewPrivate.h:

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

  • platform/mac/userscripts/simple-stylesheet-expected.checksum: Added.
  • platform/mac/userscripts/simple-stylesheet-expected.png: Added.
  • platform/mac/userscripts/simple-stylesheet-expected.txt: Added.
  • userscripts/simple-stylesheet.html: Added.
2:11 PM Changeset in webkit [48221] by kenneth@webkit.org
  • 3 edits in trunk/WebKit/qt

Implement some virtual event methods so that we can fix
event-related bugs in Qt patch releases.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09
Reviewed by Tor Arne Vestbø.

  • Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):

  • Api/qwebgraphicsitem.h:
1:40 PM Changeset in webkit [48220] by Laszlo Gombos
  • 5 edits
    6 adds in trunk

2009-09-09 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] CSS Style -webkit-box-shadow is not rendered correctly on
Qt platform
​https://bugs.webkit.org/show_bug.cgi?id=23291

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): Added the ability to draw shadows for all these curves.

2009-09-09 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] -webkit-box-shadow CSS Style is not rendered correctly on
Qt platform
​https://bugs.webkit.org/show_bug.cgi?id=23291

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
  • platform/qt/fast/box-shadow/inset-expected.checksum:
  • platform/qt/fast/box-shadow/inset-expected.png:
  • platform/qt/fast/box-shadow/spread-expected.checksum:
  • platform/qt/fast/box-shadow/spread-expected.png: Updated to show the new shadows.
1:15 PM Changeset in webkit [48219] by kenneth@webkit.org
  • 8 edits
    5 adds in trunk

.: [Qt] Add the alternative QtLauncher (based on QGraphicsView) to the build.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=28862

  • WebKit.pro:

WebCore: Add the qwebgraphicsitem.cpp to the build system.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=28862

  • WebCore.pro:

WebKit/qt: Add a new QGraphicsWidget based version of the "QWebView"
under the name "QWebGraphicsItem".

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org>, Antonio Gomes <​antonio.gomes@openbossa.org> on 2009-09-09
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=28862

Includes an alternative Qt launcher using the QGraphicsView.

  • Api/headers.pri:
  • Api/qwebgraphicsitem.cpp: Added.
  • Api/qwebgraphicsitem.h: Added.
  • Api/qwebpage.h:
  • QGVLauncher/QGVLauncher.pro: Copied from WebKit/qt/QtLauncher/QtLauncher.pro.
  • QGVLauncher/main.cpp: Added.
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::scroll):

11:41 AM Changeset in webkit [48218] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-09 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Roben.


​https://bugs.webkit.org/show_bug.cgi?id=28953

Added pre- and post- build events so that on build failure, the file
buildfailed is written to the directory $(WebKitOutputDir).

  • WinLauncher/WinLauncher.vcproj:
11:09 AM Changeset in webkit [48217] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2009-09-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Change reinterpret_cast to static_cast in r48212.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
10:56 AM Changeset in webkit [48216] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove WTF_PLATFORM_FORCE_PACK as it is no longer used
​https://bugs.webkit.org/show_bug.cgi?id=29066

  • wtf/Platform.h:
10:42 AM Changeset in webkit [48215] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-09
Add myself to list of committers.

  • Scripts/modules/committers.py:
10:36 AM Changeset in webkit [48214] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2009-09-08 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

commit-queue gets stuck if a non-committer sets commit-queue+ or review+
​https://bugs.webkit.org/show_bug.cgi?id=28605
​https://bugs.webkit.org/show_bug.cgi?id=28916

  • Scripts/bugzilla-tool:
    • Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit" comment now that it's used for rejecting patches for invalid committers too.
    • Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
    • Make the commit queue print patches count instead of bugs count, this also fixes ​https://bugs.webkit.org/show_bug.cgi?id=28916.
  • Scripts/modules/bugzilla.py:
    • Make _parse_attachment_element not validate reviewer/committer.
    • Share flag parsing code in _parse_attachment_flag.
    • Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
    • Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
    • Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
  • Scripts/modules/bugzilla_unittest.py:
    • Update this test to no longer expect committer/reviewer validation.
  • Scripts/modules/committers.py:
    • Return None on failed lookups instead of raising Exceptions.
  • Scripts/modules/committers_unittest.py:
    • Update tests to expect None returns instead of exceptions.
10:35 AM Changeset in webkit [48213] by kevino@webkit.org
  • 7 edits
    8 adds in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx port] Move functions in TemporaryLinkStubs.cpp out to files where
they belong.

​https://bugs.webkit.org/show_bug.cgi?id=29088

9:46 AM Changeset in webkit [48212] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2009-09-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

Implement flushing the instruction cache for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=29075

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush): Call IMB_Range to flush the instruction cache on Symbian
9:44 AM Changeset in webkit [48211] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-09-09 Erik Arvidsson <​arv@chromium.org>

Reviewed by David Levin.

Fix preference name in layout test.
​https://bugs.webkit.org/show_bug.cgi?id=29038

  • fast/events/click-focus-anchor.html:
  • fast/events/tab-focus-anchor.html:
9:27 AM Changeset in webkit [48210] by eric@webkit.org
  • 8 edits
    3 adds in trunk

2009-09-09 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Geolocation incorrectly calls error callback in case of exception in success callback.
​https://bugs.webkit.org/show_bug.cgi?id=27255

  • fast/dom/Geolocation/resources/callback-exception.js: Added. Tests that when an exception is thrown from the success callback, the error callback is not invoked.
  • fast/dom/Geolocation/callback-exception.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/callback-exception-expected.txt: Added. Expected result for above test.
  • platform/gtk/Skipped: Modified. Adds the above tests to the skipped list.

2009-09-09 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Geolocation incorrectly calls error callback in case of exception in success callback.
​https://bugs.webkit.org/show_bug.cgi?id=27255

Test: fast/dom/Geolocation/callback-exception.html

  • bindings/js/JSCustomPositionCallback.cpp: Modified. (WebCore::JSCustomPositionCallback::handleEvent): Modified. Removed raisedException out param.
  • bindings/js/JSCustomPositionCallback.h: Modified. Removed raisedException out param from handleEvent method and made handleEvent private.
  • bindings/js/JSCustomPositionErrorCallback.h: Modified. Made handleEvent private.
  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::sendPosition): Modified. No longer call error callback in case of exception in success callback.
  • page/PositionCallback.h: Modified. Removed raisedException out param from handleEvent method.
8:59 AM Changeset in webkit [48209] by benm@google.com
  • 5 edits
    6 adds in trunk

WebCore: When Geolocation permission is denied, stops watches as well as one-shots.
​https://bugs.webkit.org/show_bug.cgi?id=28305.

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

Tests: fast/dom/Geolocation/watch.html

fast/dom/Geolocation/permission-denied-stops-watches.html

  • page/Geolocation.cpp: Modified.

(WebCore::Geolocation::setIsAllowed): Modified. Marks the permission error as fatal.
(WebCore::Geolocation::handleError): Modified. If the error is fatal, stops watchers as well as one-shots.

  • page/PositionError.h: Modified.

(WebCore::PositionError::setIsFatal): Added. Marks an error as fatal.
(WebCore::PositionError::isFatal): Added. Determines whether an error is fatal.

LayoutTests: When Geolocation permission is denied, stops watches as well as one-shots.
​https://bugs.webkit.org/show_bug.cgi?id=28305.

Patch by Steve Block <​steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

  • fast/dom/Geolocation/resources/watch.js: Added. Tests that a watch correctly reports updates from the Geolocation service.
  • fast/dom/Geolocation/watch.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/watch-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Added. Tests that when Geolocation permission is denied, watches are stopped, as well as one-shots.
  • fast/dom/Geolocation/permission-denied-stops-watches.html: Added. Wrapper for above test.
  • fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Added. Expected result for above test.
8:15 AM Changeset in webkit [48208] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-09 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Eric Seidel.

Bug 28964 - [Chromium] ChromiumDataObject should have getter/setter interface

Added getter/setter methods and trivial inline implementations for each.
(Note that they are not yet actually used.)
Once the Chromium code is changed to use them instead of directly accessing the
member variables, the member variables should be made private and cleaned up.

No new tests (no functional behavior changed).

  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::mainURL): (WebCore::ChromiumDataObject::setMainURL): (WebCore::ChromiumDataObject::mainURLTitle): (WebCore::ChromiumDataObject::setMainURLTitle): (WebCore::ChromiumDataObject::textPlain): (WebCore::ChromiumDataObject::setTextPlain): (WebCore::ChromiumDataObject::textHTML): (WebCore::ChromiumDataObject::setTextHTML): (WebCore::ChromiumDataObject::htmlBaseURL): (WebCore::ChromiumDataObject::setHTMLBaseURL): (WebCore::ChromiumDataObject::content): (WebCore::ChromiumDataObject::releaseContent): (WebCore::ChromiumDataObject::setContent): (WebCore::ChromiumDataObject::contentFileExtension): (WebCore::ChromiumDataObject::setContentFileExtension): (WebCore::ChromiumDataObject::contentFileName): (WebCore::ChromiumDataObject::setContentFileName): (WebCore::ChromiumDataObject::fileNames): (WebCore::ChromiumDataObject::setFileNames): (WebCore::ChromiumDataObject::takeFileNames):
7:56 AM Changeset in webkit [48207] by Simon Hausmann
  • 4 edits
    1 move in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=29024
Make JavaScriptCore compile on platforms with case-insensitive file systems and typeinfo.h in STL

Patch by Kent Hansen <​khansen@trolltech.com> on 2009-09-09
Reviewed by Darin Adler.

These platforms include Microsoft Visual Studio 2003, and Symbian with Metrowerks compiler.

7:49 AM Changeset in webkit [48206] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()

Reviewed by Mark Rowe.

No change to layout test results.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::clickPointY): Changed to return y value instead of x value.
6:26 AM Changeset in webkit [48205] by yael.aharon@nokia.com
  • 2 edits in trunk

[Qt] locale date displays incorrect date format in symbian.
​https://bugs.webkit.org/show_bug.cgi?id=29032

Patch by Pat Bradley <​vincent.bradley@nokia.com> on 2009-09-08
Reviewed by Ariya Hidayat.

strftime() in Symbian does not support #
Layout tests cannot be run on Symbian yet, so they are not updated.

  • runtime/DatePrototype.cpp:
2:53 AM Changeset in webkit [48204] by Simon Hausmann
  • 2 edits in trunk/WebCore

NPAPI Plugin NPP_AsFile not working on Qt Webkit
​https://bugs.webkit.org/show_bug.cgi?id=29068

Patch by Rohini Ananth <​rohini.ananth@nokia.com> on 2009-09-09
Reviewed by Simon Hausmann.

  • platform/qt/FileSystemQt.cpp:

(WebCore::openTemporaryFile)
Autoremove property of QTemporaryFile has been set to false. Hence closeFile() just closes and does not delete the file.
This solves the deletion of created temp file in PluginStream::destroyStream() before passing to plugin in NPP_AsFile.

12:13 AM Changeset in webkit [48203] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Adjust WinCairo-specific property sheet to use static versions of
libjpeg.lib and libpng.lib. Change to libpng.lib required addition
of zlib.lib to link.

Reviewed by Dave Levin.

  • win/tools/vsprops/WinCairo.vsprops:
12:02 AM Changeset in webkit [48202] by oliver@apple.com
  • 5 edits in trunk

JSON.stringify(Date) loses the milliseconds information
​https://bugs.webkit.org/show_bug.cgi?id=29063

Reviewed by Maciej Stachowiak.

Make sure we include milliseconds in the output of toISOString.

Note: See TracTimeline for information about the timeline view.