Timeline
Sep 12, 2009:
- 8:24 PM Changeset in webkit [48340] by
-
- 3 edits in trunk/JavaScriptCore
Build fix for windows exports (again).
- 8:10 PM Changeset in webkit [48339] by
-
- 3 edits in trunk/JavaScriptCore
Build fix for windows exports
- 8:03 PM Changeset in webkit [48338] by
-
- 2 edits in trunk/JavaScriptCore
Correct fix for non-allinonefile builds
- 8:00 PM Changeset in webkit [48337] by
-
- 2 edits in trunk/JavaScriptCore
Fix non-allinonefile builds
- 7:44 PM Changeset in webkit [48336] by
-
- 41 edits3 adds in trunk
[ES5] Implement Object.keys
https://bugs.webkit.org/show_bug.cgi?id=29170
Reviewed by Maciej Stachowiak.
This patch basically requires two separate steps, the first is to split getPropertyNames
into two functions -- getOwnPropertyNames and getPropertyNames, basically making them behave
in the same way as getOwnPropertySlot and getPropertySlot. In essence getOwnPropertyNames
produces the list of properties on an object excluding its prototype chain and getPropertyNames
just iterates the the object and its prototype chain calling getOwnPropertyNames at each level.
- 6:17 PM Changeset in webkit [48335] by
-
- 2 edits in trunk/WebKitTools
run-webkit-tests has a timeout value that is too low
https://bugs.webkit.org/show_bug.cgi?id=29223
Reviewed by Mark Rowe.
- Scripts/run-webkit-tests:
Changed timeout value to 20 seconds to avoid timing out too early.
- 12:11 PM Changeset in webkit [48334] by
-
- 6 edits2 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration
Reviewed by Anders Carlsson.
Test: fast/dom/elementFromPoint-relative-to-viewport.html
- dom/Document.cpp:
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration
Reviewed by Anders Carlsson.
- fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Added.
- fast/dom/elementFromPoint-relative-to-viewport.html: Added.
- fast/events/offsetX-offsetY.html: Change to use clientX/Y instead of pageX/Y.
- fast/forms/slider-transformed.html: Ditto.
- fast/forms/slider-zoomed.html: Ditto.
- 1:14 AM Changeset in webkit [48333] by
-
- 3 edits2 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing
Reviewed by Maciej Stachowiak.
In accordance with the CSSOM View Module spec, Document.caretRangeFromPoint should interpret
the point passed to it as relative to the viewport, not the document.
Test: fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html
- dom/Document.cpp:
(WebCore::Document::caretRangeFromPoint):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing
Reviewed by Maciej Stachowiak.
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html: Added.
Sep 11, 2009:
- 11:55 PM Changeset in webkit [48332] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[GTK] Use gtk_style_set_background instead of gdk_window_set_background
https://bugs.webkit.org/show_bug.cgi?id=29173
Use gtk_style_set_background instead of gdk_window_set_background,
as suggested by the documentation. Also, use GTK_STATE_NORMAL
directly, since that's the default state of a GtkWidget.
- webkit/webkitwebview.cpp: (webkit_web_view_realize):
- 9:52 PM Changeset in webkit [48331] by
-
- 20 edits in trunk
getPropertyNames caching is invalid when the prototype chain contains objects with custom getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=29214
Reviewed by Sam Weinig.
Add a flag to TypeInfo to indicate whether a type overrides getPropertyNames.
This flag is used to make sure that caching of the property name data is safe.
- 8:40 PM Changeset in webkit [48330] by
-
- 1 edit12 adds in trunk/WebCore
Added some manual tests to show WebGL in action
https://bugs.webkit.org/show_bug.cgi?id=29215
- 8:33 PM Changeset in webkit [48329] by
-
- 2 edits in trunk/WebKitTools
wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
architectures are supported for building wxWebKit.
- 8:31 PM Changeset in webkit [48328] by
-
- 5 edits in trunk
aria definition role spelled wrong "defintion"
https://bugs.webkit.org/show_bug.cgi?id=28840
Reviewed by Darin Adler.
WebCore:
Test: accessibility/aria-slider-value-change.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::RoleEntry::):
LayoutTests:
- platform/mac/accessibility/aria-grouping-roles-expected.txt:
- platform/mac/accessibility/aria-grouping-roles.html:
- 7:17 PM Changeset in webkit [48327] by
-
- 3 edits3 adds in trunk
2009-09-11 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=29210
- fast/events/resources/tab-is-focusable-assert.js:
- fast/events/tab-is-focusable-assert-expected.txt: Added.
2009-09-11 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=29210
- dom/Node.cpp: (WebCore::Node::isFocusable):
- 6:48 PM Changeset in webkit [48326] by
-
- 2 edits in trunk/WebKit/mac
Fix <rdar://problem/7145242> Crashes inside WTF::HashTable below NetscapePluginInstanceProxy::disconnectStream
Reviewed by Jon Honeycutt.
- Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::cancelLoad): Canceling the load can result in calling through to disconnectStream.
If the plug-in instance holds the last reference to the plug-in stream this will result in the stream being deallocated.
This leads to HostedNetscapePluginStream::cancelLoad's call to disconnectStream being passed a deallocated stream object.
Since the stream was already disconnected by the call to cancel there's no need to call disconnectStream a second time.
- 5:13 PM Changeset in webkit [48325] by
-
- 14 edits in trunk/WebCore
Added variants to uniform* and vertexAttrib* calls which take sequence<> in place of CanvasArray
https://bugs.webkit.org/show_bug.cgi?id=29139
I also added a data() call to each of the CanvasArray subclasses to give back a types pointer
to the baseAddress().
- 5:00 PM Changeset in webkit [48324] by
-
- 2 edits in trunk/WebKit/win
2009-09-11 Steve Falkenburg <sfalken@apple.com>
Reviewed by Dan Bernstein.
Properly propagate preference from WebPreferences to WebCore::Settings.
https://bugs.webkit.org/show_bug.cgi?id=29192
- WebView.cpp: (WebView::initWithFrame): Apply setting when creating a new WebView. (WebView::notifyPreferencesChanged): Apply setting when preferences change.
- 4:59 PM Changeset in webkit [48323] by
-
- 2 edits in trunk/WebCore
2009-09-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Add ENABLE(WEB_SOCKETS) guards.
https://bugs.webkit.org/show_bug.cgi?id=29174
- bindings/v8/custom/V8WebSocketCustom.cpp:
- 4:57 PM Changeset in webkit [48322] by
-
- 2 edits in trunk/LayoutTests
2009-09-11 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Mark Rowe.
Add the http/tests/security/mixedContent to the Skipped list while
test failures are being investigated.
- platform/win/Skipped:
- 4:34 PM Changeset in webkit [48321] by
-
- 10 edits2 deletes in trunk
2009-09-11 Eric Seidel <eric@webkit.org>
No review, rolling out r48229.
http://trac.webkit.org/changeset/48229
- fast/events/drag-dropeffect-expected.txt: Removed.
- fast/events/drag-dropeffect.html: Removed.
2009-09-11 Eric Seidel <eric@webkit.org>
No review, rolling out r48229.
http://trac.webkit.org/changeset/48229
- WebCore.base.exp:
- dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::sourceOperation):
- page/DragController.cpp: (WebCore::DragController::DragController): (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::startDrag):
- page/DragController.h:
- page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::dragSourceMovedTo): (WebCore::EventHandler::handleDrag):
- page/EventHandler.h:
2009-09-11 Eric Seidel <eric@webkit.org>
No review, rolling out r48229.
http://trac.webkit.org/changeset/48229
- WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]):
- 4:28 PM Changeset in webkit [48320] by
-
- 3 edits in trunk/WebKitTools
2009-09-11 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
bugzilla-tool rollout threw exception under svn
https://bugs.webkit.org/show_bug.cgi?id=29211
- Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
- Scripts/modules/scm_unittest.py: add testing for this fix.
- 3:18 PM Changeset in webkit [48319] by
-
- 2 edits in trunk/WebCore
Fix the build.
2009-09-11 Michelangelo De Simone <micdesim@gmail.com>
Fix the build.
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
- 3:01 PM Changeset in webkit [48318] by
-
- 3 edits3 adds in trunk
2009-09-11 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=27456
Test case for url validation in ValidityState.
- fast/forms/ValidityState-typeMismatch-url-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-url.html: Added.
- fast/forms/resources/ValidityState-typeMismatch-url.js: Added. (check):
2009-09-11 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=27456
Added support for static validation of url in
ValidityState, for url state inputs.
From HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#url-state
Test: fast/forms/ValidityState-typeMismatch-url.html
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
- 2:52 PM Changeset in webkit [48317] by
-
- 3 edits in trunk/WebCore
2009-09-11 Evan Stade <estade@chromium.org>
Reviewed by Darin Adler.
Revert r47992: Expose functions to change the focus ring color for
Linux Chromium.
As Darin Fisher has pointed out, there is a better way to do this.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
- rendering/RenderThemeChromiumLinux.h:
- 2:51 PM CommitQueue edited by
- (diff)
- 2:47 PM Changeset in webkit [48316] by
-
- 2 edits in trunk/WebKitTools
2009-09-11 Brian Weinstein <bweinstein@apple.com>
Add myself to the committers list.
- Scripts/modules/committers.py:
- 2:34 PM Changeset in webkit [48315] by
-
- 6 edits in trunk
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=29207
Add checks for using WebCore JS context on secondary threads
- 1:21 PM Changeset in webkit [48314] by
-
- 4 edits in trunk/WebCore
2009-09-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
The inspector should have scope bars.
https://bugs.webkit.org/show_bug.cgi?id=14353
Add scope bars to the console, so the user can choose which category
of messages they want to see (All, Errors, Warnings, Logs), and they
can choose from one or more of {Errors, Warnings, Logs}.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createFilterElement): (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._updateFilter): (WebInspector.ConsoleView.prototype.filter): (WebInspector.ConsoleView.prototype.attach):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 1:09 PM Changeset in webkit [48313] by
-
- 3 edits in trunk/WebCore
2009-09-11 Yusuke Sato <yusukes@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Complex text doesn't show up with text stroking
https://bugs.webkit.org/show_bug.cgi?id=28707
Added extra NULL checks for HDC. This is the second fix for issue 28707,
and the fix is similar to http://trac.webkit.org/changeset/45482.
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):
- platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):
- 12:05 PM Changeset in webkit [48312] by
-
- 2 edits in trunk/WebKitTools
2009-09-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool land-patches should only fail-fast in --commit-queue mode
https://bugs.webkit.org/show_bug.cgi?id=29201
- Scripts/bugzilla-tool:
- 11:47 AM Changeset in webkit [48311] by
-
- 6 edits2 adds in trunk
2009-09-11 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make ElementTimeControl methods return void and not throw.
https://bugs.webkit.org/show_bug.cgi?id=28831
SVG 1.1 erratum:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface
- svg/dom/smil-methods-expected.txt: Added.
- svg/dom/smil-methods.svg: Added.
2009-09-11 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make ElementTimeControl methods return void and not throw.
https://bugs.webkit.org/show_bug.cgi?id=28831
SVG 1.1 erratum:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface
Test: svg/dom/smil-methods.svg
- svg/ElementTimeControl.h: Change return type from bool to void and remove exception argument.
- svg/ElementTimeControl.idl: Change return type from bool to void and remove raises claus.
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::beginElement): Change return type from bool to void and remove exception argument. (WebCore::SVGAnimationElement::beginElementAt): Ditto. (WebCore::SVGAnimationElement::endElement): Ditto. (WebCore::SVGAnimationElement::endElementAt): Ditto.
- svg/SVGAnimationElement.h: Ditto.
- 11:31 AM Changeset in webkit [48310] by
-
- 3 edits in trunk/WebCore
Added support for texImage2D which takes CanvasArray
https://bugs.webkit.org/show_bug.cgi?id=29191
- bindings/js/JSCanvasRenderingContext3DCustom.cpp: (WebCore::JSCanvasRenderingContext3D::texImage2D):
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::texImage2D):
- 11:15 AM Changeset in webkit [48309] by
-
- 3 edits in trunk/BugsSite
2009-09-11 David Kilzer <ddkilzer@apple.com>
Apply fix for http://www.bugzilla.org/security/3.0.8/
- 11:04 AM Changeset in webkit [48308] by
-
- 10 edits in trunk
WebCore: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192
Reviewed by Darin Adler.
- page/Settings.cpp:
(WebCore::Settings::setShouldUseHighResolutionTimers): Added.
- page/Settings.h: Added getter/setter for shouldUseHighResolutionTimers.
(WebCore::Settings::shouldUseHighResolutionTimers): Added.
- platform/win/SharedTimerWin.cpp:
(WebCore::setSharedTimerFireTime): Don't run high resolution timer code if it is disabled.
WebKit/win: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192
Reviewed by Darin Adler.
- Interfaces/IWebPreferencesPrivate.idl: Added getter/setter.
Put this just after last 4.0.3 method for future merging.
- Interfaces/WebKit.idl: Touched to force a rebuild.
- WebPreferenceKeysPrivate.h: Added prefs key for high res timers.
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled.
(WebPreferences::setShouldUseHighResolutionTimers): Added.
(WebPreferences::shouldUseHighResolutionTimers): Added.
- WebPreferences.h: Added getter/setter.
- 11:03 AM Changeset in webkit [48307] by
-
- 2 edits in trunk/WebKitTools
Make commit-log-editor move common prefixes to the top of the log
Fies <http://webkit.org/b/29190> commit-log-editor should move common
prefixes to the top of the commit log
Reviewed by Darin Adler.
- Scripts/commit-log-editor: Find and remove the longest common prefix
ending in a double newline from each ChangeLog entry, then put that
common prefix at the top of the commit log.
(removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
removes, and returns the longest common prefix ending in a double
newline from a hash of strings
- 10:59 AM Changeset in webkit [48306] by
-
- 8 edits1 add in trunk/WebCore
2009-09-11 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by Adam Barth.
[v8] Share persistent context handles between events
Change events to use a single ref-counted shared persistent handle
to the context in which to run, rather than create a new
persistent handle for each new event which puts pressure on the
gc.
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/v8/SharedPersistent.h: Added. (WebCore::SharedPersistent::set): (WebCore::SharedPersistent::get): (WebCore::SharedPersistent::disposeHandle): (WebCore::SharedPersistent::create): (WebCore::SharedPersistent::SharedPersistent):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::handleEvent):
- bindings/v8/V8AbstractEventListener.h:
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::~V8IsolatedWorld):
- bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::context): (WebCore::V8IsolatedWorld::shared_context):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::createWrapperFromCacheSlowCase): (WebCore::V8Proxy::isContextInitialized): (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::clearDocumentWrapperCache): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::setSecurityToken): (WebCore::V8Proxy::updateDocument): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::shared_context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::setContextDebugId):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::context): (WebCore::V8Proxy::shared_context):
- 10:20 AM Changeset in webkit [48305] by
-
- 2 edits in trunk/WebCore
2009-09-11 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
Create a real handle (one which would save an object from GC).
https://bugs.webkit.org/show_bug.cgi?id=29150
- bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
- 10:12 AM Changeset in webkit [48304] by
-
- 2 edits in trunk/WebKitTools
2009-09-11 Eric Seidel <eric@webkit.org>
Fix obvious typo in previous commit, no review.
bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715
- Scripts/bugzilla-tool: add back missing "scm" argument.
- 9:54 AM Changeset in webkit [48303] by
-
- 5 edits in trunk/WebKitTools
2009-09-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715
bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
The --complete-rollout option will automatically land and update the bug.
Eventually --complete-rollout will be default, but that will require more testing.
This first pass is good enough for others to try and file bugs about.
- Scripts/bugzilla-tool:
- Move modified_changelogs into scm.py.
- Move svn_revision_from_commit_text logic into scm.py.
- Add RolloutCommit command.
- Scripts/modules/bugzilla.py:
- Add reopen_bug command used by RolloutCommit.
- Scripts/modules/scm.py:
- Add functions to support RolloutCommit.
- Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
- Add a str() call so that svn_commit_log can take a numeric argument.
- Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
- Made dry_run commits return something that svn_revision_from_commit_text can parse.
- Scripts/modules/scm_unittest.py:
- Add read_from_path for easy file reading.
- Put test4 on a new line to make reverts work w/o conflict.
- Add an "svn update" call so that the checkout revision matches the server revision.
- Add tests for svn_revision_from_commit_text.
- Add a simple test for apply_reverse_diff.
- Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
- Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
- 9:35 AM Changeset in webkit [48302] by
-
- 9 edits in trunk
Get user script/stylesheet tests running on Windows
Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
skipped on Windows
Reviewed by John Sullivan.
WebKit/win:
- Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup,
addUserStyleSheetToGroup, removeUserContentFromGroup,
removeAllUserContentFromGropu to match the Mac SPI.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserContentFromGroup):
(WebView::removeAllUserContentFromGroup):
- WebView.h:
Added. Implementation was based on similar methods in WebView.mm.
WebKitTools:
- DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
against comsuppw.lib so we can use _bstr_t.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
order, added #include of comutil.h for _bstr_t.
(bstrT): Helper function to convert a JSStringRef to a _bstr_t.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
Implemented. Implementations were based on those in
LayoutTestControllerMac.mm.
LayoutTests:
- platform/win/Skipped: Removed the userscripts directory.
- 7:47 AM Changeset in webkit [48301] by
-
- 3 edits in trunk/WebCore
2009-09-11 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
Inline WebCore::v8String as it only invokes WebCore::v8ExternalString.
https://bugs.webkit.org/show_bug.cgi?id=29152
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8Binding.h: (WebCore::v8String):
- 6:29 AM Changeset in webkit [48300] by
-
- 3 edits in trunk/JavaScriptCore
2009-09-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
Compiling JavaScriptCore on sparc 64 with gcc fails.
ThreadSafeShared uses the atomic gnu_cxx::exchange_and_add with an int,
however on sparc 64 the _Atomic_word argument is typedefed to long (8 bytes).
The patch disables WTF_USE_LOCKFREE_THREADSAFESHARED in ThreadSafeShared to use
a mutex instead when compiling for sparc 64 with gcc.
- wtf/Platform.h: sparc64 is not defined on all OS.
Uses instead: sparc && arch64 sparcv9 - wtf/Threading.h:
- 5:58 AM Changeset in webkit [48299] by
-
- 2 edits in trunk/WebKit/qt
Doc: Note that Netscape plugins are only available on desktop platforms.
Patch by David Boddie <dboddie@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.
- docs/qtwebkit.qdoc:
- 5:58 AM Changeset in webkit [48298] by
-
- 2 edits in trunk/JavaScriptCore
Fix compile error on Windows7(64Bit) with latest SDK.
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
Added the missing include file.
- runtime/UString.cpp:
- 5:58 AM Changeset in webkit [48297] by
-
- 2 edits in trunk/WebKit/qt
Adjust the name of the contentspage for the documentation
to the new name used in Qt 4.6.
Patch by Martin Smith <msmith@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.
- docs/qtwebkit.qdoc:
- 5:58 AM Changeset in webkit [48296] by
-
- 2 edits in trunk/JavaScriptCore
Qt/Windows CE compile fix, include the executable allocator and
markstack implementation in the windows build.
Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.
- JavaScriptCore.pri:
- 5:58 AM Changeset in webkit [48295] by
-
- 6 edits in trunk
WebCore: Changed URLs from qtsoftware.com to qt.nokia.com, as part of a general
renaming.
Patch by Ariya Hidayat <ariya.hidayat@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
- ChangeLog-2009-06-16:
WebKit/qt: Changed URLs from qtsoftware.com to qt.nokia.com, as part of a general
renaming.
Patch by Ariya Hidayat <ariya.hidayat@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
- Api/qwebpluginfactory.cpp:
- docs/webkitsnippets/simple/main.cpp:
(main):
- docs/webkitsnippets/webpage/main.cpp:
(main):
- 5:57 AM Changeset in webkit [48294] by
-
- 12 edits in trunk/WebKit/qt
Restructure the documentation, both on a file and on a content level.
Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
- Api/qwebdatabase.cpp:
- Api/qwebelement.cpp:
- Api/qwebframe.cpp:
- Api/qwebhistory.cpp:
- Api/qwebhistoryinterface.cpp:
- Api/qwebpage.cpp:
- Api/qwebpluginfactory.cpp:
- Api/qwebsecurityorigin.cpp:
- Api/qwebsettings.cpp:
- Api/qwebview.cpp:
- docs/qtwebkit.qdoc:
- 5:57 AM Changeset in webkit [48293] by
-
- 2 edits in trunk/WebCore
Use LIBS_PRIVATE on Qt/Mac.
Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
On the Mac, it means "-framework ApplicationServices -framework Carbon
-framework AppKit" are no longer part of the default LIBS in Qt
applications. This required a lot of fixes where we used Mac-specific
code in Qt.
- WebCore.pro:
- 2:02 AM Changeset in webkit [48292] by
-
- 2 edits in trunk/WebCore
2009-09-11 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=29165
- bindings/scripts/CodeGeneratorV8.pm: Remove WK_ucfirst and WK_lcfirst, and call the ones in CodeGenerator.pm instead.
- 1:55 AM Changeset in webkit [48291] by
-
- 2 edits in trunk/WebKit/qt
2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29136
[Qt] emit microFocusChanged() signal when no QWidget-based view is present.
emit microFocusChange() signal regardless of view.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
- 1:43 AM Changeset in webkit [48290] by
-
- 2 edits in trunk/WebCore
2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=29132
Symbian winscw compiler fails compiling WebCore/text/RegularExpression.cpp.
Add RegularExpression class qualifier before Private.
- platform/text/RegularExpression.cpp:
- 1:35 AM Changeset in webkit [48289] by
-
- 2 edits in trunk/WebCore
2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=29131
Use a different variadic macro format for Symbian compiler.
Use arg... instead of ellipsis in variadic macro.
- platform/StaticConstructors.h:
- 1:27 AM Changeset in webkit [48288] by
-
- 13 edits4 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28806
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
[Qt] Make the WebInspector available as a QWidget.
- WebCore.pro:
WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=28806
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.
[Qt] Make the WebInspector available as a QWidget.
- Api/headers.pri:
- Api/qwebelement.cpp:
(QWebElement::enclosingElement):
- Api/qwebelement.h:
- Api/qwebinspector.cpp: Added.
- Api/qwebinspector.h: Added.
- Api/qwebinspector_p.h: Added.
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::setInspector):
(QWebPagePrivate::getOrCreateInspector):
(QWebPagePrivate::inspectorController):
(QWebPage::~QWebPage):
(QWebPage::triggerAction):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
- Api/qwebsettings.cpp:
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientWebPage::InspectorClientWebPage):
(WebCore::InspectorClientWebPage::createWindow):
(WebCore::InspectorClientQt::createPage):
(WebCore::InspectorClientQt::showWindow):
(WebCore::InspectorClientQt::closeWindow):
(WebCore::InspectorClientQt::attachWindow):
(WebCore::InspectorClientQt::detachWindow):
(WebCore::InspectorClientQt::updateWindowTitle):
- WebCoreSupport/InspectorClientQt.h:
- docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp: Added.
- 1:18 AM Changeset in webkit [48287] by
-
- 2 edits in trunk/WebCore
Unreviewed fix for the Web Inspector with the Qt build.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-11
Re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource
- inspector/front-end/WebKit.qrc:
- 1:12 AM Changeset in webkit [48286] by
-
- 2 edits in trunk/WebCore
Fix the Qt build, remove stray semicolon from function definition.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-11
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::buffered):
- 12:43 AM Changeset in webkit [48285] by
-
- 2 edits in trunk/WebKit/win
Fix crash on launch on Windows.
Rubber-stamped by Mark Rowe.
- WebKit.vcproj/WebKit.vcproj:
Define ENABLE_WEB_SOCKETS for all configurations.
