⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 14, 2009:

9:25 PM Changeset in webkit [48388] by beidson@apple.com
  • 5 edits in trunk

Page cache should support pages with unload handlers as an experiment.
<rdar://problem/7196485> and https://bugs.webkit.org/show_bug.cgi?id=29021

Reviewed by Darin Adler.

WebCore:

For the experiment, only allow pages with unload handlers into the Page Cache on
Mac and Windows.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests:

Disable fast/loader/frames-with-unload-handlers-in-page-cache.html as it doesn't
make sense in the context of this experiment.

  • platform/mac/Skipped:
  • platform/win/Skipped:
8:22 PM Changeset in webkit [48387] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

8:21 PM Changeset in webkit [48386] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.18

New tag.

8:07 PM Changeset in webkit [48385] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-4-branch

Merge r48368.

8:05 PM Changeset in webkit [48384] by mrowe@apple.com
  • 10 edits in branches/safari-4-branch/WebCore

Merge r48367.

7:11 PM Changeset in webkit [48383] by kov@webkit.org
  • 5 edits in trunk

Undoing mess: committing test code

7:11 PM Changeset in webkit [48382] by kov@webkit.org
  • 8 edits in trunk/WebKit/gtk

2009-09-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez and Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=29134
[GTK] Add API to access sub resources

Implement getting subresources, and improve testing of
main, and sub resources loading.

7:08 PM Changeset in webkit [48381] by kov@webkit.org
  • 5 edits in trunk

Java

6:28 PM Changeset in webkit [48380] by cmarrin@apple.com
  • 4 edits
    3 adds in trunk

Add LayoutTests infrastructure to enable and disable webgl tests.
Also added a webgl test.
https://bugs.webkit.org/show_bug.cgi?id=29254

6:07 PM Changeset in webkit [48379] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-09-14 Simon Fraser <Simon Fraser>

Fix the change in r48376 to do a null-check to fix a crashing test.

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
5:54 PM Changeset in webkit [48378] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2009-09-14 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Add --iterations option to run-webkit-tests to repeat the tests N times
https://bugs.webkit.org/show_bug.cgi?id=29263

When run with --iterations N, run-webkit-tests will repeat the tests N times.

  • Scripts/run-webkit-tests:
5:28 PM Changeset in webkit [48377] by beidson@apple.com
  • 2 edits in trunk/LayoutTests
5:19 PM Changeset in webkit [48376] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-09-14 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7047282> Safari crashes at WebCore::RenderMenuList::adjustInnerStyle() + 436

Avoid a crash when a mouse event handler on a <select> changes the select from a popup
to a list (by setting the 'size' property) inside the event handler.

Test: fast/forms/select-change-popup-to-listbox-in-event-handler.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
4:52 PM Changeset in webkit [48375] by andersca@apple.com
  • 3 edits in trunk/WebCore

More PopupMenu cleanup.

Reviewed by Jon Honeycutt.

  • platform/PopupMenu.h:
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
Call registerClass.

(WebCore::PopupMenu::registerClass):
Make this a private static member function so it can refer to PopupMenuWndProc.

(WebCore::PopupMenu::PopupMenuWndProc):
Try to get the PopupMenu and call its wndProc member function.

(WebCore::PopupMenu::wndProc):
Make this a member function.

4:08 PM Changeset in webkit [48374] by beidson@apple.com
  • 4 edits in trunk

Fix more fallout I wrought on myself by not testing the final authentication patch on Windows.

3:46 PM Changeset in webkit [48373] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKitTools

GTK build fix.

Unreviewed.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::setLogScrollingStartEvents):

3:45 PM Changeset in webkit [48372] by andersca@apple.com
  • 2 edits in trunk/WebCore

Speculative Qt build fix.

  • platform/qt/QWebPopup.cpp:

(WebCore::QWebPopup::hidePopup):

3:38 PM Changeset in webkit [48371] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

Fix RenderThemeChromiumWin::determineClassicState so that classic_state
matches the state values (and you get a single classic_state value
for a given {part,state} value. This change will be tested by a
chromium patch that will land after this.

This will be tested by code landing downstream on Chromium.org; the
code does not execute on webkit.org.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineClassicState): (WebCore::RenderThemeChromiumWin::getThemeData):
3:14 PM Changeset in webkit [48370] by andersca@apple.com
  • 11 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=29138
Simplify popup menu handling.

Reviewed by Adam Roben.

  • platform/PopupMenuClient.h:

Rename hidePopup to popupDidHide.

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
Call popupDidHide instead of hidePopup.

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenu::menuUnmapped):
Ditto.

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::show):
Ditto.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::hide):
Call popupDidHide.

(WebCore::PopupWndProc):
Call PopupMenu::hide.

  • platform/wx/PopupMenuWx.cpp:

(WebCore::PopupMenu::OnMenuItemSelected):
Call popupDidHide.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::hidePopup):
(WebCore::RenderMenuList::popupDidHide):

  • rendering/RenderMenuList.h:

Set the "popup is visible" flag in popupDidHide.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::popupDidHide):

  • rendering/RenderTextControlSingleLine.h:

Ditto.

2:27 PM Changeset in webkit [48369] by andersca@apple.com
  • 2 edits in trunk/WebCore
  • Fix <rdar://problem/7182275>.

Reviewed by David Hyatt.

Make sure that the newly created scrollbar's style is up to date.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::~PopupMenu):
Call setParent so that the scrollbar's parts are torn down correctly.

(WebCore::PopupMenu::show):
Call styleChanged.

2:25 PM Changeset in webkit [48368] by jhoneycutt@apple.com
  • 6 edits
    2 adds in trunk

DRT/test part of
<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

WebKitTools:

  • DumpRenderTree/AccessibilityController.cpp:

(logScrollingStartEventsCallback):
Turn on logging of scrolling start events.
(AccessibilityController::getJSClass):
Add a "logScrollingStartEvents" to the AccessibilityController's JS
class definition.
(AccessibilityController::resetToConsistentState):
Turn off logging of scrolling start events.

  • DumpRenderTree/AccessibilityController.h:

Declare setLogScrollingStartEvents(). Add a member for the scrolling
start event hook.

  • DumpRenderTree/mac/AccessibilityControllerMac.cpp:

(AccessibilityController::setLogScrollingStartEvents):
Stubbed.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize the handle to 0.
(logEventProc):
Renamed from logFocusEventProc; now logs scrolling start events, too.
Removed the assertion that the event is a focus event. Added a switch
to print a message for focus, scrolling start, and other, unknown
events.
(AccessibilityController::setLogFocusEvents):
Changed to use logEventProc.
(AccessibilityController::setLogScrollingStartEvents):
If turning logging off, unhook the scrolling start event hook, and clear
the member holding the handle. If turning on, query for the root
accessible, so that accessibility is enabled for the WebView, and call
SetWinEventHook to setup an event hook using logEventProc as the
callback function.

LayoutTests:

  • platform/win/accessibility/scroll-to-anchor-expected.txt: Added.
  • platform/win/accessibility/scroll-to-anchor.html:

Added. Turns on scrolling start event logging, then jumps to an
anchor at the bottom of the page.

2:25 PM Changeset in webkit [48367] by jhoneycutt@apple.com
  • 10 edits in trunk/WebCore

<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):
Added declaration for handleScrolledToAnchor(). Added a new entry to
the enum of accessibility notifications.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
Code moved from AccessibilityRenderObject::internalLinkElement() and
refactored slightly; walks the tree until it finds a Node (with a
renderer) whose accessibility is not ignored.

  • accessibility/AccessibilityObject.h:

Added a declaration for firstAccessibleObjectFromNode().

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement):
Code moved to AccessibilityObject::firstAccessibleObjectFromNode().

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):
Add a default case that returns early for notifications that Mac
doesn't handle.
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
Post an AXScrolledToAnchor notification for the first accessible from
the anchor Node.
(WebCore::AXObjectCache::postPlatformNotification):
If the notification is AXFocusedUIElementChanged, fire an
EVENT_OBJECT_FOCUS. If the notification is AXScrolledToAnchor, fire
EVENT_SYSTEM_SCROLLINGSTART, matching Firefox.
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
Code moved to postPlatformNotification().

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):
Call AXObjectCache::handleScrolledToAnchor().

2:09 PM Changeset in webkit [48366] by rik@webkit.org
  • 2 edits in trunk/WebCore

Cookies are not inspectable after reloading a page
https://bugs.webkit.org/show_bug.cgi?id=29222

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-14
Reviewed by Timothy Hatcher.

Create the cookieTreeElement on initialization instead of when the view is shown.
Reset the selected element of the sidebar on reset.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel):
(WebInspector.StoragePanel.prototype.show):
(WebInspector.StoragePanel.prototype.reset):

2:07 PM CommitQueue edited by eric@webkit.org
(diff)
1:32 PM Changeset in webkit [48365] by beidson@apple.com
  • 3 edits in trunk/WebKitTools

Windows DRT build fix.

1:12 PM Changeset in webkit [48364] by beidson@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
(WebCore::WebCoreSynchronousLoader::load):

1:05 PM Changeset in webkit [48363] by beidson@apple.com
  • 32 edits
    16 adds in trunk

Safari 4 cannot be used to update firmware on Linksys routers.
<rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160

Reviewed by Alexey Proskuryakov.

WebCore:

In http://trac.webkit.org/changeset/42483, we disabled CFNetwork's session credential storage and
implemented our own in WebCore.

One feature we lost is that CFNetwork would automatically send previously authenticated credentials
with new connections when the paths match, as allowed by RFC 2617 for HTTP Basic and Digest Authentication.

Even though it's optional for User Agents to do this, (some?) Linksys routers rely on this behavior for
HTTP Basic Authentication. So now WebCore's CredentialStorage will track URL paths for Basic credentials.

We're not making this enhancement for Digest at this time, since we don't know of anything that broke
due to the change in Digest behavior.

Test: http/tests/loading/basic-credentials-sent-automatically.html

http/tests/loading/basic-auth-resend-wrong-credentials.html

  • WebCore.base.exp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/Credential.cpp:

(WebCore::Credential::isEmpty):

  • platform/network/Credential.h:

Add a slightly more full featured CredentialStore that will track URL paths a credential belongs to:

  • platform/network/CredentialStorage.cpp: Added.

(WebCore::protectionSpaceToCredentialMap):
(WebCore::originToDefaultCredentialMap):
(WebCore::originStringFromURL):
(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):
(WebCore::CredentialStorage::getDefaultAuthenticationCredential):

  • platform/network/CredentialStorage.h: Added.

Allow ProtectionSpace to be a hash key:

  • platform/network/ProtectionSpace.cpp:

(WebCore::ProtectionSpace::ProtectionSpace):

  • platform/network/ProtectionSpace.h:

(WebCore::ProtectionSpace::ProtectionSpace):
(WebCore::ProtectionSpace::isHashTableDeletedValue):

  • platform/network/ProtectionSpaceHash.h: Added.

(WebCore::ProtectionSpaceHash::hash):
(WebCore::ProtectionSpaceHash::equal):

Allow ResourceHandles to remember the initial credential they used:

  • platform/network/ResourceHandleInternal.h:

Allow mutable ResourceRequests to update their platform object if HTTP header fields change:

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):

Remove WebCoreCredentialStorage:

  • platform/network/cf/AuthenticationCF.cpp:
  • platform/network/cf/AuthenticationCF.h:
  • platform/network/mac/AuthenticationMac.h:
  • platform/network/mac/AuthenticationMac.mm:

Change ResourceHandleCFNet to try to use stored credentials on new connections, if appropriate:

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed

Credential if it does not match the initially used Credential.

(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge): Only try the ProtectionSpace key'ed

Credential if it does not match the initially used Credential.

(WebCore::WebCoreSynchronousLoader::load):

Change ResourceHandleMac to try to use stored credentials on new connections, if appropriate:

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed

Credential if it does not match the initially used Credential.

(WebCore::ResourceHandle::receivedCredential):
(-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Only try the

ProtectionSpace key'ed Credential if it does not match the initially used Credential.

(+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):

Add base64-ability to CString:

  • platform/text/CString.cpp:

(WebCore::CStringBuffer::base64Encode):
(WebCore::CString::base64Encode):

  • platform/text/CString.h:

(WebCore::CStringBuffer::create):
(WebCore::CStringBuffer::CStringBuffer):

WebKit/mac:

Adopt the new WebCore::CredentialStorage in WebKit/Mac.

  • Misc/WebDownload.mm:

(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):

  • Plugins/WebBaseNetscapePluginView.mm:

(WebKit::getAuthenticationInfo):

WebKit/win:

Adopt the new WebCore::CredentialStorage in WebKit/Win.

  • WebDownloadCFNet.cpp:

(WebDownload::didReceiveAuthenticationChallenge):

WebKitTools:

Add the ability for DRT to handle authentication challenges.

  • DumpRenderTree/LayoutTestController.cpp:

(setAuthenticationPasswordCallback):
(setAuthenticationUsernameCallback):
(setHandlesAuthenticationChallengesCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::handlesAuthenticationChallenges):
(LayoutTestController::setHandlesAuthenticationChallenges):
(LayoutTestController::authenticationUsername):
(LayoutTestController::setAuthenticationUsername):
(LayoutTestController::authenticationPassword):
(LayoutTestController::setAuthenticationPassword):

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::didReceiveAuthenticationChallenge):

  • DumpRenderTree/win/ResourceLoadDelegate.h:

LayoutTests:

  • http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
  • http/tests/loading/basic-auth-resend-wrong-credentials.html: Added.
  • http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
  • http/tests/loading/basic-credentials-sent-automatically.html: Added.
  • http/tests/loading/resources/basic-auth-testing.php: Added.
  • http/tests/loading/resources/othersubresources: Added.
  • http/tests/loading/resources/othersubresources/protected-resource.php: Added.
  • http/tests/loading/resources/protected-resource.php: Added.
  • http/tests/loading/resources/subresources: Added.
  • http/tests/loading/resources/subresources/protected-resource.php: Added.
  • http/tests/loading/resources/test2: Added.
  • http/tests/loading/resources/test2/basic-auth-testing.php: Added.
  • http/tests/loading/resources/test2/protected-resource.php: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
12:01 PM Changeset in webkit [48362] by kov@webkit.org
  • 4 edits in trunk/LayoutTests

2009-09-14 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Add some tests that fail to the skipped list and rebaseline two tests
to pass them.

  • platform/gtk/Skipped: Populate with more failing tests.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaseline.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Ditto.
11:10 AM Changeset in webkit [48361] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

Test for <rdar://problem/6954546> and <rdar://problem/7090444>.

Reviewed by Dan Bernstein.

WebKitTools:

Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(NPP_New):

LayoutTests:

  • plugins/destroy-during-npp-new-expected.txt: Added.
  • plugins/destroy-during-npp-new.html: Added.
11:10 AM Changeset in webkit [48360] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix <rdar://problem/7090444> Crashes in-[WebBaseNetscapePluginView stop] handling NSWindowWillCloseNotification.

Reviewed by Anders Carlsson.

It's not valid to call -addWindowObservers when the view is not in a window, but this can happen when -start
initializes a plug-in and the plug-in removes itself from the document during initialization. -viewDidMoveToWindow
calls -start and then calls -addWindowObservers without ensuring that the view is still in a window.

If -[WebBaseNetscapePluginView addWindowObservers] is incorrectly called when the view is not in a window, it will
observe NSWindowWillCloseNotification on all windows. This unexpected observer registration is not balanced by an
unregistration so the notification can be delivered after the view is deallocated, causing the crash seen in
<rdar://problem/7090444>.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView start]): Only call -updateAndSetWindow if we still have a current window.
(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Remove unnecessary calls to -restartTimers and -addWindowObservers
from -[WebBaseNetscapePluginView viewDidMoveToWindow]. They are already called from within -start with the extra benefit
of ensuring that the view is still in a window when they are called.

11:10 AM Changeset in webkit [48359] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below FrameLoader::loadPlugin.

Reviewed by Dan Bernstein.

The calls to FrameLoader::requestObject within RenderPartObject::updateWidget can result in a plug-in
being initialized. This can run cause arbitrary JavaScript to run and may result in the RenderPartObject
being detached from the render tree and destroyed, causing a crash like <rdar://problem/6954546>.

No test is possible until <rdar://problem/7090444> is fixed

  • rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::updateWidget): Ensure that we stay alive for the duration of plug-in initialization.

11:10 AM Changeset in webkit [48358] by mrowe@apple.com
  • 3 edits
    1 add in trunk/WebCore

Add RenderWidgetProtector to simplify protecting a RenderWidget from destruction for the duration of a function. Deploy it within RenderWidget.

Reviewed by Dan Bernstein.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition): Use a RefPtr rather than explicitly
ref'ing and deref'ing the node.

  • rendering/RenderWidget.h:
  • rendering/RenderWidgetProtector.h:

(WebCore::RenderWidgetProtector::RenderWidgetProtector):
(WebCore::RenderWidgetProtector::~RenderWidgetProtector):

10:26 AM Changeset in webkit [48357] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-09-14 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] QWebGraphicsItem should check for null QWebPage.
https://bugs.webkit.org/show_bug.cgi?id=29185

Don't crash in QWebGraphicsItem when the page is still null, by
either checking if it's the case or constructing the default one.

  • Api/qwebgraphicsitem.cpp: (QWebGraphicsItem::icon): (QWebGraphicsItem::setZoomFactor): (QWebGraphicsItem::zoomFactor): (QWebGraphicsItem::setGeometry): (QWebGraphicsItem::load): (QWebGraphicsItem::setHtml): (QWebGraphicsItem::toHtml): (QWebGraphicsItem::setContent): (QWebGraphicsItem::history): (QWebGraphicsItem::settings):
10:19 AM Changeset in webkit [48356] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-14 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

CodeGenerator.pm needs some cleaning up
https://bugs.webkit.org/show_bug.cgi?id=29238

  • bindings/scripts/CodeGenerator.pm: (FindParentsRecursively): Removed; its functionality is now handled in AddMethodsConstantsAndAttributesFromParentClasses. (ForAllParents): New function that visits an interface's ancestors and invokes a callback for each one. (AddMethodsConstantsAndAttributesFromParentClasses): Simplified by using ForAllParents. (GetMethodsAndAttributesFromParentClasses): Ditto. (IDLFileForInterface): Factored out previous calls to ScanDirectory into this new function, which returns the filename containing a given IDL interface definition. (ParseInterface): Simplified by using IDLFileForInterface. (ScanDirectory): Removed in lieu of IDLFileForInterface.
  • bindings/scripts/CodeGeneratorV8.pm: Drop call to FindParentsRecursively and get the list of parents from the AddMethodsConstantsAndAttributesFromParentClasses call instead.
10:06 AM Changeset in webkit [48355] by kevino@webkit.org
  • 3 edits in trunk/WebKitTools

wx build fix for non-wxPython builds and a fix for errors when updating swig.py.

7:46 AM Changeset in webkit [48354] by yael.aharon@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Assert hit when dropping a file in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=29242

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-14
Reviewed by Tor Arne Vestbø.

Qt's implementation of DropData::asURL does not return a URL encoded string
as expected.

  • platform/qt/DragDataQt.cpp:
5:45 AM Changeset in webkit [48353] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Build fix for windows build.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-14
Reviewed by Tor Arne Vestbø.

JavaScriptCore

  • JavaScriptCore.pri: Correct a logic error.
  • pcre/dftables: Add missing paranthesis for tmpdir function.

WebKitTools:

  • Scripts/bisect-builds: Add missing paranthesis for tmpdir function.

Sep 13, 2009:

10:47 PM Changeset in webkit [48352] by kevino@webkit.org
  • 1 edit
    1 add in trunk/WebCore

wx build fix, file was missed during TLS.cpp removal.

7:29 PM Changeset in webkit [48351] by rik@webkit.org
  • 2 edits in trunk/WebCore

Web Inspector: Add "New Style Rule" to the localizedStrings
https://bugs.webkit.org/show_bug.cgi?id=29237

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-13
Reviewed by Oliver Hunt.

  • English.lproj/localizedStrings.js:
7:03 PM Changeset in webkit [48350] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Fix typo accidently landed in last commit.

6:52 PM Changeset in webkit [48349] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix, error out if using the wrong Python.

6:32 PM Changeset in webkit [48348] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Allow a way to set the cache policy via wx API.

https://bugs.webkit.org/show_bug.cgi?id=29200

6:20 PM Changeset in webkit [48347] by kevino@webkit.org
  • 5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Allow the user to query Frame::shouldClose via wx API.

https://bugs.webkit.org/show_bug.cgi?id=29199

6:12 PM Changeset in webkit [48346] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Fix mouse handling when the mouse leaves the window during mouse down.

https://bugs.webkit.org/show_bug.cgi?id=29198

6:04 PM Changeset in webkit [48345] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add support for console MessageLevel at wx API level.

https://bugs.webkit.org/show_bug.cgi?id=29197

5:34 PM Changeset in webkit [48344] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Implement filesystem functions.

https://bugs.webkit.org/show_bug.cgi?id=29196

3:45 AM Changeset in webkit [48343] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-13 Xan Lopez <xlopez@igalia.com>

Build fix for GTK+ < 2.14.

Do not use gtk_widget_get_window, access the window directly
through the struct.

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback):
3:23 AM Changeset in webkit [48342] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-13 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez and Jan Alonzo.

[GTK] EventSender does not set 'window' property on synthesized GDK events
https://bugs.webkit.org/show_bug.cgi?id=29169

Set the window property on synthesized GDK events in the GTK+ EventSender.

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback):
12:14 AM Changeset in webkit [48341] by kevino@webkit.org
  • 3 edits in trunk/WebCore

wx build fixes for wx 2.9.

Note: See TracTimeline for information about the timeline view.