⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 16, 2009:

11:45 PM Changeset in webkit [48458] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2009-09-16 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=29306

Tests that scripts with accented characters do not bypass the XSSAuditor.

  • http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt: Added.
  • http/tests/security/xssAuditor/img-onerror-accented-char.html: Added.

2009-09-16 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=29306

Fixes an issue where an attack that contains accented characters can
bypass the XSSAuditor.

XSSAuditor::decodeURL used the wrong length for the input string.
When the input string was decoded, the decoded result was truncated.
Hence, XSSAuditor was comparing the source code of the script to the
truncated input parameters.

Test: http/tests/security/xssAuditor/img-onerror-accented-char.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeURL):
11:42 PM Changeset in webkit [48457] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2009-09-16 Adam Barth <​abarth@webkit.org>

Unreviewed. Added new isolated world test to the skipped list.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
11:36 PM Changeset in webkit [48456] by beidson@apple.com
  • 2 edits in trunk/WebCore

Explore allowing pages with unload handlers into the Page Cache
​https://bugs.webkit.org/show_bug.cgi?id=29021

Reviewed by Sam Weinig.

No new tests. (All previous tests continue to pass)

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): If the document is in the page cache, don't fire the unload event.

11:25 PM Changeset in webkit [48455] by abarth@webkit.org
  • 6 edits
    4 adds in trunk

2009-09-16 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
​https://bugs.webkit.org/show_bug.cgi?id=27703

We now save a handle to the original context. We use that handle to
call the timeout in the right context / world.

Tests: http/tests/security/isolatedWorld/window-setTimeout-function.html

http/tests/security/isolatedWorld/window-setTimeout-string.html

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):

2009-09-16 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
​https://bugs.webkit.org/show_bug.cgi?id=27703

Add test coverage for the interaction between setTimeout and isolated
worlds.

  • http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Added.
  • http/tests/security/isolatedWorld/window-setTimeout-function.html: Added.
  • http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Added.
  • http/tests/security/isolatedWorld/window-setTimeout-string.html: Added.
9:39 PM Changeset in webkit [48454] by weinig@apple.com
  • 2 edits in trunk/WebCore

Add some groups to the xcode project to make the bindings/js/ group
a little nicer.

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
8:42 PM Changeset in webkit [48453] by weinig@apple.com
  • 20 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=29320
JS callback objects should store the global object

Reviewed by Anders Carlsson.

This just changes the callback objects to store the global object instead
of the frame. A follow up patch will change them to store the 'current'
global object instead of the lexical or dynamic.

  • DerivedSources.make: Remove unused VoidCallback.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSCustomPositionCallback.cpp:

(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):

  • bindings/js/JSCustomPositionCallback.h:

(WebCore::JSCustomPositionCallback::create):

  • bindings/js/JSCustomPositionErrorCallback.cpp:

(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):

  • bindings/js/JSCustomPositionErrorCallback.h:

(WebCore::JSCustomPositionErrorCallback::create):

  • bindings/js/JSCustomSQLStatementCallback.cpp:

(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementCallback.h:

(WebCore::JSCustomSQLStatementCallback::create):

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementErrorCallback.h:

(WebCore::JSCustomSQLStatementErrorCallback::create):

  • bindings/js/JSCustomSQLTransactionCallback.cpp:

(WebCore::JSCustomSQLTransactionCallback::Data::Data):
(WebCore::JSCustomSQLTransactionCallback::Data::globalObject):
(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionCallback.h:

(WebCore::JSCustomSQLTransactionCallback::create):

  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:

(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionErrorCallback.h:

(WebCore::JSCustomSQLTransactionErrorCallback::create):

  • bindings/js/JSCustomVoidCallback.cpp:

(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):

  • bindings/js/JSCustomVoidCallback.h:

(WebCore::JSCustomVoidCallback::create):

  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::createPositionCallback):
(WebCore::createPositionErrorCallback):
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

8:40 PM Changeset in webkit [48452] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Split the SnowLeopard build across a few machines.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
7:57 PM Changeset in webkit [48451] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wxPython bindings build fixes after recent changes.

7:33 PM Changeset in webkit [48450] by brettw@chromium.org
  • 5 edits in trunk/WebCore

Revert "2009-09-16 Albert J. Wong <​ajwong@chromium.org>"
This change did not compile.

7:13 PM Changeset in webkit [48449] by eric@webkit.org
  • 15 edits
    2 adds
    12 deletes in trunk

2009-09-15 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

<input maxlength=> should restrict only values specified by users.
​https://bugs.webkit.org/show_bug.cgi?id=21271

  • fast/forms/input-appearance-maxlength-expected.txt:
  • fast/forms/input-appearance-maxlength.html:
  • fast/forms/input-maxlength-expected.txt:
  • fast/forms/input-maxlength.html:
  • fast/forms/input-text-maxlength-expected.txt: Added.
  • fast/forms/input-text-maxlength.html:
  • fast/forms/input-text-paste-maxlength-expected.txt: Added.
  • fast/forms/input-text-paste-maxlength.html:
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum: Removed.
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.png: Removed.
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum: Removed.
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png: Removed.
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
  • platform/mac/fast/forms/input-text-maxlength-expected.txt: Removed.
  • platform/mac/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
  • platform/qt/fast/forms/input-text-maxlength-expected.txt: Removed.
  • platform/qt/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
  • platform/win/fast/forms/input-text-maxlength-expected.txt: Removed.
  • platform/win/fast/forms/input-text-paste-maxlength-expected.txt: Removed.

2009-09-15 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

<input maxlength=> should restrict only values specified by users.
​https://bugs.webkit.org/show_bug.cgi?id=21271

  • dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): (WebCore::InputElement::sanitizeValue): (WebCore::InputElement::sanitizeUserInputValue): Rename from constrainValue(). (WebCore::InputElement::handleBeforeTextInsertedEvent): (WebCore::InputElement::updateValueIfNeeded):
  • dom/InputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::sanitizeValue):
  • html/HTMLInputElement.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::constrainValue):
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::sanitizeValue):
6:58 PM Changeset in webkit [48448] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-09-16 Enrica Casucci <​enrica@apple.com>

Reviewed by Eric Seidel.

Reorganizing helper functions in htmlediting.h to group them by type of object they return/operate upon.
​https://bugs.webkit.org/show_bug.cgi?id=29319

  • editing/IndentOutdentCommand.cpp: Removed implementation of isAtUnsplittableElement.
  • editing/IndentOutdentCommand.h: Removed member function isAtUnsplittableElement, because it was not class specific and belonged logically among the helper functions.
  • editing/htmlediting.cpp: (WebCore::isAtUnsplittableElement): added. The code was taken from IndentOutdentCommand.
  • editing/htmlediting.h: Reordered functions to group them by type of object returned or operate upon. Added comments. Added isAtUnsplittableElement declaration.
5:00 PM CommitQueue edited by eric@webkit.org
(diff)
4:27 PM Changeset in webkit [48447] by ggaren@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Removed some vestigial and potentially crashy code that makes consolidating
event listeners hard.

Patch by Geoffrey Garen <​ggaren@apple.com> on 2009-09-16
Reviewed by Sam Weinig and Anders Carlsson.

  • dom/Node.cpp:

(WebCore::Node::addEventListener): No need to limit when event listeners
can be added. Other EventTargets don't do this.

Also, check for null when accessing document(). Technically, the JS bindings
do this check for us, but let's not rely on that.

LayoutTests: Added a test for a potential crash when adding an event listener to a
doctype node.

Patch by Geoffrey Garen <​ggaren@apple.com> on 2009-09-16
Reviewed by Sam Weinig.

  • fast/dom/doctype-event-listener-crash-expected.txt: Added.
  • fast/dom/doctype-event-listener-crash.html: Added.
4:25 PM Changeset in webkit [48446] by andersca@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/7155710>
HTML selects on windows cause containing window to become inactive when opened

Reviewed by Adam Roben.

Redo the way we handle events when a popup menu is shown, based on
​http://blogs.msdn.com/oldnewthing/archive/2004/08/20/217684.aspx

Since a non-active window can't capture the mouse, we use the owning window
(the WebView) as the capture window. We then run a recursive message pump that
forwards all mouse and keyboard events to the popup menu.

  • platform/PopupMenu.h:
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::wndProc):

4:23 PM Changeset in webkit [48445] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-09-16 Gabor Loki <​loki@inf.u-szeged.hu>

Reviewed by Darin Adler.

Fix GCC warnings on ARM_THUMB2 platform

  • assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::countLeadingZerosPartial):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::branchTruncateDoubleToInt32): (JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
4:14 PM Changeset in webkit [48444] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-09-16 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Eric Seidel.

Detect and add Windows7 properly to the user agent.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
4:06 PM Changeset in webkit [48443] by mitz@apple.com
  • 2 edits in trunk/WebCore

Speculative fix for
<rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Ada Chan.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::destroy): Avoid calling renderArena() if node()
is null. Add two assertions that can help determine how this crash
happens (in particular, whether node() becomes null during destroy() or
it is null before destroy() is called).

3:17 PM Changeset in webkit [48442] by Beth Dakin
  • 2 edits in trunk/WebCore

Speculative build fix.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

3:08 PM Changeset in webkit [48441] by Beth Dakin
  • 16 edits
    7 adds in trunk

WebCore: Fix for <rdar://problem/7083741> Implement a CSS extension to
adjust sub-pixel anti-aliasing for text
-and corresponding-
​https://bugs.webkit.org/show_bug.cgi?id=29291

Reviewed by Darin Adler.

Added tests:

  • fast/css/font-smoothing.html: Added.
  • fast/css/parsing-webkit-font-smoothing.html: Added.

This patch adds a new CSS property called -webkit-font-smoothing
that accepts the following as valid input: auto | none |
antialiased | subpixel-antialiased

Return appropriate computed style for -webkit-font-smoothing

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Add a case for CSSPropertyWebkitFontSmoothing, and accept valid
input.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

Add mappings for FontSmoothing to the right CSS values.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontSmoothing):

Add -webkit-font-smoothing

  • css/CSSPropertyNames.in:

Set fontSmoothing on the FontDescription.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Add antialiased and subpixel-antialiased as possible new CSS
values.

  • css/CSSValueKeywords.in:

Store the font smoothing CSS value in the FontDescription.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::fontSmoothing):
(WebCore::FontDescription::setFontSmoothing):
(WebCore::FontDescription::operator==):

Call setShouldAntialias() and setShouldUseSmoothing() appropriately
based on the CSS fontSmoothing() value.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

  • platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs):

New function fontSmoothing()

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::fontSmoothing):

New enum FontSmoothing.

  • rendering/style/RenderStyleConstants.h:

(WebCore::):

LayoutTests: Tests for <rdar://problem/7083741> Implement a CSS extension to
adjust sub-pixel anti-aliasing for text

Reviewed by Darin Adler.

New tests:

  • fast/css/font-smoothing.html: Added.
  • fast/css/parsing-webkit-font-smoothing-expected.txt: Added.
  • fast/css/parsing-webkit-font-smoothing.html: Added.
  • fast/css/resources/parsing-webkit-font-smoothing.js: Added.

(test):

  • platform/mac/fast/css/font-smoothing-expected.checksum: Added.
  • platform/mac/fast/css/font-smoothing-expected.png: Added.
  • platform/mac/fast/css/font-smoothing-expected.txt: Added.

These tests have updated results now that -webkit-font-smoothing is
reported with computed style.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:52 PM Changeset in webkit [48440] by Adam Roben
  • 3 edits in trunk/WebKit/win

Add a UI delegate callback to let the delegate draw a WebView's background

Fixes <​http://webkit.org/b/29315>.

Reviewed by Dave Hyatt.

  • Interfaces/IWebUIDelegatePrivate.idl: Added

IWebUIDelegatePrivate2::drawBackground.

  • WebView.cpp:

(WebView::paintIntoBackingStore): After clearing or filling with
white, let the delegate draw whatever background it wants. Also added
an assertion that the dirty rect is within our bounds.

2:47 PM Changeset in webkit [48439] by Adam Roben
  • 2 edits in trunk/WebKit/win

Prevent WebView from painting over sibling windows

Fixes <​http://webkit.org/b/29300> <rdar://problem/7227960> WebView can
paint over sibling windows

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::initWithFrame): Create the WebView's HWND with the
WS_CLIPSIBLINGS style.

2:46 PM Changeset in webkit [48438] by ajwong@chromium.org
  • 5 edits in trunk/WebCore

2009-09-16 Albert J. Wong <​ajwong@chromium.org>

Reviewed by David Levin.

Reimplement default media UI for Mac Chromium to match the style
of the Windows and Linux versions. Also breaks the dependency
on the internal wk* functions that were previously used to
render the media controller widgets.
​https://bugs.webkit.org/show_bug.cgi?id=29161

No media layout tests are currently enabled in Mac Chromium, so
nothing needs rebaselineing, etc.

  • css/mediaControlsChromium.css:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet): (WebCore::mediaSliderThumbImage): (WebCore::mediaVolumeSliderThumbImage): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
2:38 PM Changeset in webkit [48437] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

Remove style property if empty string is entered.

​https://bugs.webkit.org/show_bug.cgi?id=29163

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmouseout): fixed null pointer exception
  • inspector/front-end/InjectedScript.js: (InjectedScript.applyStyleText): if styletext to apply is empty it will return an array to confirm the property removal
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
2:31 PM Changeset in webkit [48436] by eric@webkit.org
  • 3 edits
    5 adds in trunk

2009-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

Added a test that checks that margin property shorthand has correct value
when there is background-repeat property in the style declaration.

​https://bugs.webkit.org/show_bug.cgi?id=28973

  • fast/backgrounds/repeat/margin-shorthand-expected.txt: Added.
  • fast/backgrounds/repeat/margin-shorthand.html: Added.
  • fast/backgrounds/repeat/resources/TEMPLATE.html: Added.
  • fast/backgrounds/repeat/resources/margin-shorthand.css: Added.
  • fast/backgrounds/repeat/resources/margin-shorthand.js: Added. (iconMarginValue):

2009-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

Always reset m_implicitShorthand to false after parsing
background-repeat style property otherwise properties
following after it may be erroneously marked as implicit.

​https://bugs.webkit.org/show_bug.cgi?id=28972
​https://bugs.webkit.org/show_bug.cgi?id=28973

Test: fast/backgrounds/repeat/margin-shorthand.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
2:05 PM Changeset in webkit [48435] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-09-16 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.

Work around a bug in AppKit on Leopard which causes compositing layers to jitter, and
become misplaced when the WebHTMLView is resized or scrolled sometimes.
<rdar://problem/7071636>

We call an internal AppKit method to make sure the layer geometry is updated correctly.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):
1:40 PM Changeset in webkit [48434] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix to support monolithic builds on Windows.

1:36 PM Changeset in webkit [48433] by eric@webkit.org
  • 3 edits
    4 adds
    4 deletes in trunk

2009-09-16 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Alexey Proskuryakov.

Incorrect behavior of XMLHttpRequest::getAllResponseHeaders and XMLHttpRequest::getResponseHeader in the
HEADERS_RECEIVED readyState.
​https://bugs.webkit.org/show_bug.cgi?id=29121

  • http/tests/xmlhttprequest/getAllResponseHeaders-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt.
  • http/tests/xmlhttprequest/getAllResponseHeaders.html: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html.
  • http/tests/xmlhttprequest/getResponseHeader-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt.
  • http/tests/xmlhttprequest/getResponseHeader.html: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt: Removed.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html: Removed.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt: Removed.
  • http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html: Removed. Modified xmlhttprequest-InvalidStateException-getAllRequestHeaders and xmlhttprequest-InvalidStateException-getRequestHeader to match the current spec and code behavior. Extended the first test to cover other aspects of the getAllResponseHeaders method and planning the same extension for the second test. The extension for the second test is to be submitted with the patch for bug 29140. Renamed the 2 tests to a shorter more accurate name, given their new intended scope.

2009-09-16 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Alexey Proskuryakov.

Incorrect behavior of XMLHttpRequest::getAllResponseHeaders and
XMLHttpRequest::getResponseHeader in the
HEADERS_RECEIVED readyState.
​https://bugs.webkit.org/show_bug.cgi?id=29121

Tests: http/tests/xmlhttprequest/getAllResponseHeaders.html

http/tests/xmlhttprequest/getResponseHeader.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): Changed the minimum valid state from LOADING to HEADERS_RECEIVED.
1:23 PM Changeset in webkit [48432] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-16 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix style violation in V8AbstractEventListener.
​https://bugs.webkit.org/show_bug.cgi?id=29303

  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::operator==):
1:16 PM Changeset in webkit [48431] by eric@webkit.org
  • 10 edits
    2 adds in trunk/WebCore

2009-09-16 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Add Watch Expression support to inspector
​https://bugs.webkit.org/show_bug.cgi?id=27514

Manual test added.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update.callback): (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertiesSection.CompareProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  • inspector/front-end/WatchExpressionsSidebarPane.js: Added. (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.addExpression): (WebInspector.WatchExpressionsSection.prototype.updateExpression): (WebInspector.WatchExpressionsSection.prototype.findAddedTreeElement): (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions): (WebInspector.WatchExpressionsSection.prototype.saveExpressions): (WebInspector.WatchExpressionsSection.CompareProperties): (WebInspector.WatchExpressionTreeElement): (WebInspector.WatchExpressionTreeElement.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype._deleteButtonClicked): (WebInspector.WatchExpressionTreeElement.prototype.startEditing): (WebInspector.WatchExpressionTreeElement.prototype.editingCancelled): (WebInspector.WatchExpressionTreeElement.prototype.applyExpression):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • manual-tests/inspector/debugger-watch-expressions.html: Added.
12:50 PM Changeset in webkit [48430] by bolsinga@apple.com
  • 46 edits
    1 add in trunk

Add ENABLE(INSPECTOR)
​https://bugs.webkit.org/show_bug.cgi?id=29260

Reviewed by David Kilzer.

JavaScriptCore:

  • wtf/Platform.h:

WebCore:

No new tests. (No change in default behavior.)

  • DerivedSources.make: Use new WebCore.Inspector.exp file if ENABLE_DRAG_SUPPORT.
  • WebCore.base.exp: Move Inspector only exports to WebCore.Inspector.exp.
  • WebCore.xcodeproj/project.pbxproj: Add WebCore.Inspector.exp.
  • bindings/js/JSDOMWindowBase.cpp: Use ENABLE(INSPECTOR) where applicable.

(WebCore::JSDOMWindowBase::supportsProfiling):

  • bindings/js/JSInspectedObjectWrapper.cpp: Wrap entire file in ENABLE(INSPECTOR).
  • bindings/js/JSInspectorBackendCustom.cpp: Ditto.
  • bindings/js/JSInspectorCallbackWrapper.cpp: Ditto.
  • bindings/js/ScriptObject.cpp: Use ENABLE(INSPECTOR) where applicable.
  • bindings/js/ScriptObject.h: Ditto.
  • bindings/js/ScriptObjectQuarantine.cpp: Wrap entire file in ENABLE(INSPECTOR).
  • dom/Document.cpp: Use ENABLE(INSPECTOR) where applicable.

(WebCore::Document::recalcStyle):
(WebCore::Document::addMessage):
(WebCore::Document::resourceRetrievedByXMLHttpRequest):
(WebCore::Document::scriptImported):

  • dom/Document.h: Ditto.
  • dom/Node.cpp: Ditto.

(WebCore::Node::dispatchGenericEvent):

  • dom/ScriptExecutionContext.h: Ditto.

(WebCore::):

  • html/HTMLDocument.cpp: Ditto.

(WebCore::HTMLDocument::createTokenizer):

  • html/HTMLTokenizer.cpp: Ditto.

(WebCore::HTMLTokenizer::write):

  • inspector/ConsoleMessage.cpp: Ditto.

(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::isEqual):

  • inspector/ConsoleMessage.h: Ditto.
  • inspector/DOMDispatchTimelineItem.cpp: Wrap entire file in ENABLE(INSPECTOR).
  • inspector/InspectorBackend.cpp: Ditto.
  • inspector/InspectorController.cpp: Ditto.
  • inspector/InspectorDOMAgent.cpp: Ditto.
  • inspector/InspectorDOMStorageResource.cpp: Ditto.
  • inspector/InspectorDatabaseResource.cpp: Ditto.
  • inspector/InspectorFrontend.cpp: Ditto.
  • inspector/InspectorResource.cpp: Ditto.
  • inspector/InspectorTimelineAgent.cpp: Ditto.
  • inspector/TimelineItem.cpp: Ditto.
  • loader/FrameLoader.cpp: Use ENABLE(INSPECTOR) where applicable.

(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
(WebCore::FrameLoader::dispatchWindowObjectAvailable):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
(WebCore::FrameLoader::dispatchWillSendRequest):
(WebCore::FrameLoader::dispatchDidReceiveResponse):
(WebCore::FrameLoader::dispatchDidReceiveContentLength):
(WebCore::FrameLoader::dispatchDidFinishLoading):

  • page/Chrome.cpp: Ditto.

(WebCore::Chrome::mouseDidMoveOverElement):

  • page/Console.cpp: Ditto.

(WebCore::Console::addMessage):
(WebCore::Console::count):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupEnd):

  • page/ContextMenuController.cpp: Ditto.

(WebCore::ContextMenuController::handleContextMenuEvent):
(WebCore::ContextMenuController::contextMenuItemSelected):

  • page/DOMWindow.cpp: Ditto.

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

  • page/EventHandler.cpp: Ditto.

(WebCore::EventHandler::handleMousePressEvent):

  • page/FrameView.cpp: Ditto.

(WebCore::FrameView::layout):
(WebCore::FrameView::paintContents):

  • page/FrameView.h: Ditto.
  • page/Page.cpp: Ditto.

(WebCore::Page::Page):
(WebCore::Page::~Page):

  • page/Page.h: Ditto.
  • platform/ContextMenu.cpp: Ditto.

(WebCore::ContextMenu::checkOrEnableIfNeeded):

  • platform/ContextMenuItem.h: Ditto.

(WebCore::):

  • storage/Database.cpp: Ditto.

(WebCore::Database::openDatabase):

  • workers/WorkerContext.cpp: Ditto.

(WebCore::WorkerContext::importScripts):

  • xml/XMLHttpRequest.cpp: Ditto.

(WebCore::XMLHttpRequest::didFinishLoading):

12:40 PM Changeset in webkit [48429] by bolsinga@apple.com
  • 21 edits
    1 add in trunk

Add ENABLE(CONTEXT_MENUS)
​https://bugs.webkit.org/show_bug.cgi?id=29225

Reviewed by David Kilzer.

JavaScriptCore:

  • wtf/Platform.h:

WebCore:

No new tests. (No change in default behavior.)

  • DerivedSources.make: Use new WebCore.ContextMenus.exp file if ENABLE_CONTEXT_MENUS.
  • WebCore.base.exp: Move ContextMenu only exports to WebCore.ContextMenus.exp.
  • WebCore.xcodeproj/project.pbxproj: Add WebCore.ContextMenus.exp.
  • dom/Node.cpp: Use ENABLE(CONTEXT_MENUS) where applicable.

(WebCore::Node::defaultEventHandler):

  • loader/EmptyClients.h: Ditto.
  • page/ContextMenuController.cpp: Wrap entire file in ENABLE(CONTEXT_MENUS).
  • page/EventHandler.cpp: Use ENABLE(CONTEXT_MENUS) where applicable.
  • page/EventHandler.h: Ditto.
  • page/Page.cpp: Ditto.

(WebCore::Page::Page):

  • page/Page.h: Ditto.
  • page/mac/EventHandlerMac.mm: Ditto.
  • page/mac/WebCoreViewFactory.h: Ditto.
  • platform/ContextMenu.cpp: Wrap entire file in ENABLE(CONTEXT_MENUS).
  • platform/LocalizedStrings.h: Use ENABLE(CONTEXT_MENUS) where applicable.
  • platform/mac/ContextMenuItemMac.mm: Wrap entire file in ENABLE(CONTEXT_MENUS).
  • platform/mac/ContextMenuMac.mm: Ditto.
  • platform/mac/LocalizedStringsMac.mm: Use ENABLE(CONTEXT_MENUS) where applicable.
  • svg/graphics/SVGImage.cpp: Ditto.

(WebCore::SVGImage::dataChanged):

12:37 PM Changeset in webkit [48428] by hyatt@apple.com
  • 4 edits in trunk/WebCore

Clean up invalidation for repainting. Hoist the dirty rect intersection test in ScrollViewMac up
into ScrollView so that all platforms do it.

Reviewed by Adam Roben.

Patch deferred repaints in FrameView::repaintContentRectangle to only add the visible portion of
the rectangle for repainting.

  • page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::repaintContentRectangle):

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformRepaintContentRectangle):

12:29 PM Changeset in webkit [48427] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-09-16 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Eric Seidel.

The webkit stdint and stdbool headers exists because
the compiler MSVC doesn't include them. The check
should not check for PLATFORM(WIN_OS) but for MSVC.

  • os-win32/stdbool.h:
  • os-win32/stdint.h:
12:10 PM Changeset in webkit [48426] by bolsinga@apple.com
  • 25 edits
    1 add in trunk

Add ENABLE(DRAG_SUPPORT)
​https://bugs.webkit.org/show_bug.cgi?id=29233

Reviewed by David Kilzer.

JavaScriptCore:

  • wtf/Platform.h:

WebCore:

No new tests. (No change in default behavior.)

  • DerivedSources.make: Use new WebCore.DragSupport.exp file if ENABLE_DRAG_SUPPORT.
  • WebCore.base.exp: Move Drag Support only exports to WebCore.DragSupport.exp.
  • WebCore.xcodeproj/project.pbxproj: Add WebCore.DragSupport.exp.
  • dom/Clipboard.h: Use ENABLE(DRAG_SUPPORT) where applicable.
  • loader/EmptyClients.h: Ditto.
  • page/DragController.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
  • page/EventHandler.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseMoveEvent):

  • page/EventHandler.h: Ditto.
  • page/Page.cpp: Ditto.

(WebCore::Page::Page):

  • page/Page.h: Ditto.
  • page/mac/DragControllerMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
  • page/mac/EventHandlerMac.mm: Use ENABLE(DRAG_SUPPORT) where applicable.

(WebCore::EventHandler::passSubframeEventToSubframe):

  • platform/DragData.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
  • platform/DragImage.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
  • platform/mac/ClipboardMac.h: Use ENABLE(DRAG_SUPPORT) where applicable.
  • platform/mac/ClipboardMac.mm: Ditto.
  • platform/mac/DragDataMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
  • platform/mac/DragImageMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
  • rendering/RenderLayer.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.

(WebCore::RenderLayer::autoscroll):

  • rendering/RenderObject.cpp: Ditto.
  • rendering/RenderObject.h: Ditto.
  • svg/graphics/SVGImage.cpp: Ditto.

(WebCore::SVGImage::dataChanged):

12:02 PM Changeset in webkit [48425] by kevino@webkit.org
  • 3 edits in trunk/WebCore

wxMSW build fix after adding support for high resolution times in Win.

10:55 AM Changeset in webkit [48424] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

waf build fix after flag was moved to correct place.

10:25 AM Changeset in webkit [48423] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Rubberstamped by Kenneth Christiansen.

Patch by Andras Becsi <​andrewbecsi@yahoo.co.uk> on 2009-09-16
[Qt] Build fix for previous changes.

  • QGVLauncher/main.cpp:

(MainView::flip):

9:59 AM Changeset in webkit [48422] by kevino@webkit.org
  • 3 edits in trunk/WebKitTools

wx build fix, improve debug support and 2.9 support on MSW.

9:11 AM Changeset in webkit [48421] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Unreviewed potential Qt < 4.6 build fix.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-16

  • QGVLauncher/main.cpp:

(MainView::flip):

8:55 AM Changeset in webkit [48420] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-16 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Blind try at fixing new test failure on Windows.

  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didReceiveTitle):
8:20 AM Changeset in webkit [48419] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-09-16 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

One more try at rebaselining the tests for those who dump frame
loader delegates.

  • http/tests/loading/redirect-with-no-location-crash-expected.txt:
7:29 AM Changeset in webkit [48418] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-09-16 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Added operator==() to event listeners. This fixes V8 bindings
build broken in ​http://trac.webkit.org/changeset/48402.
​https://bugs.webkit.org/show_bug.cgi?id=29298

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Now uses JSEventListenerType.
  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::operator==): Only compares pointers since we create at most one wrapper for a JS object.
7:29 AM Changeset in webkit [48417] by kov@webkit.org
  • 2 edits
    1 copy
    3 adds in trunk/LayoutTests

2009-09-16 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline for those who support dumping of frame
loader delegates, add specific expected result to GTK+

  • http/tests/loading/redirect-with-no-location-crash-expected.txt:
  • platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Copied from LayoutTests/http/tests/loading/redirect-with-no-location-crash-expected.txt.
6:49 AM Changeset in webkit [48416] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Add a "Flip effect" to our GraphicsView based launcher.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-16
Reviewed by Simon Hausmann.

  • QGVLauncher/main.cpp:

(MainView::resizeEvent):
(MainView::flip):
(MainWindow::flip):
(MainWindow::buildUI):

6:46 AM Changeset in webkit [48415] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for 64-bit Qt on Mac OS X

Reviewed by Simon Hausmann.

  • wtf/Platform.h: Use JSVALUE64 on DARWIN, not only on MAC
6:40 AM Changeset in webkit [48414] by zoltan@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-09-16 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Rubber-stamped by Simon Hausmann.

[Qt] Typo fix. Pass the window object to the Format
menu. In this way Qt can free its internal graphical
objects during exit.

  • QtLauncher/main.cpp: (MainWindow::setupUI):
6:37 AM Changeset in webkit [48413] by kov@webkit.org
  • 3 edits
    3 adds in trunk

WebCore:

2009-09-16 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crash when visiting ​http://flipper.googlelabs.com/
​https://bugs.webkit.org/show_bug.cgi?id=29293

Check type for being null or empty before looking it up in the
hash of supported types.

Tested by http/tests/loading/redirect-with-no-location-crash.html

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):

LayoutTests:

2009-09-16 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crash when visiting ​http://flipper.googlelabs.com/
​https://bugs.webkit.org/show_bug.cgi?id=29293

  • http/tests/loading/redirect-with-no-location-crash.html: Added.
  • http/tests/loading/redirect-with-no-location-crash-expected.html: Added.
  • http/tests/loading/resources/redirect-with-no-location-crash.php: Added.
6:18 AM Changeset in webkit [48412] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-09-16 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Fix wtf/ThreadSpecific.h under Qt to free thread local objects.
​https://bugs.webkit.org/show_bug.cgi?id=29295

This is an important fix when JavaScript workers are in use, since
unfreed ThreadGlobalDatas leak a big amount of memory (50-100k each).
QThreadStorage calls the destructor of a given object, which is the
ThreadSpecific::Data. Unlike pthread, Qt is object oriented, and does
not support the calling of a static utility function when the thread
is about to close. In this patch we call the ThreadSpecific::destroy()
utility function from the destructor of ThreadSpecific::Data. Moreover,
since Qt resets all thread local values to 0 before the calling of the
appropriate destructors, we set back the pointer to its original value.
This is necessary because the get() method of the ThreadSpecific
object may be called during the exuction of the destructor.

  • wtf/ThreadSpecific.h: (WTF::ThreadSpecific::Data::~Data): (WTF::::~ThreadSpecific): (WTF::::set): (WTF::::destroy):
4:50 AM Changeset in webkit [48411] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Build break fix on gcc ARM.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2009-09-16
Reviewed by Tor Arne Vestbø.

  • Api/qwebgraphicsitem.cpp:

(QWebGraphicsItemPrivate::_q_doLoadProgress):

1:58 AM Changeset in webkit [48410] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix a crash in QWebFrame::hasFocus() with a simple null pointer check
when the focused frame is null. We do the same check in other places
where we call kit().

Patch by Warwick Allison <​warwick.allison@nokia.com> on 2009-09-16
Reviewed by Simon Hausmann.

  • Api/qwebframe.cpp:

(QWebFrame::hasFocus):

1:56 AM Changeset in webkit [48409] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fixed a typo found during translation.

Patch by Jure Repinc <​jlp@holodeck1.com> on 2009-09-16
Reviewed by Simon Hausmann.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):

Sep 15, 2009:

10:20 PM Changeset in webkit [48408] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
​https://bugs.webkit.org/show_bug.cgi?id=28841

Layout test fix redux.
The paths to the fast/js resources needed to be updated.

  • platform/mac/accessibility/aria-slider-value-change.html:
8:39 PM Changeset in webkit [48407] by Chris Fleizach
  • 1 edit
    2 moves in trunk/LayoutTests

Layout test fix.
This test should only be for Mac, since the other platforms don't support the necessary features.

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
​https://bugs.webkit.org/show_bug.cgi?id=28841

  • accessibility/aria-slider-value-change-expected.txt: Removed.
  • accessibility/aria-slider-value-change.html: Removed.
  • platform/mac/accessibility/aria-slider-value-change-expected.txt: Copied from LayoutTests/accessibility/aria-slider-value-change-expected.txt.
  • platform/mac/accessibility/aria-slider-value-change.html: Copied from LayoutTests/accessibility/aria-slider-value-change.html.
6:30 PM Changeset in webkit [48406] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Removed the notion of "disconnected nodes with event listeners" because
it was vestigial. The reference cycle it tried to solve was solved another
way in ​https://bugs.webkit.org/show_bug.cgi?id=21260.

Patch by Geoffrey Garen <​ggaren@apple.com> on 2009-09-15
Reviewed by Sam Weinig.

  • dom/Document.cpp:

(WebCore::Document::removeAllEventListeners):

  • dom/Document.h:
  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::insertedIntoDocument):
(WebCore::Node::removedFromDocument):
(WebCore::Node::willMoveToNewOwnerDocument):
(WebCore::Node::didMoveToNewOwnerDocument):
(WebCore::Node::addEventListener):
(WebCore::Node::removeEventListener):
(WebCore::Node::clearAttributeEventListener):

5:40 PM Changeset in webkit [48405] by Chris Fleizach
  • 7 edits
    2 adds in trunk

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
​https://bugs.webkit.org/show_bug.cgi?id=28841

Reviewed by Beth Dakin.

WebCore:

Allow certain ARIA roles to change value with AXIncrement and AXDecrement.
Consolidate increment/decrement/changeValue methods.

Test: accessibility/aria-slider-value-change.html

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::increment):
(WebCore::AccessibilityRenderObject::decrement):
(WebCore::AccessibilityRenderObject::changeValueByPercent):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySlider.cpp:
  • accessibility/AccessibilitySlider.h:
  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests:

  • accessibility/aria-slider-value-change-expected.txt: Added.
  • accessibility/aria-slider-value-change.html: Added.
4:52 PM Changeset in webkit [48404] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-09-15 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Steve Falkenburg.

Add four currently failing tests to the Skipped list so we can figure out what's wrong
with them and try to get the bot closer to green. Bugs have been filed for each test.

  • platform/win/Skipped:
4:17 PM Changeset in webkit [48403] by oliver@apple.com
  • 8 edits in trunk/JavaScriptCore

Allow anonymous storage inside JSObject
​https://bugs.webkit.org/show_bug.cgi?id=29168

Reviewed by Geoff Garen

Add the concept of anonymous slots to Structures so that it is
possible to store references to values that need marking in the
standard JSObject storage buffer. This allows us to reduce the
malloc overhead of some objects (by allowing them to store JS
values in the inline storage of the object) and reduce the
dependence of custom mark functions (if all an objects children
are in the standard object property storage there's no need to
mark them manually).

2:47 PM Changeset in webkit [48402] by ggaren@apple.com
  • 33 edits in trunk/WebCore

Removed the jsEventListeners set from JSDOMGlobalObject, to simplify
creation and destruction of JSDOMGlobalObject and event listeners.

Patch by Geoffrey Garen <​ggaren@apple.com> on 2009-09-15
Reviewed by Sam Weinig.

Added an abstract operator==() to EventListener, to replace the
jsEventListeners set's role in determining if two event listeners are
equal from the DOM's perspective.

Added a type field to EventListener, and casting operations, to support
operator==() and other abstract operations.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
(WebCore::JSEventListener::markJSFunction):
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
(WebCore::JSEventListener::operator==):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::cast):

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

  • bindings/objc/ObjCEventListener.h:

(WebCore::ObjCEventListener::cast):

  • bindings/objc/ObjCEventListener.mm:

(WebCore::ObjCEventListener::ObjCEventListener):
(WebCore::ObjCEventListener::operator==):

  • dom/EventListener.h:

(WebCore::EventListener::):
(WebCore::EventListener::type):
(WebCore::EventListener::EventListener):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::addEventListener):
(WebCore::MessagePort::removeEventListener):

  • dom/Node.cpp:

(WebCore::Node::removeEventListener):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::mainFrameDocument):
(WebCore::InspectorDOMAgent::operator==):

  • inspector/InspectorDOMAgent.h:

(WebCore::InspectorDOMAgent::cast):

  • loader/ImageDocument.cpp:

(WebCore::ImageEventListener::cast):
(WebCore::ImageEventListener::ImageEventListener):
(WebCore::ImageEventListener::operator==):

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::addEventListener):
(WebCore::DOMApplicationCache::removeEventListener):

  • notifications/Notification.cpp:

(WebCore::Notification::removeEventListener):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::removeEventListener):

  • page/EventSource.cpp:

(WebCore::EventSource::addEventListener):
(WebCore::EventSource::removeEventListener):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::ConditionEventListener::cast):
(WebCore::ConditionEventListener::ConditionEventListener):
(WebCore::ConditionEventListener::operator==):
(WebCore::ConditionEventListener::handleEvent):

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::addEventListener):
(WebCore::AbstractWorker::removeEventListener):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addEventListener):
(WebCore::WorkerContext::removeEventListener):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::addEventListener):
(WebCore::XMLHttpRequest::removeEventListener):

  • xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::addEventListener):
(WebCore::XMLHttpRequestUpload::removeEventListener):

2:26 PM Changeset in webkit [48401] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-09-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fixed position elements flash when CSS transforms are applied on page > 2048px tall
​https://bugs.webkit.org/show_bug.cgi?id=27272

Update the previous workaround for misplaced compositing layers, which used a 4096px
threshold, to 2048px since that's the GPU max texture size on some older hardware.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):
1:46 PM WebKit Team edited by vestbo@webkit.org
(diff)
1:33 PM Changeset in webkit [48400] by vestbo@webkit.org
  • 8 edits in trunk

Added ENABLE_MATHML feature define and build-webkit toggle

Patch by Alex Milowski <​alex@milowski.com> on 2009-09-15
Reviewed by Tor Arne Vestbø.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

  • Scripts/build-webkit:
1:25 PM CommitQueue edited by eric@webkit.org
(diff)
12:25 PM Changeset in webkit [48399] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Allow waf build to support Python < 2.6.

11:40 AM Changeset in webkit [48398] by mrowe@apple.com
  • 7 edits in trunk

WebCore: Document.elementFromPoint() and Document.caretRangeFromPoint() erroneously returning null at points visible only after scrolling.
​https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <​randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Use visibleContentRect() instead of boundsRect() when checking hit point bounds on viewport.

  • dom/Document.cpp:

(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

LayoutTests: Document.elementFromPoint() and Document.caretRangeFromPoint() returning null at points visible only after scrolling.
​https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <​randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Extend tests to include hits in areas that are not in the initial containing block of the page.

  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
  • fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
  • fast/dom/elementFromPoint-relative-to-viewport.html:
11:36 AM Changeset in webkit [48397] by jshin@chromium.org
  • 3 edits
    9 adds in trunk

2009-09-15 Jungshik Shin <​jshin@chromium.org>

Reviewed by Eric Seidel

​http://bugs.webkit.org/show_bug.cgi?id=26660

Chromium Windows: When rotated, the baseline for a span of complex
script is completely misaligned with that of the adjacent
simple script text. It's fixed by not applying the baseline offset for
the Skia code path.

Test: transforms/2d/hindi-rotated.html

  • platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):

2009-09-15 Jungshik Shin <​jshin@chromium.org>

Reviewed by Eric Seidel

​http://bugs.webkit.org/show_bug.cgi?id=26660

Chromium Windows: When rotated, the baseline for a span of complex
script is completely misaligned with that of the adjacent simple
script text.

  • transforms/2d/hindi-rotated.html: Added.
  • platform/mac/transforms/2d/hindi-rotated-expected.checksum: Added.
  • platform/mac/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/mac/transforms/2d/hindi-rotated-expected.txt: Added.
  • platform/win/transforms: Added.
  • platform/win/transforms/2d: Added.
  • platform/win/transforms/2d/hindi-rotated-expected.checksum: Added.
  • platform/win/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/win/transforms/2d/hindi-rotated-expected.txt: Added.
11:30 AM Changeset in webkit [48396] by andersca@apple.com
  • 2 edits in trunk/WebCore

Pass the PopupMenu pointer to CreateWindowEx and then get it from the LPCREATESTRUCT in
the WM_CREATE handler. This way we don't have to first create an zero size window and then size it.

Reviewed by Adam Roben.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
(WebCore::PopupMenu::PopupMenuWndProc):

11:27 AM Changeset in webkit [48395] by atwilson@chromium.org
  • 5 edits in trunk

MessageEvent should not be cancelable by default
​https://bugs.webkit.org/show_bug.cgi?id=27846

Reviewed by Darin Adler.

WebCore:

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
Changed constructor to set cancelable=false by default, per the HTML5 spec.

LayoutTests:

  • fast/events/message-port-expected.txt:
  • fast/events/message-port.html:

Added test case to check state of MessageEvent.cancelable attribute.

11:20 AM Changeset in webkit [48394] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7224378> REGRESSION(r48360): Dragging a tab with a plug-in out of a window, the plug-in gets slow and confused

Reviewed by Anders Carlsson.

In r48360, the fix for <rdar://problem/7090444>, I neglected to consider the case where the plug-in had already been started and
-start would do an early-return rather than calling -restartTimers and -addWindowObservers itself.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Reinstate the call to -restartTimers and -addWindowObservers, but guard them
with a check that the view is still in the window.

10:52 AM Changeset in webkit [48393] by eric@webkit.org
  • 5 edits in trunk

2009-09-15 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Add a new test case for SVG Path parsing with a default command and starts with dot '.'
​https://bugs.webkit.org/show_bug.cgi?id=29123

  • svg/dom/path-parser-expected.txt:
  • svg/dom/resources/path-parser.js:

2009-09-15 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix SVG path parsing error if a command starts with dot '.'
​https://bugs.webkit.org/show_bug.cgi?id=29123

  • svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
6:14 AM Changeset in webkit [48392] by rik@webkit.org
  • 10 edits
    1 add in trunk/WebCore

Implement conditional breakpoints in the Web Inspector frontend.
​https://bugs.webkit.org/show_bug.cgi?id=28908

Patch by Alexander Pavlov <​apavlov@chromium.org> on 2009-09-15
Reviewed by Timothy Hatcher.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Breakpoint.js:

(WebInspector.Breakpoint.prototype.set condition):

  • inspector/front-end/Popup.js: Added.

(WebInspector.Popup):
(WebInspector.Popup.prototype.show):
(WebInspector.Popup.prototype.hide):
(WebInspector.Popup.prototype.get visible):
(WebInspector.Popup.prototype.set element):
(WebInspector.Popup.prototype.get element):
(WebInspector.Popup.prototype.positionElement):
(WebInspector.Popup.prototype.set anchor):
(WebInspector.Popup.prototype.get anchor):
(WebInspector.Popup.prototype.set autoHide):
(WebInspector.Popup.prototype._checkNotVisible):
(WebInspector.Popup.prototype._keyEventHandler):
(WebInspector.Popup.prototype._mouseDownEventHandler):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._loaded):
(WebInspector.SourceFrame.prototype._documentContextMenu):
(WebInspector.SourceFrame.prototype._documentMouseDown):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.committed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype._showBreakpointConditionPopup):
(WebInspector.SourceFrame.prototype._createPopupElement):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
(WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.set currentFocusElement):
(WebInspector.set currentPanel):
(WebInspector.loaded):
(WebInspector.contextMenu):
(WebInspector.elementDragStart):
(WebInspector.updateResource):
(WebInspector.drawLoadingPieChart):
(WebInspector.linkifyURLAsNode):
(WebInspector.startEditing.getContent):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):

  • inspector/front-end/utilities.js:

(Element.prototype.positionAt):
(Element.prototype.offsetRelativeToWindow):

6:03 AM Changeset in webkit [48391] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for windows.

Patch by Csaba Osztrogonac <​oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

After ​http://trac.webkit.org/changeset/47795 the MinGW build broke,
because MinGW has mingw_aligned_malloc instead of _aligned_malloc.

  • runtime/Collector.cpp:

(JSC::Heap::allocateBlock): MinGW case added.
(JSC::Heap::freeBlock): MinGW case added.

5:51 AM Changeset in webkit [48390] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for Windows/MinGW

Patch by Csaba Osztrogonac <​oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=29268

  • wtf/Platform.h: JSVALUE32_64 temporarily disabled on PLATFORM(WIN_OS) with COMPILER(MINGW)
4:29 AM Changeset in webkit [48389] by zoltan@webkit.org
  • 3 edits
    1 add in trunk/JavaScriptCore

2009-09-14 Gabor Loki <​loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Detect VFP at runtime in generic ARM port on Linux platform.
​https://bugs.webkit.org/show_bug.cgi?id=29076

  • JavaScriptCore.pri:
  • assembler/MacroAssemblerARM.cpp: Added. (JSC::isVFPPresent):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsFloatingPoint):
Note: See TracTimeline for information about the timeline view.