Timeline
Sep 17, 2009:
- 10:21 PM Changeset in webkit [48500] by
-
- 2 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=29276
REGRESSION(r48334): WebKit crashes on file select by drag
Reviewed by Adele Peterson.
Document.elementFromPoint now takes point in client space, not page space.
- page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
- 6:32 PM Changeset in webkit [48499] by
-
- 5 edits in trunk/WebCore
2009-09-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by David Levin.
Reimplement default media UI for Mac Chromium to match the style
of the Windows and Linux versions. Also breaks the dependency
on the internal wk* functions that were previously used to
render the media controller widgets.
https://bugs.webkit.org/show_bug.cgi?id=29161
No media layout tests are currently enabled in Mac Chromium, so
nothing needs rebaselineing, etc.
This is a recommit of r48438 with a compile fix and merges of
recent changes to the file.
- css/mediaControlsChromium.css:
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet): (WebCore::mediaSliderThumbImage): (WebCore::mediaVolumeSliderThumbImage): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
- 5:06 PM Changeset in webkit [48498] by
-
- 2 edits in trunk/LayoutTests
2009-09-17 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Steve Falkenburg.
Add failing test on both Windows Debug and Release to the
Windows Skipped List.
http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html is
being tracked by <https://bugs.webkit.org/show_bug.cgi?id=29353>.
- platform/win/Skipped:
- 4:59 PM Changeset in webkit [48497] by
-
- 3 edits in trunk/WebCore
2009-09-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
The Console scope bar should have a divider between All and the other possible
values (Errors, Warnings, Logs). It will look something like:
All | Errors Warnings Logs.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createDividerElement): (WebInspector.ConsoleView):
- inspector/front-end/inspector.css:
- 4:03 PM Changeset in webkit [48496] by
-
- 2 edits in trunk/WebKit/win
2009-09-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Remove assertions that were being hit by calls to
m_verticalScrollbar->invalidate(). These assertions were valid,
but they were causing tests to fail, so replacing with a FIXME
until we can find out the real cause/solution that is being tracked
by http://webkit.org/b/29350.
- WebView.cpp: (WebView::addToDirtyRegion): (WebView::paintIntoBackingStore):
- 3:54 PM Changeset in webkit [48495] by
-
- 3 edits in trunk/WebCore
Remove additional references to JSVoidCallback which no longer exists.
Reviewed by Mark Rowe.
- DerivedSources.cpp:
- WebCore.vcproj/WebCore.vcproj:
- 3:48 PM Changeset in webkit [48494] by
-
- 21 edits in trunk/LayoutTests
2009-09-17 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
Media layout tests should have a way to provide test files in different formats
https://bugs.webkit.org/show_bug.cgi?id=28327
Updating 19 media layout tests to use media files based on supported codecs.
- media/media-file.js: Prefer .wav over other formats as this is used the most in tests for mac port. Most of audio tests use media/content/test.wav as test file for mac, so this change would make sure findMediaFile() will return test.wav but not test.mp3 or other formats. (setSrcById): Fixing bug in code.
- media/video-canvas-source.html: Use findMediaFile() to locate a media file based on supported types.
- media/video-click-dblckick-standalone.html: ditto.
- media/video-controls-transformed.html: ditto.
- media/video-controls-visible-audio-only.html: ditto.
- media/video-controls-zoomed.html: ditto.
- media/video-controls.html: ditto.
- media/video-currentTime-set.html: ditto.
- media/video-currentTime-set2.html: ditto.
- media/video-currentTime.html: ditto.
- media/video-display-none-crash.html: ditto.
- media/video-display-toggle.html: ditto.
- media/video-dom-autoplay.html: ditto.
- media/video-dom-src.html: ditto.
- media/video-error-abort.html: ditto.
- media/video-load-networkState.html: ditto.
- media/video-load-readyState.html: ditto.
- media/video-loop.html: ditto.
- media/video-muted.html: ditto.
- media/video-no-autoplay.html: ditto.
- 3:48 PM Changeset in webkit [48493] by
-
- 2 edits in trunk/WebCore
Remove commented out onhashchange attribute now that it is implemented.
Reviewed by Brady Eidson.
- page/DOMWindow.idl:
- 3:23 PM Changeset in webkit [48492] by
-
- 5 edits in trunk
WebCore: <rdar://problem/7007541>
CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...
Reviewed by Oliver Hunt.
Make RuntimeObjectImp more robust against m_instance being a null (which can happen if an OOP plug-in
crashes while we're calling into it).
- bridge/runtime_object.cpp:
(JSC::RuntimeObjectImp::RuntimeObjectImp):
(JSC::RuntimeObjectImp::~RuntimeObjectImp):
(JSC::RuntimeObjectImp::invalidate):
(JSC::RuntimeObjectImp::fallbackObjectGetter):
(JSC::RuntimeObjectImp::fieldGetter):
(JSC::RuntimeObjectImp::methodGetter):
(JSC::RuntimeObjectImp::getOwnPropertySlot):
(JSC::RuntimeObjectImp::getOwnPropertyDescriptor):
(JSC::RuntimeObjectImp::put):
(JSC::RuntimeObjectImp::defaultValue):
(JSC::RuntimeObjectImp::getCallData):
(JSC::RuntimeObjectImp::getConstructData):
(JSC::RuntimeObjectImp::getPropertyNames):
- bridge/runtime_object.h:
(JSC::RuntimeObjectImp::getInternalInstance):
WebKit/mac: <rdar://problem/7007541>
CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...
Reviewed by Oliver Hunt.
Add null checks for m_instanceProxy (It will be null when a plug-in has crashed).
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invoke):
(WebKit::ProxyInstance::supportsInvokeDefaultMethod):
(WebKit::ProxyInstance::supportsConstruct):
(WebKit::ProxyInstance::getPropertyNames):
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):
(WebKit::ProxyInstance::fieldValue):
(WebKit::ProxyInstance::setFieldValue):
(WebKit::ProxyInstance::invalidate):
- 1:54 PM Changeset in webkit [48491] by
-
- 5 edits in trunk/WebCore
2009-09-17 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Wrap primitive values (as objects) in InspectorController::wrap.
- inspector/InspectorController.cpp: (WebCore::InspectorController::wrapObject): objects of any type will be wrapped into proxies, only object proxies will have objectId.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): there is InjectedScript.getCompletionsi that accepts an expression and returns possible completions. This way we don't need to wrap and unwrap the completions result into a proxy object.
- inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): (InjectedScript.evaluate): (InjectedScript._evaluateOn): (InjectedScript.createProxyObject):
- inspector/front-end/InjectedScriptAccess.js:
- 1:45 PM Changeset in webkit [48490] by
-
- 2 edits in trunk/WebCore
2009-09-17 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Wrap PageTransitionEvents properly for V8's use.
Fixes Chromium's failures for LayoutTests/fast/events/pageshow-pagehide.html.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object): Wrap PageTransitionEvents properly.
- 1:12 PM Changeset in webkit [48489] by
-
- 3 edits3 adds in trunk
2009-09-17 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Hardware-accelerated opacity transition on inline asserts
https://bugs.webkit.org/show_bug.cgi?id=29342
Remove an erroneous toRenderBox() that could be called on a RenderInline; we can just
pass an empty size, because the box size is only required for transform animations.
Test: compositing/transitions/opacity-on-inline.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startTransition):
- 1:07 PM Changeset in webkit [48488] by
-
- 2 edits in trunk/WebKitSite
2009-09-17 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Update contributing.html to mention recently added tools.
https://bugs.webkit.org/show_bug.cgi?id=29318
Update our contributing instructions to mention
the new tools (check-webkit-style and commit-queue)
recently added to make contributions easier.
- coding/contributing.html:
- Mention check-webkit-style as an optional helper tool.
- Mention checking the 'patch' checkbox.
- Mention the commit-queue as an optional helper tool.
- Remove "or in email" since patch reviews are all done via bugzilla.
- Encourage contributers to be responsible for getting their patch landed. Provide a list of committers.
- Mention commit-queue as an optional help in getting your patch landed.
- Give an overview of the commit-queue process and link to the Commit Queue docs.
- 1:03 PM Changeset in webkit [48487] by
-
- 2 edits in trunk/LayoutTests
2009-09-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Brady Eidson.
Tiger fails test http/tests/loading/redirect-with-no-location-crash.html added in r48413
https://bugs.webkit.org/show_bug.cgi?id=29329
Skip test that fails on Tiger because of a bug in its version of
CFNetwork.
- platform/mac-tiger/Skipped:
- 12:59 PM Changeset in webkit [48486] by
-
- 2 edits in trunk/WebCore
2009-09-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] OwnHandle might get a weak callback after destruction
https://bugs.webkit.org/show_bug.cgi?id=29172
Be sure to clear out weak reference so we don't get a weak callback
after we've destructed ourselves. Also, removed some tricky methods
that had no clients.
- bindings/v8/OwnHandle.h: (WebCore::OwnHandle::clear):
- 12:52 PM Changeset in webkit [48485] by
-
- 2 edits1 move in trunk/LayoutTests
2009-09-17 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION: media/video-size-intrinsic-scale.html (and other media tests?) crashing/timing-out intermittently
https://bugs.webkit.org/show_bug.cgi?id=28845
Skip media/video-size-intrinsic-scale.html in hopes of stopping the crashers.
I ran the media tests with --iterations 30 w/o seeing a crash.
I also re-enabled media/video-source-add-src.html now that we know it is not at fault.
- media/video-source-add-src.html: Renamed from LayoutTests/media/video-source-add-src.html-disabled.
- platform/mac-leopard/Skipped:
- 12:43 PM Changeset in webkit [48484] by
-
- 1 edit9 adds in trunk/LayoutTests
2009-09-17 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Add layout tests to verify there is no security leaks if someone sets a prototype of top
window to its child window.
https://bugs.webkit.org/show_bug.cgi?id=29334
- http/tests/security/resources/iframe-with-element.html: Added.
- http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt: Added.
- http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto.html: Added.
- http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt: Added.
- http/tests/security/xss-DENIED-method-with-iframe-proto.html: Added.
- http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto-expected.txt: Added.
- http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto.html: Added.
- http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto-expected.txt: Added.
- http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto.html: Added.
- 12:13 PM Changeset in webkit [48483] by
-
- 2 edits in trunk/WebCore
2009-09-17 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[V8] Partial roll out of http://trac.webkit.org/changeset/48455 to
fix crashes that started happening in V8Proxy::getEnteredContext().
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- 12:10 PM Changeset in webkit [48482] by
-
- 7 edits2 adds in trunk
AX: labels of checkboxes should, when hit-tested, return the checkbox
https://bugs.webkit.org/show_bug.cgi?id=29335
Reviewed by Beth Dakin.
WebCore:
When an accessibility hit test is done and it hits the label of a control element,
the control element should be returned instead of nothing, since the label
itself is usually ignored.
Test: accessibility/label-for-control-hittest.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::correspondingControlForLabelElement):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
- accessibility/label-for-control-hittest-expected.txt: Added.
- accessibility/label-for-control-hittest.html: Added.
- platform/gtk/Skipped:
- platform/win/Skipped:
- 12:08 PM Changeset in webkit [48481] by
-
- 2 edits in trunk/WebCore
2009-09-17 Avi Drissman <avi@chromium.org>
Reviewed by Dimitri Glazkov, build fix.
Change to make RenderThemeChromiumMac compile inside of non PLATFORM(MAC).
https://bugs.webkit.org/show_bug.cgi?id=29243
Covered by existing tests.
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
- 12:06 PM Changeset in webkit [48480] by
-
- 2 edits in trunk/WebCore
2009-09-17 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
[V8] Accessing properties/methods of an object, created with document.implementation.createDocumentType
creates nodes that have no document (ScriptExecutionContext), which in turn produces NULL-ref crashes.
https://bugs.webkit.org/show_bug.cgi?id=26402
Test: fast/dom/DOMImplementation/detached-doctype.html
fast/dom/doctype-event-listener-crash.html
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener): Added an extra NULL-check.
- 11:39 AM Changeset in webkit [48479] by
-
- 2 edits in trunk/LayoutTests
2009-09-17 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Add a newline to the end of the expected file, should fix results.
- platform/win/transforms/2d/hindi-rotated-expected.txt:
- 11:32 AM Changeset in webkit [48478] by
-
- 3 edits in trunk/WebKit/win
Post WebViewDidChangeSelectionNotification when the text selection changes.
Fixes <http://webkit.org/b/29321>
Reviewed by Adam Roben.
- Interfaces/IWebView.idl:
- WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::respondToChangedSelection):
- 11:09 AM Changeset in webkit [48477] by
-
- 2 edits in trunk/WebKitTools
wx build fix, add missing dependency.
- 11:05 AM Changeset in webkit [48476] by
-
- 4 edits in trunk/LayoutTests
2009-09-17 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Updated Windows results on three failing tests, adding font-smoothing to computed-style,
and udpated the hindi-rotated-expected to what it has been getting on the bots.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/transforms/2d/hindi-rotated-expected.txt:
- 10:44 AM Changeset in webkit [48475] by
-
- 1 add in trunk/WebCore/platform/graphics/FontSmoothingMode.h
Add file that was missing from the last change
- 10:33 AM Changeset in webkit [48474] by
-
- 11 edits in trunk/WebCore
FontDescription.h includes RenderStyleConstants.h, which violates layering
https://bugs.webkit.org/show_bug.cgi?id=29327
Reviewed by Simon Fraser.
- GNUmakefile.am: Added FontSmoothingMode.h.
- WebCore.gypi: Added FontSmoothingMode.h.
- WebCore.vcproj/WebCore.vcproj: Added FontSmoothingMode.h.
- WebCore.xcodeproj/project.pbxproj: Added FontSmoothingMode.h and made
it a private header.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Get the
font smoothing mode via the font description.
- css/CSSPrimitiveValueMappings.h: Include FontSmoothingMode.h
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Updated for the rename
of FontSmoothing to FontSmoothingMode.
(WebCore::CSSPrimitiveValue::operator FontSmoothingMode): Ditto.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Get the font smoothing mode
via the font description.
- platform/graphics/FontDescription.h: Do not include
RenderStyleConstants.h.
(WebCore::FontDescription::fontSmoothing): Updated for the rename of
FontSmoothing to FontSmoothingMode.
(WebCore::FontDescription::setFontSmoothing): Ditto.
- platform/graphics/FontSmoothingMode.h: Added.
(WebCore::FontSmoothingMode): Moved the FontSmoothing enum from
RenderStyleConstants here and renamed it to this.
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::fontSmoothing): Removed this getter, since
this can be accessed via the font description.
- rendering/style/RenderStyleConstants.h: Moved the FontSmoothing enum
from here to FontSmoothingMode.h.
- 10:32 AM Changeset in webkit [48473] by
-
- 2 edits in trunk/WebKit/win
Fix a crash when a WebView's HWND is destroyed before IWebView::close is called
WebView's HWND was being sent a WM_TIMER message after the WebView was
destroyed. This normally isn't possible (we call DestroyWindow inside
WebView's destructor to ensure the HWND doesn't outlive the WebView),
but r48060 changed WebView to call SetParent(m_viewWindow,
HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the
HWND into some weird half-destroyed state where it can still receive
WM_TIMER messages.
Fixes <http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION
(r48060): unrepro but frequent crash in WebViewWndProc
Reviewed by Steve Falkenburg.
- WebView.cpp:
(WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed()
before calling close(). This allows setHostWindow to detect that we're
handling WM_DESTROY. No other code in close() cared whether
isBeingDestroyed() was true or not.
(WebView::setHostWindow): If our host window is being set to 0 and
we're being destroyed, don't become a message-only window. Doing this
while handling WM_DESTROY seems to lead to crashes.
- 10:10 AM Changeset in webkit [48472] by
-
- 2 edits in trunk/WebCore
wx 2.9 build fix.
- 9:56 AM Changeset in webkit [48471] by
-
- 2 edits in trunk/WebKit/mac
2009-09-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Work around a bug in AppKit on Leopard which causes compositing layers to jitter, and
become misplaced when the WebHTMLView is resized or scrolled sometimes.
<rdar://problem/7071636>
The previous fix didn't fix the case where the layers jiggle when resizing the docked
inspector when the view size is over 2048px tall, on Leopard.
- WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):
- 9:41 AM Changeset in webkit [48470] by
-
- 3 edits4 adds in trunk
2009-09-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Elements appear behind <video> when they should be in front sometimes
https://bugs.webkit.org/show_bug.cgi?id=29314
r45598 added logic that tests for overlap with <video> to determine when to throw
a layer into compositing mode. That logic was incorrect in some cases, and this patch
fixes it. When testing overlap, the layer needs to be composited iff some previous layer
is composited (which adds a rect to the overlay map), and there is overlap.
Test: compositing/geometry/video-opacity-overlay.html
- rendering/RenderLayerCompositor.cpp: (WebCore::CompositingState::CompositingState): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 8:52 AM Changeset in webkit [48469] by
-
- 8 edits2 adds in trunk/WebCore
2009-09-17 Avi Drissman <avi@google.com>
Reviewed by Darin Fisher.
Update the Chromium Mac theming files (RenderTheme and Theme) to be
up-to-date.
https://bugs.webkit.org/show_bug.cgi?id=29243
http://crbug.com/19604
Covered by existing tests.
- WebCore.gypi:
- platform/chromium/ThemeChromiumMac.h: Added. (WebCore::ThemeChromiumMac::ThemeChromiumMac): (WebCore::ThemeChromiumMac::~ThemeChromiumMac): (WebCore::ThemeChromiumMac::controlRequiresPreWhiteSpace):
- platform/chromium/ThemeChromiumMac.mm: Added. (WebCore::): (WebCore::platformTheme): (WebCore::controlSizeForFont): (WebCore::sizeFromFont): (WebCore::setControlSize): (WebCore::updateStates): (WebCore::inflateRect): (WebCore::checkboxSizes): (WebCore::checkboxMargins): (WebCore::checkboxSize): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radioSizes): (WebCore::radioMargins): (WebCore::radioSize): (WebCore::radio): (WebCore::paintRadio): (WebCore::buttonSizes): (WebCore::buttonMargins): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeChromiumMac::baselinePositionAdjustment): (WebCore::ThemeChromiumMac::controlFont): (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::controlBorder): (WebCore::ThemeChromiumMac::controlPadding): (WebCore::ThemeChromiumMac::inflateControlPaintRect): (WebCore::ThemeChromiumMac::paint):
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.h:
- platform/graphics/IntRect.h:
- rendering/RenderThemeChromiumMac.h: (WebCore::RenderThemeChromiumMac::supportsControlTints): (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart): (WebCore::RenderThemeChromiumMac::supportsSelectionForegroundColors):
- rendering/RenderThemeChromiumMac.mm: (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): (-[RTCMFlippedView isFlipped]): (-[RTCMFlippedView currentEditor]): (WebCore::): (WebCore::FlippedView): (WebCore::RenderTheme::themeForPage): (WebCore::RenderThemeChromiumMac::platformActiveListBoxSelectionForegroundColor): (WebCore::RenderThemeChromiumMac::platformInactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeChromiumMac::platformInactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeChromiumMac::systemFont): (WebCore::convertNSColorToColor): (WebCore::menuBackgroundColor): (WebCore::RenderThemeChromiumMac::systemColor): (WebCore::RenderThemeChromiumMac::isControlStyled): (WebCore::RenderThemeChromiumMac::adjustRepaintRect): (WebCore::RenderThemeChromiumMac::inflateRect): (WebCore::RenderThemeChromiumMac::convertToPaintingRect): (WebCore::RenderThemeChromiumMac::setFontFromControlSize): (WebCore::RenderThemeChromiumMac::paintTextField): (WebCore::RenderThemeChromiumMac::paintCapsLockIndicator): (WebCore::RenderThemeChromiumMac::paintTextArea): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::TopGradientInterpolate): (WebCore::BottomGradientInterpolate): (WebCore::MainGradientInterpolate): (WebCore::TrackGradientInterpolate): (WebCore::RenderThemeChromiumMac::paintMenuListButtonGradients): (WebCore::RenderThemeChromiumMac::paintMenuListButton): (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): (WebCore::RenderThemeChromiumMac::popupInternalPaddingTop): (WebCore::RenderThemeChromiumMac::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumMac::adjustSliderTrackStyle): (WebCore::RenderThemeChromiumMac::adjustSliderThumbStyle): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::setSearchCellState): (WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldDecoration): (WebCore::RenderThemeChromiumMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton): (WebCore::mediaControllerTheme): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::getMediaUIPartStateFlags): (WebCore::getUnzoomedRectAndAdjustCurrentContext): (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaRewindButton): (WebCore::RenderThemeChromiumMac::paintMediaReturnToRealtimeButton): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): (WebCore::RenderThemeChromiumMac::paintMediaCurrentTime): (WebCore::RenderThemeChromiumMac::paintMediaTimeRemaining): (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet):
- 7:03 AM Changeset in webkit [48468] by
-
- 2 edits in trunk/WebKit/qt
Improve documentation for Page Cache.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-17
Reviewed by Simon Hausmann.
- Api/qwebsettings.cpp:
- 6:03 AM Changeset in webkit [48467] by
-
- 1 add in trunk/LayoutTests/platform/qt/fast/css/font-smoothing-expected.txt
2009-09-17 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Add expected file for passing font-smoothing test and update computed style tests since font smoothing is auto by default.
- platform/qt/fast/css/font-smoothing-expected.txt: Added.
- 6:01 AM Changeset in webkit [48466] by
-
- 3 edits in trunk/LayoutTests
2009-09-17 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Add expected file for passing font-smoothing test and update computed style tests since font smoothing is auto by default.
- platform/qt/fast/css/font-smoothing-expected.txt: Added.
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 5:46 AM Changeset in webkit [48465] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Update QWebSettings::setUserStyleSheetUrl() docs and test
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29081
The documentation now specifies that the URL has to be a local file
or a a data-URL (with utf-8 and base64-encoded data), as these are the
only two schemes that the current code path accepts.
The auto-test has been updated to reflect this limitation.
At a later point we should concider adding API for the new way of
doing both user defined stylesheets and scripts.
- Api/qwebsettings.cpp:
- tests/qwebpage/tst_qwebpage.cpp:
- 4:51 AM Changeset in webkit [48464] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip failing tests for now to prepare default font size reconciliation.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-17
Reviewed by Simon Hausmann.
- platform/qt/Skipped:
- 3:54 AM Changeset in webkit [48463] by
-
- 2 edits in trunk/JavaScriptCore
Symbian/WINSCW build fox.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-17
Reviewed by Simon Hausmann.
Repeat Q_OS_WIN wchar_t hack for WINSCW, similar to
revision 24774.
WINSCW defines wchar_t, thus UChar has to be wchar_t
- wtf/unicode/qt4/UnicodeQt4.h:
- 3:47 AM Changeset in webkit [48462] by
-
- 2 edits in trunk/JavaScriptCore
Symbian/WINSCW build fix.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-17
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29186
WINSCW Template specialisation name in declaration must the be the same as in implementation.
- runtime/LiteralParser.h:
- 3:44 AM Changeset in webkit [48461] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=27060
Patch by Norbert Leser <norbert.leser@nokia.com> on 2009-09-15
Reviewed by Darin Adler.
Symbian compiler for emulator target (WINSCW) fails with
"illegal operand" for m_attributesInPrevious in structure.ccp
(when calling make_pair functions).
This error is apparently due to the compiler not properly
resolving the unsigned type of the declared bitfield.
Initial patch explicitly casted m_attributesInPrevious
to unsigned, but since bitfield optimization is not critical for
the emulator target, this conditional change in header file
appears to be least intrusive.
- runtime/Structure.h:
- 3:31 AM Changeset in webkit [48460] by
-
- 4 edits in trunk/WebKit/qt
Symbian build fix.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-17
Reviewed by Simon Hausmann.
Moved the #ifdefs around _q_cleanupLeakMessages() into the function
definition.
QMake is not being able to distinguish between release and debug builds
in Symbian build. This is a Symbian toolchain issue.
- Api/qwebpage.cpp:
(QWebPagePrivate::_q_cleanupLeakMessages):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
- 3:20 AM Changeset in webkit [48459] by
-
- 2 edits in trunk/WebKit/qt
Small cosmetic documentation fixlet in the QWebInspector.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-17
Reviewed by Simon Hausmann.
- Api/qwebinspector.cpp:
Sep 16, 2009:
- 11:45 PM Changeset in webkit [48458] by
-
- 3 edits2 adds in trunk
2009-09-16 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Tests that scripts with accented characters do not bypass the XSSAuditor.
- http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-accented-char.html: Added.
2009-09-16 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Fixes an issue where an attack that contains accented characters can
bypass the XSSAuditor.
XSSAuditor::decodeURL used the wrong length for the input string.
When the input string was decoded, the decoded result was truncated.
Hence, XSSAuditor was comparing the source code of the script to the
truncated input parameters.
Test: http/tests/security/xssAuditor/img-onerror-accented-char.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeURL):
- 11:42 PM Changeset in webkit [48457] by
-
- 5 edits in trunk/LayoutTests
2009-09-16 Adam Barth <abarth@webkit.org>
Unreviewed. Added new isolated world test to the skipped list.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 11:36 PM Changeset in webkit [48456] by
-
- 2 edits in trunk/WebCore
Explore allowing pages with unload handlers into the Page Cache
https://bugs.webkit.org/show_bug.cgi?id=29021
Reviewed by Sam Weinig.
No new tests. (All previous tests continue to pass)
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): If the document is in the page cache, don't fire the unload event.
- 11:25 PM Changeset in webkit [48455] by
-
- 6 edits4 adds in trunk
2009-09-16 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
We now save a handle to the original context. We use that handle to
call the timeout in the right context / world.
Tests: http/tests/security/isolatedWorld/window-setTimeout-function.html
http/tests/security/isolatedWorld/window-setTimeout-string.html
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):
2009-09-16 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
Add test coverage for the interaction between setTimeout and isolated
worlds.
- http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Added.
- http/tests/security/isolatedWorld/window-setTimeout-function.html: Added.
- http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Added.
- http/tests/security/isolatedWorld/window-setTimeout-string.html: Added.
- 9:39 PM Changeset in webkit [48454] by
-
- 2 edits in trunk/WebCore
Add some groups to the xcode project to make the bindings/js/ group
a little nicer.
Reviewed by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj:
- 8:42 PM Changeset in webkit [48453] by
-
- 20 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=29320
JS callback objects should store the global object
Reviewed by Anders Carlsson.
This just changes the callback objects to store the global object instead
of the frame. A follow up patch will change them to store the 'current'
global object instead of the lexical or dynamic.
- DerivedSources.make: Remove unused VoidCallback.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSCustomPositionCallback.cpp:
(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):
- bindings/js/JSCustomPositionCallback.h:
(WebCore::JSCustomPositionCallback::create):
- bindings/js/JSCustomPositionErrorCallback.cpp:
(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):
- bindings/js/JSCustomPositionErrorCallback.h:
(WebCore::JSCustomPositionErrorCallback::create):
- bindings/js/JSCustomSQLStatementCallback.cpp:
(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementCallback.h:
(WebCore::JSCustomSQLStatementCallback::create):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.h:
(WebCore::JSCustomSQLStatementErrorCallback::create):
- bindings/js/JSCustomSQLTransactionCallback.cpp:
(WebCore::JSCustomSQLTransactionCallback::Data::Data):
(WebCore::JSCustomSQLTransactionCallback::Data::globalObject):
(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.h:
(WebCore::JSCustomSQLTransactionCallback::create):
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.h:
(WebCore::JSCustomSQLTransactionErrorCallback::create):
- bindings/js/JSCustomVoidCallback.cpp:
(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):
- bindings/js/JSCustomVoidCallback.h:
(WebCore::JSCustomVoidCallback::create):
- bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):
- bindings/js/JSGeolocationCustom.cpp:
(WebCore::createPositionCallback):
(WebCore::createPositionErrorCallback):
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
- 8:40 PM Changeset in webkit [48452] by
-
- 2 edits in trunk/WebKitTools
Split the SnowLeopard build across a few machines.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 7:57 PM Changeset in webkit [48451] by
-
- 3 edits in trunk/WebKit/wx
wxPython bindings build fixes after recent changes.
- 7:33 PM Changeset in webkit [48450] by
-
- 5 edits in trunk/WebCore
Revert "2009-09-16 Albert J. Wong <ajwong@chromium.org>"
This change did not compile.
- 7:13 PM Changeset in webkit [48449] by
-
- 15 edits2 adds12 deletes in trunk
2009-09-15 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
<input maxlength=> should restrict only values specified by users.
https://bugs.webkit.org/show_bug.cgi?id=21271
- fast/forms/input-appearance-maxlength-expected.txt:
- fast/forms/input-appearance-maxlength.html:
- fast/forms/input-maxlength-expected.txt:
- fast/forms/input-maxlength.html:
- fast/forms/input-text-maxlength-expected.txt: Added.
- fast/forms/input-text-maxlength.html:
- fast/forms/input-text-paste-maxlength-expected.txt: Added.
- fast/forms/input-text-paste-maxlength.html:
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum: Removed.
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.png: Removed.
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt: Removed.
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum: Removed.
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png: Removed.
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
- platform/mac/fast/forms/input-text-maxlength-expected.txt: Removed.
- platform/mac/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
- platform/qt/fast/forms/input-text-maxlength-expected.txt: Removed.
- platform/qt/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
- platform/win/fast/forms/input-text-maxlength-expected.txt: Removed.
- platform/win/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
2009-09-15 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
<input maxlength=> should restrict only values specified by users.
https://bugs.webkit.org/show_bug.cgi?id=21271
- dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): (WebCore::InputElement::sanitizeValue): (WebCore::InputElement::sanitizeUserInputValue): Rename from constrainValue(). (WebCore::InputElement::handleBeforeTextInsertedEvent): (WebCore::InputElement::updateValueIfNeeded):
- dom/InputElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::sanitizeValue):
- html/HTMLInputElement.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::constrainValue):
- wml/WMLInputElement.h: (WebCore::WMLInputElement::sanitizeValue):
- 6:58 PM Changeset in webkit [48448] by
-
- 5 edits in trunk/WebCore
2009-09-16 Enrica Casucci <enrica@apple.com>
Reviewed by Eric Seidel.
Reorganizing helper functions in htmlediting.h to group them by type of object they return/operate upon.
https://bugs.webkit.org/show_bug.cgi?id=29319
- editing/IndentOutdentCommand.cpp: Removed implementation of isAtUnsplittableElement.
- editing/IndentOutdentCommand.h: Removed member function isAtUnsplittableElement, because it was not class specific and belonged logically among the helper functions.
- editing/htmlediting.cpp: (WebCore::isAtUnsplittableElement): added. The code was taken from IndentOutdentCommand.
- editing/htmlediting.h: Reordered functions to group them by type of object returned or operate upon. Added comments. Added isAtUnsplittableElement declaration.
- 5:00 PM CommitQueue edited by
- (diff)
- 4:27 PM Changeset in webkit [48447] by
-
- 3 edits2 adds in trunk
WebCore: Removed some vestigial and potentially crashy code that makes consolidating
event listeners hard.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-16
Reviewed by Sam Weinig and Anders Carlsson.
- dom/Node.cpp:
(WebCore::Node::addEventListener): No need to limit when event listeners
can be added. Other EventTargets don't do this.
Also, check for null when accessing document(). Technically, the JS bindings
do this check for us, but let's not rely on that.
LayoutTests: Added a test for a potential crash when adding an event listener to a
doctype node.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-16
Reviewed by Sam Weinig.
- fast/dom/doctype-event-listener-crash-expected.txt: Added.
- fast/dom/doctype-event-listener-crash.html: Added.
- 4:25 PM Changeset in webkit [48446] by
-
- 3 edits in trunk/WebCore
<rdar://problem/7155710>
HTML selects on windows cause containing window to become inactive when opened
Reviewed by Adam Roben.
Redo the way we handle events when a popup menu is shown, based on
http://blogs.msdn.com/oldnewthing/archive/2004/08/20/217684.aspx
Since a non-active window can't capture the mouse, we use the owning window
(the WebView) as the capture window. We then run a recursive message pump that
forwards all mouse and keyboard events to the popup menu.
- platform/PopupMenu.h:
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::wndProc):
- 4:23 PM Changeset in webkit [48445] by
-
- 3 edits in trunk/JavaScriptCore
2009-09-16 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Darin Adler.
Fix GCC warnings on ARM_THUMB2 platform
- assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::countLeadingZerosPartial):
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::branchTruncateDoubleToInt32): (JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
- 4:14 PM Changeset in webkit [48444] by
-
- 2 edits in trunk/WebKit/qt
2009-09-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Eric Seidel.
Detect and add Windows7 properly to the user agent.
- Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
- 4:06 PM Changeset in webkit [48443] by
-
- 2 edits in trunk/WebCore
Speculative fix for
<rdar://problem/6937089> Crashes at RenderWidget::destroy()
Reviewed by Ada Chan.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy): Avoid calling renderArena() if node()
is null. Add two assertions that can help determine how this crash
happens (in particular, whether node() becomes null during destroy() or
it is null before destroy() is called).
- 3:17 PM Changeset in webkit [48442] by
-
- 2 edits in trunk/WebCore
Speculative build fix.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 3:08 PM Changeset in webkit [48441] by
-
- 16 edits7 adds in trunk
WebCore: Fix for <rdar://problem/7083741> Implement a CSS extension to
adjust sub-pixel anti-aliasing for text
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29291
Reviewed by Darin Adler.
Added tests:
- fast/css/font-smoothing.html: Added.
- fast/css/parsing-webkit-font-smoothing.html: Added.
This patch adds a new CSS property called -webkit-font-smoothing
that accepts the following as valid input: auto | none |
antialiased | subpixel-antialiased
Return appropriate computed style for -webkit-font-smoothing
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Add a case for CSSPropertyWebkitFontSmoothing, and accept valid
input.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Add mappings for FontSmoothing to the right CSS values.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontSmoothing):
Add -webkit-font-smoothing
- css/CSSPropertyNames.in:
Set fontSmoothing on the FontDescription.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Add antialiased and subpixel-antialiased as possible new CSS
values.
- css/CSSValueKeywords.in:
Store the font smoothing CSS value in the FontDescription.
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::fontSmoothing):
(WebCore::FontDescription::setFontSmoothing):
(WebCore::FontDescription::operator==):
Call setShouldAntialias() and setShouldUseSmoothing() appropriately
based on the CSS fontSmoothing() value.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
New function fontSmoothing()
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::fontSmoothing):
New enum FontSmoothing.
- rendering/style/RenderStyleConstants.h:
(WebCore::):
LayoutTests: Tests for <rdar://problem/7083741> Implement a CSS extension to
adjust sub-pixel anti-aliasing for text
Reviewed by Darin Adler.
New tests:
- fast/css/font-smoothing.html: Added.
- fast/css/parsing-webkit-font-smoothing-expected.txt: Added.
- fast/css/parsing-webkit-font-smoothing.html: Added.
- fast/css/resources/parsing-webkit-font-smoothing.js: Added.
(test):
- platform/mac/fast/css/font-smoothing-expected.checksum: Added.
- platform/mac/fast/css/font-smoothing-expected.png: Added.
- platform/mac/fast/css/font-smoothing-expected.txt: Added.
These tests have updated results now that -webkit-font-smoothing is
reported with computed style.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 2:52 PM Changeset in webkit [48440] by
-
- 3 edits in trunk/WebKit/win
Add a UI delegate callback to let the delegate draw a WebView's background
Fixes <http://webkit.org/b/29315>.
Reviewed by Dave Hyatt.
- Interfaces/IWebUIDelegatePrivate.idl: Added
IWebUIDelegatePrivate2::drawBackground.
- WebView.cpp:
(WebView::paintIntoBackingStore): After clearing or filling with
white, let the delegate draw whatever background it wants. Also added
an assertion that the dirty rect is within our bounds.
- 2:47 PM Changeset in webkit [48439] by
-
- 2 edits in trunk/WebKit/win
Prevent WebView from painting over sibling windows
Fixes <http://webkit.org/b/29300> <rdar://problem/7227960> WebView can
paint over sibling windows
Reviewed by Darin Adler.
- WebView.cpp:
(WebView::initWithFrame): Create the WebView's HWND with the
WS_CLIPSIBLINGS style.
- 2:46 PM Changeset in webkit [48438] by
-
- 5 edits in trunk/WebCore
2009-09-16 Albert J. Wong <ajwong@chromium.org>
Reviewed by David Levin.
Reimplement default media UI for Mac Chromium to match the style
of the Windows and Linux versions. Also breaks the dependency
on the internal wk* functions that were previously used to
render the media controller widgets.
https://bugs.webkit.org/show_bug.cgi?id=29161
No media layout tests are currently enabled in Mac Chromium, so
nothing needs rebaselineing, etc.
- css/mediaControlsChromium.css:
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet): (WebCore::mediaSliderThumbImage): (WebCore::mediaVolumeSliderThumbImage): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
- 2:38 PM Changeset in webkit [48437] by
-
- 4 edits in trunk/WebCore
2009-09-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Remove style property if empty string is entered.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmouseout): fixed null pointer exception
- inspector/front-end/InjectedScript.js: (InjectedScript.applyStyleText): if styletext to apply is empty it will return an array to confirm the property removal
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
- 2:31 PM Changeset in webkit [48436] by
-
- 3 edits5 adds in trunk
2009-09-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Added a test that checks that margin property shorthand has correct value
when there is background-repeat property in the style declaration.
- fast/backgrounds/repeat/margin-shorthand-expected.txt: Added.
- fast/backgrounds/repeat/margin-shorthand.html: Added.
- fast/backgrounds/repeat/resources/TEMPLATE.html: Added.
- fast/backgrounds/repeat/resources/margin-shorthand.css: Added.
- fast/backgrounds/repeat/resources/margin-shorthand.js: Added. (iconMarginValue):
2009-09-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Always reset m_implicitShorthand to false after parsing
background-repeat style property otherwise properties
following after it may be erroneously marked as implicit.
https://bugs.webkit.org/show_bug.cgi?id=28972
https://bugs.webkit.org/show_bug.cgi?id=28973
Test: fast/backgrounds/repeat/margin-shorthand.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- 2:05 PM Changeset in webkit [48435] by
-
- 2 edits in trunk/WebKit/mac
2009-09-16 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
Work around a bug in AppKit on Leopard which causes compositing layers to jitter, and
become misplaced when the WebHTMLView is resized or scrolled sometimes.
<rdar://problem/7071636>
We call an internal AppKit method to make sure the layer geometry is updated correctly.
- WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):
- 1:40 PM Changeset in webkit [48434] by
-
- 2 edits in trunk/WebKitTools
wx build fix to support monolithic builds on Windows.
- 1:36 PM Changeset in webkit [48433] by
-
- 3 edits4 adds4 deletes in trunk
2009-09-16 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Alexey Proskuryakov.
Incorrect behavior of XMLHttpRequest::getAllResponseHeaders and XMLHttpRequest::getResponseHeader in the
HEADERS_RECEIVED readyState.
https://bugs.webkit.org/show_bug.cgi?id=29121
- http/tests/xmlhttprequest/getAllResponseHeaders-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt.
- http/tests/xmlhttprequest/getAllResponseHeaders.html: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html.
- http/tests/xmlhttprequest/getResponseHeader-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt.
- http/tests/xmlhttprequest/getResponseHeader.html: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html.
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt: Removed.
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html: Removed.
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt: Removed.
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html: Removed. Modified xmlhttprequest-InvalidStateException-getAllRequestHeaders and xmlhttprequest-InvalidStateException-getRequestHeader to match the current spec and code behavior. Extended the first test to cover other aspects of the getAllResponseHeaders method and planning the same extension for the second test. The extension for the second test is to be submitted with the patch for bug 29140. Renamed the 2 tests to a shorter more accurate name, given their new intended scope.
2009-09-16 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Alexey Proskuryakov.
Incorrect behavior of XMLHttpRequest::getAllResponseHeaders and
XMLHttpRequest::getResponseHeader in the
HEADERS_RECEIVED readyState.
https://bugs.webkit.org/show_bug.cgi?id=29121
Tests: http/tests/xmlhttprequest/getAllResponseHeaders.html
http/tests/xmlhttprequest/getResponseHeader.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): Changed the minimum valid state from LOADING to HEADERS_RECEIVED.
- 1:23 PM Changeset in webkit [48432] by
-
- 2 edits in trunk/WebCore
2009-09-16 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix style violation in V8AbstractEventListener.
https://bugs.webkit.org/show_bug.cgi?id=29303
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::operator==):
- 1:16 PM Changeset in webkit [48431] by
-
- 10 edits2 adds in trunk/WebCore
2009-09-16 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Add Watch Expression support to inspector
https://bugs.webkit.org/show_bug.cgi?id=27514
Manual test added.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update.callback): (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertiesSection.CompareProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
- inspector/front-end/WatchExpressionsSidebarPane.js: Added. (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.addExpression): (WebInspector.WatchExpressionsSection.prototype.updateExpression): (WebInspector.WatchExpressionsSection.prototype.findAddedTreeElement): (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions): (WebInspector.WatchExpressionsSection.prototype.saveExpressions): (WebInspector.WatchExpressionsSection.CompareProperties): (WebInspector.WatchExpressionTreeElement): (WebInspector.WatchExpressionTreeElement.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype._deleteButtonClicked): (WebInspector.WatchExpressionTreeElement.prototype.startEditing): (WebInspector.WatchExpressionTreeElement.prototype.editingCancelled): (WebInspector.WatchExpressionTreeElement.prototype.applyExpression):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- manual-tests/inspector/debugger-watch-expressions.html: Added.
- 12:50 PM Changeset in webkit [48430] by
-
- 46 edits1 add in trunk
Add ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=29260
Reviewed by David Kilzer.
- wtf/Platform.h:
WebCore:
No new tests. (No change in default behavior.)
- DerivedSources.make: Use new WebCore.Inspector.exp file if ENABLE_DRAG_SUPPORT.
- WebCore.base.exp: Move Inspector only exports to WebCore.Inspector.exp.
- WebCore.xcodeproj/project.pbxproj: Add WebCore.Inspector.exp.
- bindings/js/JSDOMWindowBase.cpp: Use ENABLE(INSPECTOR) where applicable.
(WebCore::JSDOMWindowBase::supportsProfiling):
- bindings/js/JSInspectedObjectWrapper.cpp: Wrap entire file in ENABLE(INSPECTOR).
- bindings/js/JSInspectorBackendCustom.cpp: Ditto.
- bindings/js/JSInspectorCallbackWrapper.cpp: Ditto.
- bindings/js/ScriptObject.cpp: Use ENABLE(INSPECTOR) where applicable.
- bindings/js/ScriptObject.h: Ditto.
- bindings/js/ScriptObjectQuarantine.cpp: Wrap entire file in ENABLE(INSPECTOR).
- dom/Document.cpp: Use ENABLE(INSPECTOR) where applicable.
(WebCore::Document::recalcStyle):
(WebCore::Document::addMessage):
(WebCore::Document::resourceRetrievedByXMLHttpRequest):
(WebCore::Document::scriptImported):
- dom/Document.h: Ditto.
- dom/Node.cpp: Ditto.
(WebCore::Node::dispatchGenericEvent):
- dom/ScriptExecutionContext.h: Ditto.
(WebCore::):
- html/HTMLDocument.cpp: Ditto.
(WebCore::HTMLDocument::createTokenizer):
- html/HTMLTokenizer.cpp: Ditto.
(WebCore::HTMLTokenizer::write):
- inspector/ConsoleMessage.cpp: Ditto.
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h: Ditto.
- inspector/DOMDispatchTimelineItem.cpp: Wrap entire file in ENABLE(INSPECTOR).
- inspector/InspectorBackend.cpp: Ditto.
- inspector/InspectorController.cpp: Ditto.
- inspector/InspectorDOMAgent.cpp: Ditto.
- inspector/InspectorDOMStorageResource.cpp: Ditto.
- inspector/InspectorDatabaseResource.cpp: Ditto.
- inspector/InspectorFrontend.cpp: Ditto.
- inspector/InspectorResource.cpp: Ditto.
- inspector/InspectorTimelineAgent.cpp: Ditto.
- inspector/TimelineItem.cpp: Ditto.
- loader/FrameLoader.cpp: Use ENABLE(INSPECTOR) where applicable.
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
(WebCore::FrameLoader::dispatchWindowObjectAvailable):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
(WebCore::FrameLoader::dispatchWillSendRequest):
(WebCore::FrameLoader::dispatchDidReceiveResponse):
(WebCore::FrameLoader::dispatchDidReceiveContentLength):
(WebCore::FrameLoader::dispatchDidFinishLoading):
- page/Chrome.cpp: Ditto.
(WebCore::Chrome::mouseDidMoveOverElement):
- page/Console.cpp: Ditto.
(WebCore::Console::addMessage):
(WebCore::Console::count):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupEnd):
- page/ContextMenuController.cpp: Ditto.
(WebCore::ContextMenuController::handleContextMenuEvent):
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/DOMWindow.cpp: Ditto.
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
- page/EventHandler.cpp: Ditto.
(WebCore::EventHandler::handleMousePressEvent):
- page/FrameView.cpp: Ditto.
(WebCore::FrameView::layout):
(WebCore::FrameView::paintContents):
- page/FrameView.h: Ditto.
- page/Page.cpp: Ditto.
(WebCore::Page::Page):
(WebCore::Page::~Page):
- page/Page.h: Ditto.
- platform/ContextMenu.cpp: Ditto.
(WebCore::ContextMenu::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h: Ditto.
(WebCore::):
- storage/Database.cpp: Ditto.
(WebCore::Database::openDatabase):
- workers/WorkerContext.cpp: Ditto.
(WebCore::WorkerContext::importScripts):
- xml/XMLHttpRequest.cpp: Ditto.
(WebCore::XMLHttpRequest::didFinishLoading):
- 12:40 PM Changeset in webkit [48429] by
-
- 21 edits1 add in trunk
Add ENABLE(CONTEXT_MENUS)
https://bugs.webkit.org/show_bug.cgi?id=29225
Reviewed by David Kilzer.
- wtf/Platform.h:
WebCore:
No new tests. (No change in default behavior.)
- DerivedSources.make: Use new WebCore.ContextMenus.exp file if ENABLE_CONTEXT_MENUS.
- WebCore.base.exp: Move ContextMenu only exports to WebCore.ContextMenus.exp.
- WebCore.xcodeproj/project.pbxproj: Add WebCore.ContextMenus.exp.
- dom/Node.cpp: Use ENABLE(CONTEXT_MENUS) where applicable.
(WebCore::Node::defaultEventHandler):
- loader/EmptyClients.h: Ditto.
- page/ContextMenuController.cpp: Wrap entire file in ENABLE(CONTEXT_MENUS).
- page/EventHandler.cpp: Use ENABLE(CONTEXT_MENUS) where applicable.
- page/EventHandler.h: Ditto.
- page/Page.cpp: Ditto.
(WebCore::Page::Page):
- page/Page.h: Ditto.
- page/mac/EventHandlerMac.mm: Ditto.
- page/mac/WebCoreViewFactory.h: Ditto.
- platform/ContextMenu.cpp: Wrap entire file in ENABLE(CONTEXT_MENUS).
- platform/LocalizedStrings.h: Use ENABLE(CONTEXT_MENUS) where applicable.
- platform/mac/ContextMenuItemMac.mm: Wrap entire file in ENABLE(CONTEXT_MENUS).
- platform/mac/ContextMenuMac.mm: Ditto.
- platform/mac/LocalizedStringsMac.mm: Use ENABLE(CONTEXT_MENUS) where applicable.
- svg/graphics/SVGImage.cpp: Ditto.
(WebCore::SVGImage::dataChanged):
- 12:37 PM Changeset in webkit [48428] by
-
- 4 edits in trunk/WebCore
Clean up invalidation for repainting. Hoist the dirty rect intersection test in ScrollViewMac up
into ScrollView so that all platforms do it.
Reviewed by Adam Roben.
Patch deferred repaints in FrameView::repaintContentRectangle to only add the visible portion of
the rectangle for repainting.
- page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
- platform/ScrollView.cpp:
(WebCore::ScrollView::repaintContentRectangle):
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformRepaintContentRectangle):
- 12:29 PM Changeset in webkit [48427] by
-
- 3 edits in trunk/JavaScriptCore
2009-09-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Eric Seidel.
The webkit stdint and stdbool headers exists because
the compiler MSVC doesn't include them. The check
should not check for PLATFORM(WIN_OS) but for MSVC.
- os-win32/stdbool.h:
- os-win32/stdint.h:
- 12:10 PM Changeset in webkit [48426] by
-
- 25 edits1 add in trunk
Add ENABLE(DRAG_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=29233
Reviewed by David Kilzer.
- wtf/Platform.h:
WebCore:
No new tests. (No change in default behavior.)
- DerivedSources.make: Use new WebCore.DragSupport.exp file if ENABLE_DRAG_SUPPORT.
- WebCore.base.exp: Move Drag Support only exports to WebCore.DragSupport.exp.
- WebCore.xcodeproj/project.pbxproj: Add WebCore.DragSupport.exp.
- dom/Clipboard.h: Use ENABLE(DRAG_SUPPORT) where applicable.
- loader/EmptyClients.h: Ditto.
- page/DragController.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
- page/EventHandler.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
- page/EventHandler.h: Ditto.
- page/Page.cpp: Ditto.
(WebCore::Page::Page):
- page/Page.h: Ditto.
- page/mac/DragControllerMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
- page/mac/EventHandlerMac.mm: Use ENABLE(DRAG_SUPPORT) where applicable.
(WebCore::EventHandler::passSubframeEventToSubframe):
- platform/DragData.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
- platform/DragImage.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
- platform/mac/ClipboardMac.h: Use ENABLE(DRAG_SUPPORT) where applicable.
- platform/mac/ClipboardMac.mm: Ditto.
- platform/mac/DragDataMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
- platform/mac/DragImageMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
- rendering/RenderLayer.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.
(WebCore::RenderLayer::autoscroll):
- rendering/RenderObject.cpp: Ditto.
- rendering/RenderObject.h: Ditto.
- svg/graphics/SVGImage.cpp: Ditto.
(WebCore::SVGImage::dataChanged):
- 12:02 PM Changeset in webkit [48425] by
-
- 3 edits in trunk/WebCore
wxMSW build fix after adding support for high resolution times in Win.
- 10:55 AM Changeset in webkit [48424] by
-
- 2 edits in trunk/JavaScriptCore
waf build fix after flag was moved to correct place.
- 10:25 AM Changeset in webkit [48423] by
-
- 2 edits in trunk/WebKit/qt
Rubberstamped by Kenneth Christiansen.
Patch by Andras Becsi <andrewbecsi@yahoo.co.uk> on 2009-09-16
[Qt] Build fix for previous changes.
- QGVLauncher/main.cpp:
(MainView::flip):
- 9:59 AM Changeset in webkit [48422] by
-
- 3 edits in trunk/WebKitTools
wx build fix, improve debug support and 2.9 support on MSW.
- 9:11 AM Changeset in webkit [48421] by
-
- 2 edits in trunk/WebKit/qt
Unreviewed potential Qt < 4.6 build fix.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-16
- QGVLauncher/main.cpp:
(MainView::flip):
- 8:55 AM Changeset in webkit [48420] by
-
- 2 edits in trunk/WebKitTools
2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Blind try at fixing new test failure on Windows.
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didReceiveTitle):
- 8:20 AM Changeset in webkit [48419] by
-
- 2 edits in trunk/LayoutTests
2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
One more try at rebaselining the tests for those who dump frame
loader delegates.
- http/tests/loading/redirect-with-no-location-crash-expected.txt:
- 7:29 AM Changeset in webkit [48418] by
-
- 3 edits in trunk/WebCore
2009-09-16 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Added operator==() to event listeners. This fixes V8 bindings
build broken in http://trac.webkit.org/changeset/48402.
https://bugs.webkit.org/show_bug.cgi?id=29298
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Now uses JSEventListenerType.
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::operator==): Only compares pointers since we create at most one wrapper for a JS object.
- 7:29 AM Changeset in webkit [48417] by
-
- 2 edits1 copy3 adds in trunk/LayoutTests
2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Rebaseline for those who support dumping of frame
loader delegates, add specific expected result to GTK+
- http/tests/loading/redirect-with-no-location-crash-expected.txt:
- platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Copied from LayoutTests/http/tests/loading/redirect-with-no-location-crash-expected.txt.
- 6:49 AM Changeset in webkit [48416] by
-
- 2 edits in trunk/WebKit/qt
Add a "Flip effect" to our GraphicsView based launcher.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-16
Reviewed by Simon Hausmann.
- QGVLauncher/main.cpp:
(MainView::resizeEvent):
(MainView::flip):
(MainWindow::flip):
(MainWindow::buildUI):
- 6:46 AM Changeset in webkit [48415] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Build fix for 64-bit Qt on Mac OS X
Reviewed by Simon Hausmann.
- wtf/Platform.h: Use JSVALUE64 on DARWIN, not only on MAC
- 6:40 AM Changeset in webkit [48414] by
-
- 2 edits in trunk/WebKit/qt
2009-09-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Rubber-stamped by Simon Hausmann.
[Qt] Typo fix. Pass the window object to the Format
menu. In this way Qt can free its internal graphical
objects during exit.
- QtLauncher/main.cpp: (MainWindow::setupUI):
- 6:37 AM Changeset in webkit [48413] by
-
- 3 edits3 adds in trunk
WebCore:
2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Crash when visiting http://flipper.googlelabs.com/
https://bugs.webkit.org/show_bug.cgi?id=29293
Check type for being null or empty before looking it up in the
hash of supported types.
Tested by http/tests/loading/redirect-with-no-location-crash.html
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):
LayoutTests:
2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Crash when visiting http://flipper.googlelabs.com/
https://bugs.webkit.org/show_bug.cgi?id=29293
- http/tests/loading/redirect-with-no-location-crash.html: Added.
- http/tests/loading/redirect-with-no-location-crash-expected.html: Added.
- http/tests/loading/resources/redirect-with-no-location-crash.php: Added.
- 6:18 AM Changeset in webkit [48412] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Fix wtf/ThreadSpecific.h under Qt to free thread local objects.
https://bugs.webkit.org/show_bug.cgi?id=29295
This is an important fix when JavaScript workers are in use, since
unfreed ThreadGlobalDatas leak a big amount of memory (50-100k each).
QThreadStorage calls the destructor of a given object, which is the
ThreadSpecific::Data. Unlike pthread, Qt is object oriented, and does
not support the calling of a static utility function when the thread
is about to close. In this patch we call the ThreadSpecific::destroy()
utility function from the destructor of ThreadSpecific::Data. Moreover,
since Qt resets all thread local values to 0 before the calling of the
appropriate destructors, we set back the pointer to its original value.
This is necessary because the get() method of the ThreadSpecific
object may be called during the exuction of the destructor.
- wtf/ThreadSpecific.h: (WTF::ThreadSpecific::Data::~Data): (WTF::::~ThreadSpecific): (WTF::::set): (WTF::::destroy):
- 4:50 AM Changeset in webkit [48411] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Build break fix on gcc ARM.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-16
Reviewed by Tor Arne Vestbø.
- Api/qwebgraphicsitem.cpp:
(QWebGraphicsItemPrivate::_q_doLoadProgress):
- 1:58 AM Changeset in webkit [48410] by
-
- 2 edits in trunk/WebKit/qt
Fix a crash in QWebFrame::hasFocus() with a simple null pointer check
when the focused frame is null. We do the same check in other places
where we call kit().
Patch by Warwick Allison <warwick.allison@nokia.com> on 2009-09-16
Reviewed by Simon Hausmann.
- Api/qwebframe.cpp:
(QWebFrame::hasFocus):
- 1:56 AM Changeset in webkit [48409] by
-
- 2 edits in trunk/WebKit/qt
Fixed a typo found during translation.
Patch by Jure Repinc <jlp@holodeck1.com> on 2009-09-16
Reviewed by Simon Hausmann.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):
