⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 18, 2009:

8:46 PM Changeset in webkit [48547] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-09-18 Simon Fraser <Simon Fraser>

Fix stylistic issue raised in code review for previous commit.

  • rendering/RenderLayerBacking.cpp: (WebCore::hasNonZeroTransformOrigin):
8:44 PM Changeset in webkit [48546] by Simon Fraser
  • 5 edits
    4 adds in trunk

2009-09-18 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Element is misplaced during opacity transition with certain configuration of transform-origin and clipping
​https://bugs.webkit.org/show_bug.cgi?id=29495

If an element has zero size, but has a transform origin with absolute values,
then the transform origin would not be applied because it is implemented via
anchorPoint, which is expressed as a fraction of the layer size.

Work around this by artificially inflating the size of the backing store when we need to.

Test: compositing/geometry/transfrom-origin-on-zero-size-layer.html

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): Init m_artificiallyInflatedBounds to false.

(WebCore::hasNonZeroTransformOrigin):
Utility function that describes whether the transform-origin contains non-percentage
x or y offsets.

(WebCore::RenderLayerBacking::updateCompositedBounds):
New wrapper method around setCompositedBounds() that applies the size inflation
when necessary, setting the m_artificiallyInflatedBounds as appropriate.

(WebCore::RenderLayerBacking::updateAfterLayout): Call updateCompositedBounds().
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Ditto

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Ditto (WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry): Ditto
6:19 PM Changeset in webkit [48545] by Antti Koivisto
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=29512
Don't recalculate style when restoring from the page cache

Patch by Antti Koivisto <Antti Koivisto> on 2009-09-18
Reviewed by Maciej Stachowiak.

FrameLoaderClient::forceLayout() also forces style recalc. Instead call FrameView::forceLayout()
directly to update the scrollbars while keeping the existing style.

Makes back/forward really fast on complex pages (in cases where page cache works).

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

5:21 PM Changeset in webkit [48544] by kevino@webkit.org
  • 3 edits in trunk/WebKitTools

wx build fixes. Fix the config name under git and allow users to specify
their own waf install for experimenting with new versions.

5:18 PM Changeset in webkit [48543] by atwilson@chromium.org
  • 3 edits in trunk/LayoutTests

REGRESSION: fast/workers/worker-cloneport.html failing intermttently on leopard bot
​https://bugs.webkit.org/show_bug.cgi?id=29341

Reviewed by Eric Seidel.

  • fast/workers/worker-cloneport-expected.txt:

Updated to reflect new output (lower clone count threshold).

  • fast/workers/worker-cloneport.html:

Updated test to have a more lenient performance requirement and timeout, to address flakiness on Leopard and Chromium.

4:12 PM Changeset in webkit [48542] by oliver@apple.com
  • 25 edits
    6 adds in trunk

Implement ES5 Object.defineProperty function
​https://bugs.webkit.org/show_bug.cgi?id=29503

Reviewed by Geoff Garen

Implement Object.defineProperty. This requires adding the API to
ObjectConstructor, along with a helper function that implements the
ES5 internal ToPropertyDescriptor function. It then adds
JSObject::defineOwnProperty that implements the appropriate ES5 semantics.
Currently defineOwnProperty uses a delete followed by a put to redefine
attributes of a property, clearly this is less efficient than it could be
but we can improve this if it needs to be possible in future.

3:25 PM Changeset in webkit [48541] by beidson@apple.com
  • 8 edits in trunk/LayoutTests

Speculative fix for:
​https://bugs.webkit.org/show_bug.cgi?id=29322
and
​https://bugs.webkit.org/show_bug.cgi?id=29505

Reviewed by Alexey Proskuryakov.

Adding a "Connection: close" header might make the tests work more reliably,
and doesn't seem to make anything worse: They all continue to pass on my machine!

  • http/tests/loading/resources/basic-auth-testing.php:
  • http/tests/loading/resources/othersubresources/protected-resource.php:
  • http/tests/loading/resources/protected-resource.php:
  • http/tests/loading/resources/subresources/protected-resource.php:
  • http/tests/xmlhttprequest/resources/cross-origin-authorization.php:
  • http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php:
  • http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php:
3:24 PM Changeset in webkit [48540] by ap@apple.com
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=29510
Active DOM objects should be suspended while a modal dialog is displayed

  • manual-tests/js-timers-beneath-modal-dialog.html: Added a test for JS timers.
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Match other platforms, and make Mac also suspend active DOM objects. Since a page that currently displays a modal dialog cannot go into page cache, there is no danger of suspending an object twice.
3:20 PM Changeset in webkit [48539] by eric@webkit.org
  • 28 edits in trunk/LayoutTests

2009-09-18 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

Media layout tests should have a way to provide test files in different formats
​https://bugs.webkit.org/show_bug.cgi?id=28327

Updating 25 media layout tests to use media files based on supported codecs.

  • media/progress-event-at-least-one.html: Use findMediaFile() to locate a supported media file.
  • media/video-pause-empty-events.html: ditto.
  • media/video-play-empty-events.html: ditto.
  • media/video-play-pause-events.html: ditto.
  • media/video-played-collapse.html: ditto.
  • media/video-played-ranges-1.html: ditto.
  • media/video-played-reset.html: ditto.
  • media/video-played.js: ditto. (videoPlayedMain):
  • media/video-seek-past-end-paused.html: ditto.
  • media/video-seek-past-end-playing.html: ditto.
  • media/video-seekable.html: ditto.
  • media/video-seeking.html: ditto.
  • media/video-size.html: ditto.
  • media/video-source-error.html: ditto.
  • media/video-source-type-params.html: ditto.
  • media/video-source-type.html: ditto.
  • media/video-source.html: ditto.
  • media/video-src-change.html: ditto.
  • media/video-src-invalid-remove.html: ditto.
  • media/video-src-remove.html: ditto. Use counting.mp4 instead of silence.mpg.
  • media/video-src-remove-expected.txt: Updated results.
  • media/video-src-set.html: ditto.
  • media/video-src-source.html: ditto.
  • media/video-src.html: ditto.
  • media/video-timeupdate-during-playback.html: ditto.
  • media/video-volume.html: ditto.
  • media/video-zoom.html: ditto.
3:12 PM Changeset in webkit [48538] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-09-18 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[Qt] Buildfix caused by ​http://trac.webkit.org/changeset/48513
​https://bugs.webkit.org/show_bug.cgi?id=29351

  • bridge/qt/qt_instance.h: createRuntimeObject method renamed to newRuntimeObject.
  • bridge/runtime.h: Visibility of newRuntimeObject method modified to protected.
3:04 PM Changeset in webkit [48537] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add failing tests to the skipped list.

  • platform/mac-snowleopard/Skipped:
2:58 PM Changeset in webkit [48536] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-09-18 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

Fix parameter substitutions in console.log().

​https://bugs.webkit.org/show_bug.cgi?id=29366

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
  • inspector/front-end/InjectedScript.js: (InjectedScript.getPrototypes): (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
  • inspector/front-end/utilities.js: ():
2:39 PM Changeset in webkit [48535] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

2:36 PM Changeset in webkit [48534] by mrowe@apple.com
  • 1 copy in tags/Safari-532.0

New tag.

2:34 PM Changeset in webkit [48533] by weinig@apple.com
  • 2 edits in trunk/WebCore

Temporarily remove an assertion that was getting hit when going
back to a page in the page cache while a banner in Safari was visible.
We should re-enable this once that is fixed. See <rdar://problem/7218118>

Reviewed by Geoffrey Garen and Brady Eidson.

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayout):

2:28 PM Changeset in webkit [48532] by andersca@apple.com
  • 2 edits in trunk/WebCore

Try fixing the build again.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::wndProc):

2:23 PM Changeset in webkit [48531] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix windows build.

  • platform/win/PopupMenuWin.cpp:
1:56 PM Changeset in webkit [48530] by weinig@apple.com
  • 3 edits in trunk/WebCore

Convert another callback type object to store the global object
instead of the frame.

Reviewed by Gavin 'BearClaw' Barraclough.

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::create):
(WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver):
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSCustomXPathNSResolver.h:
1:52 PM Changeset in webkit [48529] by andersca@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=29332
<rdar://problem/7231652>
REGRESSION (r48446): While a <select> popup menu is open, the
rest of the WebView doesn't respond to mouse move events.

Reviewed by Sam Weinig.

  • platform/win/PopupMenuWin.cpp:

(WebCore::translatePoint):
New helper function that translates a point between HWND coordinates.

(WebCore::PopupMenu::show):
Protect the PopupMenu if someone removes the <select> in response to a mouse
event. Handle WM_HOST_WINDOW_MOUSEMOVE events.

(WebCore::PopupMenu::wndProc):
in the WM_MOUSEMOVE handler, if the mouse is not over the popup, post a
WM_HOST_WINDOW_MOUSEMOVE event so that the host window (the WebView) gets the
mouse move event.

1:49 PM Changeset in webkit [48528] by eric@webkit.org
  • 12 edits in trunk/WebKit/qt

2009-09-18 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Eric Seidel.

Corrected the Symbian specific UID3 values to be assigned
from the "unprotected" pool that permits self-signing of
those test and demo executables. (Added new UID3 values
where they were missing for new components.)

  • QGVLauncher/QGVLauncher.pro:
  • QtLauncher/QtLauncher.pro:
  • tests/benchmarks/loading/tst_loading.pro:
  • tests/benchmarks/painting/tst_painting.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:
  • tests/qwebview/qwebview.pro:
1:35 PM Changeset in webkit [48527] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-09-18 Gabor Loki <​loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Build fix to enable ARM_THUMB2 on Linux
​https://bugs.webkit.org/show_bug.cgi?id=

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • jit/JITStubs.cpp:
  • wtf/Platform.h:
1:30 PM Changeset in webkit [48526] by Simon Fraser
  • 7 edits
    4 adds in trunk

2009-09-18 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Compositing layers are incorrectly positioned after scrolling with position:fixed
​https://bugs.webkit.org/show_bug.cgi?id=29262

When scrolling a page with compositing layers inside a position:fixed element,
we need to update the compositing layer positions when the scroll position changes.

Test: compositing/geometry/fixed-position.html

  • WebCore.base.exp: Export FrameView::scrollPositionChanged()
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged): New method that sends the scroll event, and updates compositing layers positions if necessary.
1:18 PM Changeset in webkit [48525] by barraclough@apple.com
  • 16 edits in trunk/JavaScriptCore

2009-09-18 Gabor Loki <​loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
​https://bugs.webkit.org/show_bug.cgi?id=29122

Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
when Thumb-2 instruction set is the required target. The
PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
case where the code is common the PLATFORM(ARM) have to be used.

  • assembler/ARMAssembler.cpp:
  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.cpp:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
  • jit/ExecutableAllocator.h:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::beginUninterruptedSequence): (JSC::JIT::preserveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn): (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline):
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • jit/JITStubs.h:
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter):
1:15 PM Changeset in webkit [48524] by Simon Fraser
  • 4 edits
    4 adds in trunk

2009-09-18 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Transformed elements inside position:fixed container are clipped incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=29346

Fix clipping and hit testing on transformed elements inside a position:fixed element.
Previously, the code used the overflowClipRect of the parent clip rects, but
this is not correct for fixed postion elements. Instead, share code that is
already present in calculateRects() to get the correct rect.

Test: fast/overflow/position-fixed-transform-clipping.html

  • rendering/RenderLayer.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): Call the new backgroundClipRect() to get the correct clipRect.

(WebCore::RenderLayer::backgroundClipRect):
New method, factored out of calculateRects(), that computes the clip rect,
doing the right thing for fixed position elements.

(WebCore::RenderLayer::calculateRects):
Call the new backgroundClipRect() method.

12:41 PM Changeset in webkit [48523] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated test result for <rdar://problem/7050773>

  • platform/mac/accessibility/document-attributes-expected.txt:
12:06 PM Changeset in webkit [48522] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-09-18 Alex Milowski <​alex@milowski.com>

Reviewed by Maciej Stachowiak.

Added checkWebCoreMathMLSupport and hasMathMLSupport to support
checking for whether MathML tests should be run

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
12:00 PM Changeset in webkit [48521] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore: Fix <rdar://problem/7050773> REGRESSION (r40098) Crash at
WebCore::RenderBlock::layoutBlock()
​https://bugs.webkit.org/show_bug.cgi?id=29498

Reviewed by Darin Adler.

Test: accessibility/nested-layout-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::updateBackingStore): Changed to

call Document::updateLayoutIgnorePendingStylesheets() instead of
calling RenderObject::layoutIfNeeded(). The latter requires that
there be no pending style recalc, which allows methods that call
Document::updateLayout() to be called during layout without risking
re-entry into layout.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityActionNames]): Null-check

m_object after calling updateBackingStore(), since style recalc may
destroy the renderer, which destroys the accessibility object and
detaches it from the wrapper.

(-[AccessibilityObjectWrapper accessibilityAttributeNames]): Ditto.
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityFocusedUIElement]): Ditto.
(-[AccessibilityObjectWrapper accessibilityHitTest:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityIsIgnored]): Ditto.
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityPerformPressAction]): Ditto.
(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityPerformAction:]): Ditto.
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityIndexOfChild:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

Ditto.

LayoutTests: Test for <rdar://problem/7050773> REGRESSION (r40098) Crash at
WebCore::RenderBlock::layoutBlock()
​https://bugs.webkit.org/show_bug.cgi?id=29498

Reviewed by Darin Adler.

  • accessibility/nested-layout-crash-expected.txt: Added.
  • accessibility/nested-layout-crash.html: Added.
11:57 AM Changeset in webkit [48520] by eric@webkit.org
  • 2 edits
    3 adds in trunk/WebCore

2009-09-18 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Simon Hausmann.

Update Qt build system for Web Socket.
​https://bugs.webkit.org/show_bug.cgi?id=29270

  • WebCore.pro:
  • platform/network/qt/SocketStreamError.h: Added.
  • platform/network/qt/SocketStreamHandle.h: Added.
  • platform/network/qt/SocketStreamHandleSoup.cpp: Added.
11:45 AM Changeset in webkit [48519] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-09-18 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

NULL check HTMLMediaElement::m_playedTimeRanges.
Fix for ​https://bugs.webkit.org/show_bug.cgi?id=29494

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::addPlayedRange): New. Create m_playedTimeRanges if necessary, add range specified. (WebCore::HTMLMediaElement::seek): Use addPlayedRange. (WebCore::HTMLMediaElement::played): Use addPlayedRange. Change time comparison to be more readable. (WebCore::HTMLMediaElement::updatePlayState): Ditto.
  • html/HTMLMediaElement.h:
11:30 AM Changeset in webkit [48518] by xan@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk

2009-09-18 Xan Lopez <​xlopez@igalia.com>

Build fix.

Add missing file to the repository.

  • tests/testhittestresult.c: Added. (test_info_new): (test_info_destroy): (hit_test_result_fixture_setup): (hit_test_result_fixture_teardown): (load_status_cb): (test_webkit_hit_test_result): (main):
11:17 AM Changeset in webkit [48517] by Darin Adler
  • 1 edit in trunk/WebKitTools/ChangeLog

Added bug number.

11:16 AM Changeset in webkit [48516] by Darin Adler
  • 2 edits in trunk/WebKitTools

Some small steps toward improving run-webkit-tests. My goal is to
refactor much more of the script into functions. Later we can add
parallel test running to the tool. But better structure may help
even if someone decides to translate this into another scripting
language instead.

Patch by Darin Adler <Darin Adler> on 2009-08-28
Reviewed by Mark Rowe.

  • Scripts/run-webkit-tests: Break more pieces of the script into

seprate functions. Added readSkippedFiles, findTestsToRun, and
printResults functions. Removed custom code to skip results.html
and instead just put it into the ignoredFiles hash. Fixed some
indentation. Sorted function declarations, global variables,
and options at the top of the file alphabetically so they're not
in a semi-random order.

11:01 AM Changeset in webkit [48515] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Follow up fix for ​https://bugs.webkit.org/show_bug.cgi?id=29276
REGRESSION(r48334): WebKit crashes on file select by drag

Reviewed by Adele Peterson.

Don't use Document.elementFromPoint since it returns null if the point
is outside the viewport. Instead, just hit test ourselves.

Test: fast/events/drag-file-crash.html

  • page/DragController.cpp:

(WebCore::elementUnderMouse):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=29276
REGRESSION(r48334): WebKit crashes on file select by drag

Reviewed by Adele Peterson.

  • fast/events/drag-file-crash-expected.txt: Added.
  • fast/events/drag-file-crash.html: Added.
10:48 AM Changeset in webkit [48514] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fix date on a change log entry.

10:48 AM Changeset in webkit [48513] by Darin Adler
  • 11 edits in trunk/WebCore

Each wrapped Objective-C object should use a single RuntimeObjectImp
​https://bugs.webkit.org/show_bug.cgi?id=29351
rdar://problem/7142294

Patch by Darin Adler <Darin Adler> on 2009-09-18
Reviewed by Sam Weinig.

  • WebCore.base.exp: Added a newly-needed exported symbol.
  • bindings/objc/DOMInternal.h: Eliminated unused

createWrapperCacheWithIntegerKeys; it has not been needed since the
RGBColor wrappers were reworked.

  • bindings/objc/DOMInternal.mm: Ditto.
  • bridge/objc/objc_instance.h: Made the create function non-inline.
  • bridge/objc/objc_instance.mm:

(createInstanceWrapperCache): Added. Creates an appropriate map table.
(ObjcInstance::create): Moved here from header. Uses NSMapGet and
NSMapInsert to cache the instance in a map table.
(ObjcInstance::~ObjcInstance): Added a call to NSMapRemove to remove
the instance from the map table.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::~QtInstance): Remove unneeded code to remove
the instance from cachedObjects, which no longer exists.
(JSC::Bindings::QtInstance::newRuntimeObject): Renamed to overload new
bottleneck. Caching is now handled by the base class.

  • bridge/runtime.cpp:

(JSC::Bindings::Instance::Instance): Initialize m_runtimeObject to 0.
(JSC::Bindings::Instance::~Instance): Assert m_runtimeObject is 0.
(JSC::Bindings::Instance::createRuntimeObject): Use m_runtimeObject
if it's already set. Set m_runtimeObject and call addRuntimeObject
if it's not.
(JSC::Bindings::Instance::newRuntimeObject): Added. Virtual function,
used only by createRuntimeObject.
(JSC::Bindings::Instance::willDestroyRuntimeObject): Added.
Calls removeRuntimeObject and then clears m_runtimeObject.
(JSC::Bindings::Instance::willInvalidateRuntimeObject): Added.
Clears m_runtimeObject.

  • bridge/runtime.h: Made createRuntimeObject non-virtual. Added

willDestroyRuntimeObject, willInvalidateRuntimeObject,
newRuntimeObject, and m_runtimeObject.

  • bridge/runtime_object.cpp:

(JSC::RuntimeObjectImp::RuntimeObjectImp): Removed addRuntimeObject
call, now handled by caller.
(JSC::RuntimeObjectImp::~RuntimeObjectImp): Replaced removeRuntimeObject
call with willDestroyRuntimeObject call; the latter nows calls
removeRuntimeObject.
(JSC::RuntimeObjectImp::invalidate): Added willInvalidateRuntimeObject
call.

  • bridge/runtime_object.h: Made invalidate non-virtual.
10:46 AM Changeset in webkit [48512] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/gtk

[Gtk] Unreviewed build fix.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-18

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::platformPageClient):

10:34 AM Changeset in webkit [48511] by kenneth@webkit.org
  • 47 edits in trunk

Make PlatformWindow return something else than PlatformWidget
​https://bugs.webkit.org/show_bug.cgi?id=29085

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-17
Reviewed by Simon Hausmann.

WebCore:

Make platformWindow return a PlatformPageClient
(for now typedef'ed to PlatformWidget)

Also, change the name of platformWindow to platformPageClient()

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(getPangoLayoutForAtk):

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::platformPageClient):

  • page/Chrome.cpp:

(WebCore::Chrome::platformPageClient):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::currentPlatformMouseEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):

  • platform/HostWindow.h:
  • platform/Widget.h:
  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::getVisual):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenu::show):

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::platformAddChild):
(WebCore::ScrollView::platformRemoveChild):
(WebCore::ScrollView::visibleContentRect):

  • platform/gtk/WidgetGtk.cpp:

(WebCore::Widget::setFocus):
(WebCore::Widget::setCursor):

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/qt/PopupMenuQt.cpp:

(WebCore::PopupMenu::show):

  • platform/qt/WidgetQt.cpp:

(WebCore::Widget::setCursor):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::monitorInfoForWidget):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::wndProc):

  • platform/wx/RenderThemeWx.cpp:

(WebCore::nativeWindowForRenderObject):

  • platform/wx/ScrollbarThemeWx.cpp:

(WebCore::ScrollbarThemeWx::paint):

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::platformStart):

  • plugins/mac/PluginViewMac.cpp:

(WebCore::PluginView::platformStart):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::getValue):
(WebCore::PluginView::platformStart):

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::platformStart):

WebKit/gtk:

Reflect the rename of platformWindow and it's return type.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::platformPageClient):
(WebKit::ChromeClient::runOpenPanel):

  • WebCoreSupport/ChromeClientGtk.h:
  • webkit/webkitprivate.cpp:

(currentToplevelCallback):

  • webkit/webkitwebview.cpp:

(webkit_web_view_popup_menu_handler):

WebKit/haiku:

Reflect the rename of platformWindow and it's return type.

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::platformPageClient):

  • WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac:

Reflect the rename of platformWindow and it's return type.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::platformPageClient):

WebKit/qt:

Reflect the rename of platformWindow and it's return type.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::platformPageClient):

  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Reflect the rename of platformWindow and it's return type.

  • AccessibleBase.cpp:

(AccessibleBase::get_accParent):

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::platformPageClient):

  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

Reflect the rename of platformWindow and it's return type.

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::platformPageClient):

  • WebKitSupport/ChromeClientWx.h:
  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::isEditable):
(WebCore::EditorClientWx::registerCommandForUndo):
(WebCore::EditorClientWx::registerCommandForRedo):
(WebCore::EditorClientWx::clearUndoRedoOperations):
(WebCore::EditorClientWx::canUndo):
(WebCore::EditorClientWx::canRedo):
(WebCore::EditorClientWx::undo):
(WebCore::EditorClientWx::redo):

8:47 AM Changeset in webkit [48510] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Web inspector UI adjustments specific to the Qt platform:

  • Hide the close button
  • Hide the dock button
  • Disable the draggable toolbar

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=29384

  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js:

(WebInspector.toolbarDragStart):

8:34 AM Changeset in webkit [48509] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

Fix the Qt/Windows CE build.

Patch by Joerg Bornemann <​joerg.bornemann@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

within Qt externally.

  • wtf/DateMath.cpp: Removed unnecessary Qt #ifdef, for the

Qt build these functions are no external, too.

7:28 AM Changeset in webkit [48508] by Simon Hausmann
  • 6 edits in trunk/WebCore

QtWebKit Windows CE compile fixes

Patch by Joerg Bornemann <​joerg.bornemann@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

Exclude certain pure-WINCE specific code paths from the Qt build.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/text/TextEncodingRegistry.cpp:

(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):

  • plugins/PluginView.cpp:

(WebCore::PluginView::stop): Guard this code block with NETSCAPE_PLUGIN_API as
the corresponding PluginViewWndProc has the same guard in the header file.

7:08 AM Changeset in webkit [48507] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-09-18 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

Document webkit_web_view_stop_loading.

  • webkit/webkitwebview.cpp:
6:53 AM Changeset in webkit [48506] by xan@webkit.org
  • 5 edits in trunk

2009-09-18 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.

[GTK] context menu overriding API is very limited
​https://bugs.webkit.org/show_bug.cgi?id=27546

Add new tests to the build.

  • GNUmakefile.am:

WebKit/gtk:

2009-09-18 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.

[GTK] context menu overriding API is very limited
​https://bugs.webkit.org/show_bug.cgi?id=27546

Add webkit_web_view_get_hit_test_result, a function to get a hit
test result from a GdkEventButton. Useful to let applications
decide between several actions on button press depending on what
is being pressed.

  • webkit/webkitwebview.cpp: (webkit_web_view_stop_loading): (documentPointForWindowPoint): (webkit_web_view_get_hit_test_result):
  • webkit/webkitwebview.h:
6:53 AM Changeset in webkit [48505] by xan@webkit.org
  • 7 edits
    2 adds in trunk

2009-09-14 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.

[GTK] context menu overriding API is very limited
​https://bugs.webkit.org/show_bug.cgi?id=27546

Add WebKitHitTestResult to the build.

  • GNUmakefile.am:

WebKit/gtk:

2009-09-18 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.

[GTK] context menu overriding API is very limited
​https://bugs.webkit.org/show_bug.cgi?id=27546

Add WebKitHitTestResult, a wrapper over HitTestResult. It contains
context information about a point in the web page.

  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkithittestresult.cpp: Added. (webkit_hit_test_result_finalize): (webkit_hit_test_result_get_property): (webkit_hit_test_result_set_property): (webkit_hit_test_result_class_init): (webkit_hit_test_result_init):
  • webkit/webkithittestresult.h: Added.
  • webkit/webkitprivate.cpp: (WebKit::kit):
  • webkit/webkitprivate.h:
6:01 AM Changeset in webkit [48504] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

[Qt] Add persistence support for configuration options in the
inspector.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

  • Api/qwebinspector.cpp:
  • QtLauncher/main.cpp:

(main):

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::populateSetting):
(WebCore::InspectorClientQt::storeSetting):
(WebCore::variantToSetting):
(WebCore::settingToVariant):

2:35 AM Changeset in webkit [48503] by eric@webkit.org
  • 6 edits in trunk

2009-09-18 Steve Block <​steveblock@google.com>

Reviewed by Dimitri Glazkov.

Geolocation does not correctly handle Infinity for PositionOptions properties.
​https://bugs.webkit.org/show_bug.cgi?id=29099

  • fast/dom/Geolocation/resources/argument-types.js: Modified. Test passing positive and negative Infinity to Geolocation methods.
  • fast/dom/Geolocation/argument-types-expected.txt: Modified. Expected result for above test.

2009-09-18 Steve Block <​steveblock@google.com>

Reviewed by Dimitri Glazkov.

Geolocation does not correctly handle Infinity for PositionOptions properties.
​https://bugs.webkit.org/show_bug.cgi?id=29099

  • bindings/js/JSGeolocationCustom.cpp: Modified. (WebCore::createPositionOptions): Modified. If timeout or maximumAge is positive infinity, applies these values as a special case.
  • page/PositionOptions.h: Modified. (WebCore::PositionOptions::hasMaximumAge): Added. Determines whether the object has a maximum age. (WebCore::PositionOptions::maximumAge): Modified. Asserts that the object has a maximum age. (WebCore::PositionOptions::clearMaximumAge): Added. Clears the maximum age. (WebCore::PositionOptions::setMaximumAge): Modified. Registers that the maximum age has been set. (WebCore::PositionOptions::PositionOptions): Modified. Registers that the maximum age has been set.
2:18 AM Changeset in webkit [48502] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Fixed a bunch of documentation warnings.

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2009-09-18
Reviewed by Ariya Hidayat.

  • Api/qwebgraphicsitem.cpp:
  • Api/qwebplugindatabase.cpp:
  • Api/qwebpluginfactory.cpp:
  • Api/qwebsecurityorigin.cpp:
1:45 AM Changeset in webkit [48501] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Added a test that console output works.

Patch by Warwick Allison <​warwick.allison@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

  • tests/qwebpage/tst_qwebpage.cpp:

(ConsolePage::ConsolePage):
(ConsolePage::javaScriptConsoleMessage):
(tst_QWebPage::consoleOutput):

Sep 17, 2009:

10:21 PM Changeset in webkit [48500] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=29276
REGRESSION(r48334): WebKit crashes on file select by drag

Reviewed by Adele Peterson.

Document.elementFromPoint now takes point in client space, not page space.

  • page/DragController.cpp:

(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

6:32 PM Changeset in webkit [48499] by ajwong@chromium.org
  • 5 edits in trunk/WebCore

2009-09-17 Albert J. Wong <​ajwong@chromium.org>

Reviewed by David Levin.

Reimplement default media UI for Mac Chromium to match the style
of the Windows and Linux versions. Also breaks the dependency
on the internal wk* functions that were previously used to
render the media controller widgets.
​https://bugs.webkit.org/show_bug.cgi?id=29161

No media layout tests are currently enabled in Mac Chromium, so
nothing needs rebaselineing, etc.

This is a recommit of r48438 with a compile fix and merges of
recent changes to the file.

  • css/mediaControlsChromium.css:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet): (WebCore::mediaSliderThumbImage): (WebCore::mediaVolumeSliderThumbImage): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
5:06 PM Changeset in webkit [48498] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-09-17 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Steve Falkenburg.

Add failing test on both Windows Debug and Release to the
Windows Skipped List.


http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html is
being tracked by <​https://bugs.webkit.org/show_bug.cgi?id=29353>.

  • platform/win/Skipped:
4:59 PM Changeset in webkit [48497] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-09-17 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Timothy Hatcher.

The Console scope bar should have a divider between All and the other possible
values (Errors, Warnings, Logs). It will look something like:


All | Errors Warnings Logs.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createDividerElement): (WebInspector.ConsoleView):
  • inspector/front-end/inspector.css:
4:03 PM Changeset in webkit [48496] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

2009-09-17 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Adam Roben.

Remove assertions that were being hit by calls to
m_verticalScrollbar->invalidate(). These assertions were valid,
but they were causing tests to fail, so replacing with a FIXME
until we can find out the real cause/solution that is being tracked
by ​http://webkit.org/b/29350.

  • WebView.cpp: (WebView::addToDirtyRegion): (WebView::paintIntoBackingStore):
3:54 PM Changeset in webkit [48495] by weinig@apple.com
  • 3 edits in trunk/WebCore

Remove additional references to JSVoidCallback which no longer exists.

Reviewed by Mark Rowe.

  • DerivedSources.cpp:
  • WebCore.vcproj/WebCore.vcproj:
3:48 PM Changeset in webkit [48494] by eric@webkit.org
  • 21 edits in trunk/LayoutTests

2009-09-17 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

Media layout tests should have a way to provide test files in different formats
​https://bugs.webkit.org/show_bug.cgi?id=28327

Updating 19 media layout tests to use media files based on supported codecs.

  • media/media-file.js: Prefer .wav over other formats as this is used the most in tests for mac port. Most of audio tests use media/content/test.wav as test file for mac, so this change would make sure findMediaFile() will return test.wav but not test.mp3 or other formats. (setSrcById): Fixing bug in code.
  • media/video-canvas-source.html: Use findMediaFile() to locate a media file based on supported types.
  • media/video-click-dblckick-standalone.html: ditto.
  • media/video-controls-transformed.html: ditto.
  • media/video-controls-visible-audio-only.html: ditto.
  • media/video-controls-zoomed.html: ditto.
  • media/video-controls.html: ditto.
  • media/video-currentTime-set.html: ditto.
  • media/video-currentTime-set2.html: ditto.
  • media/video-currentTime.html: ditto.
  • media/video-display-none-crash.html: ditto.
  • media/video-display-toggle.html: ditto.
  • media/video-dom-autoplay.html: ditto.
  • media/video-dom-src.html: ditto.
  • media/video-error-abort.html: ditto.
  • media/video-load-networkState.html: ditto.
  • media/video-load-readyState.html: ditto.
  • media/video-loop.html: ditto.
  • media/video-muted.html: ditto.
  • media/video-no-autoplay.html: ditto.
3:48 PM Changeset in webkit [48493] by weinig@apple.com
  • 2 edits in trunk/WebCore

Remove commented out onhashchange attribute now that it is implemented.

Reviewed by Brady Eidson.

  • page/DOMWindow.idl:
3:23 PM Changeset in webkit [48492] by andersca@apple.com
  • 5 edits in trunk

WebCore: <rdar://problem/7007541>
CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...

Reviewed by Oliver Hunt.

Make RuntimeObjectImp more robust against m_instance being a null (which can happen if an OOP plug-in
crashes while we're calling into it).

  • bridge/runtime_object.cpp:

(JSC::RuntimeObjectImp::RuntimeObjectImp):
(JSC::RuntimeObjectImp::~RuntimeObjectImp):
(JSC::RuntimeObjectImp::invalidate):
(JSC::RuntimeObjectImp::fallbackObjectGetter):
(JSC::RuntimeObjectImp::fieldGetter):
(JSC::RuntimeObjectImp::methodGetter):
(JSC::RuntimeObjectImp::getOwnPropertySlot):
(JSC::RuntimeObjectImp::getOwnPropertyDescriptor):
(JSC::RuntimeObjectImp::put):
(JSC::RuntimeObjectImp::defaultValue):
(JSC::RuntimeObjectImp::getCallData):
(JSC::RuntimeObjectImp::getConstructData):
(JSC::RuntimeObjectImp::getPropertyNames):

  • bridge/runtime_object.h:

(JSC::RuntimeObjectImp::getInternalInstance):

WebKit/mac: <rdar://problem/7007541>
CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...

Reviewed by Oliver Hunt.

Add null checks for m_instanceProxy (It will be null when a plug-in has crashed).

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invoke):
(WebKit::ProxyInstance::supportsInvokeDefaultMethod):
(WebKit::ProxyInstance::supportsConstruct):
(WebKit::ProxyInstance::getPropertyNames):
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):
(WebKit::ProxyInstance::fieldValue):
(WebKit::ProxyInstance::setFieldValue):
(WebKit::ProxyInstance::invalidate):

1:54 PM Changeset in webkit [48491] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-09-17 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

Wrap primitive values (as objects) in InspectorController::wrap.

​https://bugs.webkit.org/show_bug.cgi?id=28983

  • inspector/InspectorController.cpp: (WebCore::InspectorController::wrapObject): objects of any type will be wrapped into proxies, only object proxies will have objectId.
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): there is InjectedScript.getCompletionsi that accepts an expression and returns possible completions. This way we don't need to wrap and unwrap the completions result into a proxy object.
  • inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): (InjectedScript.evaluate): (InjectedScript._evaluateOn): (InjectedScript.createProxyObject):
  • inspector/front-end/InjectedScriptAccess.js:
1:45 PM Changeset in webkit [48490] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-09-17 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Wrap PageTransitionEvents properly for V8's use.

​https://bugs.webkit.org/show_bug.cgi?id=29340

Fixes Chromium's failures for LayoutTests/fast/events/pageshow-pagehide.html.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object): Wrap PageTransitionEvents properly.
1:12 PM Changeset in webkit [48489] by Simon Fraser
  • 3 edits
    3 adds in trunk

2009-09-17 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Hardware-accelerated opacity transition on inline asserts
​https://bugs.webkit.org/show_bug.cgi?id=29342

Remove an erroneous toRenderBox() that could be called on a RenderInline; we can just
pass an empty size, because the box size is only required for transform animations.

Test: compositing/transitions/opacity-on-inline.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startTransition):
1:07 PM Changeset in webkit [48488] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2009-09-17 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Update contributing.html to mention recently added tools.
​https://bugs.webkit.org/show_bug.cgi?id=29318

Update our contributing instructions to mention
the new tools (check-webkit-style and commit-queue)
recently added to make contributions easier.

  • coding/contributing.html:
    • Mention check-webkit-style as an optional helper tool.
    • Mention checking the 'patch' checkbox.
    • Mention the commit-queue as an optional helper tool.
    • Remove "or in email" since patch reviews are all done via bugzilla.
    • Encourage contributers to be responsible for getting their patch landed. Provide a list of committers.
    • Mention commit-queue as an optional help in getting your patch landed.
    • Give an overview of the commit-queue process and link to the Commit Queue docs.
1:03 PM Changeset in webkit [48487] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-09-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Brady Eidson.

Tiger fails test http/tests/loading/redirect-with-no-location-crash.html added in r48413
​https://bugs.webkit.org/show_bug.cgi?id=29329

Skip test that fails on Tiger because of a bug in its version of
CFNetwork.

  • platform/mac-tiger/Skipped:
12:59 PM Changeset in webkit [48486] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] OwnHandle might get a weak callback after destruction
​https://bugs.webkit.org/show_bug.cgi?id=29172

Be sure to clear out weak reference so we don't get a weak callback
after we've destructed ourselves. Also, removed some tricky methods
that had no clients.

  • bindings/v8/OwnHandle.h: (WebCore::OwnHandle::clear):
12:52 PM Changeset in webkit [48485] by eric@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

2009-09-17 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: media/video-size-intrinsic-scale.html (and other media tests?) crashing/timing-out intermittently
​https://bugs.webkit.org/show_bug.cgi?id=28845

Skip media/video-size-intrinsic-scale.html in hopes of stopping the crashers.
I ran the media tests with --iterations 30 w/o seeing a crash.
I also re-enabled media/video-source-add-src.html now that we know it is not at fault.

  • media/video-source-add-src.html: Renamed from LayoutTests/media/video-source-add-src.html-disabled.
  • platform/mac-leopard/Skipped:
12:43 PM Changeset in webkit [48484] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2009-09-17 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

Add layout tests to verify there is no security leaks if someone sets a prototype of top
window to its child window.
​https://bugs.webkit.org/show_bug.cgi?id=29334

  • http/tests/security/resources/iframe-with-element.html: Added.
  • http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt: Added.
  • http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto.html: Added.
  • http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt: Added.
  • http/tests/security/xss-DENIED-method-with-iframe-proto.html: Added.
  • http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto-expected.txt: Added.
  • http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto.html: Added.
  • http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto-expected.txt: Added.
  • http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto.html: Added.
12:13 PM Changeset in webkit [48483] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-09-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[V8] Partial roll out of ​http://trac.webkit.org/changeset/48455 to
fix crashes that started happening in V8Proxy::getEnteredContext().

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
12:10 PM Changeset in webkit [48482] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: labels of checkboxes should, when hit-tested, return the checkbox
​https://bugs.webkit.org/show_bug.cgi?id=29335

Reviewed by Beth Dakin.

WebCore:

When an accessibility hit test is done and it hits the label of a control element,
the control element should be returned instead of nothing, since the label
itself is usually ignored.

Test: accessibility/label-for-control-hittest.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::correspondingControlForLabelElement):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/label-for-control-hittest-expected.txt: Added.
  • accessibility/label-for-control-hittest.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:
12:08 PM Changeset in webkit [48481] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-09-17 Avi Drissman <​avi@chromium.org>

Reviewed by Dimitri Glazkov, build fix.

Change to make RenderThemeChromiumMac compile inside of non PLATFORM(MAC).
​https://bugs.webkit.org/show_bug.cgi?id=29243

Covered by existing tests.

  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
12:06 PM Changeset in webkit [48480] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-09-17 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

[V8] Accessing properties/methods of an object, created with document.implementation.createDocumentType
creates nodes that have no document (ScriptExecutionContext), which in turn produces NULL-ref crashes.
​https://bugs.webkit.org/show_bug.cgi?id=26402

Test: fast/dom/DOMImplementation/detached-doctype.html

fast/dom/doctype-event-listener-crash.html

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener): Added an extra NULL-check.
11:39 AM Changeset in webkit [48479] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-09-17 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Add a newline to the end of the expected file, should fix results.

  • platform/win/transforms/2d/hindi-rotated-expected.txt:
11:32 AM Changeset in webkit [48478] by adachan@apple.com
  • 3 edits in trunk/WebKit/win

Post WebViewDidChangeSelectionNotification when the text selection changes.

Fixes <​http://webkit.org/b/29321>

Reviewed by Adam Roben.

  • Interfaces/IWebView.idl:
  • WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::respondToChangedSelection):
11:09 AM Changeset in webkit [48477] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix, add missing dependency.

11:05 AM Changeset in webkit [48476] by bweinstein@apple.com
  • 4 edits in trunk/LayoutTests

2009-09-17 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Updated Windows results on three failing tests, adding font-smoothing to computed-style,
and udpated the hindi-rotated-expected to what it has been getting on the bots.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
10:44 AM Changeset in webkit [48475] by mitz@apple.com
  • 1 add in trunk/WebCore/platform/graphics/FontSmoothingMode.h

Add file that was missing from the last change

10:33 AM Changeset in webkit [48474] by mitz@apple.com
  • 11 edits in trunk/WebCore

FontDescription.h includes RenderStyleConstants.h, which violates layering
​https://bugs.webkit.org/show_bug.cgi?id=29327

Reviewed by Simon Fraser.

  • GNUmakefile.am: Added FontSmoothingMode.h.
  • WebCore.gypi: Added FontSmoothingMode.h.
  • WebCore.vcproj/WebCore.vcproj: Added FontSmoothingMode.h.
  • WebCore.xcodeproj/project.pbxproj: Added FontSmoothingMode.h and made

it a private header.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Get the

font smoothing mode via the font description.

  • css/CSSPrimitiveValueMappings.h: Include FontSmoothingMode.h

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Updated for the rename

of FontSmoothing to FontSmoothingMode.

(WebCore::CSSPrimitiveValue::operator FontSmoothingMode): Ditto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Get the font smoothing mode

via the font description.

  • platform/graphics/FontDescription.h: Do not include

RenderStyleConstants.h.

(WebCore::FontDescription::fontSmoothing): Updated for the rename of

FontSmoothing to FontSmoothingMode.

(WebCore::FontDescription::setFontSmoothing): Ditto.

  • platform/graphics/FontSmoothingMode.h: Added.

(WebCore::FontSmoothingMode): Moved the FontSmoothing enum from

RenderStyleConstants here and renamed it to this.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::fontSmoothing): Removed this getter, since

this can be accessed via the font description.

  • rendering/style/RenderStyleConstants.h: Moved the FontSmoothing enum

from here to FontSmoothingMode.h.

10:32 AM Changeset in webkit [48473] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix a crash when a WebView's HWND is destroyed before IWebView::close is called

WebView's HWND was being sent a WM_TIMER message after the WebView was
destroyed. This normally isn't possible (we call DestroyWindow inside
WebView's destructor to ensure the HWND doesn't outlive the WebView),
but r48060 changed WebView to call SetParent(m_viewWindow,
HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the
HWND into some weird half-destroyed state where it can still receive
WM_TIMER messages.

Fixes <​http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION
(r48060): unrepro but frequent crash in WebViewWndProc

Reviewed by Steve Falkenburg.

  • WebView.cpp:

(WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed()
before calling close(). This allows setHostWindow to detect that we're
handling WM_DESTROY. No other code in close() cared whether
isBeingDestroyed() was true or not.
(WebView::setHostWindow): If our host window is being set to 0 and
we're being destroyed, don't become a message-only window. Doing this
while handling WM_DESTROY seems to lead to crashes.

10:10 AM Changeset in webkit [48472] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx 2.9 build fix.

9:56 AM Changeset in webkit [48471] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-09-16 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Work around a bug in AppKit on Leopard which causes compositing layers to jitter, and
become misplaced when the WebHTMLView is resized or scrolled sometimes.
<rdar://problem/7071636>

The previous fix didn't fix the case where the layers jiggle when resizing the docked
inspector when the view size is over 2048px tall, on Leopard.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):
9:41 AM Changeset in webkit [48470] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-09-16 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Elements appear behind <video> when they should be in front sometimes
​https://bugs.webkit.org/show_bug.cgi?id=29314

r45598 added logic that tests for overlap with <video> to determine when to throw
a layer into compositing mode. That logic was incorrect in some cases, and this patch
fixes it. When testing overlap, the layer needs to be composited iff some previous layer
is composited (which adds a rect to the overlay map), and there is overlap.

Test: compositing/geometry/video-opacity-overlay.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::CompositingState::CompositingState): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
8:52 AM Changeset in webkit [48469] by Dimitri Glazkov
  • 8 edits
    2 adds in trunk/WebCore

2009-09-17 Avi Drissman <​avi@google.com>

Reviewed by Darin Fisher.

Update the Chromium Mac theming files (RenderTheme and Theme) to be
up-to-date.

​https://bugs.webkit.org/show_bug.cgi?id=29243
​http://crbug.com/19604

Covered by existing tests.

  • WebCore.gypi:
  • platform/chromium/ThemeChromiumMac.h: Added. (WebCore::ThemeChromiumMac::ThemeChromiumMac): (WebCore::ThemeChromiumMac::~ThemeChromiumMac): (WebCore::ThemeChromiumMac::controlRequiresPreWhiteSpace):
  • platform/chromium/ThemeChromiumMac.mm: Added. (WebCore::): (WebCore::platformTheme): (WebCore::controlSizeForFont): (WebCore::sizeFromFont): (WebCore::setControlSize): (WebCore::updateStates): (WebCore::inflateRect): (WebCore::checkboxSizes): (WebCore::checkboxMargins): (WebCore::checkboxSize): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radioSizes): (WebCore::radioMargins): (WebCore::radioSize): (WebCore::radio): (WebCore::paintRadio): (WebCore::buttonSizes): (WebCore::buttonMargins): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeChromiumMac::baselinePositionAdjustment): (WebCore::ThemeChromiumMac::controlFont): (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::controlBorder): (WebCore::ThemeChromiumMac::controlPadding): (WebCore::ThemeChromiumMac::inflateControlPaintRect): (WebCore::ThemeChromiumMac::paint):
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/IntRect.h:
  • rendering/RenderThemeChromiumMac.h: (WebCore::RenderThemeChromiumMac::supportsControlTints): (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart): (WebCore::RenderThemeChromiumMac::supportsSelectionForegroundColors):
  • rendering/RenderThemeChromiumMac.mm: (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): (-[RTCMFlippedView isFlipped]): (-[RTCMFlippedView currentEditor]): (WebCore::): (WebCore::FlippedView): (WebCore::RenderTheme::themeForPage): (WebCore::RenderThemeChromiumMac::platformActiveListBoxSelectionForegroundColor): (WebCore::RenderThemeChromiumMac::platformInactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeChromiumMac::platformInactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeChromiumMac::systemFont): (WebCore::convertNSColorToColor): (WebCore::menuBackgroundColor): (WebCore::RenderThemeChromiumMac::systemColor): (WebCore::RenderThemeChromiumMac::isControlStyled): (WebCore::RenderThemeChromiumMac::adjustRepaintRect): (WebCore::RenderThemeChromiumMac::inflateRect): (WebCore::RenderThemeChromiumMac::convertToPaintingRect): (WebCore::RenderThemeChromiumMac::setFontFromControlSize): (WebCore::RenderThemeChromiumMac::paintTextField): (WebCore::RenderThemeChromiumMac::paintCapsLockIndicator): (WebCore::RenderThemeChromiumMac::paintTextArea): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::TopGradientInterpolate): (WebCore::BottomGradientInterpolate): (WebCore::MainGradientInterpolate): (WebCore::TrackGradientInterpolate): (WebCore::RenderThemeChromiumMac::paintMenuListButtonGradients): (WebCore::RenderThemeChromiumMac::paintMenuListButton): (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): (WebCore::RenderThemeChromiumMac::popupInternalPaddingTop): (WebCore::RenderThemeChromiumMac::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumMac::adjustSliderTrackStyle): (WebCore::RenderThemeChromiumMac::adjustSliderThumbStyle): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::setSearchCellState): (WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldDecoration): (WebCore::RenderThemeChromiumMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton): (WebCore::mediaControllerTheme): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::getMediaUIPartStateFlags): (WebCore::getUnzoomedRectAndAdjustCurrentContext): (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaRewindButton): (WebCore::RenderThemeChromiumMac::paintMediaReturnToRealtimeButton): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): (WebCore::RenderThemeChromiumMac::paintMediaCurrentTime): (WebCore::RenderThemeChromiumMac::paintMediaTimeRemaining): (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet):
7:03 AM Changeset in webkit [48468] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Improve documentation for Page Cache.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-09-17
Reviewed by Simon Hausmann.

  • Api/qwebsettings.cpp:
6:03 AM Changeset in webkit [48467] by zoltan@webkit.org
  • 1 add in trunk/LayoutTests/platform/qt/fast/css/font-smoothing-expected.txt

2009-09-17 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Add expected file for passing font-smoothing test and update computed style tests since font smoothing is auto by default.

  • platform/qt/fast/css/font-smoothing-expected.txt: Added.
6:01 AM Changeset in webkit [48466] by zoltan@webkit.org
  • 3 edits in trunk/LayoutTests

2009-09-17 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Add expected file for passing font-smoothing test and update computed style tests since font smoothing is auto by default.

  • platform/qt/fast/css/font-smoothing-expected.txt: Added.
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
5:46 AM Changeset in webkit [48465] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Update QWebSettings::setUserStyleSheetUrl() docs and test

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=29081

The documentation now specifies that the URL has to be a local file
or a a data-URL (with utf-8 and base64-encoded data), as these are the
only two schemes that the current code path accepts.

The auto-test has been updated to reflect this limitation.

At a later point we should concider adding API for the new way of
doing both user defined stylesheets and scripts.

  • Api/qwebsettings.cpp:
  • tests/qwebpage/tst_qwebpage.cpp:
4:51 AM Changeset in webkit [48464] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

[Qt] Skip failing tests for now to prepare default font size reconciliation.

Patch by Andras Becsi <​becsi.andras@stud.u-szeged.hu> on 2009-09-17
Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
3:54 AM Changeset in webkit [48463] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Symbian/WINSCW build fox.

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2009-09-17
Reviewed by Simon Hausmann.

Repeat Q_OS_WIN wchar_t hack for WINSCW, similar to
revision 24774.

WINSCW defines wchar_t, thus UChar has to be wchar_t

  • wtf/unicode/qt4/UnicodeQt4.h:
3:47 AM Changeset in webkit [48462] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Symbian/WINSCW build fix.

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2009-09-17
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=29186

WINSCW Template specialisation name in declaration must the be the same as in implementation.

  • runtime/LiteralParser.h:
3:44 AM Changeset in webkit [48461] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=27060

Patch by Norbert Leser <​norbert.leser@nokia.com> on 2009-09-15
Reviewed by Darin Adler.

Symbian compiler for emulator target (WINSCW) fails with
"illegal operand" for m_attributesInPrevious in structure.ccp
(when calling make_pair functions).
This error is apparently due to the compiler not properly
resolving the unsigned type of the declared bitfield.

Initial patch explicitly casted m_attributesInPrevious
to unsigned, but since bitfield optimization is not critical for
the emulator target, this conditional change in header file
appears to be least intrusive.

  • runtime/Structure.h:
3:31 AM Changeset in webkit [48460] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Symbian build fix.

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2009-09-17
Reviewed by Simon Hausmann.

Moved the #ifdefs around _q_cleanupLeakMessages() into the function
definition.

QMake is not being able to distinguish between release and debug builds
in Symbian build. This is a Symbian toolchain issue.

  • Api/qwebpage.cpp:

(QWebPagePrivate::_q_cleanupLeakMessages):

  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
3:20 AM Changeset in webkit [48459] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Small cosmetic documentation fixlet in the QWebInspector.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2009-09-17
Reviewed by Simon Hausmann.

  • Api/qwebinspector.cpp:
Note: See TracTimeline for information about the timeline view.