Timeline
Sep 21, 2009:
- 10:35 PM Changeset in webkit [48621] by
-
- 1 edit in trunk/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
Added missing brace.
- 10:25 PM Changeset in webkit [48620] by
-
- 2 edits in trunk/WebCore
2009-09-21 Adam Barth <abarth@webkit.org>
Attempted fix for the V8 build.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
- 10:08 PM Changeset in webkit [48619] by
-
- 5 edits in trunk/WebCore
2009-09-21 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Don't re-enter JavaScript after performing access checks
https://bugs.webkit.org/show_bug.cgi?id=29531
Moved the access check slightly later in this functions to avoid
re-entering the JavaScript interpreter (typically via toString)
after performing the access check.
I can't really think of a meaningful test for this change. It's more
security hygiene.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::if): (CALLBACK_FUNC_DECL): (V8Custom::WindowSetLocation): (V8Custom::ClearTimeoutImpl):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- 9:57 PM Changeset in webkit [48618] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-09-21 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
add a layout test for mishandling of an invalid sequence in multibyte
encodings
https://bugs.webkit.org/show_bug.cgi?id=27395
- fast/encoding/invalid-multi-byte-over-consumption-expected.txt: Added.
- fast/encoding/invalid-multi-byte-over-consumption.html: Added.
- 7:34 PM Changeset in webkit [48617] by
-
- 4 edits in trunk/WebCore
2009-09-21 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Eric Seidel.
Make all write transaction start with a BEGIN IMMEDIATE command
instead of BEGIN.
We cannot test this change in a layout test, because in order to
test it we need to spawn two database threads and execute
transaction steps on these two threads in a very specific order,
which seems impossible to do when they share the same main thread
(as they would in a layout test). The SQLite docs and the case
described in the bug though should be enough proof that we do have
a problem here and that this patch will fix it.
Relevant SQLite documentation:
http://www.sqlite.org/lang_transaction.html
http://www.sqlite.org/lockingv3.html#locking
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::SQLiteTransaction): Added a readOnly parameter. (WebCore::SQLiteTransaction::begin): Changed to BEGIN IMMEDIATE for write transactions.
- platform/sql/SQLiteTransaction.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): Passing the read-only flag to the SQLiteTransaction instance.
- 7:15 PM Changeset in webkit [48616] by
-
- 2 edits in trunk/WebKitSite
Add coding style guidelines for 'using namespace.'
https://bugs.webkit.org/show_bug.cgi?id=29499
Reviewed by Darin Adler.
- coding/coding-style.html:
- 6:35 PM Changeset in webkit [48615] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Mark Rowe.
- DerivedSources.make: Fix the Xcode build on SnowLeopard.
- 5:58 PM Changeset in webkit [48614] by
-
- 2 edits in trunk/WebKitTools
2009-09-11 Eric Seidel <eric@webkit.org>
Reviewed by David Kilzer.
post-diff and post-commits should be able to find bug urls in ChangeLogs.
https://bugs.webkit.org/show_bug.cgi?id=29206
- Scripts/bugzilla-tool:
- Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
- Rename --no-comment to --add-log-as-comment and reverse behavior. Comments tend to just be noise. I'll eventually remove this argument if no one uses it.
- Split out code into helper functions to try and make execute() more legible.
- Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
- Fallback to bug urls in commit diffs, instead of just in commit messages, meaning post-commits will now find bug urls in ChangeLogs.
- 5:28 PM Changeset in webkit [48613] by
-
- 2 edits in trunk/LayoutTests
2009-09-21 Brian Weinstein <bweinstein@apple.com>
Reviewed by Sam Weinig.
Add fast/events/drag-file-crash.html to Windows Skipped List because
DRT doesn't support eventSender.beginDragWithFiles on Windows yet.
- platform/win/Skipped:
- 5:19 PM Changeset in webkit [48612] by
-
- 10 edits5 adds in trunk
WebCore:
2009-09-15 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
Prevent sleeps in unload handlers.
https://bugs.webkit.org/show_bug.cgi?id=29193
Test: fast/dom/Window/slow_unload_handler.html
- WebCore.gypi:
- bindings/v8/DateExtension.cpp: Added. (WebCore::DateExtension::DateExtension): (WebCore::DateExtension::get): (WebCore::DateExtension::setAllowSleep): (WebCore::DateExtension::GetNativeFunction): (WebCore::DateExtension::weakCallback): (WebCore::DateExtension::GiveEnableSleepDetectionFunction): (WebCore::DateExtension::OnSleepDetected):
- bindings/v8/DateExtension.h: Added.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::registerExtensionWithV8): (WebCore::V8Proxy::registeredExtensionWithV8):
- bindings/v8/V8Proxy.h:
LayoutTests:
2009-09-15 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
Prevent sleeps in unload handlers.
https://bugs.webkit.org/show_bug.cgi?id=29193
- fast/dom/Window/resources/slow_unload_handler1.html: Added.
- fast/dom/Window/slow_unload_handler-expected.txt: Added.
- fast/dom/Window/slow_unload_handler.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 5:09 PM Changeset in webkit [48611] by
-
- 2 edits in trunk/WebKitTools
2009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
--parse-only parameter wasn't passed to SunSpider/sunspider script.
https://bugs.webkit.org/show_bug.cgi?id=29611
- Scripts/run-sunspider: Missing parameter passing added.
- 5:07 PM Changeset in webkit [48610] by
-
- 3 edits in trunk/WebCore
[V8] Run-time exception in onmessage handler is not forwarded to the
worker object.
https://bugs.webkit.org/show_bug.cgi?id=28980
Reviewed by David Levin.
The previous fix was partially reverted due to a reliability build break
in chromium. The break happens when an exception is thrown without
setting a message. We need to check for this scenario and handle it.
Tested by worker-close.html.
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/V8Utilities.cpp:
(WebCore::reportException):
- 4:10 PM Changeset in webkit [48609] by
-
- 18 edits1 add in trunk
JavaScriptCore: Add ENABLE(ORIENTATION_EVENTS)
https://bugs.webkit.org/show_bug.cgi?id=29508
Reviewed by Simon Fraser & Sam Weinig.
- wtf/Platform.h: Also sort PLATFORM(IPHONE) #defines.
WebCore: Add ENABLE(ORIENTATION_EVENTS)
https://bugs.webkit.org/show_bug.cgi?id=29508
Reviewed by Simon Fraser & Sam Weinig.
See documentation here:
http://developer.apple.com/safari/library/documentation/AppleApplications/Reference/SafariWebContent/HandlingEvents/HandlingEvents.html#//apple_ref/doc/uid/TP40006511-SW16
- DerivedSources.make: Use new WebCore.OrientationEvents.exp file if ENABLE_ORIENTATION_EVENTS.
Add ENABLE_ORIENTATION_EVENTS to the new ADDITIONAL_IDL_DEFINES variable that is passed to the IDL
code generator. This is because ENABLE_ORIENTATION_EVENTS is not in FEATURE_DEFINES.
- WebCore.OrientationEvents.exp: Added.
- WebCore.xcodeproj/project.pbxproj: Add WebCore.OrientationEvents.exp.
- dom/EventNames.h: Add onorientationchange.
- html/HTMLAttributeNames.in: Ditto.
- html/HTMLBodyElement.cpp: Handle onorientationchange properly.
(WebCore::HTMLBodyElement::parseMappedAttribute):
(WebCore::HTMLBodyElement::onorientationchange):
(WebCore::HTMLBodyElement::setOnorientationchange):
- html/HTMLBodyElement.h: Ditto.
- html/HTMLBodyElement.idl: Ditto.
- html/HTMLFrameSetElement.cpp: Ditto.
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
(WebCore::HTMLFrameSetElement::onorientationchange):
(WebCore::HTMLFrameSetElement::setOnorientationchange):
- html/HTMLFrameSetElement.h: Ditto.
- html/HTMLFrameSetElement.idl: Ditto.
- page/DOMWindow.cpp: Ditto.
(WebCore::DOMWindow::orientation): Calls up the to the Frame for the orientation value.
(WebCore::DOMWindow::onorientationchange):
(WebCore::DOMWindow::setOnorientationchange):
- page/DOMWindow.h: Handle onorientationchange properly.
- page/DOMWindow.idl: Ditto.
- page/Frame.cpp: Ditto.
(WebCore::Frame::Frame):
(WebCore::Frame::sendOrientationChangeEvent):
- page/Frame.h: Ditto.
(WebCore::Frame::orientation):
- 3:59 PM Changeset in webkit [48608] by
-
- 4 edits in trunk/WebCore
2009-09-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: completions are always evaluated against
window (discarding call frames).
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
- inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.selectedCallFrameId):
- 3:40 PM Changeset in webkit [48607] by
-
- 2 edits3 adds in trunk/WebCore
Unreviewed build fix for Windows (Cairo) target.
Add stubs for SocketStream classes added in @r47788, which
broke the WinCairo build.
No new tests. (Build failure).
- WebCore.vcproj/WebCore.vcproj: Add references to new files to Cairo build, exclude from standard Apple build.
- platform/network/curl/SocketStreamError.h: Added.
- platform/network/curl/SocketStreamHandle.h: Added.
- platform/network/curl/SocketStreamHandleCurl.cpp: Added.
- 3:15 PM Changeset in webkit [48606] by
-
- 3 edits in trunk/WebCore
2009-09-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Expose InspectorResource fields.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::resourceData):
- inspector/InspectorResource.h: (WebCore::InspectorResource::requestHeaderFields): (WebCore::InspectorResource::responseHeaderFields): (WebCore::InspectorResource::responseStatusCode): (WebCore::InspectorResource::requestMethod): (WebCore::InspectorResource::requestFormData):
- 2:50 PM Changeset in webkit [48605] by
-
- 2 edits in trunk/WebCore
2009-09-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: JS error drilling down childless node.
No need to dispatch double click twice - it is already handled
in TreeElement.treeElementDoubleClicked.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline):
- 2:39 PM Changeset in webkit [48604] by
-
- 14 edits1 add in trunk
WebCore: Implement new QWebPageClient class and let our classes
QWebViewPrivate and QWebGraphicsItemPrivate inherit from it.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-21
Reviewed by Simon Hausmann.
For Qt, platformPageClient() will now return a class derived from
the QWebPageClient, so the patch adapts our Qt hooks to go though
this class and not depend on the QWebView.
- WebCore.pro:
- platform/Widget.h:
- platform/qt/PlatformScreenQt.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::show):
- platform/qt/QWebPageClient.h: Added.
- platform/qt/WidgetQt.cpp:
(WebCore::Widget::setCursor):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::getValue):
(WebCore::PluginView::platformStart):
WebKit/qt: For Qt, platformPageClient() will now return a class derived from
the QWebPageClient, so the patch adapts our Qt hooks to go though
this class and not depend on the QWebView.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-21
Reviewed by Simon Hausmann.
- Api/qwebgraphicsitem.cpp:
(QWebGraphicsItemPrivate::scroll):
(QWebGraphicsItemPrivate::update):
(QWebGraphicsItemPrivate::cursor):
(QWebGraphicsItemPrivate::updateCursor):
(QWebGraphicsItemPrivate::screenNumber):
(QWebGraphicsItemPrivate::winId):
(QWebGraphicsItem::event):
(QWebGraphicsItem::setPage):
- Api/qwebgraphicsitem.h:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- Api/qwebpage_p.h:
- Api/qwebview.cpp:
(QWebViewPrivate::scroll):
(QWebViewPrivate::update):
(QWebViewPrivate::cursor):
(QWebViewPrivate::updateCursor):
(QWebViewPrivate::screenNumber):
(QWebViewPrivate::winId):
(QWebView::setPage):
(QWebView::event):
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::scroll):
(WebCore::ChromeClientQt::platformPageClient):
- 2:37 PM Changeset in webkit [48603] by
-
- 2 edits in trunk/WebCore
2009-09-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Evaluating on call frame always returns "undefined".
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript._evaluateAndWrap): (InjectedScript._evaluateOn): (InjectedScript.evaluateInCallFrame):
- 2:34 PM Changeset in webkit [48602] by
-
- 3 edits in trunk/WebCore
2009-09-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Exception formatting is broken in console.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleCommandResult):
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript.createProxyObject):
- 2:32 PM Changeset in webkit [48601] by
-
- 3 edits in trunk/WebCore
2009-09-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Console object formatting is broken.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy.wrapPrimitiveValue):
- 2:29 PM Changeset in webkit [48600] by
-
- 2 edits in trunk/WebCore
2009-09-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Crash When Logging an Element Before Opening Inspector
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- 2:27 PM Changeset in webkit [48599] by
-
- 6 edits4 adds in trunk
2009-09-21 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Incorrect clipping with accelerated compositing content, and position:fixed
https://bugs.webkit.org/show_bug.cgi?id=29347
Fix the compositing clipping logic to behave correctly when position:fixed
elements clip, by using the new backgroundClipRect() method to determine
when we need to clip, and to compute the clipping layer position.
Test: compositing/overflow/fixed-position-ancestor-clip.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::clippedByAncestor):
- 2:03 PM Changeset in webkit [48598] by
-
- 2 edits in trunk/WebCore
2009-09-21 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add back in a special case for window.top in the V8 bindings.
Fixes LayoutTests/fast/dom/Window/window-property-shadowing.html in the Chromium port.
- bindings/scripts/CodeGeneratorV8.pm: Ensure window.top is not marked as read only, as this breaks the shadowing disabling.
- 1:54 PM Changeset in webkit [48597] by
-
- 2 edits in trunk/WebKit/qt
2009-09-21 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29609
Build fix for windows when using Qt 4.5.0.
- Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
- 1:53 PM Changeset in webkit [48596] by
-
- 3 edits2 adds in trunk
2009-09-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Brady Eidson.
HTMLMediaElement: media file should not reload when page comes out of page cache
https://bugs.webkit.org/show_bug.cgi?id=29604
Test: media/restore-from-page-cache.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): Do nothing unless the element is still loading. Only fire an 'emptied' event if the readyState is HAVE_NOTHING, otherwise set the network state to NETWORK_IDLE.
2009-09-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Brady Eidson.
HTMLMediaElement: media file should not reload when page comes out of page cache
https://bugs.webkit.org/show_bug.cgi?id=29604
- media/restore-from-page-cache-expected.txt: Added.
- media/restore-from-page-cache.html: Added.
- 1:49 PM Changeset in webkit [48595] by
-
- 3 edits in trunk/WebCore
Clarify two FIXMEs.
Reviewed by Geoffrey "Sean/Shawn/Shaun" Garen.
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
- bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
- 1:47 PM Changeset in webkit [48594] by
-
- 5 edits1 add in trunk/WebKit/win
<rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource
Reviewed by Adam Roben.
Implement WebFrameLoaderClient::shouldLoadMediaElementURL and have it call the new private policy
delegate method.
- Interfaces/IWebPolicyDelegatePrivate.idl: Added.
- Interfaces/WebKit.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::shouldLoadMediaElementURL):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebKit.vcproj/Interfaces.vcproj:
- 1:37 PM Changeset in webkit [48593] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Eric Seidel.
[Fix] SourceCode's uninitialized member
Potential source of crashes and bugs was fixed. Default constructor
didn't initialized m_provider member.
- parser/SourceCode.h: (JSC::SourceCode::SourceCode):
- 12:07 PM Changeset in webkit [48592] by
-
- 2 edits in trunk/WebKit/mac
Attempt to fix the Tiger build
- WebView/WebPDFDocumentExtras.mm:
(addWebPDFDocumentExtras):
- 12:01 PM Changeset in webkit [48591] by
-
- 2 edits in trunk/WebKit/mac
Attempt to fix the Tiger build
- WebView/WebPDFDocumentExtras.mm:
(web_PDFDocumentAllScripts):
(addWebPDFDocumentExtras):
- 11:59 AM Changeset in webkit [48590] by
-
- 4 edits3 adds in trunk
REGRESSION (r48582): Crash in StructureStubInfo::initPutByIdTransition when reloading trac.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=29599
Reviewed by Geoff Garen
It is unsafe to attempt to cache new property transitions on
dictionaries of any type.
- 11:54 AM Changeset in webkit [48589] by
-
- 3 edits in trunk/WebKit/mac
Attempt to fix the Tiger build
- WebView/WebPDFDocumentExtras.mm:
- WebView/WebPDFRepresentation.mm:
- 11:52 AM Changeset in webkit [48588] by
-
- 1 edit2 adds in trunk/WebKitSite
Rubberstamped by Sam Weinig.
Add some example files for an upcoming blog post.
- blog-files/load-unload-example.html: Added.
- blog-files/pageshow-pagehide-example.html: Added.
- 11:47 AM Changeset in webkit [48587] by
-
- 2 edits in trunk/WebKit/mac
Attempt to fix the Leopard and Tiger builds
- WebView/WebPDFDocumentExtras.mm:
- 11:01 AM Changeset in webkit [48586] by
-
- 4 edits1 move4 adds in trunk/WebKit
<rdar://problem/4137135> iFrame with PDF not being handled correctly on
usps.com
https://bugs.webkit.org/show_bug.cgi?id=4151
Reviewed by Anders Carlsson.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Added WebPDFDocumentExtras.{h,mm}
and WebJSPDFDoc.{h,mm} and changed WebPDFRepresentation to
Objective-C++.
WebKit/mac:
- WebView/WebJSPDFDoc.h: Added.
- WebView/WebJSPDFDoc.mm: Added.
(jsPDFDocInitialize): Retains the WebDataSource.
(jsPDFDocFinalize): Releases the WebDataSource.
(jsPDFDocPrint): Call the WebUIDelegate method -webView:printFrameView:
with the PDF document's view.
(makeJSPDFDoc): Makes and returns a JavaScript Doc instance that wraps
the WebDataSource.
- WebView/WebPDFDocumentExtras.h: Added.
- WebView/WebPDFDocumentExtras.mm: Added.
(appendValuesInPDFNameSubtreeToArray): Traverses a subtree of a PDF name
tree and adds all values in the subtree to an array.
(allValuesInPDFNameTree): Returns an array with all of the values in a
PDF name tree.
(web_PDFDocumentAllScripts): This is the implementation of -[PDFDocument
_web_allScripts]. It gets all values in the document-level "JavaScript"
name tree, which are action dictionaries, and returns an array of the
actions' scripts.
(addWebPDFDocumentExtras): Adds the -_web_allScripts method to
PDFDocument.
- WebView/WebPDFRepresentation.h:
- WebView/WebPDFRepresentation.m: Removed.
- WebView/WebPDFRepresentation.mm: Copied from WebKit/mac/WebView/WebPDFRepresentation.m.
(+[WebPDFRepresentation initialize]): Added. Calls
addWebPDFDocumentExtras().
(-[WebPDFRepresentation finishedLoadingWithDataSource:]): Get the
scripts from the PDF document, create a JavaScript Doc object for the
document, and a JavaScript execution context, then execute every script
in the context, with the Doc object as "this".
- 9:06 AM Changeset in webkit [48585] by
-
- 2 edits in trunk/WebCore
2009-09-21 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Drop down selects fail to close when a value is selected
https://bugs.webkit.org/show_bug.cgi?id=29582
Implement PopupListBox::hidePopup, which was previously
declared but unimplemented. Removes the declaration of
showPopup since that method is not implemented.
PopupListBox::hidePopup takes care of hiding the popup,
by invoking hidePopup on its parent PopupContainer, and
then informs the PopupMenuClient that popupDidHide.
This mimics the old behavior prior to r48370.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::hidePopup):
- 8:55 AM Changeset in webkit [48584] by
-
- 2 edits in trunk/SunSpider
2009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
[Qt] Make sunspider script work on Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=29544
- sunspider: Using platform specific null device instead of /dev/null.
- 8:49 AM Changeset in webkit [48583] by
-
- 2 edits in trunk/WebCore
2009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Rubber-stamped by Simon Hausmann.
[Qt] Windows build fix.
https://bugs.webkit.org/show_bug.cgi?id=29535
- platform/network/qt/DnsPrefetchHelper.cpp: Missing #include "config.h" added.
- 8:45 AM Changeset in webkit [48582] by
-
- 8 edits in trunk/JavaScriptCore
Re-land SNES fix, with correct assertion
RS=Maciej Stachowiak
- 8:38 AM Changeset in webkit [48581] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fix JavaScriptCore/ChangeLog to match our preferred rollout procedure
- 7:45 AM Changeset in webkit [48580] by
-
- 8 edits in trunk/JavaScriptCore
Revert r48573, as it caused many assertion failures
- 6:08 AM Changeset in webkit [48579] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.15
Tagging 1.1.15.
- 5:57 AM Changeset in webkit [48578] by
-
- 4 edits in trunk
Unreviewed make dist build fix. Adding missing files.
- 5:17 AM Changeset in webkit [48577] by
-
- 3 edits in trunk/WebKit/gtk
2009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Update documentation control files to 1.1.15.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 5:16 AM Changeset in webkit [48576] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed docs build fix. Current CFLAGS and LIBS variables no
longer bring gthread in.
- docs/GNUmakefile.am:
- 4:56 AM Changeset in webkit [48575] by
-
- 4 edits in trunk
2009-09-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump version for 1.1.15 release.
- configure.ac:
WebKit/gtk:
2009-09-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for release.
- NEWS:
- 12:37 AM Changeset in webkit [48574] by
-
- 3 edits in trunk/JavaScriptCore
Fix stack alignment with ARM THUMB2 JIT.
https://bugs.webkit.org/show_bug.cgi?id=29526
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-09-19
Reviewed by Sam 'Cabin Boy' Weinig.
Stack is currently being decremented by 0x3c, bump this to 0x40 to make this a
multiple of 16 bytes.
- jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
- jit/JITStubs.h:
Sep 20, 2009:
- 10:42 PM Changeset in webkit [48573] by
-
- 8 edits in trunk/JavaScriptCore
SNES is too slow
https://bugs.webkit.org/show_bug.cgi?id=29534
Reviewed by Maciej Stachowiak.
The problem was that the emulator used multiple classes with
more properties than our dictionary cutoff allowed, this resulted
in more or less all critical logic inside the emulator requiring
uncached property access.
Rather than simply bumping the dictionary cutoff, this patch
recognises that there are two ways to create a "dictionary"
structure. Either by adding a large number of properties, or
by removing a property. In the case of adding properties we
know all the existing properties will maintain their existing
offsets, so we could cache access to those properties, if we
know they won't be removed.
To make this possible, this patch adds the logic required to
distinguish a dictionary created by addition from one created
by removal. With this logic in place we can now cache access
to objects with large numbers of properties.
SNES performance improved by more than 6x.
- 7:30 PM Changeset in webkit [48572] by
-
- 3 edits18 adds in trunk
2009-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Crash when clicking link in unload handler
https://bugs.webkit.org/show_bug.cgi?id=29525
Test that the first navigation always wins when the page tries to start
a new navigation in an unload handler.
- fast/loader/resources/fail-and-notify-done.html: Added.
- fast/loader/resources/pass-and-notify-done.html: Added.
- fast/loader/unload-form-about-blank-expected.txt: Added.
- fast/loader/unload-form-about-blank.html: Added.
- fast/loader/unload-form-expected.txt: Added.
- fast/loader/unload-form-post-about-blank-expected.txt: Added.
- fast/loader/unload-form-post-about-blank.html: Added.
- fast/loader/unload-form-post-expected.txt: Added.
- fast/loader/unload-form-post.html: Added.
- fast/loader/unload-form.html: Added.
- fast/loader/unload-hyperlink-expected.txt: Added.
- fast/loader/unload-hyperlink.html: Added.
- fast/loader/unload-javascript-url-expected.txt: Added.
- fast/loader/unload-javascript-url.html: Added.
- fast/loader/unload-reload-expected.txt: Added.
- fast/loader/unload-reload.html: Added.
- fast/loader/unload-window-location-expected.txt: Added.
- fast/loader/unload-window-location.html: Added.
2009-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Crash when clicking link in unload handler
https://bugs.webkit.org/show_bug.cgi?id=29525
Test that the first navigation always wins when the page tries to start
a new navigation in an unload handler.
Tests: fast/loader/unload-form-about-blank.html
fast/loader/unload-form-post-about-blank.html
fast/loader/unload-form-post.html
fast/loader/unload-form.html
fast/loader/unload-hyperlink.html
fast/loader/unload-javascript-url.html
fast/loader/unload-reload.html
fast/loader/unload-window-location.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader):
- 6:23 PM Changeset in webkit [48571] by
-
- 2 edits in trunk/WebCore
2009-09-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Sometimes crashes when a page is destroyed/loads another URL while playing video
https://bugs.webkit.org/show_bug.cgi?id=29496
Protect the video sink object, and destroy it in an idle callback
to hopefully avoid a race condition that leads to a crash.
This is already tested by media/video-seekable.html
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::idleUnref): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- 10:45 AM Changeset in webkit [48570] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Small documentation fix.
- webkit/webkithittestresult.cpp:
- 8:34 AM Changeset in webkit [48569] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
Reviewed by Mark Rowe.
The require statement is like the use statement, except that it
is run during script execution instead of during the 'BEGIN'
phase. This makes it possible to change @INC before the require
statement is run. See 'require' and 'use' in the perlfunc(1)
manpage and 'BEGIN' in perlmod(1) manpage.
- Scripts/run-webkit-tests: Replace eval statement with require
statement.
