Context Navigation

← Previous Period
Next Period →

Timeline

Sep 25, 2009:

11:43 PM Changeset in webkit [48787] by mitz@apple.com

2 edits in trunk/WebCore

REGRESSION (r48775) FontList.plist written by TOT WebKit causes Safari 4
to crash on launch
https://bugs.webkit.org/show_bug.cgi?id=29759

Reviewed by Sam Weinig.

platform/graphics/win/FontDatabase.cpp:

(WebCore::writeFontDatabaseToPlist): Reverted to saving the CG font DB
property list at the root of FontList.plist, but with an additional
key for the last value of the Fonts registry key.
(WebCore::populateFontDatabase): Pass the FontList.plist in its entirety
to populatFontDatabaseFromPlist.

11:41 PM Changeset in webkit [48786] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wx build fix. Add EmptyPluginHalterClient when creating Page.

11:31 PM Changeset in webkit [48785] by kevino@webkit.org

2 edits in trunk/WebCore

Build fix. Adding missing header files.

9:32 PM Changeset in webkit [48784] by ddkilzer@apple.com

2 edits in trunk/WebCore

Part 1 of 2: <http://webkit.org/b/29753> DerivedSources.make broken for non-Mac targets

Reviewed by Darin Adler.

DerivedSources.make: Move tests for ENABLE_CONTEXT_MENUS, ENABLE_DRAG_SUPPORT and ENABLE_INSPECTOR into Mac-only section.

7:35 PM Changeset in webkit [48783] by eric@webkit.org

3 edits
3 adds in trunk

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Load blocks during unload should not affect targeted loads
https://bugs.webkit.org/show_bug.cgi?id=29747

Test that we can follow targeted hyperlinks in an unload handler.

fast/loader/resources/unload-hyperlink-targeted-subframe.html: Added.
fast/loader/unload-hyperlink-targeted-expected.txt: Added.
fast/loader/unload-hyperlink-targeted.html: Added.

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Load blocks during unload should not affect targeted loads
https://bugs.webkit.org/show_bug.cgi?id=29747

Move the check of the unload state after checking for targeted links.

Test: fast/loader/unload-hyperlink-targeted.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL):

7:27 PM Changeset in webkit [48782] by eric@webkit.org

7 edits in trunk/JavaScriptCore

2009-09-25 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Fix unaligned data access in YARR_JIT on ARMv5 and below.
https://bugs.webkit.org/show_bug.cgi?id=29695

On ARMv5 and below all data access should be naturally aligned.
In the YARR_JIT there is a case when character pairs are
loaded from the input string, but this data access is not
naturally aligned. This fix introduces load32WithUnalignedHalfWords
and branch32WithUnalignedHalfWords functions which contain
naturally aligned memory loads - half word loads - on ARMv5 and below.

assembler/MacroAssemblerARM.cpp: (JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::load32WithUnalignedHalfWords): (JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32WithUnalignedHalfWords): (JSC::MacroAssemblerARMv7::branch32): (JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::load32WithUnalignedHalfWords): (JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
wtf/Platform.h:
yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generatePatternCharacterPair):

7:13 PM Changeset in webkit [48781] by eric@webkit.org

13 edits
5 copies
5 adds in trunk

2009-09-25 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[Chromium] Add initial V8 bindings for WebGL
https://bugs.webkit.org/show_bug.cgi?id=29664

WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/DOMObjectsInclude.h:
bindings/v8/DerivedSourcesAllInOne.cpp:
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
bindings/v8/V8Index.cpp:
bindings/v8/V8Index.h:
bindings/v8/custom/V8CanvasArrayBufferCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8CanvasArrayCustom.h: Added. (WebCore::constructCanvasArray):
bindings/v8/custom/V8CanvasByteArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasFloatArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasIntArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasRenderingContext3DCustom.cpp: Added. (WebCore::jsArrayToFloatArray): (WebCore::jsArrayToIntArray): (WebCore::CALLBACK_FUNC_DECL): (WebCore::): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
bindings/v8/custom/V8CanvasShortArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasUnsignedByteArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasUnsignedIntArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasUnsignedShortArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
platform/graphics/GraphicsContext3D.h:

6:45 PM Changeset in webkit [48780] by jorlow@chromium.org

4 edits in trunk

JavaScriptCore: This is breaking Chromium try bots, so I'm counting this as a build fix.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-25
Add more svn:ignore exceptions. On different platforms, these files are
generated with different case for JavaScriptCore. Also there are some
wtf project files that get built apparently.

JavaScriptCore.gyp: Changed property svn:ignore.

WebCore: This is breaking Chromium try bots, so I'm counting this as a build fix.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-25
Add more svn:ignore exceptions. On different platforms, these files are
generated with different case for WebCore.

WebCore.gyp: Changed property svn:ignore.

5:57 PM Changeset in webkit [48779] by adachan@apple.com

3 edits in trunk/JavaScriptCore

Build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

5:21 PM Changeset in webkit [48778] by ap@apple.com

30 edits
10 deletes in trunk

Reverting r48767, as it broke Windows build in a non-trivial way.

4:18 PM Changeset in webkit [48777] by agl@chromium.org

2 edits in trunk/WebCore

2009-09-24 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

Add a gyp variable to allow building a debug webcore without debug
symbols. This allows for faster compile, link, and gdb times.

https://bugs.webkit.org/show_bug.cgi?id=29721

No new tests, build config change.

WebCore.gyp/WebCore.gyp:

4:11 PM Changeset in webkit [48776] by darin@chromium.org

2 edits in trunk/WebCore

2009-09-25 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Declare RegisteredEventListener as a class instead of a struct.
This fixes a warning in the Chromium build.

dom/RegisteredEventListener.h:

4:07 PM Changeset in webkit [48775] by mitz@apple.com

6 edits in trunk

WebCore: WebCore part of
<rdar://problem/7211635> 2 byte characters are displayed as garbaged
<rdar://problem/7212626> garbled/gibberish text (off-by-one)

Reviewed by Jon Honeycutt.

When the Windows Fonts directory contains more than one font file for a
given font name, which of the fonts gets assigned to the name in the
Core Graphics font database was determined arbitrarily and did not
always match the font GDI used for the same font name. The mismatch
caused character-to-glyph mapping to use one font and glyph rendering to
use another.

The fix is to update the Core Graphics font database from the registry
entries (that reflect the name-to-font mapping that GDI uses) after
populating it with the result of scanning the Fonts directory. As a
consequence, the directory needs to be scanned at startup every time the
registry key changes, so the last value of the registry key is kept
in the property list on disk so that it could be compared to the current
value on startup.

platform/graphics/win/FontDatabase.cpp:

(WebCore::populateFontDatabaseFromPlist): Now takes a property list as
a parameter and avoids round-tripping through XML by calling
wkAddFontsFromPlist() instead of wkAddFontsFromPlistRepresentation().
(WebCore::fontFilenamesFromRegistryKey):
(WebCore::cgFontDBKey):
(WebCore::writeFontDatabaseToPlist): Now takes the CG font DB property
list and a property list with the font filenames from the registry and
writes a dictionary with those property lists as values.
(WebCore::fontFilenamesFromRegistry): Added. Returns an array with the
values in the HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Fonts
registry key.
(WebCore::populateFontDatabase): Changed to read the contents of the
Fonts registry key and compare it with the last-saved value from the
property list, and to call wkAddFontsFromRegistry() after populating the
CG font DB from the file system. Uses wkCreateFontsPlist() instead of
wkCreateFontsPlistRepresentation() to avoid round-tripping through XML.

WebKitLibraries: WebKitSystemInterface changes for
<rdar://problem/7211635> 2 byte characters are displayed as garbaged
<rdar://problem/7212626> garbled/gibberish text (off-by-one)

Reviewed by Adam Roben.

win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added

wkAddFontsFromPlistRepresentation() and replaced
wkCreateFontsPlistRepresentation() with wkCreateFontsPlist() and
wkAddFontsFromPlistRepresentation() with wkAddFontsFromPlist().

win/lib/WebKitSystemInterface.lib:
win/lib/WebKitSystemInterface_debug.lib:

3:26 PM Changeset in webkit [48774] by ggaren@apple.com

18 edits in trunk

JavaScriptCore: Inlined some object creation code, including lexicalGlobalObject access
https://bugs.webkit.org/show_bug.cgi?id=29750

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-25
Reviewed by Darin Adler.

SunSpider says 0.5% faster.

0.8% speedup on bench-alloc-nonretained.js.
2.5% speedup on v8-splay.js.

interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

interpreter/CallFrame.h:

(JSC::ExecState::lexicalGlobalObject):
(JSC::ExecState::globalThisValue):

interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::print):

runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::~ScopeChainNode):
(JSC::ScopeChainNode::push):
(JSC::ScopeChain::ScopeChain):
(JSC::ScopeChain::globalObject): Added a globalObject data member to ScopeChainNode.
Replaced accessor function for globalObject() with data member. Replaced
globalThisObject() accessor with direct access to globalThis, to match.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/JSGlobalObject.h: Inlined array and object construction.

WebCore: Inlined some object creation code, including lexicalGlobalObject access
https://bugs.webkit.org/show_bug.cgi?id=29750

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-25
Reviewed by Darin Adler.

bindings/js/JSInspectorBackendCustom.cpp:

(WebCore::JSInspectorBackend::currentCallFrame):

inspector/JavaScriptDebugServer.cpp:

(WebCore::JavaScriptDebugServer::hasBreakpoint): Updated for JavaScriptCore
API changes.

3:24 PM Changeset in webkit [48773] by hyatt@apple.com

5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=24399
Make @import work in user stylesheets. The first bug was that the URL wasn't being set on the
user sheets themselves, so relative @import URLs couldn't resolve properly. The second bug
was that the loads would be denied. This is fixed by using the requestUserCSSStyleSheet method
instead of the normal request method. In order to know when to do this, CSSStyleSheets now have
a propagated boolean, m_isUserStyleSheet, that lets them know if they are user stylesheets or not.

Reviewed by Anders Carlsson.

css/CSSImportRule.cpp:

(WebCore::CSSImportRule::insertedIntoParent):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):

css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::setIsUserStyleSheet):
(WebCore::CSSStyleSheet::isUserStyleSheet):

dom/Document.cpp:

(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):

3:02 PM Changeset in webkit [48772] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/29718> mark-bug-fixed: add -uupdate-only switch

Reviewed by Eric Seidel.

Scripts/mark-bug-fixed:

(MarkBugFixed.init): Added -uupdate-only switch to list

of parse options.

(MarkBugFixed.main): When -uupdate-only is specified, add a

comment to the bug without marking it Resolved/Fixed.

3:01 PM Changeset in webkit [48771] by Simon Fraser

3 edits
4 adds in trunk

2009-09-25 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Crash with hardware accelerated rotation of a PDF image in a data URL
<rdar://problem/7250378>

PDF images don't return a color space from CGImageGetColorSpace(),
so we need to null-check the return value before use.

Test: compositing/color-matching/pdf-image-match.html

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):

2:40 PM Changeset in webkit [48770] by Darin Adler

2 edits in trunk/WebKit/win

Speed up access to history items by caching date computation.

Patch by Darin Adler <Darin Adler> on 2009-09-25
Reviewed by Steve Falkenburg.

History/WebHistory.mm:

(getDayBoundaries): Refactored from timeIntervalForBeginningOfDay.
Returns the beginning of the day that the passed time is within and
the beginning of the next day.
(beginningOfDay): Added. Uses getDayBoundaries so it can be fast for
multiple dates within the same day, which is the common case.
(dateKey): Added. Calls beginningOfDay and converts to an integer.
(WebHistory::findKey): Changed to call dateKey instead of
timeIntervalForBeginningOfDay.

2:08 PM Changeset in webkit [48769] by Darin Adler

8 edits
1 copy
5 adds in trunk

Null-deref when first access to an Attr node is after its Element is destroyed
https://bugs.webkit.org/show_bug.cgi?id=29748

Patch by Darin Adler <Darin Adler> on 2009-09-25
Reviewed by Geoffrey Garen.

WebCore:

Test: fast/dom/Attr/access-after-element-destruction.html

bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::markChildren): Added. Keeps the ownerElement alive as
long as the Attr is alive.

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::markChildren): Added. Keeps the Element alive as
long as the NamedNodeMap is alive.

dom/Attr.idl: Added CustomMarkFunction attribute.

dom/NamedAttrMap.cpp:

(WebCore::NamedNodeMap::getAttributeItem): Tweaked formatting.
(WebCore::NamedNodeMap::detachFromElement): Call clearAttributes so we don't
have attributes hanging around that might need an Attr node created; that way
we won't crash with a null-dereference trying to deal with one of them. This
can't happen when working with JavaScript since the Element will be kept
alive due to the change above.
(WebCore::NamedNodeMap::addAttribute): Fix function name in comment.
(WebCore::NamedNodeMap::removeAttribute): Removed unneeded "+ 1" and added
missing braces.

dom/NamedAttrMap.h: Made the element function public so it can be used by

the JavaScript binding to keep the Element alive.

dom/NamedNodeMap.idl: Added CustomMarkFunction attribute.

LayoutTests:

fast/dom/Attr/access-after-element-destruction-expected.txt: Added.
fast/dom/Attr/access-after-element-destruction.html: Added.
fast/dom/Attr/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Node/script-tests/TEMPLATE.html.
fast/dom/Attr/script-tests/access-after-element-destruction.js: Added.

2:07 PM Changeset in webkit [48768] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/prepare-ChangeLog: Leave files from the script-tests directory

out, just as we do for the resources directory.

Reviewed by Geoffrey Garen.

1:44 PM Changeset in webkit [48767] by ap@apple.com

30 edits
10 adds in trunk

Reviewed by Darin Adler and Sam Weinig.

Onclick not fired for an element copied with cloneContents() or cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=25130

The change here is that JS event listeners don't keep a reference to a global object from
where they were created, and instead take it as a parameter when parsing source code. Also,
the listener creation won't fail just because it happens for an element in a frameless
document.
Thus, moving nodes between documents no longer results in having incorrect registered
lazy event listeners on them.

Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html

fast/events/attribute-listener-cloned-from-frameless-doc-context.html
fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
fast/events/attribute-listener-extracted-from-frameless-doc-context.html

bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject. (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner. (WebCore::JSEventListener::markJSFunction): Don't mark the global object. (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext. (WebCore::JSEventListener::reportError): Ditto.

bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference to JSDOMGlobalObject.

bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener creation was split between this function and ScriptEventListener; moved it here, as JS global object can be different now.

bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL, which can not be determined at parsing time.

bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests expect that errors are logged at document parsing time, and because I don't know what other side effects moving it vould have.

dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext, because JSC needs a global context here.

bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener):
bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
bindings/js/JSEventSourceCustom.cpp: (WebCore::JSEventSource::addEventListener): (WebCore::JSEventSource::removeEventListener):
bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
bindings/objc/ObjCEventListener.h:
bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
bindings/scripts/CodeGeneratorJS.pm:
dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
inspector/InspectorDOMAgent.h:
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
inspector/InspectorDOMStorageResource.h:
loader/ImageDocument.cpp: (WebCore::ImageEventListener::handleEvent):
svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::handleEvent):
workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException): Don't pass global object to JSEventListener::create(), which no longer needs it. Note that some of these functions still have an early return for null global object, which can probably be removed in a later patch. Pass ScriptExecutionContext to EventListener methods that now need it.

1:24 PM Changeset in webkit [48766] by Darin Adler

1 edit
1 add in trunk/LayoutTests

Checked in a file that was created by make-script-test-wrappers.

Patch by Darin Adler <Darin Adler> on 2009-09-25

platform/gtk/editing/pasteboard/middle-click-onpaste.html: Added.

1:00 PM Changeset in webkit [48765] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-09-25 Adam Barth <abarth@webkit.org>

Unreviewed. Added Tony to committers.py because he's a
committer now.

Scripts/modules/committers.py:

11:55 AM Changeset in webkit [48764] by adele@apple.com

5 edits
2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29740
<rdar://problem/7168738> Gmail: After changing a foreground text color, pressing return doesn't apply background to new line

Patch by Enrica Casucci <enrica@apple.com> on 2009-09-25
Reviewed by Darin Adler, Dan Bernstein, Adele Peterson, and others.

Change the way style is preserved when inserting a new paragraph.
The original code handled insertion at the beginning and at the end of a paragraph as special
cases. The newly created paragraph contained a set of nodes generated starting from the
computed style of the insertion node. This approach has two problems:

if the insertion node has a non opaque background color and one of the parent element did have

a solid background color the new paragraph did not have the element with the solid color in the tree.

in some circumstances it generated more markup than the original paragraph had (a span with bold, italic,

background color and some font attribute was being reproduced as span + bold + italic + font as separate tags.
The new approach is to recreate in the new paragraph the same hierarchy of nodes found in the
paragraph where the insertion point is.

Test: editing/inserting/insert-bg-font.html

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock): retrieves the list of all the ancestors
between the insert node and the outer block.
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock): uses the list of ancestors to recreate
in the new paragraph the same element hierarchy present in the starting paragraph.
(WebCore::InsertParagraphSeparatorCommand::doApply): changed the code to handle the general case of insertion
in the middle of the paragraph to use the new methods. Changed the handling of the insertion at the beginning and
at the end of the paragraph to use the new methods instead of applying the calculated style.

editing/InsertParagraphSeparatorCommand.h: added methods getAncestorsInsideBlock and cloneHierarchyUnderNewBlock.

LayoutTests: Updated the expected results to reflect the changes in the way the new paragraph
is created and added test case for https://bugs.webkit.org/show_bug.cgi?id=29740
<rdar://problem/7168738> Gmail: After changing a foreground text color, pressing return doesn't apply background to new line

Patch by Enrica Casucci <enrica@apple.com> on 2009-09-25
Reviewed by Darin Adler, Dan Bernstein, Adele Peterson, and others.

editing/inserting/insert-bg-font.html: Added.
platform/mac/editing/inserting/insert-bg-font-expected.txt: Added.
platform/mac/editing/pasteboard/5478250-expected.txt:

11:36 AM Changeset in webkit [48763] by eric@webkit.org

4 edits in trunk/WebCore

2009-09-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Content-type parameters not taken into account when building form-data
https://bugs.webkit.org/show_bug.cgi?id=28970

existing manual test case extended with new tests

English.lproj/localizedStrings.js:
inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshParms):
manual-tests/inspector/display-form-data.html:

11:27 AM Changeset in webkit [48762] by eric@webkit.org

5 edits in trunk/WebKitTools

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should auto-retry patches which fail to commit due to out of date files
https://bugs.webkit.org/show_bug.cgi?id=28316

Scripts/bugzilla-tool:
- Handle new CheckoutNeedsUpdate exception.
Scripts/modules/logging_unittest.py:
- Call the ScriptError constructor correctly (this test had regressed).
Scripts/modules/scm.py:
- Added the ability to define custom error handlers for run_command and added a commit_error_handler which throws CheckoutNeedsUpdate instead of ScriptError.
- Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
Scripts/modules/scm_unittest.py:
- Added tests of new error handlers.

10:53 AM Changeset in webkit [48761] by eric@webkit.org

6 edits
4 adds in trunk

2009-09-25 Yuan Song <song.yuan@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=14566

Add test "invalid-domain-change-throws-exception.html" to ensure a SECURITY_ERR exception is raised if an attempt is made to change document.domain to an invalid value. In the existing test case "basic-textareas.html", fix the faulty behavior of setting document.domain to invalid value, and replace the data URL to a file URL that points to "basic-textareas-standards.html" in order to make "basic-textareas.html" runnable in a browser.

fast/forms/basic-textareas.html:
fast/forms/resources/basic-textareas-standards.html: Added.
fast/js/invalid-domain-change-throws-exception-expected.txt: Added.
fast/js/invalid-domain-change-throws-exception.html: Added.
fast/js/resources/invalid-domain-change-throws-exception.js: Added.

2009-09-25 Yuan Song <song.yuan@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=14566

Raise SECURITY_ERR exception if an attempt is made to change document.domain to an invalid value.

Test: fast/js/invalid-domain-change-throws-exception.html

dom/Document.cpp: (WebCore::Document::setDomain):
dom/Document.h:
dom/Document.idl:

10:40 AM Changeset in webkit [48760] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should give better feedback when failing a patch
https://bugs.webkit.org/show_bug.cgi?id=29316

Scripts/bugzilla-tool:
- Update ScriptError uses to the new constructor format.
- Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output so that we can print to both stdout as well as an output buffer for error reporting.
- Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
- Use e.message_with_output() when failing a patch (this is the real fix here). I also removed use of "This patch will require manual commit." as that's not always true.
- Add missing word "bug" from log message.
Scripts/modules/scm.py:
- Make ScriptError save a bunch more data so that error messages can be nicer.
- Update ScriptError callers.

10:31 AM BuildingOnWindows edited by dbates@webkit.org

Changed title of subsection to reflect fix for linker problems (diff)

9:36 AM Changeset in webkit [48759] by eric@webkit.org

3 edits
2 adds in trunk

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

Test a strange error condition after clearing a setInterval
timer. The key point is not to crash on this test.

fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Added.
fast/dom/timer-clear-interval-in-handler-and-generate-error.html: Added.

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

When setTimeout is called with a string argument in an isolated
world, we now compile the string in the isolated world.

Last time we tried this change, we got a lot of crashes. This
time we're using a fresh local handle as our context to avoid
trouble if the peristent handle gets disposed before we leave
the context.

Test: fast/dom/timer-clear-interval-in-handler-and-generate-error.html

bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):

9:30 AM Changeset in webkit [48758] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-25 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Make tst_qwebframe work if Qt built without SSL support
https://bugs.webkit.org/show_bug.cgi?id=29735

tests/qwebframe/tst_qwebframe.cpp: Missing #ifndef blocks added.

9:23 AM Changeset in webkit [48757] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-25 Paul Godavari <paul@chromium.org>

Reviewed by Darin Fisher.

Fix a regression in Mac Chromium popup menus, where the user's
selection was ignored and the popup became unresponsive.
https://bugs.webkit.org/show_bug.cgi?id=29726

The fix is to notify the popup's client that the popup was hidden,
even if the popup has no parent.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::hidePopup):

9:10 AM Changeset in webkit [48756] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-25 Laszlo Gombos <Laszlo Gombos>

Reviewed by Gavin Barraclough.

Add ARM version detection rules for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29715

wtf/Platform.h:

8:47 AM Changeset in webkit [48755] by pfeldman@chromium.org

5 edits in trunk/WebCore

2009-09-25 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Dan Bernstein.

Enable Pasteboard::writePlainText for Chromium and fix code style nits.
https://bugs.webkit.org/show_bug.cgi?id=29734

platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writePlainText):
platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writePlainText):

8:32 AM Changeset in webkit [48754] by Adam Roben

4 edits in trunk/WebKit/win

Add SPI to invalidate a WebView's backing store

This is useful in conjunction with
IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI
delegate to force WebView to get its background redrawn.

Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's
backing store

Reviewed by Anders Carlsson.

Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore.
WebView.cpp:

(WebView::invalidateBackingStore): If rect is 0, invalidate our whole
client rect. Otherwise invalidate the intersection of rect with our
client rect.

WebView.h:

7:01 AM Changeset in webkit [48753] by kov@webkit.org

4 edits in trunk/WebKit/gtk

2009-09-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Pop down the context menu when the page transitions to committed,
to avoid keeping a context menu out of context.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
webkit/webkitprivate.h:
webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event):

1:54 AM Changeset in webkit [48752] by Simon Hausmann

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28876
[Qt] reduce peak memory consumption of text decoding.

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-09-25
Reviewed by Ariya Hidayat.

Chop large input buffer into small buffers to reduce peak memory
during decoding.

platform/text/qt/TextCodecQt.cpp:

(WebCore::TextCodecQt::decode):

1:53 AM Changeset in webkit [48751] by Simon Hausmann

4 edits in trunk/WebKit/qt

[Qt] Update QWebElement API to remove script related methods.
QWebElement::evaluateScript is the only one kept, these are
removed to postpone most of the QtWebKit<->JavaScript API design
after 4.6.
https://bugs.webkit.org/show_bug.cgi?id=29708

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-24
Reviewed by Simon Hausmann.

Api/qwebelement.cpp:
Api/qwebelement.h:

Methods removed:

QWebElement::callFunction
QWebElement::functions
QWebElement::scriptableProperty
QWebElement::setScriptableProperty
QWebElement::scriptableProperties
tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::evaluateScript):

1:19 AM Changeset in webkit [48750] by Simon Hausmann

4 edits in trunk/WebKit/qt

[Qt] Rename QWebElement::evaluateScript
to QWebElement::evaluateJavaScript.
https://bugs.webkit.org/show_bug.cgi?id=29709

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-25
Reviewed by Simon Hausmann.

Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript):

Api/qwebelement.h:
tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::evaluateJavaScript):

1:18 AM Changeset in webkit [48749] by Simon Hausmann

5 edits in trunk/WebKit/qt

[Qt] Update the stypeProperty API of QWebElement.
https://bugs.webkit.org/show_bug.cgi?id=29711

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-25
Reviewed by Simon Hausmann.

Api/qwebelement.cpp:

(QWebElement::styleProperty):

Merge the stypeProperty and the computedStyleProperty methods
Remove the default value for the style resolving enum
Rename ResolveRule to StyleResolveStrategy

(QWebElement::setStyleProperty):

Remove the priority argument since it is possible to control the behaviour by adding !important or removing in the value.
Api/qwebelement.h:
tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::style):
(tst_QWebElement::computedStyle):

tests/qwebframe/tst_qwebframe.cpp:

Sep 24, 2009:

11:53 PM Changeset in webkit [48748] by jhoneycutt@apple.com

30 edits
7 adds in trunk

Add a mechanism for automatically halting plug-ins.

Reviewed by Oliver Hunt and Alice Liu.

WebCore:

GNUmakefile.am:

WebCore.base.exp:

Update export of Page constructor.

WebCore.gypi:

WebCore.pro:

WebCore.vcproj/WebCore.vcproj:

Add PluginHalter.{h,cpp}, PluginHalterClient.h, and
HaltablePlugin.h.

WebCore.xcodeproj/project.pbxproj:

Add files to Mac project.

loader/EmptyClients.h:

Added an empty PluginHalterClient.
(WebCore::EmptyPluginHalterClient::shouldHaltPlugin):
Return false.

page/PluginHalter.cpp: Added.

(WebCore::PluginHalter::PluginHalter):
(WebCore::PluginHalter::didStartPlugin):
Add the object to the plug-in set. If this is the only item in the set,
set m_oldestStartTime to this object's time, and start the timer.
(WebCore::PluginHalter::didStopPlugin):
Remove the plug-in from the set.
(WebCore::PluginHalter::timerFired):
Find the cut-off time as the current time minus the allowed run time;
plug-ins older than this may be halted. Iterate over the plug-ins. Find
the object with the oldest start time that is too young to be halted;
we'll use its start time to set the timer's next fire time. For all
plug-ins that are candidates to be halted, call the
PluginHalterClient's shouldHaltPlugin(). If this function returns true,
call the plug-in's halt() function. Remove these objects from the set
of tracked plug-ins. Call startTimerIfNecessary() to restart the timer.
(WebCore::PluginHalter::startTimerIfNecessary):
If the timer is set to fire, or the set of tracked plug-ins is empty,
return early. Set the timer to fire after the oldest plug-in has run
for the allowed run time.

page/PluginHalter.h: Added.

(WebCore::PluginHalter::setPluginAllowedRunTime):

page/PluginHalterClient.h: Added.

(WebCore::PluginHalterClient::~PluginHalterClient)

page/Page.cpp:

(WebCore::Page::Page):
Initialize m_pluginHalterClient. Call pluginHalterEnabledStateChanged()
to create the PluginHalter if necessary.
(WebCore::Page::pluginHalterEnabledStateChanged):
If plug-in halting is enabled, create the PluginHalter. If it is
disabled, clear it.
(WebCore::Page::pluginAllowedRunTimeChanged):
If there is a plug-in halter, call its setPluginAllowedRunTime().
(WebCore::Page::didStartPlugin):
If there is a plug-in halter, call its didStartPlugin().
(WebCore::Page::didStopPlugin):
If there is a plug-in halter, call its didStopPlugin().

page/Page.h:

Add a parameter to the Page constructor for the PluginHalterClient.
Added declarations for didStartPlugin() and didStopPlugin(), which are
called when HaltablePlugins are added to or removed from the page. Adds
pluginAllowedRunTimeChanged() and pluginHalterEnabledStateChanged() to
notify the Page when these settings are changed. Added members to hold
the PluginHalter and the PluginHalterClient.

page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setPluginHalterEnabled):
If the enabled state has changed, call the Page's
pluginHalterEnabledStateChanged().
(WebCore::Settings::setPluginAllowedRunTime):
Call the Page's pluginAllowedRunTimeChanged().

page/Settings.h:

(WebCore::Settings::pluginHalterEnabled):
(WebCore::Settings::pluginAllowedRunTime):

page/HaltablePlugin.h: Added. Defines an interface for plug-ins that

can be automatically halted.
(WebCore::HaltablePlugin::~HaltablePlugin)

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):
Pass a dummy PluginHalterClient.

WebKit/gtk/:

webkit/webkitwebview.cpp:

(webkit_web_view_init):
Pass 0 for new Page constructor argument.

WebKit/mac/:

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
Pass 0 for new Page constructor argument.

WebKit/qt/:

Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
Pass 0 for new Page constructor argument.

WebKit/win:

Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface

for a delegate that determines whether plug-ins should be halted.

Interfaces/IWebPreferencesPrivate.idl:

Declare functions to get and set the enabled state of the plug-in
halter and the plug-in allowed run time.

Interfaces/IWebViewPrivate.idl:

Declare functions to get and set the IWebPluginHalterDelegate.

Interfaces/WebKit.idl:

WebCoreSupport/WebPluginHalterClient.cpp: Added.

(WebPluginHalterClient::WebPluginHalterClient):
(WebPluginHalterClient::shouldHaltPlugin):
Get the IWebPluginHalterDelegate for the WebView. Create a WebKit
DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin().
If the call fails, return false. Otherwise, return the result of the
call.

WebCoreSupport/WebPluginHalterClient.h: Added.

WebKit.vcproj/Interfaces.vcproj:

Add IWebPluginHalterDelegate.idl.

WebKit.vcproj/WebKit.vcproj:

Add WebPluginHalterClient.{h,cpp}.

WebPreferenceKeysPrivate.h:

Define WebKitPluginHalterEnabledPreferenceKey and
WebKitPluginAllowedRunTimePreferenceKey.

WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
Leave plug-in halting disabled by default. Set the default value for
the plug-in allowed run time to the max value of an unsigned int.
(WebPreferences::setPluginHalterEnabled):
(WebPreferences::pluginHalterEnabled):
(WebPreferences::setPluginAllowedRunTime):
(WebPreferences::pluginAllowedRunTime):

WebPreferences.h:

WebView.cpp:

(WebView::close):
Clear the IWebPluginHalterDelegate.
(WebView::initWithFrame):
Pass a WebPluginHalterClient when creating the Page.
(WebView::notifyPreferencesChanged):
Set the new settings when the preferences changed notification is
received.
(WebView::setPluginHalterDelegate):
(WebView::pluginHalterDelegate):

WebView.h:

Declare overrides of setPluginHalterDelegate() and
pluginHalterDelegate(). Added a member to track the
IWebPluginHalterDelegate.

11:26 PM Changeset in webkit [48747] by xan@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark "Do It!" Rowe.

Some GCC versions don't like C++-style comments in preprocessor
directives, change to C-style to shut them up.

wtf/Platform.h:

8:53 PM Changeset in webkit [48746] by Simon Fraser

3 edits
4 adds in trunk

2009-09-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

REGRESSION: webkit-transform scale no longer works properly in nightly build
https://bugs.webkit.org/show_bug.cgi?id=29730

When the initial or final state of a scale animation does not specify a transform,
use a default scale of 1, rather than zero.

Test: compositing/transitions/scale-transition-no-start.html

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::getTransformFunctionValue):

7:45 PM Changeset in webkit [48745] by atwilson@chromium.org

21 edits in trunk

WebCore: isEnabled switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930

Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.

Adds a run-time flag in Settings object that controls whether
to expose desktop notifications.

No new test, but test code also modified to set this preference.

page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications): check preference before returning notifications object

page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setExperimentalNotificationsEnabled):

page/Settings.h:

(WebCore::Settings::experimentalNotificationsEnabled):

WebKit/mac: isEnabled switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930

Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.

Adds support for the experimentalNotificationsEnabled flag in Settings
through WebPreferencesPrivate.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences experimentalNotificationsEnabled]):
(-[WebPreferences setExperimentalNotificationsEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/win: Enable switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930

Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.

Adds support for the experimentalNotificationsEnabled flag in Settings through
WebPreferencesPrivate interface. Also cleans up some issues accessing the
notification delegate through DumpRenderTree.

Interfaces/IWebPreferencesPrivate.idl:
WebCoreSupport/WebDesktopNotificationsDelegate.cpp:

(WebDesktopNotificationsDelegate::hasNotificationDelegate):
(WebDesktopNotificationsDelegate::notificationDelegate):

WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setExperimentalNotificationsEnabled):
(WebPreferences::experimentalNotificationsEnabled):

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKitTools: Enable switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930

Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.

Now that desktop notifications are controlled by run-time switch,
set that switch to true for DumpRenderTree.

DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::QueryInterface):

7:40 PM Changeset in webkit [48744] by oliver@apple.com

5 edits in trunk/JavaScriptCore

Division is needlessly slow in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=29723

Reviewed by Gavin Barraclough.

Add codegen for op_div on x86-64

7:25 PM Changeset in webkit [48743] by mitz@apple.com

3 edits
2 adds in trunk

WebCore: Fix <rdar://problem/7162000> Crash while trying to
calculate the horizontal position of image

Reviewed by Sam Weinig.

Test: fast/inline-block/relative-positioned-rtl-crash.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Corrected an
isInline() test to isRenderInline(). This is similar to r41259.

LayoutTests: Test for <rdar://problem/7162000> Crash while trying to
calculate the horizontal position of image

Reviewed by Sam Weinig.

fast/inline-block/relative-positioned-rtl-crash-expected.txt: Added.
fast/inline-block/relative-positioned-rtl-crash.html: Added.

7:16 PM Changeset in webkit [48742] by jberlin@webkit.org

2 edits in trunk/WebCore

Fix expanding profile call stacks being broken after sorting.
https://bugs.webkit.org/show_bug.cgi?id=26423

Patch by Jessie Berlin <jberlin@webkit.org> on 2009-09-24
Reviewed by Timothy Hatcher.

inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.sort):
Set shouldRefreshChildren to true on collapsed nodes with children so that expanding it
causes the children to be placed in the right positions.

6:13 PM Changeset in webkit [48741] by kevino@webkit.org

4 edits in trunk/WebKitTools

wx build fix. SnowLeopard fixes for Mac dependencies.

5:18 PM Changeset in webkit [48740] by ggaren@apple.com

2 edits in trunk/WebCore

Fixed sudden termination console spew due to too many calls to
enableSuddenTermination.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Reviewed by Stephanie Lewis.

<rdar://problem/7063125> 10A410: Safari logging enableSuddenTermination errors

page/DOMWindow.cpp:

(WebCore::removeUnloadEventListener):
(WebCore::removeAllUnloadEventListeners):
(WebCore::removeBeforeUnloadEventListener):
(WebCore::removeAllBeforeUnloadEventListeners): Only
enableSuddenTermination if the set of listeners is empty *and* this
window was in the set. Otherwise, a no-op will cause us to enableSuddenTermination.

4:44 PM Changeset in webkit [48739] by eric@webkit.org

6 edits
2 deletes in trunk

2009-09-24 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Alexey Proskuryakov.

WebKit returns "" instead of null when getting
inexistent, forbidden or invalidly named headers.
https://bugs.webkit.org/show_bug.cgi?id=29140

http/tests/xmlhttprequest/get-dangerous-headers.html: Updated to test for null instead of ""
http/tests/xmlhttprequest/getResponseHeader-expected.txt:
http/tests/xmlhttprequest/getResponseHeader.html: Extended to also test for headers that should return null.
http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html: Removed. getResponseHeader.html now covers this case as well.

2009-09-24 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Alexey Proskuryakov.

WebKit returns "" instead of null when getting
inexistent, forbidden or invalidly named headers.
https://bugs.webkit.org/show_bug.cgi?id=29140

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseHeader): Changed to return null as it should according to the spec.

3:34 PM Changeset in webkit [48738] by jorlow@chromium.org

4 edits in trunk

JavaScriptCore: Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29724

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-24
Reviewed by Dimitri Glazkov.

Adding the following files to the svn:ignore list (all in the
JavaScriptCore/JavaScriptCore.gyp directory)

JavaScriptCore.xcodeproj
JavaScriptCore.sln
JavaScriptCore.vcproj
JavaScriptCore_Debug.rules
JavaScriptCore_Release.rules
JavaScriptCore_Release - no tcmalloc.rules
JavaScriptCore_Purify.rules
JavaScriptCore.mk
JavaScriptCore_Debug_rules.mk
JavaScriptCore_Release_rules.mk
JavaScriptCore_Release - no tcmalloc_rules.mk
JavaScriptCore_Purify_rules.mk
JavaScriptCore.scons
JavaScriptCore_main.scons

JavaScriptCore.gyp: Changed property svn:ignore.

WebCore: Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29724

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-24
Reviewed by Dimitri Glazkov.

Adding the following files to the svn:ignore list (all in the
WebCore/WebCore.gyp directory)

WebCore.xcodeproj
WebCore.sln
WebCore.vcproj
WebCore_Debug.rules
WebCore_Release.rules
WebCore_Release - no tcmalloc.rules
WebCore_Purify.rules
WebCore.mk
WebCore_Debug_rules.mk
WebCore_Release_rules.mk
WebCore_Release - no tcmalloc_rules.mk
WebCore_Purify_rules.mk
WebCore.scons
WebCore_main.scons

WebCore.gyp: Changed property svn:ignore.

3:24 PM Changeset in webkit [48737] by kov@webkit.org

2 edits in trunk/WebCore

Unreviewed Mac build fix

3:00 PM Changeset in webkit [48736] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2009-09-24 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

Replace platform-dependent code with WTF::currentTime()
https://bugs.webkit.org/show_bug.cgi?id=29148

jsc.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS):
runtime/TimeoutChecker.cpp: (JSC::getCPUTime):

2:58 PM Changeset in webkit [48735] by kov@webkit.org

8 edits
3 adds in trunk

Implement correct horizontal scrollbar behavior for GTK+

WebCore

2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Oliver Hunt.

Implement correct horizontal scrollbar behavior for GTK+ also on
styled scrollbars.

https://bugs.webkit.org/show_bug.cgi?id=29348
[Gtk] Scrollwheel on horizontal scrollbars should slide horizontally

Test: platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html

page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): on GTK+, when using the wheel with the pointer on the horizontal scrollbar, scroll horizontally;
platform/PlatformWheelEvent.h:
platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::swapOrientation): allow adding a vertical scroll to the horizontal one;

WebKitTools

2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Oliver Hunt.

Add support for DRT to send mouse wheel events.

https://bugs.webkit.org/show_bug.cgi?id=29348
[Gtk] Scrollwheel on horizontal scrollbars should slide horizontally

DumpRenderTree/gtk/EventSender.cpp: (mouseWheelToCallback):

LayoutTests

2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Oliver Hunt.

Test for correct wheel scrolling behavior.

https://bugs.webkit.org/show_bug.cgi?id=29348
[Gtk] Scrollwheel on horizontal scrollbars should slide horizontally

platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html: Added.
platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll-expected.txt: Added.

2:36 PM Changeset in webkit [48734] by jorlow@chromium.org

7 edits in trunk/WebCore

2009-09-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

StorageNamespace::storageArea() should take in a PassRefPtr<StorageOrigin>
https://bugs.webkit.org/show_bug.cgi?id=29290

Modified StorageNamespace::storageArea() to take in a PassRefPtr<StorageOrigin>
per http://webkit.org/coding/RefPtr.html

No behavior change, so no tests.

storage/StorageNamespace.h:
storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
storage/StorageNamespaceImpl.h:

2:25 PM Changeset in webkit [48733] by mrowe@apple.com

4 edits in trunk/JavaScriptCore

<rdar://problem/7215058> FastMalloc scavenging thread should be named

Reviewed by Sam Weinig.

wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavengerThread): Set the thread name.

wtf/Platform.h: Move the knowledge of whether pthread_setname_np exists to here as HAVE(PTHREAD_SETNAME_NP).
wtf/ThreadingPthreads.cpp:

(WTF::setThreadNameInternal): Use HAVE(PTHREAD_SETNAME_NP).

2:18 PM Changeset in webkit [48732] by ggaren@apple.com

4 edits in trunk

JavaScriptCore: Renamed clear to removeAll, as suggested by Darin Adler.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Reviewed by Sam Weinig.

wtf/HashCountedSet.h:

(WTF::::removeAll):

WebCore: Added back enable/disableSuddenTermination() functionality I accidentally
removed in my last patch.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Reviewed by Sam Weinig.

page/DOMWindow.cpp:

(WebCore::addUnloadEventListener):
(WebCore::removeUnloadEventListener):
(WebCore::removeAllUnloadEventListeners):
(WebCore::addBeforeUnloadEventListener):
(WebCore::removeBeforeUnloadEventListener):
(WebCore::removeAllBeforeUnloadEventListeners):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

2:15 PM Changeset in webkit [48731] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Fix FastMalloc to build with assertions enabled.

Reviewed by Gavin Barraclough.

wtf/FastMalloc.cpp:

(WTF::TCMalloc_Central_FreeList::ReleaseToSpans):

wtf/TCSpinLock.h:

(TCMalloc_SpinLock::IsHeld):

1:40 PM Changeset in webkit [48730] by eric@webkit.org

2 edits
12 adds in trunk/WebKitTools

2009-09-17 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

commit-queue needs web-based status reporting
https://bugs.webkit.org/show_bug.cgi?id=29307

Add a first-pass web-based status for the commit-queue.
The bot is currently reachable at:
http://webkit-commit-queue.appspot.com/

CommitQueueStatus/app.yaml: Added.
- Application description file required by App Engine.
CommitQueueStatus/filters/init.py: Added.
- Required by python to treat 'filters' as a module.
CommitQueueStatus/filters/webkit_extras.py: Added.
- Support for turning 'bug 123' and 'patch 123' into links. This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
CommitQueueStatus/index.html: Added.
CommitQueueStatus/index.yaml: Added.
- Some auto-generated file from app engine.
CommitQueueStatus/queue_status.py: Added.
- The core logic of this bot. We could eventually split this file out into pieces.
CommitQueueStatus/stylesheets/main.css: Added.
- Some basic lame-o CSS to make the page look less awful.
CommitQueueStatus/update_status.html: Added.
- The form that the commit-queue (or a human) can use to update the status.
Scripts/bugzilla-tool:
- Add some very basic update_status calls.
Scripts/modules/statusbot.py: Added.
- Knows how to post to the CommitQueueStatus web application.

1:32 PM Changeset in webkit [48729] by weinig@apple.com

2 edits in trunk/WebCore

Don't pass -F to GCC on non-mac platforms since it is an darwin only.

Reviewed by Steve Falkenburg and Mark Rowe.

DerivedSources.make:

12:42 PM Changeset in webkit [48728] by weinig@apple.com

2 edits in trunk/WebCore

Fix windows build.

dom/Element.idl:

12:37 PM Changeset in webkit [48727] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Suggested by Darin Adler.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Removed some unnecessary parameter names.

wtf/HashCountedSet.h:

11:51 AM Changeset in webkit [48726] by senorblanco@chromium.org

3 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=29696 ([CHROMIUM] Paths fail to render in SVG with large viewbox)

Revert the relevant parts of r47925, and implement an alternate
fix (localize the coordinate check to GraphicsContext::clipPath()).
See http://crbug.com/21174.

Reviewed by Eric Seidel.

Covered by LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html.

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipPath):

platform/graphics/skia/PlatformContextSkia.cpp:

(PlatformContextSkia::currentPathInLocalCoordinates):

11:18 AM Changeset in webkit [48725] by beidson@apple.com

2 edits in trunk/WebCore

Merge changes from Mozilla's FTP directory parser.
<rdar://problem/7227620> and https://bugs.webkit.org/show_bug.cgi?id=29294

Reviewed by Sam Weinig.

FTP layout tests not possible at this time.
https://bugs.webkit.org/show_bug.cgi?id=29719 tracks making them possible.

loader/FTPDirectoryParser.cpp:

(WebCore::ParsingFailed):
(WebCore::parseOneFTPLine):

10:55 AM Changeset in webkit [48724] by kov@webkit.org

4 edits in trunk

WebCore

2009-09-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] re-enable some media tests
https://bugs.webkit.org/show_bug.cgi?id=29716

make canPlayType() return "probably" if mime-type is known
and codecs string is not empty. If codecs is empty return
"maybe".

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):

LayoutTests

2009-09-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] re-enable some media tests
https://bugs.webkit.org/show_bug.cgi?id=29716

platform/gtk/Skipped:

10:47 AM Changeset in webkit [48723] by weinig@apple.com

29 edits in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29703
Add a function to element to check whether it matches a CSS selector

Reviewed by Dan Bernstein.

Implement Element.webkitMatchesSelector.

css/CSSSelectorList.cpp:

(WebCore::forEachTagSelector):
(WebCore::forEachSelector):
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
(WebCore::CSSSelectorList::selectorsNeedNamespaceResolution):

css/CSSSelectorList.h:

Moved code to iterate the CSSSelectorList and determine if any
selectors need namespace resolution from a static function in
Node.cpp to CSSSelectorList so that it can be used by webkitMatchesSelector
as well as querySelector/querySelectorAll.

dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

dom/Element.h:
dom/Element.idl:

Implement the new function. Handles exceptional cases identically to
querySelector/querySelectorAll.

dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
Moved selectorsNeedNamespaceResolution to CSSSelectorList from here.

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=29703
Add a function to element to check whether it matches a CSS selector

Reviewed by Dan Bernstein.

Add webkitMatchesSelector to SelectorAPI tests.

fast/dom/SelectorAPI/caseID-almost-strict-expected.txt:
fast/dom/SelectorAPI/caseID-almost-strict.html:
fast/dom/SelectorAPI/caseID-expected.txt:
fast/dom/SelectorAPI/caseID-strict-expected.txt:
fast/dom/SelectorAPI/caseID-strict.html:
fast/dom/SelectorAPI/caseID.html:
fast/dom/SelectorAPI/caseTag-expected.txt:
fast/dom/SelectorAPI/caseTag.html:
fast/dom/SelectorAPI/caseTagX-expected.txt:
fast/dom/SelectorAPI/caseTagX.xhtml:
fast/dom/SelectorAPI/detached-element-expected.txt:
fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
fast/dom/SelectorAPI/not-supported-namespace-in-selector.html:
fast/dom/SelectorAPI/script-tests/detached-element.js:
fast/dom/SelectorAPI/script-tests/undefined-null-stringify.js:
fast/dom/SelectorAPI/script-tests/viewless-document.js:
fast/dom/SelectorAPI/undefined-null-stringify-expected.txt:
fast/dom/SelectorAPI/viewless-document-expected.txt:
fast/dom/Window/window-properties-expected.txt:
fast/dom/domListEnumeration-expected.txt:
fast/dom/script-tests/domListEnumeration.js:

10:14 AM Changeset in webkit [48722] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/29712> mark-bug-fixed: add -mcomment switch

Reviewed by Adam Roben.

Scripts/mark-bug-fixed:

(MarkBugFixed.init): Added -mcomment switch to list of

parse options.
(MarkBugFixed.main): When specified, prepend comment from

-mcomment command-line switch to the bug comment.

7:15 AM Changeset in webkit [48721] by kov@webkit.org

2 edits in trunk/WebKitTools

2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Jan Alonzo.

[GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
https://bugs.webkit.org/show_bug.cgi?id=29693

Show the window, to be able to synthesize events correctly.

DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): (main):

7:11 AM Changeset in webkit [48720] by pfeldman@chromium.org

11 edits in trunk/WebCore

2009-09-24 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fixed bindings build after http://trac.webkit.org/changeset/48701
https://bugs.webkit.org/show_bug.cgi?id=29713

Got rid of isWindowEvent in function signatures:

bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::getReceiverObject):
bindings/v8/V8AbstractEventListener.h:
bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::callListenerFunction):
bindings/v8/V8LazyEventListener.h:
bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): (WebCore::V8WorkerContextEventListener::callListenerFunction): (WebCore::V8WorkerContextEventListener::getReceiverObject):
bindings/v8/V8WorkerContextEventListener.h:
bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::callListenerFunction):
bindings/v8/custom/V8CustomEventListener.h:

Switched to EventTarget methods of adding/removing listeners:

bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: (WebCore::toEventID): (WebCore::ACCESSOR_SETTER):

dom/EventTarget.h: Some functions were incorrectly marked as JSC-specific.

5:54 AM Changeset in webkit [48719] by xan@webkit.org

4 edits in trunk/WebKit/gtk

2009-09-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.
[GTK] Add WEBKIT_LOAD_ERROR status
https://bugs.webkit.org/show_bug.cgi?id=29644

Add a new load-status enum value, WEBKIT_LOAD_FAILED, emitted when
there's an error during the load process. This is needed if we
want notify::load-status to be able to handle all situations,
since WEBKIT_LOAD_FINISHED is not emitted when there's an error
and we are lacking a notification of the load being stopped.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
tests/testloading.c: (web_loading_fixture_setup): (load_error_status_changed_cb): (load_error_cb): (test_loading_error): (load_cancelled_cb): (stop_load): (load_cancelled_status_changed_cb): (test_loading_cancelled): (main):
webkit/webkitwebframe.h:

5:00 AM Changeset in webkit [48718] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-09-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Color-code watch expression errors with red.

https://bugs.webkit.org/show_bug.cgi?id=29707

inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.update):
inspector/front-end/inspector.css:

4:57 AM Changeset in webkit [48717] by pfeldman@chromium.org

5 edits in trunk/WebCore

2009-09-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fix formatting for messages derived from resource warnings,
couple of drive-by formatting fixes.

https://bugs.webkit.org/show_bug.cgi?id=29705

inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole):
inspector/front-end/ConsoleView.js:
inspector/front-end/InjectedScript.js: (InjectedScript._evaluateAndWrap):
inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):

4:45 AM Changeset in webkit [48716] by pfeldman@chromium.org

5 edits in trunk/WebCore

2009-09-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Implement InspectorController::copyNode(id).

https://bugs.webkit.org/show_bug.cgi?id=28357

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::copyNode):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.handleCopyEvent):

3:55 AM Changeset in webkit [48715] by oliver@apple.com

8 edits in trunk

Roll out r48712 as it is incorrect.

Reviewed by NOBODY(rollout)

3:52 AM Changeset in webkit [48714] by xan@webkit.org

6 edits in trunk

Revert r48697, since it broke key handling notification to GTK+.

3:49 AM Changeset in webkit [48713] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] GStreamer MediaPlayer is unable to correctly querry duration
https://bugs.webkit.org/show_bug.cgi?id=24639

check duration returned by gst_element_query_duration() only
when using GStreamer < 0.10.23.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):

3:42 AM Changeset in webkit [48712] by eric@webkit.org

8 edits in trunk

2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

The indices of RuntimeArray should be enumerated like for a regular array.
https://bugs.webkit.org/show_bug.cgi?id=29005

platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
platform/mac/fast/dom/wrapper-classes-objc.html:

2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

The indices of RuntimeArray should be enumerated like for a regular array.
https://bugs.webkit.org/show_bug.cgi?id=29005

bridge/runtime_array.cpp: (JSC::RuntimeArray::getPropertyNames):
bridge/runtime_array.h:

2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=29005
The indices of RuntimeArray should be enumerated like for a regular array.

DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController arrayOfString]):

3:12 AM Changeset in webkit [48711] by Simon Hausmann

2 edits in trunk/JavaScriptCore

On Windows JSChar is typedef'ed to wchar_t.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-24
Reviewed by Simon Hausmann.

When building with WINSCW for Symbian we need to do the
same typedef.

API/JSStringRef.h:

2:38 AM Changeset in webkit [48710] by pfeldman@chromium.org

12 edits in trunk/WebCore

2009-09-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Eric Seidel.

Introduce Pasteboard::writePlaintext(const String&) so that copying
of the inspected elements HTML will be possible in WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=29634

platform/Pasteboard.h:
platform/android/TemporaryLinkStubs.cpp: (Pasteboard::writePlainText):
platform/chromium/ChromiumBridge.h:
platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writePlainText):
platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writePlainText):
platform/haiku/PasteboardHaiku.cpp: (WebCore::Pasteboard::writePlainText):
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writePlainText):
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writePlainText):
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText):
platform/wince/PasteboardWince.cpp: (WebCore::Pasteboard::writePlainText):
platform/wx/PasteboardWx.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):

1:11 AM Changeset in webkit [48709] by Simon Hausmann