⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 27, 2009:

9:49 PM WebKit Team edited by hamaji@chromium.org
(diff)
4:59 PM Changeset in webkit [48806] by weinig@apple.com
  • 8 edits
    6 moves
    6 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=29760
Implement CSSOM Range.getClientRects/getBoundingClientRect

Reviewed by Dan Bernstein.

Tests: fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html

fast/dom/Range/getBoundingClientRect.html
fast/dom/Range/getClientRects.html

  • dom/Range.cpp:

(WebCore::Range::getClientRects):
(WebCore::Range::getBoundingClientRect):
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoom):
(WebCore::Range::getBorderAndTextQuads):

  • dom/Range.h:
  • dom/Range.idl:

Implement Range.getClientRects/getBoundingClientRect.

  • dom/Element.cpp:
  • rendering/RenderObject.h:

(WebCore::adjustForAbsoluteZoom):
(WebCore::adjustIntRectForAbsoluteZoom):
(WebCore::adjustFloatPointForAbsoluteZoom):
(WebCore::adjustFloatQuadForAbsoluteZoom):
Move point/quad adjustment methods from Element.cpp to RenderObject.h
so that Range.cpp can use them as well.

LayoutTests: Tests for ​https://bugs.webkit.org/show_bug.cgi?id=29760
Implement CSSOM Range.getClientRects/getBoundingClientRect

Reviewed by Dan Bernstein.

  • fast/dom/Element/getBoundingClientRect-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-expected.txt.
  • fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt.
  • fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport.html: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html.
  • fast/dom/Element/getBoundingClientRect.html: Copied from LayoutTests/fast/dom/getBoundingClientRect.html.
  • fast/dom/Element/getClientRects-expected.txt: Copied from LayoutTests/fast/dom/getClientRects-expected.txt.
  • fast/dom/Element/getClientRects.html: Copied from LayoutTests/fast/dom/getClientRects.html.
  • fast/dom/Range/getBoundingClientRect-expected.txt: Added.
  • fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Added.
  • fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html: Added.
  • fast/dom/Range/getBoundingClientRect.html: Added.
  • fast/dom/Range/getClientRects-expected.txt: Added.
  • fast/dom/Range/getClientRects.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/getBoundingClientRect-expected.txt: Removed.
  • fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Removed.
  • fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html: Removed.
  • fast/dom/getBoundingClientRect.html: Removed.
  • fast/dom/getClientRects-expected.txt: Removed.
  • fast/dom/getClientRects.html: Removed.
2:33 PM Changeset in webkit [48805] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-09-27 Joe Ligman <​joseph.ligman@mindspring.com>

Reviewed by Simon Hausmann.

[Qt] Adding API setFocus and hasFocus to QWebElement. This API is needed for
clients that want to check/set the focus node of the document.
​https://bugs.webkit.org/show_bug.cgi?id=29682

  • Api/qwebelement.cpp: (QWebElement::hasFocus): (QWebElement::setFocus):
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::hasSetFocus):
2:32 PM Changeset in webkit [48804] by Simon Hausmann
  • 2 edits in trunk/WebCore

Unreviewed fix for WebInspector with Qt build.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-27
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

  • inspector/front-end/WebKit.qrc:
12:45 PM Changeset in webkit [48803] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-09-27 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Darin Adler.

run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
​https://bugs.webkit.org/show_bug.cgi?id=29771

  • Scripts/run-webkit-tests:
12:17 PM BuildingGtk edited by kov@webkit.org
(diff)
12:12 PM Changeset in webkit [48802] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-09-27 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Remove tests that are passing from the Skipped list after implementing
the waitForPolicyDelegate() function in LayoutTestController.
​https://bugs.webkit.org/show_bug.cgi?id=25037

  • platform/qt/Skipped:
12:05 PM Changeset in webkit [48801] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2009-09-27 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement layoutTestController.waitForPolicyDelegate.
​https://bugs.webkit.org/show_bug.cgi?id=25037

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::acceptNavigationRequest):
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::notifyDone): (LayoutTestController::waitForPolicyDelegate):
  • DumpRenderTree/qt/jsobjects.h: (LayoutTestController::waitForPolicy):
2:44 AM Changeset in webkit [48800] by pfeldman@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

2009-09-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by nobody (trivial ChangeLog fix).

Restore WebCore/ChangeLog truncated in r48778.

2:19 AM Changeset in webkit [48799] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-09-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: DOM store is being unbound twice, leading to assertion failure.

​https://bugs.webkit.org/show_bug.cgi?id=29770

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage):
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::unbind):
2:14 AM Changeset in webkit [48798] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2009-09-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not track DOM changes while inspector window is closed.

​https://bugs.webkit.org/show_bug.cgi?id=29769

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
  • inspector/InspectorDOMAgent.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable):
  • page/android/InspectorControllerAndroid.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
12:08 AM Changeset in webkit [48797] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-09-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] Double Clicking Resources Fails to Open in New Window

​https://bugs.webkit.org/show_bug.cgi?id=29762

  • inspector/front-end/InjectedScript.js: (InjectedScript.setStyleText): (InjectedScript.openInInspectedWindow):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):

Sep 26, 2009:

8:15 PM Changeset in webkit [48796] by ddkilzer@apple.com
  • 2 edits in trunk

GTK BUILD FIX: add ENABLE_ORIENTATION_EVENTS support to configure.ac

  • configure.ac: Added support for ENABLE_ORIENTATION_EVENTS.
8:02 PM Changeset in webkit [48795] by ddkilzer@apple.com
  • 6 edits in trunk

Part 2 of 2: <​http://webkit.org/b/29753> DerivedSources.make broken for non-Mac targets

Reviewed by Darin Adler.

Fix ENABLE_ORIENTATION_EVENTS for non-Mac platforms.

WebCore:

  • DerivedSources.make: Moved Platform.h check for ENABLE_ORIENTATION_EVENTS into Mac-only section and added default of ENABLE_ORIENTATION_EVENTS = 0 to non-Mac section. Added ifndef test to make it possible to override both ENABLE_DASHBOARD_SUPPORT and ENABLE_ORIENTATION_EVENTS external to the makefile. Moved addition of ENABLE_ORIENTATION_EVENTS to ADDITIONAL_IDL_DEFINES to common section.
  • GNUmakefile.am: Added support for ENABLE_ORIENTATION_EVENTS if it is ever used.
  • WebCore.pro: Ditto.

WebKit:

  • chromium/features.gypi: Added 'ENABLE_ORIENTATION_EVENTS=0' to disable this feature by default.
4:14 PM Changeset in webkit [48794] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools
<​http://webkit.org/b/29764> mark-bug-fixed: add -oopen switch

Reviewed by Eric Seidel.

The -oopen switch uses the open(1) command on Mac OS X to

open the bug URL in the default web browser. If there are
similar mechanisms on other platforms, they may be added later.

  • Scripts/mark-bug-fixed:
(MarkBugFixed.init): Added -oopen switch to list of parse

options.
(MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
code into main() and extracted prompting code into
_prompt_user_for_correctness().
(MarkBugFixed._open_bug_in_web_browser): Added.
(MarkBugFixed._prompt_user_for_correctness): Added.
(MarkBugFixed.main): Added logging code from
_determine_bug_id_and_svn_revision(). Added code to call
_open_bug_in_web_browser() if the switch is set. Added code to
call _prompt_user_for_correctness() when needed.

  • Scripts/modules/bugzilla.py: (Bugzilla.short_bug_url_for_bug_id): Added.
3:57 PM Changeset in webkit [48793] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

svn-unapply and svn-apply don't work when used outside multiple svn working directories

<​http://webkit.org/b/29744>
<rdar://problem/7252905>

Reviewed by Eric Seidel.

Some users have a workflow where svn-create-patch, svn-apply and
svn-unapply are used outside of multiple svn working
directories. Instead of aborting the scripts in these cases,
print a warning and assume that Subversion is being used.

  • Scripts/VCSUtils.pm: (determineVCSRoot): Call warn() instead of die() if both isGit() and isSVN() initially return false. Set $VCSUtils::isSVN to 1 to enforce the assumption about Subversion, then return determineSVNRoot().
  • Scripts/svn-apply: Switch to using isGit() and isSVN() from VCSUtils.pm. They both already cache their values and checking here is redundant since determineVCSRoot() is called later.
11:56 AM Changeset in webkit [48792] by eric@webkit.org
  • 18 edits in trunk/WebCore

2009-09-26 Kent Tamura <​tkent@chromium.org>

Reviewed by David Kilzer.

Move placeholder-related code to HTMLTextFormControlElement from
HTMLInputElement, WMLInputElement, InputElement, and
HTMLTextAreaElement.
​https://bugs.webkit.org/show_bug.cgi?id=28703

  • dom/InputElement.cpp: (WebCore::InputElement::dispatchFocusEvent): (WebCore::InputElement::dispatchBlurEvent): (WebCore::InputElement::setValueFromRenderer):
  • dom/InputElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): (WebCore::HTMLTextFormControlElement::~HTMLTextFormControlElement): (WebCore::HTMLTextFormControlElement::dispatchFocusEvent): (WebCore::HTMLTextFormControlElement::dispatchBlurEvent): (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): (WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
  • html/HTMLFormControlElement.h: (WebCore::HTMLTextFormControlElement::handleFocusEvent): (WebCore::HTMLTextFormControlElement::handleBlurEvent):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::handleFocusEvent): (WebCore::HTMLInputElement::handleBlurEvent): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::supportsPlaceholder): (WebCore::HTMLInputElement::isEmptyValue):
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::createRenderer):
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::supportsPlaceholder): (WebCore::HTMLTextAreaElement::isEmptyValue):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::updateFromElement):
  • rendering/RenderTextControlSingleLine.h:
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::createRenderer):
  • wml/WMLInputElement.h:
10:51 AM Changeset in webkit [48791] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2009-09-26 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
​https://bugs.webkit.org/show_bug.cgi?id=29689

Load test fonts through FontConfig before each test.
This ensures a more proper rendering of the tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): (runTest): (main):
  • DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
  • GNUmakefile.am:
8:00 AM Changeset in webkit [48790] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-09-26 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Alexey Proskuryakov.

Optimize the code so only the text from start to end is scanned.
​https://bugs.webkit.org/show_bug.cgi?id=29092

On a platform with webkit+Qt+Symbian, the parsing time for a 600K text
file improved from 400ms to 40ms (10x faster).

  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
6:12 AM Changeset in webkit [48789] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2009-09-26 Xiaomei Ji <​xji@chromium.org>

Reviewed by Eric Seidel.

This Patch fixes [chromium] the drop-down is always left-aligned even
for RTL element.
​https://bugs.webkit.org/show_bug.cgi?id=29612

For auto-complete, the items in drop-down should be right-aligned if
the directionality of <input> field is RTL.
For <select><option>, the items in drop-down should be right-aligned
if the directionality of <select> is RTL.

No automatic test is possible. Manual tests are added.

  • manual-tests/autofill_alignment.html: Added.
  • manual-tests/select_alignment.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow): Adjust the starting x-axis of text to be paint if it should be right-aligned.
5:47 AM Changeset in webkit [48788] by Simon Hausmann
  • 3 edits
    1 add in trunk/JavaScriptCore

Add MarkStackSymbian.cpp to build JavascriptCore for Symbian.

Patch by Yongjun Zhang <​yongjun.zhang@nokia.com> on 2009-09-26
Reviewed by Simon Hausmann.

Re-use Windows shrinkAllocation implementation because Symbian doesn't
support releasing part of memory region.

Use fastMalloc and fastFree to implement allocateStack and releaseStack
for Symbian port.

(JSC::MarkStack::MarkStackArray::shrinkAllocation):

  • runtime/MarkStackSymbian.cpp: Added.

(JSC::MarkStack::initializePagesize):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):

Note: See TracTimeline for information about the timeline view.