⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 3, 2009:

8:46 PM Changeset in webkit [49073] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2009-10-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

CSS Source View Should be Syntax Highlighted
​https://bugs.webkit.org/show_bug.cgi?id=14359

Support for WebKit's CSS Variables @variables and var()

  • inspector/front-end/SourceFrame.js: (WebInspector.CSSSourceSyntaxHighligher):
8:14 PM Changeset in webkit [49072] by Joseph Pecoraro
  • 3 edits in trunk/WebCore

2009-10-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Inspector should remember preferences for docked/undocked etc
​https://bugs.webkit.org/show_bug.cgi?id=29089

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleLargerResources): toggle the preference
  • inspector/front-end/inspector.js: (WebInspector._loadPreferences): factored out loading preferences (WebInspector.loaded):
7:50 PM Changeset in webkit [49071] by Joseph Pecoraro
  • 3 edits in trunk/WebCore

2009-10-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

CSS Source View Should be Syntax Highlighted
​https://bugs.webkit.org/show_bug.cgi?id=14359

Trigger the Syntax Highlighter for CSS files.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):

Factored out the Syntax Highlighting procedure into a "Class"
Added CSSSourceSyntaxHighlighter and JavaScriptSourceSyntaxHighlighter

(WebInspector.SourceSyntaxHighligher):
(WebInspector.SourceSyntaxHighligher.prototype.createSpan):
(WebInspector.SourceSyntaxHighligher.prototype.process.processChunk):
(WebInspector.SourceSyntaxHighligher.prototype.process):
(WebInspector.CSSSourceSyntaxHighligher): the CSS Highlighter
(WebInspector.JavaScriptSourceSyntaxHighligher): the JS Highlighter

5:41 PM Changeset in webkit [49070] by abarth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-03 Adam Barth <​abarth@webkit.org>

Unreview build fix. I wish I had a try server...

  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction):
5:36 PM Changeset in webkit [49069] by abarth@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-03 Adam Barth <​abarth@webkit.org>

More build fixing.

  • webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward): (webkit_web_view_can_go_back_or_forward):
5:26 PM Changeset in webkit [49068] by abarth@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-03 Adam Barth <​abarth@webkit.org>

Unreviewed build fix.

  • webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward):
5:17 PM Changeset in webkit [49067] by abarth@webkit.org
  • 12 edits in trunk

2009-10-03 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Factor back-forward list methods out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=30037

This change moves these back-forward related methods from FrameLoader
to Page. It's possible we should move these methods into some kind of
"page controller" object, but we can figure that out in a future patch.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::timerFired):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::close):
  • page/History.cpp: (WebCore::History::length):
  • page/Page.cpp: (WebCore::Page::canGoBackOrForward): (WebCore::Page::goBackOrForward): (WebCore::Page::getHistoryLength):
  • page/Page.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):

2009-10-03 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Factor PageController out of FrameLoader and Page
​https://bugs.webkit.org/show_bug.cgi?id=30037

  • webkit/webkitwebview.cpp: (webkit_web_view_can_go_back_or_forward):
1:50 PM Changeset in webkit [49066] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-03 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Remove 5 tests from the Skipped list that pass after the addition
of layoutTestController.overridePreference().

​https://bugs.webkit.org/show_bug.cgi?id=29970

  • platform/qt/Skipped:
10:01 AM Changeset in webkit [49065] by ggaren@apple.com
  • 7 edits in trunk/JavaScriptCore

Removed the concept of a "fast access cutoff" in arrays, because it
punished some patterns of array access too much, and made things too
complex for inlining in some cases.

Patch by Geoffrey Garen <​ggaren@apple.com> on 2009-10-02
Reviewed by Sam Weinig.

1.3% speedup on SunSpider.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:

(JSC::): Check m_vectorLength instead of m_fastAccessCutoff when
getting / putting from / to an array. Inline putting past the end of
the array.

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):

  • runtime/JSArray.h:

(JSC::JSArray::canGetIndex):
(JSC::JSArray::canSetIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::markChildrenDirect): Removed m_fastAccessCutoff, and
replaced with checks for JSValue() to detect reads and writes from / to
uninitialized parts of the array.

3:27 AM Changeset in webkit [49064] by pfeldman@chromium.org
  • 11 edits in trunk/WebCore

2009-10-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: prepare InspectorController for being used from layout tests.
This change adds evaluateForTestInFrontend method with the callback that
allows evaluating arbitrary code in the frontend context.

​https://bugs.webkit.org/show_bug.cgi?id=30008

  • WebCore.Inspector.exp:
  • WebCore.order:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::didEvaluateForTestInFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::evaluateForTestInFrontend):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/inspector.js: (WebInspector.evaluateForTestInFrontend):

Oct 2, 2009:

11:31 PM Changeset in webkit [49063] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Node search mode is not getting reset on element selection.

​https://bugs.webkit.org/show_bug.cgi?id=30016

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
10:24 PM Changeset in webkit [49062] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

2009-10-02 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <​https://bugs.webkit.org/show_bug.cgi?id=30036>
Should be able to resize Cookie Columns.

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.resize):
10:10 PM Changeset in webkit [49061] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows build fix.
Re-apply lost changes to auto-version.sh.

  • win/tools/scripts/auto-version.sh:
7:51 PM Changeset in webkit [49060] by jhoneycutt@apple.com
  • 12 edits in trunk/WebCore

Make WebCore::PluginView participate in plug-in halting.

Reviewed by Sam Weinig.

WebCore:

Have plug-ins opt in to automatic halting.

Reviewed by NOBODY (OOPS!).

  • platform/graphics/BitmapImage.h:

Declare a create() function that takes an HBITMAP.

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::create):
Use GetObject() to fill out a DIBSECTION structure for the given
HBITMAP. Call CGBitmapContextCreate() to create a CG context from the
bits of the bitmap. Create a CG image from the context, and pass this
when creating a new BitmapImage.

  • plugins/PluginView.cpp:

(WebCore::PluginView::start):
If we successfully started, tell our parent frame's Page.
(WebCore::PluginView::stop):
Tell our parent frame's Page that we stopped.
(WebCore::PluginView::node):

  • plugins/PluginView.h:

Inherit from HaltablePlugin.
(WebCore::PluginView::setPlatformPluginWidget):
On platforms where the platform plug-in widget is the WebCore::Widget's
platform widget, have setPlatformPluginWidget() call
setPlatformWidget().

  • plugins/PluginViewNone.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/mac/PluginViewMac.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::platformDestroy):
After destroying the window, set the platform plug-in widget to 0 to
ensure that Widget isn't holding a stale handle.
(WebCore::PluginView::halt):
Have our element's RenderWidget display a screenshot of the plug-in,
then stop the plug-in and destroy it.
(WebCore::PluginView::restart):
Clear the RenderWidget's substitute image, then start the plug-in.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::showSubstituteImage):
Set m_substituteImage to the passed image, and repaint.
(WebCore::RenderWidget::paint):
If we have a substitute image, paint that instead of allowing the
widget to paint itself.

  • rendering/RenderWidget.h:

Declare showSubstituteImage(). Added a member to store the substitute
image.

7:10 PM Changeset in webkit [49059] by abarth@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

2009-10-02 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Move PolicyCheck out of FrameLoader.{h,cpp}
​https://bugs.webkit.org/show_bug.cgi?id=30035

Purely code motion (and adding a destructor).

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/PolicyCheck.cpp:
  • loader/PolicyCheck.h:
6:47 PM Changeset in webkit [49058] by jparent@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Patch by Julie Parent <​jparent@chromium.org> on 2009-10-02
Adding myself and Ojan Vafai as committers, because we are committers.

  • Scripts/modules/committers.py:
5:47 PM Changeset in webkit [49057] by mrowe@apple.com
  • 5 edits in trunk/WebKit/mac

Roll out r49044 as it breaks many tests.

4:35 PM Changeset in webkit [49056] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-02 Jonni Rainisto <​jonni.rainisto@nokia.com>

Reviewed by Darin Adler.

Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined
​https://bugs.webkit.org/show_bug.cgi?id=29956

  • wtf/RandomNumber.cpp: (WTF::randomNumber): Added PLATFORM(WIN_OS) to handle 15bit rand()
4:27 PM Changeset in webkit [49055] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-02 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Update pixel test image for fast/table/vertical-align-baseline.html.

Expected render tree dump for this test was modified in r40146
<​http://trac.webkit.org/changeset/40146>, but the image was not updated with it.

  • platform/mac/fast/table/vertical-align-baseline-expected.checksum:
  • platform/mac/fast/table/vertical-align-baseline-expected.png:
4:20 PM Changeset in webkit [49054] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Add NPNVToolkit value quirk in plugins for nspluginwrapper.
Plugin error message was:
ERROR: failed to initialize brower-side RPC events listener
​https://bugs.webkit.org/show_bug.cgi?id=25053

(WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
(WebCore::PluginPackage::load):

4:12 PM Changeset in webkit [49053] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] X sync our XEmbed container window creation before sending the
xid to plugins.
​https://bugs.webkit.org/show_bug.cgi?id=25053

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
4:02 PM Changeset in webkit [49052] by Simon Fraser
  • 4 edits
    4 adds in trunk

2009-10-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Setting zero size on a container of a video element doesn't hide the controller
​https://bugs.webkit.org/show_bug.cgi?id=30031

Fix a logic error in enclosingCompositingLayer() when mixing normal flow and
positioned layers. This resulted in enclosingCompositingLayer() giving back a different
answer to the logic used to actually parent compositing layers, so layer positions
and layer hierarchy would be out of agreement.

Test: compositing/geometry/clipped-video-controller.html

  • rendering/RenderLayer.cpp: (WebCore::compositingContainer): (WebCore::RenderLayer::enclosingCompositingLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::setCompositingParent):
3:49 PM Changeset in webkit [49051] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-10-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

  • Move the following methods of HTMLInputElement and HTMLTextAreaElement to HTMLTextFormControlElement.

setSelectionStart()
setSelectionEnd()
select()
setSelectionRange()
selectionStart()
selectionEnd()
selection()

  • Introduce cachedSelectionStart() and cachedSelectionEnd().
  • Unify HTMLInputElement::isTextFieldWithRenderer() and HTMLTextAreaElement::rendererAfterUpdateLayout() into textRendererAfterUpdateLayout().
  • Unify a part of parseMappedAttribute() of HTMLInputElement and HTMLTextAreaElement.

​https://bugs.webkit.org/show_bug.cgi?id=29782

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::textRendererAfterUpdateLayout): (WebCore::HTMLTextFormControlElement::setSelectionStart): (WebCore::HTMLTextFormControlElement::setSelectionEnd): (WebCore::HTMLTextFormControlElement::select): (WebCore::HTMLTextFormControlElement::setSelectionRange): (WebCore::HTMLTextFormControlElement::selectionStart): (WebCore::HTMLTextFormControlElement::selectionEnd): (WebCore::HTMLTextFormControlElement::selection): (WebCore::HTMLTextFormControlElement::parseMappedAttribute):
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::cachedSelectionStart): (WebCore::HTMLInputElement::cachedSelectionEnd):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cachedSelectionStart): (WebCore::HTMLTextAreaElement::cachedSelectionEnd):
3:40 PM Changeset in webkit [49050] by eric@webkit.org
  • 14 edits in trunk/WebCore

2009-10-02 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Disconnect event listeners on navigation.
Fixes ​http://crbug.com/23597.
​https://bugs.webkit.org/show_bug.cgi?id=30027

Added V8ListenerGuard that is shared by listeners and proxy. On
navigation proxy sets a flag in the guard turning off listeners.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener):
  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8ListenerGuard::create): (WebCore::V8ListenerGuard::isDisconnected): (WebCore::V8ListenerGuard::disconnectListeners): (WebCore::V8ListenerGuard::V8ListenerGuard): (WebCore::V8AbstractEventListener::disconnected):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener):
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::disconnectFrame): (WebCore::V8Proxy::disconnectEventListeners): (WebCore::V8Proxy::clearForNavigation):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::listenerGuard):
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
  • bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
  • bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create):
3:33 PM Changeset in webkit [49049] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Fix WebGL build after CustomGetter constructor changes
​https://bugs.webkit.org/show_bug.cgi?id=30020

  • page/DOMWindow.idl: Changed CustomGetter to JSCCustomGetter for CanvasArray constructors.
3:23 PM Changeset in webkit [49048] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: text in a "Request Payload" section disappears on selection
​https://bugs.webkit.org/show_bug.cgi?id=29967

No new tests.

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestPayload):
3:15 PM Changeset in webkit [49047] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-10-02 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

Test that having infinite recursion in XMLHttpRequest event handler does not crash.
​https://bugs.webkit.org/show_bug.cgi?id=29974

  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html: Added.

2009-10-02 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Recursion guard for V8Proxy::callFunction.
Fixes ​http://crbug.com/23278.
​https://bugs.webkit.org/show_bug.cgi?id=29974

Test: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
2:59 PM Changeset in webkit [49046] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Clean up the QNetworkReplyHandler to only apply HTTP headers
for protocols in the HTTP family.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2:55 PM Changeset in webkit [49045] by Nate Chapin
  • 2 edits
    1 delete in trunk/LayoutTests

2009-10-02 Victor Wang <​victorw@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=29619

Patch ​http://trac.webkit.org/changeset/35290 adds win support for
JPEG and GIF for toDataURL encoding canvases and the test was
rewritten to not output the encoded image data, it should pass
on Win now.

  • platform/win/Skipped:
  • platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.
2:53 PM Changeset in webkit [49044] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

WebKit side of <rdar://problem/7179166>

Reviewed by Kevin Decker and Dan Bernstein.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:

Add an m_pluginIsWaitingForDraw member variable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.

(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.

(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.

  • Plugins/Hosted/WebKitPluginHost.defs:

Add PHPluginInstanceDidDraw.

2:49 PM Changeset in webkit [49043] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-02 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Jon Honeycutt.

Fix test breakages by adding null checks, and putting inspector code in
ENABLE(INSPECTOR).

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
2:39 PM Changeset in webkit [49042] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Move error check into sendResponseIfNeeded() as suggested
by Eric Seidel. Also, remove some dead code.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2:34 PM Changeset in webkit [49041] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
<rdar://problem/7148712>
​https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <​enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

Test: editing/selection/replace-selection-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Handle properly the case of
the destination position matching the end of the paragraph to move.

LayoutTests: Added test case.
<rdar://problem/7148712> Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
​https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <​enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

  • editing/selection/replace-selection-crash-expected.txt: Added.
  • editing/selection/replace-selection-crash.html: Added.
2:15 PM Changeset in webkit [49040] by jorlow@chromium.org
  • 13 edits
    3 adds in trunk

2009-10-02 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Implement per-storage-area quotas for LocalStorage
​https://bugs.webkit.org/show_bug.cgi?id=29991

I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.

I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)

Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).

Test: storage/domstorage/localstorage/quota.html

  • page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLocalStorageQuota):
  • page/Settings.h: (WebCore::Settings::localStorageQuota):
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::clear):
  • storage/StorageAreaImpl.h:
  • storage/StorageMap.cpp: (WebCore::StorageMap::create): (WebCore::StorageMap::StorageMap): (WebCore::StorageMap::copy): (WebCore::StorageMap::setItem): (WebCore::StorageMap::removeItem): (WebCore::StorageMap::importItem):
  • storage/StorageMap.h: (WebCore::StorageMap::quota):
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace):
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea):
  • storage/StorageNamespaceImpl.h:

2009-10-02 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Implement per-storage-area quotas for LocalStorage
​https://bugs.webkit.org/show_bug.cgi?id=29991

I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.

I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)

Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).

  • storage/domstorage/localstorage/quota-expected.txt: Added.
  • storage/domstorage/localstorage/quota.html: Added.
  • storage/domstorage/script-tests/quota.js: Added. (runTest):
1:09 PM Changeset in webkit [49039] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2009-10-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Database Inspector crashes Safari when table has more than 21 columns
​https://bugs.webkit.org/show_bug.cgi?id=29924

  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns.
1:07 PM Changeset in webkit [49038] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Fix Windows bustage.

1:07 PM Changeset in webkit [49037] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Fix Windows bustage.

1:01 PM Changeset in webkit [49036] by bweinstein@apple.com
  • 11 edits in trunk/WebCore

2009-10-02 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <​http://webkit.org/b/14370>.
Inspector's timeline should record when certain DOM events fired.


This patch adds calls into the Web Inspector when the main frame
fires an load event, and when the document fires its DOMContent
event. Once these values are passed in, they are sent to the Web Inspector
as a timing change, and these are denoted by vertical lines in the resources
panel (blue for DOM Content, red for load event).

  • English.lproj/localizedStrings.js: Added tooltip text.
  • dom/Document.cpp: (WebCore::Document::finishedParsing): Added an Inspector callback for DOM Content.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): Tell the main resource it got the event. (WebCore::InspectorController::mainResourceFiredLoadEvent): Ditto.
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): Added new variables. (WebCore::InspectorResource::updateScriptObject): Send new variables to inspector.js. (WebCore::InspectorResource::markDOMContentEventTime): Send a TimingChange event. (WebCore::InspectorResource::markLoadEventTime): Ditto.
  • inspector/InspectorResource.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.get mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Draw dividers for event timings. (WebInspector.ResourceTimeCalculator.prototype.computePercentageFromEventTime):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Add an Inspector callback for the Load event.
1:00 PM Changeset in webkit [49035] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Fix Windows bustage.

12:57 PM Changeset in webkit [49034] by hyatt@apple.com
  • 2 edits in trunk/WebKitTools/DumpRenderTree

Update DUmpRenderTree to account for new API.

12:42 PM Changeset in webkit [49033] by hyatt@apple.com
  • 17 edits in trunk

Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.

Reviewed by Adam Roben.

WebCore:

  • WebCore.base.exp:
  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScriptsForWorld):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):

  • page/PageGroup.h:
  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matchesPatterns):

  • page/UserContentURLPattern.h:
  • page/UserScript.h:

(WebCore::UserScript::UserScript):
(WebCore::UserScript::whitelist):
(WebCore::UserScript::blacklist):

  • page/UserStyleSheet.h:

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::whitelist):
(WebCore::UserStyleSheet::blacklist):

WebKit/mac:

  • WebView/WebView.mm:

(toStringVector):
(+[WebView _addUserScriptToGroup:source:url:worldID:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:source:url:worldID:whitelist:blacklist:]):

  • WebView/WebViewPrivate.h:

WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):

  • WebView.h:
11:41 AM Changeset in webkit [49032] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKit

2009-10-02 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Added gyp_webkit that does a subset of the things gyp_chromium does
plus some specialization for an upstream chromium build.

​https://bugs.webkit.org/show_bug.cgi?id=29986

  • chromium/DEPS: Points to gyp_webkit instead of gyp_chromium.
  • chromium/gyp_webkit: A new python file.
11:08 AM Changeset in webkit [49031] by eric.carlson@apple.com
  • 2 edits in trunk/WebKitLibraries

2009-10-02 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

<rdar://problem/7271334>
Rename MediaControllerThemeQT to MediaControllerThemeQuickTime

  • WebKitSystemInterface.h: MediaControllerThemeQT -> MediaControllerThemeQuickTime
11:06 AM Changeset in webkit [49030] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

Rolled back in r49004 with the debug 64bit build fixed

11:02 AM Changeset in webkit [49029] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Build fix when SVG is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=30011

Move TextRenderingMode related functions out from
the ENABLE(SVG) guard.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator TextRenderingMode):
10:57 AM Changeset in webkit [49028] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

2009-10-02 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Adam Roben.

svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
this will help the patch merging process when TryBots are used.

  • Scripts/svn-create-patch:
10:49 AM Changeset in webkit [49027] by cmarrin@apple.com
  • 3 edits
    2 adds in trunk

WebGL crashes with recent CanvasArray change
​https://bugs.webkit.org/show_bug.cgi?id=30018

10:22 AM Changeset in webkit [49026] by sfalken@apple.com
  • 8 edits
    1 delete in trunk

<​https://bugs.webkit.org/show_bug.cgi?id=29989>
Safari version number shouldn't be exposed in WebKit code

Reviewed by Mark Rowe.

For a WebKit version of 532.3.4:
Product version is: 5.32.3.4 (was 4.0.3.0)
File version is: 5.32.3.4 (was 4.532.3.4)

JavaScriptCore:

WebCore:

  • WebCore.vcproj/QTMovieWin.rc:

WebKit/win:

  • WebKit.vcproj/WebKit.rc:

WebKitLibraries:

  • win/tools/scripts/PRODUCTVERSION: Removed.
  • win/tools/scripts/auto-version.sh: Re-worked script to remove references to PRODUCTVERSION.
10:19 AM Changeset in webkit [49025] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

Enable two point radial gradients in Chromium/Skia.

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=30017

Covered by the following tests:

LayoutTests/svg/W3C-SVG-1.1/pservers-grad-13-b.svg
LayoutTests/fast/backgrounds/svg-as-background-3.html
LayoutTests/fast/gradients/generated-gradients.html
LayoutTests/fast/gradients/simple-gradients.html

  • platform/graphics/skia/GradientSkia.cpp:

(WebCore::Gradient::platformGradient):

9:14 AM Changeset in webkit [49024] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-10-02 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement layoutTestController.overridePreference().
​https://bugs.webkit.org/show_bug.cgi?id=29970

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::overridePreference):
  • DumpRenderTree/qt/jsobjects.h:
8:49 AM Changeset in webkit [49023] by Laszlo Gombos
  • 5 edits in trunk

2009-10-02 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.

  • Api/qgraphicswebview.cpp:
  • Api/qwebview.cpp:

2009-10-02 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.

No new tests.

  • platform/qt/QWebPageClient.h:
8:40 AM Changeset in webkit [49022] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fix the Qt on Mac OS X build.

Rubber-stamped by Simon Hausmann.

  • wtf/FastMalloc.cpp:
5:05 AM QtBackLog edited by zecke@selfish.org
(diff)
5:04 AM QtBackLog edited by zecke@selfish.org
(diff)
4:32 AM Changeset in webkit [49021] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] missing support for anamorphic PAR video size
​https://bugs.webkit.org/show_bug.cgi?id=29717

cleanup of caps handling in the video sink

  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_set_caps):
4:18 AM Changeset in webkit [49020] by Simon Hausmann
  • 34 edits in trunk

.: Disable a few more harmless MSVC warnings.

Patch by Prasanth Ullattil <​prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

  • WebKit.pri:

WebCore: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <​prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

  • bridge/qt/qt_class.h:
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

  • dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::initializeParserContext):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::getCachedFontPlatformData):

  • platform/graphics/qt/FontFallbackListQt.cpp:

(WebCore::FontFallbackList::setPlatformFont):

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::offsetForPositionForComplexText):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setURLForRect):

  • platform/graphics/qt/IconQt.cpp:

(WebCore::Icon::createIconForFiles):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::frameBufferAtIndex):

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::setEndTime):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::containsCharacters):

  • platform/graphics/qt/StillImageQt.h:

(WebCore::StillImage::destroyDecodedData):

  • platform/network/qt/DnsPrefetchHelper.h:

(WebCore::DnsPrefetchHelper::lookedUp):

  • platform/qt/ContextMenuQt.cpp:

(WebCore::ContextMenu::setPlatformDescription):

  • platform/qt/DragDataQt.cpp:

(WebCore::DragData::asURL):

  • platform/qt/PopupMenuQt.cpp:

(WebCore::PopupMenu::populate):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::supportsFocusRing):
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMediaSeekBackButton):
(WebCore::RenderThemeQt::paintMediaSeekForwardButton):

  • platform/qt/ScrollViewQt.cpp:

(WebCore::ScrollView::platformAddChild):

  • platform/qt/SearchPopupMenuQt.cpp:

(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):

  • platform/qt/TemporaryLinkStubs.cpp:

(WebCore::signedPublicKeyAndChallengeString):

  • platform/qt/WidgetQt.cpp:

(WebCore::Widget::paint):

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::setParentStyleSheet):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):
(WebCore::XSLTProcessor::transformToString):

WebKit/qt: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <​prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

  • Api/qwebframe.cpp:

(QWebFrame::scrollBarMinimum):

  • Api/qwebpage.cpp:

(QWebPagePrivate::focusInEvent):
(QWebPagePrivate::focusOutEvent):
(QWebPagePrivate::leaveEvent):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::triggerAction):
(QWebPage::acceptNavigationRequest):
(QWebPage::chooseFile):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::mouseDidMoveOverElement):
(WebCore::ChromeClientQt::reachedMaxAppCacheSize):

  • WebCoreSupport/ContextMenuClientQt.cpp:

(WebCore::ContextMenuClientQt::downloadURL):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
(WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientQt::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::setAttachedWindowHeight):
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::removeSetting):

4:14 AM Changeset in webkit [49019] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-02 Ben Murdoch <​benm@google.com>

Reviewed by David Kilzer.

Stale database version persists through browser refresh (changeVersion doesn't work)
​https://bugs.webkit.org/show_bug.cgi?id=27836

Scale the cairo surface of the video sink depending on the
pixel-aspect-ratio of the video buffer to paint. Also
destruct/re-create the surface when setSize() is called with a new
size.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::setSize): (WebCore::MediaPlayerPrivate::paint):
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
3:19 AM Changeset in webkit [49018] by benm@google.com
  • 4 edits
    4 adds in trunk

Stale database version persists through browser refresh (changeVersion doesn't work)
​https://bugs.webkit.org/show_bug.cgi?id=27836

WebCore:

Reviewed by David Kilzer.

Tests: storage/change-version-handle-reuse.html

storage/change-version.html

  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL): Implement the V8 binding for database.changeVersion().
(WebCore::createTransaction): Fix a bug that was checking the wrong argument index to save the success callback.

  • storage/Database.cpp:

(WebCore::updateGuidVersionMap): Safely update the Guid/version hash map.
(WebCore::Database::~Database): Remove code that removes the database from the guid->database and guid->version maps.
(WebCore::Database::setVersionInDatabase): Add a comment to explain some behaviour.
(WebCore::Database::close): Move the code that updates the maps from the destructor to here.
(WebCore::Database::performOpenAndVerify): Call updateGuidVersionMap instead of setting the hash map directly.
(WebCore::Database::setExpectedVersion): Update the in memory guid->version map when we want to update the database version.

LayoutTests:

Reviewed by David Kilzer.

  • storage/change-version-expected.txt: Added.
  • storage/change-version-handle-reuse-expected.txt: Added.
  • storage/change-version-handle-reuse.html: Added.
  • storage/change-version.html: Added.
1:34 AM Changeset in webkit [49017] by Simon Hausmann
  • 2 edits in trunk/WebCore

Partial WINSCW build fix.

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Add parentheses around the function pointer declaration, similar to the
second hunk in r48825.

  • loader/CachedResourceHandle.h:
1:22 AM Changeset in webkit [49016] by Simon Hausmann
  • 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

Roll out accidential r49015 commit

1:21 AM Changeset in webkit [49015] by Simon Hausmann
  • 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

use wtf/unicode/qt4/unicodeQt4.h for RVCT and WINSCW

Relative includes don't work properly with WINSCW

1:20 AM Changeset in webkit [49014] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Adam Barth <​abarth@webkit.org>

Unreviewed attempted build fix by Xcode magic.

  • WebCore.xcodeproj/project.pbxproj:
1:03 AM Changeset in webkit [49013] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-10-02 Adam Barth <​abarth@webkit.org>

Unreviewed build fix. Actually add the new files.

  • loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
  • loader/RedirectScheduler.h: Added.
12:57 AM Changeset in webkit [49012] by abarth@webkit.org
  • 9 edits in trunk/WebCore

2009-10-01 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Move RedirectScheduler to its own file
​https://bugs.webkit.org/show_bug.cgi?id=29952

This change is purely code motion.

No behavior change.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
  • loader/RedirectScheduler.h: Added.
12:41 AM Changeset in webkit [49011] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-02 Dave MacLachlan <​dmaclach@gmail.com>

Reviewed by David Levin.

Clean up warnings in WebCore/bindings/v8/npruntime.cpp
​https://bugs.webkit.org/show_bug.cgi?id=29971

Gets rid of warnings on gcc about using anonymous namespaces

warning: 'StringKeyHashTraits' has a base
'WTF::GenericHashTraits<<unnamed>::StringKey>'
whose type uses the anonymous namespace

and

warning: 'WTF::PairHashTraits<StringKeyHashTraits,
WTF::HashTraits<PrivateIdentifier*> >' has a base
'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
PrivateIdentifier*> >' whose type uses the anonymous namespace

No tests required.

  • bindings/v8/npruntime.cpp:
12:31 AM Changeset in webkit [49010] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Allow enabling and disabling of the JIT through a qmake variable.

Patch by Jørgen Lind <​jorgen.lind@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Qt's configure may set this variable through .qmake.cache if a
commandline option is given and/or the compile test for hwcap.h
failed/succeeded.

Note: See TracTimeline for information about the timeline view.