⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 4, 2009:

10:27 PM Changeset in webkit [49082] by bweinstein@apple.com
  • 7 edits
    1 add in trunk/WebCore

2009-10-04 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.


Fixes <https://bugs.webkit.org/show_bug.cgi?id=30064>
Syntax Highlighting CSS shouldn't be duplicated.

Refactor syntax highlighting CSS into a new file, add it to the
projects, and have SourceFrame.js and inspector.html include the
new CSS file.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspectorSyntaxHighlight.css: Added.
  • inspector/front-end/WebKit.qrc:
9:16 PM Changeset in webkit [49081] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-04 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.


Fixes <https://bugs.webkit.org/show_bug.cgi?id=30062>
Inspector should syntax highlight JS/CSS in elements view.

Add syntax highlighting of CSS and JavaScript tags to the elements panel.
Copied CSS rules from SourceFrame.js to inspector.css, and have the text nodes
in utilities.js call the CSS or JS Syntax highlighters if their parent is a script
or style tag.

  • inspector/front-end/inspector.css:
  • inspector/front-end/utilities.js:
7:52 PM Changeset in webkit [49080] by ukai@chromium.org
  • 4 edits in trunk

2009-10-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel

Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917

  • WebCore.gyp/WebCore.gyp:

2009-10-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel

Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917

  • chromium/features.gypi:
4:43 PM Changeset in webkit [49079] by kdecker@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Cameron Zwarich.

  • WebView/WebPreferenceKeysPrivate.h: Added new key.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Leave plug-in halting disabled by default. (-[WebPreferences pluginHalterEnabled]): Added. (-[WebPreferences setPluginHalterEnabled:]): Ditto.
  • WebView/WebPreferencesPrivate.h: Added above new methods.
2:12 PM Changeset in webkit [49078] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-04 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Levin.

check-webkit-style misses whitespace errors for operators:

<<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&,
.

https://bugs.webkit.org/show_bug.cgi?id=30021

  • Scripts/modules/cpp_style.py: Added the operators mentioned above to the same list as == and !=.
1:01 PM Changeset in webkit [49077] by xan@webkit.org
  • 5 edits
    4 adds in trunk

WebCore:

2009-10-01 Xan Lopez <xlopez@igalia.com>

Reviewed by NOBODY (OOPS!).

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.

Test: http/tests/navigation/postredirect-reload.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

LayoutTests:

2009-10-01 Xan Lopez <xlopez@igalia.com>

Reviewed by NOBODY (OOPS!).

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.

  • http/tests/navigation/postredirect-reload-expected.txt: Added.
  • http/tests/navigation/postredirect-reload.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/reloadresult.pl: Added.
  • http/tests/navigation/resources/redirect-reload.html: Added.
  • http/tests/navigation/resources/success200.html:
  • http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
11:14 AM Changeset in webkit [49076] by xan@webkit.org
  • 6 edits
    3 deletes in trunk

Revert previous patch, as the newly added test breaks other tests.

10:17 AM Changeset in webkit [49075] by xan@webkit.org
  • 6 edits
    3 adds in trunk

WebCore:

2009-10-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.

Test: http/tests/navigation/postredirect-reload.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

LayoutTests:

2009-10-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761

New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.

  • http/tests/navigation/postredirect-reload-expected.txt: Added.
  • http/tests/navigation/postredirect-reload.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/reloadresult.pl: Added.
  • http/tests/navigation/resources/success200.html:
  • http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
10:12 AM Changeset in webkit [49074] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-04 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Fixed Function leak in V8LazyEventListener.
(Should fix the remaning leak in
https://bugs.webkit.org/show_bug.cgi?id=29093).
V8LazyEventListeners used to create FunctionTemplates for each
wrapped listener which in turn created Functions that were cached
forever in V8 Context. Now there is at most one such Function per
Context.
https://bugs.webkit.org/show_bug.cgi?id=30060

Added new hidden property name to store toString result:

  • bindings/v8/V8HiddenPropertyName.cpp:
  • bindings/v8/V8HiddenPropertyName.h:

Switched to static FunctionTemplate:

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListenerToString): (WebCore::V8LazyEventListener::prepareListenerObject):

Oct 3, 2009:

8:46 PM Changeset in webkit [49073] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2009-10-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

CSS Source View Should be Syntax Highlighted
https://bugs.webkit.org/show_bug.cgi?id=14359

Support for WebKit's CSS Variables @variables and var()

  • inspector/front-end/SourceFrame.js: (WebInspector.CSSSourceSyntaxHighligher):
8:14 PM Changeset in webkit [49072] by Joseph Pecoraro
  • 3 edits in trunk/WebCore

2009-10-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Inspector should remember preferences for docked/undocked etc
https://bugs.webkit.org/show_bug.cgi?id=29089

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleLargerResources): toggle the preference
  • inspector/front-end/inspector.js: (WebInspector._loadPreferences): factored out loading preferences (WebInspector.loaded):
7:50 PM Changeset in webkit [49071] by Joseph Pecoraro
  • 3 edits in trunk/WebCore

2009-10-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

CSS Source View Should be Syntax Highlighted
https://bugs.webkit.org/show_bug.cgi?id=14359

Trigger the Syntax Highlighter for CSS files.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):

Factored out the Syntax Highlighting procedure into a "Class"
Added CSSSourceSyntaxHighlighter and JavaScriptSourceSyntaxHighlighter

(WebInspector.SourceSyntaxHighligher):
(WebInspector.SourceSyntaxHighligher.prototype.createSpan):
(WebInspector.SourceSyntaxHighligher.prototype.process.processChunk):
(WebInspector.SourceSyntaxHighligher.prototype.process):
(WebInspector.CSSSourceSyntaxHighligher): the CSS Highlighter
(WebInspector.JavaScriptSourceSyntaxHighligher): the JS Highlighter

5:41 PM Changeset in webkit [49070] by abarth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-03 Adam Barth <abarth@webkit.org>

Unreview build fix. I wish I had a try server...

  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction):
5:36 PM Changeset in webkit [49069] by abarth@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-03 Adam Barth <abarth@webkit.org>

More build fixing.

  • webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward): (webkit_web_view_can_go_back_or_forward):
5:26 PM Changeset in webkit [49068] by abarth@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-03 Adam Barth <abarth@webkit.org>

Unreviewed build fix.

  • webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward):
5:17 PM Changeset in webkit [49067] by abarth@webkit.org
  • 12 edits in trunk

2009-10-03 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Factor back-forward list methods out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30037

This change moves these back-forward related methods from FrameLoader
to Page. It's possible we should move these methods into some kind of
"page controller" object, but we can figure that out in a future patch.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::timerFired):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::close):
  • page/History.cpp: (WebCore::History::length):
  • page/Page.cpp: (WebCore::Page::canGoBackOrForward): (WebCore::Page::goBackOrForward): (WebCore::Page::getHistoryLength):
  • page/Page.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):

2009-10-03 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Factor PageController out of FrameLoader and Page
https://bugs.webkit.org/show_bug.cgi?id=30037

  • webkit/webkitwebview.cpp: (webkit_web_view_can_go_back_or_forward):
1:50 PM Changeset in webkit [49066] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-03 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Remove 5 tests from the Skipped list that pass after the addition
of layoutTestController.overridePreference().

https://bugs.webkit.org/show_bug.cgi?id=29970

  • platform/qt/Skipped:
10:01 AM Changeset in webkit [49065] by ggaren@apple.com
  • 7 edits in trunk/JavaScriptCore

Removed the concept of a "fast access cutoff" in arrays, because it
punished some patterns of array access too much, and made things too
complex for inlining in some cases.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-02
Reviewed by Sam Weinig.

1.3% speedup on SunSpider.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:

(JSC::): Check m_vectorLength instead of m_fastAccessCutoff when
getting / putting from / to an array. Inline putting past the end of
the array.

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):

  • runtime/JSArray.h:

(JSC::JSArray::canGetIndex):
(JSC::JSArray::canSetIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::markChildrenDirect): Removed m_fastAccessCutoff, and
replaced with checks for JSValue() to detect reads and writes from / to
uninitialized parts of the array.

3:27 AM Changeset in webkit [49064] by pfeldman@chromium.org
  • 11 edits in trunk/WebCore

2009-10-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: prepare InspectorController for being used from layout tests.
This change adds evaluateForTestInFrontend method with the callback that
allows evaluating arbitrary code in the frontend context.

https://bugs.webkit.org/show_bug.cgi?id=30008

  • WebCore.Inspector.exp:
  • WebCore.order:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::didEvaluateForTestInFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::evaluateForTestInFrontend):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/inspector.js: (WebInspector.evaluateForTestInFrontend):
Note: See TracTimeline for information about the timeline view.